From gitmaster at git.koha-community.org Wed Jul 5 19:06:22 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 05 Jul 2017 17:06:22 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.05.00-161-g60e55c8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 60e55c857c0e59693eaea138fbcc025f0de23960 (commit) via 69ddc094345e995aabf0b0be79813c2019419caa (commit) via adff45cd8de804cf64f73ff3fec2fe0151a9e6b5 (commit) via 57ebe9aefcfc77dbc79b671eb98e1ee997d07d4a (commit) via e5929123b9d735d8c4b14c56c134fb9f1c37b3ff (commit) via bbe22168873220d8db5ba9160df20d24f99cdf55 (commit) via ca0bde1e7e168982efc8917c5836aeedea183621 (commit) via a2be532dc244ca2e7073c4dd7693011d6aca679e (commit) via 091d6c513bcbee224ff06477e79be48cea7fe825 (commit) via c69e02c4419a2d4a7ca31af6441081cadd4e51b3 (commit) via 8f54bc6ee4f75cebb0f91a023d1e7959bc3ab503 (commit) via e14f761754b551096dbc5a1f33bb66cb493f1f27 (commit) via ad2528a1027dcc8ce55d76d76500040feecac06c (commit) via a58aca056b004dcc9c751cf29ef4e1e860b6baef (commit) via 1ef053564fdd8a037e9c276b3f2a2cdf58a2f06d (commit) via 4fe1724e306e9063243d8bda0f71d9aad091a154 (commit) via b494837c8d17a29936e2c2bcc067120c26876855 (commit) via 3d2eddaf3da3e090d00b4e5823f8f70a70c06ea1 (commit) from 905572910b3af03d86fdbd3e52c72614f41c978b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 60e55c857c0e59693eaea138fbcc025f0de23960 Author: Tomas Cohen Arazi Date: Mon Jun 26 15:25:19 2017 -0300 Bug 17554: (followup) Shibboleth check should use ->find too There was a remaining use of C4::Members::GetBorrowersWithEmail in Auth.pm. Signed-off-by: Tomas Cohen Arazi commit 69ddc094345e995aabf0b0be79813c2019419caa Author: Jonathan Druart Date: Fri Nov 4 14:43:21 2016 +0000 Bug 17554: Koha::Patrons - Remove GetBorrowersWithEmail C4::Members::GetBorrowersWithEmail can be easily replaced with Koha::Patrons->search({ email => $email }); Test plan: Confirm that you are still able to use PKI authentication Signed-off-by: Tomas Cohen Arazi commit adff45cd8de804cf64f73ff3fec2fe0151a9e6b5 Author: Marcel de Rooy Date: Fri Jun 30 12:02:00 2017 +0200 Bug 17738: [QA Follow-up] Remove second find of same patron We can just use the $patron from line 77 here. Signed-off-by: Marcel de Rooy commit 57ebe9aefcfc77dbc79b671eb98e1ee997d07d4a Author: Jonathan Druart Date: Mon Apr 17 09:00:33 2017 -0300 Bug 17738: Remove warning about redeclaration of $patron Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy commit e5929123b9d735d8c4b14c56c134fb9f1c37b3ff Author: Jonathan Druart Date: Wed Dec 7 14:43:43 2016 +0100 Bug 17738: Remove C4::Reserves::GetReservesFromBorrowernumber At this point, there should not be any occurrences of GetReservesFromBorrowernumber anymore. Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy commit bbe22168873220d8db5ba9160df20d24f99cdf55 Author: Jonathan Druart Date: Wed Dec 7 14:42:48 2016 +0100 Bug 17738: Replace GetReservesFromBorrowernumber with Koha::Patron->get_holds This patch replace the different calls to GetReservesFromBorrowernumber with a calls to Koha::Patron->get_holds. In some places we need to get a restricted set of holds, that's why we process a search on this holds returned by ->get_holds (on the found status for instance). The changes are quite trivial and reading the diff should be enough to catch bugs. Test plan: I would suggest to test this patch with patches from bug 17736 and bug 17737, to place different kind of holds (biblio and item level, future and past). Then do a whole workflow to detect bug, view a record, delete record, order, place a hold on an item which has been ordered, etc. The hold's informations should always be the same without or without these patches. Tested both patches together, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy commit ca0bde1e7e168982efc8917c5836aeedea183621 Author: Marcel de Rooy Date: Fri Jun 23 10:43:16 2017 +0200 Bug 17843: [QA Follow-up] Some polishing Resolve warning from members/summary-print.pl: "my" variable $itemtype masks earlier declaration in same scope Test if find returns a Koha object in GetDescription. Test if find returns a Koha object too in shelves.pl. While testing, I had a crash on a biblioitem with itemtype NULL (bad record, but these things tend to happen somehow.) Can't call method "imageurl" on an undefined value at virtualshelves/shelves.pl line 253. Same for opac/opac-shelves.pl. Note: Did not add tests everywhere but generally, I have the impression that we do not sufficiently test on the results of Koha::Object->find. Mostly we just assume that it will find a record. Several reports include fixes to resolve that wrong assumption. Signed-off-by: Marcel de Rooy commit a2be532dc244ca2e7073c4dd7693011d6aca679e Author: Jonathan Druart Date: Wed Jan 4 10:32:26 2017 +0100 Bug 17843: Remove C4::Koha::getitemtypeinfo At this point there should not be any calls to this subroutine. Signed-off-by: Lari Taskula Signed-off-by: Marcel de Rooy commit 091d6c513bcbee224ff06477e79be48cea7fe825 Author: Jonathan Druart Date: Wed Jan 4 10:30:47 2017 +0100 Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes The C4::Koha::getitemtypeinfo subroutine did the almost same job as GetItemTypes. On top of that it returned the imageurl value processed by C4::Koha::getitemtypeimagelocation. This value is only used from the 2 [opac-]shelves.pl scripts. Then it's better not retrieve it only when we need it. Test plan: Play with the different scripts touched by this patch and focus on item types. The same description as prior to this patch must be displayed. Note that sometimes it is not the translated description which is displayed, but that should be fixed on another bug report. Indeed we do not expect this patch to change any behaviors. Signed-off-by: Lari Taskula Signed-off-by: Marcel de Rooy commit c69e02c4419a2d4a7ca31af6441081cadd4e51b3 Author: Julian Maurice Date: Mon Jun 12 12:28:31 2017 +0200 Bug 18782: Remove unused C4::Serials::getsupplierbyserialid TEST PLAN ---------- git grep -i getsupplierby -- only the code removed and the test tweaked git bz apply 18782 sudo koha-shell -c bash kohadev prove -v t/db_dependent/Serials.t qa -v 2 c 1 exit -- sign off Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy commit 8f54bc6ee4f75cebb0f91a023d1e7959bc3ab503 Author: Nick Clemens Date: Mon Jul 3 17:01:02 2017 +0000 Bug 18228: QA Followup - use gender neutral language in new tests commit e14f761754b551096dbc5a1f33bb66cb493f1f27 Author: Jonathan Druart Date: Mon May 15 10:44:47 2017 -0300 Bug 18228: Add missing comma in kohastructure.sql Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit ad2528a1027dcc8ce55d76d76500040feecac06c Author: Marcel de Rooy Date: Wed Mar 8 16:28:59 2017 +0100 Bug 18228: Adjust Virtualshelves.t Test plan: Run t/db_dependent/Virtualshelves.t Signed-off-by: Marcel de Rooy Signed-off-by: Eric Gosselin Signed-off-by: Jesse Maseto Signed-off-by: Nick Clemens commit a58aca056b004dcc9c751cf29ef4e1e860b6baef Author: Marcel de Rooy Date: Wed Mar 8 15:31:25 2017 +0100 Bug 18228: Implement the new columns in code The two new columns as mentioned in the commit message of the table revision must be used in the codebase now. Highlighting some changes in Koha::VirtualShel[f|ves]: [1] Additional methods is_public and is_private. [2] Method add_biblio did not check permissions. Does now. No impact on the interface, but one call in the unit test was affected. [3] Method remove_biblios is signficantly simplified. Removed a FIXME. [4] Method can_biblios_be_removed now redirects to can_biblios_be_added. A followup report may deal with unifying those routines. [5] Condition in get_some_shelves changed. [6] The reference to allow_add in get_shelves_containing_record can simply be removed. opac-shelves.pl and shelves.pl now pass the default setting of Owner only to the template. Templates shelves.tt and opac-shelves.tt now include the new permission field with three choices as mentioned in the table revision patch. opac-addbybiblionumber.pl and addbybiblionumber now need a check on allow_change_from_owner; search conditions slightly adjusted to the new permission scheme. Test plan: When we refer to visibility in the test plan, please check the Add to-combo on opac search results and staff results. And check opac-addbybiblionumber by clicking Save to Lists from opac results. The step 'Check delete' means: open the list in opac and check if you see the Delete button below the entries (only check, do not delete). [ 1] Create private list I01 (perm=Owner) [ 2] Check visibility: Seen. [ 3] Add a book. (Change by owner should be allowed.) [ 4] Check delete: Yes. [ 5] Edit list I01, set perm=Nobody [ 6] Check visibility: Not seen. [ 7] Check delete: No. [ 8] Share list I01 with another patron. [ 9] Check visibility for the other patron: Not seen. [10] Check delete for the other patron: No. [11] Change permission of list I01 to Anyone (by owner). [12] Check visibility for the other patron: Seen. [13] Let other patron add a book (change is allowed). [14] Let owner delete the same book again (change allowed). [15] Create public list U01 (perm=Owner) [16] Check visibility: Seen. [17] Add a book. (Change by owner should be allowed.) [18] Login as other user. Check visibility: Not seen. Check delete: No. [19] Change permission of U01 to Nobody (by owner) [20] As owner: Check visibility: Not seen. Check delete: No. [21] As other user: Check visibility: Not seen. Check delete: No. [22] Create public list U02 (perm=Anyone) [23] Add a book by owner. [24] Delete the same book by other user. Add another book. Signed-off-by: Marcel de Rooy Signed-off-by: Jesse Maseto Signed-off-by: Nick Clemens commit 1ef053564fdd8a037e9c276b3f2a2cdf58a2f06d Author: Marcel de Rooy Date: Wed Mar 8 14:19:34 2017 +0100 Bug 18228: DBIx schema changes for Virtualshelve.pm No test plan. Signed-off-by: Marcel de Rooy Signed-off-by: Jesse Maseto Signed-off-by: Nick Clemens commit 4fe1724e306e9063243d8bda0f71d9aad091a154 Author: Marcel de Rooy Date: Wed Mar 8 14:10:32 2017 +0100 Bug 18228: Table revision of virtualshelves In order to make the permissions easier, we will replace the columns allow_add, allow_delete_own and allow_delete_other by two new columns allow_change_from_owner and allow_change_from_others. The distinction between adding or deleting an entry is no longer made. If you have change permission, you can do both. Also deleting an entry does no longer depend on who added the entry. Formerly, the owner could always add entries. It is now possible to make a list readonly. We will not use the combination of owner=no and other=yes. This will leave us three possibilities: [1] owner=no, other=no: The list is read-only. No one can change contents of the list. Naturally, the owner can edit permissions. [2] owner=yes, other=no: Only the owner can change contents. [3] owner=yes, other=yes: Anyone seeing the list can change contents. This especially applies to shared lists and public lists. The two database columns will be presented in the interface as one permission field offering the three abovementioned options. Test plan: [1] Run the db rev. Signed-off-by: Marcel de Rooy Signed-off-by: Jesse Maseto Signed-off-by: Nick Clemens commit b494837c8d17a29936e2c2bcc067120c26876855 Author: Marcel de Rooy Date: Thu Jun 22 08:55:16 2017 +0200 Bug 18214: Add check for shared or public list Following the idea behind bug 10865, we are only showing the permissions when the list is shared or public. Adding a simple test in opac-shelves here. Note 1: Since the owner can always add or delete entries, the permissions will not be relevant anymore for a strictly private list. Note 2: Staff view always shows the permissions. This could have been changed here too, but that change is far less urgent (bug 10865 did not touch staff view and bug 18228 will rearrange permissions anyway). Test plan: [1] Verify on OPAC that you see the permissions for a private list with shares or a public list. And you do not see them for a private list without shares. Signed-off-by: Marcel de Rooy commit 3d2eddaf3da3e090d00b4e5823f8f70a70c06ea1 Author: Marcel de Rooy Date: Mon Mar 6 09:44:48 2017 +0100 Bug 18214: Cannot edit list permissions of a private list If you have disabled the pref OpacAllowPublicListCreation, your users are not able to edit the list permissions for private/shared lists. For a private list they may only be theoretically relevant, but for a shared list they are relevant. Since we do not always know the history of a list (has it been public or shared, does it contains entries from other users) and therefore permissions are even relevant for a currently private list, we should just allow editing these permissions. Test plan: [1] Do not yet apply this patch. [2] Disable OpacAllowPublicListCreation. [3] Create a private list in OPAC. Edit the list. Verify that you do not see the permission combo boxes. [4] Apply this patch. Edit the list again. Do they appear now? Signed-off-by: Marcel de Rooy Signed-off-by: Magnus Enger Works as advertised. ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 16 ++-- C4/Biblio.pm | 4 +- C4/ILSDI/Services.pm | 30 ++++--- C4/Koha.pm | 40 ---------- C4/Members.pm | 36 ++------- C4/Reserves.pm | 35 --------- C4/SIP/ILS/Patron.pm | 20 +++-- C4/Serials.pm | 29 +------ Koha/Patron/Discharge.pm | 9 ++- Koha/Schema/Result/Virtualshelve.pm | 20 ++--- Koha/Template/Plugin/ItemTypes.pm | 9 +-- Koha/Virtualshelf.pm | 74 +++++++----------- Koha/Virtualshelves.pm | 12 +-- acqui/orderreceive.pl | 5 +- catalogue/getitem-ajax.pl | 5 +- circ/returns.pl | 12 +-- circ/transferstoreceive.pl | 5 +- circ/waitingreserves.pl | 5 +- installer/data/mysql/atomicupdate/bug18228.perl | 30 +++++++ installer/data/mysql/kohastructure.sql | 5 +- .../prog/en/modules/virtualshelves/shelves.tt | 35 +++------ .../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 42 ++++------ members/discharge.pl | 6 +- members/summary-print.pl | 6 +- opac/opac-addbybiblionumber.pl | 17 ++-- opac/opac-browser.pl | 1 - opac/opac-reserve.pl | 12 +-- opac/opac-search.pl | 3 +- opac/opac-shelves.pl | 28 ++++--- opac/opac-tags_subject.pl | 1 - svc/checkouts | 5 +- svc/holds | 5 +- t/db_dependent/Holds.t | 17 ++-- t/db_dependent/Koha.t | 8 +- t/db_dependent/Serials.t | 4 +- t/db_dependent/Virtualshelves.t | 82 ++++++++------------ virtualshelves/addbybiblionumber.pl | 17 ++-- virtualshelves/shelves.pl | 26 ++++--- 38 files changed, 287 insertions(+), 429 deletions(-) create mode 100644 installer/data/mysql/atomicupdate/bug18228.perl hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jul 6 20:50:02 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 06 Jul 2017 18:50:02 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.05.00-190-gd9c8eea Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d9c8eea442bbe4e30be172d547e519dcd781341d (commit) via df4a87d4a69761715791a10cbf94383af345350d (commit) via a78bb5ba1c51d995a597cb0ac7e5e9f95345ed3e (commit) via 29a1f0fd9cb98473157e72b5782cb8bbd6623a51 (commit) via 65c32eee8eef7102544a579a2a68c7ebb4a6b0bd (commit) via e29163af4cde7ce33060716091726e6fa2eef65e (commit) via 3829020c2664ec531354f78f0c04d00f5dd6795d (commit) via e3bf4fc8bb821456305d587a8d49fe39b07abd06 (commit) via 8a0ecda6c4ff368b9ff7a18593d7bdf4fc07e541 (commit) via ce176fd170227456fa725e5f1f2f6b1b04fd044d (commit) via 23b84c0b6532d9c42894b648891d835e7624db49 (commit) via e48a5fb560123bac31e9a692026601ddd320f966 (commit) via f40c093c19e21c6a8aa7a41d4e51fc4e3fc1d8e9 (commit) via b94b16f67963b03fd17170d2c2f2efa581c12c0f (commit) via ebb887e5c93c96c6fc51d95b76de6a221ba4463e (commit) via d222da0602ba96f08cc6c026f39451b0aa7de01e (commit) via 0d98089ec701bc96893e68408ce2dedad36f7235 (commit) via 83e4adf0abff0e81febf4bcee473ce9c599e8311 (commit) via aa03981e79a10bd5a032f13533d93f0b87bd37f7 (commit) via c1112236f908626b273f7dc950807ce2e085db2d (commit) via 540d488e980b2521b424bed0f0267002c6dbd03e (commit) via 241be8ff1ae24fff6165c8d6877945637467ee9a (commit) via 3b5529c3abca87afb4f66f5bc7d3aa0fe005c1aa (commit) via 9eb88f588bd13ddf25135c26acd905abe71f326a (commit) via 2d19a34529bc313922a085a99288e55d8634c8b6 (commit) via 8b15c064405ff4a48cb3f5803dd6bd16d49d5b9b (commit) via 0c09adbfc87b950b9f08aebede131ba694997290 (commit) via a81947782bb884feccd5401499f1a6e8f469b0b0 (commit) via 520d1acac832fe299408eb393daaa5e434e88927 (commit) from 60e55c857c0e59693eaea138fbcc025f0de23960 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d9c8eea442bbe4e30be172d547e519dcd781341d Author: Marcel de Rooy Date: Fri Jun 23 10:12:44 2017 +0200 Bug 18104: [QA Follow-up] Add a test for customized name in AE Test plan: Run t/db_dependent/SIP/Message.t Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit df4a87d4a69761715791a10cbf94383af345350d Author: Kyle M Hall Date: Mon Mar 6 12:05:31 2017 +0000 Bug 18104 - allow SIP2 field AE (personal name ) to be customized Koha's SIP2 server sends the patron's name in the format "Firstname Surname" which is not very good for machine reading. We need to allow the format of the patron name to be customized in a manner similar to what is done with the DA field on bug 16755. Test Plan: 1) Apply this patch, start or restart your SIP server 2) Find a patron with a first and last name 3) Send a patron information request via the sip2 cli tool 4) Note the AE field has the format " " ( i.e. the current behavior ) 5) Add this parameter to the login stanza you are using: ae_field_template="[% patron.surname %][% IF patron.firstname %], [% patron.firstname %][% END %]" 6) Restart your SIP server 7) Repeat step 3 8) Note the AE field now has the format ", " Signed-off-by: Kyle M Hall Signed-off-by: Benjamin Daeuber Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit a78bb5ba1c51d995a597cb0ac7e5e9f95345ed3e Author: Kyle M Hall Date: Thu Dec 29 14:22:04 2016 +0000 Bug 16755 - allow SIP2 field DA ( hold patron name ) to be customized The SIP2 DA field that Koha transmits is an odd and arbitrary format that some SIP2 clients cannot handle. It would be best if this format were customizable on a per-login basis in the same manner as the AV field. Test Plan: 1) Find an item that is checked out with holds 2) Return the item via SIP2 ( using the SIP2 cli emulator ) 3) Note the value of the DA field 4) Apply this patch, restart your SIP2 server 5) Repeat step 2 6) Note the DA field value has not changed 7) Add this parameter to the login stanza you are using: da_field_template="[% patron.surname %][% IF patron.firstname %], [% patron.firstname %][% END %]" 8) Restart the SIP2 server again 9) Repeat step 2 10) Note the DA field returned is now in the format "$surname, $firstname" Signed-off-by: Kyle M Hall Signed-off-by: Benjamin Daeuber Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 29a1f0fd9cb98473157e72b5782cb8bbd6623a51 Author: Marc V?ron Date: Fri Jun 23 18:48:00 2017 +0200 Bug 18465: (followup) Fix issue with patron lists an do not use clone This followup fixes duplex printing with patron lists. Additionaly, it uses simple copy instead of clone and removes a superfluous line, see comments #15 - #17 Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 65c32eee8eef7102544a579a2a68c7ebb4a6b0bd Author: Marc V?ron Date: Thu Apr 20 20:43:11 2017 +0200 Bug 18465 - Patron card creator: Print on duplex card printer Card printers with duplex functionality need as input a PDF file where odd pages contain the front side and even pages the back side of the cards. This patch adds such functionality. To prepare test: - In Patron card creator > Templates, prepare a 1 up template (1 column / 1 row) that fits to a single card. Give it a name like 'Duplex card template' (Attention, Card with and Card height seem to have wrong labels, that will go to a separate bug). - In Patron card creator > Layouts create a layout for the front side and one for the back side. Give them names to easily remember (Card front layout, Card back layout) - Go to Patron card creator > Batches and test both layouts together with the 1 up template. Save and keepp both test files as reference. To test: - Apply patch. Restart memcached and plack. - Go to Patron card creator > Batches - Click "Export" for a batch - In the following screen, note the new field "Select a layout for the back side" with a hint what it is used for - Leave it on 'Back side layout not used', export and compare output with test ooutput from preparation. It should be the same - Select the layout you prepared for the back side. - Export - this file should contain 2 PDF pages per patron, one first with the front side, second with the back side. Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit e29163af4cde7ce33060716091726e6fa2eef65e Author: David Kuhn Date: Tue Jun 6 09:38:07 2017 -0700 Bug 18616 - The "Add forgot password link to OPAC" should allow patrons to use their library card number in addition to username Allow patrons to enter either their library card number or user name in the "Log in" box for password recovery. Most patrons at our library use their card number to log in and are unaware of what their userid is. However there are some who have set a customized userid and would prefer to use that. This patch would allow either to be entered for password recovery. To test: 1. Enable the password recovery feature. 2. In the OPAC, click on "Forgot you password?" link and enter a valid library card number. 3. The error message "No account found with the provided information" appears. 4. Apply the patch. 5. Repeat step 2. The recovery email is now sent. Note: Moved patch from 16711 back here and re-tested. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 3829020c2664ec531354f78f0c04d00f5dd6795d Author: Marc V?ron Date: Sun May 21 18:28:48 2017 +0200 Bug 16711: OPAC Password recovery: Handling if multiple accounts have the same mail address To reproduce: - Create 3 Accounts, login names are test01, test02, test03, Email is the same for all. - Go to OPAC -> Password recovery and indicate E-Mail only - You will get an email for only one of the accounts above. To test: - Apply patch, restart memcached and plack - Go to db, delete from borrower_password_recovery; - Try steps above to reproduce. You will get an error message: Account identification with this email address only is ambiguous. Please use the field 'Login' as well. - Verify that other cases work as before (provide valid / invalid login only, provide valid email for an existing account, provide unknown email, provide both login and email with all combinations of valid / invalid) Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Bug 16711: (QA-followup) Use count directly See comment # 13 Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit e3bf4fc8bb821456305d587a8d49fe39b07abd06 Author: Lee Jamison Date: Thu Jun 22 16:42:15 2017 +0000 Bug 18848: borrowers.lastseen comment typo Typo in comment for the lastseen column in the borrowers table. To test: 1. Verify lastseen column displays "last time a patron has been seed" 2. Apply patch 3. Verify lastseen column changed to "last time a patron has been seen" Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 8a0ecda6c4ff368b9ff7a18593d7bdf4fc07e541 Author: Colin Campbell Date: Tue Jun 20 16:35:35 2017 +0100 Bug 18830: Fix phrasing of screen message Verb should be plural in this message Signed-off-by: Israelex A Vele?a for KohaCon17 Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit ce176fd170227456fa725e5f1f2f6b1b04fd044d Author: Marc V?ron Date: Mon Jun 19 21:23:54 2017 +0200 Bug 18824: Remove stray i from matching-rules.tt The file koha-tmpl/intranet-tmpl/prog/en/modules/admin/matching-rules.tt contains a stray i that should not be there. This patch removes it. Signed-off-by: Chris Kirby Applied patch. Checked line 516. Stray i had been removed. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 23b84c0b6532d9c42894b648891d835e7624db49 Author: Lee Jamison Date: Thu Jun 22 16:42:15 2017 +0000 Bug 18848: borrowers.lastseen comment typo Typo in comment for the lastseen column in the borrowers table. To test: 1. Verify lastseen column displays "last time a patron has been seed" 2. Apply patch 3. Verify lastseen column changed to "last time a patron has been seen" Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit e48a5fb560123bac31e9a692026601ddd320f966 Author: Marcel de Rooy Date: Mon Jul 3 09:31:52 2017 +0200 Bug 18881: [QA Follow-up] Remove even more Removing the commented section from the template: If it does not work, it should not be here. When it works again, put it back in. Since @itemtypesloop is not used, remove it from the script too. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit f40c093c19e21c6a8aa7a41d4e51fc4e3fc1d8e9 Author: Marc V?ron Date: Fri Jun 30 20:20:44 2017 +0200 Bug 18881: Remove dead code from view_holdsqueue.pl Aleisha spotted the typo in $itemtypes and proposed a correction on bug 18859. The description was not even used. Template calls GetDescription. To test: Verify that viewing the holds queue still works as expected. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit b94b16f67963b03fd17170d2c2f2efa581c12c0f Author: Rodrigo Santellan Date: Wed Jun 21 15:40:43 2017 -0300 Bug 14572 - insert_single_holiday() forces a value on an AUTO_INCREMENT column, during an INSERT Removing all the id from the columns on the inserts and removing the parameter '' of the values for the id. Test plan: 1) Go to tools -> calendar 2) Add a Holiday only on this day. 3) Add a Holiday repeated every same day of the week. 4) Add a Holiday repeated yearly on the same date. 5) Add a Holidays on a range. 6) Add a Holidays repeated yearly on a range. 7) You should have the five calendars displayed. Signed-off-by: Lee Jamison Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit ebb887e5c93c96c6fc51d95b76de6a221ba4463e Author: Colin Campbell Date: Thu Jun 8 12:59:55 2017 +0100 Bug 18755: Allow empty passwords in Patron Info to return OK With this patch a parameter 'allow_empty_passwords="1" can be added to a login in the SIP configuration file to allow the behaviour as was normal before the patch for bug 16610 was applied. Some sip clients rely on this behaviour sending an empty password field when they wish to validate to user but do not have the password. If a password is supplied it will be validated A test has been added to Message.t to confirm this behaviour Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit d222da0602ba96f08cc6c026f39451b0aa7de01e Author: Mark Tompsett Date: Fri Jun 9 13:01:14 2017 -0400 Bug 18771: CGI.pm: Subroutine multi_param redefined The commands in the test plan are examples, and may need varying depending on your installation. This was created as a result of attempting to clean the installation process up. However, I believe the redefine might exist normally too. I just didn't check. This is tested on a Debian 8 box sudo apt-get update'd fully. TEST PLAN --------- empty error log $ echo > ~/koha-dev/var/log/koha-error_log drop and recreate and empty db > drop database koha_library; > create database koha_library; > quit run the web installer, but DO NOT LOG IN! *opening chrome to Staff Client URL* check the error log $ less ~/koha-dev/var/log/koha-error_log ... [Fri Jun 09 13:08:52.793627 2017] [cgi:error] [pid 5802] [client 192.168.71.101:58169] AH01215: [Fri Jun 9 13:08:52 2017] CGI.pm: Subroutine multi_param redefined at /usr/share/perl5/CGI.pm line 419. ... apply patch empty error log $ echo > ~/koha-dev/var/log/koha-error_log refresh the installation login page recheck the error log $ less ~/koha-dev/var/log/koha-error_log notice no reference to "Subroutine multi_param redefined" run koha qa test tools Notice that it is just a require CGI; and comment added. Signed-off-by: Lee Jamison Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 0d98089ec701bc96893e68408ce2dedad36f7235 Author: Marcel de Rooy Date: Wed Jun 14 15:37:55 2017 +0200 Bug 18634: Handle colliding translation for preference sections Problem on this report was caused by translating the tabs Privacy and Payments by the same string. This caused overwriting a hash entry. This patch tests if the key already exists and if so, it merges the entries instead of overwriting the old contents. Test plan: [1] Make sure that e.g. Privacy and Payments translate to e.g Vie privee. [2] Run translate install fr-CA (or the language you altered) [3] Without this patch you should loose preferences from either Privacy or Payments. With this patch, they should be merged. Signed-off-by: Marcel de Rooy Tested with fr-CA. Signed-off-by: Blou Reset the .po files, reproduced the problem. Applied the patch and suddenly 'paypal' appeared. Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart commit 83e4adf0abff0e81febf4bcee473ce9c599e8311 Author: Jonathan Druart Date: Thu Jul 6 14:28:18 2017 -0300 Bug 18801: DBRev 17.05.00.003 commit aa03981e79a10bd5a032f13533d93f0b87bd37f7 Author: Marcel de Rooy Date: Thu Jun 15 15:47:21 2017 +0200 Bug 18801: [Follow-up] Dbrev to repair bad auth type codes Test plan Run updatedatabase. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit c1112236f908626b273f7dc950807ce2e085db2d Author: Nick Clemens Date: Wed Jun 14 09:19:10 2017 -0400 Bug 18801 - Merging authorities has an invalid 'Default' type in the merge framework selector To test: 1 - Find two authorities and start a merge 2 - Leave the dropdown at 'Default' 3 - Merge records and note you get an error and can no longer view the new record 4 - Check DB value of record authtypecode = 'Default' 5 - Apply patch 6 - Find two other authorities 7 - Merge leaving selector at default 8 - Success 9 - Check DB value of record authtypecode = '' Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 540d488e980b2521b424bed0f0267002c6dbd03e Author: Nick Clemens Date: Mon Jul 3 09:42:21 2017 +0000 Bug 18434 - Followup fix tests for sorting and factes Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 241be8ff1ae24fff6165c8d6877945637467ee9a Author: Nick Clemens Date: Fri Jun 16 10:01:12 2017 -0400 Bug 18434 - Followup - same changes for sort and facet fields To test: 1 - Index some stuff with multiple fields defined for sorting i.e. Authorites - make heading sortable - default is 110a and 111a for heading - a record with 111a empty will make the sort field empty 2 - view the record: curl http://localhost:9200/koha_kohadev_authorities/data/30?pretty=true 3 - Note the blank field 4 - Apply patch 5 - Reindex 6 - Fields should be correctly populated Unit tests to follow (once I have the originals working for all) Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 3b5529c3abca87afb4f66f5bc7d3aa0fe005c1aa Author: Tomas Cohen Arazi Date: Mon May 15 11:46:00 2017 -0300 Bug 18434: (QA followup) Move _convert_marc_to_json tests into Indexer.t Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 9eb88f588bd13ddf25135c26acd905abe71f326a Author: Nick Clemens Date: Fri Apr 14 10:03:11 2017 -0400 Bug 18434: Elasticsearch indexing broken with newer catmandu version To test: 1 - Make sure you have latest koha deps, catmandu versions should be: libcatmandu-marc-perl 1.09-1~kohadev1 libcatmandu-perl 1.0304-2~kohadev1 2 - Reindex elastic 3 - Try searching and likely notice odd results 4 - Try: curl -XGET 'http://localhost:9200/koha_kohadev_biblios/data/792?pretty=true' with a known biblionumber and notice some null fields 5 - Apply patch 6 - Reindex 7 - Note fields are populated and search works as expected Signed-off-by: Chris Cormack Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 2d19a34529bc313922a085a99288e55d8634c8b6 Author: Tomas Cohen Arazi Date: Fri May 12 15:39:25 2017 -0300 Bug 18434: Add tests for K:SE:E::get_fixer_rules This patch tries to introduce exhaustive tests for this class method. I didn't try to provide a regression test for the current bug per-se, but cover the current method behaviour as much as I could. (kidclamp) I added a quick test of _convert_marc_to_json to use the mocking here and illuminate what the change does, before the patches this should fail (fields are indexed in place of one another), after it should succeed (new indexed fields are appended). A minor bug is highlighted by this new tests, I'll provide a followup for it. To test: - Run: $ sudo koha-shell kohadev k$ de kohaclone k$ prove t/db_dependent/Koha_Elasticsearch.t => FAIL: The returned fixer rules are not the expected ones Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 8b15c064405ff4a48cb3f5803dd6bd16d49d5b9b Author: Fridolin Somers Date: Wed Jun 14 12:33:25 2017 +0200 Bug 18756 - add Unit Test Signed-off-by: Lee Jamison Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 0c09adbfc87b950b9f08aebede131ba694997290 Author: Christophe Croullebois Date: Thu Jun 8 13:17:56 2017 +0000 Bug 18756: Users can view aq.baskets even if they are not allowed Due to bad use of grep syntax if there is one or more Basket Users the result of grep is not equal to 0 and the borrower is allowed. Test plan : 1- select system preference 'AcqViewBaskets' on 'user' 2- create 2 borrowers (A, B) with only permissions on acquisition : group_manage order_manage order_receive staff 3- login with A and create a basket 4- add a basquet manager other than B 5- relog with account B 6- you can see the basket Apply the patch. The basket is no longer visible. 1- relog with A 2- add basquet manager B 3- relog with B 5- you must see the basket Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit a81947782bb884feccd5401499f1a6e8f469b0b0 Author: Jonathan Druart Date: Wed Jul 5 20:03:24 2017 -0300 Bug 18870: Force scalar context for Koha::Club methods These 2 methods are called from the template in list context. However since bug 18539 Koha::Objects->find can no longer be called in list context. Forcing the context to scalar fixes the problem and should not introduced side-effects. Test plan: - Create a club template - Create a club using this template => Without this patch you should no longer get the following error: Template process failed: undef error - Cannot use "->find" in list context at /home/vagrant/kohaclone/Koha/Club.pm line 51. Signed-off-by: Aleisha Amohia Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart commit 520d1acac832fe299408eb393daaa5e434e88927 Author: Jonathan Druart Date: Thu Jul 6 13:58:05 2017 -0300 Bug 18228: DBRev 17.05.00.002 Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: C4/Acquisition.pm | 4 +- C4/Calendar.pm | 8 +- C4/Context.pm | 1 + C4/SIP/ILS/Item.pm | 18 ++- C4/SIP/ILS/Patron.pm | 20 +++ C4/SIP/Sip/MsgType.pm | 11 +- Koha.pm | 2 +- Koha/Club.pm | 4 +- Koha/SearchEngine/Elasticsearch.pm | 6 +- circ/view_holdsqueue.pl | 14 -- etc/SIPconfig.xml | 2 + installer/data/mysql/atomicupdate/bug18228.perl | 30 ----- installer/data/mysql/kohastructure.sql | 4 +- installer/data/mysql/updatedatabase.pl | 54 ++++++++ .../prog/en/modules/acqui/invoices.tt | 2 +- .../prog/en/modules/admin/matching-rules.tt | 2 +- .../prog/en/modules/authorities/merge.tt | 1 - .../prog/en/modules/circ/view_holdsqueue.tt | 11 -- .../prog/en/modules/help/patroncards/manage.tt | 3 +- .../prog/en/modules/patroncards/print.tt | 19 ++- .../bootstrap/en/modules/opac-password-recovery.tt | 5 +- misc/translator/LangInstaller.pm | 7 +- opac/opac-password-recovery.pl | 23 +++- patroncards/create-pdf.pl | 22 +++- patroncards/print.pl | 5 + t/Acquisition/CanUserManageBasket.t | 9 +- t/db_dependent/Koha_Elasticsearch.t | 138 +++++++++++++++++++- t/db_dependent/Koha_Elasticsearch_Indexer.t | 73 ++++++++++- t/db_dependent/SIP/Message.t | 18 ++- 29 files changed, 413 insertions(+), 103 deletions(-) delete mode 100644 installer/data/mysql/atomicupdate/bug18228.perl hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 10 12:01:40 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 10 Jul 2017 10:01:40 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.01-29-gf4b6e59 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via f4b6e5963ff3511d54f1af1f66d1fb7c1e2cfb4a (commit) via 306055cd81a8f61cd25025f89bdb5e8d90a33caf (commit) from bb14ce9d657f2a30621a0a6465809cef1f820f3c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f4b6e5963ff3511d54f1af1f66d1fb7c1e2cfb4a Author: Marcel de Rooy Date: Thu Jun 22 08:55:16 2017 +0200 Bug 18214: Add check for shared or public list Following the idea behind bug 10865, we are only showing the permissions when the list is shared or public. Adding a simple test in opac-shelves here. Note 1: Since the owner can always add or delete entries, the permissions will not be relevant anymore for a strictly private list. Note 2: Staff view always shows the permissions. This could have been changed here too, but that change is far less urgent (bug 10865 did not touch staff view and bug 18228 will rearrange permissions anyway). Test plan: [1] Verify on OPAC that you see the permissions for a private list with shares or a public list. And you do not see them for a private list without shares. Signed-off-by: Marcel de Rooy (cherry picked from commit b494837c8d17a29936e2c2bcc067120c26876855) Signed-off-by: Fridolin Somers commit 306055cd81a8f61cd25025f89bdb5e8d90a33caf Author: Marcel de Rooy Date: Mon Mar 6 09:44:48 2017 +0100 Bug 18214: Cannot edit list permissions of a private list If you have disabled the pref OpacAllowPublicListCreation, your users are not able to edit the list permissions for private/shared lists. For a private list they may only be theoretically relevant, but for a shared list they are relevant. Since we do not always know the history of a list (has it been public or shared, does it contains entries from other users) and therefore permissions are even relevant for a currently private list, we should just allow editing these permissions. Test plan: [1] Do not yet apply this patch. [2] Disable OpacAllowPublicListCreation. [3] Create a private list in OPAC. Edit the list. Verify that you do not see the permission combo boxes. [4] Apply this patch. Edit the list again. Do they appear now? Signed-off-by: Marcel de Rooy Signed-off-by: Magnus Enger Works as advertised. (cherry picked from commit 3d2eddaf3da3e090d00b4e5823f8f70a70c06ea1) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 10 12:08:17 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 10 Jul 2017 10:08:17 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.01-30-g87cf7af Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via 87cf7af3cd659dad5606685f262c12450e5356ef (commit) from f4b6e5963ff3511d54f1af1f66d1fb7c1e2cfb4a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 87cf7af3cd659dad5606685f262c12450e5356ef Author: Julian Maurice Date: Mon Jun 12 12:28:31 2017 +0200 Bug 18782: Remove unused C4::Serials::getsupplierbyserialid TEST PLAN ---------- git grep -i getsupplierby -- only the code removed and the test tweaked git bz apply 18782 sudo koha-shell -c bash kohadev prove -v t/db_dependent/Serials.t qa -v 2 c 1 exit -- sign off Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy (cherry picked from commit c69e02c4419a2d4a7ca31af6441081cadd4e51b3) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: C4/Serials.pm | 29 +---------------------------- t/db_dependent/Serials.t | 4 +--- 2 files changed, 2 insertions(+), 31 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 10 12:36:44 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 10 Jul 2017 10:36:44 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.01-31-gd1de822 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via d1de8225e81b4a35c603cf7896c28fbaed55b20e (commit) from 87cf7af3cd659dad5606685f262c12450e5356ef (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d1de8225e81b4a35c603cf7896c28fbaed55b20e Author: Jonathan Druart Date: Wed Jul 5 20:03:24 2017 -0300 Bug 18870: Force scalar context for Koha::Club methods These 2 methods are called from the template in list context. However since bug 18539 Koha::Objects->find can no longer be called in list context. Forcing the context to scalar fixes the problem and should not introduced side-effects. Test plan: - Create a club template - Create a club using this template => Without this patch you should no longer get the following error: Template process failed: undef error - Cannot use "->find" in list context at /home/vagrant/kohaclone/Koha/Club.pm line 51. Signed-off-by: Aleisha Amohia Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart (cherry picked from commit a81947782bb884feccd5401499f1a6e8f469b0b0) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: Koha/Club.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 10 12:41:56 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 10 Jul 2017 10:41:56 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.01-33-g9800895 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via 9800895cabade7ad8d78ff986a9a156f3962efa2 (commit) via 40db2dcc388706b54f13db9c312ee7f181f6bd9b (commit) from d1de8225e81b4a35c603cf7896c28fbaed55b20e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9800895cabade7ad8d78ff986a9a156f3962efa2 Author: Christophe Croullebois Date: Thu Jun 8 13:17:56 2017 +0000 Bug 18756: Users can view aq.baskets even if they are not allowed Due to bad use of grep syntax if there is one or more Basket Users the result of grep is not equal to 0 and the borrower is allowed. Test plan : 1- select system preference 'AcqViewBaskets' on 'user' 2- create 2 borrowers (A, B) with only permissions on acquisition : group_manage order_manage order_receive staff 3- login with A and create a basket 4- add a basquet manager other than B 5- relog with account B 6- you can see the basket Apply the patch. The basket is no longer visible. 1- relog with A 2- add basquet manager B 3- relog with B 5- you must see the basket Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 0c09adbfc87b950b9f08aebede131ba694997290) Signed-off-by: Fridolin Somers commit 40db2dcc388706b54f13db9c312ee7f181f6bd9b Author: Fridolin Somers Date: Wed Jun 14 12:33:25 2017 +0200 Bug 18756 - add Unit Test Signed-off-by: Lee Jamison Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 8b15c064405ff4a48cb3f5803dd6bd16d49d5b9b) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: C4/Acquisition.pm | 4 ++-- t/Acquisition/CanUserManageBasket.t | 9 ++++++++- 2 files changed, 10 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 10 19:54:57 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 10 Jul 2017 17:54:57 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.05.00-220-g94513d0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 94513d0739757f0c5db4b7d1040aaae40622a60e (commit) via 9cad748de79f6b11026e3a112c2dd3dbc6c0cfc8 (commit) via 1b2435cb4a56c125022da6fabbff99cdc0473b66 (commit) via 2b90ea2cb0e5e976de7ddef0151ae83d8ac578e6 (commit) via 06c53f21dbf6258451999358e4f4fd59d3315111 (commit) via fa48e204f21e72c82b557b1ac9e4ba5859b7226e (commit) via c73e269a13f64fe016dc90941280c9d2e9cfb02c (commit) via 0c14a76049061a581c508a8abe032bbb7844fabe (commit) via 98aaa69d38eda8bf9beee3ac8dd8e5d60443eb3f (commit) via ed03edddbdb6846588ff42e967b44c190cdb019b (commit) via 2c9aeb9b0f4449d1a25274b8fbf8dae4ec11d3bf (commit) via fa467223eaedc2a6a09f0796ae57463de573d832 (commit) via eed1447a63b9e3d80fcb8171b5d2bfde3994e554 (commit) via f4ded893c56a89a24dd8ed0192350044093386bf (commit) via b977e9ec241d9f5865e5882f60518e90076b5a29 (commit) via 08e8a6f1ec66c93f8194bc747625f12272796129 (commit) via 05b0956957cffd0851ea38e3f4ba9597f9178d55 (commit) via 9e54375398965829f1d5c2e679b9529cb9c86311 (commit) via 9ed00ad6dc9d08542b29b8e7592e6081189482f5 (commit) via 6eade474ed3a84a5ba372a26ac27bf9fb4bd2299 (commit) via 1544f9a5d4a8acd47c97d7c6ac55dee8e759d3ff (commit) via b2e305b10b3ee0545799c2f752b4483cb3373970 (commit) via dadfeabc379ffeb417aad28e544fbdcc292d2755 (commit) via b8d188caa9370a435690882f93cf6850e39c7fb2 (commit) via 89c7d328fdeaea96adca3d9a179ad26695dbc292 (commit) via bcfa31a8e37f88ab07c1e7ed954ab57684d0dcfa (commit) via 8599d5b675072977dec4a78831017cd395e96cfe (commit) via fa592a9685a5f072b20ef16c3f3fbcd2fa6e36b2 (commit) via ff100eb77362781ce901066818baa03b4ff1f7eb (commit) via 546379cc92b733cb29a0b70247a72c770afdad26 (commit) from d9c8eea442bbe4e30be172d547e519dcd781341d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 94513d0739757f0c5db4b7d1040aaae40622a60e Author: Jonathan Druart Date: Mon Jul 10 14:18:12 2017 -0300 Bug 17829: Update CanUserManageBasket to fix tests Signed-off-by: Jonathan Druart commit 9cad748de79f6b11026e3a112c2dd3dbc6c0cfc8 Author: Tomas Cohen Arazi Date: Mon Jul 10 11:54:05 2017 -0300 Bug 17829: (followup) Fix small rebasing errors Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 1b2435cb4a56c125022da6fabbff99cdc0473b66 Author: Jonathan Druart Date: Wed Apr 5 14:05:07 2017 -0300 Bug 17829: followup for request.pl This script is really ugly and need to be rewritten completely to separate the different action. $patron is not always defined, we need to take it into account. Note that this patch is mainly indentation changes. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 2b90ea2cb0e5e976de7ddef0151ae83d8ac578e6 Author: Jonathan Druart Date: Thu Dec 29 14:24:03 2016 +0100 Bug 17829: Move GetMember to Koha::Patron GetMember returned a patron given a borrowernumber, cardnumber or userid. All of these 3 attributes are defined as a unique key at the DB level and so we can use Koha::Patrons->find to replace this subroutine. Additionaly GetMember set category_type and description. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 06c53f21dbf6258451999358e4f4fd59d3315111 Author: Marcel de Rooy Date: Fri Jul 7 10:42:55 2017 +0200 Bug 18260: [QA Follow-up] Always something left? Remove second Koha::Biblios->find in imageviewer.pl Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit fa48e204f21e72c82b557b1ac9e4ba5859b7226e Author: Jonathan Druart Date: Wed Jul 5 16:26:37 2017 -0300 Bug 18260: Handle nonexistent biblionumber in imageviewer.pl Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit c73e269a13f64fe016dc90941280c9d2e9cfb02c Author: Jonathan Druart Date: Mon Mar 13 16:43:40 2017 -0300 Bug 18260: Koha::Biblio - Remove GetBiblio C4::Biblio::GetBiblio can be replaced with Koha Biblio->find Test plan: Import batch, view issue history, search for items, see the image of a bibliographic record, modify and delete records in a batch Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 0c14a76049061a581c508a8abe032bbb7844fabe Author: Marcel de Rooy Date: Fri Jul 7 09:55:54 2017 +0200 Bug 18277: [QA Follow-up] Additional polishing Fix POD error in Biblio.pm, as reported by qa tools: Apparent command =cut not preceded by blank line Resolve crash in t/db_dependent/Items/DelItem.t: Can't call method "biblio" on an undefined value at C4/Items.pm line 669. Add find test in tools/batchMod.pl. Increase readability of map statement. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 98aaa69d38eda8bf9beee3ac8dd8e5d60443eb3f Author: Jonathan Druart Date: Wed Mar 15 12:42:33 2017 -0300 Bug 18277: Remove the C4::Biblio::GetBiblionumberFromItemnumber Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit ed03edddbdb6846588ff42e967b44c190cdb019b Author: Jonathan Druart Date: Wed Mar 15 12:39:01 2017 -0300 Bug 18277: Remove GetBiblionumberFromItemnumber - create_analytical_rel.pl I have no idea how to test this patch, see bug 5528, or simply read the code. Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 2c9aeb9b0f4449d1a25274b8fbf8dae4ec11d3bf Author: Jonathan Druart Date: Wed Mar 15 12:30:53 2017 -0300 Bug 18277: Remove GetBiblionumberFromItemnumber - linkitem Test plan: Enable EasyAnalyticalRecords and link an item to another one (Edit > link to host item) Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit fa467223eaedc2a6a09f0796ae57463de573d832 Author: Jonathan Druart Date: Wed Mar 15 12:28:13 2017 -0300 Bug 18277: Remove GetBiblionumberFromItemnumber - Easy ones To retrieve a biblionumber from an itemnumber, we can use: Koha::Item->biblio->biblionumber This is only what this patchset does. Doing that we will be able to get rid of the C4::Biblio::GetBiblionumberFromItemnumber subroutine. Test plan: - Acquisition module: cancel a receipt - Export a record to CSV - Modify items in a batch Item's info should be correct Other changes with be checked by QA team, by reading the code. Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit eed1447a63b9e3d80fcb8171b5d2bfde3994e554 Author: Jonathan Druart Date: Mon Jul 10 12:54:35 2017 -0300 Bug 18276: (follow-up) Remove GetBiblioFromItemNumber - Easy ones - Item does not have a title attribute, it comes from biblio - There is an additional call to effective_itemtype done on AddReturn, so we need to catch both warnings Signed-off-by: Jonathan Druart commit f4ded893c56a89a24dd8ed0192350044093386bf Author: Marcel de Rooy Date: Fri Jul 7 09:04:21 2017 +0200 Bug 18276: [QA Follow-up] Fix two new calls Found two calls in opac-issue-note.pl and svc/patron_notes. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit b977e9ec241d9f5865e5882f60518e90076b5a29 Author: Jonathan Druart Date: Wed Jul 5 14:53:57 2017 -0300 Bug 18276: barcode may be nonexistent when checking out/in Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 08e8a6f1ec66c93f8194bc747625f12272796129 Author: Marcel de Rooy Date: Fri Jun 30 10:58:28 2017 +0200 Bug 18276: [QA Follow-up] Two newlines to make qa tools happy FAIL pod Apparent command =cut not preceded by blank line in file misc/cronjobs/advance_notices.pl FAIL pod Apparent command =cut not preceded by blank line in file C4/SIP/ILS/Item.pm Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 05b0956957cffd0851ea38e3f4ba9597f9178d55 Author: Jonathan Druart Date: Fri May 5 10:11:02 2017 -0300 Bug 18276: (follow-up) Remove GetBiblioFromItemNumber - ILSDI Take into account biblio level holds Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 9e54375398965829f1d5c2e679b9529cb9c86311 Author: Jonathan Druart Date: Thu Apr 20 12:49:51 2017 -0300 Bug 18276: FIX status display for course reserves This include file is terribly wrong, it's called from different places that do not set the same flag. The status from detail and result page might be different from the one display on the course reserve table. Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 9ed00ad6dc9d08542b29b8e7592e6081189482f5 Author: Jonathan Druart Date: Wed Mar 15 12:21:16 2017 -0300 Bug 18276: Remove the C4::Biblio::GetBiblioFromItemNumber subroutine Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 6eade474ed3a84a5ba372a26ac27bf9fb4bd2299 Author: Jonathan Druart Date: Wed Mar 15 16:02:38 2017 -0300 Bug 18276: Remove GetBiblioFromItemNumber - Easy ones The subroutine C4::Biblio::GetBiblioFromItemNumber was wrong for several reasons: - badly named, we can get biblio info from a barcode - SELECT * from items, biblio and biblioitems makes things hard to follow and debug, we never know where do come from the value we display - sometimes called only for trivial information such as biblionumber, author or title This patchset suggests to replace it with calls to: - Koha::Items->find for item's info - $item->biblio for biblio's info - $item->biblio->biblioitem for biblioitem's info Test plan: Item's info should correctly be displayed on the following pages: - circulation history - transfer book - checkin - waiting holds QA will check the other changes reading the code, it's trivial Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 1544f9a5d4a8acd47c97d7c6ac55dee8e759d3ff Author: Jonathan Druart Date: Wed Mar 15 16:02:31 2017 -0300 Bug 18276: Remove GetBiblioFromItemNumber - circulation pages Test plan: 1. Checkout items in a batch The information displayed should be ok (title, subtitles, author, itemnotes, barcode) 2. Checkout an item using the standard checkout page You should correctly see the information of the item that has been checked out (title and author) Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit b2e305b10b3ee0545799c2f752b4483cb3373970 Author: Jonathan Druart Date: Wed Mar 15 10:41:29 2017 -0300 Bug 18276: Remove GetBiblioFromItemNumber - ILSDI Test plan: Hit /cgi-bin/koha/ilsdi.pl?service=GetPatronInfo&patron_id=51&show_holds=1 The results should be the same before and after this patch Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit dadfeabc379ffeb417aad28e544fbdcc292d2755 Author: Jonathan Druart Date: Wed Mar 15 10:15:30 2017 -0300 Bug 18276: Remove GetBiblioFromItemNumber - Course reserves Values from the items, biblio and biblioitems tables are used in the template, so we need to pass all of them to the template, but separately. That way we easily see which field from which table we are displaying. Test plan: Create a course reserve and add items. Correct information must be displayed on the detail page of the course reserve, on staff and OPAC interface. Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit b8d188caa9370a435690882f93cf6850e39c7fb2 Author: Tomas Cohen Arazi Date: Fri Jul 7 16:53:09 2017 -0300 Bug 17680: Remove Koha::Upload use incorrectly added Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 89c7d328fdeaea96adca3d9a179ad26695dbc292 Author: Jonathan Druart Date: Wed Jul 5 17:11:24 2017 -0300 Bug 17680: Fix conflict with bug 18651 $issue is now a Koha::Checkout, not a hashref Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit bcfa31a8e37f88ab07c1e7ed954ab57684d0dcfa Author: Jonathan Druart Date: Thu Jun 15 12:18:49 2017 -0300 Bug 17680: Add few tests for AddReturn when overdue To make sure the last patch fixes the issue Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 8599d5b675072977dec4a78831017cd395e96cfe Author: Jonathan Druart Date: Wed Jun 14 10:48:29 2017 -0300 Bug 17680: Fix regression - is_overdue must be called is_overdue must be called even if there is not dropbox date (!) Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit fa592a9685a5f072b20ef16c3f3fbcd2fa6e36b2 Author: Jonathan Druart Date: Fri Nov 25 13:53:03 2016 +0100 Bug 17680: C4::Circulation - Remove GetItemIssue, complex calls There are a few calls to GetItemIssue where it's not as easy to make sure everything will be fine just replacing the calls with a Koha::Issues->find - In AddReturn the overdue flag is used (that's why this patch depends on bug 17689) - In CanBookBeRenewed, as well as the overdue flag the dates converted to DateTime were used. It's now our job to convert them when we need them. - Same in AddRenewal but we also call _CalculateAndUpdateFine, so we need to update the variables in this subroutine. Note that, prior to this patch, AddReturn returned the GetItemIssue hashref in the $iteminformation. Most of the time this variable is not used, I have found only 1 place where it's used: circ/returns.pl TODO: In this script we should call ->is_overdue instead of the DateTime->compare calls Test plan: All the circulation tests must pass (it's how I have caught the specific cases). Do some checkins/checkouts/renewal and focus on the due date Signed-off-by: Marc V?ron Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit ff100eb77362781ce901066818baa03b4ff1f7eb Author: Jonathan Druart Date: Fri Nov 25 14:00:34 2016 +0100 Bug 17680: C4::Circulation - Remove GetItemIssue This patch simply removes the C4::Circulation::GetItemIssue subroutine Test plan: At this point, `git grep GetItemIssue` should not return any occurrence in the codebase Signed-off-by: Alex Buckley Signed-off-by: Marc V?ron Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 546379cc92b733cb29a0b70247a72c770afdad26 Author: Jonathan Druart Date: Fri Nov 25 12:02:01 2016 +0000 Bug 17680: C4::Circulation - Remove GetItemIssue, simple calls C4::Circulation::GetItemIssue returned all the issue and item informations for a given issue. Moveover it also did some date manipulations. Most of the time this subroutine was called, there additional information were useless as the caller usually just needed the basic issue's infos 'from the issue table). This first patch updates the simple calls, ie. the ones that just need the issue's infomations. Test plan: The following operations should success: - transfer a book - create a rule for on-site checkouts and confirm that a patron cannot check more items out that it's defined in the rule. - Renew an issue using ILSDI - Using SIP confirm that you are able to see your issues Followed test plan, works as expected Signed-off-by: Marc V?ron Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: C4/Acquisition.pm | 31 +- C4/Auth.pm | 7 +- C4/Biblio.pm | 77 +--- C4/Budgets.pm | 5 +- C4/Circulation.pm | 413 +++++++++----------- C4/CourseReserves.pm | 8 +- C4/HoldsQueue.pm | 11 +- C4/ILSDI/Services.pm | 106 ++--- C4/ImportBatch.pm | 8 +- C4/Items.pm | 3 +- C4/Letters.pm | 30 +- C4/Members.pm | 77 +--- C4/Record.pm | 4 +- C4/Reserves.pm | 35 +- C4/SIP/ILS/Item.pm | 64 ++- C4/SIP/ILS/Patron.pm | 10 +- C4/SIP/ILS/Transaction.pm | 8 +- C4/SIP/ILS/Transaction/Hold.pm | 40 +- C4/SIP/ILS/Transaction/Renew.pm | 6 +- C4/SIP/ILS/Transaction/RenewAll.pm | 4 +- C4/Serials.pm | 8 +- Koha/REST/V1/Hold.pm | 15 +- acqui/acqui-home.pl | 12 +- acqui/addorderiso2709.pl | 10 +- acqui/basket.pl | 12 +- acqui/basketgroup.pl | 8 +- acqui/booksellers.pl | 14 +- acqui/neworderbiblio.pl | 6 +- acqui/neworderempty.pl | 11 +- acqui/orderreceive.pl | 11 +- acqui/transferorder.pl | 5 +- admin/aqbudgets.pl | 15 +- catalogue/ISBDdetail.pl | 10 +- catalogue/MARCdetail.pl | 10 +- catalogue/detail.pl | 18 +- catalogue/imageviewer.pl | 21 +- catalogue/issuehistory.pl | 13 +- catalogue/itemsearch.pl | 3 +- catalogue/labeledMARCdetail.pl | 10 +- catalogue/moredetail.pl | 15 +- catalogue/search.pl | 12 +- cataloguing/additem.pl | 7 +- cataloguing/linkitem.pl | 69 ++-- cataloguing/moveitem.pl | 24 +- circ/branchtransfers.pl | 59 +-- circ/circulation.pl | 104 +++-- circ/returns.pl | 253 ++++++------ circ/transferstoreceive.pl | 41 +- circ/waitingreserves.pl | 49 +-- course_reserves/add_items.pl | 7 +- .../prog/en/modules/catalogue/issuehistory.tt | 10 +- .../prog/en/modules/cataloguing/linkitem.tt | 1 - .../prog/en/modules/cataloguing/moveitem.tt | 8 +- .../prog/en/modules/circ/circulation.tt | 2 +- .../en/modules/circ/circulation_batch_checkouts.tt | 2 +- .../en/modules/course_reserves/add_items-step2.tt | 4 +- .../en/modules/course_reserves/course-details.tt | 10 +- .../bootstrap/en/includes/item-status.inc | 19 +- .../bootstrap/en/modules/opac-course-details.tt | 8 +- members/boraccount.pl | 18 +- members/deletemem.pl | 54 +-- members/discharge.pl | 49 ++- members/files.pl | 16 +- members/housebound.pl | 2 +- members/mancredit.pl | 18 +- members/maninvoice.pl | 20 +- members/member-flags.pl | 89 +++-- members/member-password.pl | 19 +- members/member.pl | 11 +- members/memberentry.pl | 14 +- members/moremember.pl | 21 +- members/notices.pl | 11 +- members/pay.pl | 7 +- members/paycollect.pl | 7 +- members/printfeercpt.pl | 12 +- members/printinvoice.pl | 12 +- members/purchase-suggestions.pl | 17 +- members/readingrec.pl | 15 +- members/routing-lists.pl | 29 +- members/statistics.pl | 14 +- members/summary-print.pl | 7 +- members/update-child.pl | 4 +- misc/cronjobs/advance_notices.pl | 15 +- misc/cronjobs/notice_unprocessed_suggestions.pl | 20 +- misc/export_borrowers.pl | 17 +- misc/load_testing/benchmark_staff.pl | 4 +- misc/migration_tools/create_analytical_rel.pl | 57 ++- offline_circ/enqueue_koc.pl | 12 +- offline_circ/list.pl | 18 +- offline_circ/process_koc.pl | 82 ++-- opac/opac-ISBDdetail.pl | 6 +- opac/opac-MARCdetail.pl | 5 +- opac/opac-account-pay-paypal-return.pl | 5 +- opac/opac-account.pl | 10 +- opac/opac-detail.pl | 23 +- opac/opac-discharge.pl | 6 +- opac/opac-imageviewer.pl | 4 +- opac/opac-issue-note.pl | 8 +- opac/opac-memberentry.pl | 23 +- opac/opac-messaging.pl | 5 +- opac/opac-passwd.pl | 13 +- opac/opac-readingrecord.pl | 4 +- opac/opac-registration-verify.pl | 5 +- opac/opac-renew.pl | 3 +- opac/opac-reserve.pl | 40 +- opac/opac-sendbasket.pl | 9 +- opac/opac-sendshelf.pl | 7 +- opac/opac-shelves.pl | 11 +- opac/opac-showreviews.pl | 4 +- opac/opac-suggestions.pl | 8 +- opac/opac-user.pl | 2 +- opac/sco/sco-main.pl | 8 +- opac/svc/patron_notes | 4 +- patroncards/create-pdf.pl | 4 +- patroncards/edit-batch.pl | 5 +- reports/orders_by_fund.pl | 6 +- reserve/placerequest.pl | 6 +- reserve/request.pl | 187 ++++----- reviews/reviewswaiting.pl | 8 +- serials/routing-preview.pl | 3 +- serials/routing.pl | 3 +- serials/subscription-history.pl | 5 +- suggestion/suggestion.pl | 22 +- svc/members/search | 5 +- t/db_dependent/Acquisition.t | 8 +- t/db_dependent/Acquisition/OrderUsers.t | 2 - t/db_dependent/Circulation.t | 107 ++++- t/db_dependent/Circulation/Branch.t | 1 - t/db_dependent/Circulation/CheckIfIssuedToPatron.t | 5 +- .../Circulation/GetPendingOnSiteCheckouts.t | 4 +- t/db_dependent/Circulation/GetTopIssues.t | 3 +- t/db_dependent/Circulation/IsItemIssued.t | 3 +- .../Circulation/IssuingRules/maxsuspensiondays.t | 4 +- t/db_dependent/Circulation/Returns.t | 8 +- t/db_dependent/Circulation/SwitchOnSiteCheckouts.t | 7 +- t/db_dependent/Circulation/issue.t | 31 +- t/db_dependent/Holds/RevertWaitingStatus.t | 4 +- t/db_dependent/Koha/Patrons.t | 2 +- t/db_dependent/Members.t | 37 +- t/db_dependent/Members/GetAllIssues.t | 5 +- t/db_dependent/Members/GetOverdues.t | 3 +- t/db_dependent/Members/GetPendingIssues.t | 5 +- t/db_dependent/Members/IssueSlip.t | 3 +- t/db_dependent/Patron/Borrower_Debarments.t | 3 +- t/db_dependent/Patron/Borrower_Discharge.t | 2 +- t/db_dependent/Patron/Borrower_PrevCheckout.t | 13 +- t/db_dependent/Reserves.t | 3 +- t/db_dependent/Utils/Datatables_Members.t | 15 + t/db_dependent/rollingloans.t | 7 +- tools/batchMod.pl | 14 +- tools/batch_record_modification.pl | 4 +- tools/import_borrowers.pl | 4 +- tools/modborrowers.pl | 3 +- tools/picture-upload.pl | 1 - tools/viewlog.pl | 26 +- virtualshelves/shelves.pl | 8 +- 156 files changed, 1688 insertions(+), 1678 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Jul 10 23:14:00 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 10 Jul 2017 21:14:00 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.05.00-225-gfd28b02 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via fd28b02202aa2b47d23cb503ba1e63844638a928 (commit) via 5d6813e0708a54a9113cd74cc6a2558c77b5fc33 (commit) via 96b1f92ae218bc889d1490385f934deec28f630a (commit) via 2f7bad7039137fe1b3263cbaded1ce68f8daba04 (commit) via a000d95a4d322607eccdbf08abc94dd78d4e5617 (commit) from 94513d0739757f0c5db4b7d1040aaae40622a60e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fd28b02202aa2b47d23cb503ba1e63844638a928 Author: Owen Leonard Date: Sat May 6 09:40:16 2017 +0000 Bug 12349: Show card number in detailled suggestion pages This patch modifies the main suggestion management page to link patron names to their details rather than with a "mailto:" link. This patch also includes the following changes: - A fix for Bug 18154, Show card number in suggestion details view. - Changes for brevity to labels in the suggestion details & edit view. - Addition of the datepicker class to date fields in the suggestion edit view. Signed-off-by: Marc V?ron Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 5d6813e0708a54a9113cd74cc6a2558c77b5fc33 Author: Jonathan Druart Date: Mon Jul 10 18:09:23 2017 -0300 Bug 18577: Add FIXME about the missing FK Signed-off-by: Jonathan Druart commit 96b1f92ae218bc889d1490385f934deec28f630a Author: Nick Clemens Date: Fri Jun 23 14:11:44 2017 +0000 Bug 18577 - Importing a batch using a framework not fully set up causes and endless loop To test: 1 - Create a new framework - don't set it up 2 - Stage some records for import 3 - Manage the import, note your new framwork is in the list 4 - Apply patch 5 - Reload the page 6 - Note the framework is no longer an option Followed test plan, worked as intended Signed-off-by: Alex Buckley Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart commit 2f7bad7039137fe1b3263cbaded1ce68f8daba04 Author: Julian Maurice Date: Mon Jun 12 09:18:30 2017 +0200 Bug 18633: Remove remaining use of CGI.param in template Signed-off-by: Marc V?ron Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit a000d95a4d322607eccdbf08abc94dd78d4e5617 Author: Julian Maurice Date: Wed Jun 28 13:05:42 2017 -0400 Bug 18633: Remove useless use of CGI TT plugin The form is sent using AJAX so there is never a query string in the URL (no POST parameters either) Tested both patches together, item search behaves as before, log entries are gone Signed-off-by: Marc V?ron Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: Koha/Schema/Result/BiblioFramework.pm | 9 ++ catalogue/itemsearch.pl | 1 + .../prog/en/modules/catalogue/itemsearch.tt | 87 +++----------------- .../prog/en/modules/catalogue/itemsearch_json.tt | 3 +- .../prog/en/modules/suggestion/suggestion.tt | 48 +++++++---- suggestion/suggestion.pl | 1 + tools/manage-marc-import.pl | 2 +- 7 files changed, 57 insertions(+), 94 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Jul 11 20:46:29 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 11 Jul 2017 18:46:29 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.05.00-226-gc91eb80 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via c91eb80efb3b715fcb825f5cfd11cc6b152cbcb2 (commit) from fd28b02202aa2b47d23cb503ba1e63844638a928 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c91eb80efb3b715fcb825f5cfd11cc6b152cbcb2 Author: Jonathan Druart Date: Tue Jul 11 15:23:17 2017 -0300 Bug 17829: (follow-up) Move GetMember to Koha::Patron Prevent crash at the opac when no user is logged in Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: opac/opac-ISBDdetail.pl | 2 +- opac/opac-MARCdetail.pl | 4 ++-- opac/opac-detail.pl | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jul 12 09:17:18 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 12 Jul 2017 07:17:18 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.01-38-g15e6d33 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via 15e6d33fc02f2c11e24c359dbc52da6b2f20fbf9 (commit) via 794bb066aaedbbd73cd66c08744c52f25b725d96 (commit) via 7feb5654ebe7c0445eead29ac14cb47374d1783c (commit) via b1737846404716094b42e19fd2f5774bf15e2662 (commit) via 437d7f62fb98ec04c4ec9753aae1e3d04bb56f51 (commit) from 9800895cabade7ad8d78ff986a9a156f3962efa2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 15e6d33fc02f2c11e24c359dbc52da6b2f20fbf9 Author: Nick Clemens Date: Mon Jul 3 09:42:21 2017 +0000 Bug 18434 - Followup fix tests for sorting and factes Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart (cherry picked from commit 540d488e980b2521b424bed0f0267002c6dbd03e) Signed-off-by: Fridolin Somers commit 794bb066aaedbbd73cd66c08744c52f25b725d96 Author: Nick Clemens Date: Fri Jun 16 10:01:12 2017 -0400 Bug 18434 - Followup - same changes for sort and facet fields To test: 1 - Index some stuff with multiple fields defined for sorting i.e. Authorites - make heading sortable - default is 110a and 111a for heading - a record with 111a empty will make the sort field empty 2 - view the record: curl http://localhost:9200/koha_kohadev_authorities/data/30?pretty=true 3 - Note the blank field 4 - Apply patch 5 - Reindex 6 - Fields should be correctly populated Unit tests to follow (once I have the originals working for all) Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart (cherry picked from commit 241be8ff1ae24fff6165c8d6877945637467ee9a) Signed-off-by: Fridolin Somers commit 7feb5654ebe7c0445eead29ac14cb47374d1783c Author: Tomas Cohen Arazi Date: Mon May 15 11:46:00 2017 -0300 Bug 18434: (QA followup) Move _convert_marc_to_json tests into Indexer.t Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart (cherry picked from commit 3b5529c3abca87afb4f66f5bc7d3aa0fe005c1aa) Signed-off-by: Fridolin Somers commit b1737846404716094b42e19fd2f5774bf15e2662 Author: Nick Clemens Date: Fri Apr 14 10:03:11 2017 -0400 Bug 18434: Elasticsearch indexing broken with newer catmandu version To test: 1 - Make sure you have latest koha deps, catmandu versions should be: libcatmandu-marc-perl 1.09-1~kohadev1 libcatmandu-perl 1.0304-2~kohadev1 2 - Reindex elastic 3 - Try searching and likely notice odd results 4 - Try: curl -XGET 'http://localhost:9200/koha_kohadev_biblios/data/792?pretty=true' with a known biblionumber and notice some null fields 5 - Apply patch 6 - Reindex 7 - Note fields are populated and search works as expected Signed-off-by: Chris Cormack Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart (cherry picked from commit 9eb88f588bd13ddf25135c26acd905abe71f326a) Signed-off-by: Fridolin Somers commit 437d7f62fb98ec04c4ec9753aae1e3d04bb56f51 Author: Tomas Cohen Arazi Date: Fri May 12 15:39:25 2017 -0300 Bug 18434: Add tests for K:SE:E::get_fixer_rules This patch tries to introduce exhaustive tests for this class method. I didn't try to provide a regression test for the current bug per-se, but cover the current method behaviour as much as I could. (kidclamp) I added a quick test of _convert_marc_to_json to use the mocking here and illuminate what the change does, before the patches this should fail (fields are indexed in place of one another), after it should succeed (new indexed fields are appended). A minor bug is highlighted by this new tests, I'll provide a followup for it. To test: - Run: $ sudo koha-shell kohadev k$ de kohaclone k$ prove t/db_dependent/Koha_Elasticsearch.t => FAIL: The returned fixer rules are not the expected ones Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart (cherry picked from commit 2d19a34529bc313922a085a99288e55d8634c8b6) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: Koha/SearchEngine/Elasticsearch.pm | 6 +- t/db_dependent/Koha_Elasticsearch.t | 138 ++++++++++++++++++++++++++- t/db_dependent/Koha_Elasticsearch_Indexer.t | 73 +++++++++++++- 3 files changed, 210 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jul 12 09:40:47 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 12 Jul 2017 07:40:47 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.01-39-g7bcad81 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via 7bcad818744b11180b2b2c31a5dda8d51552b862 (commit) from 15e6d33fc02f2c11e24c359dbc52da6b2f20fbf9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7bcad818744b11180b2b2c31a5dda8d51552b862 Author: Marcel de Rooy Date: Wed Jun 14 15:37:55 2017 +0200 Bug 18634: Handle colliding translation for preference sections Problem on this report was caused by translating the tabs Privacy and Payments by the same string. This caused overwriting a hash entry. This patch tests if the key already exists and if so, it merges the entries instead of overwriting the old contents. Test plan: [1] Make sure that e.g. Privacy and Payments translate to e.g Vie privee. [2] Run translate install fr-CA (or the language you altered) [3] Without this patch you should loose preferences from either Privacy or Payments. With this patch, they should be merged. Signed-off-by: Marcel de Rooy Tested with fr-CA. Signed-off-by: Blou Reset the .po files, reproduced the problem. Applied the patch and suddenly 'paypal' appeared. Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart (cherry picked from commit 0d98089ec701bc96893e68408ce2dedad36f7235) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: misc/translator/LangInstaller.pm | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jul 12 10:12:18 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 12 Jul 2017 08:12:18 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.01-40-g037e056 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via 037e056c0451e1d383a414e47573f5a4cece9677 (commit) from 7bcad818744b11180b2b2c31a5dda8d51552b862 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 037e056c0451e1d383a414e47573f5a4cece9677 Author: Mark Tompsett Date: Fri Jun 9 13:01:14 2017 -0400 Bug 18771: CGI.pm: Subroutine multi_param redefined The commands in the test plan are examples, and may need varying depending on your installation. This was created as a result of attempting to clean the installation process up. However, I believe the redefine might exist normally too. I just didn't check. This is tested on a Debian 8 box sudo apt-get update'd fully. TEST PLAN --------- empty error log $ echo > ~/koha-dev/var/log/koha-error_log drop and recreate and empty db > drop database koha_library; > create database koha_library; > quit run the web installer, but DO NOT LOG IN! *opening chrome to Staff Client URL* check the error log $ less ~/koha-dev/var/log/koha-error_log ... [Fri Jun 09 13:08:52.793627 2017] [cgi:error] [pid 5802] [client 192.168.71.101:58169] AH01215: [Fri Jun 9 13:08:52 2017] CGI.pm: Subroutine multi_param redefined at /usr/share/perl5/CGI.pm line 419. ... apply patch empty error log $ echo > ~/koha-dev/var/log/koha-error_log refresh the installation login page recheck the error log $ less ~/koha-dev/var/log/koha-error_log notice no reference to "Subroutine multi_param redefined" run koha qa test tools Notice that it is just a require CGI; and comment added. Signed-off-by: Lee Jamison Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit d222da0602ba96f08cc6c026f39451b0aa7de01e) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: C4/Context.pm | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jul 12 11:22:14 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 12 Jul 2017 09:22:14 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.01-41-g459c144 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via 459c144f2a54f4b1ddeb9e7595030107e821d2b2 (commit) from 037e056c0451e1d383a414e47573f5a4cece9677 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 459c144f2a54f4b1ddeb9e7595030107e821d2b2 Author: Colin Campbell Date: Thu Jun 8 12:59:55 2017 +0100 Bug 18755: Allow empty passwords in Patron Info to return OK With this patch a parameter 'allow_empty_passwords="1" can be added to a login in the SIP configuration file to allow the behaviour as was normal before the patch for bug 16610 was applied. Some sip clients rely on this behaviour sending an empty password field when they wish to validate to user but do not have the password. If a password is supplied it will be validated A test has been added to Message.t to confirm this behaviour Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit ebb887e5c93c96c6fc51d95b76de6a221ba4463e) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: C4/SIP/Sip/MsgType.pm | 3 +++ t/db_dependent/SIP/Message.t | 9 ++++++++- 2 files changed, 11 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jul 12 11:26:34 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 12 Jul 2017 09:26:34 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.01-42-g9efe633 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via 9efe6332901e081cb7f7fc0a510449b697da4ce4 (commit) from 459c144f2a54f4b1ddeb9e7595030107e821d2b2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9efe6332901e081cb7f7fc0a510449b697da4ce4 Author: Rodrigo Santellan Date: Wed Jun 21 15:40:43 2017 -0300 Bug 14572 - insert_single_holiday() forces a value on an AUTO_INCREMENT column, during an INSERT Removing all the id from the columns on the inserts and removing the parameter '' of the values for the id. Test plan: 1) Go to tools -> calendar 2) Add a Holiday only on this day. 3) Add a Holiday repeated every same day of the week. 4) Add a Holiday repeated yearly on the same date. 5) Add a Holidays on a range. 6) Add a Holidays repeated yearly on a range. 7) You should have the five calendars displayed. Signed-off-by: Lee Jamison Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit b94b16f67963b03fd17170d2c2f2efa581c12c0f) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: C4/Calendar.pm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jul 12 11:45:08 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 12 Jul 2017 09:45:08 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.01-44-geac2968 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via eac29685b98ee766a861bd664fe1fc5b15d417d0 (commit) via 87f4310dd2eaf3e2298e0a9bcb02ac7d54ec0c04 (commit) from 9efe6332901e081cb7f7fc0a510449b697da4ce4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit eac29685b98ee766a861bd664fe1fc5b15d417d0 Author: Marcel de Rooy Date: Mon Jul 3 09:31:52 2017 +0200 Bug 18881: [QA Follow-up] Remove even more Removing the commented section from the template: If it does not work, it should not be here. When it works again, put it back in. Since @itemtypesloop is not used, remove it from the script too. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit e48a5fb560123bac31e9a692026601ddd320f966) Signed-off-by: Fridolin Somers commit 87f4310dd2eaf3e2298e0a9bcb02ac7d54ec0c04 Author: Marc V?ron Date: Fri Jun 30 20:20:44 2017 +0200 Bug 18881: Remove dead code from view_holdsqueue.pl Aleisha spotted the typo in $itemtypes and proposed a correction on bug 18859. The description was not even used. Template calls GetDescription. To test: Verify that viewing the holds queue still works as expected. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit f40c093c19e21c6a8aa7a41d4e51fc4e3fc1d8e9) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: circ/view_holdsqueue.pl | 14 -------------- .../prog/en/modules/circ/view_holdsqueue.tt | 11 ----------- 2 files changed, 25 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jul 12 11:55:08 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 12 Jul 2017 09:55:08 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.01-46-gad5d726 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via ad5d72658b21b7c7fe163b411ec637300ee528c2 (commit) via 0905eabc45a028cadf329f82f1287b49cb17023d (commit) from eac29685b98ee766a861bd664fe1fc5b15d417d0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ad5d72658b21b7c7fe163b411ec637300ee528c2 Author: Lee Jamison Date: Thu Jun 22 16:42:15 2017 +0000 Bug 18848: borrowers.lastseen comment typo Typo in comment for the lastseen column in the borrowers table. To test: 1. Verify lastseen column displays "last time a patron has been seed" 2. Apply patch 3. Verify lastseen column changed to "last time a patron has been seen" Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit e3bf4fc8bb821456305d587a8d49fe39b07abd06) Signed-off-by: Fridolin Somers commit 0905eabc45a028cadf329f82f1287b49cb17023d Author: Lee Jamison Date: Thu Jun 22 16:42:15 2017 +0000 Bug 18848: borrowers.lastseen comment typo Typo in comment for the lastseen column in the borrowers table. To test: 1. Verify lastseen column displays "last time a patron has been seed" 2. Apply patch 3. Verify lastseen column changed to "last time a patron has been seen" Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit 23b84c0b6532d9c42894b648891d835e7624db49) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/kohastructure.sql | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jul 12 11:57:29 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 12 Jul 2017 09:57:29 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.01-47-g1224ec9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via 1224ec9dbd1bf4a254918ddebd11a47eb0ae2ee5 (commit) from ad5d72658b21b7c7fe163b411ec637300ee528c2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1224ec9dbd1bf4a254918ddebd11a47eb0ae2ee5 Author: Marc V?ron Date: Mon Jun 19 21:23:54 2017 +0200 Bug 18824: Remove stray i from matching-rules.tt The file koha-tmpl/intranet-tmpl/prog/en/modules/admin/matching-rules.tt contains a stray i that should not be there. This patch removes it. Signed-off-by: Chris Kirby Applied patch. Checked line 516. Stray i had been removed. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit ce176fd170227456fa725e5f1f2f6b1b04fd044d) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/matching-rules.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Jul 12 11:58:44 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 12 Jul 2017 09:58:44 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.01-48-g5bbb863 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via 5bbb863147959471a1a11e019eb18007c5c78583 (commit) from 1224ec9dbd1bf4a254918ddebd11a47eb0ae2ee5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5bbb863147959471a1a11e019eb18007c5c78583 Author: Colin Campbell Date: Tue Jun 20 16:35:35 2017 +0100 Bug 18830: Fix phrasing of screen message Verb should be plural in this message Signed-off-by: Israelex A Vele?a for KohaCon17 Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit 8a0ecda6c4ff368b9ff7a18593d7bdf4fc07e541) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Jul 13 23:43:19 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 13 Jul 2017 21:43:19 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.05.00-239-g068db9a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 068db9aaabb0694b4d12404bda16525efad0fde7 (commit) via 88ab0ef5791d2b428399690c505ac42aba4616df (commit) via 7ed66a6c8ae1c3c824e496c2d312e23db1dd8e41 (commit) via 91e02ffdb31a560dd166bd45bca5a7815213f266 (commit) via f87435c933616c648c50ab609d1fea2ac51785a7 (commit) via afddf4145fbbfd978e4c5cd22f0ae2cbbef70560 (commit) via 58f9eded86c01d2889ed5a25551aba30c9b824a8 (commit) via 7723ffdd130996ec946d5b9149f90cb0cdc447fc (commit) via 1fc3751804146e92c0d8d85517ffcd6ec338808e (commit) via c1485ae8ce5432936cc28c066c9a28d3f6ec2f99 (commit) via a0b6bcfd55c0bdfc45f229ea5cc6373cece24432 (commit) via e21d2ac864b651375a366b12ab30b0f5b506f1d3 (commit) via 9f9d4aa4b067be60af423b2e2497ae370ef2484d (commit) from c91eb80efb3b715fcb825f5cfd11cc6b152cbcb2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 068db9aaabb0694b4d12404bda16525efad0fde7 Author: Owen Leonard Date: Tue Jun 6 15:50:19 2017 +0000 Bug 17639 - Remove white filling inside of Koha logo This patch modifies the Koha logo SVG file to remove the fill from two letters. This patch also optimizes the file and converts the text object to paths for better cross-platform portability. To test you could: - Open the file in an editor and confirm that the change is correct - or - - Open the file in a browser and use the code inspector to add a background-color attribute to the top-level tag. The logo should appear transparent, with no white fills. Signed-off-by: Jonathan Druart commit 88ab0ef5791d2b428399690c505ac42aba4616df Author: Aleisha Amohia Date: Thu Jul 13 05:16:53 2017 +0000 Bug 18934: Preventing warns in Admin -> SMS providers This patch initialises the $op variable to prevent the warns To test: 1) Go to admin -> sms providers 2) Notice warns in error log 3) Apply patch and refresh page 4) Notice warns are gone Sponsored-by: Catalyst IT Signed-off-by: Jonathan Druart commit 7ed66a6c8ae1c3c824e496c2d312e23db1dd8e41 Author: Aleisha Amohia Date: Tue Jun 27 01:40:48 2017 +0000 Bug 18858: Prevent warn when deleting a borrower debarment To test: 1) Look at intranet log 2) Go to delete a debarment on a borrower 3) Notice warn 4) Apply patch 5) Add a new debarment 6) Delete this debarment 7) Notice warn is gone Sponsored-by: Catalyst IT Signed-off-by: Jonathan Druart commit 91e02ffdb31a560dd166bd45bca5a7815213f266 Author: Owen Leonard Date: Sat Apr 29 19:29:11 2017 +0000 Bug 16545 - Make edit link a styled button in item search results This patch replaces the item search results "edit" link with a dropup button which offers "Edit item" and "Edit record" links. To test, apply the patch and perform an item search. Each results should have an "Edit" menu. Confirm that the menu links work correctly for items on more than one page. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart commit f87435c933616c648c50ab609d1fea2ac51785a7 Author: Owen Leonard Date: Sat Apr 29 19:36:18 2017 +0000 Bug 18542 - Move and style "new field" link in item search form This patch modifies the item search page JavaScript so that the "New field" link has a "+" icon and is always placed at the end of the last row in that section of the form. To test, apply the patch and open the item search form in the staff client. In the third section there should be a "+ New field" link at the end of the first row of fields. Clicking the "New field" link should clone that row and move the link to the end of the cloned row. Behaves as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Amended patch: Fix indentation commit afddf4145fbbfd978e4c5cd22f0ae2cbbef70560 Author: Chris Kirby Date: Wed Jun 21 18:27:21 2017 +0000 Bug 18839: Suggestion.pl spelling mistake On the suggestion management page, 'unknown' is spelled 'unkown' This patch corrects this spelling mistake in suggestion/suggestion.pl koha-tmpl/intranet-tmpl/prog/en/include/strings.inc koha-tmpl/intranet-tmpl/prog/en/include/search_indexes.inc Signed-off-by: Lee Jamison Signed-off-by: sonia BOUIS Signed-off-by: Jonathan Druart commit 58f9eded86c01d2889ed5a25551aba30c9b824a8 Author: Aleisha Amohia Date: Mon Jul 10 02:12:18 2017 +0000 Bug 18917: Use font-awesome buttons for CSV profiles To test: 1) Go to Tools -> CSV profiles 2) Notice old style of links for Edit and Delete 3) Apply patch and refresh page 4) Notice buttons for Edit and Delete 5) Confirm they work as expected Sponsored-by: Catalyst IT Signed-off-by: Lee Jamison Signed-off-by: Jonathan Druart commit 7723ffdd130996ec946d5b9149f90cb0cdc447fc Author: Aleisha Amohia Date: Mon Jul 10 02:31:22 2017 +0000 Bug 18918: Disable CSV option if no CSV profiles exist To test: 1) Confirm you have no MARC CSV profiles (tools -> csv profiles) 2) Go to Tools -> Export data 3) Select the CSV file format for biblios 4) Notice the CSV profile dropdown shows up but the dropdown is empty 5) Click the Export button, notice Koha breaks 6) Go back and apply the patch, refresh 7) Notice the CSV option is now disabled in the file format menu 8) If you hover over CSV, an appropriate message should show explaining why it is disabled 9) Create a CSV profile for MARC 10) Go back to Export and you should be able to use CSV now without problem Sponsored-by: Catalyst IT Signed-off-by: Lee Jamison Signed-off-by: Jonathan Druart commit 1fc3751804146e92c0d8d85517ffcd6ec338808e Author: Nick Clemens Date: Tue Apr 11 16:09:27 2017 -0400 Bug 18367 - Fix untranslatable string from Bug 18264 Restore display of message when no barcode found To test: 1 - Go to course reserves 2 - Add an item to a course 3 - Try adding an invalid barcode - should get an alert 4 - Try force adding an item with itemnumber: http://localhost:8081/cgi-bin/koha/course_reserves/add_items.pl?op=lookpup&course_id=11&itemnumber=1234523546 5 - Should recieve an error Signed-off-by: Fr?d?ric Demians Signed-off-by: Jonathan Druart commit c1485ae8ce5432936cc28c066c9a28d3f6ec2f99 Author: Jonathan Druart Date: Thu Jul 13 14:39:08 2017 -0300 Bug 18775: Use Koha::Patron->library instead of Koha::Libraries->find Signed-off-by: Jonathan Druart commit a0b6bcfd55c0bdfc45f229ea5cc6373cece24432 Author: David Kuhn Date: Sat Jun 10 13:08:20 2017 -0700 Bug 18775 - The "Password Reset" notice should use the patron's homebranch's email as "from" address To test: 1. Enable the password recovery feature. 2. In the OPAC, click on "Forgot you password?" link and enter requested information. 3. The email with the password reset link has the Koha Admin Email Address listed as the sender. 4. Apply the patch. 5. Repeat step 2. The email with the password reset link now has the the "from" address set for the patron's home branch listed as the sender. Signed-off-by: Jessica Freeman Signed-off-by: Jonathan Druart commit e21d2ac864b651375a366b12ab30b0f5b506f1d3 Author: Owen Leonard Date: Wed May 24 17:51:18 2017 +0000 Bug 18667: Show a diff view of SQL reports when converting This patch reformats the SQL conversion before-and-after view so that it shows a diff between the two, just as the Manage MARC Import interface does. This patch also makes a correction to the JavaScript which is triggered by the closing of the modal. In Bootstrap 3 "hidden.bs.modal" is the event name instead of "hidden." To test, apply the patch and find an SQL report in your reports library which requires updating. - Click the "Update SQL" button. - In the modal window, the "existing" and "updated" SQL should be shown side-by-side with colored highlighting of the differece. - Confirm that the "Update" button still works correctly. - Also confirm that if you open the preview of another report, the "Close" button hides the modal and updates the contents of the modal markup. Use your browser's DOM inspector to confirm that