[koha-commits] main Koha release repository branch master updated. v17.05.00-279-g37fc0d8

Mon Jul 24 21:01:00 CEST 2017

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  37fc0d817d46d21897015a8e1df754b59ba477a6 (commit)
       via  04a601ef659c64446790758ebbe369a2ce090875 (commit)
       via  1b4d4f989b1d6c589a08f21ce19a48dca9072ec7 (commit)
       via  db64c94953be772fb316d508fdfffd374ea1d835 (commit)
       via  214a0e61021934c7e6deee5a24cf11606a57199b (commit)
       via  51e8b7bbc9d4fe1d560b65eef3285ec3c0b74e71 (commit)
       via  9b92d79817c359635f463fd5a1e5715affe96356 (commit)
       via  e9374dcf6308256f4597e1c83920559d2673b90c (commit)
       via  7a306d72ab98f2abf2266716761820f1098ede9b (commit)
       via  40c719a5248877d200920c2c9a028e273a5f1370 (commit)
       via  f839955db707415368d23ae81bdb14505dd058ee (commit)
       via  50bc4170cec172de04db2033d464c96348d5a508 (commit)
       via  a696843f82dc026ab6545f18b113af8efc753715 (commit)
       via  d5dc473382ccfa118e78e91507384245ce0dcfcb (commit)
       via  f55b8493460116c06e88058af6d86de6700c7b37 (commit)
      from  cd42ce2252b275092bf704447777f25ebd3d31dc (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 37fc0d817d46d21897015a8e1df754b59ba477a6
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Jul 24 14:25:21 2017 -0300

    Bug 18545: Re-add call to enableCheckboxActions

    This call is used to refresh the page correctly

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 04a601ef659c64446790758ebbe369a2ce090875
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Fri Jun 9 15:50:41 2017 +0000

    Bug 18545 [Follow-up] Remove use of onclick from OPAC Cart

    This patch makes a few corrections:

    - Use 'e.preventDefault()' instead of 'return false' in changed
      sections.
    - Modify the event handler on checkboxes to successfully handle the
      un-check action as well as the check action. (QA comment 5).

    To test, follow the original test plan.

    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

    Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 1b4d4f989b1d6c589a08f21ce19a48dca9072ec7
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date:   Fri May 5 03:58:49 2017 +0000

    Bug 18545: Remove use of onclick from OPAC cart

    To test:
    1) Apply patch and add one or more items to your cart
    2) Confirm that clicking the following things still works as expected:
     - more details
     - brief display
     - send
     - download
     - print
     - select all
     - clear all
     - selecting by clicking checkbox
     - remove title
     - add title to list
     - place hold
     - add tag
     - empty and close

    Sponsored-by: Catalyst IT

    Followed test plan, works as expected. Resolves issue with two
    print dialogues from Bug 18544.
    Signed-off-by: Marc Véron <veron at veron.ch>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit db64c94953be772fb316d508fdfffd374ea1d835
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Mon May 15 10:38:43 2017 +0200

    Bug 18605: Remove TRUNCATE from C4/HoldsQueue.pm

    Replaces TRUNCATE by DELETE, since truncate implicitly commits. We don't
    need to do that here. (Would complicate testing it too.)
    Fixes typo disablig.
    Add a simple test to HoldsQueue.t.

    Test plan:
    Run t/db_dependent/HoldsQueue.t

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 214a0e61021934c7e6deee5a24cf11606a57199b
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Wed Jul 19 09:48:04 2017 +0200

    Bug 18955 - autocomplete is on in OPAC password recovery

    In OPAC password recovery form autocomplete is not disabled.
    So when login or email is entered, it is saved in browser input history for autocomplete.
    This is a major issue for OPAC on computers with public access.

    This patch adds autocomplete off on forms.

    Test :
    - Enable system preferences OpacPasswordChange and OpacResetPassword
    - Go to OPAC
    - Be sure to not be logged in
    - Click on "Forgot your password?"
    - Enter a loggin and email and Submit
    => Without patch there is an autocompletion with values you entered
    => With patch there is no autocompletion

    Signed-off-by: Marc Véron <veron at veron.ch>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 51e8b7bbc9d4fe1d560b65eef3285ec3c0b74e71
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Jul 24 14:04:06 2017 -0300

    Bug 18572: Remove AddRenewal parameter

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 9b92d79817c359635f463fd5a1e5715affe96356
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Jul 19 18:26:07 2017 +0000

    Bug 18572 - QA Followup

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit e9374dcf6308256f4597e1c83920559d2673b90c
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Jun 23 12:27:19 2017 +0000

    Bug 18572 - Improper branchcode set during OPAC renewal

    To test:
    1 - Set 'OpacRenewalBranch' to various settings
    2 - Renew an item for a ptron under each setting
    3 - Confirm action_log entries reflect the correct branch for each
    secnario
    4 - prove t/db_dependent/Circulation/issue.t

    Signed-off-by: David Kuhn <techservspec at gmail.com>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 7a306d72ab98f2abf2266716761820f1098ede9b
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Thu Jul 20 16:08:59 2017 +0200

    Bug 18965 - branch transfer limits pagination save bug

    In branch transfer limits, tables are paginated with 20 rows by default.

    The bug is that datatable not only hides rows, they are not in form.
    So when submitting form, rows not visible are erased.

    Test plan :
    Wihout patch :
    - Create 22 branches, you can hack the creation form by manualling calling URL : /cgi-bin/koha/admin/branches.pl?op=add_validate&branchcode=Bxx&branchname=Bxx
    - Go to Administration > Library transfer limits
    - You see table first page : only 20 first rows are shown
    - You see all checkboxes are checked
    - Go to second page of this table
    - Save
    => You see table first page with all checkboxes unchecked
    With patch the is no pagination, all checkboxes are shown when you save

    Signed-off-by: Axelle Clarisse <axelle.clarisse at univ-amu.fr>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 40c719a5248877d200920c2c9a028e273a5f1370
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Wed Jul 19 13:59:45 2017 +0200

    Bug 18951: Adjust Isbd.t

    Add schema calls.
    Remove an unneeded AddBiblio call.

    Test plan:
    Run t/db_dependent/Biblio/Isbd.t

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Lee Jamison <ldjamison at marywood.edu>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit f839955db707415368d23ae81bdb14505dd058ee
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Wed Jul 19 13:48:55 2017 +0200

    Bug 18951: Create data for TransformKohaToMarc.t

    Adding schema and caching statements.
    Adjust it so that the Koha to MARC mappings are not assumed to be present,
    but are created as needed.
    Remove the mock on marcflavour. It is no longer needed.
    Resolving a small typo.

    Test plan:
    Run t/db_dependent/Biblio/TransformKohaToMarc.t

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Lee Jamison <ldjamison at marywood.edu>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 50bc4170cec172de04db2033d464c96348d5a508
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Wed Jul 19 13:33:34 2017 +0200

    Bug 18951: Some t/Biblio tests are database dependent (git mv)

    Move Isbd.t and TransformKohaToMarc.t to db_dependent.
    Next patch will add a few adjustments too.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Lee Jamison <ldjamison at marywood.edu>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit a696843f82dc026ab6545f18b113af8efc753715
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Jul 21 12:07:19 2017 +0000

    Bug 18826 - (QA Followup) Add mock SessionStorage to patrons.t

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit d5dc473382ccfa118e78e91507384245ce0dcfcb
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Jul 12 17:24:24 2017 -0300

    Bug 18826: rollback transaction for api tests

    The holds.t tests for the REST api do no rollback properly and modify
    the DB (no cleanup).
    This comes from a bug caused by SessionStorage = mysql (default)

    The error is:
        "rollback ineffective with AutoCommit enabled"

    Test plan:
      select count(*) from borrowers;
      prove t/db_dependent/api/v1/holds.t
      select count(*) from borrowers;
    => The number of entry must be the same before and after the tests have
    been executed

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit f55b8493460116c06e88058af6d86de6700c7b37
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Sat Jul 22 21:48:49 2017 +0200

    Bug 18971: Typo Koha::ItemsTypes for Koha::ItemTypes

    As reported by Nick, a typo from bug 17843.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm                                  |    6 +-
 C4/HoldsQueue.pm                                   |    4 +-
 acqui/orderreceive.pl                              |    2 +-
 .../en/modules/admin/branch_transfer_limits.tt     |    2 +-
 .../opac-tmpl/bootstrap/en/modules/opac-basket.tt  |   92 ++++++++++++++++----
 .../bootstrap/en/modules/opac-password-recovery.tt |    4 +-
 opac/opac-renew.pl                                 |    2 +-
 t/Biblio/TransformKohaToMarc.t                     |   31 -------
 t/{ => db_dependent}/Biblio/Isbd.t                 |   11 +--
 t/db_dependent/Biblio/TransformKohaToMarc.t        |   42 +++++++++
 t/db_dependent/Circulation/issue.t                 |   24 ++++-
 t/db_dependent/HoldsQueue.t                        |   12 ++-
 t/db_dependent/api/v1/holds.t                      |   14 +--
 t/db_dependent/api/v1/patrons.t                    |   12 ++-
 14 files changed, 188 insertions(+), 70 deletions(-)
 delete mode 100644 t/Biblio/TransformKohaToMarc.t
 rename t/{ => db_dependent}/Biblio/Isbd.t (90%)
 create mode 100644 t/db_dependent/Biblio/TransformKohaToMarc.t

hooks/post-receive
-- 
main Koha release repository