[koha-commits] main Koha release repository branch 16.11.x updated. v16.11.08-35-g477ce13
Git repo owner
gitmaster at git.koha-community.org
Mon Jun 5 15:59:48 CEST 2017
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 16.11.x has been updated
via 477ce133588931d3529196771b40e59a23efa60e (commit)
via 49743040503e1d0bc690752de93287e43bdeb699 (commit)
via 20472eec42c8a92a10b536a22ec2ac80c0613487 (commit)
via bf5dfd2e0aaed6c82197c7ba0633bf93d44f976f (commit)
via 7a0dea4a7bd1eab568bd99f3fa28fdda3997179c (commit)
via f83e96c7ae62eb16b3764e3bf36083dd35e6263d (commit)
via 5c7bee6c4b924ee2d169b7e9b3045701b63e425a (commit)
via 7bd3424847c7d4c922a623417636837ab11a6ca2 (commit)
via 1607b2a18ba7b5ce9accfc673718f3d633e26edd (commit)
via 9ce77e80a9dc82c0abaa82ccb35f2331c2d3f965 (commit)
via cb82ca95ec579b6ad05b24163673e68039f56520 (commit)
via 122fa4c82af978b3d074ae4bafb2b0f49a3e4592 (commit)
via ba18e8e3bf173b07c4179cb1559fabc72b05f60a (commit)
via 26977379950beb656e818b7f91cf86eff1af141f (commit)
via a4e1c502726a23c31f7c2084577b30aa376b3124 (commit)
via 1f2bf282bf29bbc1fd4ed8f15e9217573543dc0e (commit)
via bebe91bafbb84381fea8b920665df117536e4651 (commit)
via dfc043a6495e6426a950a2779bf688c5f95aabe5 (commit)
via fac99c82ccbbc3462d0a8bead681ab9d1c19fa57 (commit)
via ed4946ad4027e5a0da62e7f67387bd446d75d920 (commit)
via 134554f448b4a09210edbb65520d7d95163ccde5 (commit)
via d4a7949c0466c3bd6900a93aa61c69e0e3469ec8 (commit)
via ae368a3eaaa70cf3f677ba49d5cb5ad21b72cafa (commit)
via bb9df1e552996eccb4e3fd650e7cc214a7b55720 (commit)
via d88b51691bd3225f909cee961299807495d873a4 (commit)
via b74de73f5521bb416edea9b7123eb3088f5e7e04 (commit)
via ae71ae912e7e8b714e7bf23130fb3acf492048d2 (commit)
via 873aca09ae4bb96fd4dd44e1a8034701a43aedb9 (commit)
via 8ebbefed7323b303407dc972098a5ef1bd69c518 (commit)
via df74913f2e9cb5c2cb533f15c1ac4575054cdc57 (commit)
via 00549f22cd049817ee6ef996d430fc04190ac1a3 (commit)
via 54d42d3465c42d4c72a64336a162f31c79d35a9f (commit)
via 21d8f726fa205b4b31f9a3b7f17227688a6b3449 (commit)
via ed66ddc018d0b8286e9b339b3e253f940f172c59 (commit)
from 5c7ca2ef433e94c8fae59467c7d73dad4dbee2e1 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 477ce133588931d3529196771b40e59a23efa60e
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Mon Jun 5 15:54:52 2017 +0200
Revert "Bug 18551 - Hide with CSS dynamic elements in member search"
This reverts commit 243c75430c97df727c4f6a51228d95c401face88.
commit 49743040503e1d0bc690752de93287e43bdeb699
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Mon Jun 5 15:54:38 2017 +0200
Revert "Bug 18551: followup - hide advanced filters in header, move hidding to css file"
This reverts commit 50f10a39280d741945e501f7de8c12a34429cd5b.
commit 20472eec42c8a92a10b536a22ec2ac80c0613487
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Mar 20 07:22:41 2017 -0400
Bug 18264 - (QA Followup) Remove use of GetBiblioFromItemNumber Replace <blank> with (blank)
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 0d239e4e6f3c7095173773252dc9ce38b48c0799)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit bf5dfd2e0aaed6c82197c7ba0633bf93d44f976f
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Mar 14 14:16:09 2017 +0000
Bug 18264 - Course reserves - use itemnumber for editing existing reserve items
This patch alters the crouse reserves module to use itemnumber as the
lookup method for existing reserves as opposed to barcode
To test:
1 - Apply patch
2 - Add some items to a course reserves - all should work as expected
3 - Delete the barcode for an item on reserve
4 - Note the edit link still resolves to the correct item
Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
(cherry picked from commit 2ead301181c33f42d3c88abffa8d18b8a416b40a)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit 7a0dea4a7bd1eab568bd99f3fa28fdda3997179c
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Feb 16 11:04:11 2017 +0000
Bug 17974 (QA Followup)
Use the $biblio_rs variable
In case of Koha::Object you can call new_from_dbic directly, however,
it fails for Koha::Objects so using an intermediary variable should
be done for consistency
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 236dbdf5f1922f98305df8b4c3aee040c0086b05)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit f83e96c7ae62eb16b3764e3bf36083dd35e6263d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Sat Jan 21 16:45:34 2017 +0100
Bug 17974: Add the Koha::Item->biblio method
Test plan:
prove t/db_dependent/Koha/Items.t
should return green
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit c614342f2743b1076b6a7a6740ea6586acf547ac)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit 5c7bee6c4b924ee2d169b7e9b3045701b63e425a
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed May 17 12:54:44 2017 -0400
Bug 18478 - Some notices sent via SMS gateway fail
It seems that for HOLD and DUE (and maybe more) notices we rely on
C4::Letters::SendQueuedMessages
to populate the correct address.
This patch adjust that subroutine to correctly populate the field and/or
fail messages if no SMS provider available
To test:
1 - Define a messaging prefs for a patron to recieve hold notices via
SMS
2 - Ensure you have defined an SMS message for 'HOLD' letter
3 - Set an SMS alert number for patron
4 - Set the SMS::Send driver to 'Email'
5 - Fill a hold for the patron
6 - Check the db and note the address is null
7 - run process_message_queue.pl
8 - Check db - address is null and message pending
9 - Apply patch
10 - run process_message_queue
11 - Message to_address should be populated and message sent
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 4fa3df9462eaa4a6a2399af4d7036d2f3ee990ce)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit 7bd3424847c7d4c922a623417636837ab11a6ca2
Author: Olivier Crouzet <kohateam at univ-lyon3.fr>
Date: Sat Apr 22 18:20:48 2017 +0200
Bug 18482 False duplicates detected on adding a batch-[16.11.x]
For applying on 16.11.x
When adding a batch from a stage file with defaut matching on
title/author, if a duplicate is detected, all following records
treated in the batch are discarded from import even if they are not duplicates
Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit 1607b2a18ba7b5ce9accfc673718f3d633e26edd
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue May 2 17:27:48 2017 -0300
Bug 18512: Add tests 16.11.X version
Remove use of build_object
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit 9ce77e80a9dc82c0abaa82ccb35f2331c2d3f965
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Apr 28 14:11:00 2017 -0400
Bug 18512 - GetAuthorisedValues.GetByCode Template plguin should return code (not empty string) if value not found
To test:
1 - Create or edit a borrower with info in Sort1 and Sort2 field, not
mapped to authorized values
2 - Note this info does not display on moremember.tt
3 - Apply patch
4 - Note value is passed through
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 62c337065590a0eca51db37d286bcb04fa7971ff)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit cb82ca95ec579b6ad05b24163673e68039f56520
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed Apr 12 16:06:29 2017 +0200
Bug 14399: Results form also needs a few interface changes
Currently, the value of compareinv2barcd is used to determine if the
Seen column, the Select/Clear all buttons and the Mark seen buttons are
displayed. But if we scanned barcodes, we already marked items as seen.
So we should only display these buttons when we did not upload barcodes.
Test plan:
[1] Upload a barcode file. Check that the result form does not show
the buttons.
[2] Generate an inventory list, so do not upload a barcode file. Verify
that you still see the buttons.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit af89df12e72ea51010039a2206bb942bcc4c4b50)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit 122fa4c82af978b3d074ae4bafb2b0f49a3e4592
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed Apr 5 15:12:31 2017 +0200
Bug 14399: Interface changes
A part of the confusion around the inventory script may arise from the
fact that the form offers several options that are only used under
certain conditions. This patch hopefully rearranges a few options more
logically and only offers options when appropriate.
The barcode fieldset now also contains Compare barcodes and Do not check in
checkboxes. These are meaningful when a barcode file is uploaded.
The fieldset Item location filters (new name) contains fields that are
always used. Same for tne only control left under Additional options,
Export to CSV.
The fieldset Optional filters depends on the status of the barcode file
and the Compare checkbox. It is now shown or hidden depending on what
you select: if you do not upload a file, it is shown; or if you upload
a file and check Compare, it is shown. Otherwise we hide it, since the
script will not look at these values. Under this fieldset last inventory
date and Skip items on loan are added, since their behavior is the same
as the various item statuses.
Test plan:
In this test plan we test both the script changes from the previous patch
and the interface changes here. We follow the three main scenario's as
mentioned in the previous patch.
[1] First we prepare a few test items.
Pick two biblios A, B and create five items say A1,A2,B1,B2,B3.
Pick a not-existing callnumber range you want to test and move these
five items there. Add barcodes too (say A1..B3).
Edit one item A1 to a not-existing notforloan status (doing this on
the mysql command line is fastest).
Like: update items set notforloan = '9' where barcode='A1';
Now simulate that we did not add/edit these items today:
update items set datelastseen='2017-01-01' where barcode in ('A1','A2','B1','B2','B3');
Note: We need this when comparing with last inventory date in the last
scenario.
Scenario 1 (no barcodes uploaded)
[2] Enter the callnumber range on inventory form.
Verify that "Set inventory date", Compare barcodes and "Do not check
in" are disabled on the form. Check that you see the Optional filters
box.
Submit the form. Verify that you see all five items.
Do the same. Check Export to CSV. Check result file contents.
Scenario 2 (upload barcodes, do not compare)
[3] Create a barcode file with the barcodes of A1, A2 and B1. Add another
existing barcode outside the test callnumber range.
After uploading this file, verify that "Set inventory date", Compare and
"Do not check in" are enabled. The Optional filters should be hidden.
Leave "Set inventory date" to today. Enter the callnumber range again.
Submit the form.
What do we expect? Four items should have been updated (alert). We
should see barcode A1 with problem Unknown status. We should see
also the barcode from the other range (Found in wrong place).
Repeat this step with the same file. But now export to CSV. Verify that
you see two barcodes with problems again in the csv file.
Scenario 3 (upload barcodes, compare)
[4] Create another barcode file with barcodes of B2 and one existing barcode
outside the test callnumber range.
After uploading this file, check the Compare checkbox. Verify now that
the Optional filters box is displayed again.
Leave "Set inventory date" to today. Enter the callnumber range again.
Also set "Last inventory date" to today (important!).
Submit the form.
What do we expect now? Two items should be updated (see alert).
We should see barcode B3 with problem Missing. We should also see the
barcode from the other range (wrong place).
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 35b73aa3c6fb163f1389d30f0c175bec19696698)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit ba18e8e3bf173b07c4179cb1559fabc72b05f60a
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Mon Apr 3 15:16:42 2017 +0200
Bug 14399: Numerous small refinements to the inventory script
This patch contains the following changes:
[01] Label "Inventory date" reworded to "Last inventory date", adding a
small explanation for its purpose.
[02] Restructured the results: it was an array with items and possible
error messages. Multiple messages duplicated individual items. Now the
results are in a hash, pulling all error messages for one item together.
At the end of the script they are copied to an array. (A helper sub
additemtoresults is added in this regard.) We no longer use array
@items_with_problems.
[03] Both datepickers are no longer connected to the same class. This
prevents changing the set date by filling the last inventory date.
[04] Input markseen in the template and $markseen in the script are
no longer needed.
[05] The paragraph before the detail link in the results table in the
Title column has been removed. Same for problems column. This makes
vertical spacing consistent.
[06] Problem status 'missingitem' is no longer used; the missing items
are marked as 'not_scanned'. Two additional statuses are: no_barcode and
checkedout.
[07] Removed unused $itemtype, $totalrecords and $count. We use variable
$moddatecount to report a count to the template.
[08] The script updated scanned items twice. The first time with ModItem
and the second time with ModDateLastSeen. The second call is removed.
[09] If a book is checked in, we do no longer return an error message when
the checkin is successful (ERR_ONLOAN_RET). The updated datelastseen is
passed to the results.
[10] $wrongplacelist is renamed to $rightplacelist. It is only built when
we need it. (Same for inventorylist now.)
[11] Datelastseen (last inventory date) is always used for building the
inventory list. It allows you to process partial barcode lists or make
a list of items not seen after some date. We do no longer use variable
$paramdatelastseen.
[12] The section where items.datelastseen was compared with the inventory
date has been removed. Scanned items were already updated; to get items
seen before some date, you can now use last inventory date without passing
barcodes.
The form can mainly be used for the following three cases:
[1] Prepare an inventory list or csv file; we do not upload barcodes.
[2] Update items for uploaded barcodes without comparing to inventory.
Last inventory date is useless in this case.
Errors wrongplace, checkedout and changestatus are reported.
Use this scenario for partial scanned barcode lists (all but last).
[3] Update items for uploaded barcodes and compare to inventory, filtered
by an optional last inventory date.
Apart from the errors mentioned under [2], this also reports
not_scanned ("missing") and no_barcode.
Use this scenario too for the last partial barcode file (together with
inventory date).
Test plan:
See next patch ("Interface changes").
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 6da97c7c8713bb16cbf6cf079df18534c3661414)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit 26977379950beb656e818b7f91cf86eff1af141f
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Mon Apr 3 13:05:13 2017 +0200
Bug 14399: Prevent display of double zero notforloan status
On bug 12913 a zero status is added on the inventory form. This prevents
a lot of false warnings for a wrong notforloan status. The zero status
is not included in the default setup. But if you would add one, the
status will display here twice now.
This patch checks if the status already exists.
Test plan:
[1] Add a zero NOTFORLOAN status if it does not yet exist in Authorized
values.
[2] Check that you do not see two "For loan" statuses on inventory form.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit e162c4d526e042c4b382629a7aec880dcfced346)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit a4e1c502726a23c31f7c2084577b30aa376b3124
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Wed May 24 01:54:02 2017 -0400
Bug 5395: Update C4::Acquisition::SearchOrders POD
Comparing the perldoc to the function:
- basketname
- basketgroupname
- budget_id
Were missing. This adds them.
Also, a description of ordernumber and search were
added, as they are not self-evident by their name
alone.
There are no code changes, so all tests should pass
or fail identically before and after patch.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Fixed typo basetgroupname
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 8ed599113c7592ec2e2227e3a7265a7e9cc9ca0e)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit 1f2bf282bf29bbc1fd4ed8f15e9217573543dc0e
Author: David Cook <dcook at prosentient.com.au>
Date: Thu May 25 14:37:21 2017 +1000
Bug 18669 - RewriteCond affecting wrong rule in koha-httpd.conf
One of the RewriteCond directives in koha-httpd.conf was affecting
the wrong RewriteRule after its original RewriteRule was commented out
years ago.
_TEST PLAN_
0) Before applying patch, build Koha from source
*) make
*) make install (or make upgrade)
*) Copy or symlink etc/koha-httpd.conf to your Apache vhost directory
(and enable if you're on a Debian based system)
*) Restart Apache
1) Make sure that you have at least 1 bibliographic record in Koha
(URL like this http://server:port/cgi-bin/koha/opac-detail.pl?biblionumber=1)
2) Go to http://server:port/bib/1
3) Note that you get a 404 error
4) Apply the patch
5) Rebuild Koha from source as per step 0
6) Go to http://server:port/bib/1
7) Note that you now see the same page as you would if you went to
http://server:port/cgi-bin/koha/opac-detail.pl?biblionumber=1
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 9026169a235aa8133660ef649d98d8cedc5a4692)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit bebe91bafbb84381fea8b920665df117536e4651
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri May 26 10:25:10 2017 +0200
Bug 18611: [QA Follow-up] Add unit test for GetItemNumbersFromImportBatch
Test plan:
Run t/db_dependent/ImportBatch.t
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 01e7523dfb1ec9789f38dd6d7819cb5e3d7d7cc2)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit dfc043a6495e6426a950a2779bf688c5f95aabe5
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri May 26 10:20:00 2017 +0200
Bug 18611: [QA Follow-up] Make SQL query more readable
Make it more explicit by adding join statements.
Test plan:
See next patch for adding a unit test.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit b37df275b85114ccd23986d94af7ed21544269e6)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit fac99c82ccbbc3462d0a8bead681ab9d1c19fa57
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Tue May 23 11:03:04 2017 +0000
Bug 18611 - Followup, remove tabs to make qa tools happy
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 092f02d227417ac9786e23651ab13fbd566589c8)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit ed4946ad4027e5a0da62e7f67387bd446d75d920
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue May 16 05:40:28 2017 -0400
Bug 18611 - Create labels action fails in manage-marc-import.pl if an item has been deleted from the import batch.
To test:
1 - Import a batch with some items
2 - Delete one of the imported items
3 - Browse to Tools->Staged MARC record management
4 - Click (Create label batch) for the batch you imported
5 - Recieve an error
6 - Apply patch
7 - Click (Create label batch)
8 - Batch is created with remaning items from the import
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 7249351f120f3bd02d7f7829af10bd89cae490dc)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit 134554f448b4a09210edbb65520d7d95163ccde5
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Mon Jun 5 14:38:20 2017 +0200
Bug 18600 - DBRev 16.11.00.002
commit d4a7949c0466c3bd6900a93aa61c69e0e3469ec8
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue May 23 16:16:39 2017 -0300
Bug 18600: Add pref TalkingTechItivaPhoneNotification if missing
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit ec4b976289d68b4122f081f05ff7a7a023a32580)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit ae368a3eaaa70cf3f677ba49d5cb5ad21b72cafa
Author: LeireDiez <leire at scanbit.net>
Date: Thu May 11 17:09:22 2017 +0200
Bug 18204 - Authority searches are not saved in Search history
When you search an authority in Authority search, this search is not saved in Search history.
EnableOpacSearchHistory is enabled
Steps to test:
1- Login your account (opac)
2- Search an authority in Authority search
3- Go to Search history -> Authority
4- It says "Your authority search history is empty"
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit d4e3e6af9fd054dc64844be49e8d1a0f28b545bd)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit bb9df1e552996eccb4e3fd650e7cc214a7b55720
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue May 23 14:10:20 2017 -0300
Bug 16295: Fix access to MMT admin page
There was a typo in the permission code
Test plan:
Try to access the marc modification templates admin page with the
marc_modification_templates permission (and not all tools permissions)
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit d046474805b065f7419fefb06902d6ae18a0cd29)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit d88b51691bd3225f909cee961299807495d873a4
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Mon Jun 5 14:26:35 2017 +0200
Bug 18663 - DBRev 16.11.00.001
commit b74de73f5521bb416edea9b7123eb3088f5e7e04
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue May 23 16:16:17 2017 -0300
Bug 18663: Add pref ExportRemoveFields if missing
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 6f29c775d92d72bd03188efea4a41b3fbb49e928)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit ae71ae912e7e8b714e7bf23130fb3acf492048d2
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri May 26 11:45:31 2017 -0300
Bug 15465: Fix typo in bugs.k-c.org
(cherry picked from commit 0b7c517bfe9c76b0e40f25f1fa5b1f3cf7a00dd3)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit 873aca09ae4bb96fd4dd44e1a8034701a43aedb9
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Fri May 5 10:23:23 2017 +0000
Bug 18548: Print usage when missing instance name in koha-create script
Test plan:
1. Run: debian/scripts/koha-create --request-db
-> Without patch you see the getent error message
-> With patch you see usage and "Missing instance name" message
Signed-off-by: Dilan Johnpulle <dilan at calyx.net.au>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit d2ed4fadc59260372baedab038d16bd7cb169b1c)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit 8ebbefed7323b303407dc972098a5ef1bd69c518
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri May 12 09:38:37 2017 -0400
Bug 18569 - Quick add patron will not copy over details from cities and towns pull down into patron details
Followed test plan and the city value updates in the quick add form correctly.
Signed-off-by: Dilan Johnpulle <dilan at calyx.net.au>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit e609679eb278383f573eda78048f8fa107ae159b)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit df74913f2e9cb5c2cb533f15c1ac4575054cdc57
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu May 18 22:00:44 2017 -0400
Bug 18598 - Quick add form doesn't clear values when switching
To test:
1 - Fill out some fields in quick add
2 - Switch to full form and clear fields
3 - Switch back and fields are still populated
4 - Fill a field in long form
5 - Switch to quick add and clear it
6 - Save
7 - Value set in 4 is saved
8 - Apply patch
9 - Repeat 1-6 - values should be cleared and not saved
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit c762cd827e0a80960f3b23513981a382025b3bee)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit 00549f22cd049817ee6ef996d430fc04190ac1a3
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri May 12 09:18:45 2017 -0400
Bug 18596 - Quick add form duplicating password confirm
To test:
1 - Add password to BorrowerMandatoryField
2 - View quick add form
3 - See confirm password twice
4 - Apply patch
5 - See confirm password once
6 - Add password to QuickAddFields
7 - Confirm one confirm field
8 - Remove password form BorrowerMandatory field
9 - Confirm there is one confirm field and password fields are not
required
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 3e5dbef9ef18e0eaadfff9c7d7b5838aec75fb36)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit 54d42d3465c42d4c72a64336a162f31c79d35a9f
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Tue May 23 14:31:01 2017 +0200
Bug 18647: Resolve internal server error on category_type
See bug 18552. When we resolved the housebound_role bug, the hash got
filled correctly again. And this revealed that the (second) call to
Koha::Patrons->find was not appropriate. It can be removed, as Jonathan
explained on the report.
Note: Commit 95429af6855e8ed37945b681dc466bf360deffb added this call, but
it was hidden until the template variable hash got fixed.
Test plan:
Restart Plack and go to patron details again.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 87bb59304e53755d7b4565c517578a838e1f0041)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit 21d8f726fa205b4b31f9a3b7f17227688a6b3449
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri May 19 12:22:03 2017 +0200
Bug 18552: [16.11.X] [QA Follow-up] Resolve warnings
Like:
Problem = a value of AutoResumeSuspendedHolds has been passed to param without key at /usr/share/koha/masterclone/C4/Templates.pm line 137.
Problem = a value of relatives_borrowernumbers has been passed to param without key at /usr/share/koha/masterclone/C4/Templates.pm line 137.
Problem is functions returning undef in list context (in this case
housebound_role).
No need to call Patrons::find a second time.
Note: The call of GetDebarments in the first patch suffered from this too.
It is in a fine place now too. But strictly speaking, should not have been
moved.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit ed66ddc018d0b8286e9b339b3e253f940f172c59
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Thu May 18 23:10:13 2017 +0000
Bug 18552: [16.11.X] Borrower debarments not showing on member detail page
To test:
1) Go to a borrowers details page and create a manual restriction
2) Notice the restriction shows at the top of the page but the
restriction tab says the member is currently unrestricted
3) Apply patch and refresh page
4) Restrictions tab should now correctly show debarments and correct
number is shown
5) Confirming deleting and adding restrictions still works as expected
Sponsored-by: Catalyst IT
Followed test plan, works as expected
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
-----------------------------------------------------------------------
Summary of changes:
C4/Acquisition.pm | 9 +-
C4/ImportBatch.pm | 25 ++-
C4/Letters.pm | 8 +
Koha.pm | 2 +-
Koha/Item.pm | 14 ++
Koha/Template/Plugin/AuthorisedValues.pm | 2 +-
README.md | 2 +-
acqui/addorderiso2709.pl | 7 +-
course_reserves/add_items.pl | 19 +-
debian/scripts/koha-create | 2 +
etc/koha-httpd.conf | 6 +-
installer/data/mysql/updatedatabase.pl | 22 +++
koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 6 -
.../prog/en/includes/patron-search.inc | 9 +-
.../en/modules/course_reserves/add_items-step2.tt | 4 +-
.../en/modules/course_reserves/course-details.tt | 2 +-
.../prog/en/modules/members/member.tt | 4 +-
.../prog/en/modules/members/memberentrygen.tt | 8 +-
.../prog/en/modules/tools/inventory.tt | 115 +++++++----
koha-tmpl/intranet-tmpl/prog/js/members.js | 13 +-
members/moremember.pl | 17 +-
opac/opac-authorities-home.pl | 2 +-
t/db_dependent/ImportBatch.t | 29 ++-
t/db_dependent/Koha/Items.t | 10 +-
t/db_dependent/Template/Plugin/AuthorisedValues.t | 71 +++++++
tools/inventory.pl | 204 +++++++++-----------
tools/marc_modification_templates.pl | 2 +-
27 files changed, 397 insertions(+), 217 deletions(-)
create mode 100644 t/db_dependent/Template/Plugin/AuthorisedValues.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list