[koha-commits] main Koha release repository branch master updated. v17.05.00-54-g61f556d
Git repo owner
gitmaster at git.koha-community.org
Mon Jun 5 22:57:52 CEST 2017
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 61f556d47d37e677411200ed29e12118d73f482c (commit)
via 5abcef4f54269a0c39eb6852795d4b6350ad30f1 (commit)
via b237b4f34785286e844cc7aedf82dfbebb5c3438 (commit)
via 92c0ea7d76323b03d1fc089e8770b604eeccbcb6 (commit)
via 57469b3b19d23ac5b8e6c67a72278c505eeba1b4 (commit)
via c1f42859b54dfbfb06316826375b4608bdc3fefb (commit)
via 8bf72439c0e20c5fa8f3f735ebc36b04ec6a749f (commit)
via 617988a7c10d5807f1d2be3b026a30466adb0b33 (commit)
via 1985e6e4b3bd5fafe685b1a1e4874ea239f44261 (commit)
via fb3654077ff7331c71c033ddcedfe576fd8d7e28 (commit)
via 70ae3a9dc26bb0af8567431c3e0e5d236a527103 (commit)
via 71c75f4773015ffe36811b6d5de6b995ccf7a2f3 (commit)
via b5b1d3282e52427b16f1133742908ed27b28ea80 (commit)
via 149d8a6ec2413fc59a8bb51d520adec49b46bbe5 (commit)
from dd9da3e8f64ac4eb8fde5a1a58e0d692542ce2e6 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 61f556d47d37e677411200ed29e12118d73f482c
Author: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Date: Thu Mar 16 21:28:08 2017 +0200
Bug 18289 - Fix t/Prices.t having a Test::DBIx::Class cache issue
REPLICATE ISSUE:
perl t/Prices.t -> fails
AFTER THIS PATCH AND DEPENDENCIES:
perl t/Prices.t -> OK
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 5abcef4f54269a0c39eb6852795d4b6350ad30f1
Author: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Date: Thu Mar 16 21:26:36 2017 +0200
Bug 18288 - Fix t/SocialData.t having a Test::DBIx::Class cache issue
REPLICATE ISSUE:
perl t/SocialData.t -> fails
AFTER THIS PATCH AND DEPENDENCIES:
perl t/SocialData.t -> OK
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit b237b4f34785286e844cc7aedf82dfbebb5c3438
Author: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Date: Thu Mar 16 21:17:24 2017 +0200
Bug 18287 - Fix t/Koha.t having a Test::DBIx::Class cache issue
REPLICATE ISSUE:
perl t/Koha.t -> fails
AFTER THIS PATCH AND DEPENDENCIES:
perl t/Koha.t -> OK
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 92c0ea7d76323b03d1fc089e8770b604eeccbcb6
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Jun 5 17:32:43 2017 -0300
Bug 18226: Perltidy + license
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 57469b3b19d23ac5b8e6c67a72278c505eeba1b4
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed May 24 14:14:50 2017 +0200
Bug 18226: [QA Follow-up] Remove verbose
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c1f42859b54dfbfb06316826375b4608bdc3fefb
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed May 24 14:10:29 2017 +0200
Bug 18226: [QA Follow-up] Remove further assumptions on branch count
See also follow-up on bug 18286.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 8bf72439c0e20c5fa8f3f735ebc36b04ec6a749f
Author: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Date: Tue Mar 7 18:56:29 2017 +0200
Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code duplication
Is 'instantiations' even a word?
Use a Test::DBIx::Class defaults instead.
Save your keyboard and prevent horrible bugs from emerging from rampant code duplication.
This change doesn't seem to have any impact on the speed of executing those tests.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 617988a7c10d5807f1d2be3b026a30466adb0b33
Author: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Date: Wed Mar 8 17:34:28 2017 +0200
Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code duplication. Replace mock_dbh 2
Couldn't make the tests pass using Test::DBIx::Class, so reverted to the "usual way" since these tests are
in db_dependent anyway.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 1985e6e4b3bd5fafe685b1a1e4874ea239f44261
Author: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Date: Tue Mar 7 19:19:52 2017 +0200
Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code duplication. Replace mock_dbh 1
t/00-load.t already checks if all of the perl modules can be compiled.
The tests deleted in this commit do a duplicate test with t/00-load.t
Hence they have become unnecessary.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit fb3654077ff7331c71c033ddcedfe576fd8d7e28
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Tue May 2 16:18:41 2017 +0200
Bug 18286: [Follow-up] Remove assumption on branch count
A test in db_dependent should not make assumptions on the number of
branches in the database. If you need one, create one. Removing the
assumption of a non-zero count.
Removing the library count statement outside the subtest.
Replacing C4::Context by Koha::Database.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 70ae3a9dc26bb0af8567431c3e0e5d236a527103
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Tue May 2 15:46:08 2017 +0200
Bug 18286: [QA Follow-up] Fix some warnings from qa tools
[1] Resolve warning on variable assignment before use strict.
[2] Remove unused $schema variable.
[3] Remove eval expression construction.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 71c75f4773015ffe36811b6d5de6b995ccf7a2f3
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Tue May 2 15:44:47 2017 +0200
Bug 18286: [Follow-up] Add t/etc/schema.pl
We need this file here already.
Copied from bug 18226 and adjusted in order to keep qa tools quiet.
Test plan:
Run t/db_dependent/01-test_dbic.t again.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit b5b1d3282e52427b16f1133742908ed27b28ea80
Author: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Date: Thu Mar 16 21:08:31 2017 +0200
Bug 18286: Test::DBIx::Class connection/schema is shadowed by a cached connection/schema
If Koha::Database->schema gets called before
use Test::DBIx::Class
The DB connection from $KOHA_CONF is cached.
This happens most of the time because when C4::Context and friends are loaded
(in compile-time?), they already access the DB.
After Test::DBIx::Class is instantiated and hooks put in place to overload
Koha::Schema connection, those hooks are never called due to getting the old
connection from cache.
This feature introduces a test case to replicate the behaviour and shows how
flushing the connection cache solves the problem.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 149d8a6ec2413fc59a8bb51d520adec49b46bbe5
Author: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Date: Thu Mar 16 20:59:35 2017 +0200
Bug 18285: Koha::Database schema cache accessors
Safe way of getting and flushing the $database->{schema} -cache.
This is needed by Test::DBIx::Class to overcome pre-initialization connection
caching from C4::Context and others.
See Bug 18286.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
-----------------------------------------------------------------------
Summary of changes:
Koha/Database.pm | 17 +++++
t/00-load.t | 2 +-
t/Auth_with_shibboleth.t | 2 +-
t/Biblio.t | 8 +--
t/Breeding.t | 28 --------
t/Calendar.t | 7 +-
t/Images.t | 7 +-
t/Koha.t | 8 +--
t/Letters.t | 7 +-
t/Matcher.t | 7 +-
t/Members/cardnumber.t | 2 +-
t/Members_AttributeTypes.t | 7 +-
t/Message.t | 29 --------
t/NorwegianPatronDB.t | 7 +-
t/Overdues.t | 29 --------
t/Patron.t | 2 +-
t/Prices.t | 8 +--
t/RotatingCollections.t | 29 --------
t/Search.t | 2 +-
t/SocialData.t | 8 +--
t/SuggestionEngine_AuthorityFile.t | 2 +-
t/XSLT.t | 15 +---
t/db_dependent/01-test_dbic.t | 110 ++++++++++++++++++++++++++++++
t/db_dependent/Circulation/CalcDateDue.t | 40 +++++------
t/db_dependent/Context.t | 2 +-
t/db_dependent/Sitemapper.t | 7 +-
t/etc/schema.pl | 9 +++
t/lib/Mocks.pm | 9 ---
28 files changed, 177 insertions(+), 233 deletions(-)
delete mode 100755 t/Breeding.t
delete mode 100755 t/Message.t
delete mode 100755 t/Overdues.t
delete mode 100755 t/RotatingCollections.t
create mode 100644 t/db_dependent/01-test_dbic.t
create mode 100644 t/etc/schema.pl
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list