[koha-commits] main Koha release repository branch 17.05.x updated. v17.05.00-13-g14e84e4

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.05.x has been updated
       via  14e84e422ee5c454e2bce341a124330b047deb63 (commit)
       via  c31db771b38053867369fd5833f0b4f1ee7e9b0d (commit)
      from  14e8f5bb713bd4f45a85f028e0c9b5738f3eefd5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 14e84e422ee5c454e2bce341a124330b047deb63
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue May 9 15:56:32 2017 -0300

    Bug 17944: QA follow-up
    
    - Remove an unused use statement
    - Fix pod
    - Use snake_case
    - Fix test "An itemtype cannot be deleted if and only if there is
    biblioitem linked with it"
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 6d76f61a6b0b6b429246c5a9398ec55f97d98027)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit c31db771b38053867369fd5833f0b4f1ee7e9b0d
Author: Alex Buckley <alexbuckley at catalyst.net.nz>
Date:   Sun Jan 22 01:52:50 2017 +0000

    Bug 17944 - Add Koha::ItemType->can_be_deleted and use it from admin/itemtypes.pl
    
    Removed the sql code from Itemtypes.pm and replaced  it with DBIx
    database query in the itemtypes.pl administrative script
    
    Test plan:
    1. In the staff interface, stage and manage MARC records for import
    
    2. Try to delete an itemtype. If there are items of that itemtype in the
       database then a message telling you the number of items of that
       itemtype there are will be displayed.
    
    3. Record that number
    
    4. View the admin/itemtpes.pl script and confirm that there is sql code
       written in this file.
    
    5. Apply this patch
    
    6. View the admin/itemtypes.pl script and observe that there is no sql
       in this file. There is however DBIx code, for example
       $schema->resultset('Item')->search({ 'itype' => $itemtype_code} );
       which is searching for items with the itype value matching
       $itemtype_code value.
    
    7. In the staff interface try to delete the same itemtype
    
    8. Record the number of items there are with that itemtype in the
       resulting message
    
    9. The numbers recorded in steps 3 and 8 should match showing that the
       DBIx code is working as intended
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit db3ebe47e859e85659b1a2565a03bcb6b59df0ff)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/ItemType.pm                                   |   17 ++++++++++++++
 admin/itemtypes.pl                                 |   24 +++++++-------------
 .../prog/en/modules/admin/itemtypes.tt             |    2 +-
 t/db_dependent/Koha/ItemTypes.t                    |   20 +++++++++++++++-
 4 files changed, 45 insertions(+), 18 deletions(-)


hooks/post-receive
-- 
main Koha release repository