[koha-commits] main Koha release repository branch master updated. v17.05.00-72-g8d22702
Git repo owner
gitmaster at git.koha-community.org
Fri Jun 9 17:48:07 CEST 2017
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 8d2270254187b7d876d466860a76fd231b9549c2 (commit)
via 6bb4a0405abe0d03be3915644c6a05e2e3ee1e9f (commit)
via 7c9273be169ca4da47059aa152f8c6ea11137a52 (commit)
via c35932923407e9ec088957f877e8607289b6b914 (commit)
via 78a9f39f9a97179af3e3a38cf8cb17b3f043d88a (commit)
via 6e7c125a56be8971ec9c9bb52373bff5004a936a (commit)
via f1d90f205e3dc8177c0d524b208d9d4a367cf56e (commit)
via 6a2ef935ac63c67a4b31d8c3eb9bcb8d974d844e (commit)
via eb0a67ea10c9210dbfb42f810c280b7515b04a16 (commit)
from e426da4e009ce63c10923eaddd1ca271dca8005e (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 8d2270254187b7d876d466860a76fd231b9549c2
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Wed Jun 7 11:29:46 2017 +0200
Bug 18741: Fix loading of SQL files in web installer
Test plan:
1. Start a normal install using the web installer
2. When asked to select data to load, verify that
'message_transport_types' is checked, and check some optional data
files
3. Continue the install to the end
4. Verify that message_transport_types is not empty, and that the
optional data you checked is there
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 6bb4a0405abe0d03be3915644c6a05e2e3ee1e9f
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Wed May 31 16:10:41 2017 +0200
Bug 18706 - Remove useless Javascript
Whe checking a subfield to be deleted, the code
$(this).val($(this).siblings("[name='subfield']").val());
is useless, the checkbox already contains the subfield code :
<input type="checkbox" ... name="disable_input" value="[% ite.subfield %]" />
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7c9273be169ca4da47059aa152f8c6ea11137a52
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Wed May 31 16:02:44 2017 +0200
Bug 18706 - subfields to delete not disabled anymore in batch item modification
In Tools > Batch item modification, one can click a checkbox to delete a subfield.
This click use to disable the input to change the field value.
This comes from the patch : Bug 13501: Move "Required" and checkbox after input/select
Because input is found using JQuery next().
This patch replaces with $(this).parent().find("[name='field_value']").
Test plan :
- Go to Tools > Batch item modification
- Enter a barcode and submit
- Click on a checkbox on a non-mandatory subfield
=> Without patch the input or select is not disabled
=> With patch the input or select is disabled
- Submit
=> Check that subfield is deleted
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c35932923407e9ec088957f877e8607289b6b914
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Jun 1 23:52:07 2017 -0300
Bug 18716: Remove CGI::param warns from updatesupplier.pl
This script floods the logs with this kind of warnings.
To test:
- Run:
$ koha-plack-err
- Edit a vendor in the acquisitions module
- Save
=> FAIL: Logs show lots of warnings that look like:
CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_acqui_updatesupplier_2epl
- Apply this patch
- Run:
$ restart_all
$ koha-plack-err
- Edit a vendor, add/delete vendor contacts
=> SUCESS: No more warnings
- Verify editing and storing vendor contacts works as expected.
- Sign off :-D
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 78a9f39f9a97179af3e3a38cf8cb17b3f043d88a
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Jun 9 11:16:08 2017 -0300
Bug 18767: Remove useless diags from GetDailyQuote.t
This tests print useless debugging info.
To test:
- Run:
$ sudo koha-shell kohadev
k$ cd kohaclone
k$ prove t/db_dependent/Koha/GetDailyQuote.t
=> FAIL: Some output telling what is doing on each step is printed.
- Apply the patch
- Run
k$ prove t/db_dependent/Koha/GetDailyQuote.t
=> SUCCESS: No output, YAY!
- Sign off :-D
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 6e7c125a56be8971ec9c9bb52373bff5004a936a
Author: Marc Véron <veron at veron.ch>
Date: Mon Jun 5 06:52:58 2017 +0200
Bug 18727: System preferences loose part of values because of double quotes
System preferences do not display values of text fields properly if they
contain doulbe quotes.
To recreate:
- Go to Home > Administration > System preferences , then tab Acquisitions
- Enter values to both system preferences like proposed in the example (o=5|a="bar foo" and o=5|a="foo bar")
- Save
- Click on tab Acquisitions to reload
- Wrong result: Both preferences show a value of: o=5|a=
(parts with double quotes are truncated)
- Edit any of the email addresses (Bug 9814):
KohaAdminEmailAddress, NoticeBcc, ReplytoDefault, PayPalUser
- Set value to: "The Library" <thelibrary at example.com>
- Search for this email address syspref to re-display it
- Wrong result:
Use [ ] " autocomplete="off" /> as the email address for the
administrator of Koha.
To test:
- Apply patch
- Try to recreate issues above
- Additionally, edit other system preferences that could contain double
quotes, e.g. LibraryName or UsageStatsLibraryName
- Set value to: Bibliothek "Zur Leseratte"
(Note: patch contains a tiny fix for a typo in acquisitions.pref)
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f1d90f205e3dc8177c0d524b208d9d4a367cf56e
Author: Marc Véron <veron at veron.ch>
Date: Sun Jun 4 18:04:00 2017 +0200
Bug 18689: calendar error with double quotes in title or description of holiday
This patch fixes the calendar display with holidays having double qoutes in
title or description.
To test:
- Apply patch
- Go to Home > Tools > Calendar
- Create new holidays of each type (Day only, repeated wekly/yearly,
range, yearly repeated range and enter double qoutes in their titles and
descriptions
- Verify that calendar displays and works as expected
- Verify that you can edit the holidays
Signed-off-by: Lee Jamison <ldjamison at marywood.edu>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 6a2ef935ac63c67a4b31d8c3eb9bcb8d974d844e
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Mon Jun 5 11:20:18 2017 +0000
Bug 18722: Fund name is not shown in received orders fund subtotals
Test plan:
1) Go to acquisition and receive some orders
2) Show the receive summary for invoice
--> without patch, the fund name in subtotal is not shown
--> with patch the name is shown as expected
Signed-off-by: Michael Cabus <michael at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit eb0a67ea10c9210dbfb42f810c280b7515b04a16
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Mon Jun 5 12:24:07 2017 -0400
Bug 18730: Batch Mod Edit <label> HTML validation fails
[tag] [reply] [−] Description M. Tompsett 2017-06-05 16:30:21 UTC
Know the barcode of an existing item.
Home -> Tools -> Batch Item Modification
Enter the barcode
Click
View Page source
select and copy it into validator.w3.org direct input.
There will be complaints about <labels>.
Apply this patch
refresh the page.
select and copy it into validator.w3.org direct input.
There will be no complaints about <labels>.
This is intended to be a highly focused HTML bug, as the
missing form tag which will fix the <div> issues at the bottom
is corrected on bug 18710.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
-----------------------------------------------------------------------
Summary of changes:
acqui/updatesupplier.pl | 2 +-
installer/install.pl | 2 +-
.../intranet-tmpl/prog/en/modules/acqui/parcel.tt | 2 +-
.../prog/en/modules/admin/preferences.tt | 2 +-
.../en/modules/admin/preferences/acquisitions.pref | 2 +-
.../prog/en/modules/tools/batchMod-edit.tt | 15 ++++++-------
.../prog/en/modules/tools/holidays.tt | 9 ++++----
t/db_dependent/Koha/GetDailyQuote.t | 23 +++++++++++++++-----
8 files changed, 33 insertions(+), 24 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list