[koha-commits] main Koha release repository branch 16.11.x updated. v16.11.08-46-gab75a49
Git repo owner
gitmaster at git.koha-community.org
Mon Jun 12 00:58:11 CEST 2017
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 16.11.x has been updated
via ab75a49507a676ce982f213dc86b035df04a1dfb (commit)
via 5d30c9517d34912a1b83c02685391d417c9af019 (commit)
via f702610405093b394dac2e625a1e9516593573dd (commit)
via 46a1886b6937ac2bf7f909200f47750e571a8170 (commit)
via 1ead1f2b4919729dbf6501f85c12fc5e861b848d (commit)
via e0f4ede153fe2e1cb9d319eea9dc589815e3b101 (commit)
via 80598882305e81fab3eb321f163c5a3ee838bb8e (commit)
via 64f2624d58e2b1ac51e376abcb48c78c3afc3556 (commit)
via de656a7b5cf80fa83ab37ffb71c6d8c0b6c73d9c (commit)
from 1da486da8987ce92299b2fdc8dd43bb1963ed6c4 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit ab75a49507a676ce982f213dc86b035df04a1dfb
Author: Marc Véron <veron at veron.ch>
Date: Sun Jun 4 22:09:14 2017 +0200
Bug 13747: Fix problems with frequency descriptions containing quotes
If a serial frequency description contains quotes or is surrounded by
quotes, the description is empty ("TEST" > empty) or shown without the
quotes part (TEST "sth" > TEST) on editing the frequency.
To verify:
- Create a new frequency with description: "Test"
- Modify frequency
- Verify the description field is empty
To test:
- Apply patch
- Try to recreate, verify that the description field is
correctly filled when editing
- Test also with a name like: 'A "souble quoted" name'
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit 16307c40343cdb0ed4ff69c9c001fc4d9e1a459f)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit 17df2459ddc294eb2499fce6d9f6f32d20e6db67)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit 5d30c9517d34912a1b83c02685391d417c9af019
Author: Marc Véron <veron at veron.ch>
Date: Tue May 23 07:08:41 2017 +0200
Bug 18653: Possible privacy breach with OPAC password recovery
OPAC password recovery allows to find out which email address belongs to an account. An attacker could systematically guess login names. If they hit an existing one, OPAC displays a message like:
An email has been sent to "xxx at yyy.zz".
Having a combination of login name and email, attackers could use the information e.g. for phishing or other personalized actions.
To reproduce:
- Enable OPAC password recovery (syspref OpacResetPassword)
- 'Guess' a login name e.g. by using a common pattern like ptester for Peter Tester
- If such account exists, you get to know the related email address
This patch removes the email address from the success message. Additionaly, it changes
wording to address Bug 18570 ('will be sent' instead of 'has been sent')
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Simplified the wording. "Will be sent shortly" is used elsewhere too.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit eddf975cf0244c731f987c64af5126090f73f9f2)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit 2d1dad1a4afa1bfaa14715b7953ed8265dbdb398)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit f702610405093b394dac2e625a1e9516593573dd
Author: Owen Leonard <oleonard at myacpl.org>
Date: Sat Apr 29 17:14:10 2017 +0000
Bug 13913 - Renewal error message in OPAC is confusing
This patch adds some formatting to the error message a patron receives
when there are renewal failures in the OPAC.
This is pretty much the least which could be done to address this
problem. However, I don't think the issue can be fixed without
re-thinking how renewals are processed. Sending error messages back to
opac-user.pl via URL parameter isn't flexible enough.
To test, apply the patch and attempt to renew multiple items in the OPAC
which cannot be renewed for some reason, for instance because they have
been renewed too many times. The error messages should appear in a list
rather than strung together in one long block of text.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit 281e1253777d2bd635610075fe610bedb2d47360)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit 14e8f5bb713bd4f45a85f028e0c9b5738f3eefd5)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Changed borrower back to patron as it was before this patch.
commit 46a1886b6937ac2bf7f909200f47750e571a8170
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Tue May 2 01:08:02 2017 +0200
Bug 11122: Follow up - Fix some display issues and typos
This patch fixes the display of copyrightdate for MARC21 installations.
As MARC21 already requires you to add punctuation in cataloguing, there
is usually no need for punctutation in the templates.
Also fixes a template variable name typo and the basket summary page.
To test (all 3 patches):
- Add several order lines to an order, one should be uncertain
- Verify that the publisher and publication year are displayed
- Check the uncertain price page
- Verify that the publisher code and publication year are displayed
- Fix uncertain price and close your order
- Basket summary: Verify... (you know what)
- Cancel one of your orders
- Verify... for cancelled orders
- Receive shipment
- Verify... for unreceived orders
- Receive order
- Verify ... for received orders
- Finish receiving
- Verify ... on the invoice summary page
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit cbb5096934907ec56df27d6ee3e77d752cd5e401)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit 428467a0228429ba78020e9097ede7c43ad6d04e)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit 1ead1f2b4919729dbf6501f85c12fc5e861b848d
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Sun Apr 19 20:28:21 2015 -0400
Bug 11122: Address MARC21 vs. UNIMARC issue
In comment #6 and comment #17, Katrin pointed out the discrepancy
between UNIMARC (using publisheryear) vs. Other MARC installations
(using copyrightdate). This was dealt with in invoice.tt already.
This patch does similar logic for the other 3 template files.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit c470b3e38486e3c6040a10f6b0bf90af069f4566)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit 003e52896eeb74ca8c9d9ea253eff4f6022e52c0)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit e0f4ede153fe2e1cb9d319eea9dc589815e3b101
Author: Fridolyn SOMERS <fridolyn.somers at biblibre.com>
Date: Wed Oct 23 12:05:23 2013 +0200
Bug 11122 - publisher code and publication year not fetched in acq orders
In acquisition, several templates try to display publisher code and publication year : invoice.tt, parcel.tt, transferorder.tt.
Thoses pages use C4::Acquisition methods GetPendingOrders or GetInvoiceDetails.
The bug is that in the SQL query of those methods, biblioitems.publishercode and biblioitems.publicationyear.
In uncertainprice.pl those datas are fetch using GetBiblioData.
It whould be better to fetch them in GetPendingOrders and GetInvoiceDetails.
This patch changes SQL queries to fetch wanted datas : aqorders.*,biblio.title,biblio.author,biblioitems.isbn,biblioitems.publishercode,biblioitems.publicationyear. GetInvoiceDetails also needs : biblio.seriestitle,biblioitems.volume.
This patch also unifies the way biblio datas are displayed :
<a href="link to catalog using biblionumber">[title]</a> <em>by</em> [author] – [isbn]
<em>Publisher:</em> [publishercode], [publicationyear]
Test plan :
- Choose a biblio record containing a data in :
biblio.title,
biblio.author,
biblioitems.isbn,
biblioitems.publishercode,
biblioitems.publicationyear,
biblio.seriestitle,
biblioitems.volume.
- Create an order using this biblio.
- Look at this order in pages : parcel.pl, transferorder.pl, uncertainprice.pl
=> You see publisher code and publication year
- Look at this order in page : invoice.pl
=> You see publisher code, publication year, series title and volume
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit c59e395b749132080fefb81e5b12f8c0b6654665)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit 44a80fe0665c0d375faf6b5bded8a2fe96b5ff24)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit 80598882305e81fab3eb321f163c5a3ee838bb8e
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date: Tue May 30 15:17:58 2017 +0100
Bug 18700 Fix grammar (data cannot be pluralized)
data is a mass noun or plural of datum - datas is ungrammatical
and jarring for a native speaker.
Split the awkward sounding sentence into two for more clarity,
thanks to Marc Véron for the suggestion.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit 60b31a7a2219dea16f124684bd21e6d12a35c05a)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit ad741d2512e23746ceb009b2c0a7f57403ab3bb5)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit 64f2624d58e2b1ac51e376abcb48c78c3afc3556
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue May 30 16:55:19 2017 -0400
Bug 18704 - File types limit in tools/export.pl is causing issues with csv files generated by MS/Excel
To test:
1 - Save a csv of biblionumber from MS/Excel
2 - Attempt to export records using this file
3 - It fails (mimetype is appliction/vnd.ms-excel)
4 - Apply patch
5 - Try again
6 - It succeeds!
Signed-off-by: Jason Palmer <jpalmer at switchinc.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit ef6211b319b58b4c35e8cb8555e1caa4da9b2a8f)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit 283ccd4da55ce950cf7ace02688daf0db7c0e494)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit de656a7b5cf80fa83ab37ffb71c6d8c0b6c73d9c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Apr 18 13:50:36 2017 -0300
Bug 18179: Update existing calls
This patch updates the existing occurrences of ->find called in a list
context.
There are certainly others that are not easy to catch with git grep.
Test plan:
Confirm that the 4 modified scripts still works as expected.
We need this one ASAP in master to make sure we will not get other
side-effects of this kind and to catch possible uncaught occurrences
before the release.
Tested scripts changed by this patch, they work as expected.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
-----------------------------------------------------------------------
Summary of changes:
C4/Acquisition.pm | 3 +++
acqui/uncertainprice.pl | 20 ++--------------
.../intranet-tmpl/prog/en/modules/acqui/basket.tt | 6 +++--
.../intranet-tmpl/prog/en/modules/acqui/invoice.tt | 10 ++++----
.../intranet-tmpl/prog/en/modules/acqui/parcel.tt | 14 ++++++++++--
.../prog/en/modules/acqui/transferorder.tt | 7 +++++-
.../prog/en/modules/acqui/uncertainprice.tt | 19 ++++++++++++----
.../prog/en/modules/admin/admin-home.tt | 2 +-
.../en/modules/serials/subscription-frequencies.tt | 2 +-
.../bootstrap/en/modules/opac-password-recovery.tt | 2 +-
.../opac-tmpl/bootstrap/en/modules/opac-user.tt | 24 ++++++++++----------
members/memberentry.pl | 2 +-
opac/opac-user.pl | 2 +-
tools/export.pl | 2 +-
14 files changed, 63 insertions(+), 52 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list