[koha-commits] main Koha release repository branch master updated. v17.05.00-102-gad7ff09

Thu Jun 15 21:08:08 CEST 2017

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  ad7ff09b995e5275f2c6d664b31351321b1674af (commit)
       via  15cbf14f4d4f8039ad7820ce37da202b19e0075d (commit)
       via  8218f2b55c544ac9fbb29153f2b1727d75cae5d7 (commit)
       via  b28d25e9cd2939460c4b4043bafd7013e7248515 (commit)
       via  a740e773c6bfeb2b42945f16047b1f5dfba67af4 (commit)
       via  48f847025d2963c7d5583d46e27e59b28620e4b7 (commit)
       via  628d8391d29a59f7d6a0ecfb52081684cee81403 (commit)
       via  6906b848a78ad4c7d52c1e7c7ce195f08cc6d2a6 (commit)
       via  f97addef42826c0007f91cace1f365de358a8b60 (commit)
       via  f4c965781d82e9537015b695cc15677cd06d72cd (commit)
       via  a44f202fdb9c933e0b5ac88656e2c8f74e498023 (commit)
       via  25d28e7c8100c1993f8794e39ed135781de04a47 (commit)
       via  d0bf036c1828bbbd37a022f8449e217e8e269475 (commit)
      from  75a62e93922834dd511ee7eb1fbdd31f2006fe1d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit ad7ff09b995e5275f2c6d664b31351321b1674af
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Jun 15 15:46:17 2017 -0300

    Bug 18539: remove occurrence in ReNewSubscription.t

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 15cbf14f4d4f8039ad7820ce37da202b19e0075d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Apr 18 13:49:18 2017 -0300

    Bug 18539: Forbid list context calls for Koha::Objects->find

    Reading https://perlmaven.com/how-to-return-undef-from-a-function
    this sound like the more correct behaviour.

    Considering:
    $template->param(
        stuff => Koha::Stuffs->find( $id ),
        foo   => 1,
    );
    without this patch, if the $id does not represent any rows in the DB,
    stuff will be assigned to 'foo' and $foo will be undef in the template.
    That can lead to very bad side-effects.

    With this patch we make sure that it will never happen again.

    Test plan:
      prove t/db_dependent/Koha/Objects.t
    should return green

    Signed-off-by: Marc Véron <veron at veron.ch>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 8218f2b55c544ac9fbb29153f2b1727d75cae5d7
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Feb 27 08:59:53 2017 +0000

    Bug 17975: Let C4::Letters manage today param substitution

    The today parameter is properly handled from C4::Letters subroutines, we
    do not need to pass it from callers.

    Signed-off-by: Marc Véron <veron at veron.ch>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit b28d25e9cd2939460c4b4043bafd7013e7248515
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Jan 16 17:33:39 2017 +0100

    Bug 17975: TT syntax for notices - Prove that HOLD_SLIP is compatible

    Here we need to test <<today>>.
    We already pass a value, but it was wrong. We must pass a string, not a
    DateTime object, otherwise the KohaDates plugin will not display the
    hours part if we need it.

    Test plan:
    Define a HOLD_SLIP notice template to match your need.
    Do not forget to use
      [% today | $KohaDates %]
    or
      [% today | $KohaDates with_hours => 1 %]
    To access data from the reserves table, use the 'hold' variable

    Tested both patches together with several date formats, works as expected.
    Signed-off-by: Marc Véron <veron at veron.ch>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit a740e773c6bfeb2b42945f16047b1f5dfba67af4
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Jan 16 16:58:23 2017 +0100

    Bug 17965: TT syntax for notices - Prove that DUEDGST is compatible

    This notice template have the particular feature of using <<count>>.
    This value is substitued during the process of the notice template.
    For the TT syntax, all what we need is to send the values to substitute to the
    template.

    Note that items.content can also be used in these template, you can have
    a look at bug 17967 to see a better alternative to this marker.

    Test plan:
    Generate DUEDGST and DUE notice messages.
    You should be able to generate the same messages with the TT syntax.

    Signed-off-by: Marc Véron <veron at veron.ch>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 48f847025d2963c7d5583d46e27e59b28620e4b7
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Sun Mar 12 22:56:19 2017 -0300

    Bug 18254: Remove call to GetItemsByBiblioitemnumber call from additem.pl

    The code from additem to delete all the items of a bibliographic record
    is very ackward.
    This patch simplifies the algorithm and make the code more readable.

    Test plan:
    Remove all the items of a bibliographic records
    If at least 1 item is checked out you should get an error.

    No change with the current behavior is expected.

    Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 628d8391d29a59f7d6a0ecfb52081684cee81403
Author: Marc Véron <veron at veron.ch>
Date:   Thu May 18 20:02:33 2017 +0200

    Bug 18630: Translatability (Clubs): 'Cancel' is ambiguous and leads to mistakes

    The button to cancel a club enrollement is labelled with 'Cancel'. That is ambiguous and translates e.g. in German to 'Abbrechen' which can lead to
    mistakes.

    To test:
    - Apply patch
    - Enroll a patron to a club
    - Enable public enrollment in OPAC
    - Verify that the button to cancel enrollment in both OPAC and staff client
      reads 'Cancel enrollement' (instead of 'Cancel' without patch)
      (The button appears on the patron's detail pages in OPAC and staff client)

    Amended for comment #4 / mv

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 6906b848a78ad4c7d52c1e7c7ce195f08cc6d2a6
Author: David Cook <dcook at prosentient.com.au>
Date:   Wed Jan 11 15:36:05 2017 +1100

    Bug 17710 - C4::Matcher::get_matches and C4::ImportBatch::GetBestRecordMatch should use same logic

    C4::ImportBatch::GetBestRecordMatch uses SQL to sort by score descending
    then candidate_match_id descending. With C4::Matcher::get_matches, I
    implement the same sort but use Perl code to do it, since we're sorting
    search results.

    It's a simple change, but it's in a big block of code, so I don't have
    unit tests.

    Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit f97addef42826c0007f91cace1f365de358a8b60
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Mon Jun 5 18:18:07 2017 -0400

    Bug 18732: Noisy t/SMS.t triggered by koha_conf.xml without sms_send_config

    Upgraded systems may be lacking sms_send_config which makes t/SMS.t noisy.
    This silently bypasses the problem.

    Remove sms_send_config from your koha-conf.xml file
    prove t/SMS.t
    -- it will be noisy, but pass.
    apply patch
    prove t/SMS.t
    -- noise gone.
    run koha qa test tools.

    Signed-off-by: Lee Jamison <ldjamison at marywood.edu>
    Works correctly as indicated by the testing plan.
    No "uninitialized" noise after patch is applied.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Slightly amended: turned the iif around.

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit f4c965781d82e9537015b695cc15677cd06d72cd
Author: Marc Véron <veron at veron.ch>
Date:   Sun Jun 4 19:55:08 2017 +0200

    Bug 11235: Names for reports and dictionary are cut off when quotes are used

    To reproduce for saved reports:

    - Go to Home > Reports > Guided reports wizard
    - Create a report with double quotes in it's name, e.g. 'My "double quoted" report'
    - Go to "Saved reports", locate in the list the new report (name is correct here,
      is correct in database as well)
    - From the selection button at the right choose "Edit"
    - Result: Content of edit field for the report name is truncated (displays only: 'My')

    To reproduce for Reports dictionary:

    - Go to Home > Reports > Guided reports wizard
    - Create a new definition, give it the name 'The "double quoted" definition' and enter
      a text with double quotes for "Description"
    - Save
    - Verify that in the list of definitions both name and descriptions are truncated
      (in database as well)

    To test:
    - Apply patch
    - Verify that issues described above can no longer be reproduced

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit a44f202fdb9c933e0b5ac88656e2c8f74e498023
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Wed Oct 12 12:38:16 2016 +0200

    Bug 13452: Fix for plack

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 25d28e7c8100c1993f8794e39ed135781de04a47
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Fri Oct 2 11:31:10 2015 +0200

    Bug 13452: Fix obvious issues in issues_avg_stats.pl

    - Remove joins with issuingrules which are not needed
    - Fix the SQL query so that $weight is now the value of COUNT(*) instead
      of a timestamp
    - QA fix: '$column eq $itype' instead of '$column =~ $itype' (same for
      $line)

    Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit d0bf036c1828bbbd37a022f8449e217e8e269475
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date:   Tue Jun 9 01:04:07 2015 +0200

    Bug 13452: 'Average loan time' report to obey item-level_itypes preference

    Fixes the 'Average loan time' report so that the system
    preference setting item-level_itypes is taken into account.

    Before the patch, the report was always using the biblio
    level itemtype. With the patch, it will depend on the pref
    setting.

    To test:
    - Run various reports, compare results with both
      possible pref settings
    - Try limiting your search in various ways, especially
      on a specific itemtype
    - Make sure you switch checkboxes in testing,
      using itemtype as the row or as the column

    Notes:
    - Filtering on a specific itemtype on master was not working
      if the itemtype was chosen as column. The patch should fix that.
    - Fixes headings and breadcrumbs so that the name of the report
      is the same as on the reports start page

    Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg at gmail.com>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-----------------------------------------------------------------------

Summary of changes:
 C4/Letters.pm                                      |    6 +-
 C4/Matcher.pm                                      |    5 +-
 C4/Overdues.pm                                     |    1 -
 C4/Reserves.pm                                     |    1 -
 C4/SMS.pm                                          |   10 +-
 Koha/Objects.pm                                    |    2 +
 cataloguing/additem.pl                             |   55 ++++------
 .../prog/en/modules/clubs/patron-clubs-tab.tt      |    2 +-
 .../prog/en/modules/reports/dictionary.tt          |   74 ++++++-------
 .../en/modules/reports/guided_reports_start.tt     |    4 +-
 .../prog/en/modules/reports/issues_avg_stats.tt    |    4 +-
 .../bootstrap/en/modules/clubs/clubs-tab.tt        |    2 +-
 reports/issues_avg_stats.pl                        |   45 +++-----
 t/db_dependent/Koha/Objects.t                      |   12 ++-
 t/db_dependent/Letters/TemplateToolkit.t           |  114 +++++++++++++++++++-
 t/db_dependent/Serials/ReNewSubscription.t         |    4 +-
 16 files changed, 219 insertions(+), 122 deletions(-)

hooks/post-receive
-- 
main Koha release repository