[koha-commits] main Koha release repository branch master updated. v17.05.00-114-g4dd9236

Fri Jun 16 22:06:40 CEST 2017

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  4dd9236c6ebdfff33abcf97b6ea254ed1e63ffbe (commit)
       via  9fb5f8519f2937aa7db6b53d6501f09ada11db4f (commit)
       via  3b64ebe2346de50d2fa3745d0febb935b5cc8b75 (commit)
       via  0f105285910d6a14b44d7cd789475a144552a627 (commit)
       via  8035a467f0b5d8441d4164bc183286d4f2593438 (commit)
       via  08ab41aa9825e48f6321a90bf0bef09b572d4000 (commit)
       via  a88f540ec1a0f7e1f876f3811d0e44cb3ff3a612 (commit)
       via  943a3a5c3ab4df6337607e1e237ff4f059d23da4 (commit)
       via  e1afa469f8313144c70ae91d7efa356beb8168b8 (commit)
       via  e1f943b9992ea1a3c5d4659ca6fa787834d66376 (commit)
       via  de74a4e5a0ec0fcf85a42b637d07c2bcd81d63f0 (commit)
       via  ec288a50def5c4fdcd7b001087fed0b120e4a211 (commit)
      from  ad7ff09b995e5275f2c6d664b31351321b1674af (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4dd9236c6ebdfff33abcf97b6ea254ed1e63ffbe
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Tue Jun 6 08:09:19 2017 +0000

    Bug 18703 - Followup, fix typo "statment"

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

commit 9fb5f8519f2937aa7db6b53d6501f09ada11db4f
Author: Marc Véron <veron at veron.ch>
Date:   Tue May 30 20:44:30 2017 +0200

    Bug 18703 - Translatability: Resolve some remaining %%] problems for staff client in 6 Files

    There are some more files that expose parts of tt diretives to translations, mostly due to
    line breaks inside directives.

    Files covered with this Bug:

    koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc
     koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc
    koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc
    koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt
    koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt
    koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt

    To test:
    - Review code, verify that line breaks are removed
    - Run QA tools
    - Bonus test: Create a "language" aa-AA and verify that no fragments
      containign %%] are picked for the 6 files

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

commit 3b64ebe2346de50d2fa3745d0febb935b5cc8b75
Author: Marc Véron <veron at veron.ch>
Date:   Tue May 30 16:08:32 2017 +0200

    Bug 18699: Get rid of %%] in translation for edi_accounts.tt

    Translation for edi_accounts.tt exposes:
    [%% transport_types = [ 'FTP', 'SFTP', 'FILE' ] %%]

    Translators should not be confronted with such code internals.

    To test:
    - Review code change (it removes line breaks)
    - Bonus test: Create a new translatin for "language" aa-AA and
      verify that the line no longer appears in aa-AA-staff-prog.po

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

commit 0f105285910d6a14b44d7cd789475a144552a627
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Jun 16 17:00:23 2017 -0300

    Bug 18804: Add additional information to execute successfuly selenium tests

commit 8035a467f0b5d8441d4164bc183286d4f2593438
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Jun 14 13:08:43 2017 -0300

    Bug 18804: (bug 13501 follow-up) Fix add item form (select2)

    Hard to say here, select2 adds so many elements that we need to ignore.
    Here we just assume that input text with an id starting with
    tag_952_subfield must be filled

    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

    Signed-off-by: Lee Jamison <ldjamison at marywood.edu>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

commit 08ab41aa9825e48f6321a90bf0bef09b572d4000
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Jun 14 13:08:20 2017 -0300

    Bug 18804: (bugs 16400,11088 follow-up) Update the "save category" elt selector

    With bug 11088 and bug 16400 the submit node switched from:
      <input type="submit" name="save" onclick="return check_form_borrowers();" value="Save" />
    to:
      <button type="submit" name="save" onclick="return check_form_borrowers">
    then finally to:
      <button class="btn btn-small" id="saverecord" type="submit" name="save" onclick="return check_form_borrowers();">

    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

    Signed-off-by: Lee Jamison <ldjamison at marywood.edu>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

commit a88f540ec1a0f7e1f876f3811d0e44cb3ff3a612
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Jun 14 13:07:41 2017 -0300

    Bug 18804: (bug 16286 follow-up) Update the "save category" elt selector

    Bug 16286 replaced the submit node:
      <input type="button" value="Save" onclick="Check(this.form);" />
    with
      <input type="submit" value="Save" />

    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

    Signed-off-by: Lee Jamison <ldjamison at marywood.edu>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

commit 943a3a5c3ab4df6337607e1e237ff4f059d23da4
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Jun 13 17:43:39 2017 -0300

    Bug 18804: Skip selenium tests if Selenium::Remote::Driver is not installed

    We do not want these tests to fail if the module is not installed.
    This module is not in the dependencies of Koha and it is good as it.
    A developper who wants to use it will know what to do.
    It is part of RM duties to make sure these tests pass

    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

    Signed-off-by: Lee Jamison <ldjamison at marywood.edu>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

commit e1afa469f8313144c70ae91d7efa356beb8168b8
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Jun 16 07:57:14 2017 +0200

    Bug 18361: [QA Follow-up] Resolve warning on undef values supplied

    The following warning was raised in Letters.t:
    DBIx::Class::ResultSource::_minimal_valueset_satisfying_constraint():
    NULL/undef values supplied for requested unique constraint 'primary' (NULL
    values in column(s): 'id'). This is almost certainly not what you wanted,
    though you can set DBIC_NULLABLE_KEY_NOWARN to disable this warning.

    This warning is triggered by this line in C4/Letters.pm:
        Koha::SMS::Providers->find( $member->{'sms_provider_id'} );
    As you already guessed, the sms_provider_id returns undef.

    Resolved in sub find by testing if there are parameters and if so, they
    should not be all undefined. (In most cases there will be only one
    parameter; but this report is about composite keys.)

    Added a trivial test case in Objects.t too.

    Test plan:
    Run t/db_dependent/Koha/Object.t
    Run t/db_dependent/Koha/Objects.t
    Run t/db_dependent/Letters.t

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

commit e1f943b9992ea1a3c5d4659ca6fa787834d66376
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Wed Apr 19 11:57:33 2017 -0300

    Bug 18361: (QA followup) Add tests for the no params case

    This patch adds a test for the trivial case in which no param is passed
    and the ->find method returns undef.

    For completeness purposes.

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit de74a4e5a0ec0fcf85a42b637d07c2bcd81d63f0
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Thu Apr 13 13:15:30 2017 +0200

    Bug 18361: Additional tests for Koha::Objects->find

    Adding a subtest find in t/db_dependent/Koha/Objects.t.

    Test plan:
    Run t/db_dependent/Koha/Objects.t

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit ec288a50def5c4fdcd7b001087fed0b120e4a211
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Mar 31 13:52:15 2017 +0200

    Bug 18361: Koha::Objects->find should accept composite primary keys

    Changes the $id parameter to an array. (IssuingRule has three keys.)
    The build_object method in TestBuilder.pm has been adjusted to pass
    multiple primary key values to find.

    Also adjusted the POD section to show more clearly that we accept
    the same parameters as DBIx ResultSet does.

    Test plan:
    Run t/db_dependent/Koha/Object.t
    Run t/db_dependent/Koha/Objects.t
    Run t/db_dependent/TestBuilder.t

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-----------------------------------------------------------------------

Summary of changes:
 Koha/Objects.pm                                    |   17 +-
 .../en/includes/authorities-search-results.inc     |   28 +--
 .../intranet-tmpl/prog/en/includes/circ-menu.inc   |    3 +-
 .../prog/en/includes/search_indexes.inc            |   14 +-
 .../prog/en/modules/admin/edi_accounts.tt          |    5 +-
 .../prog/en/modules/catalogue/issuehistory.tt      |    6 +-
 .../intranet-tmpl/prog/en/modules/intranet-main.tt |    9 +-
 .../prog/en/modules/members/members-update.tt      |    3 +-
 t/db_dependent/Koha/Objects.t                      |   39 +++-
 t/db_dependent/selenium/basic_workflow.t           |  237 +++++++++++---------
 t/lib/TestBuilder.pm                               |    2 +-
 11 files changed, 209 insertions(+), 154 deletions(-)

hooks/post-receive
-- 
main Koha release repository