From gitmaster at git.koha-community.org Fri Mar 3 17:53:17 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Mar 2017 16:53:17 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-513-g50c5708 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 50c5708fe8ed74e22d78d9acb81080c7840954dc (commit) via f7dbe1751c2e99a3e573038f2f8c90127a832ddf (commit) via 77337a2ab537843eab70cc06b8bc2531ad2014dc (commit) from 11bae489bc85a9463712c9caafd2caf7b63155d9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 50c5708fe8ed74e22d78d9acb81080c7840954dc Author: Kyle M Hall Date: Fri Mar 3 16:45:22 2017 +0000 Bug 17260 - DBRev 16.12.00.011 Signed-off-by: Kyle M Hall commit f7dbe1751c2e99a3e573038f2f8c90127a832ddf Author: Jonathan Druart Date: Fri Feb 24 08:08:30 2017 +0000 Bug 17260: Update existing installs Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 77337a2ab537843eab70cc06b8bc2531ad2014dc Author: Blou Date: Fri Jan 27 16:51:26 2017 +0000 Bug 17260: updatedatabase.pl fails on invalid entries in ENUM and BOOLEAN columns The loading of file admin/searchengine/elasticsearch/mappings.yaml specifies 'type' as empty, which fails with Mysql 5.7+ which is more stringent. Also, forcing an empty value into a boolean also fails. Both issues arise when updatedatabase.pl hit 3.23.00.050. NOTE: both issues could also be resolved by actually setting values in the load file. This doesn't make this solution incorrect, though. To Test/reproduce: -1) Happens with Mysql 5.7.4. Maybe earlier, but certainly at that point. Use a Xenial kohadevbox to more easily test. 0) Find a database on 3.22 or earlier, save it. a) place sql_mode=IGNORE_SPACE,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION into the [mysqld] section of /etc/mysql/mysql.conf.d/mysqld.cnf b) restart you mysql server c) drop the db and recreate it d) checkout the 3.22.x branch e) do a web install f) remove the added sql_mode g) restart the mysql server 1) Set your code base to master 2) run updatedatabase.pl 3) See the errors on 3.23.00.050 4) Apply the patch 5) Reload the 3.22 db. a) repeat steps 0(a)-0(g) b) don't forget the caching issues 6) succeed with updatedatabase.pl 7) drop the db and recreate it 8) run the web installer 9) notice no issues either. 10) run koha qa test tools NOTE: This bug only solved the upgrade portion. I added the kohastructure.sql change as well. I confirmed that all the code changes were triggered with this test plan. Signed-off-by: Mark Tompsett Signed-off-by: Mehdi Hamidi Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- Koha/SearchEngine/Elasticsearch.pm | 2 +- installer/data/mysql/kohastructure.sql | 2 +- installer/data/mysql/updatedatabase.pl | 13 ++++++++++++- 4 files changed, 15 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 3 17:59:32 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Mar 2017 16:59:32 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-516-gb1249dc Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b1249dcc34d22722c23fb3a231b61bcd42f82550 (commit) via 08b1ebec75623c84967fd09611cf1fef4442c200 (commit) via 35e3678f13e47b5e9596b4a4d62cb050e1832760 (commit) from 50c5708fe8ed74e22d78d9acb81080c7840954dc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b1249dcc34d22722c23fb3a231b61bcd42f82550 Author: Francesco Rivetti Date: Mon Feb 20 11:02:40 2017 +0100 Bug 17941 add tests to cover the optimization of the nested loop the new code skip testing for more borrowers if the item can't be renewed this require more tests for the case where 2+ items are reserved. I tried to add 1 more reserve to the main test suit, but too many other tests rely on specific holds, and I couldn't get around it. Instead, I added a subtest that consider the specific simple case and leave the other test cases exactly has they were designed. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Amended-patch: Just fix 3 indendations Signed-off-by: Kyle M Hall commit 08b1ebec75623c84967fd09611cf1fef4442c200 Author: Francesco Rivetti Date: Tue Feb 14 11:16:01 2017 +0100 Bug 17941 don't compute priority more than needed Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 35e3678f13e47b5e9596b4a4d62cb050e1832760 Author: Francesco Rivetti Date: Tue Feb 14 11:13:51 2017 +0100 Bug 17941 avoid scanning the full cartesian product when a item match a borrower, there is no point in checking the other borrowers Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 29 ++++++----- reserve/request.pl | 3 +- t/db_dependent/Circulation.t | 110 +++++++++++++++++++++++++++++++++++++++++- 3 files changed, 125 insertions(+), 17 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 3 18:02:13 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Mar 2017 17:02:13 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-519-gcddb4b1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via cddb4b1ef049204da9a0db169b6aa83c3a361eac (commit) via 37288efd23199420cb79316ed1acbd0e1b1beb00 (commit) via 72e67285b7d98cb1934350274bbcc7191c63c66e (commit) from b1249dcc34d22722c23fb3a231b61bcd42f82550 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit cddb4b1ef049204da9a0db169b6aa83c3a361eac Author: Kyle M Hall Date: Fri Mar 3 16:54:15 2017 +0000 Bug 18160 [QA Followup] - Correct whitespace Signed-off-by: Kyle M Hall commit 37288efd23199420cb79316ed1acbd0e1b1beb00 Author: Mark Tompsett Date: Thu Feb 23 11:47:00 2017 -0500 Bug 18160: Follow up tweak if condition Based on comment #9, moved if condition. Based on comment #8, tweaked condition to grab preference. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 72e67285b7d98cb1934350274bbcc7191c63c66e Author: Nick Clemens Date: Thu Feb 23 00:35:13 2017 +0000 Bug 18160 - Error when OverDriveCirculation not enabled This patch only executes OverDrive circulation JS if OverDriveCirculation pref is enabled To test: 1 - Disable OverDriveCirculation 2 - Log in to opac and view summary tab 3 - Note 'Internal server error' 4 - Apply patch 5 - Repeat and note error is not present Signed-off-by: Srdjan Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 3 18:05:31 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Mar 2017 17:05:31 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-520-g1102109 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 1102109f9ccff4ce0b01f95ae16adb65a9806b26 (commit) from cddb4b1ef049204da9a0db169b6aa83c3a361eac (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1102109f9ccff4ce0b01f95ae16adb65a9806b26 Author: Tomas Cohen Arazi Date: Wed Jan 25 09:35:42 2017 -0300 Bug 17992: REST api: Remove the use of ->unblessed from Cities controller As bug 17932 adds TO_JSON to Koha::Object(s), there's no need for using it. Also, as this is a reference implementation for developers to copy and paste it is sensible to make this change even when this is not causing any bug. To test: - Apply the patch - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/api/v1/cities.t => SUCCESS: Tests still pass! - Sign off :-D Signed-off-by: Matthias Meusburger Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/REST/V1/Cities.pm | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 3 18:15:30 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Mar 2017 17:15:30 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-522-gd43131c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d43131c4fca8124a8a9e4dcdea82e2bdf1af196a (commit) via 18af48bffe112a5df61a8a546da86dc31f32a7e7 (commit) from 1102109f9ccff4ce0b01f95ae16adb65a9806b26 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d43131c4fca8124a8a9e4dcdea82e2bdf1af196a Author: Jonathan Druart Date: Tue Feb 14 10:52:14 2017 +0100 Bug 18087: Handle invalid filetypes If an invalid file is used as biblionumber list, we should display a message. Test plan: 1/ Use csv, plain text files => Should work 2/ Use invalid files (binary files like pdf, doc*, xsl*, etc.) => Should not work and see a warning message. Amended patch after signoff: Remove one warn debug line Signed-off-by: Joy Nelson Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 18af48bffe112a5df61a8a546da86dc31f32a7e7 Author: Joy Nelson Date: Thu Feb 9 11:42:57 2017 -0800 Bug 18087 - Clarification on File type when using file of biblionumbers to export data Added a line to the screen detailing the types of files that can be used to upload a list of biblionumbers. Test plan: 1. Go to tools->export data 2. under File option, (File types accepted: .csv and .txt) should appear 3. Check both Bibliographic and Authority Export screens for this new string. Signed-off-by: Claire Gravely Signed-off-by: Joy Nelson Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/tools/export.tt | 13 +++++++++++-- tools/export.pl | 12 ++++++++++++ 2 files changed, 23 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 3 18:16:44 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Mar 2017 17:16:44 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-524-ge9d5615 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e9d5615e70056cd887b9471827611a78275016ab (commit) via b2eb6109ff308de7d2bc9338d708ac7fe9b6e3d7 (commit) from d43131c4fca8124a8a9e4dcdea82e2bdf1af196a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e9d5615e70056cd887b9471827611a78275016ab Author: Mark Tompsett Date: Tue Feb 21 13:13:02 2017 -0500 Bug 13968: Follow up - Clean HTML tags for hints Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit b2eb6109ff308de7d2bc9338d708ac7fe9b6e3d7 Author: Marc V?ron Date: Sat Feb 18 17:15:06 2017 +0100 Bug 13968 - Branch email hints are misleading This patch replaces missleading notes with Reply-To and Return-Path fields to reflect indicate falback values if they are empty (ReplyToDefault and ReturnpathDefault system prefs). To test: - Apply patch - In Home > Administration > Libraties and Groups, edit a library - Verify that hints display for fields Reply-To and Return-Path, indicating their default values. Amended to remove extra - 2017-02-21 mv Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 3 18:28:10 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Mar 2017 17:28:10 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-533-gabdf231 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via abdf2319cd0fca27046699ae029107e92bb7f02f (commit) via b4cd5faeb09b4872b5ea413e0aace3ebbaae26c5 (commit) via ea321eaf3d6023d8d8b0fbb6ed4a85051f78d60b (commit) via 60a0e155a1586531bff220766704f0c9699cfb16 (commit) via e8d34c2bdd741cdfbe9cb483740d645aef396f9a (commit) via ce55b024467f5d1da92a97c1dc058fbbd593b781 (commit) via 286be46e8a8c126c5a23dd16e310d11253378da5 (commit) via 4f72b06e5d5807a88b243e12fe4085e617e822c8 (commit) via bfe63a1e73bcfb57d6e2c41b98208419ba00a71f (commit) from e9d5615e70056cd887b9471827611a78275016ab (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit abdf2319cd0fca27046699ae029107e92bb7f02f Author: Marcel de Rooy Date: Mon Feb 27 13:21:18 2017 +0100 Bug 16966: [QA Follow-up] Check count, not size in template The method size is not covered by tests at koha-tmpl/intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt line 163. The method size is not covered by tests at koha-tmpl/intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt line 183. Script cleanborrowers passes patrons_to_delete and patrons_to_anonymize to the template. One is an array ref where we should use 'size', the other is a Koha::Patrons object where we should use 'count'. If we don't, we will not anonymize a lot of records ;) Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit b4cd5faeb09b4872b5ea413e0aace3ebbaae26c5 Author: Jonathan Druart Date: Fri Feb 24 12:34:26 2017 +0100 Bug 16966: move parameters to hashref Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit ea321eaf3d6023d8d8b0fbb6ed4a85051f78d60b Author: Jonathan Druart Date: Fri Feb 24 12:25:33 2017 +0100 Bug 16966: Fix small QA issues Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 60a0e155a1586531bff220766704f0c9699cfb16 Author: Jonathan Druart Date: Fri Feb 17 10:39:09 2017 +0100 Bug 16966: Teach K::S::R::OldIssue its Koha objects class Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit e8d34c2bdd741cdfbe9cb483740d645aef396f9a Author: Jonathan Druart Date: Tue Dec 20 12:15:10 2016 +0100 Bug 16966: The method should return a Koha::Patrons object Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit ce55b024467f5d1da92a97c1dc058fbbd593b781 Author: Jonathan Druart Date: Tue Dec 20 10:08:35 2016 +0000 Bug 16966: Make the tests pass again Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 286be46e8a8c126c5a23dd16e310d11253378da5 Author: Jonathan Druart Date: Fri Jul 22 17:25:24 2016 +0100 Bug 16966: Koha::Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise The C4::Members::GetBorrowersWithIssuesHistoryOlderThan subroutine is supposed to return the patrons with an issue history older than a given date. It would make more sense to return a list of Koha::Patrons. On the way, the code from AnonymiseIssueHistory will be moved as well to anonymise_issue_history. Note that these 2 subroutines are strongly linked: one is used to know the number of patrons we will anonymise the history, the other one is used to anonymise the issues history. The problem is that the first one is not used to do the action, but only for displayed purpose. In some cases, these 2 values can differ, which could be confusing. Case 1: The logged in librarian is not superlibrarian and IndependentBranches is set: if 2+ patrons from different libraries match the date parameter, the interface will display "Checkout history for 2 patrons will be anonymized", when actually only 1 will be. Case 2: If 2+ patrons match the date parameter but one of them has his privacy set to forever (privacy=0), the same issue will appear. This patch moves the code from C4::Members::GetBorrowersWithIssuesHistoryOlderThan to Koha::Patrons->search_patrons_to_anonymise and from C4::Circulation::AnonymiseIssueHistory to Koha::Patrons->anonymise_issue_history Test plan: 1/ Confirm the 2 issues and make sure they are fixed using the Batch patron anonymization tool (tools/cleanborrowers.pl) 2/ At the OPAC, use the 'Immediate deletion' button to delete all your reading history (regardless the setting of the privacy rule) 3/ Use the cronjob script (misc/cronjobs/batch_anonymise.pl) to anonymise patrons. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 4f72b06e5d5807a88b243e12fe4085e617e822c8 Author: Jonathan Druart Date: Fri Jul 22 16:43:56 2016 +0100 Bug 16966: Koha::Patrons - Move AnonymiseIssueHistory tests The next patch will move C4::Circulation::AnonymiseIssueHistory and C4::Members::GetBorrowersWithIssuesHistoryOlderThan to Koha::Patrons This patch move the history anonymisation code to the Patrons.t test file and the entire subtest related to StoreLastBorrower to StoreLastBorrower.t It just moves and add some minor adjustements. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit bfe63a1e73bcfb57d6e2c41b98208419ba00a71f Author: Jonathan Druart Date: Fri Jul 22 15:57:26 2016 +0100 Bug 16966: GetBorrowersWithIssuesHistoryOlderThan - Highlight the existing issue in tests If IndependentBranches is set, the code is buggy. This patch only highlight the bug by providing a test. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 44 --- C4/Members.pm | 46 ---- Koha/Patrons.pm | 64 ++++- Koha/Schema/Result/OldIssue.pm | 4 +- .../prog/en/modules/tools/cleanborrowers.tt | 12 +- .../opac-tmpl/bootstrap/en/modules/opac-privacy.tt | 6 +- misc/cronjobs/batch_anonymise.pl | 7 +- opac/opac-privacy.pl | 15 +- t/db_dependent/Circulation/AnonymiseIssueHistory.t | 279 -------------------- t/db_dependent/Circulation/StoreLastBorrower.t | 144 ++++++++++ t/db_dependent/Koha/Patrons.t | 183 ++++++++++++- tools/cleanborrowers.pl | 23 +- 12 files changed, 419 insertions(+), 408 deletions(-) delete mode 100644 t/db_dependent/Circulation/AnonymiseIssueHistory.t create mode 100644 t/db_dependent/Circulation/StoreLastBorrower.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 3 18:59:37 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Mar 2017 17:59:37 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-535-g3f66081 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 3f66081fb5a69feeeb5cf7c0876a6debc932beee (commit) via 21a13396c9610c5defa2451d1ca6fd0d08e8ca3c (commit) from abdf2319cd0fca27046699ae029107e92bb7f02f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3f66081fb5a69feeeb5cf7c0876a6debc932beee Author: Jonathan Druart Date: Thu Jan 26 12:43:14 2017 +0100 Bug 17334: Format the date according to the system preference - Use KohaDates TT plugin to format the date correctly - Do not use a temporary variable - Replace: patron's info Requested: Datetime with patron's info - Requested on Datetime Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 21a13396c9610c5defa2451d1ca6fd0d08e8ca3c Author: Alex Buckley Date: Fri Jan 20 03:59:24 2017 +0000 Bug 17334- Added a timestamp to the members-update.tt To show the user when the pending modifications were requested. Test plan: 1.Log into OPAC and click on Lists->Your Lists->your personal details 2. Change/add a value in that form 3. Select the 'Submit update request' 4. Log into the Koha staff interface, then go to the url: cgi-bin/koha/members/members-update.pl 5. You will see near the top of each box containing a pending request the following are displayed: surname, firstname, patron category, branch, and cardnumber but no timestamp. 6. Apply this patch 7. Repeat steps 1,2, 3, 4 8. You will now see timestamp in the format "Requested: YYYY-MM-DD HH:MM:SS" next to each patrons details near the top of each pending request box. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 3 19:04:34 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Mar 2017 18:04:34 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-536-g257c179 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 257c1793420108f1cb5efdec7bf03649d41940a0 (commit) from 3f66081fb5a69feeeb5cf7c0876a6debc932beee (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 257c1793420108f1cb5efdec7bf03649d41940a0 Author: Emma Smith Date: Tue Jan 17 03:23:18 2017 +0000 Bug 17840: adding classes to notes in checkouts Test Plan 1) Add an internal and a public note to an item. 2) Check out the item. 3) Verify that both notes are shown in between title and barcode in the second column of the details table. 4) Verify there is an empty class="" in the HTML source code for each 5) Apply patch and refresh page 6) View page source, confirm that class has been changed I tested this by first applying the patch for bug 17919 to catch the check-in software error. Patch working as expected :) Signed-off-by: Claire Gravely Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 3 19:18:52 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Mar 2017 18:18:52 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-537-g9b92a49 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 9b92a494e6d91297f460eb8ed073a6d3dec5b2d9 (commit) from 257c1793420108f1cb5efdec7bf03649d41940a0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9b92a494e6d91297f460eb8ed073a6d3dec5b2d9 Author: Marcel de Rooy Date: Mon Dec 15 14:10:56 2014 +0100 Bug 18037: Hold notes template cleanup (from 15545) From the second patch of bug 15545: Removing some unused template code related to a former approach. Adding some changes for future extension by bug 15545. This patch was tested by Liz Rea when the routine IsHoldNoteRequired was called by opac-reserve.pl. The only change here is that we do not yet call this routine; so leaving her original signoff. Test plan: [1] Enable OPACHoldNotes. [2] Place a hold on a serial record. No behavior change. Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 36 +++++++++----------- opac/opac-reserve.pl | 2 +- 2 files changed, 18 insertions(+), 20 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 3 19:20:49 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Mar 2017 18:20:49 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-541-gfd8c2d4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via fd8c2d4e35f0ed4d7661eea2f1238fe2d094b969 (commit) via 17e84750d9d90f3d2df466d1c8d8a63bbd5ad09d (commit) via cb58b11f6769f69e109c1f42a78b3756d429dc80 (commit) via 6572ee07dbcd9fde4169c6b9e3f3f8a8e0eaf516 (commit) from 9b92a494e6d91297f460eb8ed073a6d3dec5b2d9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fd8c2d4e35f0ed4d7661eea2f1238fe2d094b969 Author: Marcel de Rooy Date: Tue Feb 7 14:03:54 2017 +0100 Bug 18070: Correct error from podchecker on line 1376 Resolves: *** ERROR: Spurious =cut command at line 1376 in file C4/AuthoritiesMarc.pm Test plan: [1] Run podchecker on C4/AuthoritiesMarc.pm Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Julian Maurice Signed-off-by: Kyle M Hall commit 17e84750d9d90f3d2df466d1c8d8a63bbd5ad09d Author: Marcel de Rooy Date: Tue Feb 14 16:41:26 2017 +0100 Bug 18070: [Follow-up] What should DelAuthority return? Script tools/batch_delete_records.pl only checks the return value of DelAuthority. The return value depends on DBI rows, which is not always reliable. It may return -1 when it 'does not know'. Testing $@ in tools/batch_delete_records.pl should actually be enough. The return value was discarded in C4/ImportBatch.pm. Removing an unused variable. Test plan: [1] Pick an authority record with a few linked biblios. Delete this authority record via tools/batch_delete_records.pl. Check if the linked biblio records are cleaned up. [2] Bonus: Make a typo in the SQL statement of DelAuthority. Check if batch_delete_records shows you the error message. Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Julian Maurice Signed-off-by: Kyle M Hall commit cb58b11f6769f69e109c1f42a78b3756d429dc80 Author: Marcel de Rooy Date: Tue Jan 31 13:01:58 2017 +0100 Bug 18070: Extend sub merge to remove fields for deleted authorities In order to accomplish this, we need to add some additional checks in the merge routine. The actual change to remove the field, is quite small. Furthermore, we need to add a merge call in DelAuthority and adjust the merge cron job accordingly. The change is well supported by additional tests, including a simulation of postponed removal via cron, if dontmerge is enabled. Note: Deleting an authority with linked biblios is tested on the next patch. Test plan: [1] Run t/db_dependent/Authorities/Merge.t [2] Delete an authority without linked biblios from the Authorities module. If the indexer is not fast enough, wait a bit and refresh to verify that the authority is gone on authorities-home.pl. Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Julian Maurice Signed-off-by: Kyle M Hall commit 6572ee07dbcd9fde4169c6b9e3f3f8a8e0eaf516 Author: Marcel de Rooy Date: Tue Jan 31 11:46:21 2017 +0100 Bug 18070: Deleting an authority should update the linked biblio records Adding a test where we delete an authority and prove that the linked biblio still contains a reference to it. Note: Currently, you can only delete a used authority from Tools, batch record deletion. If you do, the biblio records will still contain references to the deleted authority. Test plan: [1] Run t/db_dependent/Authorities/Merge.t Last test should fail: not ok 1 - Field 609 should be gone too Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Julian Maurice Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/AuthoritiesMarc.pm | 54 +++++++++++++++++++------------ C4/ImportBatch.pm | 2 +- misc/migration_tools/merge_authority.pl | 9 ++++-- t/db_dependent/Authorities/Merge.t | 48 ++++++++++++++++++++++++++- tools/batch_delete_records.pl | 4 +-- 5 files changed, 89 insertions(+), 28 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 3 19:21:39 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Mar 2017 18:21:39 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-542-g93a3b1f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 93a3b1fe8d94b06f995d6a0df7df63194910af28 (commit) from fd8c2d4e35f0ed4d7661eea2f1238fe2d094b969 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 93a3b1fe8d94b06f995d6a0df7df63194910af28 Author: Aleisha Amohia Date: Tue Feb 14 01:21:01 2017 +0000 Bug 18108: Sorting by author in opac summary To test: 1) Log into OPAC, go to your summary 2) Notice 'author' is in Title column, therefore unable to sort by author 3) Apply patch and refresh page 4) Notice author has now been moved into Author column 5) Confirm sorting by author works as expected and sorting of all other columns works as expected Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 3 19:21:56 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Mar 2017 18:21:56 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-543-g3d3ab8b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 3d3ab8bd2f0ca7fc091d0367047248c561a3af8a (commit) from 93a3b1fe8d94b06f995d6a0df7df63194910af28 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3d3ab8bd2f0ca7fc091d0367047248c561a3af8a Author: Aleisha Amohia Date: Tue Feb 14 19:42:15 2017 +0000 Bug 13685: Sorting by author in opac reading history opac-readingrecord.pl was actually already set up to do this, the option to sort by author was just not put into the tt file. This patch adds that. To test: 1) Log into OPAC, go to your reading history 2) Confirm that 'Order by author' shows in the dropdown 3) Confirm it works as expected Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 3 19:23:44 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Mar 2017 18:23:44 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-544-gb6cb18c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b6cb18c4a8292cabe5fd611b349b51d5c79b5fe4 (commit) from 3d3ab8bd2f0ca7fc091d0367047248c561a3af8a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b6cb18c4a8292cabe5fd611b349b51d5c79b5fe4 Author: Marc V?ron Date: Wed Feb 15 10:24:56 2017 +0100 Bug 18122 - Audio alerts: Add hint on where to enable sounds This patch adds a hint to page Home > Administration > Audio alerts and related help page about where to enable the sound system (syspref 'AudioAlerts'). To test: - Apply patch - Disable syspref 'AudioAlerts' - Go to Home > Administration > Audio alerts - Note hint below title 'Audio alerts' - Enable syspref 'AudioAlerts' - Go to Home > Administration > Audio alerts - Hint is no longer visible (since audios are enabled) - Open Help page (top right) - Verify that hint on help page makes sense. Amended to add alert class as requested by comment #2 2017-02-21 mv Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/audio_alerts.tt | 7 +++++++ .../intranet-tmpl/prog/en/modules/help/admin/audio_alerts.tt | 2 ++ 2 files changed, 9 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 3 19:24:46 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Mar 2017 18:24:46 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-546-g19cbebc Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 19cbebc9b6dc061c6c9525a224a0c6d4a7b6d604 (commit) via ff647be07c54191f1c1ee5693be96bf4d0040672 (commit) from b6cb18c4a8292cabe5fd611b349b51d5c79b5fe4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 19cbebc9b6dc061c6c9525a224a0c6d4a7b6d604 Author: Jonathan Druart Date: Mon Feb 27 13:28:20 2017 +0000 Bug 18169: Add test without before parameter for search_patrons_to_anonymise Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit ff647be07c54191f1c1ee5693be96bf4d0040672 Author: Jonathan Druart Date: Fri Feb 24 13:26:29 2017 +0100 Bug 18169: Make 'before' param non mandatory for Koha::Patrons->anonymise_issue_history From opac-privacy.pl: # delete all reading records for items returned # uses a hardcoded date ridiculously far in the future my $rows = eval { Koha::Patrons->search({ 'me.borrowernumber' => $borrowernumber })->anonymise_issue_history( { before => '2999-12-12' } ); }; It sounds better to make this before parameter not mandatory, and remove the condition from the sql query if it is not passed. Test plan: 1. Anonymise your reading history at the OPAC. 2. Confirm that all your reading history has been anonymised Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/Patrons.pm | 19 ++++++++++---- opac/opac-privacy.pl | 4 +-- t/db_dependent/Koha/Patrons.t | 57 +++++++++++++++++++++++++++++++++-------- 3 files changed, 62 insertions(+), 18 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 3 19:26:06 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Mar 2017 18:26:06 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-549-g3f6f4a2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 3f6f4a2b36537cdcf3e89832e83595d7d6a649ad (commit) via c3f6f26c35ecdab035f8e0035ee8eb73cd5fe99c (commit) via 902342f415c51ebb13ea3b36cad3583a39afc1a7 (commit) from 19cbebc9b6dc061c6c9525a224a0c6d4a7b6d604 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3f6f4a2b36537cdcf3e89832e83595d7d6a649ad Author: Jonathan Druart Date: Fri Feb 24 07:46:19 2017 +0000 Bug 7663: Fix bad merge conflict with bug 15584 Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit c3f6f26c35ecdab035f8e0035ee8eb73cd5fe99c Author: Nick Clemens Date: Fri Feb 24 01:29:22 2017 +0000 Bug 7663 (QA Followup) Ignore empty entries Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 902342f415c51ebb13ea3b36cad3583a39afc1a7 Author: Nick Clemens Date: Thu Dec 1 11:47:31 2016 +0000 Bug 7663 - batch add barcodes to a list This patch changes the barcode input on add list to a textarea and process multiples barcodes to allow for adding many items to a list at once To test: 1 - Create a list 2 - Add some items 3 - Verify items are added and success reported 4 - Add these items again 5 - Verify you are notified they were not added 6 - Type invalid barcodes into the text area and submit 7 - Verify you are notifed of failure to add 8 - Try going to a list that doesn't exist and adding barcodes i.e. http://localhost:8081/cgi-bin/koha/virtualshelves/shelves.pl?op=add_biblio&shelfnumber=9999&barcodes=4 9 - Verify correct error 10 - Try the above but with a list that exists while signed in as a patron without lists permission: i.e. http://localhost:8080/cgi-bin/koha/opac-shelves.pl?op=view&shelfnumber=3 11 - Verify correct error: "You do not have permission to view this list." Signed-off-by: Chris Kirby Works as advertised. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/virtualshelves/shelves.tt | 12 +++---- virtualshelves/shelves.pl | 33 +++++++++++--------- 2 files changed, 25 insertions(+), 20 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 3 19:34:38 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Mar 2017 18:34:38 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-550-g01371f8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 01371f8fad6efd30bf5a3b10bf3cf9f5eabbe5b5 (commit) from 3f6f4a2b36537cdcf3e89832e83595d7d6a649ad (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 01371f8fad6efd30bf5a3b10bf3cf9f5eabbe5b5 Author: Aleisha Amohia Date: Wed Feb 15 00:30:57 2017 +0000 Bug 10978: Redirect to basket list of a supplier after deleting a basket This patch redirects to the vendor's list of baskets after deleting a basket, fixes breadcrumbs after deletion and also hides the toolbar actions after deletion (seeing as you can't edit/export etc a basket that no longer exists). To test: 1) Go to Acquisitions -> find a vendor -> view a basket or create a new basket 2) Delete the basket. Notice you are taken to a list of all vendors and baskets 3) Apply patch and do step 1 again 4) Delete the basket. Notice appropriate breadcrumbs, no toolbar, and confirm link to return to baskets for the vendor works. Sponsored-by: Catalyst IT Followed test plan, works as expected (links to vendor's baskets and all baskets) Signed-off-by: Marc V?ron Re-tested. Wording of buttons "Show baskets for vendor..." and "Show all active baskets" makes sense. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: acqui/basket.pl | 6 +++++- koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt | 11 +++++++++-- 2 files changed, 14 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 3 19:38:00 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Mar 2017 18:38:00 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-553-gd9069b5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d9069b5b60c10db20136af2bef837123558a2c22 (commit) via eaa9882dd10414cf16ecaf80bcf856bfc60e42c1 (commit) via c6ea593971502833ff6f37c3eccc994d5b15171e (commit) from 01371f8fad6efd30bf5a3b10bf3cf9f5eabbe5b5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d9069b5b60c10db20136af2bef837123558a2c22 Author: Kyle M Hall Date: Fri Mar 3 18:30:01 2017 +0000 Bug 14764 - DBRev 16.12.00.012 Signed-off-by: Kyle M Hall commit eaa9882dd10414cf16ecaf80bcf856bfc60e42c1 Author: Liz Rea Date: Fri Feb 3 10:18:51 2017 +1300 Bug 14764 - [followup] Addressing QA concerns * removed Policy: * put the syspref in alpha order with the others * added els to the if. Signed-off-by: Baptiste Wojtkowski Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit c6ea593971502833ff6f37c3eccc994d5b15171e Author: Liz Rea Date: Thu Nov 3 10:18:45 2016 +1300 Bug 14764: OPAC news selector Test plan: 1) Add more than one library, at least two in total is needed. Make note of which is your current user's home branch. 2) Go to Tools -> News and add one global ("All") news item and one specific for each branch. 3) Apply the patches. 4) Perform database upgrades when you log in. 5) Go to OPAC main, it should work as before: Showing global news as well as the news for your home branch once logged in. 6) Go to System Preferences -> OPAC and set 'OPACNewsBranchSelect' to yes. 7) Go to OPAC main, you should see the global news item plus any items for your home branch for the current user if logged in. 8) Above the news, you will see a dropdown that lists the branches. Select one, and click "Change library." 9) You should now see global news and the news for the selected branch, regardless of whether logged in or not. Sponsored-By: Halland County Library Fixes QA comments: * Keep the current selected branch selected * Change OPACNewsBranchSelect -> OPACNewsLibrarySelect * fix 'system wide only' view for logged in user. We still show system wide even when a library is selected. * Removed the "change library" link * Added a label to the field. Signed-off-by: Owen Leonard Signed-off-by: Zeno Tajoli Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 11 +++++++++ .../prog/en/modules/admin/preferences/opac.pref | 7 ++++++ .../bootstrap/en/includes/opac-bottom.inc | 8 +++++++ .../opac-tmpl/bootstrap/en/modules/opac-main.tt | 25 +++++++++++++++++++- opac/opac-main.pl | 3 +++ 7 files changed, 55 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 3 19:40:59 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Mar 2017 18:40:59 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-554-g84e48d0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 84e48d03238ce2446e7ea24401bda0a8f4e4422d (commit) from d9069b5b60c10db20136af2bef837123558a2c22 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 84e48d03238ce2446e7ea24401bda0a8f4e4422d Author: Dimitris Kamenopoulos Date: Sun Dec 27 16:01:43 2015 +1300 Bug 15427 : Enable TLS support for MySQL In summary, changes are: 1) If you have chosen MySQL, Makefile.PL will ask you if you want TLS (default: "no"), and then the locations for CA cert, client cert and client key (reasonable defaults are provided). Settings , , and are added in koha-conf.xml 2) If yes in koha-conf.xml, the installer and database connection scripts add the TLS options in both DBI connection strings and mysql command line To test 1/ Apply patch 2/ Check everything still works and db connections are the same as before 3/ Either run Makefile.PL and step through the options or edit your koha-conf.xml to enable TLS 4/ Check db connections are still working Patch provided to me by Dimitris Kamenopoulos and I reformatted it into a git patch, any errors are probably mine Signed-off-by: Mirko Tietgen Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Installer.pm | 12 ++++++++++-- Koha/Database.pm | 12 +++++++++++- Makefile.PL | 26 ++++++++++++++++++++++++++ etc/koha-conf.xml | 4 ++++ installer/install.pl | 15 +++++++++++++-- rewrite-config.PL | 6 +++++- 6 files changed, 69 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 3 19:42:28 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Mar 2017 18:42:28 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-556-g7963796 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 796379697849d6ca0364a736aa72dfecf28134e6 (commit) via 1edb8cbeee2f89c7fb4cd1f643b23cb20d91d35d (commit) from 84e48d03238ce2446e7ea24401bda0a8f4e4422d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 796379697849d6ca0364a736aa72dfecf28134e6 Author: Jonathan Druart Date: Wed Feb 1 17:54:43 2017 +0100 Bug 16530: Add a new method to the Branches TT Plugin to avoid c/p We should do the same for the other check (FA exists), but cannot find a good and quick way to implement. Doing it this way will avoid regression later, we will no have to check if the variable is correctly passed to the template. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 1edb8cbeee2f89c7fb4cd1f643b23cb20d91d35d Author: Aleisha Date: Tue May 17 04:35:46 2016 +0000 Bug 16530: Adding a circ sidebar navigation menu and circSidebar syspref to activate/deactivate Edit: Fast cataloging link should now show on all pages, removed offline circulation links Edit 2: Creates the syspref to activate or deactivate the sidebar Edit 3: Fixing merge conflicts, using Koha::BiblioFrameworks to find FA framework and adding sidebar to on-site checkouts This adds a sidebar to circ/branchoverdues.tt circ/circulation.tt (I also fixed up some of the indentation in this file to make it easier to see where the divs started and ended) circ/renew.tt circ/returns.tt circ/selectbranchprinter.tt circ/transferstoreceive.tt circ/view_holdsqueue.tt circ/waitingreserves.tt circ/branchtransfers.tt circ/on-site_checkouts.tt To test: 1) Confirm syspref CircSidebar is activated 2) Go to all of the above pages and confirm the sidebar menu shows up 3) Confirm fast cataloguing link and transfer link are there 4) Trigger any error messages you can possibly think of (i.e. on renew.pl: barcode does not exist). Confirm that this does not mess up the layout of the page 5) Go to a user account page, Check out tab. (Since this is a circ/circulation.pl page). Ensure the circ nav sidebar doesn't show up (confirm it looks as it usually does) 6) Deactivate circSidebar 7) Confirm pages all look normal Sponsored-by: Catalyst IT Signed-off-by: Jan Kissig Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/Template/Plugin/Branches.pm | 5 ++ circ/branchoverdues.pl | 6 +- circ/branchtransfers.pl | 8 ++- circ/circulation-home.pl | 2 - circ/on-site_checkouts.pl | 8 ++- circ/renew.pl | 7 +- circ/returns.pl | 6 +- circ/selectbranchprinter.pl | 7 +- circ/transferstoreceive.pl | 8 ++- circ/view_holdsqueue.pl | 6 +- circ/waitingreserves.pl | 8 ++- .../bug_16530-add_CircSidebar_syspref.sql | 1 + installer/data/mysql/sysprefs.sql | 1 + .../intranet-tmpl/prog/en/includes/circ-nav.inc | 55 ++++++++++++++++ .../en/modules/admin/preferences/circulation.pref | 6 ++ .../prog/en/modules/circ/branchoverdues.tt | 10 ++- .../prog/en/modules/circ/branchtransfers.tt | 13 +++- .../prog/en/modules/circ/circulation-home.tt | 3 +- .../prog/en/modules/circ/circulation.tt | 20 ++++-- .../prog/en/modules/circ/on-site_checkouts.tt | 3 +- .../intranet-tmpl/prog/en/modules/circ/renew.tt | 14 ++-- .../intranet-tmpl/prog/en/modules/circ/returns.tt | 68 ++++++++++++++++---- .../prog/en/modules/circ/selectbranchprinter.tt | 10 ++- .../prog/en/modules/circ/transferstoreceive.tt | 10 ++- .../prog/en/modules/circ/view_holdsqueue.tt | 10 ++- .../prog/en/modules/circ/waitingreserves.tt | 10 ++- 26 files changed, 257 insertions(+), 48 deletions(-) create mode 100644 installer/data/mysql/atomicupdate/bug_16530-add_CircSidebar_syspref.sql create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/circ-nav.inc hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 3 19:44:50 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Mar 2017 18:44:50 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-557-g5e7a784 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 5e7a78475a7f8fdb178b8beb4c84d781b5f09a72 (commit) from 796379697849d6ca0364a736aa72dfecf28134e6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5e7a78475a7f8fdb178b8beb4c84d781b5f09a72 Author: Kyle M Hall Date: Fri Mar 3 18:36:55 2017 +0000 Bug 16530 - DBRev 16.12.00.013 Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- .../atomicupdate/bug_16530-add_CircSidebar_syspref.sql | 1 - installer/data/mysql/updatedatabase.pl | 11 +++++++++++ 3 files changed, 12 insertions(+), 2 deletions(-) delete mode 100644 installer/data/mysql/atomicupdate/bug_16530-add_CircSidebar_syspref.sql hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 3 19:45:28 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Mar 2017 18:45:28 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-558-g7a5f17f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 7a5f17ff6ecbec3a7f73fa54b900dae909996b29 (commit) from 5e7a78475a7f8fdb178b8beb4c84d781b5f09a72 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7a5f17ff6ecbec3a7f73fa54b900dae909996b29 Author: Aleisha Amohia Date: Thu Feb 16 22:19:59 2017 +0000 Bug 18135: Show alert if no authorities selected in batch record deletion To test: 1) Go to Tools -> Batch record deletion 2) Select Authorities as record type, put in an auth id, click Continue 3) Unselect the authorities and click Delete selected records 4) Confirm an alert shows up 5) Clear the alert and confirm deleting the authority still works as normal Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/tools/batch_delete_records.tt | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 3 20:32:18 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 03 Mar 2017 19:32:18 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-559-gd84ed89 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d84ed89557e2c921f261b1c620434d432dcbd3f7 (commit) from 7a5f17ff6ecbec3a7f73fa54b900dae909996b29 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d84ed89557e2c921f261b1c620434d432dcbd3f7 Author: Colin Campbell Date: Tue Apr 5 12:56:24 2016 +0100 Bug 16202: GetIssuingCharges should return a collectable amount Charges should not include elements less than a penny/cent they are not displayed but can be saved to the database causing "odd" behaviour down the line Make the routine round the resultant charge to nearest cent, so consistent values are returned. Removed the one case where it was rounded post call. Although the main danger is values generated by the discount calculation apply the rounding to all returned charges in case the item charge is defined using the 3rd or 4th decimal places. NOTE: prove -v t/db_dependent/Circulation.t triggers the change. Though, all the returned amounts are 0.00 only. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 6 15:18:36 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 06 Mar 2017 14:18:36 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-560-g59ca80f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 59ca80f2a181a18cb0d568b7ca86d1da99f9748b (commit) from d84ed89557e2c921f261b1c620434d432dcbd3f7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 59ca80f2a181a18cb0d568b7ca86d1da99f9748b Author: Marcel de Rooy Date: Mon Mar 6 10:39:18 2017 +0100 Bug 18215: Resolve warning on $tls in Database.pm Resolve this warning: updatedatabase.pl: Use of uninitialized value $tls in string eq at /usr/share/koha/masterclone/Koha/Database.pm line 63. Test plan: [1] Check if you do not see the warning anymore. Signed-off-by: Magnus Enger Warning disappears after applying the patch. Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/Database.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 13 00:15:22 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sun, 12 Mar 2017 23:15:22 +0000 Subject: [koha-commits] main Koha release repository branch 16.11.x updated. v16.11.04-11-g3dedc5e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 16.11.x has been updated via 3dedc5e4ba1b749e6a8582248bc04a731e01853e (commit) via fbb93fb43002e2d4224e3d7778d3cc91225654a1 (commit) via 9e3f087a6e0ea5c818756da553eb042256175f26 (commit) via 4d4834f1d3de49564357d580248fa5b58b6b93a2 (commit) via 1ce1107af53c58692ea31912f53944ee1c450f6c (commit) via c548686674e991d074f2c67438844b64b0ceb4d7 (commit) via 8a9adc4bc0dff1ed97192997fd3739ef479731d0 (commit) via 6f512cff8b264167f27ff8d007da9b172a772192 (commit) via 9ce369fb8af98b4efa91c3fc25a8a958cea408bc (commit) via 0b1311ccb9f0b0a67ae94f0304ac0bd4f31a7485 (commit) via 56938d7630ae4f90b3bcf650bbce3a6c5ad2c81e (commit) from 829016f8b7e3bf0b10b26f63e0f02418f5352149 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3dedc5e4ba1b749e6a8582248bc04a731e01853e Author: Marc V?ron Date: Wed Feb 15 10:24:56 2017 +0100 Bug 18122 - Audio alerts: Add hint on where to enable sounds This patch adds a hint to page Home > Administration > Audio alerts and related help page about where to enable the sound system (syspref 'AudioAlerts'). To test: - Apply patch - Disable syspref 'AudioAlerts' - Go to Home > Administration > Audio alerts - Note hint below title 'Audio alerts' - Enable syspref 'AudioAlerts' - Go to Home > Administration > Audio alerts - Hint is no longer visible (since audios are enabled) - Open Help page (top right) - Verify that hint on help page makes sense. Amended to add alert class as requested by comment #2 2017-02-21 mv Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit b6cb18c4a8292cabe5fd611b349b51d5c79b5fe4) Signed-off-by: Katrin Fischer commit fbb93fb43002e2d4224e3d7778d3cc91225654a1 Author: Emma Smith Date: Tue Jan 17 03:23:18 2017 +0000 Bug 17840: adding classes to notes in checkouts Test Plan 1) Add an internal and a public note to an item. 2) Check out the item. 3) Verify that both notes are shown in between title and barcode in the second column of the details table. 4) Verify there is an empty class="" in the HTML source code for each 5) Apply patch and refresh page 6) View page source, confirm that class has been changed I tested this by first applying the patch for bug 17919 to catch the check-in software error. Patch working as expected :) Signed-off-by: Claire Gravely Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 257c1793420108f1cb5efdec7bf03649d41940a0) Signed-off-by: Katrin Fischer commit 9e3f087a6e0ea5c818756da553eb042256175f26 Author: Mark Tompsett Date: Tue Feb 21 13:13:02 2017 -0500 Bug 13968: Follow up - Clean HTML tags for hints Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit e9d5615e70056cd887b9471827611a78275016ab) Signed-off-by: Katrin Fischer commit 4d4834f1d3de49564357d580248fa5b58b6b93a2 Author: Marc V?ron Date: Sat Feb 18 17:15:06 2017 +0100 Bug 13968 - Branch email hints are misleading This patch replaces missleading notes with Reply-To and Return-Path fields to reflect indicate falback values if they are empty (ReplyToDefault and ReturnpathDefault system prefs). To test: - Apply patch - In Home > Administration > Libraties and Groups, edit a library - Verify that hints display for fields Reply-To and Return-Path, indicating their default values. Amended to remove extra - 2017-02-21 mv Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit b2eb6109ff308de7d2bc9338d708ac7fe9b6e3d7) Signed-off-by: Katrin Fischer commit 1ce1107af53c58692ea31912f53944ee1c450f6c Author: Jonathan Druart Date: Tue Feb 14 10:52:14 2017 +0100 Bug 18087: Handle invalid filetypes If an invalid file is used as biblionumber list, we should display a message. Test plan: 1/ Use csv, plain text files => Should work 2/ Use invalid files (binary files like pdf, doc*, xsl*, etc.) => Should not work and see a warning message. Amended patch after signoff: Remove one warn debug line Signed-off-by: Joy Nelson Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit d43131c4fca8124a8a9e4dcdea82e2bdf1af196a) Signed-off-by: Katrin Fischer commit c548686674e991d074f2c67438844b64b0ceb4d7 Author: Joy Nelson Date: Thu Feb 9 11:42:57 2017 -0800 Bug 18087 - Clarification on File type when using file of biblionumbers to export data Added a line to the screen detailing the types of files that can be used to upload a list of biblionumbers. Test plan: 1. Go to tools->export data 2. under File option, (File types accepted: .csv and .txt) should appear 3. Check both Bibliographic and Authority Export screens for this new string. Signed-off-by: Claire Gravely Signed-off-by: Joy Nelson Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall (cherry picked from commit 18af48bffe112a5df61a8a546da86dc31f32a7e7) Signed-off-by: Katrin Fischer commit 8a9adc4bc0dff1ed97192997fd3739ef479731d0 Author: Katrin Fischer Date: Sun Mar 12 23:09:39 2017 +0100 Bug 17260: DBRev 16.11.04.001 commit 6f512cff8b264167f27ff8d007da9b172a772192 Author: Blou Date: Fri Jan 27 16:51:26 2017 +0000 Bug 17260: updatedatabase.pl fails on invalid entries in ENUM and BOOLEAN columns The loading of file admin/searchengine/elasticsearch/mappings.yaml specifies 'type' as empty, which fails with Mysql 5.7+ which is more stringent. Also, forcing an empty value into a boolean also fails. Both issues arise when updatedatabase.pl hit 3.23.00.050. NOTE: both issues could also be resolved by actually setting values in the load file. This doesn't make this solution incorrect, though. To Test/reproduce: -1) Happens with Mysql 5.7.4. Maybe earlier, but certainly at that point. Use a Xenial kohadevbox to more easily test. 0) Find a database on 3.22 or earlier, save it. a) place sql_mode=IGNORE_SPACE,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION into the [mysqld] section of /etc/mysql/mysql.conf.d/mysqld.cnf b) restart you mysql server c) drop the db and recreate it d) checkout the 3.22.x branch e) do a web install f) remove the added sql_mode g) restart the mysql server 1) Set your code base to master 2) run updatedatabase.pl 3) See the errors on 3.23.00.050 4) Apply the patch 5) Reload the 3.22 db. a) repeat steps 0(a)-0(g) b) don't forget the caching issues 6) succeed with updatedatabase.pl 7) drop the db and recreate it 8) run the web installer 9) notice no issues either. 10) run koha qa test tools NOTE: This bug only solved the upgrade portion. I added the kohastructure.sql change as well. I confirmed that all the code changes were triggered with this test plan. Signed-off-by: Mark Tompsett Signed-off-by: Mehdi Hamidi Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 77337a2ab537843eab70cc06b8bc2531ad2014dc) Signed-off-by: Katrin Fischer commit 9ce369fb8af98b4efa91c3fc25a8a958cea408bc Author: Jonathan Druart Date: Wed Nov 23 14:47:10 2016 +0000 Bug 18248: Fix SQL statement to setting marc_subfield_structure.authorised_value to NULL We want to update it if it's empty, not equal to ';' nopaste vim mode is to blame Signed-off-by: Kyle M Hall (cherry picked from commit 11bae489bc85a9463712c9caafd2caf7b63155d9) Signed-off-by: Katrin Fischer commit 0b1311ccb9f0b0a67ae94f0304ac0bd4f31a7485 Author: Aleisha Amohia Date: Mon Jan 23 22:32:39 2017 +0000 Bug 17947: Searching my library first shows the branchcode by the search bar rather than branchname Test Plan 1: Turn on SearchMyLibraryFirst and go into OPAC 2: It should say Search (in Only) 3: Apply patch and refresh page. It should now say Search (in only) Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit e8420b5d80558a8a74f7f6a1421352dcad2c9c88) Signed-off-by: Katrin Fischer commit 56938d7630ae4f90b3bcf650bbce3a6c5ad2c81e Author: Aleisha Amohia Date: Fri Jan 13 00:19:48 2017 +0000 Bug 17895: 'Re-set' typo fix To test: 1) Log into OPAC and go to change your password 2) Enter current password incorrectly and click Submit changes 3) Observe error message and typo 're-set' 4) Apply patch and refresh page 5) May be asked to resend data - if so, click Resend, if not, repeat step 2 6) Observe error message and corrected spelling of 'reset' Sponsored-by: Catalyst IT Signed-off-by: Caitlin Goodger Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 86ec263b2d0994ecb53ff283ef246b529d4570e2) Signed-off-by: Katrin Fischer ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- Koha/SearchEngine/Elasticsearch.pm | 2 +- installer/data/mysql/kohastructure.sql | 2 +- installer/data/mysql/updatedatabase.pl | 15 +++++++++++++-- .../intranet-tmpl/prog/en/modules/admin/audio_alerts.tt | 7 +++++++ .../intranet-tmpl/prog/en/modules/admin/branches.tt | 4 ++-- .../prog/en/modules/help/admin/audio_alerts.tt | 2 ++ koha-tmpl/intranet-tmpl/prog/en/modules/tools/export.tt | 13 +++++++++++-- koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 10 ++-------- koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-passwd.tt | 2 +- tools/export.pl | 12 ++++++++++++ 12 files changed, 54 insertions(+), 19 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Mar 14 14:08:04 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 14 Mar 2017 13:08:04 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-561-g13de29a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 13de29ad4465b964e37d4f460f5c9145e23939a1 (commit) from 59ca80f2a181a18cb0d568b7ca86d1da99f9748b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 13de29ad4465b964e37d4f460f5c9145e23939a1 Author: Marcel de Rooy Date: Thu Jan 19 15:43:38 2017 +0100 Bug 7143: Replace Santallan by Santellan Missed one typo in about.tt. Can go along with the next patch here. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Mar 14 17:43:31 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 14 Mar 2017 16:43:31 +0000 Subject: [koha-commits] main Koha release repository branch 16.11.x updated. v16.11.04-14-g661e638 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 16.11.x has been updated via 661e6389c990c603cbc6a0a9444c27ec9d01afe2 (commit) via 8b58728a7c0fa8f03dc86729a62f12fdd3154462 (commit) via e817334a06ae8acdc2118525618d0e3010dd06d3 (commit) from 3dedc5e4ba1b749e6a8582248bc04a731e01853e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 661e6389c990c603cbc6a0a9444c27ec9d01afe2 Author: Colin Campbell Date: Tue Apr 5 12:56:24 2016 +0100 Bug 16202: GetIssuingCharges should return a collectable amount Charges should not include elements less than a penny/cent they are not displayed but can be saved to the database causing "odd" behaviour down the line Make the routine round the resultant charge to nearest cent, so consistent values are returned. Removed the one case where it was rounded post call. Although the main danger is values generated by the discount calculation apply the rounding to all returned charges in case the item charge is defined using the 3rd or 4th decimal places. NOTE: prove -v t/db_dependent/Circulation.t triggers the change. Though, all the returned amounts are 0.00 only. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit d84ed89557e2c921f261b1c620434d432dcbd3f7) Signed-off-by: Katrin Fischer commit 8b58728a7c0fa8f03dc86729a62f12fdd3154462 Author: Marcel de Rooy Date: Thu Jan 19 15:43:38 2017 +0100 Bug 7143: Replace Santallan by Santellan Missed one typo in about.tt. Can go along with the next patch here. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 13de29ad4465b964e37d4f460f5c9145e23939a1) Signed-off-by: Katrin Fischer commit e817334a06ae8acdc2118525618d0e3010dd06d3 Author: Aleisha Amohia Date: Thu Feb 16 22:19:59 2017 +0000 Bug 18135: Show alert if no authorities selected in batch record deletion To test: 1) Go to Tools -> Batch record deletion 2) Select Authorities as record type, put in an auth id, click Continue 3) Unselect the authorities and click Delete selected records 4) Confirm an alert shows up 5) Clear the alert and confirm deleting the authority still works as normal Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 7a5f17ff6ecbec3a7f73fa54b900dae909996b29) Signed-off-by: Katrin Fischer ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 4 +++- koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 2 +- .../prog/en/modules/tools/batch_delete_records.tt | 10 +++++++++- 3 files changed, 13 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 15 12:19:40 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 15 Mar 2017 11:19:40 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.17-3-g8c47d3b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 8c47d3bd2bb5b8d267bdac545b6c44463a581fa1 (commit) via c9f81961d5a1d4ac062cf2565b86dbbe5dcb3e94 (commit) via 82559d5ad55e4f057f795b7afc570bae963150fd (commit) from ccf341a5e66a3b5b25dd685d4c7ec47d9ff7807c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8c47d3bd2bb5b8d267bdac545b6c44463a581fa1 Author: Julian Maurice Date: Wed Mar 15 11:38:28 2017 +0100 Bug 18111: Follow-up for 3.22.x Replace [% frameworkcode %] by 'default' wherever needed commit c9f81961d5a1d4ac062cf2565b86dbbe5dcb3e94 Author: Mark Tompsett Date: Sat Feb 18 23:06:16 2017 -0500 Bug 18111: Swap framework_name and frameworkcode With the frameworkcode changed to an empty string, which really is closer to the physical reality, some javascript somewhere breaks. This means the spinner does not appear when you confirm that you wish to import it. TEST PLAN ---------- 1) apply first patch 2) export default framework, doesn't matter format 3) import default framework using that file. 4) answer yes or whatever it is. -- spinner does not appear. 5) apply this patch 6) import default framework use the same file. 7) answer yes or whatever it is. -- spinner does appear. 8) decide if you wish to find and fix the javascript conditions. if yes -- do so, and then obsolete this once you have. if not -- sign this off after running koha qa test tools Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Mason James (cherry picked from commit 3b4e164903ec532ad616d7e9021719bbd00b292e) Signed-off-by: Julian Maurice commit 82559d5ad55e4f057f795b7afc570bae963150fd Author: Jonathan Druart Date: Tue Feb 14 16:21:45 2017 +0000 Bug 18111: Fix import of default framework Caused by bug 16035. Recreate the issue: Go to Home ? Administration ? MARC frameworks For the default framework: Actions > import It will not work Test plan: Confirm test plans from bug 16035 and bug 17389 still pass Confirm that the import for the default framework now works Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Mason James (cherry picked from commit 07eefd02ba363c6072b6370e4360a91360e31ab2) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: admin/import_export_framework.pl | 19 +++++------- .../prog/en/modules/admin/biblio_framework.tt | 32 ++++++++++---------- 2 files changed, 24 insertions(+), 27 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 15 12:22:22 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 15 Mar 2017 11:22:22 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.17-4-gb40ab81 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via b40ab81d93e9e7bb6acd59c6cd4209358bd9ac72 (commit) from 8c47d3bd2bb5b8d267bdac545b6c44463a581fa1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b40ab81d93e9e7bb6acd59c6cd4209358bd9ac72 Author: Luke Honiss Date: Tue Jan 17 02:27:55 2017 +0000 Bug 17865 'If a subscription has no history end date, it shows as expired today in OPAC' --TEST PLAN-- 1) View a subscription with no history end date 2) Search for an item with a subcription in OPAC 3) Under subscription tab click more details 4) The end date will be the current date 5) Apply patch and refresh 6) The end date will not be shown Signed-off-by: Baptiste Wojtkowski Signed-off-by: Jonathan Druart Signed-off-by: Mason James (cherry picked from commit 8b096e91f1c07ba0295ef3fdc700eefb7d3a9834) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/Serials.pm | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 15 12:24:18 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 15 Mar 2017 11:24:18 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.17-6-g96c08a9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 96c08a967ed4415717c075b49bf9db314229f28e (commit) via 68242470b96ae89452c50a69f44e53255a6a3d6c (commit) from b40ab81d93e9e7bb6acd59c6cd4209358bd9ac72 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 96c08a967ed4415717c075b49bf9db314229f28e Author: Caitlin Goodger Date: Thu Jan 19 00:54:24 2017 +0000 Bug 17852 Follow up.Multiple URLs (856) in list email are broken This is a follow-up to my previous patch. This fixes it on the OPAC and the previous one was from the intranet Test Plan 1: Add multiple urls to a biblographic record 2: Add the biblographic record to a list and then email it from the OPAC 3: See that the links are broken and have been merged into one. 4: Apply patch 5: Send the list again and see that the links work Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Mason James (cherry picked from commit e914a29788a1a85399a135d3cfd19ef9ee6f5a28) Signed-off-by: Julian Maurice commit 68242470b96ae89452c50a69f44e53255a6a3d6c Author: Caitlin Goodger Date: Tue Jan 17 21:37:49 2017 +0000 Bug 17852; Multiple URLs (856) in list email are broken. Test Plan 1: Add multiple urls to a biblographic record 2: Add the biblographic record to a list and then email it. 3: See that the links are broken and have been merged into one. 4: Apply patch 5: Send the list again and see that the links work Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Mason James (cherry picked from commit bcbd75fba2bc69b3aa26672db16d350a09d48c25) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/sendshelf.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelf.tt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 15 12:36:38 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 15 Mar 2017 11:36:38 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.17-8-g27217f2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 27217f2b3409100f3198d70fd701252637137264 (commit) via fb8f062d83539dcc67bbc753de5e4b332fb960d0 (commit) from 96c08a967ed4415717c075b49bf9db314229f28e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 27217f2b3409100f3198d70fd701252637137264 Author: Aleisha Amohia Date: Mon Jan 23 22:32:39 2017 +0000 Bug 17947: Searching my library first shows the branchcode by the search bar rather than branchname Test Plan 1: Turn on SearchMyLibraryFirst and go into OPAC 2: It should say Search (in Only) 3: Apply patch and refresh page. It should now say Search (in only) Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit e8420b5d80558a8a74f7f6a1421352dcad2c9c88) Signed-off-by: Katrin Fischer (cherry picked from commit 0b1311ccb9f0b0a67ae94f0304ac0bd4f31a7485) Signed-off-by: Julian Maurice commit fb8f062d83539dcc67bbc753de5e4b332fb960d0 Author: Aleisha Amohia Date: Fri Jan 13 00:19:48 2017 +0000 Bug 17895: 'Re-set' typo fix To test: 1) Log into OPAC and go to change your password 2) Enter current password incorrectly and click Submit changes 3) Observe error message and typo 're-set' 4) Apply patch and refresh page 5) May be asked to resend data - if so, click Resend, if not, repeat step 2 6) Observe error message and corrected spelling of 'reset' Sponsored-by: Catalyst IT Signed-off-by: Caitlin Goodger Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 86ec263b2d0994ecb53ff283ef246b529d4570e2) Signed-off-by: Katrin Fischer (cherry picked from commit 56938d7630ae4f90b3bcf650bbce3a6c5ad2c81e) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc | 3 ++- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-passwd.tt | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 15 12:44:21 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 15 Mar 2017 11:44:21 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.17-9-g5c152f4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 5c152f45dfa2a0bc2af908b3e4d8676e75a19568 (commit) from 27217f2b3409100f3198d70fd701252637137264 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5c152f45dfa2a0bc2af908b3e4d8676e75a19568 Author: Colin Campbell Date: Tue Apr 5 12:56:24 2016 +0100 Bug 16202: GetIssuingCharges should return a collectable amount Charges should not include elements less than a penny/cent they are not displayed but can be saved to the database causing "odd" behaviour down the line Make the routine round the resultant charge to nearest cent, so consistent values are returned. Removed the one case where it was rounded post call. Although the main danger is values generated by the discount calculation apply the rounding to all returned charges in case the item charge is defined using the 3rd or 4th decimal places. NOTE: prove -v t/db_dependent/Circulation.t triggers the change. Though, all the returned amounts are 0.00 only. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit d84ed89557e2c921f261b1c620434d432dcbd3f7) Signed-off-by: Katrin Fischer (cherry picked from commit 661e6389c990c603cbc6a0a9444c27ec9d01afe2) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 20 13:38:05 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 20 Mar 2017 12:38:05 +0000 Subject: [koha-commits] main Koha release repository annotated tag v3.22.18 created. v3.22.18 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The annotated tag, v3.22.18 has been created at 3f826df0081e9cdaa345b5aab3736a223b239266 (tag) tagging 2effbe144aa2cfed98ca5e615042925faa81465c (commit) replaces v3.22.17 tagged by Julian Maurice on Fri Mar 17 10:47:08 2017 +0100 - Log ----------------------------------------------------------------- Koha release 3.22.18 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAABAgAGBQJYy7CcAAoJELCH1RJUPDmp79oQANS9C68MLmuBVs11ZH4yvpbe e1J64xgfncQ4zqtD2f6LJ9o/Joy0bL54koKPNuV7oYcJdgWKTdsP8wSUApbDKH/Q Aptt5swQ+f/4hvqSaeZzSBM9+v28HJLb7a1wXs4ZrSKTY1FOYYFqG1zyUJ/4kjnb ivF8GaN2pI6gNX6ve4MHyPHIQ1fCCAgbF+GWBW0RxUuoJ8VORVo2pqup8g67ibnj Owv+PuZn08e10kavB5lcMXhJY4hsmImlikMOnWwkMXU1CzlPKN/YlezdXtF9LlbM VqOMUp+O0R4LVTRISco17C/SCjxdlZ8VyRYUSpjYo0RFofWr+JV/EBhHfX+B/mtX 3zk7ECT0iUKdKn2+niRfYT6fA1jysC7VGvtkVrNc7s0NRiGvib87cs5CSXO+UHU0 WUTlS13Nh9Fd/VRuQ85atPooPsslmMX+ScXZkyC2MBufrXUqxbPH/lkBkNARwr9Z UEiurPcgw7sM8s6dd+Pg2ptBxxxkt2MkdHxzpFhyDyc4F1AaDQuE7VvF9oHFJZ62 jURZkaskmfeXXs3AwW+YEP67z4oxg0vpaj7BAVliNLiCE5rKzoYaBWVlmpLrn8wl twrAIEYaHS/Tjf1YWu7j8bX9bYWPmbZL7/yXvoLIVc6JLI8xG8EtjjkjYKRbY0SP YXlR6s/2ExDO+JyW7mq7 =IGwE -----END PGP SIGNATURE----- Aleisha Amohia (2): Bug 17895: 'Re-set' typo fix Bug 17947: Searching my library first shows the branchcode by the search bar rather than branchname Caitlin Goodger (2): Bug 17852; Multiple URLs (856) in list email are broken. Bug 17852 Follow up.Multiple URLs (856) in list email are broken Colin Campbell (1): Bug 16202: GetIssuingCharges should return a collectable amount Jonathan Druart (2): Bug 18111: Fix import of default framework Bug 18275: Do not rely on CGI param userid to log a user in if auth is not required Julian Maurice (4): Bug 18111: Follow-up for 3.22.x Translation updates for 3.22.18 Update release notes for 3.22.18 Increment version for 3.22.18 Luke Honiss (1): Bug 17865 'If a subscription has no history end date, it shows as expired today in OPAC' Mark Tompsett (1): Bug 18111: Swap framework_name and frameworkcode Tomas Cohen Arazi (1): Bug 18275: Regression test ----------------------------------------------------------------------- hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 20 13:37:45 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 20 Mar 2017 12:37:45 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.18 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 2effbe144aa2cfed98ca5e615042925faa81465c (commit) via 6481b532dbf0835cfc2ea2d37165846c98a58050 (commit) via 91ca766103bf7c5360aa41778b076c7a9937c0f4 (commit) via f1c9d2e2653912343c07d08bccf0f7f72616f0bb (commit) via 5690d6bc540dcb9d3f2597065c737e2e7df1f121 (commit) from 5c152f45dfa2a0bc2af908b3e4d8676e75a19568 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2effbe144aa2cfed98ca5e615042925faa81465c Author: Julian Maurice Date: Fri Mar 17 09:31:49 2017 +0100 Increment version for 3.22.18 commit 6481b532dbf0835cfc2ea2d37165846c98a58050 Author: Julian Maurice Date: Fri Mar 17 09:44:22 2017 +0100 Update release notes for 3.22.18 commit 91ca766103bf7c5360aa41778b076c7a9937c0f4 Author: Julian Maurice Date: Fri Mar 17 10:12:40 2017 +0100 Translation updates for 3.22.18 commit f1c9d2e2653912343c07d08bccf0f7f72616f0bb Author: Jonathan Druart Date: Wed Mar 15 14:52:49 2017 -0300 Bug 18275: Do not rely on CGI param userid to log a user in if auth is not required From opac/opac-memberentry.pl, authnotrequired is set. That means a patron can access the page without being logged in. It is used on this page for the self registration feature. From C4::Auth::get_template_and_user, we have $userid = $q_userid; $q_userid is previously set to the 'userid' CGI param. We end up here if authonotrequired is set AND CGISESSID does not exist. Test plan: - Run: $ prove t/db_dependent/Auth.t => FAIL: Regression test for checkauth fails - Apply this patch - Run: $ prove t/db_dependent/Auth.t => SUCCESS: Tests pass. - Sign off :-D Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi commit 5690d6bc540dcb9d3f2597065c737e2e7df1f121 Author: Tomas Cohen Arazi Date: Thu Mar 16 09:23:24 2017 -0300 Bug 18275: Regression test Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 9 +- Koha.pm | 2 +- installer/data/mysql/updatedatabase.pl | 6 + ...e_notes_3_22_16.md => release_notes_3_22_18.md} | 101 ++++-- misc/translator/po/am-Ethi-marc-MARC21.po | 2 +- misc/translator/po/am-Ethi-marc-NORMARC.po | 2 +- misc/translator/po/am-Ethi-marc-UNIMARC.po | 2 +- misc/translator/po/am-Ethi-opac-bootstrap.po | 2 +- misc/translator/po/am-Ethi-pref.po | 26 +- misc/translator/po/am-Ethi-staff-help.po | 2 +- misc/translator/po/am-Ethi-staff-prog.po | 340 +++++++++--------- misc/translator/po/ar-Arab-marc-MARC21.po | 2 +- misc/translator/po/ar-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ar-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ar-Arab-opac-bootstrap.po | 2 +- misc/translator/po/ar-Arab-pref.po | 36 +- misc/translator/po/ar-Arab-staff-help.po | 2 +- misc/translator/po/ar-Arab-staff-prog.po | 344 +++++++++--------- misc/translator/po/az-AZ-marc-MARC21.po | 2 +- misc/translator/po/az-AZ-marc-NORMARC.po | 2 +- misc/translator/po/az-AZ-marc-UNIMARC.po | 2 +- misc/translator/po/az-AZ-opac-bootstrap.po | 2 +- misc/translator/po/az-AZ-pref.po | 30 +- misc/translator/po/az-AZ-staff-help.po | 2 +- misc/translator/po/az-AZ-staff-prog.po | 340 +++++++++--------- misc/translator/po/be-BY-marc-MARC21.po | 2 +- misc/translator/po/be-BY-marc-NORMARC.po | 2 +- misc/translator/po/be-BY-marc-UNIMARC.po | 2 +- misc/translator/po/be-BY-opac-bootstrap.po | 2 +- misc/translator/po/be-BY-pref.po | 32 +- misc/translator/po/be-BY-staff-help.po | 2 +- misc/translator/po/be-BY-staff-prog.po | 340 +++++++++--------- misc/translator/po/bg-Cyrl-marc-MARC21.po | 2 +- misc/translator/po/bg-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/bg-Cyrl-marc-UNIMARC.po | 2 +- misc/translator/po/bg-Cyrl-opac-bootstrap.po | 2 +- misc/translator/po/bg-Cyrl-pref.po | 30 +- misc/translator/po/bg-Cyrl-staff-help.po | 2 +- misc/translator/po/bg-Cyrl-staff-prog.po | 340 +++++++++--------- misc/translator/po/bn-IN-marc-MARC21.po | 2 +- misc/translator/po/bn-IN-marc-NORMARC.po | 2 +- misc/translator/po/bn-IN-marc-UNIMARC.po | 2 +- misc/translator/po/bn-IN-opac-bootstrap.po | 2 +- misc/translator/po/bn-IN-pref.po | 30 +- misc/translator/po/bn-IN-staff-help.po | 2 +- misc/translator/po/bn-IN-staff-prog.po | 340 +++++++++--------- misc/translator/po/ca-ES-marc-MARC21.po | 2 +- misc/translator/po/ca-ES-marc-NORMARC.po | 2 +- misc/translator/po/ca-ES-marc-UNIMARC.po | 2 +- misc/translator/po/ca-ES-opac-bootstrap.po | 10 +- misc/translator/po/ca-ES-pref.po | 26 +- misc/translator/po/ca-ES-staff-help.po | 2 +- misc/translator/po/ca-ES-staff-prog.po | 348 +++++++++--------- misc/translator/po/cs-CZ-marc-MARC21.po | 2 +- misc/translator/po/cs-CZ-marc-NORMARC.po | 2 +- misc/translator/po/cs-CZ-marc-UNIMARC.po | 2 +- misc/translator/po/cs-CZ-opac-bootstrap.po | 2 +- misc/translator/po/cs-CZ-pref.po | 36 +- misc/translator/po/cs-CZ-staff-help.po | 2 +- misc/translator/po/cs-CZ-staff-prog.po | 344 +++++++++--------- misc/translator/po/cy-GB-marc-MARC21.po | 2 +- misc/translator/po/cy-GB-marc-NORMARC.po | 2 +- misc/translator/po/cy-GB-marc-UNIMARC.po | 2 +- misc/translator/po/cy-GB-opac-bootstrap.po | 2 +- misc/translator/po/cy-GB-pref.po | 26 +- misc/translator/po/cy-GB-staff-help.po | 2 +- misc/translator/po/cy-GB-staff-prog.po | 340 +++++++++--------- misc/translator/po/da-DK-marc-MARC21.po | 2 +- misc/translator/po/da-DK-marc-NORMARC.po | 2 +- misc/translator/po/da-DK-marc-UNIMARC.po | 2 +- misc/translator/po/da-DK-opac-bootstrap.po | 2 +- misc/translator/po/da-DK-pref.po | 36 +- misc/translator/po/da-DK-staff-help.po | 2 +- misc/translator/po/da-DK-staff-prog.po | 340 +++++++++--------- misc/translator/po/de-CH-marc-MARC21.po | 2 +- misc/translator/po/de-CH-marc-NORMARC.po | 2 +- misc/translator/po/de-CH-marc-UNIMARC.po | 2 +- misc/translator/po/de-CH-opac-bootstrap.po | 2 +- misc/translator/po/de-CH-pref.po | 36 +- misc/translator/po/de-CH-staff-help.po | 2 +- misc/translator/po/de-CH-staff-prog.po | 344 +++++++++--------- misc/translator/po/de-DE-marc-MARC21.po | 2 +- misc/translator/po/de-DE-marc-NORMARC.po | 2 +- misc/translator/po/de-DE-marc-UNIMARC.po | 2 +- misc/translator/po/de-DE-opac-bootstrap.po | 2 +- misc/translator/po/de-DE-pref.po | 36 +- misc/translator/po/de-DE-staff-help.po | 4 +- misc/translator/po/de-DE-staff-prog.po | 344 +++++++++--------- misc/translator/po/el-GR-marc-MARC21.po | 2 +- misc/translator/po/el-GR-marc-NORMARC.po | 2 +- misc/translator/po/el-GR-marc-UNIMARC.po | 2 +- misc/translator/po/el-GR-opac-bootstrap.po | 8 +- misc/translator/po/el-GR-pref.po | 32 +- misc/translator/po/el-GR-staff-help.po | 2 +- misc/translator/po/el-GR-staff-prog.po | 376 ++++++++++---------- misc/translator/po/en-GB-marc-MARC21.po | 2 +- misc/translator/po/en-GB-marc-NORMARC.po | 2 +- misc/translator/po/en-GB-marc-UNIMARC.po | 2 +- misc/translator/po/en-GB-opac-bootstrap.po | 2 +- misc/translator/po/en-GB-pref.po | 30 +- misc/translator/po/en-GB-staff-help.po | 2 +- misc/translator/po/en-GB-staff-prog.po | 340 +++++++++--------- misc/translator/po/en-NZ-marc-MARC21.po | 2 +- misc/translator/po/en-NZ-marc-NORMARC.po | 2 +- misc/translator/po/en-NZ-marc-UNIMARC.po | 2 +- misc/translator/po/en-NZ-opac-bootstrap.po | 2 +- misc/translator/po/en-NZ-pref.po | 36 +- misc/translator/po/en-NZ-staff-help.po | 2 +- misc/translator/po/en-NZ-staff-prog.po | 344 +++++++++--------- misc/translator/po/eo-marc-MARC21.po | 2 +- misc/translator/po/eo-marc-NORMARC.po | 2 +- misc/translator/po/eo-marc-UNIMARC.po | 2 +- misc/translator/po/eo-opac-bootstrap.po | 2 +- misc/translator/po/eo-pref.po | 26 +- misc/translator/po/eo-staff-help.po | 2 +- misc/translator/po/eo-staff-prog.po | 340 +++++++++--------- misc/translator/po/es-ES-marc-MARC21.po | 6 +- misc/translator/po/es-ES-marc-NORMARC.po | 2 +- misc/translator/po/es-ES-marc-UNIMARC.po | 2 +- misc/translator/po/es-ES-opac-bootstrap.po | 2 +- misc/translator/po/es-ES-pref.po | 40 ++- misc/translator/po/es-ES-staff-help.po | 2 +- misc/translator/po/es-ES-staff-prog.po | 358 ++++++++++--------- misc/translator/po/eu-marc-MARC21.po | 2 +- misc/translator/po/eu-marc-NORMARC.po | 2 +- misc/translator/po/eu-marc-UNIMARC.po | 2 +- misc/translator/po/eu-opac-bootstrap.po | 2 +- misc/translator/po/eu-pref.po | 26 +- misc/translator/po/eu-staff-help.po | 2 +- misc/translator/po/eu-staff-prog.po | 340 +++++++++--------- misc/translator/po/fa-Arab-marc-MARC21.po | 2 +- misc/translator/po/fa-Arab-marc-NORMARC.po | 2 +- misc/translator/po/fa-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/fa-Arab-opac-bootstrap.po | 2 +- misc/translator/po/fa-Arab-pref.po | 36 +- misc/translator/po/fa-Arab-staff-help.po | 2 +- misc/translator/po/fa-Arab-staff-prog.po | 340 +++++++++--------- misc/translator/po/fi-FI-marc-MARC21.po | 2 +- misc/translator/po/fi-FI-marc-NORMARC.po | 2 +- misc/translator/po/fi-FI-marc-UNIMARC.po | 2 +- misc/translator/po/fi-FI-opac-bootstrap.po | 2 +- misc/translator/po/fi-FI-pref.po | 36 +- misc/translator/po/fi-FI-staff-help.po | 2 +- misc/translator/po/fi-FI-staff-prog.po | 344 +++++++++--------- misc/translator/po/fo-FO-marc-MARC21.po | 2 +- misc/translator/po/fo-FO-marc-NORMARC.po | 2 +- misc/translator/po/fo-FO-marc-UNIMARC.po | 2 +- misc/translator/po/fo-FO-opac-bootstrap.po | 2 +- misc/translator/po/fo-FO-pref.po | 26 +- misc/translator/po/fo-FO-staff-help.po | 2 +- misc/translator/po/fo-FO-staff-prog.po | 340 +++++++++--------- misc/translator/po/fr-CA-marc-MARC21.po | 2 +- misc/translator/po/fr-CA-marc-NORMARC.po | 2 +- misc/translator/po/fr-CA-marc-UNIMARC.po | 2 +- misc/translator/po/fr-CA-opac-bootstrap.po | 2 +- misc/translator/po/fr-CA-pref.po | 36 +- misc/translator/po/fr-CA-staff-help.po | 2 +- misc/translator/po/fr-CA-staff-prog.po | 344 +++++++++--------- misc/translator/po/fr-FR-marc-MARC21.po | 2 +- misc/translator/po/fr-FR-marc-NORMARC.po | 2 +- misc/translator/po/fr-FR-marc-UNIMARC.po | 2 +- misc/translator/po/fr-FR-opac-bootstrap.po | 2 +- misc/translator/po/fr-FR-pref.po | 36 +- misc/translator/po/fr-FR-staff-help.po | 2 +- misc/translator/po/fr-FR-staff-prog.po | 344 +++++++++--------- misc/translator/po/gl-marc-MARC21.po | 2 +- misc/translator/po/gl-marc-NORMARC.po | 2 +- misc/translator/po/gl-marc-UNIMARC.po | 2 +- misc/translator/po/gl-opac-bootstrap.po | 2 +- misc/translator/po/gl-pref.po | 30 +- misc/translator/po/gl-staff-help.po | 2 +- misc/translator/po/gl-staff-prog.po | 340 +++++++++--------- misc/translator/po/he-Hebr-marc-MARC21.po | 2 +- misc/translator/po/he-Hebr-marc-NORMARC.po | 2 +- misc/translator/po/he-Hebr-marc-UNIMARC.po | 2 +- misc/translator/po/he-Hebr-opac-bootstrap.po | 2 +- misc/translator/po/he-Hebr-pref.po | 26 +- misc/translator/po/he-Hebr-staff-help.po | 2 +- misc/translator/po/he-Hebr-staff-prog.po | 340 +++++++++--------- misc/translator/po/hi-marc-MARC21.po | 2 +- misc/translator/po/hi-marc-NORMARC.po | 2 +- misc/translator/po/hi-marc-UNIMARC.po | 2 +- misc/translator/po/hi-opac-bootstrap.po | 2 +- misc/translator/po/hi-pref.po | 41 ++- misc/translator/po/hi-staff-help.po | 2 +- misc/translator/po/hi-staff-prog.po | 360 +++++++++---------- misc/translator/po/hr-HR-marc-MARC21.po | 2 +- misc/translator/po/hr-HR-marc-NORMARC.po | 2 +- misc/translator/po/hr-HR-marc-UNIMARC.po | 2 +- misc/translator/po/hr-HR-opac-bootstrap.po | 2 +- misc/translator/po/hr-HR-pref.po | 26 +- misc/translator/po/hr-HR-staff-help.po | 2 +- misc/translator/po/hr-HR-staff-prog.po | 340 +++++++++--------- misc/translator/po/hu-HU-marc-MARC21.po | 2 +- misc/translator/po/hu-HU-marc-NORMARC.po | 2 +- misc/translator/po/hu-HU-marc-UNIMARC.po | 2 +- misc/translator/po/hu-HU-opac-bootstrap.po | 2 +- misc/translator/po/hu-HU-pref.po | 30 +- misc/translator/po/hu-HU-staff-help.po | 2 +- misc/translator/po/hu-HU-staff-prog.po | 340 +++++++++--------- misc/translator/po/hy-Armn-marc-MARC21.po | 10 +- misc/translator/po/hy-Armn-marc-NORMARC.po | 2 +- misc/translator/po/hy-Armn-marc-UNIMARC.po | 2 +- misc/translator/po/hy-Armn-opac-bootstrap.po | 2 +- misc/translator/po/hy-Armn-pref.po | 40 ++- misc/translator/po/hy-Armn-staff-help.po | 2 +- misc/translator/po/hy-Armn-staff-prog.po | 369 +++++++++---------- misc/translator/po/ia-marc-MARC21.po | 2 +- misc/translator/po/ia-marc-NORMARC.po | 2 +- misc/translator/po/ia-marc-UNIMARC.po | 2 +- misc/translator/po/ia-opac-bootstrap.po | 2 +- misc/translator/po/ia-pref.po | 26 +- misc/translator/po/ia-staff-help.po | 2 +- misc/translator/po/ia-staff-prog.po | 340 +++++++++--------- misc/translator/po/id-ID-marc-MARC21.po | 2 +- misc/translator/po/id-ID-marc-NORMARC.po | 2 +- misc/translator/po/id-ID-marc-UNIMARC.po | 2 +- misc/translator/po/id-ID-opac-bootstrap.po | 2 +- misc/translator/po/id-ID-pref.po | 30 +- misc/translator/po/id-ID-staff-help.po | 2 +- misc/translator/po/id-ID-staff-prog.po | 340 +++++++++--------- misc/translator/po/iq-CA-marc-MARC21.po | 2 +- misc/translator/po/iq-CA-marc-NORMARC.po | 2 +- misc/translator/po/iq-CA-marc-UNIMARC.po | 2 +- misc/translator/po/iq-CA-opac-bootstrap.po | 2 +- misc/translator/po/iq-CA-pref.po | 26 +- misc/translator/po/iq-CA-staff-help.po | 2 +- misc/translator/po/iq-CA-staff-prog.po | 340 +++++++++--------- misc/translator/po/is-IS-marc-MARC21.po | 2 +- misc/translator/po/is-IS-marc-NORMARC.po | 2 +- misc/translator/po/is-IS-marc-UNIMARC.po | 2 +- misc/translator/po/is-IS-opac-bootstrap.po | 2 +- misc/translator/po/is-IS-pref.po | 30 +- misc/translator/po/is-IS-staff-help.po | 2 +- misc/translator/po/is-IS-staff-prog.po | 340 +++++++++--------- misc/translator/po/it-IT-marc-MARC21.po | 10 +- misc/translator/po/it-IT-marc-NORMARC.po | 2 +- misc/translator/po/it-IT-marc-UNIMARC.po | 2 +- misc/translator/po/it-IT-opac-bootstrap.po | 12 +- misc/translator/po/it-IT-pref.po | 60 +++- misc/translator/po/it-IT-staff-help.po | 2 +- misc/translator/po/it-IT-staff-prog.po | 369 +++++++++---------- misc/translator/po/iu-CA-marc-MARC21.po | 2 +- misc/translator/po/iu-CA-marc-NORMARC.po | 2 +- misc/translator/po/iu-CA-marc-UNIMARC.po | 2 +- misc/translator/po/iu-CA-opac-bootstrap.po | 2 +- misc/translator/po/iu-CA-pref.po | 26 +- misc/translator/po/iu-CA-staff-help.po | 2 +- misc/translator/po/iu-CA-staff-prog.po | 340 +++++++++--------- misc/translator/po/ja-Jpan-JP-marc-MARC21.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-NORMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-UNIMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-opac-bootstrap.po | 2 +- misc/translator/po/ja-Jpan-JP-pref.po | 26 +- misc/translator/po/ja-Jpan-JP-staff-help.po | 2 +- misc/translator/po/ja-Jpan-JP-staff-prog.po | 340 +++++++++--------- misc/translator/po/ka-marc-MARC21.po | 2 +- misc/translator/po/ka-marc-NORMARC.po | 2 +- misc/translator/po/ka-marc-UNIMARC.po | 2 +- misc/translator/po/ka-opac-bootstrap.po | 2 +- misc/translator/po/ka-pref.po | 26 +- misc/translator/po/ka-staff-help.po | 2 +- misc/translator/po/ka-staff-prog.po | 340 +++++++++--------- misc/translator/po/km-KH-marc-MARC21.po | 2 +- misc/translator/po/km-KH-marc-NORMARC.po | 2 +- misc/translator/po/km-KH-marc-UNIMARC.po | 2 +- misc/translator/po/km-KH-opac-bootstrap.po | 2 +- misc/translator/po/km-KH-pref.po | 26 +- misc/translator/po/km-KH-staff-help.po | 2 +- misc/translator/po/km-KH-staff-prog.po | 340 +++++++++--------- misc/translator/po/kn-Knda-marc-MARC21.po | 2 +- misc/translator/po/kn-Knda-marc-NORMARC.po | 2 +- misc/translator/po/kn-Knda-marc-UNIMARC.po | 2 +- misc/translator/po/kn-Knda-opac-bootstrap.po | 2 +- misc/translator/po/kn-Knda-pref.po | 26 +- misc/translator/po/kn-Knda-staff-help.po | 2 +- misc/translator/po/kn-Knda-staff-prog.po | 340 +++++++++--------- misc/translator/po/ko-Kore-KP-marc-MARC21.po | 2 +- misc/translator/po/ko-Kore-KP-marc-NORMARC.po | 2 +- misc/translator/po/ko-Kore-KP-marc-UNIMARC.po | 2 +- misc/translator/po/ko-Kore-KP-opac-bootstrap.po | 2 +- misc/translator/po/ko-Kore-KP-pref.po | 36 +- misc/translator/po/ko-Kore-KP-staff-help.po | 2 +- misc/translator/po/ko-Kore-KP-staff-prog.po | 344 +++++++++--------- misc/translator/po/ku-Arab-marc-MARC21.po | 2 +- misc/translator/po/ku-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ku-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ku-Arab-opac-bootstrap.po | 2 +- misc/translator/po/ku-Arab-pref.po | 30 +- misc/translator/po/ku-Arab-staff-help.po | 2 +- misc/translator/po/ku-Arab-staff-prog.po | 340 +++++++++--------- misc/translator/po/lo-Laoo-marc-MARC21.po | 2 +- misc/translator/po/lo-Laoo-marc-NORMARC.po | 2 +- misc/translator/po/lo-Laoo-marc-UNIMARC.po | 2 +- misc/translator/po/lo-Laoo-opac-bootstrap.po | 2 +- misc/translator/po/lo-Laoo-pref.po | 30 +- misc/translator/po/lo-Laoo-staff-help.po | 2 +- misc/translator/po/lo-Laoo-staff-prog.po | 340 +++++++++--------- misc/translator/po/mi-NZ-marc-MARC21.po | 2 +- misc/translator/po/mi-NZ-marc-NORMARC.po | 2 +- misc/translator/po/mi-NZ-marc-UNIMARC.po | 2 +- misc/translator/po/mi-NZ-opac-bootstrap.po | 2 +- misc/translator/po/mi-NZ-pref.po | 26 +- misc/translator/po/mi-NZ-staff-help.po | 2 +- misc/translator/po/mi-NZ-staff-prog.po | 340 +++++++++--------- misc/translator/po/ml-marc-MARC21.po | 2 +- misc/translator/po/ml-marc-NORMARC.po | 2 +- misc/translator/po/ml-marc-UNIMARC.po | 2 +- misc/translator/po/ml-opac-bootstrap.po | 2 +- misc/translator/po/ml-pref.po | 26 +- misc/translator/po/ml-staff-help.po | 2 +- misc/translator/po/ml-staff-prog.po | 340 +++++++++--------- misc/translator/po/mon-marc-MARC21.po | 2 +- misc/translator/po/mon-marc-NORMARC.po | 2 +- misc/translator/po/mon-marc-UNIMARC.po | 2 +- misc/translator/po/mon-opac-bootstrap.po | 2 +- misc/translator/po/mon-pref.po | 30 +- misc/translator/po/mon-staff-help.po | 2 +- misc/translator/po/mon-staff-prog.po | 340 +++++++++--------- misc/translator/po/mr-marc-MARC21.po | 2 +- misc/translator/po/mr-marc-NORMARC.po | 2 +- misc/translator/po/mr-marc-UNIMARC.po | 2 +- misc/translator/po/mr-opac-bootstrap.po | 2 +- misc/translator/po/mr-pref.po | 30 +- misc/translator/po/mr-staff-help.po | 2 +- misc/translator/po/mr-staff-prog.po | 340 +++++++++--------- misc/translator/po/ms-MY-marc-MARC21.po | 2 +- misc/translator/po/ms-MY-marc-NORMARC.po | 2 +- misc/translator/po/ms-MY-marc-UNIMARC.po | 2 +- misc/translator/po/ms-MY-opac-bootstrap.po | 2 +- misc/translator/po/ms-MY-pref.po | 30 +- misc/translator/po/ms-MY-staff-help.po | 2 +- misc/translator/po/ms-MY-staff-prog.po | 340 +++++++++--------- misc/translator/po/my-marc-MARC21.po | 2 +- misc/translator/po/my-marc-NORMARC.po | 2 +- misc/translator/po/my-marc-UNIMARC.po | 2 +- misc/translator/po/my-opac-bootstrap.po | 2 +- misc/translator/po/my-pref.po | 26 +- misc/translator/po/my-staff-help.po | 2 +- misc/translator/po/my-staff-prog.po | 340 +++++++++--------- misc/translator/po/nb-NO-marc-MARC21.po | 2 +- misc/translator/po/nb-NO-marc-NORMARC.po | 2 +- misc/translator/po/nb-NO-marc-UNIMARC.po | 2 +- misc/translator/po/nb-NO-opac-bootstrap.po | 2 +- misc/translator/po/nb-NO-pref.po | 36 +- misc/translator/po/nb-NO-staff-help.po | 2 +- misc/translator/po/nb-NO-staff-prog.po | 344 +++++++++--------- misc/translator/po/ne-NE-marc-MARC21.po | 2 +- misc/translator/po/ne-NE-marc-NORMARC.po | 2 +- misc/translator/po/ne-NE-marc-UNIMARC.po | 2 +- misc/translator/po/ne-NE-opac-bootstrap.po | 2 +- misc/translator/po/ne-NE-pref.po | 26 +- misc/translator/po/ne-NE-staff-help.po | 2 +- misc/translator/po/ne-NE-staff-prog.po | 340 +++++++++--------- misc/translator/po/nl-BE-marc-MARC21.po | 2 +- misc/translator/po/nl-BE-marc-NORMARC.po | 2 +- misc/translator/po/nl-BE-marc-UNIMARC.po | 2 +- misc/translator/po/nl-BE-opac-bootstrap.po | 2 +- misc/translator/po/nl-BE-pref.po | 36 +- misc/translator/po/nl-BE-staff-help.po | 2 +- misc/translator/po/nl-BE-staff-prog.po | 340 +++++++++--------- misc/translator/po/nl-NL-marc-MARC21.po | 2 +- misc/translator/po/nl-NL-marc-NORMARC.po | 2 +- misc/translator/po/nl-NL-marc-UNIMARC.po | 2 +- misc/translator/po/nl-NL-opac-bootstrap.po | 2 +- misc/translator/po/nl-NL-pref.po | 30 +- misc/translator/po/nl-NL-staff-help.po | 2 +- misc/translator/po/nl-NL-staff-prog.po | 340 +++++++++--------- misc/translator/po/nn-NO-marc-MARC21.po | 2 +- misc/translator/po/nn-NO-marc-NORMARC.po | 2 +- misc/translator/po/nn-NO-marc-UNIMARC.po | 2 +- misc/translator/po/nn-NO-opac-bootstrap.po | 2 +- misc/translator/po/nn-NO-pref.po | 30 +- misc/translator/po/nn-NO-staff-help.po | 2 +- misc/translator/po/nn-NO-staff-prog.po | 340 +++++++++--------- misc/translator/po/oc-marc-NORMARC.po | 2 +- misc/translator/po/oc-pref.po | 36 +- misc/translator/po/pbr-marc-MARC21.po | 2 +- misc/translator/po/pbr-marc-NORMARC.po | 2 +- misc/translator/po/pbr-marc-UNIMARC.po | 2 +- misc/translator/po/pbr-opac-bootstrap.po | 2 +- misc/translator/po/pbr-pref.po | 30 +- misc/translator/po/pbr-staff-help.po | 2 +- misc/translator/po/pbr-staff-prog.po | 340 +++++++++--------- misc/translator/po/pl-PL-marc-MARC21.po | 10 +- misc/translator/po/pl-PL-marc-NORMARC.po | 2 +- misc/translator/po/pl-PL-marc-UNIMARC.po | 2 +- misc/translator/po/pl-PL-opac-bootstrap.po | 2 +- misc/translator/po/pl-PL-pref.po | 36 +- misc/translator/po/pl-PL-staff-help.po | 2 +- misc/translator/po/pl-PL-staff-prog.po | 363 +++++++++---------- misc/translator/po/prs-marc-MARC21.po | 2 +- misc/translator/po/prs-marc-NORMARC.po | 2 +- misc/translator/po/prs-marc-UNIMARC.po | 2 +- misc/translator/po/prs-opac-bootstrap.po | 2 +- misc/translator/po/prs-pref.po | 36 +- misc/translator/po/prs-staff-help.po | 2 +- misc/translator/po/prs-staff-prog.po | 340 +++++++++--------- misc/translator/po/pt-BR-marc-MARC21.po | 2 +- misc/translator/po/pt-BR-marc-NORMARC.po | 2 +- misc/translator/po/pt-BR-marc-UNIMARC.po | 2 +- misc/translator/po/pt-BR-opac-bootstrap.po | 2 +- misc/translator/po/pt-BR-pref.po | 36 +- misc/translator/po/pt-BR-staff-help.po | 2 +- misc/translator/po/pt-BR-staff-prog.po | 344 +++++++++--------- misc/translator/po/pt-PT-marc-MARC21.po | 2 +- misc/translator/po/pt-PT-marc-NORMARC.po | 2 +- misc/translator/po/pt-PT-marc-UNIMARC.po | 2 +- misc/translator/po/pt-PT-opac-bootstrap.po | 2 +- misc/translator/po/pt-PT-pref.po | 36 +- misc/translator/po/pt-PT-staff-help.po | 2 +- misc/translator/po/pt-PT-staff-prog.po | 344 +++++++++--------- misc/translator/po/ro-RO-marc-MARC21.po | 2 +- misc/translator/po/ro-RO-marc-NORMARC.po | 2 +- misc/translator/po/ro-RO-marc-UNIMARC.po | 2 +- misc/translator/po/ro-RO-opac-bootstrap.po | 2 +- misc/translator/po/ro-RO-pref.po | 30 +- misc/translator/po/ro-RO-staff-help.po | 2 +- misc/translator/po/ro-RO-staff-prog.po | 340 +++++++++--------- misc/translator/po/ru-RU-marc-MARC21.po | 2 +- misc/translator/po/ru-RU-marc-NORMARC.po | 2 +- misc/translator/po/ru-RU-marc-UNIMARC.po | 2 +- misc/translator/po/ru-RU-opac-bootstrap.po | 2 +- misc/translator/po/ru-RU-pref.po | 32 +- misc/translator/po/ru-RU-staff-help.po | 2 +- misc/translator/po/ru-RU-staff-prog.po | 340 +++++++++--------- misc/translator/po/rw-RW-marc-MARC21.po | 2 +- misc/translator/po/rw-RW-marc-NORMARC.po | 2 +- misc/translator/po/rw-RW-marc-UNIMARC.po | 2 +- misc/translator/po/rw-RW-opac-bootstrap.po | 2 +- misc/translator/po/rw-RW-pref.po | 26 +- misc/translator/po/rw-RW-staff-help.po | 2 +- misc/translator/po/rw-RW-staff-prog.po | 340 +++++++++--------- misc/translator/po/sd-PK-marc-MARC21.po | 2 +- misc/translator/po/sd-PK-marc-NORMARC.po | 2 +- misc/translator/po/sd-PK-marc-UNIMARC.po | 2 +- misc/translator/po/sd-PK-opac-bootstrap.po | 2 +- misc/translator/po/sd-PK-pref.po | 30 +- misc/translator/po/sd-PK-staff-help.po | 2 +- misc/translator/po/sd-PK-staff-prog.po | 340 +++++++++--------- misc/translator/po/sk-SK-marc-MARC21.po | 2 +- misc/translator/po/sk-SK-marc-NORMARC.po | 2 +- misc/translator/po/sk-SK-marc-UNIMARC.po | 2 +- misc/translator/po/sk-SK-opac-bootstrap.po | 2 +- misc/translator/po/sk-SK-pref.po | 36 +- misc/translator/po/sk-SK-staff-help.po | 2 +- misc/translator/po/sk-SK-staff-prog.po | 344 +++++++++--------- misc/translator/po/sl-SI-marc-MARC21.po | 2 +- misc/translator/po/sl-SI-marc-NORMARC.po | 2 +- misc/translator/po/sl-SI-marc-UNIMARC.po | 2 +- misc/translator/po/sl-SI-opac-bootstrap.po | 2 +- misc/translator/po/sl-SI-pref.po | 34 +- misc/translator/po/sl-SI-staff-help.po | 2 +- misc/translator/po/sl-SI-staff-prog.po | 340 +++++++++--------- misc/translator/po/sq-AL-marc-MARC21.po | 2 +- misc/translator/po/sq-AL-marc-NORMARC.po | 2 +- misc/translator/po/sq-AL-marc-UNIMARC.po | 2 +- misc/translator/po/sq-AL-opac-bootstrap.po | 2 +- misc/translator/po/sq-AL-pref.po | 30 +- misc/translator/po/sq-AL-staff-help.po | 2 +- misc/translator/po/sq-AL-staff-prog.po | 340 +++++++++--------- misc/translator/po/sr-Cyrl-marc-MARC21.po | 2 +- misc/translator/po/sr-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/sr-Cyrl-marc-UNIMARC.po | 2 +- misc/translator/po/sr-Cyrl-opac-bootstrap.po | 2 +- misc/translator/po/sr-Cyrl-pref.po | 30 +- misc/translator/po/sr-Cyrl-staff-help.po | 2 +- misc/translator/po/sr-Cyrl-staff-prog.po | 340 +++++++++--------- misc/translator/po/sv-SE-marc-MARC21.po | 2 +- misc/translator/po/sv-SE-marc-NORMARC.po | 2 +- misc/translator/po/sv-SE-marc-UNIMARC.po | 2 +- misc/translator/po/sv-SE-opac-bootstrap.po | 2 +- misc/translator/po/sv-SE-pref.po | 36 +- misc/translator/po/sv-SE-staff-help.po | 2 +- misc/translator/po/sv-SE-staff-prog.po | 344 +++++++++--------- misc/translator/po/sw-KE-marc-MARC21.po | 2 +- misc/translator/po/sw-KE-marc-NORMARC.po | 2 +- misc/translator/po/sw-KE-marc-UNIMARC.po | 2 +- misc/translator/po/sw-KE-opac-bootstrap.po | 2 +- misc/translator/po/sw-KE-pref.po | 26 +- misc/translator/po/sw-KE-staff-help.po | 2 +- misc/translator/po/sw-KE-staff-prog.po | 340 +++++++++--------- misc/translator/po/ta-LK-marc-MARC21.po | 2 +- misc/translator/po/ta-LK-marc-NORMARC.po | 2 +- misc/translator/po/ta-LK-marc-UNIMARC.po | 2 +- misc/translator/po/ta-LK-opac-bootstrap.po | 2 +- misc/translator/po/ta-LK-pref.po | 30 +- misc/translator/po/ta-LK-staff-help.po | 2 +- misc/translator/po/ta-LK-staff-prog.po | 340 +++++++++--------- misc/translator/po/ta-marc-MARC21.po | 2 +- misc/translator/po/ta-marc-NORMARC.po | 2 +- misc/translator/po/ta-marc-UNIMARC.po | 2 +- misc/translator/po/ta-opac-bootstrap.po | 2 +- misc/translator/po/ta-pref.po | 26 +- misc/translator/po/ta-staff-help.po | 2 +- misc/translator/po/ta-staff-prog.po | 340 +++++++++--------- misc/translator/po/tet-marc-MARC21.po | 2 +- misc/translator/po/tet-marc-NORMARC.po | 2 +- misc/translator/po/tet-marc-UNIMARC.po | 2 +- misc/translator/po/tet-opac-bootstrap.po | 2 +- misc/translator/po/tet-pref.po | 30 +- misc/translator/po/tet-staff-help.po | 2 +- misc/translator/po/tet-staff-prog.po | 344 +++++++++--------- misc/translator/po/th-TH-marc-MARC21.po | 2 +- misc/translator/po/th-TH-marc-NORMARC.po | 2 +- misc/translator/po/th-TH-marc-UNIMARC.po | 2 +- misc/translator/po/th-TH-opac-bootstrap.po | 2 +- misc/translator/po/th-TH-pref.po | 30 +- misc/translator/po/th-TH-staff-help.po | 2 +- misc/translator/po/th-TH-staff-prog.po | 340 +++++++++--------- misc/translator/po/tl-PH-marc-MARC21.po | 2 +- misc/translator/po/tl-PH-marc-NORMARC.po | 2 +- misc/translator/po/tl-PH-marc-UNIMARC.po | 2 +- misc/translator/po/tl-PH-opac-bootstrap.po | 2 +- misc/translator/po/tl-PH-pref.po | 36 +- misc/translator/po/tl-PH-staff-help.po | 2 +- misc/translator/po/tl-PH-staff-prog.po | 340 +++++++++--------- misc/translator/po/tr-TR-marc-MARC21.po | 2 +- misc/translator/po/tr-TR-marc-NORMARC.po | 2 +- misc/translator/po/tr-TR-marc-UNIMARC.po | 2 +- misc/translator/po/tr-TR-opac-bootstrap.po | 2 +- misc/translator/po/tr-TR-pref.po | 36 +- misc/translator/po/tr-TR-staff-help.po | 2 +- misc/translator/po/tr-TR-staff-prog.po | 344 +++++++++--------- misc/translator/po/uk-UA-marc-MARC21.po | 2 +- misc/translator/po/uk-UA-marc-NORMARC.po | 2 +- misc/translator/po/uk-UA-marc-UNIMARC.po | 2 +- misc/translator/po/uk-UA-opac-bootstrap.po | 2 +- misc/translator/po/uk-UA-pref.po | 28 +- misc/translator/po/uk-UA-staff-help.po | 2 +- misc/translator/po/uk-UA-staff-prog.po | 340 +++++++++--------- misc/translator/po/ur-Arab-marc-MARC21.po | 2 +- misc/translator/po/ur-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ur-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ur-Arab-opac-bootstrap.po | 2 +- misc/translator/po/ur-Arab-pref.po | 30 +- misc/translator/po/ur-Arab-staff-help.po | 2 +- misc/translator/po/ur-Arab-staff-prog.po | 340 +++++++++--------- misc/translator/po/vi-VN-marc-MARC21.po | 2 +- misc/translator/po/vi-VN-marc-NORMARC.po | 2 +- misc/translator/po/vi-VN-marc-UNIMARC.po | 2 +- misc/translator/po/vi-VN-opac-bootstrap.po | 2 +- misc/translator/po/vi-VN-pref.po | 36 +- misc/translator/po/vi-VN-staff-help.po | 2 +- misc/translator/po/vi-VN-staff-prog.po | 340 +++++++++--------- misc/translator/po/zh-Hans-CN-marc-MARC21.po | 2 +- misc/translator/po/zh-Hans-CN-marc-NORMARC.po | 2 +- misc/translator/po/zh-Hans-CN-marc-UNIMARC.po | 2 +- misc/translator/po/zh-Hans-CN-opac-bootstrap.po | 2 +- misc/translator/po/zh-Hans-CN-pref.po | 36 +- misc/translator/po/zh-Hans-CN-staff-help.po | 2 +- misc/translator/po/zh-Hans-CN-staff-prog.po | 344 +++++++++--------- misc/translator/po/zh-Hans-TW-marc-MARC21.po | 2 +- misc/translator/po/zh-Hans-TW-marc-NORMARC.po | 2 +- misc/translator/po/zh-Hans-TW-marc-UNIMARC.po | 2 +- misc/translator/po/zh-Hans-TW-opac-bootstrap.po | 2 +- misc/translator/po/zh-Hans-TW-pref.po | 36 +- misc/translator/po/zh-Hans-TW-staff-help.po | 2 +- misc/translator/po/zh-Hans-TW-staff-prog.po | 344 +++++++++--------- t/db_dependent/Auth.t | 29 +- 560 files changed, 16143 insertions(+), 14476 deletions(-) copy misc/release_notes/{release_notes_3_22_16.md => release_notes_3_22_18.md} (69%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 20 14:08:13 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 20 Mar 2017 13:08:13 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-563-g2470e22 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2470e225d8791d1b87daaebde2591caab6427d49 (commit) via 3844d6f36bcee2b0e2102c2df1323cdd86940303 (commit) from 13de29ad4465b964e37d4f460f5c9145e23939a1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2470e225d8791d1b87daaebde2591caab6427d49 Author: Jonathan Druart Date: Wed Mar 15 14:52:49 2017 -0300 Bug 18275: Do not rely on CGI param userid to log a user in if auth is not required From opac/opac-memberentry.pl, authnotrequired is set. That means a patron can access the page without being logged in. It is used on this page for the self registration feature. From C4::Auth::get_template_and_user, we have $userid = $q_userid; $q_userid is previously set to the 'userid' CGI param. We end up here if authonotrequired is set AND CGISESSID does not exist. Test plan: - Run: $ prove t/db_dependent/Auth.t => FAIL: Regression test for checkauth fails - Apply this patch - Run: $ prove t/db_dependent/Auth.t => SUCCESS: Tests pass. - Sign off :-D Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall commit 3844d6f36bcee2b0e2102c2df1323cdd86940303 Author: Tomas Cohen Arazi Date: Thu Mar 16 09:23:24 2017 -0300 Bug 18275: Regression test Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 9 ++++----- t/db_dependent/Auth.t | 27 ++++++++++++++++++++++++--- 2 files changed, 28 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 20 16:36:44 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 20 Mar 2017 15:36:44 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-565-ge6c2858 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e6c2858c4faf71920912c3e2df92225b45548c9d (commit) via 69f68da800794d964836daa472e3c0ce2b154f95 (commit) from 2470e225d8791d1b87daaebde2591caab6427d49 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e6c2858c4faf71920912c3e2df92225b45548c9d Author: Srdjan Date: Tue Mar 14 12:24:42 2017 +1300 Bug 18243: 16034 follow-up: Conditionally test Koha::ExternalContent::* modules loading To test: 1 - Make sure you don't have WebService::ILS installed 2 - prove t/00-load.t 3 - You should get a failure to load module and tests are skipped 4 - Apply patch 5 - prove t/00-load.t 6 - Module is not loaded, test are skipped Optional: 7 - Install WebService::ILS 5 - prove t/00-load.t 6 - Module is loaded, test passes Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 69f68da800794d964836daa472e3c0ce2b154f95 Author: Srdjan Date: Thu Mar 2 13:31:14 2017 +1300 Bug 18243: 16034 follow-up: better handling of absence of WebService::ILS::OverDrive::Patron at testing To test: 1 - Make sure you don't have WebService::ILS::OverDrive::Patron installed 2 - prove t/Koha_ExternalContent_OverDrive.t 3 - You should get a failure to load module and tests are skipped 4 - Apply patch 5 - prove t/Koha_ExternalContent_OverDrive.t 6 - Module is not loaded, test are skipped Fixed small typo 'cannot filnd' -> 'cannot find' Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: t/00-load.t | 3 +++ t/Koha_ExternalContent_OverDrive.t | 8 ++++---- 2 files changed, 7 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 20 16:41:54 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 20 Mar 2017 15:41:54 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-566-g9d8e835 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 9d8e83528f39a2d8401f7ed50888c595f48205f5 (commit) from e6c2858c4faf71920912c3e2df92225b45548c9d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9d8e83528f39a2d8401f7ed50888c595f48205f5 Author: Olli-Antti Kivilahti Date: Tue Mar 7 13:26:51 2017 +0200 Bug 18222 - Fix tests broken by Buug 18026 root at koha_ci_1:/home/koha/Koha# KOHA_CONF=$KOHA_CONF perl t/Koha_Template_Plugin_Koha.t 1..3 ok 1 - use Koha::Template::Plugin::Koha; ok 2 1..2 ok 1 - Correct development version ok 2 - Correct maintenance version ok 3 - Koha::Template::Plugin::Koha::Version tests Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: t/Koha_Template_Plugin_Koha.t | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 20 20:54:12 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 20 Mar 2017 19:54:12 +0000 Subject: [koha-commits] main Koha release repository annotated tag v16.11.05 created. v16.11.05 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The annotated tag, v16.11.05 has been created at 3d98f71e91ffe1ee559f84096ee515205dbb613e (tag) tagging d3ef053c415fdab3ab59310cb4d058f6a0c50e77 (commit) replaces v16.11.04 tagged by Katrin Fischer on Fri Mar 17 00:27:54 2017 +0100 - Log ----------------------------------------------------------------- Koha release 16.11.05 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAABAgAGBQJYyx96AAoJEB+uyDM6ADoAbAEQAMz64DEcKRNhLapvkR0dR4wr vE16vx927sKgiyO5LhkqbNWOsyq2RP8uhvwR7eB1L+3bKuOsTXQ0binbET7VUGnx AMs2xKh1Iv4drfkncaZUe5TLyd9srZRfxScyb7rbtRLT5X8XS/Y7HfpX89ztYvwI dE8Ie3mzR7xYoBLhDlVYE5N5lgLKNN/POZkGFzHEgvGd3roeVsyun0vZw0A9o3aO VPMV/h8Yn1EwFxUyM2nmOeqwyyB1RG0Np0bu3mN9O45O5XxspElWc4YomqRqUYr1 6YErWTRt9NmdEK0KY2VrRakwT22e+kcbdmptqBwGfZj29EAk7MGouvRPdM0GsgFS XHXvYUjIHj6mDPC65vxH1dSvEULFt7knH5tkJnaASfDaCLksvmFWrrXORsXCTqzZ 0X5WoVf8Nv1LUfjbAgMzAQts7/RfhM4O4Q1ukYUdrz2YVDwc+V7gQc9HGN/ju8DL 5A3yZh6ZeOOLXpobAj+dPL+TmSNC7X/AFfuUM/bj5emeHvfgO3N348bbjUZVBUKr MZ7DRoGE6ueCrANAmZWCgyjWgGgU4UkX8DVpWA8AKImvcQvkxbsf97ydq+8XTmCz mGj6j7gAuAT5lEBFcRMfffV/0Iw6OJomYqR5V49vxIZBg5IgNniuXoyC27mcinyr aFbtEiEBbHCPM0P0XvWL =5yZR -----END PGP SIGNATURE----- Aleisha Amohia (3): Bug 17895: 'Re-set' typo fix Bug 17947: Searching my library first shows the branchcode by the search bar rather than branchname Bug 18135: Show alert if no authorities selected in batch record deletion Blou (1): Bug 17260: updatedatabase.pl fails on invalid entries in ENUM and BOOLEAN columns Colin Campbell (1): Bug 16202: GetIssuingCharges should return a collectable amount Emma Smith (1): Bug 17840: adding classes to notes in checkouts Jonathan Druart (3): Bug 18248: Fix SQL statement to setting marc_subfield_structure.authorised_value to NULL Bug 18087: Handle invalid filetypes Bug 18275: Do not rely on CGI param userid to log a user in if auth is not required Joy Nelson (1): Bug 18087 - Clarification on File type when using file of biblionumbers to export data Katrin Fischer (3): Bug 17260: DBRev 16.11.04.001 Increment version for 16.11.05 release Merge remote-tracking branch 'transl/16.11.05-translate-20170316' into 16.11.x Koha instance kohadev-koha (1): Add release notes to 16.11.04 security release Marc V?ron (2): Bug 13968 - Branch email hints are misleading Bug 18122 - Audio alerts: Add hint on where to enable sounds Marcel de Rooy (1): Bug 7143: Replace Santallan by Santellan Mark Tompsett (1): Bug 13968: Follow up - Clean HTML tags for hints Tomas Cohen Arazi (1): Bug 18275: Regression test root (1): Translation updates for Koha 16.11.05 ----------------------------------------------------------------------- hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 20 20:53:50 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 20 Mar 2017 19:53:50 +0000 Subject: [koha-commits] main Koha release repository branch 16.11.x updated. v16.11.05 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 16.11.x has been updated via d3ef053c415fdab3ab59310cb4d058f6a0c50e77 (commit) via afabf5b5a42c53c4290a6e2f95131dcd6127f691 (commit) via c0e748aaec84e5161a8c235e11d72d04f6105931 (commit) via 243b80075dc2c96e94a849335c1d1724bcc65753 (commit) via cf837a537682c769908043ff6a93613967dd6334 (commit) via 1a703faf6376a216a8ded37a50bd8c08613a8e9d (commit) from 661e6389c990c603cbc6a0a9444c27ec9d01afe2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d3ef053c415fdab3ab59310cb4d058f6a0c50e77 Author: Koha instance kohadev-koha Date: Thu Mar 16 23:24:44 2017 +0000 Add release notes to 16.11.04 security release commit afabf5b5a42c53c4290a6e2f95131dcd6127f691 Merge: 243b800 c0e748a Author: Katrin Fischer Date: Fri Mar 17 00:09:17 2017 +0100 Merge remote-tracking branch 'transl/16.11.05-translate-20170316' into 16.11.x commit c0e748aaec84e5161a8c235e11d72d04f6105931 Author: root Date: Thu Mar 16 19:55:44 2017 -0300 Translation updates for Koha 16.11.05 commit 243b80075dc2c96e94a849335c1d1724bcc65753 Author: Katrin Fischer Date: Thu Mar 16 23:50:07 2017 +0100 Increment version for 16.11.05 release commit cf837a537682c769908043ff6a93613967dd6334 Author: Jonathan Druart Date: Wed Mar 15 14:52:49 2017 -0300 Bug 18275: Do not rely on CGI param userid to log a user in if auth is not required From opac/opac-memberentry.pl, authnotrequired is set. That means a patron can access the page without being logged in. It is used on this page for the self registration feature. From C4::Auth::get_template_and_user, we have $userid = $q_userid; $q_userid is previously set to the 'userid' CGI param. We end up here if authonotrequired is set AND CGISESSID does not exist. Test plan: - Run: $ prove t/db_dependent/Auth.t => FAIL: Regression test for checkauth fails - Apply this patch - Run: $ prove t/db_dependent/Auth.t => SUCCESS: Tests pass. - Sign off :-D Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi commit 1a703faf6376a216a8ded37a50bd8c08613a8e9d Author: Tomas Cohen Arazi Date: Thu Mar 16 09:23:24 2017 -0300 Bug 18275: Regression test Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 9 +- Koha.pm | 2 +- installer/data/mysql/updatedatabase.pl | 6 + ...s_16_11_03.html => release_notes_16_11_05.html} | 154 +- ...notes_16_11_03.md => release_notes_16_11_05.md} | 140 +- misc/translator/po/am-Ethi-marc-MARC21.po | 2 +- misc/translator/po/am-Ethi-marc-NORMARC.po | 2 +- misc/translator/po/am-Ethi-marc-UNIMARC.po | 2 +- misc/translator/po/am-Ethi-opac-bootstrap.po | 8 +- misc/translator/po/am-Ethi-staff-help.po | 35 +- misc/translator/po/am-Ethi-staff-prog.po | 346 ++- misc/translator/po/ar-Arab-marc-MARC21.po | 2 +- misc/translator/po/ar-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ar-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ar-Arab-opac-bootstrap.po | 10 +- misc/translator/po/ar-Arab-pref.po | 43 +- misc/translator/po/ar-Arab-staff-help.po | 35 +- misc/translator/po/ar-Arab-staff-prog.po | 393 +-- misc/translator/po/as-IN-marc-MARC21.po | 2 +- misc/translator/po/as-IN-marc-NORMARC.po | 2 +- misc/translator/po/as-IN-marc-UNIMARC.po | 2 +- misc/translator/po/as-IN-opac-bootstrap.po | 8 +- misc/translator/po/as-IN-staff-help.po | 35 +- misc/translator/po/as-IN-staff-prog.po | 345 ++- misc/translator/po/az-AZ-marc-MARC21.po | 2 +- misc/translator/po/az-AZ-marc-NORMARC.po | 2 +- misc/translator/po/az-AZ-marc-UNIMARC.po | 2 +- misc/translator/po/az-AZ-opac-bootstrap.po | 8 +- misc/translator/po/az-AZ-staff-help.po | 35 +- misc/translator/po/az-AZ-staff-prog.po | 350 ++- misc/translator/po/be-BY-marc-MARC21.po | 2 +- misc/translator/po/be-BY-marc-NORMARC.po | 2 +- misc/translator/po/be-BY-marc-UNIMARC.po | 2 +- misc/translator/po/be-BY-opac-bootstrap.po | 8 +- misc/translator/po/be-BY-staff-help.po | 35 +- misc/translator/po/be-BY-staff-prog.po | 350 ++- misc/translator/po/bg-Cyrl-marc-MARC21.po | 2 +- misc/translator/po/bg-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/bg-Cyrl-marc-UNIMARC.po | 2 +- misc/translator/po/bg-Cyrl-opac-bootstrap.po | 8 +- misc/translator/po/bg-Cyrl-staff-help.po | 35 +- misc/translator/po/bg-Cyrl-staff-prog.po | 345 ++- misc/translator/po/bn-IN-marc-MARC21.po | 2 +- misc/translator/po/bn-IN-marc-NORMARC.po | 2 +- misc/translator/po/bn-IN-marc-UNIMARC.po | 2 +- misc/translator/po/bn-IN-opac-bootstrap.po | 8 +- misc/translator/po/bn-IN-staff-help.po | 35 +- misc/translator/po/bn-IN-staff-prog.po | 345 ++- misc/translator/po/ca-ES-marc-MARC21.po | 2 +- misc/translator/po/ca-ES-marc-NORMARC.po | 2 +- misc/translator/po/ca-ES-marc-UNIMARC.po | 2 +- misc/translator/po/ca-ES-opac-bootstrap.po | 18 +- misc/translator/po/ca-ES-staff-help.po | 35 +- misc/translator/po/ca-ES-staff-prog.po | 358 ++- misc/translator/po/cs-CZ-marc-MARC21.po | 2 +- misc/translator/po/cs-CZ-marc-NORMARC.po | 2 +- misc/translator/po/cs-CZ-marc-UNIMARC.po | 2 +- misc/translator/po/cs-CZ-opac-bootstrap.po | 10 +- misc/translator/po/cs-CZ-staff-help.po | 35 +- misc/translator/po/cs-CZ-staff-prog.po | 376 +-- misc/translator/po/cy-GB-marc-MARC21.po | 2 +- misc/translator/po/cy-GB-marc-NORMARC.po | 2 +- misc/translator/po/cy-GB-marc-UNIMARC.po | 2 +- misc/translator/po/cy-GB-opac-bootstrap.po | 8 +- misc/translator/po/cy-GB-staff-help.po | 35 +- misc/translator/po/cy-GB-staff-prog.po | 345 ++- misc/translator/po/da-DK-marc-MARC21.po | 2 +- misc/translator/po/da-DK-marc-NORMARC.po | 2 +- misc/translator/po/da-DK-marc-UNIMARC.po | 2 +- misc/translator/po/da-DK-opac-bootstrap.po | 10 +- misc/translator/po/da-DK-staff-help.po | 35 +- misc/translator/po/da-DK-staff-prog.po | 354 ++- misc/translator/po/de-CH-marc-MARC21.po | 2 +- misc/translator/po/de-CH-marc-NORMARC.po | 2 +- misc/translator/po/de-CH-marc-UNIMARC.po | 2 +- misc/translator/po/de-CH-opac-bootstrap.po | 12 +- misc/translator/po/de-CH-pref.po | 42 +- misc/translator/po/de-CH-staff-help.po | 41 +- misc/translator/po/de-CH-staff-prog.po | 376 ++- misc/translator/po/de-DE-marc-MARC21.po | 2 +- misc/translator/po/de-DE-marc-NORMARC.po | 2 +- misc/translator/po/de-DE-marc-UNIMARC.po | 2 +- misc/translator/po/de-DE-opac-bootstrap.po | 14 +- misc/translator/po/de-DE-pref.po | 42 +- misc/translator/po/de-DE-staff-help.po | 43 +- misc/translator/po/de-DE-staff-prog.po | 372 ++- misc/translator/po/el-GR-marc-MARC21.po | 2 +- misc/translator/po/el-GR-marc-NORMARC.po | 2 +- misc/translator/po/el-GR-marc-UNIMARC.po | 2 +- misc/translator/po/el-GR-opac-bootstrap.po | 28 +- misc/translator/po/el-GR-pref.po | 8 +- misc/translator/po/el-GR-staff-help.po | 41 +- misc/translator/po/el-GR-staff-prog.po | 397 +-- misc/translator/po/en-GB-marc-MARC21.po | 2 +- misc/translator/po/en-GB-marc-NORMARC.po | 2 +- misc/translator/po/en-GB-marc-UNIMARC.po | 2 +- misc/translator/po/en-GB-opac-bootstrap.po | 8 +- misc/translator/po/en-GB-staff-help.po | 35 +- misc/translator/po/en-GB-staff-prog.po | 350 ++- misc/translator/po/en-NZ-marc-MARC21.po | 2 +- misc/translator/po/en-NZ-marc-NORMARC.po | 2 +- misc/translator/po/en-NZ-marc-UNIMARC.po | 2 +- misc/translator/po/en-NZ-opac-bootstrap.po | 10 +- misc/translator/po/en-NZ-staff-help.po | 35 +- misc/translator/po/en-NZ-staff-prog.po | 372 ++- misc/translator/po/eo-marc-MARC21.po | 2 +- misc/translator/po/eo-marc-NORMARC.po | 2 +- misc/translator/po/eo-marc-UNIMARC.po | 2 +- misc/translator/po/eo-opac-bootstrap.po | 102 +- misc/translator/po/eo-staff-help.po | 35 +- misc/translator/po/eo-staff-prog.po | 345 ++- misc/translator/po/es-ES-marc-MARC21.po | 6 +- misc/translator/po/es-ES-marc-NORMARC.po | 2 +- misc/translator/po/es-ES-marc-UNIMARC.po | 2 +- misc/translator/po/es-ES-opac-bootstrap.po | 22 +- misc/translator/po/es-ES-pref.po | 62 +- misc/translator/po/es-ES-staff-help.po | 64 +- misc/translator/po/es-ES-staff-prog.po | 398 +-- misc/translator/po/eu-marc-MARC21.po | 2 +- misc/translator/po/eu-marc-NORMARC.po | 2 +- misc/translator/po/eu-marc-UNIMARC.po | 2 +- misc/translator/po/eu-opac-bootstrap.po | 8 +- misc/translator/po/eu-staff-help.po | 35 +- misc/translator/po/eu-staff-prog.po | 346 ++- misc/translator/po/fa-Arab-marc-MARC21.po | 2 +- misc/translator/po/fa-Arab-marc-NORMARC.po | 2 +- misc/translator/po/fa-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/fa-Arab-opac-bootstrap.po | 8 +- misc/translator/po/fa-Arab-staff-help.po | 35 +- misc/translator/po/fa-Arab-staff-prog.po | 350 ++- misc/translator/po/fi-FI-marc-MARC21.po | 2 +- misc/translator/po/fi-FI-marc-NORMARC.po | 2 +- misc/translator/po/fi-FI-marc-UNIMARC.po | 2 +- misc/translator/po/fi-FI-opac-bootstrap.po | 10 +- misc/translator/po/fi-FI-pref.po | 40 +- misc/translator/po/fi-FI-staff-help.po | 35 +- misc/translator/po/fi-FI-staff-prog.po | 364 ++- misc/translator/po/fo-FO-marc-MARC21.po | 2 +- misc/translator/po/fo-FO-marc-NORMARC.po | 2 +- misc/translator/po/fo-FO-marc-UNIMARC.po | 2 +- misc/translator/po/fo-FO-opac-bootstrap.po | 8 +- misc/translator/po/fo-FO-staff-help.po | 35 +- misc/translator/po/fo-FO-staff-prog.po | 345 ++- misc/translator/po/fr-CA-marc-MARC21.po | 2 +- misc/translator/po/fr-CA-marc-NORMARC.po | 2 +- misc/translator/po/fr-CA-marc-UNIMARC.po | 2 +- misc/translator/po/fr-CA-opac-bootstrap.po | 16 +- misc/translator/po/fr-CA-staff-help.po | 35 +- misc/translator/po/fr-CA-staff-prog.po | 356 ++- misc/translator/po/fr-FR-marc-MARC21.po | 2 +- misc/translator/po/fr-FR-marc-NORMARC.po | 2 +- misc/translator/po/fr-FR-marc-UNIMARC.po | 2 +- misc/translator/po/fr-FR-opac-bootstrap.po | 10 +- misc/translator/po/fr-FR-staff-help.po | 35 +- misc/translator/po/fr-FR-staff-prog.po | 356 ++- misc/translator/po/gl-marc-MARC21.po | 2 +- misc/translator/po/gl-marc-NORMARC.po | 2 +- misc/translator/po/gl-marc-UNIMARC.po | 2 +- misc/translator/po/gl-opac-bootstrap.po | 8 +- misc/translator/po/gl-staff-help.po | 35 +- misc/translator/po/gl-staff-prog.po | 350 ++- misc/translator/po/he-Hebr-marc-MARC21.po | 2 +- misc/translator/po/he-Hebr-marc-NORMARC.po | 2 +- misc/translator/po/he-Hebr-marc-UNIMARC.po | 2 +- misc/translator/po/he-Hebr-opac-bootstrap.po | 8 +- misc/translator/po/he-Hebr-staff-help.po | 35 +- misc/translator/po/he-Hebr-staff-prog.po | 350 ++- misc/translator/po/hi-marc-MARC21.po | 2 +- misc/translator/po/hi-marc-NORMARC.po | 2 +- misc/translator/po/hi-marc-UNIMARC.po | 2 +- misc/translator/po/hi-opac-bootstrap.po | 10 +- misc/translator/po/hi-pref.po | 40 +- misc/translator/po/hi-staff-help.po | 35 +- misc/translator/po/hi-staff-prog.po | 391 +-- misc/translator/po/hr-HR-marc-MARC21.po | 2 +- misc/translator/po/hr-HR-marc-NORMARC.po | 2 +- misc/translator/po/hr-HR-marc-UNIMARC.po | 2 +- misc/translator/po/hr-HR-opac-bootstrap.po | 10 +- misc/translator/po/hr-HR-staff-help.po | 35 +- misc/translator/po/hr-HR-staff-prog.po | 350 ++- misc/translator/po/hu-HU-marc-MARC21.po | 60 +- misc/translator/po/hu-HU-marc-NORMARC.po | 2 +- misc/translator/po/hu-HU-marc-UNIMARC.po | 2 +- misc/translator/po/hu-HU-opac-bootstrap.po | 12 +- misc/translator/po/hu-HU-staff-help.po | 35 +- misc/translator/po/hu-HU-staff-prog.po | 350 ++- misc/translator/po/hy-Armn-marc-MARC21.po | 2 +- misc/translator/po/hy-Armn-marc-NORMARC.po | 2 +- misc/translator/po/hy-Armn-marc-UNIMARC.po | 2 +- misc/translator/po/hy-Armn-opac-bootstrap.po | 10 +- misc/translator/po/hy-Armn-pref.po | 387 ++- misc/translator/po/hy-Armn-staff-help.po | 184 +- misc/translator/po/hy-Armn-staff-prog.po | 1591 +++++----- misc/translator/po/ia-marc-MARC21.po | 2 +- misc/translator/po/ia-marc-NORMARC.po | 2 +- misc/translator/po/ia-marc-UNIMARC.po | 2 +- misc/translator/po/ia-opac-bootstrap.po | 8 +- misc/translator/po/ia-staff-help.po | 35 +- misc/translator/po/ia-staff-prog.po | 345 ++- misc/translator/po/id-ID-marc-MARC21.po | 2 +- misc/translator/po/id-ID-marc-NORMARC.po | 2 +- misc/translator/po/id-ID-marc-UNIMARC.po | 2 +- misc/translator/po/id-ID-opac-bootstrap.po | 8 +- misc/translator/po/id-ID-staff-help.po | 35 +- misc/translator/po/id-ID-staff-prog.po | 346 ++- misc/translator/po/iq-CA-marc-MARC21.po | 2 +- misc/translator/po/iq-CA-marc-NORMARC.po | 2 +- misc/translator/po/iq-CA-marc-UNIMARC.po | 2 +- misc/translator/po/iq-CA-opac-bootstrap.po | 8 +- misc/translator/po/iq-CA-staff-help.po | 35 +- misc/translator/po/iq-CA-staff-prog.po | 345 ++- misc/translator/po/is-IS-marc-MARC21.po | 2 +- misc/translator/po/is-IS-marc-NORMARC.po | 2 +- misc/translator/po/is-IS-marc-UNIMARC.po | 2 +- misc/translator/po/is-IS-opac-bootstrap.po | 8 +- misc/translator/po/is-IS-staff-help.po | 35 +- misc/translator/po/is-IS-staff-prog.po | 350 ++- misc/translator/po/it-IT-marc-MARC21.po | 2 +- misc/translator/po/it-IT-marc-NORMARC.po | 2 +- misc/translator/po/it-IT-marc-UNIMARC.po | 2 +- misc/translator/po/it-IT-opac-bootstrap.po | 20 +- misc/translator/po/it-IT-pref.po | 36 +- misc/translator/po/it-IT-staff-help.po | 35 +- misc/translator/po/it-IT-staff-prog.po | 378 +-- misc/translator/po/iu-CA-marc-MARC21.po | 2 +- misc/translator/po/iu-CA-marc-NORMARC.po | 2 +- misc/translator/po/iu-CA-marc-UNIMARC.po | 2 +- misc/translator/po/iu-CA-opac-bootstrap.po | 8 +- misc/translator/po/iu-CA-staff-help.po | 35 +- misc/translator/po/iu-CA-staff-prog.po | 345 ++- misc/translator/po/ja-Jpan-JP-marc-MARC21.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-NORMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-UNIMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-opac-bootstrap.po | 8 +- misc/translator/po/ja-Jpan-JP-staff-help.po | 35 +- misc/translator/po/ja-Jpan-JP-staff-prog.po | 350 ++- misc/translator/po/ka-marc-MARC21.po | 2 +- misc/translator/po/ka-marc-NORMARC.po | 2 +- misc/translator/po/ka-marc-UNIMARC.po | 2 +- misc/translator/po/ka-opac-bootstrap.po | 8 +- misc/translator/po/ka-staff-help.po | 35 +- misc/translator/po/ka-staff-prog.po | 345 ++- misc/translator/po/km-KH-marc-MARC21.po | 2 +- misc/translator/po/km-KH-marc-NORMARC.po | 2 +- misc/translator/po/km-KH-marc-UNIMARC.po | 2 +- misc/translator/po/km-KH-opac-bootstrap.po | 8 +- misc/translator/po/km-KH-staff-help.po | 35 +- misc/translator/po/km-KH-staff-prog.po | 345 ++- misc/translator/po/kn-Knda-marc-MARC21.po | 2 +- misc/translator/po/kn-Knda-marc-NORMARC.po | 2 +- misc/translator/po/kn-Knda-marc-UNIMARC.po | 2 +- misc/translator/po/kn-Knda-opac-bootstrap.po | 8 +- misc/translator/po/kn-Knda-staff-help.po | 35 +- misc/translator/po/kn-Knda-staff-prog.po | 346 ++- misc/translator/po/ko-Kore-KP-marc-MARC21.po | 2 +- misc/translator/po/ko-Kore-KP-marc-NORMARC.po | 2 +- misc/translator/po/ko-Kore-KP-marc-UNIMARC.po | 2 +- misc/translator/po/ko-Kore-KP-opac-bootstrap.po | 8 +- misc/translator/po/ko-Kore-KP-staff-help.po | 35 +- misc/translator/po/ko-Kore-KP-staff-prog.po | 352 ++- misc/translator/po/ku-Arab-marc-MARC21.po | 2 +- misc/translator/po/ku-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ku-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ku-Arab-opac-bootstrap.po | 8 +- misc/translator/po/ku-Arab-staff-help.po | 35 +- misc/translator/po/ku-Arab-staff-prog.po | 350 ++- misc/translator/po/lo-Laoo-marc-MARC21.po | 2 +- misc/translator/po/lo-Laoo-marc-NORMARC.po | 2 +- misc/translator/po/lo-Laoo-marc-UNIMARC.po | 2 +- misc/translator/po/lo-Laoo-opac-bootstrap.po | 8 +- misc/translator/po/lo-Laoo-staff-help.po | 35 +- misc/translator/po/lo-Laoo-staff-prog.po | 350 ++- misc/translator/po/mi-NZ-marc-MARC21.po | 2 +- misc/translator/po/mi-NZ-marc-NORMARC.po | 2 +- misc/translator/po/mi-NZ-marc-UNIMARC.po | 2 +- misc/translator/po/mi-NZ-opac-bootstrap.po | 8 +- misc/translator/po/mi-NZ-staff-help.po | 35 +- misc/translator/po/mi-NZ-staff-prog.po | 350 ++- misc/translator/po/ml-marc-MARC21.po | 2 +- misc/translator/po/ml-marc-NORMARC.po | 2 +- misc/translator/po/ml-marc-UNIMARC.po | 2 +- misc/translator/po/ml-opac-bootstrap.po | 8 +- misc/translator/po/ml-staff-help.po | 35 +- misc/translator/po/ml-staff-prog.po | 345 ++- misc/translator/po/mon-marc-MARC21.po | 2 +- misc/translator/po/mon-marc-NORMARC.po | 2 +- misc/translator/po/mon-marc-UNIMARC.po | 2 +- misc/translator/po/mon-opac-bootstrap.po | 8 +- misc/translator/po/mon-staff-help.po | 35 +- misc/translator/po/mon-staff-prog.po | 350 ++- misc/translator/po/mr-marc-MARC21.po | 2 +- misc/translator/po/mr-marc-NORMARC.po | 2 +- misc/translator/po/mr-marc-UNIMARC.po | 2 +- misc/translator/po/mr-opac-bootstrap.po | 8 +- misc/translator/po/mr-staff-help.po | 35 +- misc/translator/po/mr-staff-prog.po | 350 ++- misc/translator/po/ms-MY-marc-MARC21.po | 2 +- misc/translator/po/ms-MY-marc-NORMARC.po | 2 +- misc/translator/po/ms-MY-marc-UNIMARC.po | 2 +- misc/translator/po/ms-MY-opac-bootstrap.po | 8 +- misc/translator/po/ms-MY-staff-help.po | 35 +- misc/translator/po/ms-MY-staff-prog.po | 350 ++- misc/translator/po/my-marc-MARC21.po | 2 +- misc/translator/po/my-marc-NORMARC.po | 2 +- misc/translator/po/my-marc-UNIMARC.po | 2 +- misc/translator/po/my-opac-bootstrap.po | 8 +- misc/translator/po/my-staff-help.po | 35 +- misc/translator/po/my-staff-prog.po | 345 ++- misc/translator/po/nb-NO-marc-MARC21.po | 2 +- misc/translator/po/nb-NO-marc-NORMARC.po | 2 +- misc/translator/po/nb-NO-marc-UNIMARC.po | 2 +- misc/translator/po/nb-NO-opac-bootstrap.po | 10 +- misc/translator/po/nb-NO-staff-help.po | 35 +- misc/translator/po/nb-NO-staff-prog.po | 365 ++- misc/translator/po/ne-NE-marc-MARC21.po | 2 +- misc/translator/po/ne-NE-marc-NORMARC.po | 2 +- misc/translator/po/ne-NE-marc-UNIMARC.po | 2 +- misc/translator/po/ne-NE-opac-bootstrap.po | 8 +- misc/translator/po/ne-NE-staff-help.po | 35 +- misc/translator/po/ne-NE-staff-prog.po | 345 ++- misc/translator/po/nl-BE-marc-MARC21.po | 2 +- misc/translator/po/nl-BE-marc-NORMARC.po | 2 +- misc/translator/po/nl-BE-marc-UNIMARC.po | 2 +- misc/translator/po/nl-BE-opac-bootstrap.po | 8 +- misc/translator/po/nl-BE-staff-help.po | 35 +- misc/translator/po/nl-BE-staff-prog.po | 350 ++- misc/translator/po/nl-NL-marc-MARC21.po | 2 +- misc/translator/po/nl-NL-marc-NORMARC.po | 2 +- misc/translator/po/nl-NL-marc-UNIMARC.po | 2 +- misc/translator/po/nl-NL-opac-bootstrap.po | 8 +- misc/translator/po/nl-NL-staff-help.po | 35 +- misc/translator/po/nl-NL-staff-prog.po | 346 ++- misc/translator/po/nn-NO-marc-MARC21.po | 2 +- misc/translator/po/nn-NO-marc-NORMARC.po | 2 +- misc/translator/po/nn-NO-marc-UNIMARC.po | 2 +- misc/translator/po/nn-NO-opac-bootstrap.po | 8 +- misc/translator/po/nn-NO-staff-help.po | 35 +- misc/translator/po/nn-NO-staff-prog.po | 350 ++- misc/translator/po/oc-marc-MARC21.po | 2 +- misc/translator/po/oc-marc-NORMARC.po | 2 +- misc/translator/po/oc-marc-UNIMARC.po | 2 +- misc/translator/po/oc-opac-bootstrap.po | 8 +- misc/translator/po/oc-staff-help.po | 35 +- misc/translator/po/oc-staff-prog.po | 356 ++- misc/translator/po/pbr-marc-MARC21.po | 2 +- misc/translator/po/pbr-marc-NORMARC.po | 2 +- misc/translator/po/pbr-marc-UNIMARC.po | 2 +- misc/translator/po/pbr-opac-bootstrap.po | 8 +- misc/translator/po/pbr-staff-help.po | 35 +- misc/translator/po/pbr-staff-prog.po | 345 ++- misc/translator/po/pl-PL-marc-MARC21.po | 10 +- misc/translator/po/pl-PL-marc-NORMARC.po | 2 +- misc/translator/po/pl-PL-marc-UNIMARC.po | 2 +- misc/translator/po/pl-PL-opac-bootstrap.po | 10 +- misc/translator/po/pl-PL-pref.po | 24 +- misc/translator/po/pl-PL-staff-help.po | 35 +- misc/translator/po/pl-PL-staff-prog.po | 426 +-- misc/translator/po/prs-marc-MARC21.po | 2 +- misc/translator/po/prs-marc-NORMARC.po | 2 +- misc/translator/po/prs-marc-UNIMARC.po | 2 +- misc/translator/po/prs-opac-bootstrap.po | 8 +- misc/translator/po/prs-staff-help.po | 35 +- misc/translator/po/prs-staff-prog.po | 350 ++- misc/translator/po/pt-BR-marc-MARC21.po | 2 +- misc/translator/po/pt-BR-marc-NORMARC.po | 2 +- misc/translator/po/pt-BR-marc-UNIMARC.po | 2 +- misc/translator/po/pt-BR-opac-bootstrap.po | 10 +- misc/translator/po/pt-BR-staff-help.po | 35 +- misc/translator/po/pt-BR-staff-prog.po | 356 ++- misc/translator/po/pt-PT-marc-MARC21.po | 2 +- misc/translator/po/pt-PT-marc-NORMARC.po | 2 +- misc/translator/po/pt-PT-marc-UNIMARC.po | 2 +- misc/translator/po/pt-PT-opac-bootstrap.po | 10 +- misc/translator/po/pt-PT-staff-help.po | 35 +- misc/translator/po/pt-PT-staff-prog.po | 356 ++- misc/translator/po/ro-RO-marc-MARC21.po | 74 +- misc/translator/po/ro-RO-marc-NORMARC.po | 2 +- misc/translator/po/ro-RO-marc-UNIMARC.po | 2 +- misc/translator/po/ro-RO-opac-bootstrap.po | 356 ++- misc/translator/po/ro-RO-staff-help.po | 35 +- misc/translator/po/ro-RO-staff-prog.po | 370 ++- misc/translator/po/ru-RU-marc-MARC21.po | 2 +- misc/translator/po/ru-RU-marc-NORMARC.po | 2 +- misc/translator/po/ru-RU-marc-UNIMARC.po | 2 +- misc/translator/po/ru-RU-opac-bootstrap.po | 10 +- misc/translator/po/ru-RU-staff-help.po | 35 +- misc/translator/po/ru-RU-staff-prog.po | 350 ++- misc/translator/po/rw-RW-marc-MARC21.po | 2 +- misc/translator/po/rw-RW-marc-NORMARC.po | 2 +- misc/translator/po/rw-RW-marc-UNIMARC.po | 2 +- misc/translator/po/rw-RW-opac-bootstrap.po | 8 +- misc/translator/po/rw-RW-staff-help.po | 35 +- misc/translator/po/rw-RW-staff-prog.po | 345 ++- misc/translator/po/sd-PK-marc-MARC21.po | 2 +- misc/translator/po/sd-PK-marc-NORMARC.po | 2 +- misc/translator/po/sd-PK-marc-UNIMARC.po | 2 +- misc/translator/po/sd-PK-opac-bootstrap.po | 8 +- misc/translator/po/sd-PK-staff-help.po | 35 +- misc/translator/po/sd-PK-staff-prog.po | 345 ++- misc/translator/po/sk-SK-marc-MARC21.po | 2 +- misc/translator/po/sk-SK-marc-NORMARC.po | 2 +- misc/translator/po/sk-SK-marc-UNIMARC.po | 2 +- misc/translator/po/sk-SK-opac-bootstrap.po | 10 +- misc/translator/po/sk-SK-staff-help.po | 35 +- misc/translator/po/sk-SK-staff-prog.po | 356 ++- misc/translator/po/sl-SI-marc-MARC21.po | 2 +- misc/translator/po/sl-SI-marc-NORMARC.po | 2 +- misc/translator/po/sl-SI-marc-UNIMARC.po | 2 +- misc/translator/po/sl-SI-opac-bootstrap.po | 8 +- misc/translator/po/sl-SI-staff-help.po | 35 +- misc/translator/po/sl-SI-staff-prog.po | 345 ++- misc/translator/po/sq-AL-marc-MARC21.po | 2 +- misc/translator/po/sq-AL-marc-NORMARC.po | 2 +- misc/translator/po/sq-AL-marc-UNIMARC.po | 2 +- misc/translator/po/sq-AL-opac-bootstrap.po | 10 +- misc/translator/po/sq-AL-staff-help.po | 35 +- misc/translator/po/sq-AL-staff-prog.po | 346 ++- misc/translator/po/sr-Cyrl-marc-MARC21.po | 2 +- misc/translator/po/sr-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/sr-Cyrl-marc-UNIMARC.po | 2 +- misc/translator/po/sr-Cyrl-opac-bootstrap.po | 8 +- misc/translator/po/sr-Cyrl-staff-help.po | 35 +- misc/translator/po/sr-Cyrl-staff-prog.po | 346 ++- misc/translator/po/sv-SE-marc-MARC21.po | 2 +- misc/translator/po/sv-SE-marc-NORMARC.po | 2 +- misc/translator/po/sv-SE-marc-UNIMARC.po | 2 +- misc/translator/po/sv-SE-opac-bootstrap.po | 10 +- misc/translator/po/sv-SE-pref.po | 3222 ++++++++++---------- misc/translator/po/sv-SE-staff-help.po | 35 +- misc/translator/po/sv-SE-staff-prog.po | 356 ++- misc/translator/po/sw-KE-marc-MARC21.po | 2 +- misc/translator/po/sw-KE-marc-NORMARC.po | 2 +- misc/translator/po/sw-KE-marc-UNIMARC.po | 2 +- misc/translator/po/sw-KE-opac-bootstrap.po | 8 +- misc/translator/po/sw-KE-staff-help.po | 35 +- misc/translator/po/sw-KE-staff-prog.po | 345 ++- misc/translator/po/ta-LK-marc-MARC21.po | 2 +- misc/translator/po/ta-LK-marc-NORMARC.po | 2 +- misc/translator/po/ta-LK-marc-UNIMARC.po | 2 +- misc/translator/po/ta-LK-opac-bootstrap.po | 8 +- misc/translator/po/ta-LK-staff-help.po | 35 +- misc/translator/po/ta-LK-staff-prog.po | 345 ++- misc/translator/po/ta-marc-MARC21.po | 2 +- misc/translator/po/ta-marc-NORMARC.po | 2 +- misc/translator/po/ta-marc-UNIMARC.po | 2 +- misc/translator/po/ta-opac-bootstrap.po | 8 +- misc/translator/po/ta-staff-help.po | 35 +- misc/translator/po/ta-staff-prog.po | 345 ++- misc/translator/po/tet-marc-MARC21.po | 2 +- misc/translator/po/tet-marc-NORMARC.po | 2 +- misc/translator/po/tet-marc-UNIMARC.po | 2 +- misc/translator/po/tet-opac-bootstrap.po | 10 +- misc/translator/po/tet-staff-help.po | 35 +- misc/translator/po/tet-staff-prog.po | 351 ++- misc/translator/po/th-TH-marc-MARC21.po | 2 +- misc/translator/po/th-TH-marc-NORMARC.po | 2 +- misc/translator/po/th-TH-marc-UNIMARC.po | 2 +- misc/translator/po/th-TH-opac-bootstrap.po | 8 +- misc/translator/po/th-TH-staff-help.po | 35 +- misc/translator/po/th-TH-staff-prog.po | 346 ++- misc/translator/po/tl-PH-marc-MARC21.po | 2 +- misc/translator/po/tl-PH-marc-NORMARC.po | 2 +- misc/translator/po/tl-PH-marc-UNIMARC.po | 2 +- misc/translator/po/tl-PH-opac-bootstrap.po | 8 +- misc/translator/po/tl-PH-staff-help.po | 35 +- misc/translator/po/tl-PH-staff-prog.po | 346 ++- misc/translator/po/tr-TR-marc-MARC21.po | 2 +- misc/translator/po/tr-TR-marc-NORMARC.po | 2 +- misc/translator/po/tr-TR-marc-UNIMARC.po | 2 +- misc/translator/po/tr-TR-opac-bootstrap.po | 10 +- misc/translator/po/tr-TR-pref.po | 39 +- misc/translator/po/tr-TR-staff-help.po | 35 +- misc/translator/po/tr-TR-staff-prog.po | 368 ++- misc/translator/po/uk-UA-marc-MARC21.po | 14 +- misc/translator/po/uk-UA-marc-NORMARC.po | 2 +- misc/translator/po/uk-UA-marc-UNIMARC.po | 2 +- misc/translator/po/uk-UA-opac-bootstrap.po | 14 +- misc/translator/po/uk-UA-pref.po | 4 +- misc/translator/po/uk-UA-staff-help.po | 39 +- misc/translator/po/uk-UA-staff-prog.po | 361 ++- misc/translator/po/ur-Arab-marc-MARC21.po | 2 +- misc/translator/po/ur-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ur-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ur-Arab-opac-bootstrap.po | 8 +- misc/translator/po/ur-Arab-staff-help.po | 35 +- misc/translator/po/ur-Arab-staff-prog.po | 345 ++- misc/translator/po/vi-VN-marc-MARC21.po | 2 +- misc/translator/po/vi-VN-marc-NORMARC.po | 2 +- misc/translator/po/vi-VN-marc-UNIMARC.po | 2 +- misc/translator/po/vi-VN-opac-bootstrap.po | 8 +- misc/translator/po/vi-VN-staff-help.po | 35 +- misc/translator/po/vi-VN-staff-prog.po | 350 ++- misc/translator/po/zh-Hans-CN-marc-MARC21.po | 2 +- misc/translator/po/zh-Hans-CN-marc-NORMARC.po | 2 +- misc/translator/po/zh-Hans-CN-marc-UNIMARC.po | 2 +- misc/translator/po/zh-Hans-CN-opac-bootstrap.po | 10 +- misc/translator/po/zh-Hans-CN-staff-help.po | 35 +- misc/translator/po/zh-Hans-CN-staff-prog.po | 356 ++- misc/translator/po/zh-Hans-TW-marc-MARC21.po | 2 +- misc/translator/po/zh-Hans-TW-marc-NORMARC.po | 2 +- misc/translator/po/zh-Hans-TW-marc-UNIMARC.po | 2 +- misc/translator/po/zh-Hans-TW-opac-bootstrap.po | 10 +- misc/translator/po/zh-Hans-TW-pref.po | 33 +- misc/translator/po/zh-Hans-TW-staff-help.po | 43 +- misc/translator/po/zh-Hans-TW-staff-prog.po | 394 +-- t/db_dependent/Auth.t | 27 +- 506 files changed, 21347 insertions(+), 17923 deletions(-) copy misc/release_notes/{release_notes_16_11_03.html => release_notes_16_11_05.html} (63%) copy misc/release_notes/{release_notes_16_11_03.md => release_notes_16_11_05.md} (59%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 22 11:39:24 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 22 Mar 2017 10:39:24 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-568-g95f4c19 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 95f4c197692523d6abec712bbb003e4b710344e3 (commit) via 36ee625f0890c80190e53f59bbb2282c3b2bfcb5 (commit) from 9d8e83528f39a2d8401f7ed50888c595f48205f5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 95f4c197692523d6abec712bbb003e4b710344e3 Author: Marcel de Rooy Date: Fri Mar 17 10:52:46 2017 +0100 Bug 18284: [QA Follow-up] Add test descriptions Signed-off-by: Marcel de Rooy Signed-off-by: Brendan A Gallagher commit 36ee625f0890c80190e53f59bbb2282c3b2bfcb5 Author: Jonathan Druart Date: Thu Mar 16 15:20:10 2017 -0300 Bug 18284: (bug 17196 follow-up) Move biblio metadata when a biblio is deleted There is a deletedbiblio_metadata table but it is not populated when a biblio is deleted. Since we have a ON DELETE constraint on biblio_metadata.biblionumber, the row is deleted when the biblio entry is deleted => data lost! Test plan: - Create a biblio - Delete it => Without this patch the deletedbiblio_metadata table is not populated with the biblio_metadata row related to the biblio => With this patch applied you should see that the row has been moved. Followed test plan, behaves as expected Signed-off-by: Marc V?ron Signed-off-by: Marcel de Rooy Signed-off-by: Brendan A Gallagher ----------------------------------------------------------------------- Summary of changes: C4/Biblio.pm | 30 ++++++++++++++++++++++++++++++ t/db_dependent/Biblio.t | 30 +++++++++++++++++++++++------- 2 files changed, 53 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 23 09:49:39 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 23 Mar 2017 08:49:39 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-570-g7aa0808 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 7aa0808ff227850fc448b74dabed9b15ac0eb927 (commit) via 48b1328ebeb7ed2337ba75a582705389767b691a (commit) from 95f4c197692523d6abec712bbb003e4b710344e3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7aa0808ff227850fc448b74dabed9b15ac0eb927 Author: Jonathan Druart Date: Thu Mar 9 16:58:17 2017 -0300 Bug 18242: [SOLUTION 2]Handle correctly move to old_issues The table old_issues has a primary key defined on the issue_id column. This issue_id comes from the issues table when an item is checked in. In some case the value of issue_id already exists in the table Basically this happens when an item is returned and mysqld is restarted: The auto increment value for issues.issue_id will be reset to MAX(issue_id)+1 (which is the value of the last entry of old_issues). See also the description of bug 18003 for more informations. In this solution the change is done at code level instead of DB structure: If old_issues.issue_id already exists before moving from the issues table, the issue_id is updated (not on cascade for accountlines.issue_id, should it?) before the move. Signed-off-by: Chris Cormack Signed-off-by: Nick Clemens Signed-off-by: Brendan A Gallagher commit 48b1328ebeb7ed2337ba75a582705389767b691a Author: Jonathan Druart Date: Thu Mar 9 16:41:31 2017 -0300 Bug 18242: [SOLUTION 2]Add tests Signed-off-by: Chris Cormack Signed-off-by: Nick Clemens Signed-off-by: Brendan A Gallagher ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 74 +++++++++++++++++++++------------- t/db_dependent/Circulation/Returns.t | 28 ++++++++++++- 2 files changed, 73 insertions(+), 29 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 23 09:51:09 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 23 Mar 2017 08:51:09 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-571-ga649958 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a649958315c98500ebe0ea3f91c05a8067d54e58 (commit) from 7aa0808ff227850fc448b74dabed9b15ac0eb927 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a649958315c98500ebe0ea3f91c05a8067d54e58 Author: David Gustafsson Date: Mon Mar 20 15:13:13 2017 +0100 Bug 18305 - jquery.fixFloat.js breaks advanced MARC editor Remove use of ECMASCRIPT 2015 default parameter syntax in jquery.fixFloat.js to be compatible with a wider range of browser versions. Test plan: 1. Usa a not so modern browser, for example Chrome/Chromium < 49, any version of IE besides Edge, Opera, or Firefox < 15.0. 2. Edit a bibliographic record in staff client and try switching to advanced MARC editor (check console, no errors should appear). Signed-off-by: Mirko Tietgen Signed-off-by: Jonathan Druart Signed-off-by: Brendan A Gallagher ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.fixFloat.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 23 09:57:17 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 23 Mar 2017 08:57:17 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-572-gf79cf79 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f79cf7930d887ea157fa64bb89fb0eb130b74aae (commit) from a649958315c98500ebe0ea3f91c05a8067d54e58 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f79cf7930d887ea157fa64bb89fb0eb130b74aae Author: Nicolas Legrand Date: Wed Feb 22 10:11:18 2017 +0100 Bug 18150 - CanItemBeReserved doesn't work with (IndependentBranches AND ! canreservefromotherbranches) The variable $item used to be a hash, but at the end of the function, it's a Koha object. As $item->{homebranch} doesn't yield anything and should be $item->homebranch. It prevents people using different branches without holds between branches from placing a hold on an item they should be able to place hold on. Test plan: 1. Before patch a. with IndependantBranches off b. try to place hold on an item you should be able to place hold on c. it should work d. put IndependantBranches on and canreservefromotherbranches off e. shouldn't work 2. after patches redo steps from (1) and everything should be working fine. Signed-off-by: Christopher Brannon Signed-off-by: Jonathan Druart Note: Item is fetched twice, it's not necessary. But out of the scope of this patch. Signed-off-by: Brendan A Gallagher ----------------------------------------------------------------------- Summary of changes: C4/Reserves.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 23 11:09:52 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 23 Mar 2017 10:09:52 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-573-g547208d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 547208d06458865300f1ff23f7723da6e4901d6a (commit) from f79cf7930d887ea157fa64bb89fb0eb130b74aae (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 547208d06458865300f1ff23f7723da6e4901d6a Author: Nick Clemens Date: Fri Mar 3 16:10:09 2017 +0000 Bug 18115 - Fix use of Objects as hashref in acqui/addorderiso2709.pl - Bug 15503 followup Fix use of 'gstrate' for 'tax_rate' Signed-off-by: Matthias Meusburger Signed-off-by: Jonathan Druart Signed-off-by: Brendan A Gallagher ----------------------------------------------------------------------- Summary of changes: acqui/addorderiso2709.pl | 20 ++++++++++---------- t/db_dependent/Acquisition/OrderUsers.t | 1 - 2 files changed, 10 insertions(+), 11 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 23 11:12:30 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 23 Mar 2017 10:12:30 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-576-geb5151b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via eb5151b0a89758d6da83eccfa08b5239f20d4ea2 (commit) via db93f85a333f10499562605d26b6fc2600ffc496 (commit) via 4f2c804e8a36f9016e02867cc46669dff59e605d (commit) from 547208d06458865300f1ff23f7723da6e4901d6a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit eb5151b0a89758d6da83eccfa08b5239f20d4ea2 Author: Baptiste Wojtkowski Date: Mon Mar 20 08:35:17 2017 +0000 BUG 8010: Removed Auth2.t Signed-off-by: Marc V?ron Signed-off-by: Martin Renvoize Signed-off-by: Brendan A Gallagher commit db93f85a333f10499562605d26b6fc2600ffc496 Author: Baptiste Wojtkowski Date: Fri Mar 17 16:12:59 2017 +0000 BUG 8010: Correct a few syntax errors, and moved tests - Tests are now in t/db_dependent/Search/History.t - There were 2 differents sysprefs in sysprefs.sql and in atomicupdate => fixed Signed-off-by: Marc V?ron Signed-off-by: Martin Renvoize Signed-off-by: Brendan A Gallagher commit 4f2c804e8a36f9016e02867cc46669dff59e605d Author: Baptiste Wojtkowski Date: Mon Feb 13 15:21:57 2017 +0000 Added a new syspref to Load history to the next user Added a syspref LoadHistory addSearchHistoryToTheFirstLoggedUser to select if you want the system to add the history of searches performed without session when you log in as registered user. TEST PLAN 1 - Search in the catalogue, check you are not logged 2 - Log in : your last history should appear 4 - Log out 5 - Apply the patch 6 - Repeat 1 and 2 7 - Desactivate the syspref addSearchHistoryToTheFirstLoggedUser 8 - Repeat 1 and 2 : your last history shouldn't appear The Unit test doesn't rollback but delete the added lines : the function get_template_and_user allway sets the autocommit to 1. https://bugs.koha-community.org/show_bug.cgi?id=8010 Tested 3 patches together, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Martin Renvoize Signed-off-by: Brendan A Gallagher ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 50 ++++---- ...adSearchHistoryToTheFirstLoggedUser_syspref.sql | 2 + installer/data/mysql/sysprefs.sql | 1 + .../en/modules/admin/preferences/searching.pref | 8 ++ t/db_dependent/Search/History.t | 129 +++++++++++++++++++- 5 files changed, 165 insertions(+), 25 deletions(-) create mode 100644 installer/data/mysql/atomicupdate/bug_8010-add_LoadSearchHistoryToTheFirstLoggedUser_syspref.sql hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 23 11:23:59 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 23 Mar 2017 10:23:59 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-578-g0d239e4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 0d239e4e6f3c7095173773252dc9ce38b48c0799 (commit) via 2ead301181c33f42d3c88abffa8d18b8a416b40a (commit) from eb5151b0a89758d6da83eccfa08b5239f20d4ea2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0d239e4e6f3c7095173773252dc9ce38b48c0799 Author: Nick Clemens Date: Mon Mar 20 07:22:41 2017 -0400 Bug 18264 - (QA Followup) Remove use of GetBiblioFromItemNumber Replace with (blank) Signed-off-by: Jonathan Druart Signed-off-by: Brendan A Gallagher commit 2ead301181c33f42d3c88abffa8d18b8a416b40a Author: Nick Clemens Date: Tue Mar 14 14:16:09 2017 +0000 Bug 18264 - Course reserves - use itemnumber for editing existing reserve items This patch alters the crouse reserves module to use itemnumber as the lookup method for existing reserves as opposed to barcode To test: 1 - Apply patch 2 - Add some items to a course reserves - all should work as expected 3 - Delete the barcode for an item on reserve 4 - Note the edit link still resolves to the correct item Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Brendan A Gallagher ----------------------------------------------------------------------- Summary of changes: course_reserves/add_items.pl | 19 ++++++++++++------- .../en/modules/course_reserves/add_items-step2.tt | 4 ++-- .../en/modules/course_reserves/course-details.tt | 2 +- 3 files changed, 15 insertions(+), 10 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 23 11:29:04 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 23 Mar 2017 10:29:04 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-579-g3115ac6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 3115ac641f2e8cf2c7ec7b697e4e74092ef06f45 (commit) from 0d239e4e6f3c7095173773252dc9ce38b48c0799 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3115ac641f2e8cf2c7ec7b697e4e74092ef06f45 Author: Jonathan Druart Date: Mon Mar 13 01:11:54 2017 -0300 Bug 18256: Koha::Items - Remove GetItemsCount C4::Items::GetItemsCount can be replaced with Koha::Biblio->items->count Test plan: Create a bibliographic record with items attached Try to delete the record from a basket (acquisition module), the detail page and the batch item deletion tool. => You should not be able to delete it. Remove the items and then try again to delete the record => Now you must be able to delete it. Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Brendan A Gallagher ----------------------------------------------------------------------- Summary of changes: C4/Acquisition.pm | 4 +++- C4/Items.pm | 21 -------------------- acqui/basket.pl | 5 +++-- acqui/parcel.pl | 2 +- catalogue/ISBDdetail.pl | 5 ++++- catalogue/MARCdetail.pl | 5 ++++- catalogue/imageviewer.pl | 5 ++++- catalogue/labeledMARCdetail.pl | 4 +++- t/db_dependent/Acquisition.t | 41 ++++++++++++++++++++++++++++++++++------ tools/batchMod.pl | 4 +++- 10 files changed, 60 insertions(+), 36 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 23 11:35:30 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 23 Mar 2017 10:35:30 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-582-gb925afc Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b925afc451590acf9f30bcacde160b70f10b8be7 (commit) via 0b7702d00342c06241ea7f2430d13c204ce0e230 (commit) via 306250e4967aa27dbb9807e622065ed76dd5048c (commit) from 3115ac641f2e8cf2c7ec7b697e4e74092ef06f45 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b925afc451590acf9f30bcacde160b70f10b8be7 Author: Nick Clemens Date: Thu Feb 16 14:26:20 2017 +0000 Bug 17169 - Use CCODE descriptions instead of codes Signed-off-by: Jonathan Druart Signed-off-by: Brendan A Gallagher commit 0b7702d00342c06241ea7f2430d13c204ce0e230 Author: Tomas Cohen Arazi Date: Mon Feb 6 16:49:49 2017 -0300 Bug 17169: (QA followup) Add NORMARC and UNIMARC definitions for CCODE Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Brendan A Gallagher commit 306250e4967aa27dbb9807e622065ed76dd5048c Author: Nick Clemens Date: Tue Oct 11 09:01:12 2016 +0000 Bug 17169: Add a facet for ccode fields to ElasticSearch To test: 1 - Apply patch 2 - Backup your db 3 - Drop and create a new db to ensure your mappings are refreshed from the patch 4 - add some titles with items with collection codes 5 - search and see collection code facets 6 - sign off Work to be done: 1 - Replace codes with descriptions Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Brendan A Gallagher ----------------------------------------------------------------------- Summary of changes: Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 1 + Koha/SearchEngine/Elasticsearch/Search.pm | 2 +- admin/searchengine/elasticsearch/mappings.yaml | 19 +++++++++++++++++++ koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc | 3 +++ .../opac-tmpl/bootstrap/en/includes/opac-facets.inc | 3 +++ 5 files changed, 27 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 23 13:07:46 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 23 Mar 2017 12:07:46 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-583-g20ad341 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 20ad341eefc555e0cf2b0f2862347e8a48b28935 (commit) from b925afc451590acf9f30bcacde160b70f10b8be7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 20ad341eefc555e0cf2b0f2862347e8a48b28935 Author: Marc V?ron Date: Sat Mar 11 17:18:10 2017 +0100 Bug 8603: Patron card creator - 'Barcode Type' doesn't stick in layouts To reproduce: 1. Make a new layout 2. Tick "Print card number as barcode" 3. Change 'Barcode Type' to anything other than Code39 4. Save 5. Edit it again 6. Its back to Code39 To test: 1. Apply patch 2. Repeat steps above 3. Verify that 'Barcode type' is selected as expected Signed-off-by: Nick Clemens https://bugs.koha-community.org/show_bug.cgi?id=18063 https://bugs.koha-community.org/show_bug.cgi?id=8063 Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy Signed-off-by: Brendan A Gallagher ----------------------------------------------------------------------- Summary of changes: patroncards/edit-layout.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 23 13:09:04 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 23 Mar 2017 12:09:04 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-584-g37da40b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 37da40b323d8bc012724510fe4839dcb908c2b3b (commit) from 20ad341eefc555e0cf2b0f2862347e8a48b28935 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 37da40b323d8bc012724510fe4839dcb908c2b3b Author: Marc V?ron Date: Sat Mar 11 19:17:37 2017 +0100 Bug 18246: Patron card creator: Unit not always displays properly in layouts To reproduce: 1) Create a new layout 2) Select an unit in "Units selection" 3) Save 4) Edit layout again 5) Select other unit, e.g. 'SI Centimeter' 6) Save 7) Repeat 8) Edit again Error: Latest unit seems to stick and can no longer be changed, because in units drop down, multiple untis are marked as selected. To test: 1) Apply patch 2) Repeat steps above, verify that value for units always display as expected. Signed-off-by: Jesse Maseto Signed-off-by: Marcel de Rooy Signed-off-by: Brendan A Gallagher ----------------------------------------------------------------------- Summary of changes: patroncards/edit-layout.pl | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 23 13:12:33 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 23 Mar 2017 12:12:33 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-586-g708a896 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 708a896ffadda23caf1dc52463f47aede8fe005a (commit) via c80cd97b68c76312062780783427542a5268c61f (commit) from 37da40b323d8bc012724510fe4839dcb908c2b3b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 708a896ffadda23caf1dc52463f47aede8fe005a Author: Mark Tompsett Date: Fri Mar 10 15:04:15 2017 -0500 Bug 18215: Third case which was missed. Git install old-school style a pre-tls koha Drop the DB Create the DB change branch to master Run a web install. Signed-off-by: Brendan A Gallagher commit c80cd97b68c76312062780783427542a5268c61f Author: Marcel de Rooy Date: Fri Mar 10 09:17:02 2017 +0100 Bug 18215: Fix another tls warning Resolve warning: Use of uninitialized value in string eq at C4/Installer.pm line 79. Test plan: Add a trivial .sql file in atomicupdate (comment is sufficient). Run updatedatabase.pl Without the patch you have the warning. Apply the patch and repeat (no warning). Signed-off-by: Marcel de Rooy Signed-off-by: Brendan A Gallagher ----------------------------------------------------------------------- Summary of changes: C4/Installer.pm | 2 +- installer/install.pl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 23 13:23:58 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 23 Mar 2017 12:23:58 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-588-g5823d4c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 5823d4ca6a71404d502eeb7f1bf5dd152fd98e22 (commit) via f86500351af0a1a4d1593eb2aa689b8ec52bc401 (commit) from 708a896ffadda23caf1dc52463f47aede8fe005a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5823d4ca6a71404d502eeb7f1bf5dd152fd98e22 Author: Jonathan Druart Date: Tue Feb 14 15:22:40 2017 +0000 Bug 18094: Only search in searchable patron attributes if searching in standard fields Test plan: - Add a new patron attrbute and mark it searchable - Populate a new patron with 'potato' in that field - Add/edit another patron to have email potato at invalidemail.com' - Perform a patron search with query 'potato' (in standard fields) => Both patrons are returned - Perform a patron search with filters 'Email' and query 'potato' => Only 1 patron is returned and you are redirected to the patron detail page. Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Brendan A Gallagher commit f86500351af0a1a4d1593eb2aa689b8ec52bc401 Author: Jonathan Druart Date: Tue Feb 14 16:19:25 2017 +0100 Bug 18094: Add tests to highlight the problem Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Brendan A Gallagher ----------------------------------------------------------------------- Summary of changes: C4/Utils/DataTables/Members.pm | 2 +- t/db_dependent/Utils/Datatables_Members.t | 31 ++++++++++++++++++++++++++++- 2 files changed, 31 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 23 13:25:19 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 23 Mar 2017 12:25:19 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-589-gfe898bc Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via fe898bc641b6d76d7b869654dce4ec21e219daf8 (commit) from 5823d4ca6a71404d502eeb7f1bf5dd152fd98e22 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fe898bc641b6d76d7b869654dce4ec21e219daf8 Author: Jonathan Druart Date: Tue Feb 7 09:10:42 2017 +0100 Bug 18069: Remove residue of rebuild_zebra -x Bug 17731 removed the -x option of rebuild_zebra but koha-rebuild-zebra still cals the script with this option. "Warning: You passed -x which is already the default and is now deprecated" Test plan: sudo koha-rebuild-zebra -f should no longer raise the warning Signed-off-by: Mason James Signed-off-by: Marcel de Rooy Signed-off-by: Brendan A Gallagher ----------------------------------------------------------------------- Summary of changes: debian/scripts/koha-rebuild-zebra | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 23 14:28:26 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 23 Mar 2017 13:28:26 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-590-g39f3ed3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 39f3ed3f10bf902354527d10896fa19c37e2f492 (commit) from fe898bc641b6d76d7b869654dce4ec21e219daf8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 39f3ed3f10bf902354527d10896fa19c37e2f492 Author: Brendan A Gallagher Date: Wed Mar 22 22:16:10 2017 +0000 DBREV for Bug 8010 - Search history can be added to the wrong patron Signed-off-by: Brendan A Gallagher ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- ...010-add_LoadSearchHistoryToTheFirstLoggedUser_syspref.sql | 2 -- installer/data/mysql/updatedatabase.pl | 10 ++++++++++ 3 files changed, 11 insertions(+), 3 deletions(-) delete mode 100644 installer/data/mysql/atomicupdate/bug_8010-add_LoadSearchHistoryToTheFirstLoggedUser_syspref.sql hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 23 14:42:05 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 23 Mar 2017 13:42:05 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-591-g01a8d63 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 01a8d633dfab80e6d146de17d9c27a84a1a06cc8 (commit) from 39f3ed3f10bf902354527d10896fa19c37e2f492 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 01a8d633dfab80e6d146de17d9c27a84a1a06cc8 Author: Kyle M Hall Date: Thu Mar 23 13:33:59 2017 +0000 Update DB Schema Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/Schema/Result/SearchField.pm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 23 16:14:23 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 23 Mar 2017 15:14:23 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-596-g6b626b6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6b626b64944dff0ba0adff99da26e3bbe8eb7544 (commit) via ffbeae312bb472a58adf33e13b8c3d5f9124f0af (commit) via 384b69462e6005e316680b88de304095a39a318b (commit) via 601312c6c80e82837869b4eb2c91686c6a1361b3 (commit) via 3d46c0c7bb8ce487f85cd0d0233cb7ceffcbbde3 (commit) from 01a8d633dfab80e6d146de17d9c27a84a1a06cc8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6b626b64944dff0ba0adff99da26e3bbe8eb7544 Author: Jonathan Druart Date: Sun Mar 12 19:54:58 2017 -0300 Bug 14608: Move country list to an include file Signed-off-by: Marcel de Rooy Signed-off-by: Brendan A Gallagher commit ffbeae312bb472a58adf33e13b8c3d5f9124f0af Author: Mark Tompsett Date: Fri Jan 13 13:33:05 2017 -0500 Bug 14608: Follow up on labels and search box This addresses concerns raised in comment #26 and comment #27. Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Signed-off-by: Brendan A Gallagher commit 384b69462e6005e316680b88de304095a39a318b Author: Jonathan Druart Date: Tue Dec 20 22:31:41 2016 +0000 Bug 14608: Add a reference to Hea at the end of the installer process Signed-off-by: Mark Tompsett Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Signed-off-by: Brendan A Gallagher commit 601312c6c80e82837869b4eb2c91686c6a1361b3 Author: Jonathan Druart Date: Tue Dec 20 22:31:25 2016 +0000 Bug 14608: Add a link from the admin home page Signed-off-by: Mark Tompsett Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Signed-off-by: Brendan A Gallagher commit 3d46c0c7bb8ce487f85cd0d0233cb7ceffcbbde3 Author: Jonathan Druart Date: Tue Dec 20 22:29:53 2016 +0000 Bug 14608: Add a page to configure shared statistics This patch set adds: - a reference to Hea at the end of the installation process - a link to the new page from the admin home page - a new page to easily configure shared statistics Signed-off-by: Mark Tompsett Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Signed-off-by: Brendan A Gallagher ----------------------------------------------------------------------- Summary of changes: admin/usage_statistics.pl | 58 ++++++ .../prog/en/includes/country-list.inc | 196 ++++++++++++++++++++ .../prog/en/modules/admin/admin-home.tt | 2 + .../prog/en/modules/admin/usage_statistics.tt | 178 ++++++++++++++++++ .../prog/en/modules/installer/step3.tt | 4 + 5 files changed, 438 insertions(+) create mode 100755 admin/usage_statistics.pl create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/country-list.inc create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/admin/usage_statistics.tt hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 23 16:30:16 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 23 Mar 2017 15:30:16 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-603-geee0020 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via eee0020f4a1eaea3acf5fd53ea0a3d2e98b3ba35 (commit) via c3db243ad459782362c7051a648730bc51fda83d (commit) via 7aff8696614604960b7244fac798a28c4438fc36 (commit) via c302fd2bea710c960db7bc14aeac762c865f677a (commit) via 0d479976af81df3a66024e4ffc18ecc2038c0103 (commit) via f3c4c7016128e6550230cd44f8efedf0374db25e (commit) via 63a1adff9097493be0329aebab5fb3bf8a627b80 (commit) from 6b626b64944dff0ba0adff99da26e3bbe8eb7544 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit eee0020f4a1eaea3acf5fd53ea0a3d2e98b3ba35 Author: Brendan A Gallagher Date: Thu Mar 23 00:18:10 2017 +0000 DBREV for Bug 18066 - Hea - Version 2 Signed-off-by: Brendan A Gallagher commit c3db243ad459782362c7051a648730bc51fda83d Author: Julian Maurice Date: Tue Mar 21 12:01:45 2017 +0100 Bug 18066: Fix map positioning in admin/usage_statistics.pl Signed-off-by: Julian Maurice Signed-off-by: Brendan A Gallagher commit 7aff8696614604960b7244fac798a28c4438fc36 Author: Jonathan Druart Date: Tue Mar 21 07:21:38 2017 -0300 Bug 18066: Fix tests Signed-off-by: Julian Maurice Signed-off-by: Brendan A Gallagher commit c302fd2bea710c960db7bc14aeac762c865f677a Author: Jonathan Druart Date: Tue Feb 28 17:13:07 2017 +0000 Bug 18066: Use https for ws Signed-off-by: Chris Cormack Signed-off-by: Julian Maurice Signed-off-by: Brendan A Gallagher commit 0d479976af81df3a66024e4ffc18ecc2038c0103 Author: Jonathan Druart Date: Tue Feb 28 11:16:56 2017 +0000 Bug 18066: Do not use token for OSM tiles Signed-off-by: Chris Cormack Signed-off-by: Julian Maurice Signed-off-by: Brendan A Gallagher commit f3c4c7016128e6550230cd44f8efedf0374db25e Author: Jonathan Druart Date: Tue Feb 7 09:31:28 2017 +0100 Bug 18066: Add the leaflet library Signed-off-by: Chris Cormack Signed-off-by: Julian Maurice Signed-off-by: Brendan A Gallagher commit 63a1adff9097493be0329aebab5fb3bf8a627b80 Author: Jonathan Druart Date: Thu Feb 2 16:53:58 2017 +0100 Bug 18066: Hea V2 This patch is the Koha part of the Hea v2 project. You can find the (testing) code for the server at hea-ws - https://github.com/joubu/hea-ws/commits/v2 hea-app - https://github.com/joubu/hea-app/commits/v2 They contain the different pull requests made over the last 6 months. More information on Hea at https://wiki.koha-community.org/wiki/KohaUsageStat_RFC The goal of this commit message is to provide an overview of what could be a new version of Hea. Prior to these changes, the Hea database was filled with 1 line per Koha installation. System preferences were filled by the libraries and a cronjob (share_usage_with_koha_community.pl) collected these values to send them to a webservice (hea-ws/upload.pl). With the need to collect more data we would want to collect data at the library level (branch) and not at the installation level. For instance the geolocation, the url or the country can be different from one library to another, even if managed from the same Koha installation. The Hea DB has been upgraded to reflect that change (see hea-app/sql/schema.sql). The hidden goal of this patch is to make Hea sexier and explain better to libraries how it can be useful to share their information with the Koha community. I guess the main problem is the lack of communication and explanations about what we are doing we these data. To fill this gap I'd like to (TODO) 1. Communicate on the ML about this new version of Hea (once it got pushed and backported) 2. Link the Privacy_Policy.md from the Hea interface 3. Get help from a native English speaker to add popup/help/info/whatever on "Home ? Administration ? Usage statistics", to clearly explain what happens (and what will not happen!) when an option or another is set. You can find screenshot of this whole enhancement on bug 18066, comment 2. What this patch does: - Create a new branches.geolocation DB field - Add 3 new sysprefs: * UsageStatsGeolocation * UsageStatsLibrariesInfo * UsageStatsPublicID - Integrate the Leaflet JS library to get a fancy map to pick geolocations How does it works: On the new administration page where statistics to share are configured, there are several new things. It is now possible to share information either per Koha installation or libraries. If UsageStatsLibrariesInfo is set, the info at library level (url, name, country, geolocation) will be sent to the Hea webservice. If it is not set, you can decide to fill UsageStatsLibraryUrl, UsageStatsLibraryName, UsageStatsCountry, UsageStatsGeolocation to share these information. Note that even if the data are retrieved at installation level, it's better to fill the prefs as well: On the Hea website the different libraries defined for a given Koha installation could be displayed on the same page. This page is a public page which will be attributed to every installation (with the pref UsageStatsPublicID). On this page all the info available publicly will be displayed. TODO later: - Add a button on the administration page to delete the info shared publicly. It will be easy to show that the info are no longer displayed on the public page. - Add an icon per Koha installation to get a better "public page" - Any suggestions? Test plan: We will need to test hea-ws, hea-app and the Koha-side code to test the whole enhancement. 1/ To start, clone the hea-ws and hea-app project and checkout the 'master' branch (*not* 'v2') 2/ Create the hea database and user CREATE DATABASE hea CREATE USER 'hea'@'localhost' IDENTIFIED BY 'hea'; GRANT ALL PRIVILEGES ON hea.* TO 'hea'@'localhost'; FLUSH PRIVILEGES; 3/ Fill the DB with some data mysql hea < hea-app/sql/schema.sql mysql hea < hea-app/sql/sql/mock-data.sql 4/ Checkout the 'v2' branch for both hea-ws and hea-app 5/ Execute the upgrade DB script % cd hea-app % perl -p -i -e 's/REPLACE_ME/hea/' sql/upgrade.pl # Fill the DB info % perl sql/upgrade.pl Now the DB is using the v2 structure. That means we have 1 installation row per library previously defined. 1 library row has also been created. 5/ Configure hea-ws % echo '192.168.50.1 hea.koha-community.org' >> /etc/hosts DocumentRoot "/path/to/hea-ws" ServerName "hea.koha-community.org" Options +ExecCGI Require all granted AddHandler cgi-script .pl And enable it with a2ensite, then restart apache. The copy the database.yml.sample to database.yml and edit it to fill the DB info. 6/ Launch the hea-app % cd hea-app % edit README.md # to install the missing modules % cp environments/config.yml environments/development.yml % edit environments/development.yml # to fill the DB info % perl bin/app.pl Then hit localhost:3000 You should see a local version of Hea with sample data 7/ Back to Koha side A. We will test that the webservice still works with previous version of Koha (without v2) a. Do not configure Hea % perl misc/cronjobs/share_usage_with_koha_community.pl -f -v Then hit localhost:3000 => Nothing added b. Configure Hea on admin/usage_statistics.pl perl misc/cronjobs/share_usage_with_koha_community.pl -f -v => New library added c. Modify the Hea configuration perl misc/cronjobs/share_usage_with_koha_community.pl -f -v => Info are modified B. Not we will test that it works with the new version (much more fun ;)) % git checkout hea-v2 # koha a. Configure Hea using /admin/usage_statistics.pl perl misc/cronjobs/share_usage_with_koha_community.pl -f -v => Check the result on localhost:3000 b. Share libraries's info perl misc/cronjobs/share_usage_with_koha_community.pl -f -v c. Continue to play a bit and share the info. Signed-off-by: Chris Cormack Signed-off-by: Julian Maurice Signed-off-by: Brendan A Gallagher ----------------------------------------------------------------------- Summary of changes: C4/UsageStats.pm | 28 +- Koha.pm | 2 +- Koha/Schema/Result/Branch.pm | 12 +- admin/usage_statistics.pl | 17 +- installer/data/mysql/sysprefs.sql | 3 + installer/data/mysql/updatedatabase.pl | 22 + .../intranet-tmpl/lib/leaflet/images/layers-2x.png | Bin 0 -> 1259 bytes .../intranet-tmpl/lib/leaflet/images/layers.png | Bin 0 -> 696 bytes .../lib/leaflet/images/marker-icon-2x.png | Bin 0 -> 2586 bytes .../lib/leaflet/images/marker-icon.png | Bin 0 -> 1466 bytes .../lib/leaflet/images/marker-shadow.png | Bin 0 -> 618 bytes koha-tmpl/intranet-tmpl/lib/leaflet/leaflet-src.js |13251 ++++++++++++++++++++ .../intranet-tmpl/lib/leaflet/leaflet-src.map | 1 + koha-tmpl/intranet-tmpl/lib/leaflet/leaflet.css | 624 + koha-tmpl/intranet-tmpl/lib/leaflet/leaflet.js | 9 + koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 3 + .../prog/en/modules/admin/preferences/admin.pref | 11 + .../prog/en/modules/admin/usage_statistics.tt | 167 +- misc/cronjobs/share_usage_with_koha_community.pl | 2 +- t/db_dependent/UsageStats.t | 43 +- 20 files changed, 14164 insertions(+), 31 deletions(-) create mode 100644 koha-tmpl/intranet-tmpl/lib/leaflet/images/layers-2x.png create mode 100644 koha-tmpl/intranet-tmpl/lib/leaflet/images/layers.png create mode 100644 koha-tmpl/intranet-tmpl/lib/leaflet/images/marker-icon-2x.png create mode 100644 koha-tmpl/intranet-tmpl/lib/leaflet/images/marker-icon.png create mode 100644 koha-tmpl/intranet-tmpl/lib/leaflet/images/marker-shadow.png create mode 100644 koha-tmpl/intranet-tmpl/lib/leaflet/leaflet-src.js create mode 100644 koha-tmpl/intranet-tmpl/lib/leaflet/leaflet-src.map create mode 100644 koha-tmpl/intranet-tmpl/lib/leaflet/leaflet.css create mode 100644 koha-tmpl/intranet-tmpl/lib/leaflet/leaflet.js hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 23 16:44:35 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 23 Mar 2017 15:44:35 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-604-ga6f50cb Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a6f50cbcb92c2575eb31e906ea54bf0386654906 (commit) from eee0020f4a1eaea3acf5fd53ea0a3d2e98b3ba35 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a6f50cbcb92c2575eb31e906ea54bf0386654906 Author: Jonathan Druart Date: Wed Feb 1 12:42:43 2017 +0100 Bug 18028: Remove outdated install_misc directory This directory is no longer maintained and contain outdated information on how to install Koha. On the Internet there are tutos using them and that can create confusion to new user (yes it could be confusing as well to execute a file that does no longer exist). NOTE: last tweak was mid 2016, but before that 2015. So I agree with the deletion. Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Signed-off-by: Brendan A Gallagher ----------------------------------------------------------------------- Summary of changes: install_misc/UpgradeBackup.pm | 94 ---------------- install_misc/debian.packages | 148 -------------------------- install_misc/environment_Makefile.PL | 80 -------------- install_misc/ubuntu-packages.sh | 194 ---------------------------------- install_misc/ubuntu.10.04.packages | 163 ---------------------------- install_misc/ubuntu.12.04.packages | 168 ----------------------------- install_misc/ubuntu.packages | 168 ----------------------------- 7 files changed, 1015 deletions(-) delete mode 100644 install_misc/UpgradeBackup.pm delete mode 100644 install_misc/debian.packages delete mode 100644 install_misc/environment_Makefile.PL delete mode 100755 install_misc/ubuntu-packages.sh delete mode 100644 install_misc/ubuntu.10.04.packages delete mode 100644 install_misc/ubuntu.12.04.packages delete mode 100644 install_misc/ubuntu.packages hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 23 16:47:00 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 23 Mar 2017 15:47:00 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-606-gfbbd4b4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via fbbd4b40f0d71b79194fc186e66f985488be26c6 (commit) via 5508897d5a2b73c30d50fed26a6bfed62bf49398 (commit) from a6f50cbcb92c2575eb31e906ea54bf0386654906 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fbbd4b40f0d71b79194fc186e66f985488be26c6 Author: Marcel de Rooy Date: Sun Jan 29 15:40:14 2017 +0100 Bug 18010: Remove potential exposure from gettemplate A similar bad template check from C4::Auth::get_template_and_user should be applied in C4::Templates::gettemplate. Before this patch it would be possible to expose files like: my $template = C4::Templates::gettemplate( '/etc/passwd', 'intranet', CGI::new, 1 ); print $template->output; Note that the is_plugin flag in the above call is the culprit. This patch provides a quick security fix without touching get_template_and_user, and can be backported to stable branches. I will provide an enhanced and centralized check on report 17989, also removing the is_plugin flag. Note: We allow .pref here too for use in admin/preferences.pl. Test plan: [1] Run t/db_dependent/Auth.t (triggering get_template_and_user and gettemplate). [2] Run t/db_dependent/Templates.t again (see first test plan). The tests should no longer fail. [3] Open a page on opac or intranet. [4] Open a systempreferences tab. [5] Add a book to the cart and send it ([opac-]sendbasket uses gettemplate). Signed-off-by: Marcel de Rooy Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Brendan A Gallagher commit 5508897d5a2b73c30d50fed26a6bfed62bf49398 Author: Marcel de Rooy Date: Sun Jan 29 15:52:22 2017 +0100 Bug 18010: Unit test for gettemplate A trivial test, similar to the ones in Auth.t. Without the check in gettemplate (added in the second patch), the passwd file will be exposed and the test fails. Test plan: Run t/db_dependent/Templates.t without second patch. The two tests in the last subtest should fail. Signed-off-by: Marcel de Rooy Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Brendan A Gallagher ----------------------------------------------------------------------- Summary of changes: C4/Templates.pm | 1 + t/db_dependent/Templates.t | 11 ++++++++++- 2 files changed, 11 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 23 16:48:19 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 23 Mar 2017 15:48:19 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-607-g3b794b1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 3b794b1312d0cfac81b302d0e823e2c5683a1f0e (commit) from fbbd4b40f0d71b79194fc186e66f985488be26c6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3b794b1312d0cfac81b302d0e823e2c5683a1f0e Author: Nick Clemens Date: Wed Jan 25 17:00:34 2017 +0000 Bug 17995 - HOLDPLACED notice should have access to the reserves table To test: 1 - Add reserves.reservenotes to HOLDPLACED message 2 - Enable emailLibrarianWhenHoldIsPlaced OpacHoldNotes sysprefs 3 - Place a hold via OPAC with a note 4 - view the messagequeue and note the reservenotes is blank 5 - Apply patch 6 - Place a hold with a note 7 - view the messagequeue and note the reservenotes is populated Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Brendan A Gallagher ----------------------------------------------------------------------- Summary of changes: C4/Reserves.pm | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 23 16:51:27 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 23 Mar 2017 15:51:27 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-608-g85a21dd Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 85a21dd9715518746dd93defd4803a81d23a5b18 (commit) from 3b794b1312d0cfac81b302d0e823e2c5683a1f0e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 85a21dd9715518746dd93defd4803a81d23a5b18 Author: Brendan A Gallagher Date: Thu Mar 23 00:39:22 2017 +0000 Updating the Schema Signed-off-by: Brendan A Gallagher ----------------------------------------------------------------------- Summary of changes: Koha/Schema/Result/Branch.pm | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 23 16:55:42 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 23 Mar 2017 15:55:42 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-609-g30d24fe Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 30d24fe6fc2021df37b0744b9b6270471e29c25a (commit) from 85a21dd9715518746dd93defd4803a81d23a5b18 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 30d24fe6fc2021df37b0744b9b6270471e29c25a Author: Colin Campbell Date: Wed Nov 9 14:37:33 2016 +0000 Bug 17605: [MASTER] Add currency to orders generated by quotes Sets the vendors currency in the edi generated order The currency used is agreed between vendor and library and the value in the quote is optional Edifact potentially allows the currency to be overwitten by specifying another currency in the CUX segment but we know currently of no supplier doing this Signed-off-by: Alex Buckley Signed-off-by: Marcel de Rooy Signed-off-by: Brendan A Gallagher ----------------------------------------------------------------------- Summary of changes: Koha/EDI.pm | 3 +++ 1 file changed, 3 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 23 16:58:21 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 23 Mar 2017 15:58:21 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-611-gbe156d9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via be156d9ad9e5bcfadab34d44f90e04fd61e256ad (commit) via 607b14516a955c9989e4764c69527edbc1f36ba0 (commit) from 30d24fe6fc2021df37b0744b9b6270471e29c25a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit be156d9ad9e5bcfadab34d44f90e04fd61e256ad Author: Jonathan Druart Date: Thu Feb 9 12:44:38 2017 +0100 Bug 15854: Use a READ and WRITE LOCK on message_queue To make sure we will not never get a race conditions for these kinds of notices, we need to add a LOCK on the message_queue table. This does not smell the best way to do that, but I faced deadlock issues when I tried to use "UPDATE FOR" https://dev.mysql.com/doc/refman/5.7/en/innodb-locking-reads.html https://dev.mysql.com/doc/refman/5.7/en/lock-tables.html https://dev.mysql.com/doc/refman/5.7/en/commit.html To test this patch, or another solution, you need to apply manually this change: my $message = C4::Message->find_last_message($borrower, $type, $mtt); unless ( $message ) { + sleep(1); C4::Message->enqueue($letter, $borrower, $mtt); } else { And repeat the test plan from first patch. Do not forget to truncate the message_queue table. Followed test plans, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Martin Renvoize Signed-off-by: Brendan A Gallagher commit 607b14516a955c9989e4764c69527edbc1f36ba0 Author: Jonathan Druart Date: Thu Feb 9 12:13:07 2017 +0100 Bug 15854: Simplify the code to limit race conditions There is an obvious race condition when CHECKIN and RENEWAL are generated from circulation.pl calling svc/renew or svc/checkin in AJAX. The 2 first queries will try to get the id of the last message (find_last_message) and if it does not exist, they will insert it. Theorically that could be lead to have several "digest" messages for a given patron. I did not recreate more than 2 messages, from the third one at least one of the two firsts existed in the DB already. This patch just simplifies the code to make the SELECT and INSERT or UPDATE closer and limit the race condition possibilities. Test plan: 0. Set RenewalSendNotice and circ rules to have a lot of renewals available 1. Use batch checkouts (or one by one) to check out several items to a patron 2. Empty message_queue (at least of this patron) 3. Renew them all at once ("select all" link, "renew or check in" button) 4. Check the message_queue Without this patch you have lot of chances to faced a race condition and get at least 2 messages for the same patron. This is not expected, we expect 1 digest with all the messages. With this patch apply you have lot of chances not to face it, but it's not 100% safe as we do not use a mechanism to lock the table at the DBMS level. Tested both patches together, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Martin Renvoize Signed-off-by: Brendan A Gallagher ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 64 ++++++++++++++++++++++------------------------------- 1 file changed, 27 insertions(+), 37 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 23 17:24:52 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 23 Mar 2017 16:24:52 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-612-g6fe4de7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6fe4de7f5c093d077cf5192d7405d7da1ac2c0d2 (commit) from be156d9ad9e5bcfadab34d44f90e04fd61e256ad (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6fe4de7f5c093d077cf5192d7405d7da1ac2c0d2 Author: Jonathan Druart Date: Thu Mar 23 13:14:59 2017 -0300 Fix updatedatabase.pl syntax error ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/updatedatabase.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 23 17:42:07 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 23 Mar 2017 16:42:07 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-614-g9c347a7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 9c347a7f3571b36b8c3415e41cf567fa76f0ad56 (commit) via 64812347c9536340484f17758c6881ca882987d6 (commit) from 6fe4de7f5c093d077cf5192d7405d7da1ac2c0d2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9c347a7f3571b36b8c3415e41cf567fa76f0ad56 Author: Jonathan Druart Date: Thu Mar 23 13:32:34 2017 -0300 Bug 18066: Update Schema This patch basically reverts 85a21dd9715518746dd93defd4803a81d23a5b18 commit 64812347c9536340484f17758c6881ca882987d6 Author: Jonathan Druart Date: Thu Mar 23 13:31:24 2017 -0300 Bug 18066: Add the new geolocation column to kohastructure.sql ----------------------------------------------------------------------- Summary of changes: Koha/Schema/Result/Branch.pm | 12 ++++++++++-- installer/data/mysql/kohastructure.sql | 1 + 2 files changed, 11 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 24 19:51:35 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 24 Mar 2017 18:51:35 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-619-g382d086 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 382d086ecdb220f882382bbb58b0121d0604d684 (commit) via 3f2ade46ace082e69cb9f40f7cf241853e1897f8 (commit) via a39fbd78e61d62b680f7e592effc903e344a928f (commit) via 62249ff5734819a148bff267855b570387ea231a (commit) via bd01041ac6985656ca1bf1f2a6b9d565e98bd61d (commit) from 9c347a7f3571b36b8c3415e41cf567fa76f0ad56 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 382d086ecdb220f882382bbb58b0121d0604d684 Author: Tomas Cohen Arazi Date: Fri Mar 10 12:32:06 2017 -0300 Bug 17755: (followup) Override ->search to allow filtering by branchcode Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 3f2ade46ace082e69cb9f40f7cf241853e1897f8 Author: Tomas Cohen Arazi Date: Thu Jan 19 15:09:15 2017 -0300 Bug 17755: (QA followup) Return $self when appropriate As failure situations raise exceptions that should be handled outside the object class, methods should return $self so successive calls can be chained nicely. This patch makes methods return $self and adjusts the tests to reflect this change. Make sure tests pass: - Run: $ prove t/db_dependent/Koha/Patron/Attribute/Types.t => SUCCESS: Tests return green - Sign off :-D Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit a39fbd78e61d62b680f7e592effc903e344a928f Author: Tomas Cohen Arazi Date: Mon Oct 31 15:09:43 2016 -0300 Bug 17755: Introduce Koha::Patron::Attribute::Type(s) This patch introduces the Koha::Object-based classes for handling patron attribute types. It also adds branch limitation handling to the Koha::Patron::Attribute::Type class. It is built on top of the new Koha::Object::Library::Limit class that extends Koha::Object so it handles library limits. Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 62249ff5734819a148bff267855b570387ea231a Author: Tomas Cohen Arazi Date: Mon Dec 12 11:15:45 2016 -0300 Bug 17755: Unit tests This patch introduces unit tests for Koha::Object::Library::Limit. It is done this way because it needs to be instantiated to be usable. To test: - Run: $ prove t/db_dependent/Koha/Patron/Attribute/Types.t => SUCCESS: Tests pass - Sign off :-D Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit bd01041ac6985656ca1bf1f2a6b9d565e98bd61d Author: Tomas Cohen Arazi Date: Mon Dec 12 14:17:44 2016 -0300 Bug 17755: Introduce Koha::Object::Limit::Library This patch introduces a new class for extending Koha::Object using multiple inheritance. It cannot be used standalone, it needs to be used in Koha::Object implementations like this: use base qw( Koha::Object Koha::Object::Limit::Library ); Its goal is to provide a single way and place to deal with this common pattern in Koha's codebase. As it happened with Koha::Object, that needed to be tested in a real object class, this work was done on top of Koha::Patron::Attribute::Type implementation and it is fully covered by the tests that are introduced for it. Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/Exceptions.pm | 9 +- Koha/Object/Limit/Library.pm | 188 +++++++++++ .../Currencies.pm => Patron/Attribute/Type.pm} | 31 +- Koha/{Libraries.pm => Patron/Attribute/Types.pm} | 45 +-- t/db_dependent/Koha/Patron/Attribute/Types.t | 339 ++++++++++++++++++++ 5 files changed, 574 insertions(+), 38 deletions(-) create mode 100644 Koha/Object/Limit/Library.pm copy Koha/{Acquisition/Currencies.pm => Patron/Attribute/Type.pm} (68%) copy Koha/{Libraries.pm => Patron/Attribute/Types.pm} (51%) create mode 100644 t/db_dependent/Koha/Patron/Attribute/Types.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 24 19:52:18 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 24 Mar 2017 18:52:18 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-621-g7b5c8cb Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 7b5c8cbf079725381341cea5494717d58735ca9b (commit) via 9812c8b26e9886f0a7a79bbcefba1ac91ec7ed79 (commit) from 382d086ecdb220f882382bbb58b0121d0604d684 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7b5c8cbf079725381341cea5494717d58735ca9b Author: Tomas Cohen Arazi Date: Fri Dec 23 12:05:35 2016 -0300 Bug 17792: Add opac_editable and opac_display methods This patch adds two methods to the Koha::Patron::Attribute: - opac_display - opac_editable Both method just check the corresponding Koha::Patron::Attribute::Type and return the values for those attributes. This is useful to avoid checking that manually on the controller scripts. To test: - Run: $ prove t/db_dependent/Koha/Patron/Attributes.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 9812c8b26e9886f0a7a79bbcefba1ac91ec7ed79 Author: Tomas Cohen Arazi Date: Wed Dec 21 12:53:07 2016 -0300 Bug 17792: Introduce Koha::Patron::Attribute(s) This patch introduces stub Koha::Object(s) for handling patron attributes. Edit: amended the POD to fix C&p mistake Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/{SMS/Provider.pm => Patron/Attribute.pm} | 45 +++++----- Koha/{CsvProfiles.pm => Patron/Attributes.pm} | 14 ++-- t/db_dependent/Koha/Patron/Attributes.t | 110 +++++++++++++++++++++++++ 3 files changed, 139 insertions(+), 30 deletions(-) copy Koha/{SMS/Provider.pm => Patron/Attribute.pm} (55%) copy Koha/{CsvProfiles.pm => Patron/Attributes.pm} (81%) create mode 100644 t/db_dependent/Koha/Patron/Attributes.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 24 19:58:12 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 24 Mar 2017 18:58:12 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-643-g3db855b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 3db855b872ccbf133e238ddc537b6f0b818c931e (commit) via e06c1931872f2a54e2a12cf2b8468480e613ce5c (commit) via ec9ac4d7b9873dd99b92212564b698dc6bf904b1 (commit) via 3ce090781970c869d6d4c78f9e0eb4eb3e0d8ad2 (commit) via ebe44fc7febfa248842bf1f50ccb1c961f31259b (commit) via afb7b7dc2df5e2c0f7ebb4ed75777fef4a5ab12a (commit) via f9a5fd005efa2567be99f9eb2f44e5e79641f74c (commit) via e63e4bb35a67a2beed52139b2f149623526d5e23 (commit) via c44a377d9cc44538b6a7134f48763184c9a110ba (commit) via b6797fdc8708e73eee0cfd7562e55543ed4f5e3b (commit) via bb039e0328e0151b78c752e7a7be2c6a1c4f7d3a (commit) via 2811d8555d5dc409b8a358795d3f188c87fa950b (commit) via 0fbc8620e2180f67270403d4c3a81d7334b3f62e (commit) via dc6702e3cd9aa17b41880975823305f5d5aa553c (commit) via c8889f0ff7cfb83422f0136faaf1be9cdec5515c (commit) via 925e664f42ff9546624946258fe27263e6041fa3 (commit) via bfa3f410320e6baad98f277a6cfd9b41a4d68dac (commit) via 01506e0195266a0e6b6005c43b9763bf4a09dd78 (commit) via 2eda977de72434643863301726c5aa9f51be7b36 (commit) via 0a40e0c60ff2ac405960cfd34033dd3d5896ac08 (commit) via 1fa5660dbcd015b20cd3059dfdba11c0b4f345bd (commit) via 21e496bd7bcf3cd3f8826410384005e0cabc17d4 (commit) from 7b5c8cbf079725381341cea5494717d58735ca9b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3db855b872ccbf133e238ddc537b6f0b818c931e Author: Kyle M Hall Date: Fri Mar 24 18:49:15 2017 +0000 Bug 13757 - DBRev 16.12.00.016 Signed-off-by: Kyle M Hall commit e06c1931872f2a54e2a12cf2b8468480e613ce5c Author: Tomas Cohen Arazi Date: Wed Mar 22 18:51:48 2017 -0300 Bug 13757: (QA followup) Filter out non-editable params before storing Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit ec9ac4d7b9873dd99b92212564b698dc6bf904b1 Author: Tomas Cohen Arazi Date: Wed Mar 22 16:22:53 2017 -0300 Bug 13757: (QA followup) Exclude empty attributes from rendering if non-editable In self registration opac displayable (and not editable) attributes are displayed as empty. This an empty value is passed to the template for creating an empty input and it shouldn't when the attribute is not editable. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 3ce090781970c869d6d4c78f9e0eb4eb3e0d8ad2 Author: Tomas Cohen Arazi Date: Thu Feb 16 16:02:48 2017 -0300 Bug 13757: Attribute with value 0 should be stored Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit ebe44fc7febfa248842bf1f50ccb1c961f31259b Author: Tomas Cohen Arazi Date: Thu Feb 16 16:02:22 2017 -0300 Bug 13757: (regression test) Attribute with value 0 should be stored Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit afb7b7dc2df5e2c0f7ebb4ed75777fef4a5ab12a Author: Tomas Cohen Arazi Date: Fri Feb 3 15:22:57 2017 -0300 Bug 13757: Better display for attr changes in members-update.pl This patch changes the way changed attributes are displayed for the staff user to make the decision to approve (or not) the changes. Regards Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit f9a5fd005efa2567be99f9eb2f44e5e79641f74c Author: Tomas Cohen Arazi Date: Fri Feb 3 15:22:37 2017 -0300 Bug 13757: Make K::P::Modifications->pending return K::P::Attribute This patch makes Koha::Patron::Modifications->pending return Koha::Patron:Attribute objects. They are not stored on the DB but only live in memory on runtime. members-update.pl is the only place this is used, and this way we have all we need for better rendering the UI. Tests are added for the changed API. Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit e63e4bb35a67a2beed52139b2f149623526d5e23 Author: Tomas Cohen Arazi Date: Thu Feb 2 10:14:25 2017 -0300 Bug 13757: (QA followup) Fix non-editable attrs on failed save When a field is not editable but displayable in the OPAC, and you submit an incomplete/wrong update, those attributes are displayed as empty. This patch fixes that. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit c44a377d9cc44538b6a7134f48763184c9a110ba Author: Tomas Cohen Arazi Date: Mon Jan 30 12:36:57 2017 -0300 Bug 13757: (QA followup) Make opac-memberentry.pl handle attrs deletion The original code on this bug skipped empty-valued attributes. But emptying attributes is the only way to tell the controller script that the user wants to delete them. This patch makes opac-memberentry.pl check the existence of attributes sharing the code of the empty for the given patron, and it stores the deletion on the Koha::Patron::Modification as needed. Otherwise deletions got skipped. To test: - Verify setting/deleting attributes that are opac-editable and verify the results are sound. https://bugs.koha-community.org/show_bug.cgi?id=13737 Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit b6797fdc8708e73eee0cfd7562e55543ed4f5e3b Author: Tomas Cohen Arazi Date: Tue Jan 31 12:41:51 2017 -0300 Bug 13757: Make Koha::Patron::Modification->store del empty attrs This patch makes Koha::Patron::Modification->store delete the passed attributes that contain empty values. This is the way it currently works, as all opac-editable attributes are presented to the end-user and they are allowed to delete them, and the best way I found to represent the deletion on the modification request is by setting it to the empty string. I chose this way because it is how the staff interface handles it, so it is consistent. To test: - Apply this patch - Run: $ prove t/db_dependent/Koha/Patron/Modifications.t => SUCCESS: This time tests pass! - Verify comment #70 on the bug is fixed now - Sign off :-D Signed-off-by: Tomas Cohen Arazi https://bugs.koha-community.org/show_bug.cgi?id=13737 Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit bb039e0328e0151b78c752e7a7be2c6a1c4f7d3a Author: Tomas Cohen Arazi Date: Tue Jan 31 12:39:53 2017 -0300 Bug 13757: (regression tests) Empty attributes should delete existing This patch introduces tests for the required functionality. To test: - Run: $ prove t/db_dependent/Koha/Patron/Modifications.t => FAIL: The current code doesn't work like that Signed-off-by: Tomas Cohen Arazi https://bugs.koha-community.org/show_bug.cgi?id=13737 Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 2811d8555d5dc409b8a358795d3f188c87fa950b Author: Tomas Cohen Arazi Date: Fri Jan 20 10:59:27 2017 -0300 Bug 13757: (QA followup) Check DB structure before altering table Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 0fbc8620e2180f67270403d4c3a81d7334b3f62e Author: Tomas Cohen Arazi Date: Tue Jan 3 17:19:30 2017 -0300 Bug 13757: (followup) Fix authorized value display when opac_display & not opac_editable Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit dc6702e3cd9aa17b41880975823305f5d5aa553c Author: Tomas Cohen Arazi Date: Fri Dec 23 16:56:06 2016 -0300 Bug 13757: (followup) Regression tests for ->approve changes Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit c8889f0ff7cfb83422f0136faaf1be9cdec5515c Author: Tomas Cohen Arazi Date: Fri Dec 23 16:19:06 2016 -0300 Bug 13757: (followup) Only touch opac_editable attributes As reported by Owen, the members-update.pl was showing every attributes the patron has (display issue) instead of showing only those affected by the changes. This patch fixes this by filtering the patron's attributes by opac editability. It also fixes Koha::Patron::Modification->approve so it only clears the attributes with the updating 'code' and leaves the others untouched. As its been coded so far (until someone refactors it all) the Koha::Patron::Modification object needs to contain all the attributes for a specific code. And it comes from parsing the UI's input. Tests for Koha::Patron::Modification->approve to come. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 925e664f42ff9546624946258fe27263e6041fa3 Author: Tomas Cohen Arazi Date: Mon Dec 19 16:22:17 2016 -0300 Bug 13757: (followup) Staff interface changes This patch adds proper extended attributes display and handling on the patron modifications moderation page (members-update.pl). It also adds changes checking to the opac-memberentry.pl page so it only saves a modification request if there are changes (it only checked regular fields and not the extended ones). Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit bfa3f410320e6baad98f277a6cfd9b41a4d68dac Author: Tomas Cohen Arazi Date: Mon Dec 19 12:52:27 2016 -0300 Bug 13757: (followup) Remove warnings Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 01506e0195266a0e6b6005c43b9763bf4a09dd78 Author: Tomas Cohen Arazi Date: Mon Dec 19 12:51:04 2016 -0300 Bug 13757: Add extended attributes to the patron modification Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 2eda977de72434643863301726c5aa9f51be7b36 Author: Tomas Cohen Arazi Date: Thu Oct 27 11:52:20 2016 -0300 Bug 13757: DBIC update Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 0a40e0c60ff2ac405960cfd34033dd3d5896ac08 Author: Jesse Weaver Date: Wed Dec 14 12:30:10 2016 -0300 Bug 13757: OPAC changes Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 1fa5660dbcd015b20cd3059dfdba11c0b4f345bd Author: Jesse Weaver Date: Wed Dec 14 12:29:10 2016 -0300 Bug 13757: DB update Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 21e496bd7bcf3cd3f8826410384005e0cabc17d4 Author: Jesse Weaver Date: Wed Sep 2 17:54:04 2015 -0600 Bug 13757: Add the option to set patron attributes editable in the OPAC Note: this is a squashed version of the original patchset, because it was needed This patch adds an opac_editable property of borrower attribute types that can be set in the interface. I'm removing work on OPAC and will refactor it, keeping the author attribution. Test plan: 1. Repeat the following with a new and existing borrower attribute type: 2. Verify that "Editable in OPAC" can only be checked if "Display in OPAC" is checked. 3. Verify that this new property is correctly saved. Signed-off-by: Aleisha Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Members/AttributeTypes.pm | 58 +++-- Koha.pm | 2 +- Koha/Patron/Modification.pm | 48 ++-- Koha/Patron/Modifications.pm | 15 +- Koha/Schema/Result/BorrowerAttributeType.pm | 12 +- admin/patron-attr-types.pl | 25 ++- installer/data/mysql/kohastructure.sql | 1 + installer/data/mysql/updatedatabase.pl | 14 ++ koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 8 + .../prog/en/modules/admin/patron-attr-types.tt | 16 ++ .../prog/en/modules/members/members-update.tt | 49 ++++- .../bootstrap/en/modules/opac-memberentry.tt | 98 +++++++-- members/members-update.pl | 46 ++-- opac/opac-memberentry.pl | 229 ++++++++++++++++++-- t/db_dependent/Koha/Patron/Modifications.t | 106 ++++++++- 15 files changed, 627 insertions(+), 100 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 27 15:04:03 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 27 Mar 2017 13:04:03 +0000 Subject: [koha-commits] main Koha release repository branch 16.11.x updated. v16.11.05-13-gab23d13 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 16.11.x has been updated via ab23d1368343ad115a5072f7264b99c7bee68675 (commit) via bdae6c9492ea8db223c03753090060592a330be7 (commit) via 108853352a87c3493612ec29e305dcc5997fe69c (commit) via 74fe3f5cda7cac22640f9ae3d68b3d62a6765dc0 (commit) via 1161a67476b5b61358fdaecca57b012e663a7b02 (commit) via fd1f24487a73a721f5318608fb09c47a2bea2e1b (commit) via fac1ccd9b2f2ce5fd61ea842eb622b8f70e613f0 (commit) via b294550ac6db804193928af798500e18d83de9db (commit) via 50483ff17cd2b6223c9fa3a2844195a57fc95160 (commit) via 95bccfbbb8f2b0d0de064ae34dca24e3d59852a4 (commit) via 34a91f6e3d7da38aafb37a57a962c1d852f9101a (commit) via 4f57d8ccea9033cc3b6d17d69f3ac6d982877b6d (commit) via b3939f6f659fa3a409639441c24a5d5d6a73a6a3 (commit) from d3ef053c415fdab3ab59310cb4d058f6a0c50e77 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ab23d1368343ad115a5072f7264b99c7bee68675 Author: Jonathan Druart Date: Thu Feb 9 12:44:38 2017 +0100 Bug 15854: Use a READ and WRITE LOCK on message_queue To make sure we will not never get a race conditions for these kinds of notices, we need to add a LOCK on the message_queue table. This does not smell the best way to do that, but I faced deadlock issues when I tried to use "UPDATE FOR" https://dev.mysql.com/doc/refman/5.7/en/innodb-locking-reads.html https://dev.mysql.com/doc/refman/5.7/en/lock-tables.html https://dev.mysql.com/doc/refman/5.7/en/commit.html To test this patch, or another solution, you need to apply manually this change: my $message = C4::Message->find_last_message($borrower, $type, $mtt); unless ( $message ) { + sleep(1); C4::Message->enqueue($letter, $borrower, $mtt); } else { And repeat the test plan from first patch. Do not forget to truncate the message_queue table. Followed test plans, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Martin Renvoize Signed-off-by: Brendan A Gallagher (cherry picked from commit be156d9ad9e5bcfadab34d44f90e04fd61e256ad) Signed-off-by: Katrin Fischer commit bdae6c9492ea8db223c03753090060592a330be7 Author: Jonathan Druart Date: Thu Feb 9 12:13:07 2017 +0100 Bug 15854: Simplify the code to limit race conditions There is an obvious race condition when CHECKIN and RENEWAL are generated from circulation.pl calling svc/renew or svc/checkin in AJAX. The 2 first queries will try to get the id of the last message (find_last_message) and if it does not exist, they will insert it. Theorically that could be lead to have several "digest" messages for a given patron. I did not recreate more than 2 messages, from the third one at least one of the two firsts existed in the DB already. This patch just simplifies the code to make the SELECT and INSERT or UPDATE closer and limit the race condition possibilities. Test plan: 0. Set RenewalSendNotice and circ rules to have a lot of renewals available 1. Use batch checkouts (or one by one) to check out several items to a patron 2. Empty message_queue (at least of this patron) 3. Renew them all at once ("select all" link, "renew or check in" button) 4. Check the message_queue Without this patch you have lot of chances to faced a race condition and get at least 2 messages for the same patron. This is not expected, we expect 1 digest with all the messages. With this patch apply you have lot of chances not to face it, but it's not 100% safe as we do not use a mechanism to lock the table at the DBMS level. Tested both patches together, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Martin Renvoize Signed-off-by: Brendan A Gallagher (cherry picked from commit 607b14516a955c9989e4764c69527edbc1f36ba0) Signed-off-by: Katrin Fischer commit 108853352a87c3493612ec29e305dcc5997fe69c Author: Colin Campbell Date: Wed Nov 9 14:37:33 2016 +0000 Bug 17605: [STABLE] Add currency to orders generated by quotes Sets the vendors currency in the edi generated order The currency used is agreed between vendor and library and the value in the quote is optional Edifact potentially allows the currency to be overwitten by specifying another currency in the CUX segment but we know currently of no supplier doing this Signed-off-by: Alex Buckley Signed-off-by: Marcel de Rooy commit 74fe3f5cda7cac22640f9ae3d68b3d62a6765dc0 Author: Marcel de Rooy Date: Sun Jan 29 15:40:14 2017 +0100 Bug 18010: Remove potential exposure from gettemplate A similar bad template check from C4::Auth::get_template_and_user should be applied in C4::Templates::gettemplate. Before this patch it would be possible to expose files like: my $template = C4::Templates::gettemplate( '/etc/passwd', 'intranet', CGI::new, 1 ); print $template->output; Note that the is_plugin flag in the above call is the culprit. This patch provides a quick security fix without touching get_template_and_user, and can be backported to stable branches. I will provide an enhanced and centralized check on report 17989, also removing the is_plugin flag. Note: We allow .pref here too for use in admin/preferences.pl. Test plan: [1] Run t/db_dependent/Auth.t (triggering get_template_and_user and gettemplate). [2] Run t/db_dependent/Templates.t again (see first test plan). The tests should no longer fail. [3] Open a page on opac or intranet. [4] Open a systempreferences tab. [5] Add a book to the cart and send it ([opac-]sendbasket uses gettemplate). Signed-off-by: Marcel de Rooy Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Brendan A Gallagher (cherry picked from commit fbbd4b40f0d71b79194fc186e66f985488be26c6) Signed-off-by: Katrin Fischer commit 1161a67476b5b61358fdaecca57b012e663a7b02 Author: Marcel de Rooy Date: Sun Jan 29 15:52:22 2017 +0100 Bug 18010: Unit test for gettemplate A trivial test, similar to the ones in Auth.t. Without the check in gettemplate (added in the second patch), the passwd file will be exposed and the test fails. Test plan: Run t/db_dependent/Templates.t without second patch. The two tests in the last subtest should fail. Signed-off-by: Marcel de Rooy Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Brendan A Gallagher (cherry picked from commit 5508897d5a2b73c30d50fed26a6bfed62bf49398) Signed-off-by: Katrin Fischer Conflicts: t/db_dependent/Templates.t commit fd1f24487a73a721f5318608fb09c47a2bea2e1b Author: Jonathan Druart Date: Wed Feb 1 12:42:43 2017 +0100 Bug 18028: Remove outdated install_misc directory This directory is no longer maintained and contain outdated information on how to install Koha. On the Internet there are tutos using them and that can create confusion to new user (yes it could be confusing as well to execute a file that does no longer exist). NOTE: last tweak was mid 2016, but before that 2015. So I agree with the deletion. Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Signed-off-by: Brendan A Gallagher (cherry picked from commit a6f50cbcb92c2575eb31e906ea54bf0386654906) Signed-off-by: Katrin Fischer commit fac1ccd9b2f2ce5fd61ea842eb622b8f70e613f0 Author: Jonathan Druart Date: Tue Feb 7 09:10:42 2017 +0100 Bug 18069: Remove residue of rebuild_zebra -x Bug 17731 removed the -x option of rebuild_zebra but koha-rebuild-zebra still cals the script with this option. "Warning: You passed -x which is already the default and is now deprecated" Test plan: sudo koha-rebuild-zebra -f should no longer raise the warning Signed-off-by: Mason James Signed-off-by: Marcel de Rooy Signed-off-by: Brendan A Gallagher (cherry picked from commit fe898bc641b6d76d7b869654dce4ec21e219daf8) Signed-off-by: Katrin Fischer commit b294550ac6db804193928af798500e18d83de9db Author: Jonathan Druart Date: Tue Feb 14 15:22:40 2017 +0000 Bug 18094: Only search in searchable patron attributes if searching in standard fields Test plan: - Add a new patron attrbute and mark it searchable - Populate a new patron with 'potato' in that field - Add/edit another patron to have email potato at invalidemail.com' - Perform a patron search with query 'potato' (in standard fields) => Both patrons are returned - Perform a patron search with filters 'Email' and query 'potato' => Only 1 patron is returned and you are redirected to the patron detail page. Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Brendan A Gallagher (cherry picked from commit 5823d4ca6a71404d502eeb7f1bf5dd152fd98e22) Signed-off-by: Katrin Fischer commit 50483ff17cd2b6223c9fa3a2844195a57fc95160 Author: Jonathan Druart Date: Tue Feb 14 16:19:25 2017 +0100 Bug 18094: Add tests to highlight the problem Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Brendan A Gallagher (cherry picked from commit f86500351af0a1a4d1593eb2aa689b8ec52bc401) Signed-off-by: Katrin Fischer commit 95bccfbbb8f2b0d0de064ae34dca24e3d59852a4 Author: Marc V?ron Date: Sat Mar 11 19:17:37 2017 +0100 Bug 18246: Patron card creator: Unit not always displays properly in layouts To reproduce: 1) Create a new layout 2) Select an unit in "Units selection" 3) Save 4) Edit layout again 5) Select other unit, e.g. 'SI Centimeter' 6) Save 7) Repeat 8) Edit again Error: Latest unit seems to stick and can no longer be changed, because in units drop down, multiple untis are marked as selected. To test: 1) Apply patch 2) Repeat steps above, verify that value for units always display as expected. Signed-off-by: Jesse Maseto Signed-off-by: Marcel de Rooy Signed-off-by: Brendan A Gallagher (cherry picked from commit 37da40b323d8bc012724510fe4839dcb908c2b3b) Signed-off-by: Katrin Fischer commit 34a91f6e3d7da38aafb37a57a962c1d852f9101a Author: Marc V?ron Date: Sat Mar 11 17:18:10 2017 +0100 Bug 8603: Patron card creator - 'Barcode Type' doesn't stick in layouts To reproduce: 1. Make a new layout 2. Tick "Print card number as barcode" 3. Change 'Barcode Type' to anything other than Code39 4. Save 5. Edit it again 6. Its back to Code39 To test: 1. Apply patch 2. Repeat steps above 3. Verify that 'Barcode type' is selected as expected Signed-off-by: Nick Clemens https://bugs.koha-community.org/show_bug.cgi?id=18063 https://bugs.koha-community.org/show_bug.cgi?id=8063 Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy Signed-off-by: Brendan A Gallagher (cherry picked from commit 20ad341eefc555e0cf2b0f2862347e8a48b28935) Signed-off-by: Katrin Fischer commit 4f57d8ccea9033cc3b6d17d69f3ac6d982877b6d Author: Nicolas Legrand Date: Wed Feb 22 10:11:18 2017 +0100 Bug 18150 - CanItemBeReserved doesn't work with (IndependentBranches AND ! canreservefromotherbranches) The variable $item used to be a hash, but at the end of the function, it's a Koha object. As $item->{homebranch} doesn't yield anything and should be $item->homebranch. It prevents people using different branches without holds between branches from placing a hold on an item they should be able to place hold on. Test plan: 1. Before patch a. with IndependantBranches off b. try to place hold on an item you should be able to place hold on c. it should work d. put IndependantBranches on and canreservefromotherbranches off e. shouldn't work 2. after patches redo steps from (1) and everything should be working fine. Signed-off-by: Christopher Brannon Signed-off-by: Jonathan Druart Note: Item is fetched twice, it's not necessary. But out of the scope of this patch. Signed-off-by: Brendan A Gallagher (cherry picked from commit f79cf7930d887ea157fa64bb89fb0eb130b74aae) Signed-off-by: Katrin Fischer commit b3939f6f659fa3a409639441c24a5d5d6a73a6a3 Author: David Gustafsson Date: Mon Mar 20 15:13:13 2017 +0100 Bug 18305 - jquery.fixFloat.js breaks advanced MARC editor Remove use of ECMASCRIPT 2015 default parameter syntax in jquery.fixFloat.js to be compatible with a wider range of browser versions. Test plan: 1. Usa a not so modern browser, for example Chrome/Chromium < 49, any version of IE besides Edge, Opera, or Firefox < 15.0. 2. Edit a bibliographic record in staff client and try switching to advanced MARC editor (check console, no errors should appear). Signed-off-by: Mirko Tietgen Signed-off-by: Jonathan Druart Signed-off-by: Brendan A Gallagher (cherry picked from commit a649958315c98500ebe0ea3f91c05a8067d54e58) Signed-off-by: Katrin Fischer ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 64 +++---- C4/Reserves.pm | 2 +- C4/Templates.pm | 1 + C4/Utils/DataTables/Members.pm | 2 +- Koha/EDI.pm | 2 + debian/scripts/koha-rebuild-zebra | 8 +- install_misc/UpgradeBackup.pm | 94 ---------- install_misc/debian.packages | 148 --------------- install_misc/environment_Makefile.PL | 80 -------- install_misc/ubuntu-packages.sh | 194 -------------------- install_misc/ubuntu.10.04.packages | 163 ---------------- install_misc/ubuntu.12.04.packages | 168 ----------------- install_misc/ubuntu.packages | 168 ----------------- .../lib/jquery/plugins/jquery.fixFloat.js | 3 +- patroncards/edit-layout.pl | 6 +- t/db_dependent/Templates.t | 14 +- t/db_dependent/Utils/Datatables_Members.t | 31 +++- 17 files changed, 82 insertions(+), 1066 deletions(-) delete mode 100644 install_misc/UpgradeBackup.pm delete mode 100644 install_misc/debian.packages delete mode 100644 install_misc/environment_Makefile.PL delete mode 100755 install_misc/ubuntu-packages.sh delete mode 100644 install_misc/ubuntu.10.04.packages delete mode 100644 install_misc/ubuntu.12.04.packages delete mode 100644 install_misc/ubuntu.packages hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 27 15:28:18 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 27 Mar 2017 13:28:18 +0000 Subject: [koha-commits] main Koha release repository annotated tag v16.11.06 created. v16.11.06 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The annotated tag, v16.11.06 has been created at 2b0f57ad0e04a0fb53bc5bc77a47dfdf22182e8e (tag) tagging e94bf3f00f5b3e17dd01b6581093dfe1faa87aee (commit) replaces v16.11.05 tagged by Katrin Fischer on Mon Mar 27 15:27:18 2017 +0200 - Log ----------------------------------------------------------------- Koha release 16.11.06 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAABAgAGBQJY2RM2AAoJEB+uyDM6ADoA6sYP/jDGP4dWp3+wbLbL8nHtyUhg PxCotvfhjlM35hHEf024Ujdg/uL6yJRjWKnHCprb1nzYpzOaMCWqUgRI+pQa2/El 5DofZEEznTukji5S8pv89iSmczQeNM1ixgHUWr5eJQ2DBMbDz0STNFampDhPvwSM dUZ3ZgUtG3r89Stak2ZQmRbdFNZZXRHDhUUmFXe53BvEZoywvtlkAkFvffGZLyFR Z+m3CWbiYoJ0EuBc+Vo1tY87aBfaEYNbYYGIPHnwotisRDJFIq362pvulLCIyKRn vSZI6To12rK0ZdICeEi67IkBt8Pku9bW93daUEVoSWcR7iMa46upGKP411yXIpQT Ot4/DZ4pw5OELLcupPN7dQfjxfCWvHqEmwRM4fUn64dWIghwWU7Qy3NnkCWD1MDF U1IsxeQufC3Q5+AokYUIxFNjyE3wdB5QJj/5Gn+iT6TWAz5PK2xmG1IEQS6fOomt pURUv/T15D8lwH6GWBALNSi/QZFxyvAP1h/jroCr58xEec3wTdnqtmHuvEtRJZiB 40d2lPyLROPp5Hke3rZ4M3d8lqqnXTxiZkXrE6vK2qB5LAIzAoosIHVyIngHaKtX hiv0+kUxL4RmxJVLGO1J81q/r0jktyQinlo5UEioQKdxPS6Vls6QOxHRo3b8tCCh KQhW+KpC+QjRN1LYnRPi =6Wme -----END PGP SIGNATURE----- Colin Campbell (1): Bug 17605: [STABLE] Add currency to orders generated by quotes David Gustafsson (1): Bug 18305 - jquery.fixFloat.js breaks advanced MARC editor Jonathan Druart (6): Bug 18094: Add tests to highlight the problem Bug 18094: Only search in searchable patron attributes if searching in standard fields Bug 18069: Remove residue of rebuild_zebra -x Bug 18028: Remove outdated install_misc directory Bug 15854: Simplify the code to limit race conditions Bug 15854: Use a READ and WRITE LOCK on message_queue Katrin Fischer (2): Increment version for 16.11.06 release Merge remote-tracking branch 'transl/16.11.06-translate-20170327' into 16.11.x Koha instance kohadev-koha (1): Add release notes to 16.11.06 release Marc V?ron (2): Bug 8603: Patron card creator - 'Barcode Type' doesn't stick in layouts Bug 18246: Patron card creator: Unit not always displays properly in layouts Marcel de Rooy (2): Bug 18010: Unit test for gettemplate Bug 18010: Remove potential exposure from gettemplate Nicolas Legrand (1): Bug 18150 - CanItemBeReserved doesn't work with (IndependentBranches AND ! canreservefromotherbranches) root (1): Translation updates for Koha 16.11.06 ----------------------------------------------------------------------- hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 27 15:28:01 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 27 Mar 2017 13:28:01 +0000 Subject: [koha-commits] main Koha release repository branch 16.11.x updated. v16.11.06 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 16.11.x has been updated via e94bf3f00f5b3e17dd01b6581093dfe1faa87aee (commit) via 36dcb5e23d90655dcf9618035ad5d3353bc43e85 (commit) via 380b63208c5006a189177223704775bc92d98c63 (commit) via 0ce712b5520ea5c1cdb8684720c17c733e562bb9 (commit) from ab23d1368343ad115a5072f7264b99c7bee68675 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e94bf3f00f5b3e17dd01b6581093dfe1faa87aee Author: Koha instance kohadev-koha Date: Mon Mar 27 13:25:27 2017 +0000 Add release notes to 16.11.06 release commit 36dcb5e23d90655dcf9618035ad5d3353bc43e85 Merge: 380b632 0ce712b Author: Katrin Fischer Date: Mon Mar 27 13:16:40 2017 +0000 Merge remote-tracking branch 'transl/16.11.06-translate-20170327' into 16.11.x commit 380b63208c5006a189177223704775bc92d98c63 Author: Katrin Fischer Date: Mon Mar 27 15:10:02 2017 +0200 Increment version for 16.11.06 release commit 0ce712b5520ea5c1cdb8684720c17c733e562bb9 Author: root Date: Mon Mar 27 10:11:27 2017 -0300 Translation updates for Koha 16.11.06 ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/updatedatabase.pl | 6 + ...s_16_11_05.html => release_notes_16_11_06.html} | 142 ++-- ...notes_16_11_03.md => release_notes_16_11_06.md} | 125 +++- misc/translator/po/am-Ethi-marc-MARC21.po | 2 +- misc/translator/po/am-Ethi-marc-NORMARC.po | 2 +- misc/translator/po/am-Ethi-marc-UNIMARC.po | 2 +- misc/translator/po/am-Ethi-opac-bootstrap.po | 2 +- misc/translator/po/am-Ethi-staff-help.po | 2 +- misc/translator/po/am-Ethi-staff-prog.po | 2 +- misc/translator/po/ar-Arab-marc-MARC21.po | 2 +- misc/translator/po/ar-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ar-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ar-Arab-opac-bootstrap.po | 8 +- misc/translator/po/ar-Arab-staff-help.po | 8 +- misc/translator/po/ar-Arab-staff-prog.po | 49 +- misc/translator/po/as-IN-marc-MARC21.po | 2 +- misc/translator/po/as-IN-marc-NORMARC.po | 2 +- misc/translator/po/as-IN-marc-UNIMARC.po | 2 +- misc/translator/po/as-IN-opac-bootstrap.po | 2 +- misc/translator/po/as-IN-staff-help.po | 2 +- misc/translator/po/as-IN-staff-prog.po | 2 +- misc/translator/po/az-AZ-marc-MARC21.po | 2 +- misc/translator/po/az-AZ-marc-NORMARC.po | 2 +- misc/translator/po/az-AZ-marc-UNIMARC.po | 2 +- misc/translator/po/az-AZ-opac-bootstrap.po | 2 +- misc/translator/po/az-AZ-staff-help.po | 2 +- misc/translator/po/az-AZ-staff-prog.po | 2 +- misc/translator/po/be-BY-marc-MARC21.po | 2 +- misc/translator/po/be-BY-marc-NORMARC.po | 2 +- misc/translator/po/be-BY-marc-UNIMARC.po | 2 +- misc/translator/po/be-BY-opac-bootstrap.po | 2 +- misc/translator/po/be-BY-staff-help.po | 2 +- misc/translator/po/be-BY-staff-prog.po | 2 +- misc/translator/po/bg-Cyrl-marc-MARC21.po | 2 +- misc/translator/po/bg-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/bg-Cyrl-marc-UNIMARC.po | 2 +- misc/translator/po/bg-Cyrl-opac-bootstrap.po | 2 +- misc/translator/po/bg-Cyrl-staff-help.po | 2 +- misc/translator/po/bg-Cyrl-staff-prog.po | 2 +- misc/translator/po/bn-IN-marc-MARC21.po | 2 +- misc/translator/po/bn-IN-marc-NORMARC.po | 2 +- misc/translator/po/bn-IN-marc-UNIMARC.po | 2 +- misc/translator/po/bn-IN-opac-bootstrap.po | 2 +- misc/translator/po/bn-IN-staff-help.po | 2 +- misc/translator/po/bn-IN-staff-prog.po | 2 +- misc/translator/po/ca-ES-marc-MARC21.po | 2 +- misc/translator/po/ca-ES-marc-NORMARC.po | 2 +- misc/translator/po/ca-ES-marc-UNIMARC.po | 2 +- misc/translator/po/ca-ES-opac-bootstrap.po | 2 +- misc/translator/po/ca-ES-staff-help.po | 2 +- misc/translator/po/ca-ES-staff-prog.po | 2 +- misc/translator/po/cs-CZ-marc-MARC21.po | 2 +- misc/translator/po/cs-CZ-marc-NORMARC.po | 2 +- misc/translator/po/cs-CZ-marc-UNIMARC.po | 2 +- misc/translator/po/cs-CZ-opac-bootstrap.po | 12 +- misc/translator/po/cs-CZ-staff-help.po | 2 +- misc/translator/po/cs-CZ-staff-prog.po | 88 +-- misc/translator/po/cy-GB-marc-MARC21.po | 2 +- misc/translator/po/cy-GB-marc-NORMARC.po | 2 +- misc/translator/po/cy-GB-marc-UNIMARC.po | 2 +- misc/translator/po/cy-GB-opac-bootstrap.po | 2 +- misc/translator/po/cy-GB-staff-help.po | 2 +- misc/translator/po/cy-GB-staff-prog.po | 2 +- misc/translator/po/da-DK-marc-MARC21.po | 2 +- misc/translator/po/da-DK-marc-NORMARC.po | 2 +- misc/translator/po/da-DK-marc-UNIMARC.po | 2 +- misc/translator/po/da-DK-opac-bootstrap.po | 2 +- misc/translator/po/da-DK-staff-help.po | 2 +- misc/translator/po/da-DK-staff-prog.po | 2 +- misc/translator/po/de-CH-marc-MARC21.po | 2 +- misc/translator/po/de-CH-marc-NORMARC.po | 2 +- misc/translator/po/de-CH-marc-UNIMARC.po | 2 +- misc/translator/po/de-CH-opac-bootstrap.po | 2 +- misc/translator/po/de-CH-staff-help.po | 6 +- misc/translator/po/de-CH-staff-prog.po | 6 +- misc/translator/po/de-DE-marc-MARC21.po | 2 +- misc/translator/po/de-DE-marc-NORMARC.po | 2 +- misc/translator/po/de-DE-marc-UNIMARC.po | 2 +- misc/translator/po/de-DE-opac-bootstrap.po | 12 +- misc/translator/po/de-DE-staff-help.po | 10 +- misc/translator/po/de-DE-staff-prog.po | 14 +- misc/translator/po/el-GR-marc-MARC21.po | 2 +- misc/translator/po/el-GR-marc-NORMARC.po | 2 +- misc/translator/po/el-GR-marc-UNIMARC.po | 2 +- misc/translator/po/el-GR-opac-bootstrap.po | 2 +- misc/translator/po/el-GR-staff-help.po | 2 +- misc/translator/po/el-GR-staff-prog.po | 2 +- misc/translator/po/en-GB-marc-MARC21.po | 2 +- misc/translator/po/en-GB-marc-NORMARC.po | 2 +- misc/translator/po/en-GB-marc-UNIMARC.po | 2 +- misc/translator/po/en-GB-opac-bootstrap.po | 2 +- misc/translator/po/en-GB-staff-help.po | 2 +- misc/translator/po/en-GB-staff-prog.po | 2 +- misc/translator/po/en-NZ-marc-MARC21.po | 2 +- misc/translator/po/en-NZ-marc-NORMARC.po | 2 +- misc/translator/po/en-NZ-marc-UNIMARC.po | 2 +- misc/translator/po/en-NZ-opac-bootstrap.po | 2 +- misc/translator/po/en-NZ-staff-help.po | 2 +- misc/translator/po/en-NZ-staff-prog.po | 2 +- misc/translator/po/eo-marc-MARC21.po | 2 +- misc/translator/po/eo-marc-NORMARC.po | 2 +- misc/translator/po/eo-marc-UNIMARC.po | 2 +- misc/translator/po/eo-opac-bootstrap.po | 6 +- misc/translator/po/eo-staff-help.po | 2 +- misc/translator/po/eo-staff-prog.po | 2 +- misc/translator/po/es-ES-marc-MARC21.po | 2 +- misc/translator/po/es-ES-marc-NORMARC.po | 2 +- misc/translator/po/es-ES-marc-UNIMARC.po | 2 +- misc/translator/po/es-ES-opac-bootstrap.po | 6 +- misc/translator/po/es-ES-pref.po | 22 +- misc/translator/po/es-ES-staff-help.po | 6 +- misc/translator/po/es-ES-staff-prog.po | 6 +- misc/translator/po/eu-marc-MARC21.po | 2 +- misc/translator/po/eu-marc-NORMARC.po | 2 +- misc/translator/po/eu-marc-UNIMARC.po | 2 +- misc/translator/po/eu-opac-bootstrap.po | 2 +- misc/translator/po/eu-staff-help.po | 2 +- misc/translator/po/eu-staff-prog.po | 2 +- misc/translator/po/fa-Arab-marc-MARC21.po | 2 +- misc/translator/po/fa-Arab-marc-NORMARC.po | 2 +- misc/translator/po/fa-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/fa-Arab-opac-bootstrap.po | 2 +- misc/translator/po/fa-Arab-staff-help.po | 2 +- misc/translator/po/fa-Arab-staff-prog.po | 2 +- misc/translator/po/fi-FI-marc-MARC21.po | 2 +- misc/translator/po/fi-FI-marc-NORMARC.po | 2 +- misc/translator/po/fi-FI-marc-UNIMARC.po | 2 +- misc/translator/po/fi-FI-opac-bootstrap.po | 12 +- misc/translator/po/fi-FI-staff-help.po | 8 +- misc/translator/po/fi-FI-staff-prog.po | 41 +- misc/translator/po/fo-FO-marc-MARC21.po | 2 +- misc/translator/po/fo-FO-marc-NORMARC.po | 2 +- misc/translator/po/fo-FO-marc-UNIMARC.po | 2 +- misc/translator/po/fo-FO-opac-bootstrap.po | 2 +- misc/translator/po/fo-FO-staff-help.po | 2 +- misc/translator/po/fo-FO-staff-prog.po | 2 +- misc/translator/po/fr-CA-marc-MARC21.po | 2 +- misc/translator/po/fr-CA-marc-NORMARC.po | 2 +- misc/translator/po/fr-CA-marc-UNIMARC.po | 2 +- misc/translator/po/fr-CA-opac-bootstrap.po | 32 +- misc/translator/po/fr-CA-pref.po | 239 +++++-- misc/translator/po/fr-CA-staff-help.po | 2 +- misc/translator/po/fr-CA-staff-prog.po | 331 +++++---- misc/translator/po/fr-FR-marc-MARC21.po | 16 +- misc/translator/po/fr-FR-marc-NORMARC.po | 2 +- misc/translator/po/fr-FR-marc-UNIMARC.po | 14 +- misc/translator/po/fr-FR-opac-bootstrap.po | 18 +- misc/translator/po/fr-FR-pref.po | 49 +- misc/translator/po/fr-FR-staff-help.po | 94 ++- misc/translator/po/fr-FR-staff-prog.po | 737 ++++++++++---------- misc/translator/po/gl-marc-MARC21.po | 2 +- misc/translator/po/gl-marc-NORMARC.po | 2 +- misc/translator/po/gl-marc-UNIMARC.po | 2 +- misc/translator/po/gl-opac-bootstrap.po | 2 +- misc/translator/po/gl-staff-help.po | 2 +- misc/translator/po/gl-staff-prog.po | 2 +- misc/translator/po/he-Hebr-marc-MARC21.po | 14 +- misc/translator/po/he-Hebr-marc-NORMARC.po | 2 +- misc/translator/po/he-Hebr-marc-UNIMARC.po | 2 +- misc/translator/po/he-Hebr-opac-bootstrap.po | 2 +- misc/translator/po/he-Hebr-staff-help.po | 2 +- misc/translator/po/he-Hebr-staff-prog.po | 2 +- misc/translator/po/hi-marc-MARC21.po | 2 +- misc/translator/po/hi-marc-NORMARC.po | 2 +- misc/translator/po/hi-marc-UNIMARC.po | 2 +- misc/translator/po/hi-opac-bootstrap.po | 2 +- misc/translator/po/hi-staff-help.po | 2 +- misc/translator/po/hi-staff-prog.po | 2 +- misc/translator/po/hr-HR-marc-MARC21.po | 2 +- misc/translator/po/hr-HR-marc-NORMARC.po | 2 +- misc/translator/po/hr-HR-marc-UNIMARC.po | 2 +- misc/translator/po/hr-HR-opac-bootstrap.po | 2 +- misc/translator/po/hr-HR-staff-help.po | 2 +- misc/translator/po/hr-HR-staff-prog.po | 2 +- misc/translator/po/hu-HU-marc-MARC21.po | 2 +- misc/translator/po/hu-HU-marc-NORMARC.po | 2 +- misc/translator/po/hu-HU-marc-UNIMARC.po | 2 +- misc/translator/po/hu-HU-opac-bootstrap.po | 2 +- misc/translator/po/hu-HU-staff-help.po | 2 +- misc/translator/po/hu-HU-staff-prog.po | 2 +- misc/translator/po/hy-Armn-marc-MARC21.po | 2 +- misc/translator/po/hy-Armn-marc-NORMARC.po | 2 +- misc/translator/po/hy-Armn-marc-UNIMARC.po | 2 +- misc/translator/po/hy-Armn-opac-bootstrap.po | 2 +- misc/translator/po/hy-Armn-staff-help.po | 2 +- misc/translator/po/hy-Armn-staff-prog.po | 2 +- misc/translator/po/ia-marc-MARC21.po | 2 +- misc/translator/po/ia-marc-NORMARC.po | 2 +- misc/translator/po/ia-marc-UNIMARC.po | 2 +- misc/translator/po/ia-opac-bootstrap.po | 2 +- misc/translator/po/ia-staff-help.po | 2 +- misc/translator/po/ia-staff-prog.po | 2 +- misc/translator/po/id-ID-marc-MARC21.po | 2 +- misc/translator/po/id-ID-marc-NORMARC.po | 2 +- misc/translator/po/id-ID-marc-UNIMARC.po | 2 +- misc/translator/po/id-ID-opac-bootstrap.po | 2 +- misc/translator/po/id-ID-staff-help.po | 2 +- misc/translator/po/id-ID-staff-prog.po | 2 +- misc/translator/po/iq-CA-marc-MARC21.po | 2 +- misc/translator/po/iq-CA-marc-NORMARC.po | 2 +- misc/translator/po/iq-CA-marc-UNIMARC.po | 2 +- misc/translator/po/iq-CA-opac-bootstrap.po | 2 +- misc/translator/po/iq-CA-staff-help.po | 2 +- misc/translator/po/iq-CA-staff-prog.po | 2 +- misc/translator/po/is-IS-marc-MARC21.po | 2 +- misc/translator/po/is-IS-marc-NORMARC.po | 2 +- misc/translator/po/is-IS-marc-UNIMARC.po | 2 +- misc/translator/po/is-IS-opac-bootstrap.po | 2 +- misc/translator/po/is-IS-staff-help.po | 2 +- misc/translator/po/is-IS-staff-prog.po | 2 +- misc/translator/po/it-IT-marc-MARC21.po | 2 +- misc/translator/po/it-IT-marc-NORMARC.po | 2 +- misc/translator/po/it-IT-marc-UNIMARC.po | 2 +- misc/translator/po/it-IT-opac-bootstrap.po | 18 +- misc/translator/po/it-IT-pref.po | 15 +- misc/translator/po/it-IT-staff-help.po | 15 +- misc/translator/po/it-IT-staff-prog.po | 51 +- misc/translator/po/iu-CA-marc-MARC21.po | 2 +- misc/translator/po/iu-CA-marc-NORMARC.po | 2 +- misc/translator/po/iu-CA-marc-UNIMARC.po | 2 +- misc/translator/po/iu-CA-opac-bootstrap.po | 2 +- misc/translator/po/iu-CA-staff-help.po | 2 +- misc/translator/po/iu-CA-staff-prog.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-MARC21.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-NORMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-UNIMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-opac-bootstrap.po | 2 +- misc/translator/po/ja-Jpan-JP-staff-help.po | 2 +- misc/translator/po/ja-Jpan-JP-staff-prog.po | 2 +- misc/translator/po/ka-marc-MARC21.po | 2 +- misc/translator/po/ka-marc-NORMARC.po | 2 +- misc/translator/po/ka-marc-UNIMARC.po | 2 +- misc/translator/po/ka-opac-bootstrap.po | 2 +- misc/translator/po/ka-staff-help.po | 2 +- misc/translator/po/ka-staff-prog.po | 2 +- misc/translator/po/km-KH-marc-MARC21.po | 2 +- misc/translator/po/km-KH-marc-NORMARC.po | 2 +- misc/translator/po/km-KH-marc-UNIMARC.po | 2 +- misc/translator/po/km-KH-opac-bootstrap.po | 2 +- misc/translator/po/km-KH-staff-help.po | 2 +- misc/translator/po/km-KH-staff-prog.po | 2 +- misc/translator/po/kn-Knda-marc-MARC21.po | 2 +- misc/translator/po/kn-Knda-marc-NORMARC.po | 2 +- misc/translator/po/kn-Knda-marc-UNIMARC.po | 2 +- misc/translator/po/kn-Knda-opac-bootstrap.po | 2 +- misc/translator/po/kn-Knda-staff-help.po | 2 +- misc/translator/po/kn-Knda-staff-prog.po | 2 +- misc/translator/po/ko-Kore-KP-marc-MARC21.po | 2 +- misc/translator/po/ko-Kore-KP-marc-NORMARC.po | 2 +- misc/translator/po/ko-Kore-KP-marc-UNIMARC.po | 2 +- misc/translator/po/ko-Kore-KP-opac-bootstrap.po | 2 +- misc/translator/po/ko-Kore-KP-staff-help.po | 2 +- misc/translator/po/ko-Kore-KP-staff-prog.po | 2 +- misc/translator/po/ku-Arab-marc-MARC21.po | 2 +- misc/translator/po/ku-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ku-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ku-Arab-opac-bootstrap.po | 2 +- misc/translator/po/ku-Arab-staff-help.po | 2 +- misc/translator/po/ku-Arab-staff-prog.po | 2 +- misc/translator/po/lo-Laoo-marc-MARC21.po | 2 +- misc/translator/po/lo-Laoo-marc-NORMARC.po | 2 +- misc/translator/po/lo-Laoo-marc-UNIMARC.po | 2 +- misc/translator/po/lo-Laoo-opac-bootstrap.po | 2 +- misc/translator/po/lo-Laoo-staff-help.po | 2 +- misc/translator/po/lo-Laoo-staff-prog.po | 2 +- misc/translator/po/mi-NZ-marc-MARC21.po | 2 +- misc/translator/po/mi-NZ-marc-NORMARC.po | 2 +- misc/translator/po/mi-NZ-marc-UNIMARC.po | 2 +- misc/translator/po/mi-NZ-opac-bootstrap.po | 2 +- misc/translator/po/mi-NZ-staff-help.po | 2 +- misc/translator/po/mi-NZ-staff-prog.po | 2 +- misc/translator/po/ml-marc-MARC21.po | 2 +- misc/translator/po/ml-marc-NORMARC.po | 2 +- misc/translator/po/ml-marc-UNIMARC.po | 2 +- misc/translator/po/ml-opac-bootstrap.po | 2 +- misc/translator/po/ml-staff-help.po | 2 +- misc/translator/po/ml-staff-prog.po | 2 +- misc/translator/po/mon-marc-MARC21.po | 2 +- misc/translator/po/mon-marc-NORMARC.po | 2 +- misc/translator/po/mon-marc-UNIMARC.po | 2 +- misc/translator/po/mon-opac-bootstrap.po | 2 +- misc/translator/po/mon-staff-help.po | 2 +- misc/translator/po/mon-staff-prog.po | 2 +- misc/translator/po/mr-marc-MARC21.po | 2 +- misc/translator/po/mr-marc-NORMARC.po | 2 +- misc/translator/po/mr-marc-UNIMARC.po | 2 +- misc/translator/po/mr-opac-bootstrap.po | 2 +- misc/translator/po/mr-staff-help.po | 2 +- misc/translator/po/mr-staff-prog.po | 2 +- misc/translator/po/ms-MY-marc-MARC21.po | 2 +- misc/translator/po/ms-MY-marc-NORMARC.po | 2 +- misc/translator/po/ms-MY-marc-UNIMARC.po | 2 +- misc/translator/po/ms-MY-opac-bootstrap.po | 2 +- misc/translator/po/ms-MY-staff-help.po | 2 +- misc/translator/po/ms-MY-staff-prog.po | 2 +- misc/translator/po/my-marc-MARC21.po | 2 +- misc/translator/po/my-marc-NORMARC.po | 2 +- misc/translator/po/my-marc-UNIMARC.po | 2 +- misc/translator/po/my-opac-bootstrap.po | 2 +- misc/translator/po/my-staff-help.po | 2 +- misc/translator/po/my-staff-prog.po | 2 +- misc/translator/po/nb-NO-marc-MARC21.po | 2 +- misc/translator/po/nb-NO-marc-NORMARC.po | 2 +- misc/translator/po/nb-NO-marc-UNIMARC.po | 2 +- misc/translator/po/nb-NO-opac-bootstrap.po | 2 +- misc/translator/po/nb-NO-staff-help.po | 2 +- misc/translator/po/nb-NO-staff-prog.po | 2 +- misc/translator/po/ne-NE-marc-MARC21.po | 2 +- misc/translator/po/ne-NE-marc-NORMARC.po | 2 +- misc/translator/po/ne-NE-marc-UNIMARC.po | 2 +- misc/translator/po/ne-NE-opac-bootstrap.po | 2 +- misc/translator/po/ne-NE-staff-help.po | 2 +- misc/translator/po/ne-NE-staff-prog.po | 2 +- misc/translator/po/nl-BE-marc-MARC21.po | 2 +- misc/translator/po/nl-BE-marc-NORMARC.po | 2 +- misc/translator/po/nl-BE-marc-UNIMARC.po | 2 +- misc/translator/po/nl-BE-opac-bootstrap.po | 2 +- misc/translator/po/nl-BE-staff-help.po | 2 +- misc/translator/po/nl-BE-staff-prog.po | 2 +- misc/translator/po/nl-NL-marc-MARC21.po | 2 +- misc/translator/po/nl-NL-marc-NORMARC.po | 2 +- misc/translator/po/nl-NL-marc-UNIMARC.po | 2 +- misc/translator/po/nl-NL-opac-bootstrap.po | 2 +- misc/translator/po/nl-NL-staff-help.po | 2 +- misc/translator/po/nl-NL-staff-prog.po | 2 +- misc/translator/po/nn-NO-marc-MARC21.po | 2 +- misc/translator/po/nn-NO-marc-NORMARC.po | 2 +- misc/translator/po/nn-NO-marc-UNIMARC.po | 2 +- misc/translator/po/nn-NO-opac-bootstrap.po | 2 +- misc/translator/po/nn-NO-staff-help.po | 2 +- misc/translator/po/nn-NO-staff-prog.po | 2 +- misc/translator/po/oc-marc-MARC21.po | 2 +- misc/translator/po/oc-marc-NORMARC.po | 2 +- misc/translator/po/oc-marc-UNIMARC.po | 2 +- misc/translator/po/oc-opac-bootstrap.po | 2 +- misc/translator/po/oc-staff-help.po | 2 +- misc/translator/po/oc-staff-prog.po | 2 +- misc/translator/po/pbr-marc-MARC21.po | 2 +- misc/translator/po/pbr-marc-NORMARC.po | 2 +- misc/translator/po/pbr-marc-UNIMARC.po | 2 +- misc/translator/po/pbr-opac-bootstrap.po | 2 +- misc/translator/po/pbr-staff-help.po | 2 +- misc/translator/po/pbr-staff-prog.po | 2 +- misc/translator/po/pl-PL-marc-MARC21.po | 2 +- misc/translator/po/pl-PL-marc-NORMARC.po | 2 +- misc/translator/po/pl-PL-marc-UNIMARC.po | 2 +- misc/translator/po/pl-PL-opac-bootstrap.po | 8 +- misc/translator/po/pl-PL-staff-help.po | 8 +- misc/translator/po/pl-PL-staff-prog.po | 37 +- misc/translator/po/prs-marc-MARC21.po | 2 +- misc/translator/po/prs-marc-NORMARC.po | 2 +- misc/translator/po/prs-marc-UNIMARC.po | 2 +- misc/translator/po/prs-opac-bootstrap.po | 2 +- misc/translator/po/prs-staff-help.po | 2 +- misc/translator/po/prs-staff-prog.po | 2 +- misc/translator/po/pt-BR-marc-MARC21.po | 2 +- misc/translator/po/pt-BR-marc-NORMARC.po | 2 +- misc/translator/po/pt-BR-marc-UNIMARC.po | 2 +- misc/translator/po/pt-BR-opac-bootstrap.po | 2 +- misc/translator/po/pt-BR-staff-help.po | 2 +- misc/translator/po/pt-BR-staff-prog.po | 2 +- misc/translator/po/pt-PT-marc-MARC21.po | 10 +- misc/translator/po/pt-PT-marc-NORMARC.po | 2 +- misc/translator/po/pt-PT-marc-UNIMARC.po | 2 +- misc/translator/po/pt-PT-opac-bootstrap.po | 10 +- misc/translator/po/pt-PT-pref.po | 33 +- misc/translator/po/pt-PT-staff-help.po | 8 +- misc/translator/po/pt-PT-staff-prog.po | 104 +-- misc/translator/po/ro-RO-marc-MARC21.po | 72 +- misc/translator/po/ro-RO-marc-NORMARC.po | 67 +- misc/translator/po/ro-RO-marc-UNIMARC.po | 193 ++--- misc/translator/po/ro-RO-opac-bootstrap.po | 202 +++--- misc/translator/po/ro-RO-pref.po | 54 +- misc/translator/po/ro-RO-staff-help.po | 2 +- misc/translator/po/ro-RO-staff-prog.po | 114 +-- misc/translator/po/ru-RU-marc-MARC21.po | 2 +- misc/translator/po/ru-RU-marc-NORMARC.po | 2 +- misc/translator/po/ru-RU-marc-UNIMARC.po | 2 +- misc/translator/po/ru-RU-opac-bootstrap.po | 2 +- misc/translator/po/ru-RU-staff-help.po | 2 +- misc/translator/po/ru-RU-staff-prog.po | 2 +- misc/translator/po/rw-RW-marc-MARC21.po | 2 +- misc/translator/po/rw-RW-marc-NORMARC.po | 2 +- misc/translator/po/rw-RW-marc-UNIMARC.po | 2 +- misc/translator/po/rw-RW-opac-bootstrap.po | 2 +- misc/translator/po/rw-RW-staff-help.po | 2 +- misc/translator/po/rw-RW-staff-prog.po | 2 +- misc/translator/po/sd-PK-marc-MARC21.po | 2 +- misc/translator/po/sd-PK-marc-NORMARC.po | 2 +- misc/translator/po/sd-PK-marc-UNIMARC.po | 2 +- misc/translator/po/sd-PK-opac-bootstrap.po | 2 +- misc/translator/po/sd-PK-staff-help.po | 2 +- misc/translator/po/sd-PK-staff-prog.po | 2 +- misc/translator/po/sk-SK-marc-MARC21.po | 2 +- misc/translator/po/sk-SK-marc-NORMARC.po | 2 +- misc/translator/po/sk-SK-marc-UNIMARC.po | 2 +- misc/translator/po/sk-SK-opac-bootstrap.po | 2 +- misc/translator/po/sk-SK-staff-help.po | 2 +- misc/translator/po/sk-SK-staff-prog.po | 2 +- misc/translator/po/sl-SI-marc-MARC21.po | 2 +- misc/translator/po/sl-SI-marc-NORMARC.po | 2 +- misc/translator/po/sl-SI-marc-UNIMARC.po | 2 +- misc/translator/po/sl-SI-opac-bootstrap.po | 2 +- misc/translator/po/sl-SI-staff-help.po | 2 +- misc/translator/po/sl-SI-staff-prog.po | 2 +- misc/translator/po/sq-AL-marc-MARC21.po | 2 +- misc/translator/po/sq-AL-marc-NORMARC.po | 2 +- misc/translator/po/sq-AL-marc-UNIMARC.po | 2 +- misc/translator/po/sq-AL-opac-bootstrap.po | 2 +- misc/translator/po/sq-AL-staff-help.po | 2 +- misc/translator/po/sq-AL-staff-prog.po | 2 +- misc/translator/po/sr-Cyrl-marc-MARC21.po | 2 +- misc/translator/po/sr-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/sr-Cyrl-marc-UNIMARC.po | 2 +- misc/translator/po/sr-Cyrl-opac-bootstrap.po | 2 +- misc/translator/po/sr-Cyrl-staff-help.po | 2 +- misc/translator/po/sr-Cyrl-staff-prog.po | 2 +- misc/translator/po/sv-SE-marc-MARC21.po | 2 +- misc/translator/po/sv-SE-marc-NORMARC.po | 2 +- misc/translator/po/sv-SE-marc-UNIMARC.po | 2 +- misc/translator/po/sv-SE-opac-bootstrap.po | 2 +- misc/translator/po/sv-SE-staff-help.po | 2 +- misc/translator/po/sv-SE-staff-prog.po | 2 +- misc/translator/po/sw-KE-marc-MARC21.po | 2 +- misc/translator/po/sw-KE-marc-NORMARC.po | 2 +- misc/translator/po/sw-KE-marc-UNIMARC.po | 2 +- misc/translator/po/sw-KE-opac-bootstrap.po | 2 +- misc/translator/po/sw-KE-staff-help.po | 2 +- misc/translator/po/sw-KE-staff-prog.po | 2 +- misc/translator/po/ta-LK-marc-MARC21.po | 2 +- misc/translator/po/ta-LK-marc-NORMARC.po | 2 +- misc/translator/po/ta-LK-marc-UNIMARC.po | 2 +- misc/translator/po/ta-LK-opac-bootstrap.po | 2 +- misc/translator/po/ta-LK-staff-help.po | 2 +- misc/translator/po/ta-LK-staff-prog.po | 2 +- misc/translator/po/ta-marc-MARC21.po | 2 +- misc/translator/po/ta-marc-NORMARC.po | 2 +- misc/translator/po/ta-marc-UNIMARC.po | 2 +- misc/translator/po/ta-opac-bootstrap.po | 2 +- misc/translator/po/ta-staff-help.po | 2 +- misc/translator/po/ta-staff-prog.po | 2 +- misc/translator/po/tet-marc-MARC21.po | 2 +- misc/translator/po/tet-marc-NORMARC.po | 2 +- misc/translator/po/tet-marc-UNIMARC.po | 2 +- misc/translator/po/tet-opac-bootstrap.po | 2 +- misc/translator/po/tet-staff-help.po | 2 +- misc/translator/po/tet-staff-prog.po | 536 +++++++------- misc/translator/po/th-TH-marc-MARC21.po | 2 +- misc/translator/po/th-TH-marc-NORMARC.po | 2 +- misc/translator/po/th-TH-marc-UNIMARC.po | 2 +- misc/translator/po/th-TH-opac-bootstrap.po | 2 +- misc/translator/po/th-TH-staff-help.po | 2 +- misc/translator/po/th-TH-staff-prog.po | 2 +- misc/translator/po/tl-PH-marc-MARC21.po | 2 +- misc/translator/po/tl-PH-marc-NORMARC.po | 2 +- misc/translator/po/tl-PH-marc-UNIMARC.po | 2 +- misc/translator/po/tl-PH-opac-bootstrap.po | 2 +- misc/translator/po/tl-PH-staff-help.po | 2 +- misc/translator/po/tl-PH-staff-prog.po | 2 +- misc/translator/po/tr-TR-marc-MARC21.po | 2 +- misc/translator/po/tr-TR-marc-NORMARC.po | 2 +- misc/translator/po/tr-TR-marc-UNIMARC.po | 2 +- misc/translator/po/tr-TR-opac-bootstrap.po | 12 +- misc/translator/po/tr-TR-staff-help.po | 8 +- misc/translator/po/tr-TR-staff-prog.po | 52 +- misc/translator/po/uk-UA-marc-MARC21.po | 2 +- misc/translator/po/uk-UA-marc-NORMARC.po | 2 +- misc/translator/po/uk-UA-marc-UNIMARC.po | 2 +- misc/translator/po/uk-UA-opac-bootstrap.po | 2 +- misc/translator/po/uk-UA-pref.po | 14 +- misc/translator/po/uk-UA-staff-help.po | 2 +- misc/translator/po/uk-UA-staff-prog.po | 2 +- misc/translator/po/ur-Arab-marc-MARC21.po | 2 +- misc/translator/po/ur-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ur-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ur-Arab-opac-bootstrap.po | 2 +- misc/translator/po/ur-Arab-staff-help.po | 2 +- misc/translator/po/ur-Arab-staff-prog.po | 2 +- misc/translator/po/vi-VN-marc-MARC21.po | 2 +- misc/translator/po/vi-VN-marc-NORMARC.po | 2 +- misc/translator/po/vi-VN-marc-UNIMARC.po | 2 +- misc/translator/po/vi-VN-opac-bootstrap.po | 2 +- misc/translator/po/vi-VN-staff-help.po | 2 +- misc/translator/po/vi-VN-staff-prog.po | 2 +- misc/translator/po/zh-Hans-CN-marc-MARC21.po | 2 +- misc/translator/po/zh-Hans-CN-marc-NORMARC.po | 2 +- misc/translator/po/zh-Hans-CN-marc-UNIMARC.po | 2 +- misc/translator/po/zh-Hans-CN-opac-bootstrap.po | 2 +- misc/translator/po/zh-Hans-CN-staff-help.po | 2 +- misc/translator/po/zh-Hans-CN-staff-prog.po | 2 +- misc/translator/po/zh-Hans-TW-marc-MARC21.po | 2 +- misc/translator/po/zh-Hans-TW-marc-NORMARC.po | 2 +- misc/translator/po/zh-Hans-TW-marc-UNIMARC.po | 2 +- misc/translator/po/zh-Hans-TW-opac-bootstrap.po | 8 +- misc/translator/po/zh-Hans-TW-staff-help.po | 8 +- misc/translator/po/zh-Hans-TW-staff-prog.po | 39 +- 497 files changed, 2528 insertions(+), 2185 deletions(-) copy misc/release_notes/{release_notes_16_11_05.html => release_notes_16_11_06.html} (69%) copy misc/release_notes/{release_notes_16_11_03.md => release_notes_16_11_06.md} (63%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 29 15:09:39 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 29 Mar 2017 13:09:39 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-644-g1a53b49 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 1a53b49980e913c55c6f2021d21b6aa99ac8cefd (commit) from 3db855b872ccbf133e238ddc537b6f0b818c931e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1a53b49980e913c55c6f2021d21b6aa99ac8cefd Author: Mark Tompsett Date: Mon Feb 20 01:37:49 2017 -0500 Bug 18144: Restore pieces of C4/Auth to make Google OpenID Connect work By restoring some pieces of logic, with the name changed from $persona to $emailaddress, the openid will work again for OPAC logins. See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988#c68 for an excellent test plan. Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart Did not test it, but trust in author and signoffer Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 27 ++++++++++++++++++++++++++- 1 file changed, 26 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 29 15:10:41 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 29 Mar 2017 13:10:41 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-645-g8dad158 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 8dad1582c100017f8ad3e331c9a9b9cc9ed4e4d6 (commit) from 1a53b49980e913c55c6f2021d21b6aa99ac8cefd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8dad1582c100017f8ad3e331c9a9b9cc9ed4e4d6 Author: Jonathan Druart Date: Tue Mar 21 10:52:42 2017 -0300 Bug 18312: Fix export unless a file is supplied Bug 18087 breaks export unless a file is supplied. Can't use an undefined value as a HASH reference at /home/vagrant/kohaclone/tools/export.pl line 75. Test plan: Export records using a file of id that is not a valid file (not txt or csv) Export records using a valid file Export records without supplying a file => The export should work or fail as expected. Signed-off-by: Jesse Maseto Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: tools/export.pl | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 30 11:47:56 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 30 Mar 2017 09:47:56 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-648-g574d483 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 574d48362d32c14920712ae35bdd28101785315c (commit) via 7190593d9dd38001c2d101bcad5cddc222a45ebe (commit) via 3562816dd1b8855c7973ce5650ff834407c1a548 (commit) from 8dad1582c100017f8ad3e331c9a9b9cc9ed4e4d6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 574d48362d32c14920712ae35bdd28101785315c Author: Jonathan Druart Date: Wed Feb 15 17:14:13 2017 +0100 Bug 18124: Change the calls to generate and check CSRF tokens The parameter change in Koha::Token should be applied to the calling scripts. Test plan: Confirm that the different forms of the scripts modified by this patch still work correctly. Test the problematic behavior: Open 2 tabs with in same user's session, go on the edit patron page (memberentry.pl). Log out and log in from the other tab. Submit the form => Wrong CSRF token should be raised Signed-off-by: Marcel de Rooy Signed-off-by: Julian Maurice Signed-off-by: Kyle M Hall commit 7190593d9dd38001c2d101bcad5cddc222a45ebe Author: Marcel de Rooy Date: Thu Feb 16 11:59:12 2017 +0100 Bug 18124: [Follow-up] Handle default parameters in a sub Adds a internal routine to handle default values for the parameters id and secret. Also adds a parameter session_id for generate_csrf and check_csrf. This session parameter is combined with the id parameter when generating or checking a token. Test plan: Run t/Token.t Signed-off-by: Marcel de Rooy Signed-off-by: Julian Maurice Signed-off-by: Kyle M Hall commit 3562816dd1b8855c7973ce5650ff834407c1a548 Author: Jonathan Druart Date: Wed Feb 15 17:14:13 2017 +0100 Bug 18124: Restrict CSRF token to user's session Currently the CSRF token generated is based on the borrowernumber, and is valid across user's session. We need to restrict the CSRF token to the current session. With this patch the CSRF token is generated concatenating the id (borrowernumber) and the CGISESSID cookie. Test plan: Run t/Token.t Signed-off-by: Marcel de Rooy Signed-off-by: Julian Maurice Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/Token.pm | 35 ++++++++++++++++++++++++++++----- basket/sendbasket.pl | 10 ++-------- members/deletemem.pl | 13 +++--------- members/member-flags.pl | 11 ++--------- members/member-password.pl | 11 ++--------- members/memberentry.pl | 13 +++--------- members/moremember.pl | 7 +------ opac/opac-memberentry.pl | 13 ++++-------- opac/opac-sendbasket.pl | 11 +++-------- t/Token.t | 47 +++++++++++++++++++++++++++++++++++++------- tools/import_borrowers.pl | 9 ++------- tools/picture-upload.pl | 11 +++-------- 12 files changed, 95 insertions(+), 96 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 12:45:09 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 10:45:09 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-649-gead7d86 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ead7d86842d76e4619ebf7a4d9fa28998bad3442 (commit) from 574d48362d32c14920712ae35bdd28101785315c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ead7d86842d76e4619ebf7a4d9fa28998bad3442 Author: Jonathan Druart Date: Tue Mar 21 12:24:28 2017 -0300 Bug 18266: Fix internal error when paying fine for lost item without.. item If a fine is created for a lost item but the itemnumber is not supplied, the system will return it. The item should not be mark as returned if there is no item linked to the fine. Test plan: 1. Turn StoreLastBorrower on 2. Create a manual invoice for a lost item, do not supply a barcode 3. Pay the fines 'Pay fines > Pay' => Without this patch applied you get Can't call method "last_returned_by" on an undefined value at /home/marc/koha/C4/Circulation.pm line 2188. => With this patch applied, you must not get the error. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/Account.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 12:47:40 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 10:47:40 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-650-gdd88c8f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via dd88c8f710e4915dac6437355c356f0632b776fb (commit) from ead7d86842d76e4619ebf7a4d9fa28998bad3442 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit dd88c8f710e4915dac6437355c356f0632b776fb Author: Jonathan Druart Date: Tue Feb 14 14:39:48 2017 +0000 Bug 18058: Allow borrower_message_preferences to be truncated borrower_message_preferences cannot be truncated because of the foreign. DBMS fails with "Cannot truncate a table referenced in a foreign key constraint" To avoid that we should remove the FK check and truncate the other table as well. I am wondering if we really need a truncate here DELETE FROM borrower_message_preferences; should do the job, but leave it as it because of the param name. Test plan perl misc/maintenance/borrowers-force-messaging-defaults --doit --truncate Should no longer raise the error message Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: misc/maintenance/borrowers-force-messaging-defaults | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 12:48:50 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 10:48:50 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-651-gff4958c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ff4958c80656fcca5c31cb291cef2c3866c86b23 (commit) from dd88c8f710e4915dac6437355c356f0632b776fb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ff4958c80656fcca5c31cb291cef2c3866c86b23 Author: Jonathan Druart Date: Wed Mar 15 09:30:19 2017 -0300 Bug 18270: Do not fetch the MARC record when deleting an item $record is never used later, the call is superfluous. Test plan: Quick glance at the code should be enough Signed-off-by: Marc V?ron Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Items.pm | 2 -- 1 file changed, 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 12:49:40 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 10:49:40 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-653-g6a6a71b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6a6a71b9d8145fe11e4a01260b50a86b1e2b5c42 (commit) via 5651755e68a7c41d1646fa06e1d96b7bf32de5da (commit) from ff4958c80656fcca5c31cb291cef2c3866c86b23 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6a6a71b9d8145fe11e4a01260b50a86b1e2b5c42 Author: Tomas Cohen Arazi Date: Wed Mar 29 14:50:22 2017 -0300 Bug 18258: (QA followup) Use Koha::Subscriptions Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall commit 5651755e68a7c41d1646fa06e1d96b7bf32de5da Author: Jonathan Druart Date: Mon Mar 13 15:27:06 2017 -0300 Bug 18258: Add the Koha::Biblio->subscriptions method Test plan: prove t/db_dependent/Koha/Biblios.t should return green Signed-off-by: Marc V?ron Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/Biblio.pm | 18 ++++++++++++++++++ t/db_dependent/Koha/Biblios.t | 19 ++++++++++++++++++- 2 files changed, 36 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 12:51:46 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 10:51:46 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-655-gd420e6a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d420e6ae210294884430d294e6cd97e4cc179fa8 (commit) via 4cc79c77c904e9a8e5ff35ca872b7673b3c005c9 (commit) from 6a6a71b9d8145fe11e4a01260b50a86b1e2b5c42 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d420e6ae210294884430d294e6cd97e4cc179fa8 Author: Jonathan Druart Date: Wed Jan 4 11:38:34 2017 +0100 Bug 17844: Replace C4::Koha::get_notforloan_label_of with Koha::AuthorisedValues This patch is more a bugfix than a refactoring. Indeed the C4::Koha::get_notforloan_label_of behaviors were buggy: 1/ It does not display the opac description at the OPAC, but always the staff description 2/ It does not care of the framework of the biblio, but retrieve the first row of the marc_subfield_structure mapped with items.notforloan These 2 bugs can easily be fixed using the Koha::AuthorisedValues->search_by_koha_field Steps to recreate the issues: - Create 2 authorised value categories for not for loan (NFL1 and NFL2) with the same values. Define a different description for the OPAC. - Define link 952$7 to NFL1 for the default framework and to NFL2 for the BK framework - Create 2 bibliographic records (B1 using NFL1 and B2 using NFL2) with 2 items each (1 item should have a not for loan value) - Go to the "Place a hold" view for this record. - In the item list, you should see the not for loan value => The staff description of NFL1 will always be used, even for the OPAC Test plan: - Recreate the issues without this patchset - Apply this patchset - Recreate the steps to recreate the issues => The staff description of NFL2 should be displayed for the B2 item => The opac description of NFL2 should be displayed for the B2 item at the OPAC Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 4cc79c77c904e9a8e5ff35ca872b7673b3c005c9 Author: Jonathan Druart Date: Wed Jan 4 11:53:33 2017 +0100 Bug 17844: Remove C4::Koha::get_notforloan_label_of Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Koha.pm | 53 -------------------------------------------------- opac/opac-reserve.pl | 8 ++++++-- reserve/request.pl | 6 ++++-- 3 files changed, 10 insertions(+), 57 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 12:53:15 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 10:53:15 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-657-gc8c52ba Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via c8c52ba72e90656304e85f2958f3f6f5ff0f3487 (commit) via 7dad38e88f9440ca42ec95fc0daf26521e3a5f28 (commit) from d420e6ae210294884430d294e6cd97e4cc179fa8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c8c52ba72e90656304e85f2958f3f6f5ff0f3487 Author: Jonathan Druart Date: Wed Jan 4 15:41:22 2017 +0100 Bug 17847: Remove C4::Koha::GetAuthvalueDropbox Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 7dad38e88f9440ca42ec95fc0daf26521e3a5f28 Author: Jonathan Druart Date: Wed Jan 4 13:43:27 2017 +0100 Bug 17847: Replace C4::Koha::GetAuthvalueDropbox with Koha::AuthorisedValues The C4::Koha::GetAuthvalueDropbox subroutine does the same job as Koha::AuthorisedValues->search We should then replace the different calls to this subroutine to finally remove it. There were 2 calls to this subroutine: - from the AuthorisedValues TT plugin (called from av-build-dropbox.inc and members/housebound.tt) - from the acqui/ajax-getauthvaluedropbox.pl ajax script To make sure that this patchset does not introduce regressions, we will have to test that the TT plugin and the ajax script still behave as before. Test plan: 1/ Test acqui/ajax-getauthvaluedropbox.pl - Link a fund to an authorised value category - Create a new order => When you select a fund linked to AV category, the sort1 (and/or sort2, depending on what you set) should be replaced with a dropdown list populated with the authorised values 2/ Test av-build-dropbox.inc - Create some authorised values for Bsort1 - Edit a patron => The sort1 should be a dropdown list populated with the Bsort1 AV 3/ Test members/housebound.tt - Enable the housebound module (pref HouseboundModule) - On the patron detail page, click on the "Housebound" tab => The frequency dropdown list should be populated with the different HSBND_FREQ AV Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Koha.pm | 38 -------------------- Koha/Template/Plugin/AuthorisedValues.pm | 14 ++++++-- acqui/ajax-getauthvaluedropbox.pl | 28 ++++++++++----- .../prog/en/includes/av-build-dropbox.inc | 8 ++--- .../prog/en/modules/members/housebound.tt | 6 ++-- 5 files changed, 38 insertions(+), 56 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 12:54:15 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 10:54:15 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-661-g66d322d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 66d322d9199782135895e7478b515c5c0eb8b9a9 (commit) via 66584e46bd183aa0a2eeaf6e66d62f3d43461539 (commit) via d09096abaeca2e484839a4ba2cfcb31d603f23dc (commit) via 7a5709906bd53a44500e71ce169c67244e6e2e3f (commit) from c8c52ba72e90656304e85f2958f3f6f5ff0f3487 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 66d322d9199782135895e7478b515c5c0eb8b9a9 Author: Jonathan Druart Date: Mon Dec 12 16:03:01 2016 +0100 Bug 14146: Add the new pref CumulativeRestrictionPeriods Sponsored-by: Orex Digital Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 66584e46bd183aa0a2eeaf6e66d62f3d43461539 Author: Jonathan Druart Date: Mon Dec 12 16:04:07 2016 +0100 Bug 14146: Clean a bit and make the code understandable The code was a bit weird and this patch cleans it a bit by renaming variables and adding a variable. Sponsored-by: Orex Digital Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit d09096abaeca2e484839a4ba2cfcb31d603f23dc Author: Jonathan Druart Date: Wed Nov 30 19:33:44 2016 +0000 Bug 14146: Add the ability to cumulate restriction periods At the moment the default behaviour is not to cumulate the restriction periods but to apply the longest one. This patch set creates a new syspref CumulativeRestrictionPeriods. If on, the behaviour changes and the restriction periods are cumulated: the days of the second restriction are added to the actual restriction period. We could add a new circulation rule instead of a syspref, but I am not sure it's very useful to have such granularity for this behaviour (can be changed if needed). How it works: Let's take 2 items, A and B. A is returned with Na days late, and B Nb days late The grace period is Ng and there is 1 day of suspension charge per day of overdue The suspension period is until day D = Na - Ng + Nb - Ng I would have expected D = Na + Nb - Ng but it's how it worked before this patch. Test plan: Create several overdue for a given patron Do the checkins and confirm that the period are added if the pref is on. If the pref is off, you should not get any changes in the existing behaviour. Sponsored-by: Orex Digital Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 7a5709906bd53a44500e71ce169c67244e6e2e3f Author: Jonathan Druart Date: Mon Dec 12 16:04:42 2016 +0100 Bug 14146: Add tests for AddReturn + CumulativeRestrictionPeriods Sponsored-by: Orex Digital Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 26 +++- installer/data/mysql/atomicupdate/bug_14146.sql | 2 + installer/data/mysql/sysprefs.sql | 1 + .../en/modules/admin/preferences/circulation.pref | 6 + t/db_dependent/Circulation.t | 128 ++++++++++++++++++++ 5 files changed, 157 insertions(+), 6 deletions(-) create mode 100644 installer/data/mysql/atomicupdate/bug_14146.sql hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 12:59:14 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 10:59:14 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-662-gb7adcf6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b7adcf69476a969cda6b8670e8a7e91f4c4af5b2 (commit) from 66d322d9199782135895e7478b515c5c0eb8b9a9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b7adcf69476a969cda6b8670e8a7e91f4c4af5b2 Author: Kyle M Hall Date: Fri Mar 31 10:18:35 2017 +0000 Bug 14146 - DBRev 16.12.00.017 Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/atomicupdate/bug_14146.sql | 2 -- installer/data/mysql/updatedatabase.pl | 13 ++++++++++++- 3 files changed, 13 insertions(+), 4 deletions(-) delete mode 100644 installer/data/mysql/atomicupdate/bug_14146.sql hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 13:00:37 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 11:00:37 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-664-gafe3fa1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via afe3fa1d071aae2078cd3c52ad1b7e242ddcf3ef (commit) via 73c83b51c2041bd7eb3653f6395d907f4b51eff1 (commit) from b7adcf69476a969cda6b8670e8a7e91f4c4af5b2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit afe3fa1d071aae2078cd3c52ad1b7e242ddcf3ef Author: Jonathan Druart Date: Mon Mar 13 18:17:13 2017 -0300 Bug 18269: Move field mappings related code to Koha::FieldMapping[s] The 3 subroutines GetFieldMapping, SetFieldMapping and DeleteFieldMapping from the C4::Biblio module were only used from the field mappings admin page. They can easily replaced with new packages Koha::FieldMappings based on Koha::Object[s] Test plan: Add and delete field mappings (admin/fieldmapping.pl, Home ? Administration ? Keyword to MARC mapping). Add an existing mapping > Nothing should be added Note that this page has not been rewritten and you will not get any feedbacks, but it's not the goal of this page to improve it. Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit 73c83b51c2041bd7eb3653f6395d907f4b51eff1 Author: Jonathan Druart Date: Tue Mar 14 18:10:08 2017 -0300 Bug 18269: Add Koha::FieldMapping[s] packages Tested both patches together, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Biblio.pm | 63 -------------------- Koha/{City.pm => FieldMapping.pm} | 6 +- Koha/{ItemTypes.pm => FieldMappings.pm} | 10 ++-- admin/fieldmapping.pl | 46 +++++++------- .../prog/en/modules/admin/fieldmapping.tt | 11 ++-- t/db_dependent/Charset.t | 2 +- 6 files changed, 39 insertions(+), 99 deletions(-) copy Koha/{City.pm => FieldMapping.pm} (89%) copy Koha/{ItemTypes.pm => FieldMappings.pm} (84%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 13:01:12 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 11:01:12 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-665-g95e6f6a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 95e6f6a612013bedbb26054295b3336008466aed (commit) from afe3fa1d071aae2078cd3c52ad1b7e242ddcf3ef (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 95e6f6a612013bedbb26054295b3336008466aed Author: Jonathan Druart Date: Mon Jan 16 14:46:12 2017 +0100 Bug 17963: TT syntax for notices - Prove that AR_* are compatible Nothing new here since bug 17962, the AR_* notice messages are quite simple. They send the article_request, patron, biblio, biblioitem, item and library linked to the article request. All the fields from these 6 tables should still be accessible using the TT syntax. Test plan: Define TT notice templates for AR_PENDING, AR_PROCESSING, AR_COMPLETED or AR_CANCELED. You should manage to create a template to generate the same result as the historical syntax. Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Letters.pm | 6 ++++ Koha/ArticleRequest.pm | 2 +- t/db_dependent/Letters/TemplateToolkit.t | 55 +++++++++++++++++++++++++++++- 3 files changed, 61 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 13:45:11 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 11:45:11 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.18-1-gd84f150 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via d84f150e88509e77929eb9f4fbd4237262bf361d (commit) from 2effbe144aa2cfed98ca5e615042925faa81465c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d84f150e88509e77929eb9f4fbd4237262bf361d Author: Marc V?ron Date: Sat Mar 11 17:18:10 2017 +0100 Bug 8603: Patron card creator - 'Barcode Type' doesn't stick in layouts To reproduce: 1. Make a new layout 2. Tick "Print card number as barcode" 3. Change 'Barcode Type' to anything other than Code39 4. Save 5. Edit it again 6. Its back to Code39 To test: 1. Apply patch 2. Repeat steps above 3. Verify that 'Barcode type' is selected as expected Signed-off-by: Nick Clemens https://bugs.koha-community.org/show_bug.cgi?id=18063 https://bugs.koha-community.org/show_bug.cgi?id=8063 Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy Signed-off-by: Brendan A Gallagher (cherry picked from commit 20ad341eefc555e0cf2b0f2862347e8a48b28935) Signed-off-by: Katrin Fischer (cherry picked from commit 34a91f6e3d7da38aafb37a57a962c1d852f9101a) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: patroncards/edit-layout.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 13:51:34 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 11:51:34 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-667-gd3cb1b0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d3cb1b0ab33b7070924611fd33e3a1aa3c34aab9 (commit) via 52d5519743b2108cd01fcce9b9786a3e461f8e76 (commit) from 95e6f6a612013bedbb26054295b3336008466aed (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d3cb1b0ab33b7070924611fd33e3a1aa3c34aab9 Author: Jonathan Druart Date: Sat Jan 21 14:13:49 2017 +0100 Bug 17970: Fix GetPreparedLetter behavior if nothing to substitute From C4::Letters::GetPreparedLetter: my $tables = $params{tables}; my $substitute = $params{substitute}; $tables || $substitute || $repeat or carp( "ERROR: nothing to substitute - both 'tables' and 'substitute' are empty" ), return; So if the parameter tables or substitute is passed but does not contain anything, it will not warn as expected. Test plan: 1/ Apply the patch with tests 2/ Confirm that they do not pass 3/ Apply this patch 4/ Confirm that the tests now pass Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 52d5519743b2108cd01fcce9b9786a3e461f8e76 Author: Jonathan Druart Date: Sat Jan 21 14:13:36 2017 +0100 Bug 17970: Add tests to highlight the problem Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Letters.pm | 10 +++++----- t/db_dependent/Letters.t | 41 ++++++++++++++++++++++++++++++++++++++++- 2 files changed, 45 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 13:53:26 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 11:53:26 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-670-g83a7ab2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 83a7ab21f320b7f7cfe8b3b6b1ab8f6895fe8180 (commit) via 77b72decd41bcdcd642cb9d3f32f86611dcf1566 (commit) via 3ee3cf10e61aaad8a47881fdc6cc565e74c847af (commit) from d3cb1b0ab33b7070924611fd33e3a1aa3c34aab9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 83a7ab21f320b7f7cfe8b3b6b1ab8f6895fe8180 Author: Nick Clemens Date: Wed Mar 29 16:10:52 2017 -0400 Bug 17971 (QA Followup) Clarify comment Signed-off-by: Kyle M Hall commit 77b72decd41bcdcd642cb9d3f32f86611dcf1566 Author: Jonathan Druart Date: Tue Jan 17 16:18:54 2017 +0100 Bug 17971: Add support for objects represented by fk For instance an issue is not fetch from its fk but using the fk itemnumber. We need to support them. Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall commit 3ee3cf10e61aaad8a47881fdc6cc565e74c847af Author: Jonathan Druart Date: Sat Jan 21 14:26:27 2017 +0100 Bug 17971: TT syntax for notices - Add support for plurals On of the awesome things we will be able to do with the TT syntax is the support of plurals. For instance we will be able to send a list of items, checkouts, etc. to the notice template. That way we will get rid of our custom syntax like <> or for instance. The existing code already has the playground for that but it is not used. Basically the idea is to add a "loops" key which can contain a list of object to retrieve from the DB and send to the template. For instance: loops => { overdues => [ $itemnumber_1, .., $itemnumber_N ] } will send a variable "overdues" to the template. It will contain the Koha::Checkout objects relative to the id passed. There is one quite big inconvenient to this approach so far: since we are still supporting the historical syntax, the objects can be fetch by a script, then the script will send the id to GetPreparedLetter which will refetch them. This must be improved, but I suggest to do that later. Test plan: prove t/db_dependent/Letters/TemplateToolkit.t should return green Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Letters.pm | 23 +++++++++++++++----- t/db_dependent/Letters/TemplateToolkit.t | 35 +++++++++++++++++++++++++++++- 2 files changed, 52 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 13:54:27 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 11:54:27 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-676-g2b0b5d6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2b0b5d68de77f977e894dc69a379b1c8f4034eea (commit) via 1901af692a97a81daed2c1c6f48232ef862172ef (commit) via b7735ed1281e959c3df34581e13e4276e53fd8a3 (commit) via d4c3bbb597f19b5dbdf75227dbd67923bb832d85 (commit) via 4fc3ccf61d04f8b04e2dac0527130fe074f863e3 (commit) via b0dc5fc0f32a26c24b6e9da91da6ab2ffda0e2c2 (commit) from 83a7ab21f320b7f7cfe8b3b6b1ab8f6895fe8180 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2b0b5d68de77f977e894dc69a379b1c8f4034eea Author: Marcel de Rooy Date: Fri Feb 17 08:10:43 2017 +0100 Bug 15498: [QA Follow-up] Additional changes Adds ExportRemoveFields to sysprefs.sql Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 1901af692a97a81daed2c1c6f48232ef862172ef Author: Jonathan Druart Date: Fri Feb 17 10:13:32 2017 +0000 Bug 15498: Fix conflict with bug 17394 Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit b7735ed1281e959c3df34581e13e4276e53fd8a3 Author: Jonathan Druart Date: Wed Nov 2 10:31:43 2016 +0000 Bug 15498: Fix show/hide csv profile list Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit d4c3bbb597f19b5dbdf75227dbd67923bb832d85 Author: Jonathan Druart Date: Wed Nov 2 08:42:11 2016 +0000 Bug 15498: Do not display sql csv profiles Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 4fc3ccf61d04f8b04e2dac0527130fe074f863e3 Author: Jonathan Druart Date: Wed Jan 6 16:36:54 2016 +0000 Bug 15498: Add ExportCircHistory and remove ExportWithCsvProfile Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit b0dc5fc0f32a26c24b6e9da91da6ab2ffda0e2c2 Author: Jonathan Druart Date: Wed Nov 2 08:28:01 2016 +0000 Bug 15498: Let the user choose the CSV profile to export circ history The way the export options are displayed at the bottom of the checkouts table was not consistent. Prior to this patch set, they are display if ExportRemoveFields or ExportWithCsvProfile is set. It does not make any sense, the user could want to export the checkouts in iso2709 format without having to define a csv profile and fill the pref. Moreover the behavior of this pref did not match its description: it's used as a default CSV profile when exporting records from the export tools or the command line. This patch set adds a new pref ExportCircHistory and remove ExportWithCsvProfile. The new pref is set if ExportWithCsvProfile or ExportRemoveFields were set. A new dropdown list with the CSV profile list will be displayed in the export area, at the bottom of the checkouts table. Note that now --csv_profile_id is mandatory for the export command line (misc/export_records.pl) if the export format is csv. Test plan: 0/ Do not execute the DB entry 1/ Clear both ExportWithCsvProfile and ExportRemoveFields prefs 2/ Execute the DB entry 3/ ExportCircHistory should not be set and the export options should not be displayed at the bottom of the checkouts table. 4/ Remove the pref DELETE FROM systempreferences WHERE variable='ExportCircHistory'; and reinsert the previous one, with a value: INSERT INTO systempreferences (variable, value) VALUES ('ExportWithCsvProfile', 'something'); Execute the DB entry again => The now pref should be now set 5/ Export some checkouts using the CSV entry 6/ Note that the export tool and commandline script still work using the csv format. You have to provide a --csv_profile_id option to make it work. Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/Exporter/Record.pm | 10 +++------- circ/circulation.pl | 5 +++++ installer/data/mysql/atomicupdate/bug_15475.sql | 6 ++++++ installer/data/mysql/sysprefs.sql | 2 ++ .../intranet-tmpl/prog/en/includes/checkouts-table.inc | 11 +++++++++-- .../prog/en/modules/admin/preferences/circulation.pref | 8 +++++--- koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 5 +---- .../intranet-tmpl/prog/en/modules/help/circ/circulation.tt | 2 +- .../intranet-tmpl/prog/en/modules/members/moremember.tt | 5 +---- koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 10 ++++++++++ members/moremember.pl | 5 +++++ misc/export_records.pl | 9 +++------ tools/export.pl | 6 ------ 13 files changed, 51 insertions(+), 33 deletions(-) create mode 100644 installer/data/mysql/atomicupdate/bug_15475.sql hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 14:00:31 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 12:00:31 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-677-g0fcfc56 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 0fcfc561adae216d630a7b770440e7d5c315dcd2 (commit) from 2b0b5d68de77f977e894dc69a379b1c8f4034eea (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0fcfc561adae216d630a7b770440e7d5c315dcd2 Author: Kyle M Hall Date: Fri Mar 31 11:19:50 2017 +0000 Bug 15498 - DBRev 16.12.00.018 Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/atomicupdate/bug_15475.sql | 6 ------ installer/data/mysql/updatedatabase.pl | 18 ++++++++++++++++++ 3 files changed, 19 insertions(+), 7 deletions(-) delete mode 100644 installer/data/mysql/atomicupdate/bug_15475.sql hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 14:01:31 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 12:01:31 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-679-g4bd8b75 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 4bd8b751e396eca594606b988de1fa5dbf3fd73f (commit) via 712e67aa7efa032c35103dc90a7243361eebe568 (commit) from 0fcfc561adae216d630a7b770440e7d5c315dcd2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4bd8b751e396eca594606b988de1fa5dbf3fd73f Author: Marcel de Rooy Date: Fri Mar 31 09:32:53 2017 +0200 Bug 18332: [QA Follow-up] Adjust slice call in last method We should call slice in list context with the correct indexes. Test plan: Run t/db_dependent/Koha/Objects.t Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 712e67aa7efa032c35103dc90a7243361eebe568 Author: Jonathan Druart Date: Thu Mar 23 22:03:19 2017 -0300 Bug 18332: Add the Koha::Objects->last method DBIx::Class does not provide such method, but it can be handy in some cases. Test plan: prove t/db_dependent/Koha/Objects.t should return green Test returned green. Signed-off-by: Marc V?ron Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/Objects.pm | 26 +++++++++++++++++++++++++- t/db_dependent/Koha/Objects.t | 15 ++++++++++++++- 2 files changed, 39 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 14:05:04 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 12:05:04 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-682-g6831dd5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6831dd5977086ea869516bfdce995a7cd2b921ef (commit) via 3be702c1a1ab8c18e5b4a07385d2f8749b172d40 (commit) via 9236efdb5727189478f317ab4d1c61fc8556194d (commit) from 4bd8b751e396eca594606b988de1fa5dbf3fd73f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6831dd5977086ea869516bfdce995a7cd2b921ef Author: Kyle M Hall Date: Fri Mar 31 11:23:43 2017 +0000 Bug 18173 - DBRev 16.12.00.019 Signed-off-by: Kyle M Hall commit 3be702c1a1ab8c18e5b4a07385d2f8749b172d40 Author: Marcel de Rooy Date: Tue Mar 7 14:26:51 2017 +0100 Bug 18173: DBIx schema changes Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 9236efdb5727189478f317ab4d1c61fc8556194d Author: Jonathan Druart Date: Mon Feb 27 09:41:55 2017 +0000 Bug 18173: Remove DB field issues.return The DB field issues.return has never really been used apparently. I found the first occurrence of this field in commit eac3a7b19a8aa7cda34aac396f5093c213a4aa5a CommitDate: Mon Mar 12 22:43:47 2001 +0000 Database definition file, checked into cvs to make keeping database current easier Since I did not find any use of this field. I guess it can be removed safely. There is no proper test plan here. Just make sure this field has never been used. Signed-off-by: Magnus Enger I have not found any use of issues.return or old_issues.return. In all my live instances the column is always NULL. Issuing and returning seems to work as expected after the columns have been removed. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- Koha/Schema/Result/Issue.pm | 12 ++---------- Koha/Schema/Result/OldIssue.pm | 12 ++---------- installer/data/mysql/kohastructure.sql | 2 -- installer/data/mysql/updatedatabase.pl | 14 ++++++++++++++ 5 files changed, 19 insertions(+), 23 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 14:45:04 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 12:45:04 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-693-ge83d92a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e83d92a713e2deea3081a4ff8caa0d63ea66d8c8 (commit) via 8639a64bdb35cf9b28baceffb22cc81394dd8db2 (commit) via 14a78a8c5201ad2e4306ed0202007820e1409bb3 (commit) via 703b97f22d62ac7d25981a0449196fbe5b90aec1 (commit) via e1dce7dd5b1d62671d8d59055f832fcae1a26260 (commit) via ac30cc82492b11ab99020bd555b5e20ebb6c2a23 (commit) via ecf5dcdbfad35dbdf81843274049113907620a10 (commit) via 24d6de661af1e414e8deaa1e61cff511d570d2cf (commit) via 041a04282ae1c7e2a187760265ab639e1139cab7 (commit) via 87afa5142bd12c0d5ff630dbf27d8703ca0ea131 (commit) via 42d110a774b65549241e191882f87a89fc312329 (commit) from 6831dd5977086ea869516bfdce995a7cd2b921ef (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e83d92a713e2deea3081a4ff8caa0d63ea66d8c8 Author: Jonathan Druart Date: Fri Feb 3 10:45:13 2017 +0100 Bug 17736: Fix typo ->new vs ->next while ->new is terrible, let's call that a typo... Signed-off-by: Marcel de Rooy opac-detail works again ! Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall commit 8639a64bdb35cf9b28baceffb22cc81394dd8db2 Author: Marcel de Rooy Date: Fri Jan 6 13:36:35 2017 +0100 Bug 17736: [QA Follow-up] Script basket.pl is not Plack compliant Several warnings like: Variable "$confirm_pref" is not available at /usr/share/koha/masterclone/acqui/basket.pl line 507. Primarily caused by sub edi_close_and_order. Easy fix. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall commit 14a78a8c5201ad2e4306ed0202007820e1409bb3 Author: Marcel de Rooy Date: Fri Jan 6 13:22:07 2017 +0100 Bug 17736: [QA Follow-up] We do not need GetItemHolds in acqui The solution of Jonathan can be applied in two other cases, effectively making GetItemHolds obsolete. Test plan: [1] Git grep on GetItemHolds [2] Add an order, place a hold, delete order. [3] Add an order, receive, place hold, delete order. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall commit 703b97f22d62ac7d25981a0449196fbe5b90aec1 Author: Marcel de Rooy Date: Fri Jan 6 12:21:56 2017 +0100 Bug 17736: [QA Follow-up] Crashes in basket.pl and parcel.pl Crash in basket.pl: Can't call method "holds" on an undefined value at /usr/share/koha/masterclone/acqui/basket.pl line 466. Comes from a biblionumber == NULL in aqorders where I cancelled the order and deleted the biblio. Crash in parcel.pl: Can't call method "holds" on an undefined value at /usr/share/koha/masterclone/acqui/parcel.pl line 246. Similar fix. Trivial fixes indeed. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall commit e1dce7dd5b1d62671d8d59055f832fcae1a26260 Author: Marcel de Rooy Date: Fri Jan 6 12:03:27 2017 +0100 Bug 17736: [QA Follow-up] Wrong biblionumber in acqui/parcel Trivial fix. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall commit ac30cc82492b11ab99020bd555b5e20ebb6c2a23 Author: Marcel de Rooy Date: Fri Jan 6 11:45:17 2017 +0100 Bug 17736: [QA Follow-up] Solve warning from qa tools on Holds.t FAIL t/db_dependent/Holds.t "my" variable $hold masks earlier declaration in same scope Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall commit ecf5dcdbfad35dbdf81843274049113907620a10 Author: Marcel de Rooy Date: Fri Jan 6 11:21:10 2017 +0100 Bug 17736: [Follow-up] Resolve inherited AUTOLOAD for non-method errors Like: Use of inherited AUTOLOAD for non-method Koha::Biblio::GetMarcBiblio() is deprecated at /usr/share/koha/masterclone/Koha/Biblio.pm line 60. Use of inherited AUTOLOAD for non-method Koha::Biblio::GetRecordValue() is deprecated at /usr/share/koha/masterclone/Koha/Biblio.pm line 60. Resolved by not importing them but fully qualifying them. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall commit 24d6de661af1e414e8deaa1e61cff511d570d2cf Author: Marcel de Rooy Date: Fri Jan 6 10:48:48 2017 +0100 Bug 17736: [Follow-up] Rename to current_holds It is not about when the hold was 'placed' but if the hold pertains to the future or not. Test plan: [1] Git grep on holds_placed_before_today. [2] Run t/db_dependent/Koha/Biblios.t [3] Run t/db_dependent/Reserves.t Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall commit 041a04282ae1c7e2a187760265ab639e1139cab7 Author: Jonathan Druart Date: Wed Dec 7 12:26:53 2016 +0100 Bug 17736: Remove C4::Reserves::GetReservesFromBiblionumber At this point, there should not be any occurrences of GetReservesFromBiblionumber left in the codebase Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall commit 87afa5142bd12c0d5ff630dbf27d8703ca0ea131 Author: Jonathan Druart Date: Wed Dec 7 02:29:01 2016 +0000 Bug 17736: Replace GetReservesFromBiblionumber with Koha::Biblio->holds The C4::Reserve::GetReservesFromBiblionumber took 3 parameters, the biblionumber, an optional itemnumber and a "all_dates" flag. If set, the subroutine returned all the holds placed on a given bibliographic record, even the ones placed in the future. Almost all of the calls had this flag set, they will be replaced with a call to Koha::Biblio->holds. But 5 did not have it: - C4::Biblio::DelBiblio -tools/batch_delete_records.pl => These 2 were wrong, we want to retrieve the holds to cancel them before deleting the record. We need to get all the holds, even the ones placed in the future /!\ CHANGE IN THE BEHAVIOR - acqui/parcel.pl => 1 call per item were made to this subroutine. They have been replaced with only 1 call to the new method Koha::Biblios->holds_placed_before_today Then we filter on the itemnumbers. I think this is wrong: we need the number of holds to know if the record can be deleted, so even if future holds exist, the deletion should not be possible. - serials/routing-preview.pl - C4::ILSDI::Services::GetRecords - C4::SIP::ILS::Item->new => Seems ok, we just one to display holds placed before today Test plan: I would suggest to test this patch with patches from bug 17737 and bug 17738, to place different kind of holds (biblio and item level, future and past). Then do a whole workflow to detect bug, view a record, delete record, order, place a hold on an item which has been ordered, etc. The hold's informations should always be the same without or without these patches. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall commit 42d110a774b65549241e191882f87a89fc312329 Author: Jonathan Druart Date: Wed Dec 7 16:38:38 2016 +0100 Bug 17736: Add the Koha::Biblio->holds_placed_before_today method Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Biblio.pm | 8 ++- C4/ILSDI/Services.pm | 8 ++- C4/Items.pm | 22 ------- C4/Reserves.pm | 67 -------------------- C4/SIP/ILS/Item.pm | 12 ++-- Koha/Biblio.pm | 27 ++++++-- acqui/basket.pl | 21 +++--- acqui/parcel.pl | 20 +++--- catalogue/ISBDdetail.pl | 6 +- catalogue/MARCdetail.pl | 6 +- catalogue/detail.pl | 6 +- catalogue/imageviewer.pl | 6 +- catalogue/labeledMARCdetail.pl | 6 +- catalogue/moredetail.pl | 8 +-- .../prog/en/modules/tools/batch_delete_records.tt | 4 +- opac/opac-detail.pl | 18 +++--- opac/opac-reserve.pl | 10 +-- serials/routing-preview.pl | 27 ++++---- t/db_dependent/Holds.t | 29 +++++---- t/db_dependent/Koha/Biblios.t | 15 ++++- t/db_dependent/Reserves.t | 25 ++++---- t/db_dependent/UsageStats.t | 7 +- tools/batch_delete_records.pl | 19 ++++-- 23 files changed, 160 insertions(+), 217 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 14:53:11 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 12:53:11 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-701-g767ede8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 767ede853bbc2d899c0b7c39ad884111d4e93902 (commit) via 7bbb8be387ee80359261613ebc727a77382d03fe (commit) via 0509d427b9ef7358cc7d044f19c4be2039ccfced (commit) via 164db2833e8fb746d50540ae286e0fef97a83a41 (commit) via 20fe28d42cad0088e1d474b2d8249e3a7eec6f7b (commit) via 91c087cebcab7b005ced31c6deb9519dad3b3abf (commit) via e5d1f6c70835f23465af0a50821888b6211db37d (commit) via 6bdae255a919fbc7c4e8ae507190ea780a0b9860 (commit) from e83d92a713e2deea3081a4ff8caa0d63ea66d8c8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 767ede853bbc2d899c0b7c39ad884111d4e93902 Author: Kyle M Hall Date: Fri Mar 31 12:12:21 2017 +0000 Bug 17560 - DBRev 16.12.00.020 Signed-off-by: Kyle M Hall commit 7bbb8be387ee80359261613ebc727a77382d03fe Author: Jonathan Druart Date: Mon Mar 20 11:10:44 2017 -0300 Bug 17560: Improve wordings Signed-off-by: Marcel de Rooy Amended as per comment33 of Alex Sassmannshausen. Signed-off-by: Kyle M Hall commit 0509d427b9ef7358cc7d044f19c4be2039ccfced Author: Jonathan Druart Date: Fri Mar 10 10:59:41 2017 -0300 Bug 17560: Improve strenght of hold existence test This patch is a QA follow-up to fix several issues: - 1 call to GetReserveFee was wrong in ModReserveFill - Update DB entry was wrong and insufficient - Add robustness to the tests in sco-main Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 164db2833e8fb746d50540ae286e0fef97a83a41 Author: Jonathan Druart Date: Sun Nov 6 19:41:47 2016 +0000 Bug 17560: Add a message when a patron checking in using the self checkout Sponsored-by: Cheshire Libraries Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 20fe28d42cad0088e1d474b2d8249e3a7eec6f7b Author: Jonathan Druart Date: Sun Nov 6 18:55:22 2016 +0000 Bug 17560: Update the wording when a patron places a hold at the OPAC Sponsored-by: Cheshire Libraries Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 91c087cebcab7b005ced31c6deb9519dad3b3abf Author: Jonathan Druart Date: Thu Nov 3 16:12:38 2016 +0000 Bug 17560: Hold fee placement at point of checkout Currently, Koha charges all patrons a hold fee in all circumstances, if a hold fee is applicable to their patron category. This is immediately applied at point of request. However, it would be useful to let patrons make requests without a charge being incurred until they physically have the item in their hands and checked out to their cards. The hold fee will only be added to the account as soon as the item is checked out to the requesting patron. With this scenario, we will be certain that patrons have the correct item, and they are happy with what has been supplied. It also means that patrons can place holds via the OPAC without reaching the usage limit that has been selected. Test plan: 0/ All the following steps must be done with a patron using a patron category with a hold fee 1/ Make sure that the existing options for HoldFeeMode work as before 2/ Select the third option "any time a hold is collected" 3/ Place a hold on an item 4/ Note that the patron has not been charged 5/ Check this item from the staff interface 6/ Note that the patron has been charged 7/ Place another hold 8/ Use the self checkout feature at the OPAC for the checkin 9/ Note that the patron has been charged and a message is displayed to inform about the fee. Sponsored-by: Cheshire Libraries Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit e5d1f6c70835f23465af0a50821888b6211db37d Author: Jonathan Druart Date: Thu Nov 3 13:20:17 2016 +0000 Bug 17560: Update current code This patch updates the current code to make it works with the new option's name of the syspref. It also refactor the tests to make them more reusable and robust. Sponsored-by: Cheshire Libraries Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 6bdae255a919fbc7c4e8ae507190ea780a0b9860 Author: Jonathan Druart Date: Thu Nov 3 08:16:26 2016 +0000 Bug 17560: Add a third option to HoldFeeMode This patch adds a new 'any_time_is_collected' option to the HoldFeeMode syspref. The existing 'always' option is renamed with 'any_time_is_placed'' Sponsored-by: Cheshire Libraries Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy ----------------------------------------------------------------------- Summary of changes: C4/Reserves.pm | 13 +- Koha.pm | 2 +- installer/data/mysql/sysprefs.sql | 2 +- installer/data/mysql/updatedatabase.pl | 14 ++ .../en/modules/admin/preferences/circulation.pref | 3 +- .../opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 6 +- .../opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 3 + opac/sco/sco-main.pl | 40 +++++- t/db_dependent/Reserves/GetReserveFee.t | 147 +++++++++++++++----- 9 files changed, 184 insertions(+), 46 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 15:02:06 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 13:02:06 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-705-g443b2ef Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 443b2ef4f4a8a99f3369668257be8bd7d147143e (commit) via 6ddf51573dac1e97f5bd2fc23211d22206a9aa6d (commit) via 68c365ea8ab536a85d92d3769b0bbaa0e1691116 (commit) via 8c3fc47338fed6c35ea21a6524d6c1a109861ebf (commit) from 767ede853bbc2d899c0b7c39ad884111d4e93902 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 443b2ef4f4a8a99f3369668257be8bd7d147143e Author: Alex Arnaud Date: Tue Nov 15 10:30:16 2016 +0000 Bug 6979 - Fix Already in a transaction error Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall commit 6ddf51573dac1e97f5bd2fc23211d22206a9aa6d Author: Alex Arnaud Date: Tue Nov 15 10:02:05 2016 +0000 Bug 6979 - Handle multiple branches in non-auth_by_bin Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall commit 68c365ea8ab536a85d92d3769b0bbaa0e1691116 Author: Alex Arnaud Date: Tue Nov 15 09:46:52 2016 +0000 Bug 6979 - Update tests Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall commit 8c3fc47338fed6c35ea21a6524d6c1a109861ebf Author: = <=> Date: Wed Oct 5 16:47:21 2011 -0400 Bug #6979 I removed several lines of code in the checkpw_ldap subroutine where LDAP authentication takes place, in the "else" part of the conditional that checks for the auth_by_bind config parameter. I added several lines to check whether the user can log in to LDAP using their DN and the password supplied in the login form. If they are able to bind, login contiues as normal and the LDAP attributes can be harvested as normal if the update options are turned on. The routine that was in place was failing because it was trying to check against a non-existent LDAP entry attribute called 'userpassword'. Instead of checking against a 'userpassword' attribute, the routine really should be checking to make sure the user can actually bind to LDAP. That's what I set up, and it is a safer way to test authentication against LDAP. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Auth_with_ldap.pm | 37 +++++++---- t/db_dependent/Auth_with_ldap.t | 140 +++++++++++++++------------------------ 2 files changed, 80 insertions(+), 97 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 15:03:59 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 13:03:59 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.18-2-ge491615 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via e491615349409389af192f285320fd60cd43dba5 (commit) from d84f150e88509e77929eb9f4fbd4237262bf361d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e491615349409389af192f285320fd60cd43dba5 Author: Marc V?ron Date: Sat Mar 11 19:17:37 2017 +0100 Bug 18246: Patron card creator: Unit not always displays properly in layouts To reproduce: 1) Create a new layout 2) Select an unit in "Units selection" 3) Save 4) Edit layout again 5) Select other unit, e.g. 'SI Centimeter' 6) Save 7) Repeat 8) Edit again Error: Latest unit seems to stick and can no longer be changed, because in units drop down, multiple untis are marked as selected. To test: 1) Apply patch 2) Repeat steps above, verify that value for units always display as expected. Signed-off-by: Jesse Maseto Signed-off-by: Marcel de Rooy Signed-off-by: Brendan A Gallagher (cherry picked from commit 37da40b323d8bc012724510fe4839dcb908c2b3b) Signed-off-by: Katrin Fischer (cherry picked from commit 95bccfbbb8f2b0d0de064ae34dca24e3d59852a4) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: patroncards/edit-layout.pl | 2 ++ 1 file changed, 2 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 15:13:40 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 13:13:40 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-707-g664d653 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 664d6534171677455f3cf1467e8726146714133a (commit) via 358fb744c74cc63b7d2ae7d7e406ada205502ea8 (commit) from 443b2ef4f4a8a99f3369668257be8bd7d147143e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 664d6534171677455f3cf1467e8726146714133a Author: Marcel de Rooy Date: Tue Mar 28 16:39:25 2017 +0200 Bug 12913: [QA Follow-up] Reword 'change item status' and add zero status The zero status should be added in @notforloans. It is a legitimate status for available books. The zero status description can be translated in the template. The 'Change item status' is confusing. We mean that we saw a notforloan status that we do not expect (read: does not exist in the table). Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 358fb744c74cc63b7d2ae7d7e406ada205502ea8 Author: Fridolin Somers Date: Fri Sep 12 15:21:18 2014 +0200 Bug 12913 - wrong inventory results when notforloan filter is not used In inventory tool, there is a test on scanned items notforloan value : if the value is not one of authorized values, the inventory results displays the problem "Change item status". The bug is that if notforloan filter is not used, the notforloan values array is not filled and so all scanned items are marked with this problem. Test plan : - Check you have in default framework an item subfield mapped with items.notforloan and with an authorized value catergory, for example 'NOTFORLOAN' - Check the authorized value category has at least value '0' - Create a new value in this category, for example '9' - Create a biblio with default framework - Create an item with barcode='000AAA1', callnumber='ZZZAAA1' and notforloan=0 - Create an item with barcode='000AAA2', callnumber='ZZZAAA2' and notforloan=9 - Delete new value created above, for example '9' - Create a file 'barecodes.txt' containing 2 lines '000AAA1' and '000AAA2' - Go to inventory tool : /cgi-bin/koha/tools/inventory.pl - Choose file in 'Barcode file' - Enter item callnumber between 'ZZZ' and 'ZZZZ' - Check 'Compare barcodes list to results' - Submit => without patch, you get 2 results with problem 'Change item status' even for item with notforloan=0 => with patch, you get 1 result with 'Change item status' on item with notforloan=9 Signed-off-by: Nick Clemens Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/tools/inventory.tt | 14 ++++++++---- tools/inventory.pl | 23 ++++++-------------- 2 files changed, 17 insertions(+), 20 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 15:14:06 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 13:14:06 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-708-g0f32bd9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 0f32bd99997c82cf7b70eef32818dc817cbff64b (commit) from 664d6534171677455f3cf1467e8726146714133a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0f32bd99997c82cf7b70eef32818dc817cbff64b Author: Fridolin Somers Date: Fri Mar 24 16:07:16 2017 +0100 Bug 18329 - Batch record deletion broken Hie, Tools > Batch record deletion seems broken. Any deletion returns error : Bibliographic record YYY was not deleted. An error occurred. (The error was: {UNKNOWN}: DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1560. at /home/koha/src/C4/Biblio.pm line 3468 , see the Koha log file for more information). Looks like it is because of Bug 18242 which added a transaction in C4::Biblio::_koha_delete_biblio_metadata : $schema->txn_do. The script batch_delete_records created a transaction with $dbh->{AutoCommit} = 0; This patch fixes by using also Koha::Schema in batch_delete_records to manage transaction. It also removes "$dbh->{RaiseError} = 1", this behavior is managed in Koha::Database. Test plan : - Go to Staff interface : Tools > Batch record deletion - Enter a few existing biblionumbers - Click on "Continue" - Click on "Delete selected records" => Without patch you get a DB error => With patch you get confirmation message - Try to get the biblios to confirm they are deleted : /cgi-bin/koha/catalogue/detail.pl?biblionumber=xxx - Test with and without Plack Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: tools/batch_delete_records.pl | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 15:14:39 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 13:14:39 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-709-g72de37e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 72de37e24bd02ffccad3cd1a76e0d74202cf7794 (commit) from 0f32bd99997c82cf7b70eef32818dc817cbff64b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 72de37e24bd02ffccad3cd1a76e0d74202cf7794 Author: Benjamin Rokseth Date: Tue Dec 13 13:38:19 2016 +0100 Bug 17758 - SIP checkin does not handle holds correctly This patch updates SIP checkin to use reserve_id as param, to fix regression introduced by Bug 14695. To test: Given 1 patron and 1 biblio with two items attached: 1) create two record level holds on one biblio on same user Using SIP client or telnet: 2) checkin item x on pickup branch, observe item is waiting and hold 1 is filled 3) checkin item y on pickup branch, observe item y now is waiting and x is available 4) apply this patch and repeat 1-3, now expected behaviour should be that both holds are filled and both items waiting Signed-off-by: Srdjan Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/SIP/ILS/Transaction/Checkin.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 15:16:23 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 13:16:23 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-710-gb041dfa Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b041dfa1800249f0179cb6839eda029026d088ca (commit) from 72de37e24bd02ffccad3cd1a76e0d74202cf7794 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b041dfa1800249f0179cb6839eda029026d088ca Author: Aleisha Amohia Date: Tue Feb 14 01:36:44 2017 +0000 Bug 8548: Add datatable to circ overdue report, remove sortby filter This patch adds a datatable to the circ overdue report. Since the datatable makes sorting easy, I've also removed the sort by filter on the side. To test: 1) Go to Circulation -> Overdues 2) Notice overdues report shows as datatable 3) Confirm sorting on all columns works 4) Test the Filters and confirm they all still work as expected Sponsored-by: Catalyst IT Signed-off-by: Baptiste Wojtkowski Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: circ/overdue.pl | 60 +------------------- .../intranet-tmpl/prog/en/modules/circ/overdue.tt | 34 +++-------- 2 files changed, 9 insertions(+), 85 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 15:16:54 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 13:16:54 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-714-g8fcb7c1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 8fcb7c11480cf96ffcbd2979aa1e4219337e5de5 (commit) via a191bcaf323f7effd66e7b46dfdcbd722ba0a647 (commit) via 4c2b8358cb4974d1b6b708e1dfe6084cf4049457 (commit) via 53ebb5c33b474ce507d1e7c239dbffb3d1842b1b (commit) from b041dfa1800249f0179cb6839eda029026d088ca (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8fcb7c11480cf96ffcbd2979aa1e4219337e5de5 Author: Jonathan Druart Date: Tue Mar 21 16:03:11 2017 -0300 Bug 17708: Rename 'RENEW' with 'RENEWAL' Sounds more appropriate and consistent with existing action logs. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit a191bcaf323f7effd66e7b46dfdcbd722ba0a647 Author: Jonathan Druart Date: Tue Mar 21 15:53:26 2017 -0300 Bug 17708: Fix use statements For an unknown reason, the use_ok('Circulation') does not work as intended (see 3660c451a36d). With the new use of C4::Log, the trick does no longer work. It does not make sense to add the use_ok('C4::Log') in Circulation.t, removing it. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 4c2b8358cb4974d1b6b708e1dfe6084cf4049457 Author: Jonathan Druart Date: Tue Mar 21 16:00:19 2017 -0300 Bug 17708: Add the IGNORE clause Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 53ebb5c33b474ce507d1e7c239dbffb3d1842b1b Author: Baptiste Wojtkowski Date: Wed Feb 8 08:54:42 2017 +0000 Bug 17708: Added a logaction function in Addrenewal in order to send renew logs 20/02/17 : added the syspref RenewalLog 24/20/17 : added a test for the syspref Renewal Log test plan 1 - Chose a Borrower and have him renewing an item 2 - Check the renew logs : they should be empty 3 - Apply patch and set the syspref RenewalLog to 1 4 - Have the Borrower renewing a new item 5 - Check the renew logs : there should be your renew I called the function logaction, which is in charge of modifying the logs, within the function which adds a new renewal at the list. Signed-off-by: Julien Comte Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 4 +++- .../atomicupdate/bug_17708_add-RenewalLog.sql | 2 ++ installer/data/mysql/sysprefs.sql | 1 + .../prog/en/modules/admin/preferences/logs.pref | 6 ++++++ t/db_dependent/Circulation.t | 21 +++++++++++++++----- 5 files changed, 28 insertions(+), 6 deletions(-) create mode 100644 installer/data/mysql/atomicupdate/bug_17708_add-RenewalLog.sql hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 15:17:34 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 13:17:34 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.18-3-gf23c922 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via f23c9225406f8ab61da7c0560e4c56ec4065a601 (commit) from e491615349409389af192f285320fd60cd43dba5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f23c9225406f8ab61da7c0560e4c56ec4065a601 Author: Jonathan Druart Date: Tue Feb 14 15:22:40 2017 +0000 Bug 18094: Only search in searchable patron attributes if searching in standard fields Test plan: - Add a new patron attrbute and mark it searchable - Populate a new patron with 'potato' in that field - Add/edit another patron to have email potato at invalidemail.com' - Perform a patron search with query 'potato' (in standard fields) => Both patrons are returned - Perform a patron search with filters 'Email' and query 'potato' => Only 1 patron is returned and you are redirected to the patron detail page. Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Brendan A Gallagher (cherry picked from commit 5823d4ca6a71404d502eeb7f1bf5dd152fd98e22) Signed-off-by: Katrin Fischer (cherry picked from commit b294550ac6db804193928af798500e18d83de9db) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/Utils/DataTables/Members.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 15:18:59 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 13:18:59 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-715-gc77316d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via c77316db40ca94117c120c54214e0dda0f658228 (commit) from 8fcb7c11480cf96ffcbd2979aa1e4219337e5de5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c77316db40ca94117c120c54214e0dda0f658228 Author: Kyle M Hall Date: Fri Mar 31 12:38:21 2017 +0000 Bug 17708 - DBRev 16.12.00.021 Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- .../data/mysql/atomicupdate/bug_17708_add-RenewalLog.sql | 2 -- installer/data/mysql/updatedatabase.pl | 11 +++++++++++ 3 files changed, 12 insertions(+), 3 deletions(-) delete mode 100644 installer/data/mysql/atomicupdate/bug_17708_add-RenewalLog.sql hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 15:19:20 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 13:19:20 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-717-gb76eac9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b76eac9ca2c32a5db51b9b8ca32a2cf4fa6397b5 (commit) via 71f267fd3f3750510e3df5f2819d57ed45dcf919 (commit) from c77316db40ca94117c120c54214e0dda0f658228 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b76eac9ca2c32a5db51b9b8ca32a2cf4fa6397b5 Author: Marcel de Rooy Date: Mon Feb 6 10:29:44 2017 +0100 Bug 14535: Update the supplier filter too The combobox on the left side of late orders is filled by sub GetBooksellersWithLateOrders. The same change as in the first patch must be made here to include suppliers with late orders without a price. Bonus: Sort the list. Test plan: [1] Run t/db_dependent/Bookseller.t. [2] Go to late orders. Use the filter on suppliers. Signed-off-by: Marcel de Rooy Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 71f267fd3f3750510e3df5f2819d57ed45dcf919 Author: Marcel de Rooy Date: Mon Feb 6 10:04:57 2017 +0100 Bug 14535: Late orders does not show orders with price = 0 This patch removes the filter of unitpricesupplier <> 0 and unitpricelib <> 0 from GetLateOrders as used in lateorders.pl. This allows you to claim late orders without a price entered. Test plan: [1] Run t/db_dependent/Acquisition.t [2] Check if you see an order with no price in lateorders.pl. (If needed, remove prices from a few orders.) Signed-off-by: Marcel de Rooy Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Acquisition.pm | 6 +----- C4/Bookseller.pm | 2 -- acqui/lateorders.pl | 2 +- 3 files changed, 2 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 15:20:17 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 13:20:17 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.18-5-g093f902 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 093f902eafe4f721f88445ee3f5ef440c9768f30 (commit) via 65b29fdda57d66d8beb105ecaca4fe7eaa1fab50 (commit) from f23c9225406f8ab61da7c0560e4c56ec4065a601 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 093f902eafe4f721f88445ee3f5ef440c9768f30 Author: Marcel de Rooy Date: Sun Jan 29 15:40:14 2017 +0100 Bug 18010: Remove potential exposure from gettemplate A similar bad template check from C4::Auth::get_template_and_user should be applied in C4::Templates::gettemplate. Before this patch it would be possible to expose files like: my $template = C4::Templates::gettemplate( '/etc/passwd', 'intranet', CGI::new, 1 ); print $template->output; Note that the is_plugin flag in the above call is the culprit. This patch provides a quick security fix without touching get_template_and_user, and can be backported to stable branches. I will provide an enhanced and centralized check on report 17989, also removing the is_plugin flag. Note: We allow .pref here too for use in admin/preferences.pl. Test plan: [1] Run t/db_dependent/Auth.t (triggering get_template_and_user and gettemplate). [2] Run t/db_dependent/Templates.t again (see first test plan). The tests should no longer fail. [3] Open a page on opac or intranet. [4] Open a systempreferences tab. [5] Add a book to the cart and send it ([opac-]sendbasket uses gettemplate). Signed-off-by: Marcel de Rooy Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Brendan A Gallagher (cherry picked from commit fbbd4b40f0d71b79194fc186e66f985488be26c6) Signed-off-by: Katrin Fischer (cherry picked from commit 74fe3f5cda7cac22640f9ae3d68b3d62a6765dc0) Signed-off-by: Julian Maurice commit 65b29fdda57d66d8beb105ecaca4fe7eaa1fab50 Author: Marcel de Rooy Date: Sun Jan 29 15:52:22 2017 +0100 Bug 18010: Unit test for gettemplate A trivial test, similar to the ones in Auth.t. Without the check in gettemplate (added in the second patch), the passwd file will be exposed and the test fails. Test plan: Run t/db_dependent/Templates.t without second patch. The two tests in the last subtest should fail. Signed-off-by: Marcel de Rooy Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Brendan A Gallagher (cherry picked from commit 5508897d5a2b73c30d50fed26a6bfed62bf49398) Signed-off-by: Katrin Fischer Conflicts: t/db_dependent/Templates.t (cherry picked from commit 1161a67476b5b61358fdaecca57b012e663a7b02) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/Templates.pm | 1 + t/db_dependent/Templates.t | 14 +++++++++++++- 2 files changed, 14 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 15:27:05 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 13:27:05 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-718-ga723de2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a723de2ae0c393743fc111955ee81b5e6c5b7f4a (commit) from b76eac9ca2c32a5db51b9b8ca32a2cf4fa6397b5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a723de2ae0c393743fc111955ee81b5e6c5b7f4a Author: Marc V?ron Date: Fri Mar 10 11:22:24 2017 +0100 Bug 18244: Patron card creator does not take in account fields with underscore (B_address etc.) Fields with underscore like B_address do not print on patron cards. To reproduce: - Create patron card layout using fields with underscore in their name (e.g. ) - Print (export) patron card - Verify that fields without underscore are replaced by their value, but fields with underscore do not replace but show the field name To test: - Apply patch - Try to reproduce and verify that fields with underscore are replace as expected Signed-off-by: Christopher Brannon Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Patroncards/Patroncard.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 15:28:40 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 13:28:40 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-722-g53f2b56 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 53f2b56fa15fac2f0d2ef0777e95f436d6914ec7 (commit) via c26afc2568311a2b7a99f33705cbc35b715563a8 (commit) via d79a264b6991d48bda026fc0ccde0607b519423f (commit) via 1843ee148b25a904d8baffbbe8f0ea504b539a64 (commit) from a723de2ae0c393743fc111955ee81b5e6c5b7f4a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 53f2b56fa15fac2f0d2ef0777e95f436d6914ec7 Author: Marcel de Rooy Date: Fri Mar 17 13:24:41 2017 +0100 Bug 7728: [QA Follow-up] Fix POD whitespace Resolves complaints from qa tools. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit c26afc2568311a2b7a99f33705cbc35b715563a8 Author: Julian Maurice Date: Wed Jan 11 14:51:43 2017 +0100 Bug 7728: QA fixes - Remove useless comments - Use Koha::Objects::find instead of Koha::Objects::search Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit d79a264b6991d48bda026fc0ccde0607b519423f Author: Paul Poulain Date: Tue Jan 26 14:03:21 2016 +0000 Bug 7728: Adding unit test ReNewSubscription.t Test plan: * run without the patch, the test will fail * run with the patch, the test will pass Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 1843ee148b25a904d8baffbbe8f0ea504b539a64 Author: Paul Poulain Date: Wed Dec 9 10:25:43 2015 +0000 Bug 7728: Fix subs history end date consistency Without this patch, there is an inconsistency in subscriptions: * a new subscription has no history end date set (as expected) * if you renew it, a date is set. This patch removes the setting of the history end date during renewal Test plan: * create a subscription, go to subscription-detail.pl page, tab "Summary". No History end date is set * renew the subscription => a date has been set * apply the patch * create another subscription * renew it => no history end date has been set * sign-off Signed-off-by: beroud Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Serials.pm | 16 ++--- t/db_dependent/Serials/ReNewSubscription.t | 96 ++++++++++++++++++++++++++++ 2 files changed, 103 insertions(+), 9 deletions(-) create mode 100644 t/db_dependent/Serials/ReNewSubscription.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 15:31:16 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 13:31:16 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.18-7-g45e686c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 45e686c842dc684ca6d55793fd2f3a49fcac7ffa (commit) via 59f43610aca9f99c36004a7a3bd638a497c59e40 (commit) from 093f902eafe4f721f88445ee3f5ef440c9768f30 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 45e686c842dc684ca6d55793fd2f3a49fcac7ffa Author: Jonathan Druart Date: Thu Feb 9 12:44:38 2017 +0100 Bug 15854: Use a READ and WRITE LOCK on message_queue To make sure we will not never get a race conditions for these kinds of notices, we need to add a LOCK on the message_queue table. This does not smell the best way to do that, but I faced deadlock issues when I tried to use "UPDATE FOR" https://dev.mysql.com/doc/refman/5.7/en/innodb-locking-reads.html https://dev.mysql.com/doc/refman/5.7/en/lock-tables.html https://dev.mysql.com/doc/refman/5.7/en/commit.html To test this patch, or another solution, you need to apply manually this change: my $message = C4::Message->find_last_message($borrower, $type, $mtt); unless ( $message ) { + sleep(1); C4::Message->enqueue($letter, $borrower, $mtt); } else { And repeat the test plan from first patch. Do not forget to truncate the message_queue table. Followed test plans, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Martin Renvoize Signed-off-by: Brendan A Gallagher (cherry picked from commit be156d9ad9e5bcfadab34d44f90e04fd61e256ad) Signed-off-by: Katrin Fischer (cherry picked from commit ab23d1368343ad115a5072f7264b99c7bee68675) Signed-off-by: Julian Maurice commit 59f43610aca9f99c36004a7a3bd638a497c59e40 Author: Jonathan Druart Date: Thu Feb 9 12:13:07 2017 +0100 Bug 15854: Simplify the code to limit race conditions There is an obvious race condition when CHECKIN and RENEWAL are generated from circulation.pl calling svc/renew or svc/checkin in AJAX. The 2 first queries will try to get the id of the last message (find_last_message) and if it does not exist, they will insert it. Theorically that could be lead to have several "digest" messages for a given patron. I did not recreate more than 2 messages, from the third one at least one of the two firsts existed in the DB already. This patch just simplifies the code to make the SELECT and INSERT or UPDATE closer and limit the race condition possibilities. Test plan: 0. Set RenewalSendNotice and circ rules to have a lot of renewals available 1. Use batch checkouts (or one by one) to check out several items to a patron 2. Empty message_queue (at least of this patron) 3. Renew them all at once ("select all" link, "renew or check in" button) 4. Check the message_queue Without this patch you have lot of chances to faced a race condition and get at least 2 messages for the same patron. This is not expected, we expect 1 digest with all the messages. With this patch apply you have lot of chances not to face it, but it's not 100% safe as we do not use a mechanism to lock the table at the DBMS level. Tested both patches together, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Martin Renvoize Signed-off-by: Brendan A Gallagher (cherry picked from commit 607b14516a955c9989e4764c69527edbc1f36ba0) Signed-off-by: Katrin Fischer (cherry picked from commit bdae6c9492ea8db223c03753090060592a330be7) Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 64 ++++++++++++++++++++++------------------------------- 1 file changed, 27 insertions(+), 37 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 15:46:52 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 13:46:52 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-723-gf454013 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f454013ec9beb8f6e4c382253b76bfac5ca65244 (commit) from 53f2b56fa15fac2f0d2ef0777e95f436d6914ec7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f454013ec9beb8f6e4c382253b76bfac5ca65244 Author: Nick Clemens Date: Fri Mar 3 14:56:31 2017 +0000 Bug 12972 - Transfer slip and transfer message (blue box) can conflict Instead of passing the homebranch to the slip, let's pass TransferWaitingAt (the value we display) To test: 1 - Check in an item that will initiate a transfer (hold or automatic item return) 2 - Note the transfer message and receipt match 3 - Remove the reason for transfer (bot don't cancel transfer) i.e. cancel hold or change homebranch of item to current library 4 - Check the item in again 5 - Note the message displays the transfer destination and the slip shows the homebranch 6 - Apply patch 7 - Repeat 5 but note slip and message match 8 - Test any edge cases for correctness 9 - sign off Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 15:49:02 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 13:49:02 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-725-gd2ee53f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d2ee53fb5f90277d47fc56667e71018f5d9b88a9 (commit) via 5a7dc0749f581e4c4bc6ec68d3f3ab6bac12afd5 (commit) from f454013ec9beb8f6e4c382253b76bfac5ca65244 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d2ee53fb5f90277d47fc56667e71018f5d9b88a9 Author: Marcel de Rooy Date: Thu Mar 30 10:20:30 2017 +0200 Bug 18019: [QA Follow-up] Also catch the delete from authorities detail Good catch from Jonathan. See comment11. Authorities detail should pass a CSRF token to authorities-home when deleting a record without linked biblios. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Passing the token with GET is not a good way to do, but nothing quick to replace that. Signed-off-by: Kyle M Hall commit 5a7dc0749f581e4c4bc6ec68d3f3ab6bac12afd5 Author: Marcel de Rooy Date: Tue Feb 7 09:09:33 2017 +0100 Bug 18019: Add CSRF protection to authorities-home.pl (op==delete) Without this patch, it is possible to delete authority records with URL manipulation. Like: /cgi-bin/koha/authorities/authorities-home.pl?op=delete&authid=[XXX] Test plan: [1] Go to Authorities. Search for some authorities (without links). [2] Delete an authority. Should work. [3] Apply patch. [4] Construct an URL like above to delete another authority. Should fail. Under Plack this results in an internal server error, the log tells you: Wrong CSRF token. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens Amended the test plan. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: authorities/authorities-home.pl | 13 +++++++++++++ authorities/detail.pl | 2 ++ .../intranet-tmpl/prog/en/modules/authorities/detail.tt | 2 +- .../prog/en/modules/authorities/searchresultlist.tt | 3 ++- 4 files changed, 18 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 16:00:07 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 14:00:07 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-728-g5e8366d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 5e8366d77a0c016c5b5a3e045e3e74c5a67da349 (commit) via bc73b938867f95f2a2bfd2d1c5c069ab66a6ea95 (commit) via a5485b65f3e797cef946a0d68419c72fb10eda84 (commit) from d2ee53fb5f90277d47fc56667e71018f5d9b88a9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5e8366d77a0c016c5b5a3e045e3e74c5a67da349 Author: Marcel de Rooy Date: Thu Mar 23 10:01:53 2017 +0100 Bug 17866: [QA Follow-up] Reword message for missing email address See BZ, comment 14 from Jonathan. In the exceptional case that branch email address and fallback, i.e. preference KohaAdminEmailAddress, are both empty or not valid, the error message should reflect that (of course :) Signed-off-by: Marcel de Rooy Removed branch email and KohaAdminEmailAddress. Followed the test plan of the first patch and saw the alert. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit bc73b938867f95f2a2bfd2d1c5c069ab66a6ea95 Author: Marcel de Rooy Date: Wed Mar 22 16:50:33 2017 +0100 Bug 17866: [QA Follow-up] Add notification for changed sender address See BZ, comment 6, requested by QA. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit a5485b65f3e797cef946a0d68419c72fb10eda84 Author: Marcel de Rooy Date: Mon Jan 9 15:10:56 2017 +0100 Bug 17866: Change sender for serial claim notifications Currently, the From field uses the emailaddress of the staff client member from the user context. This is exceptional in Koha. And might very well be, as in our case, the cause of fraud detection warnings. We should use branch email address or fallback to KohaAdminEmailAddress, as we do (almost) everywhere else. Test plan: Go to subscription detail in Koha. Go to Claims. Select a missing issue and click Send notification. Verify the sender address in the generated notification. (Make sure that you receive this mail.) Signed-off-by: Grace McKenzie Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Letters.pm | 3 ++- installer/data/mysql/atomicupdate/bug17866.perl | 5 +++++ koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt | 4 ++-- serials/claims.pl | 2 +- 4 files changed, 10 insertions(+), 4 deletions(-) create mode 100644 installer/data/mysql/atomicupdate/bug17866.perl hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 16:03:19 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 14:03:19 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-729-g0a0fcd3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 0a0fcd31e039a01c0d7693b58a4d787109161954 (commit) from 5e8366d77a0c016c5b5a3e045e3e74c5a67da349 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0a0fcd31e039a01c0d7693b58a4d787109161954 Author: Kyle M Hall Date: Fri Mar 31 13:22:37 2017 +0000 Bug 17866 - DBRev 16.12.00.022 Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/atomicupdate/bug17866.perl | 5 ----- installer/data/mysql/updatedatabase.pl | 6 ++++++ 3 files changed, 7 insertions(+), 6 deletions(-) delete mode 100644 installer/data/mysql/atomicupdate/bug17866.perl hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 16:04:39 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 14:04:39 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-730-g9098a4d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 9098a4d3fa7268bf11ab108693192070c44c9eaf (commit) from 0a0fcd31e039a01c0d7693b58a4d787109161954 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9098a4d3fa7268bf11ab108693192070c44c9eaf Author: Christopher Brannon Date: Fri Mar 10 19:54:05 2017 +0000 Bug 17346: Make checkin column hidable To test: 1) Go to columns_settings.pl --> Circulation --> issues-table and note that you cannot change the settings for checkin. 2) Go to columns_settings.pl --> Patrons --> issues-table and note that you cannot change the settings for checkin. 3) Apply the patch. 4) Go to both tables again and note that you can now change the settings. Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: admin/columns_settings.yml | 4 ---- 1 file changed, 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 16:07:08 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 14:07:08 +0000 Subject: [koha-commits] main Koha release repository annotated tag v3.22.19 created. v3.22.19 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The annotated tag, v3.22.19 has been created at 57e19b2256fa039891f267cc68a8a8424945716d (tag) tagging 2e9be0441c63603d1d48e5b4fb9272bef0dba071 (commit) replaces v3.22.18 tagged by Julian Maurice on Fri Mar 31 16:04:14 2017 +0200 - Log ----------------------------------------------------------------- Koha release 3.22.19 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAABAgAGBQJY3mHeAAoJELCH1RJUPDmpDVgP/A4fTyu/9mnS+K9eCjnMl5bL +giEsPl2bDyPQ6yeiUQxjpeLlB5d9uOnf4YxvQUsD+KTIeNjrZcVISXAUw5WeU8n D1IvdabZdykpXEaNAUmV+Sgl9bLRn9BU7fb7rDDfdJV0F28yAMxLatN3i1ZBHfnR f/AAbEYHuOzC8svq99tIOPh7lMkPSZIgK1sr4SGMVfS3OVR1iaXsbrEhmuyNcwOh 7TP5BP/sPnd+mu7lb+w2UAnoFgVQtj3FwsLiFv/BbPiTG+udLUpi9Q1vlbTaDqvl nUqKS1OWeg9x+nrQWyXXYHoiLkARRAZK2syU0EsECpE14n1BGeuI9K6u0KwBf+CA Nr0rT9OdKZj7f1reG7qCKRaVWQv0y97chhdm2d2r4WDoQYTJkEeyL/SnugjhJxOh aoVYoxTfHlC6THMG5brPmp2wWpRwTx9viwBcNXGmvx81BALz/uRs15lTRIXnNwYr ankXvzshC9nel6+LdOUlYR26yc+W/1tEiSgwBnvQVxSXpkZCV5xpdvNnyq1KFjqx WcKI2g92QDhDQqOJlR9M9sUCKedhDd7bXkfFQi0CkL5w8NWJE209p5K183LAhY4S of1dQMNkSt6O6A1VBf4cWstVhveSqMJllsCIpgM28SoyaytT6kFef8InvxyQ0Ham Bs+sB6z93tAptAsRtrOV =CtBK -----END PGP SIGNATURE----- Jonathan Druart (3): Bug 18094: Only search in searchable patron attributes if searching in standard fields Bug 15854: Simplify the code to limit race conditions Bug 15854: Use a READ and WRITE LOCK on message_queue Julian Maurice (2): Update release notes for 3.22.19 Increment version for 3.22.19 Marc V?ron (2): Bug 8603: Patron card creator - 'Barcode Type' doesn't stick in layouts Bug 18246: Patron card creator: Unit not always displays properly in layouts Marcel de Rooy (2): Bug 18010: Unit test for gettemplate Bug 18010: Remove potential exposure from gettemplate root (1): Translation updates for Koha 3.22.19 ----------------------------------------------------------------------- hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 16:07:06 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 14:07:06 +0000 Subject: [koha-commits] main Koha release repository branch 3.22.x updated. v3.22.19 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.22.x has been updated via 2e9be0441c63603d1d48e5b4fb9272bef0dba071 (commit) via 412809533786b9bedae32b9f60d4ba6c5e31dcf9 (commit) via 466a34c4938abe871b9eef8d2d1efc486a3a0ccd (commit) from 45e686c842dc684ca6d55793fd2f3a49fcac7ffa (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2e9be0441c63603d1d48e5b4fb9272bef0dba071 Author: Julian Maurice Date: Fri Mar 31 16:03:25 2017 +0200 Increment version for 3.22.19 commit 412809533786b9bedae32b9f60d4ba6c5e31dcf9 Author: Julian Maurice Date: Fri Mar 31 16:02:53 2017 +0200 Update release notes for 3.22.19 Signed-off-by: Julian Maurice commit 466a34c4938abe871b9eef8d2d1efc486a3a0ccd Author: root Date: Fri Mar 31 10:46:48 2017 -0300 Translation updates for Koha 3.22.19 Signed-off-by: Julian Maurice ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/updatedatabase.pl | 6 ++ ...e_notes_3_22_16.md => release_notes_3_22_19.md} | 83 +++++++-------- misc/translator/po/de-DE-opac-bootstrap.po | 8 +- misc/translator/po/de-DE-pref.po | 31 +++++- misc/translator/po/de-DE-staff-help.po | 5 +- misc/translator/po/de-DE-staff-prog.po | 25 ++--- misc/translator/po/fr-FR-marc-MARC21.po | 34 +++--- misc/translator/po/fr-FR-marc-NORMARC.po | 16 +-- misc/translator/po/fr-FR-pref.po | 54 ++++++++-- misc/translator/po/fr-FR-staff-help.po | 28 ++--- misc/translator/po/fr-FR-staff-prog.po | 28 ++--- misc/translator/po/it-IT-pref.po | 10 +- misc/translator/po/it-IT-staff-prog.po | 12 +-- misc/translator/po/nl-BE-marc-MARC21.po | 108 +++++++++++++++----- misc/translator/po/nl-BE-staff-help.po | 24 +++-- misc/translator/po/nl-BE-staff-prog.po | 15 +-- misc/translator/po/pl-PL-pref.po | 33 ++++-- misc/translator/po/pl-PL-staff-prog.po | 18 ++-- misc/translator/po/pt-PT-marc-MARC21.po | 18 ++-- misc/translator/po/pt-PT-pref.po | 30 +++++- misc/translator/po/pt-PT-staff-prog.po | 27 ++--- misc/translator/po/tet-staff-prog.po | 16 +-- 23 files changed, 405 insertions(+), 226 deletions(-) copy misc/release_notes/{release_notes_3_22_16.md => release_notes_3_22_19.md} (73%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 16:08:14 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 14:08:14 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-732-g6770289 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 67702891ae6e778836702d1976cc82566f1b344f (commit) via bb5050b5038bb03da3967420fc6b9ef06eef3f83 (commit) from 9098a4d3fa7268bf11ab108693192070c44c9eaf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 67702891ae6e778836702d1976cc82566f1b344f Author: Christopher Brannon Date: Tue Mar 7 22:18:49 2017 +0000 Bug 18219: Remove extra whitespace from returns.tt Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit bb5050b5038bb03da3967420fc6b9ef06eef3f83 Author: Christopher Brannon Date: Tue Mar 7 20:01:05 2017 +0000 Bug 18219: Remove duplicated code in returns.tt Removed lines of code that were duplicated in bug 16530. Fixes alignment of a few lines of code surrounding duplication. Modifies returns.tt To test: 1) Check in items that are not checked out. 2) Note duplicated problem message (i.e. "Not checked out.") 3) Apply patch. 4) Repeat step 1. 5) Note the problem message is no longer duplicated. Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/circ/returns.tt | 75 ++++++-------------- 1 file changed, 20 insertions(+), 55 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 16:09:05 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 14:09:05 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-734-gf14de00 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f14de0007c47ae66d0276186df073c0375d37610 (commit) via bb1492e9f67439753bf428bd06fa710791e70c74 (commit) from 67702891ae6e778836702d1976cc82566f1b344f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f14de0007c47ae66d0276186df073c0375d37610 Author: Jonathan Druart Date: Thu Mar 9 11:25:28 2017 -0300 Bug 18209: Add default, 'Actions' and fix case Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit bb1492e9f67439753bf428bd06fa710791e70c74 Author: Blou Date: Fri Mar 3 16:13:40 2017 -0500 Bug 18209 - Patron's card manage.pl page is not fully translatable The headers of the tables displayed in patroncards/manage.tt are hardcoded in the .pl and thus cannot be translated. This simple fix reuse the translate_card_element tool already in the code to make the strings translatable. Applied patch and verified that table headers on manage.pl display the same as before. Signed-off-by: Marc V?ron Re-tested, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/patroncards/manage.tt | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 16:14:15 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 14:14:15 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-735-gc6463c2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via c6463c258f644ea5a1983680814eb765f1801283 (commit) from f14de0007c47ae66d0276186df073c0375d37610 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c6463c258f644ea5a1983680814eb765f1801283 Author: Marc V?ron Date: Tue Mar 21 14:52:51 2017 +0100 Bug 18307 - Branchname is no longer displayed in subscription tab view This patch restores the branchname in OPAC subscription detail view. Additionally, it adds the subscriptons count to the tab title to make it consistent with the other tab titles. To test: - Search a subscription in OPAC catalog - Go to Subscriptions tab (see screenshot in initial comment) - Verify that library name does not display - Apply patch - Verify that library name displays properly in Subscriptons tab - Verify that the tab title displays the subscriptions count e.g.: Subscriptions (2) Signed-off-by: Claire Gravely Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 16:26:12 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 14:26:12 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-736-g0595fee Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 0595fee148a70110307d743b7ea696ef87a35ff6 (commit) from c6463c258f644ea5a1983680814eb765f1801283 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0595fee148a70110307d743b7ea696ef87a35ff6 Author: Tomas Cohen Arazi Date: Tue Mar 14 11:25:24 2017 -0300 Bug 7143: Add Patricio Marrone to history.txt Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: docs/history.txt | 1 + koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 1 + 2 files changed, 2 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 16:27:14 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 14:27:14 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-737-g9a4fd7b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 9a4fd7b27074d7ce923f7b47061d1e6636ecbc56 (commit) from 0595fee148a70110307d743b7ea696ef87a35ff6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9a4fd7b27074d7ce923f7b47061d1e6636ecbc56 Author: Grace McKenzie Date: Tue Jan 17 22:45:28 2017 +0000 Bug 17290 - Standardize on "Patron Categories" We need to standardize on terminology, this changes all instances of patron types to be patron categories. To text, just view the patch Signed-off-by: C?dric Vita Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/admin/smart-rules.tt | 18 ++++++++-------- .../prog/en/modules/help/admin/categorie.tt | 6 +++--- .../modules/help/admin/item_circulation_alerts.tt | 6 +++--- .../prog/en/modules/help/admin/smart-rules.tt | 22 ++++++++++---------- .../prog/en/modules/help/members/boraccount.tt | 4 ++-- 5 files changed, 28 insertions(+), 28 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 16:28:18 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 14:28:18 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-738-gdb46728 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via db467287d174827e52c322cb86d75b8628df52fe (commit) from 9a4fd7b27074d7ce923f7b47061d1e6636ecbc56 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit db467287d174827e52c322cb86d75b8628df52fe Author: Marc V?ron Date: Tue Mar 14 14:29:08 2017 +0100 Bug 18263: Make use of syspref 'CurrencyFormat' for Account and Pay fines tables On Home > Patrons > Accounts for... and Home > Patrons > Pay fines for..., make the amounts display as defined in syspref 'CurrencyFormat' To test: - Apply patch - Give a patron a high fine or credit (e.g. 12345.67) - Got to pages Home > Patrons > Accounts for... and Home > Patrons > Pay fines - Verify that amounts display following syspref 'CurrencyFormat' (e.g. 12'345.67 for syspref set to 360'000.00 (CH) Signed-off-by: Mirko Tietgen Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/members/boraccount.tt | 9 +++++---- koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt | 11 ++++++----- 2 files changed, 11 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 16:28:53 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 14:28:53 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-739-g5693f10 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 5693f102204f9685fc4b33c74315b22e1536b241 (commit) from db467287d174827e52c322cb86d75b8628df52fe (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5693f102204f9685fc4b33c74315b22e1536b241 Author: Jacek Ablewicz Date: Thu Sep 1 21:10:57 2016 +0200 Bug 17233 - Add 008 value builder plugin for MARC21 classifications This patch adds 008 cataloguing value builder for MARC21 classifications records (LCC, DDC/Dewey, UDC and so on). For most practical purposes, MARC21 classification records () are quite similar to regular MARC21 authority records, so handling them in Koha is (almost) achievable by means of the built-in 'regular' MARC21 authority records related functionalities, but there are some notable differences - in particular, 008 field length and format is not the same. To test: 1) apply patch 2) link the new plugin (marc21_field_008_classifications.pl) to the 008 field in the existing (or cloned, ..) authority framework of your choice 3) try to add, edit, re-edit 008 field using this "authority" framework, ensure that the new plugin behaves as it should according to the Library of Congress specifications for MARC21 classification records 008 field format (). Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: ...ties.pl => marc21_field_008_classifications.pl} | 53 ++--- .../marc21_field_008_classifications.tt | 219 ++++++++++++++++++++ 2 files changed, 240 insertions(+), 32 deletions(-) copy cataloguing/value_builder/{marc21_field_008_authorities.pl => marc21_field_008_classifications.pl} (58%) create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_field_008_classifications.tt hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 16:30:26 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 14:30:26 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-740-g14814bc Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 14814bc9a6986ed33da41767afcbf63084e73c9c (commit) from 5693f102204f9685fc4b33c74315b22e1536b241 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 14814bc9a6986ed33da41767afcbf63084e73c9c Author: Aleisha Amohia Date: Thu Jan 19 21:54:12 2017 +0000 Bug 17946: Show number of subscriptions on tab in OPAC record details This patch removes some duplicate code. To test: 1) Edit at least one subscription (or add a new one) to have a record 2) Find that record on the OPAC 3) Confirm that the Subscriptions tab reads the correct number of subscriptions attached to the record Sponsored-by: Catalyst IT Signed-off-by: JMBroust Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 2 +- opac/opac-detail.pl | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 16:31:05 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 14:31:05 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-741-g85f52d5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 85f52d52e7fc77d6635321523e77a45a69081289 (commit) from 14814bc9a6986ed33da41767afcbf63084e73c9c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 85f52d52e7fc77d6635321523e77a45a69081289 Author: Aleisha Amohia Date: Thu Feb 16 22:10:34 2017 +0000 Bug 18134: Updating Preview MARC button in Batch Authority Record Mod This patch ensures the Preview MARC button when batch modifying authority records looks like the Preview MARC button when batch modifying biblio records. To test: 1) Go to Tools -> Batch record modification 2) Leave record type as Biblio, Put in a biblionumber, select a template and click Continue 3) Notice the 'Show MARC' button 4) Click Cancel and change record type to Authority. Put in auth id, select template, click Continue 5) Notice ugly 'Preview MARC' link 6) Apply patch and refresh page 7) There should now be a nice 'Show MARC' button like there is for biblio mod. Confirm it still works as expected. Sponsored-by: Catalyst IT Signed-off-by: JMBroust Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/tools/batch_record_modification.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 16:31:49 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 14:31:49 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-742-g305c804 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 305c804ec95b4c15e12f1bae16f0f4c0b338bcb5 (commit) from 85f52d52e7fc77d6635321523e77a45a69081289 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 305c804ec95b4c15e12f1bae16f0f4c0b338bcb5 Author: Aleisha Amohia Date: Tue Feb 28 02:20:01 2017 +0000 Bug 18181: Can't tell which subscriptions already have a routing list if seeing all subs attached to a biblio To test: 1) Go to Serials -> search for a subscription 2) Add a new routing list for a subscription 3) After saving, you should be redirected to the subscription detail page 4) Click Serial collection on the left sidebar menu 5) Notice there is a button that says 'Edit routing list' next to this subscription in the first table 6) Click 'See any subscription attached to this biblio' link 7) Notice it no longer says edit next to this subscription, it says 'Create routing list' 8) Apply patch and refresh page 9) Should now show 'Edit' button like expected Sponsored-by: Catalyst IT Signed-off-by: S?verine QUEUNE Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: serials/serials-collection.pl | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 16:32:27 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 14:32:27 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-746-g8bb7769 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 8bb7769cad1d9be8c2b8b6a3412bb5f5ede171bd (commit) via 3c81b82b4b4baf930ff76cb21a041480b1404a6b (commit) via 8d2d59190a4c07f3f04db8c69ec830acac7c801d (commit) via 3f7139d0864b06e5c13ca7529df657d3a2eb3329 (commit) from 305c804ec95b4c15e12f1bae16f0f4c0b338bcb5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8bb7769cad1d9be8c2b8b6a3412bb5f5ede171bd Author: Jonathan Druart Date: Tue Mar 7 15:52:03 2017 -0300 Bug 4969: Do not display the new link if we are seeing all baskets of a given vendor Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 3c81b82b4b4baf930ff76cb21a041480b1404a6b Author: Jonathan Druart Date: Tue Mar 7 15:45:57 2017 -0300 Bug 4969: Do not jump to the top on click Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 8d2d59190a4c07f3f04db8c69ec830acac7c801d Author: Jonathan Druart Date: Tue Mar 7 15:44:57 2017 -0300 Bug 4969: Cursor should be pointer for links Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 3f7139d0864b06e5c13ca7529df657d3a2eb3329 Author: Aleisha Amohia Date: Fri Mar 3 01:32:54 2017 +0000 Bug 4969: Toggle showing of all/active vendors This patch provides the functionality to hide inactive vendors from the vendor search. To test: 1) Make sure at least one vendor is inactive 2) Do a vendor search 3) Confirm the link to show only active vendors works, and is replaced with a link to show all vendors when clicked 4) Confirm the link to show all vendors works, and is replaced with a link to show only active vendors when clicked Sponsored-by: Catalyst IT Followed test plan, works as expected Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/acqui/booksellers.tt | 26 +++++++++++++++++--- 1 file changed, 23 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 16:33:21 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 14:33:21 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-747-g50f4024 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 50f402405591ceb77c510f7cacd62749ac9e3b59 (commit) from 8bb7769cad1d9be8c2b8b6a3412bb5f5ede171bd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 50f402405591ceb77c510f7cacd62749ac9e3b59 Author: David Cook Date: Tue Jan 19 16:37:09 2016 +1100 Bug 15541 - Prevent normalization during matching/import process This patch allows you to use the "qualifier,qualifier" syntax in the Record Matching Rules "Search Index" when using the QueryParser. While QueryParser doesn't support this syntax, it will now fallback correctly to non-QueryParser functionality. Without the patch, your search will just fail silently. This patch also adds a "skip_normalize" option to C4::Search::SimpleSearch(), and uses the option during C4::Matcher::get_matches. This prevents the s/:/=/g and s/=/:/g normalization. This normalization is heavy-handed, and while it is necessary sometimes to generate a valid CCL query or QueryParser query, C4::Matcher::get_matches() already produces a valid CCL query, so we don't need to do this normalization. Additionally, this normalization causes problems when you use a Zebra register which isn't normalized: namely the "u" register. Strings are stored "as is", so http://localhost/koha/resource/1 is stored as is during indexing. When you search, you need to pass the exact same thing through the query to get a match. Using http=//localhost/koha/resource/1 in your query will yield zero results. _TEST PLAN_ 0) Apply patch 1) Create a Record Matching Rule in Koha with the following details: Matching rule code: TEST Description: Test Match threshold: 100 Record type: Bibliographic Match point 1: Search index: id-other,st-urx Score: 100 Tag: 024 Subfields: a Normalization rule: None 2) Create a record in Koha with an indexable URI 2a) Default framework 2b) 024 $a http://koha-community.org/test $2 uri 2c) 040 $c test 2d) 245 $a This is a test record 2e) 942 $c Books 2f) Save (save again if cautioned about missing fields as these should autofill) 3) Do a full re-index of Zebra 4) Download your record from Koha as a .mrc file (ie isomarc, binary marc, etc) 5) Go to "Stage MARC records for import" 5a) Upload your .marc file. 5b) Change your "Record matching rule" to "Test" 5c) Click Stage for import 9) It should say "1 records with at least one match in catalog per matching rule "Test". NOTE: For completeness, you can go through this process on a clean master branch, and note that it will say '0 records with at least one match in catalog per matching rule "TEST"' Signed-off-by: Alex Buckley Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Matcher.pm | 6 ++++-- C4/Search.pm | 9 +++++---- Koha/SearchEngine/Elasticsearch/Search.pm | 6 +++++- 3 files changed, 14 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 16:34:59 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 14:34:59 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-750-ga31f6e6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a31f6e6171f2e152a15d7738c4d718451e8e7da9 (commit) via 63fec9c094f419dc38e31f01e52e6d234ac8019d (commit) via c2c3c110053803a486f89cee8cae2a9b24088f7f (commit) from 50f402405591ceb77c510f7cacd62749ac9e3b59 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a31f6e6171f2e152a15d7738c4d718451e8e7da9 Author: Kyle M Hall Date: Wed Mar 1 11:24:54 2017 +0000 Bug 14365 - Change 'Last modified' to 'Last edit' for terseness Signed-off-by: Cab Vinton Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 63fec9c094f419dc38e31f01e52e6d234ac8019d Author: Kyle M Hall Date: Tue Feb 7 15:55:30 2017 +0000 Bug 14365 - SQL Reports Last Edit Date column - Show in interface Test Plan: 1) Apply these patches 2) Modify a saved sql report 3) Note the "Last modified" column is updated 4) Run the report 5) Note the "Last run" column is updated Signed-off-by: Cab Vinton Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit c2c3c110053803a486f89cee8cae2a9b24088f7f Author: Kyle M Hall Date: Tue Feb 7 16:01:12 2017 +0000 Bug 14365 - Populate never used saved_sql column last_run when execute_query is called Signed-off-by: Cab Vinton Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Reports/Guided.pm | 9 ++++-- .../en/modules/reports/guided_reports_start.tt | 6 +++- misc/cronjobs/runreport.pl | 3 +- opac/svc/report | 2 +- reports/guided_reports.pl | 2 +- svc/report | 2 +- t/db_dependent/Reports/Guided.t | 30 +++++++++++++++++++- 7 files changed, 45 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 16:37:13 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 14:37:13 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-752-gb88f084 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b88f0846e603b7026f87895b73940c53f2a703c9 (commit) via 5887566f463cf37d56b496d1138935e4c20c0ab8 (commit) from a31f6e6171f2e152a15d7738c4d718451e8e7da9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b88f0846e603b7026f87895b73940c53f2a703c9 Author: Kyle M Hall Date: Thu Jun 16 15:41:43 2016 +0000 Bug 16757 - Add support for Fee Paid to SIP cli emulator for testing Signed-off-by: Rhonda Kuiper Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 5887566f463cf37d56b496d1138935e4c20c0ab8 Author: Kyle M Hall Date: Thu Jun 16 14:50:44 2016 +0000 Bug 16757 - Add ability to pay fee by id for SIP2 The SIP protocol allows for a Fee Paid message to specify a fee identifier in the CG field. While this field is read and passed to C4::SIP::ILS::pay_fee, it is not passed along to C4::SIP::ILS::Transaction::FeePayment::pay and is thus not used. We should enable this functionality in Koha now that accountlines each have a unique identifier that can be passed along to the payment requestor via the AV field line items added by bug 14512. Test Plan: 1) Create a fee in Koha 2) Ensure your SIP2 server is running and configured correctly 3) Send a 37 Fee Paid message to Koha's SIP server with the accountlines_id for that fee in the CG fee identifier field, along with the other required fields. 4) Note that specific fee was paid in Koha Signed-off-by: Rhonda Kuiper Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/SIP/ILS.pm | 8 ++-- C4/SIP/ILS/Transaction/FeePayment.pm | 25 +++++++++-- misc/sip_cli_emulator.pl | 79 +++++++++++++++++++++++++++++++++- 3 files changed, 103 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 16:38:36 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 14:38:36 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-753-g39bcba5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 39bcba540a6c00fc374284dc025297a568befed6 (commit) from b88f0846e603b7026f87895b73940c53f2a703c9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 39bcba540a6c00fc374284dc025297a568befed6 Author: Luke Honiss Date: Thu Jan 19 22:52:49 2017 +0000 Bug 17945 - Breadcrumbs broken on opac-serial-issues.pl ==TEST PLAN== 1) Make a subscription with a record 2) Search and view the record in OPAC 3) Click on the subscription tab and click more details 4) The breadcrumb will say 'Detals for' without the record name 5) Apply patch 6) Refresh the page 7) The breadcrumb will display the name of the record (fixed small error) Signed-off-by: Sonia BOUIS Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: opac/opac-serial-issues.pl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 16:48:30 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 14:48:30 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-755-g512f79b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 512f79b87cb23346a785278d51b3c7a9c3983622 (commit) via 2ba1e472e6d9b194c2fec4bc7844c673cc967cad (commit) from 39bcba540a6c00fc374284dc025297a568befed6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 512f79b87cb23346a785278d51b3c7a9c3983622 Author: Jonathan Druart Date: Tue Mar 21 07:30:26 2017 -0300 Bug 18283: 'sql' should be 'SQL' Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 2ba1e472e6d9b194c2fec4bc7844c673cc967cad Author: Nick Clemens Date: Thu Mar 16 11:28:29 2017 -0400 Bug 18283 - Display improvements on report results - hide code and change wording This patch makes small display improvements to the report results page. -Add toggle link for SQL code -Change results count wording -Add 'Notes:' label report notes To test: 1 - Apply patch 2 - Run some reports 3 - Check that results page makes sense 4 - Hide and display code and ensure toggle works Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Christopher Brannon Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/includes/reports-toolbar.inc | 4 ++++ .../prog/en/modules/reports/guided_reports_start.tt | 13 ++++++++++--- 2 files changed, 14 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 16:54:30 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 14:54:30 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-756-gcd812cb Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via cd812cb42136fb0dda895f0af69f8abd4fe07ac0 (commit) from 512f79b87cb23346a785278d51b3c7a9c3983622 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit cd812cb42136fb0dda895f0af69f8abd4fe07ac0 Author: Marcel de Rooy Date: Mon Feb 27 10:57:18 2017 +0100 Bug 18174: Add update to Koha::Object Since Koha::Objects has a update method, we should allow it too in Koha::Object. Note that it is just redirecting to DBIx immediately. Changed the exception when the method generates an error. The previous code suggested that the method was not found, but this is not the case. Test plan: Run t/db_dependent/Koha/Object.t Followed test plan, tests passes OK. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/Object.pm | 5 ++--- t/db_dependent/Koha/Object.t | 29 +++++++++++++++++++++++++++-- 2 files changed, 29 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 16:56:31 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 14:56:31 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-757-gd455dc3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d455dc31d4f423a154009823b0b8db925c5efe48 (commit) from cd812cb42136fb0dda895f0af69f8abd4fe07ac0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d455dc31d4f423a154009823b0b8db925c5efe48 Author: Marcel de Rooy Date: Thu Mar 2 14:24:17 2017 +0100 Bug 18200: Fix a potential issue with preceding space in GetMarcUrls Trims the URL in order prevent prefixing a space with http:// Normally you won't have a preceding space here, but I saw it happening one day and it does not cost much to resolve it. Bonus: Adding few simple tests in t/db_dependent/Biblio.t. Test plan: [1] Run t/db_dependent/Biblio.t [2] Add a 856$u with preceding space (MARC21) [3] Check opac-detail, Online access with OPACXSLTDetailsDisplay empty. Signed-off-by: Marcel de Rooy Followed test plan, works as expected Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Biblio.pm | 1 + t/db_dependent/Biblio.t | 17 ++++++++++++++--- 2 files changed, 15 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 16:57:35 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 14:57:35 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-758-g9bc62c4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 9bc62c4e1dca2fba92f63dfcbd472db88dc7ff80 (commit) from d455dc31d4f423a154009823b0b8db925c5efe48 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9bc62c4e1dca2fba92f63dfcbd472db88dc7ff80 Author: Marcel de Rooy Date: Mon Mar 20 10:32:14 2017 +0100 Bug 18302: Release team 17.05 Changes to about.tt in sections release team and development team. Notes: [1] We do not have a QA manager in 17.05 any more. [2] Martin Renvoize has been added to the QA team of 16.11 after the election; this was not adjusted in about, but has been added in the Development team section now. Test plan: Compare about:Koha team with roles for 17.05 page on the wiki. Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 40 +++++++++++----------- 1 file changed, 20 insertions(+), 20 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 17:08:13 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 15:08:13 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-760-g2370695 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2370695fb9efa680251ddd9cb1e0e271fcf4935e (commit) via 37550a1d690c91465789920f64800c28bdc9a6ec (commit) from 9bc62c4e1dca2fba92f63dfcbd472db88dc7ff80 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2370695fb9efa680251ddd9cb1e0e271fcf4935e Author: Marcel de Rooy Date: Mon Mar 20 21:58:49 2017 +0100 Bug 18304: [QA Follow-up] Add id to paragraph tag See Bugzilla, comment 4. Note: the id is unique in the Koha codebase (git grepped). Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall commit 37550a1d690c91465789920f64800c28bdc9a6ec Author: Marcel de Rooy Date: Mon Mar 20 12:58:42 2017 +0100 Bug 18304: Do not mail cart or list contents to the library Sometimes we receive mails from patrons, sent from opac-sendbasket or opac-sendshelf. Instead of placing a hold on books they send the contents of the cart (or even a list). This patch simply puts a note on both forms saying that they should not use the mail to request or renew books. If both options are disabled on the OPAC, the message is not shown. Test plan: [1] Enable RequestOnOPAC. [2] Put a book in the cart. [3] Open the cart, click on Send. Verify presence of the message. [4] Open a list. [5] Click on Send list. Verify presence of the message. Signed-off-by: Marcel de Rooy Signed-off-by: Jesse Maseto Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendbasketform.tt | 2 ++ koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelfform.tt | 2 ++ 2 files changed, 4 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 17:08:55 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 15:08:55 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-768-g08a9deb Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 08a9deb1c07c075085b391dff7c573b67dceafc2 (commit) via f8144691cc47aeb37e976f1d4c6dcb2b75510d26 (commit) via da51c004964ae3b83f1878e3eb523981995773e9 (commit) via 22f1f3a26a97a74b4468b875da58c7b4fd1a6409 (commit) via 2f4e57b20fb3843d7a4db19dca320e7992e5e03e (commit) via 2ccdbcd0f56ee865c6901d2ec397132f1ef5879a (commit) via d0e40439cd0c009ad41dc8770a94cd775c02eafb (commit) via 9b92ce4cd173e8249b02a6b62ad3b95aea1d6c5f (commit) from 2370695fb9efa680251ddd9cb1e0e271fcf4935e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 08a9deb1c07c075085b391dff7c573b67dceafc2 Author: Martin Renvoize Date: Thu Mar 23 14:54:38 2017 +0000 Bug 12026: [QA Follow-up] Add Tests for autocreate https://bugs.koha-community.org/show_bug.cgi?id=12026 Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Kyle M Hall commit f8144691cc47aeb37e976f1d4c6dcb2b75510d26 Author: Marcel de Rooy Date: Thu Mar 23 11:56:50 2017 +0100 Bug 12026: [QA Follow-up] Fix a POD line Still refers to a removed parameter of _autocreate. Signed-off-by: Marcel de Rooy Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Kyle M Hall commit da51c004964ae3b83f1878e3eb523981995773e9 Author: Martin Renvoize Date: Wed Mar 22 13:54:46 2017 +0000 Bug 12026: [Rebase Follow-up] - Fix Test Signed-off-by: Marcel de Rooy Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Kyle M Hall commit 22f1f3a26a97a74b4468b875da58c7b4fd1a6409 Author: Marcel de Rooy Date: Tue Mar 21 10:27:03 2017 +0100 Bug 12026: [QA Follow-up] POD typo and tiny change in AddMember_Opac [1] Correct xml error in POD Copy-pasting this example from Auth_with_shibboleth.pm into koha-conf.xml did not work. We need a closing tag ;) [2] If AddMember_Opac calls AddMember_Auto, there is no need to call fixup_cardnumber. Adding trivial test for AddMember_Auto in Members.t. Signed-off-by: Marcel de Rooy Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Kyle M Hall commit 2f4e57b20fb3843d7a4db19dca320e7992e5e03e Author: Mirko Tietgen Date: Tue Nov 15 11:36:33 2016 +0100 Bug 12026: Fix small errors When running tests I got two errors. Do these changes make sense? Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Kyle M Hall commit 2ccdbcd0f56ee865c6901d2ec397132f1ef5879a Author: Martin Renvoize Date: Wed Oct 12 10:08:31 2016 +0000 Bug 12026: [Followup] Rebasing Signed-off-by: Mirko Tietgen Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Kyle M Hall commit d0e40439cd0c009ad41dc8770a94cd775c02eafb Author: Martin Renvoize Date: Wed Jul 30 14:53:27 2014 +0000 Bug 12026: [Follow up] Added Documentation Updated to work with match point selection - The base bug that this patch enhances has added the ability to choose your match point in the configuration file. This patch adds code to take that change into account. Signed-off-by: Mirko Tietgen Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Kyle M Hall commit 9b92ce4cd173e8249b02a6b62ad3b95aea1d6c5f Author: Jesse Weaver Date: Wed Apr 2 15:53:03 2014 +0000 Bug 12026: Adds auto-provisioning to shibboleth - Adds the option to map shibboleth attributes to koha user columns and allows mapping to auto create non-existant users Signed-off-by: Mirko Tietgen Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Olli-Antti Kivilahti Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Auth_with_shibboleth.pm | 41 ++++++++++-- C4/Members.pm | 21 ++++-- t/Auth_with_shibboleth.t | 156 ++++++++++++++++++++++++++++++-------------- t/db_dependent/Members.t | 20 ++++-- 4 files changed, 173 insertions(+), 65 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 17:13:55 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 15:13:55 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-769-g70377b3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 70377b375794dffa4ff18bd9b7a7f37060cf295c (commit) from 08a9deb1c07c075085b391dff7c573b67dceafc2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 70377b375794dffa4ff18bd9b7a7f37060cf295c Author: Nick Clemens Date: Wed Mar 1 14:30:11 2017 +0000 Bug 18189 - Elasticsearch sorting broken To test: 1 - Have ES enabled and biblios and authorities indexed 2 - Perform a catalog search 3 - Try to sort results by author, it will fail 4 - Perform an authority search with sorting enabled, it will fail 5 - Apply patch 6 - Reindex, deleting current indexes perl /home/vagrant/kohaclone/misc/search_tools/rebuild_elastic_search.pl -d -v 7 - Repeat 3&4, they should succeed Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/SearchEngine/Elasticsearch.pm | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 17:14:32 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 15:14:32 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-771-gd28c215 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d28c2152abd1ba3b5dfd8af1ceffab094c552bfa (commit) via a7bdc6eb3e2fc7de7158d938e37552eb75bd0cc7 (commit) from 70377b375794dffa4ff18bd9b7a7f37060cf295c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d28c2152abd1ba3b5dfd8af1ceffab094c552bfa Author: Jonathan Druart Date: Tue Mar 21 16:55:37 2017 -0300 Bug 17014: Simplify some code Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit a7bdc6eb3e2fc7de7158d938e37552eb75bd0cc7 Author: Owen Leonard Date: Mon Aug 1 12:33:24 2016 -0400 Bug 17014 - Remove more event attributes from patron templates There are many patron-related templates which still use event attributes to define events. This patch updates these templates so that events are defined in JavaScript. To test apply the patch and check out to a patron. - From the Print menu in the toolbar, choose "Print summary." The patron summary page should open and the print dialog should be automatically triggered. - From the Print menu in the toolbar, choose "Print slip." The patron slip page should open and the print dialog should be automatically triggered. - From the Print menu in the toolbar, choose "Print quick slip." The patron quick slip page should open and the print dialog should be automatically triggered. - Click the patron's "Fines" tab in the left-hand sidebar and then choose the "Account" tab. -- Click the "Print" button for an account payment (the link should point to printfeercpt.pl). A print receipt page should open and the print dialog should be automatically triggered. -- Follow the same procedure for a transaction which is not an account payment (the link should point to printinvoice.pl). - Click the "Create manual invoice" tab. -- Select one of the "type" choices. Doing so should automatically populate the "Description" field with the corresponding code. -- If necessary, define one or more values for the MANUAL_INV authorized value and confirm that those invoice types work as well. - From the patron's "Pay fines" tab, click the "Pay amount" button. In the "collect from patron" field, enter any combination of letters, numbers, and symbols. When you tab away from that field your text should be reformatted to currency format. - From the patrons home page, change the filter in the left-hand sidebar and submit it. The correct results should be returned. Signed-off-by: EricGosselin Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/includes/slip-print.inc | 6 +++--- .../prog/en/modules/circ/printslip.tt | 2 +- .../prog/en/modules/members/maninvoice.tt | 21 +++++++++----------- .../prog/en/modules/members/member.tt | 3 ++- .../prog/en/modules/members/moremember-print.tt | 5 +---- .../prog/en/modules/members/moremember-receipt.tt | 2 +- .../prog/en/modules/members/paycollect.tt | 16 +++++++-------- .../prog/en/modules/members/printfeercpt.tt | 4 +--- .../prog/en/modules/members/printinvoice.tt | 7 +++---- 9 files changed, 29 insertions(+), 37 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 17:17:26 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 15:17:26 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-777-g36cfb22 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 36cfb22621c5afa1d1e094a51e9d68937d1bf7d5 (commit) via dd54e970a593e758fa7d914e1241b22196cb6f7c (commit) via e610025babae7efac8415437fa7aee3fad9dce0a (commit) via 5d6ee0c7a0de306d68a66a23d7c2414d7274de74 (commit) via d777df6b6f51dc65e6963c4e9ab0ed54b811813a (commit) via 46291a0c9f924f5f73824c18b1ee06c206ae9fb4 (commit) from d28c2152abd1ba3b5dfd8af1ceffab094c552bfa (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 36cfb22621c5afa1d1e094a51e9d68937d1bf7d5 Author: Jonathan Druart Date: Wed Mar 29 16:39:36 2017 -0300 Bug 17828: return $self to be consistent Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit dd54e970a593e758fa7d914e1241b22196cb6f7c Author: Jonathan Druart Date: Tue Mar 28 11:39:09 2017 -0300 Bug 17828: Use Koha::Patron::Attributes instead of _resultset Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit e610025babae7efac8415437fa7aee3fad9dce0a Author: Tomas Cohen Arazi Date: Mon Mar 27 12:47:14 2017 -0300 Bug 17828: (QA followup) Add ->type and reuse it Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 5d6ee0c7a0de306d68a66a23d7c2414d7274de74 Author: Tomas Cohen Arazi Date: Thu Mar 23 12:07:49 2017 -0300 Bug 17828: (followup) Add Test::Exception as dependency Test::Exception is available on Jessie and already installed when koha-common gets installed Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit d777df6b6f51dc65e6963c4e9ab0ed54b811813a Author: Tomas Cohen Arazi Date: Fri Dec 30 11:12:32 2016 -0300 Bug 17828: Overload Koha::Patron::Attribute->store to check for unique_id and repeatable This patch introduces a Koha::Patron::Attribute->store method that does the required check for the corresponding Koha::Patron::Attribute::Type and raises an exception if trying to store more than one unique attribute code/value combination, and another exception for non-repeatable attribute types being stored while already existing on the DB. This patch introduces exception definitions for that purpose. To test: - Apply the unit tests patches - Run: $ prove t/db_dependent/Koha/Patron/Attributes.t => FAIL: Tests fail - Apply this patch - Run: $ prove t/db_dependent/Koha/Patron/Attributes.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 46291a0c9f924f5f73824c18b1ee06c206ae9fb4 Author: Tomas Cohen Arazi Date: Fri Dec 30 11:10:33 2016 -0300 Bug 17828: Unit tests for Koha::Patron::Attribute->store Unit tests for an overloaded Koha::Patron::Attribute->store that checks attribute type's uniqueness property and raises an exception conveniently. It also tests for repeatable attribute type's property. Test plan on the implementing patch. Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Installer/PerlDependencies.pm | 67 ++++++------ Koha/Exceptions/Patron/Attribute.pm | 20 ++++ Koha/Patron/Attribute.pm | 85 ++++++++++++++++ t/db_dependent/Koha/Patron/Attributes.t | 170 ++++++++++++++++++++++++++++++- 4 files changed, 310 insertions(+), 32 deletions(-) create mode 100644 Koha/Exceptions/Patron/Attribute.pm hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 17:17:58 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 15:17:58 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-779-g2266733 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2266733767536ddf47f31821ba87d860c246700f (commit) via 60ba1bf5dd26b75d86f31325183eea4359702f84 (commit) from 36cfb22621c5afa1d1e094a51e9d68937d1bf7d5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2266733767536ddf47f31821ba87d860c246700f Author: Tomas Cohen Arazi Date: Thu Dec 29 11:40:57 2016 -0300 Bug 17825: (followup) Remove unused function AttributeTypeExists Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall commit 60ba1bf5dd26b75d86f31325183eea4359702f84 Author: Tomas Cohen Arazi Date: Thu Dec 29 11:32:27 2016 -0300 Bug 17825: Remove the use of AttributeTypeExists from opac-user.pl With the introducion of Koha::Object-based Koha::Patron::Attribute::Type(s) there's no need for using this function. This patch replaces it with a regular ->search + ->count call. To test: - Have a user with checkouts logged into the OPAC on the opac-user.pl page - Set the SHOW_BCODE attribute to 'no' on the staff interface for the user. - Reload opac-user.pl => SUCCESS: The barcode is not shown for checked out items. - Set the SHOW_BCODE atttribute to 'yes' on the staff interface for the user. - Reload opac-user.pl => SUCCESS: The barcode is shown for checked out items. - Delete the Patron attribute type SHOW_BCODE - Reload opac-user.pl => SUCCESS: No barcode is shown for checked out items - Sign off :-D Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: C4/Members/AttributeTypes.pm | 16 ---------------- opac/opac-user.pl | 4 +++- t/Members_AttributeTypes.t | 10 +--------- 3 files changed, 4 insertions(+), 26 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 31 21:13:36 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 31 Mar 2017 19:13:36 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v16.11.00-780-g360949f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 360949f37927ce87dc4326437c2414fc73bae845 (commit) from 2266733767536ddf47f31821ba87d860c246700f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 360949f37927ce87dc4326437c2414fc73bae845 Author: Jonathan Druart Date: Fri Mar 31 16:12:48 2017 -0300 Fix number of tests in Circulation.t ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Circulation.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository