[koha-commits] main Koha release repository branch master updated. v16.11.00-513-g50c5708

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  50c5708fe8ed74e22d78d9acb81080c7840954dc (commit)
       via  f7dbe1751c2e99a3e573038f2f8c90127a832ddf (commit)
       via  77337a2ab537843eab70cc06b8bc2531ad2014dc (commit)
      from  11bae489bc85a9463712c9caafd2caf7b63155d9 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 50c5708fe8ed74e22d78d9acb81080c7840954dc
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Fri Mar 3 16:45:22 2017 +0000

    Bug 17260 - DBRev 16.12.00.011
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit f7dbe1751c2e99a3e573038f2f8c90127a832ddf
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Feb 24 08:08:30 2017 +0000

    Bug 17260: Update existing installs
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 77337a2ab537843eab70cc06b8bc2531ad2014dc
Author: Blou <philippe.blouin at inlibro.com>
Date:   Fri Jan 27 16:51:26 2017 +0000

    Bug 17260: updatedatabase.pl fails on invalid entries in ENUM and BOOLEAN columns
    
    The loading of file admin/searchengine/elasticsearch/mappings.yaml
    specifies 'type' as empty, which fails with Mysql 5.7+ which is more
    stringent.
    
    Also, forcing an empty value into a boolean also fails.
    
    Both issues arise when updatedatabase.pl hit 3.23.00.050.
    
    NOTE: both issues could also be resolved by actually setting values in
          the load file. This doesn't make this solution incorrect, though.
    
    To Test/reproduce:
    -1) Happens with Mysql 5.7.4.  Maybe earlier, but certainly at
        that point. Use a Xenial kohadevbox to more easily test.
    0) Find a database on 3.22 or earlier, save it.
        a) place
               sql_mode=IGNORE_SPACE,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION
           into the [mysqld] section of /etc/mysql/mysql.conf.d/mysqld.cnf
        b) restart you mysql server
        c) drop the db and recreate it
        d) checkout the 3.22.x branch
        e) do a web install
        f) remove the added sql_mode
        g) restart the mysql server
    1) Set your code base to master
    2) run updatedatabase.pl
    3) See the errors on 3.23.00.050
    4) Apply the patch
    5) Reload the 3.22 db.
       a) repeat steps 0(a)-0(g)
       b) don't forget the caching issues
    6) succeed with updatedatabase.pl
    7) drop the db and recreate it
    8) run the web installer
    9) notice no issues either.
    10) run koha qa test tools
    
    NOTE: This bug only solved the upgrade portion.
          I added the kohastructure.sql change as well.
          I confirmed that all the code changes were
          triggered with this test plan.
    
    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    Signed-off-by: Mehdi Hamidi <mehdi.hamidi at inlibro.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha.pm                                |    2 +-
 Koha/SearchEngine/Elasticsearch.pm     |    2 +-
 installer/data/mysql/kohastructure.sql |    2 +-
 installer/data/mysql/updatedatabase.pl |   13 ++++++++++++-
 4 files changed, 15 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
main Koha release repository