[koha-commits] main Koha release repository branch master updated. v16.11.00-533-gabdf231
Git repo owner
gitmaster at git.koha-community.org
Fri Mar 3 18:28:10 CET 2017
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via abdf2319cd0fca27046699ae029107e92bb7f02f (commit)
via b4cd5faeb09b4872b5ea413e0aace3ebbaae26c5 (commit)
via ea321eaf3d6023d8d8b0fbb6ed4a85051f78d60b (commit)
via 60a0e155a1586531bff220766704f0c9699cfb16 (commit)
via e8d34c2bdd741cdfbe9cb483740d645aef396f9a (commit)
via ce55b024467f5d1da92a97c1dc058fbbd593b781 (commit)
via 286be46e8a8c126c5a23dd16e310d11253378da5 (commit)
via 4f72b06e5d5807a88b243e12fe4085e617e822c8 (commit)
via bfe63a1e73bcfb57d6e2c41b98208419ba00a71f (commit)
from e9d5615e70056cd887b9471827611a78275016ab (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit abdf2319cd0fca27046699ae029107e92bb7f02f
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Mon Feb 27 13:21:18 2017 +0100
Bug 16966: [QA Follow-up] Check count, not size in template
The method size is not covered by tests at koha-tmpl/intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt line 163.
The method size is not covered by tests at koha-tmpl/intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt line 183.
Script cleanborrowers passes patrons_to_delete and patrons_to_anonymize to
the template. One is an array ref where we should use 'size', the other is a
Koha::Patrons object where we should use 'count'.
If we don't, we will not anonymize a lot of records ;)
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit b4cd5faeb09b4872b5ea413e0aace3ebbaae26c5
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Feb 24 12:34:26 2017 +0100
Bug 16966: move parameters to hashref
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit ea321eaf3d6023d8d8b0fbb6ed4a85051f78d60b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Feb 24 12:25:33 2017 +0100
Bug 16966: Fix small QA issues
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 60a0e155a1586531bff220766704f0c9699cfb16
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Feb 17 10:39:09 2017 +0100
Bug 16966: Teach K::S::R::OldIssue its Koha objects class
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit e8d34c2bdd741cdfbe9cb483740d645aef396f9a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Dec 20 12:15:10 2016 +0100
Bug 16966: The method should return a Koha::Patrons object
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit ce55b024467f5d1da92a97c1dc058fbbd593b781
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Dec 20 10:08:35 2016 +0000
Bug 16966: Make the tests pass again
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 286be46e8a8c126c5a23dd16e310d11253378da5
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Jul 22 17:25:24 2016 +0100
Bug 16966: Koha::Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise
The C4::Members::GetBorrowersWithIssuesHistoryOlderThan subroutine is supposed
to return the patrons with an issue history older than a given date.
It would make more sense to return a list of Koha::Patrons.
On the way, the code from AnonymiseIssueHistory will be moved as well to
anonymise_issue_history.
Note that these 2 subroutines are strongly linked: one is used to know the
number of patrons we will anonymise the history, the other one is used to
anonymise the issues history. The problem is that the first one is not used to
do the action, but only for displayed purpose.
In some cases, these 2 values can differ, which could be confusing.
Case 1:
The logged in librarian is not superlibrarian and IndependentBranches is set:
if 2+ patrons from different libraries match the date parameter, the interface
will display "Checkout history for 2 patrons will be anonymized", when actually
only 1 will be.
Case 2:
If 2+ patrons match the date parameter but one of them has his privacy set to
forever (privacy=0), the same issue will appear.
This patch moves the code from C4::Members::GetBorrowersWithIssuesHistoryOlderThan
to Koha::Patrons->search_patrons_to_anonymise and from
C4::Circulation::AnonymiseIssueHistory to
Koha::Patrons->anonymise_issue_history
Test plan:
1/ Confirm the 2 issues and make sure they are fixed using the Batch
patron anonymization tool (tools/cleanborrowers.pl)
2/ At the OPAC, use the 'Immediate deletion' button to delete all your
reading history (regardless the setting of the privacy rule)
3/ Use the cronjob script (misc/cronjobs/batch_anonymise.pl) to
anonymise patrons.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 4f72b06e5d5807a88b243e12fe4085e617e822c8
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Jul 22 16:43:56 2016 +0100
Bug 16966: Koha::Patrons - Move AnonymiseIssueHistory tests
The next patch will move C4::Circulation::AnonymiseIssueHistory and
C4::Members::GetBorrowersWithIssuesHistoryOlderThan to Koha::Patrons
This patch move the history anonymisation code to the Patrons.t test
file and the entire subtest related to StoreLastBorrower to
StoreLastBorrower.t
It just moves and add some minor adjustements.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit bfe63a1e73bcfb57d6e2c41b98208419ba00a71f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Jul 22 15:57:26 2016 +0100
Bug 16966: GetBorrowersWithIssuesHistoryOlderThan - Highlight the existing issue in tests
If IndependentBranches is set, the code is buggy. This patch only
highlight the bug by providing a test.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Circulation.pm | 44 ---
C4/Members.pm | 46 ----
Koha/Patrons.pm | 64 ++++-
Koha/Schema/Result/OldIssue.pm | 4 +-
.../prog/en/modules/tools/cleanborrowers.tt | 12 +-
.../opac-tmpl/bootstrap/en/modules/opac-privacy.tt | 6 +-
misc/cronjobs/batch_anonymise.pl | 7 +-
opac/opac-privacy.pl | 15 +-
t/db_dependent/Circulation/AnonymiseIssueHistory.t | 279 --------------------
t/db_dependent/Circulation/StoreLastBorrower.t | 144 ++++++++++
t/db_dependent/Koha/Patrons.t | 183 ++++++++++++-
tools/cleanborrowers.pl | 23 +-
12 files changed, 419 insertions(+), 408 deletions(-)
delete mode 100644 t/db_dependent/Circulation/AnonymiseIssueHistory.t
create mode 100644 t/db_dependent/Circulation/StoreLastBorrower.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list