[koha-commits] main Koha release repository branch master updated. v16.11.00-563-g2470e22
Git repo owner
gitmaster at git.koha-community.org
Mon Mar 20 14:08:13 CET 2017
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 2470e225d8791d1b87daaebde2591caab6427d49 (commit)
via 3844d6f36bcee2b0e2102c2df1323cdd86940303 (commit)
from 13de29ad4465b964e37d4f460f5c9145e23939a1 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 2470e225d8791d1b87daaebde2591caab6427d49
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Mar 15 14:52:49 2017 -0300
Bug 18275: Do not rely on CGI param userid to log a user in if auth is not required
From opac/opac-memberentry.pl, authnotrequired is set.
That means a patron can access the page without being logged in. It is
used on this page for the self registration feature.
From C4::Auth::get_template_and_user, we have
$userid = $q_userid;
$q_userid is previously set to the 'userid' CGI param.
We end up here if authonotrequired is set AND CGISESSID does not exist.
Test plan:
- Run:
$ prove t/db_dependent/Auth.t
=> FAIL: Regression test for checkauth fails
- Apply this patch
- Run:
$ prove t/db_dependent/Auth.t
=> SUCCESS: Tests pass.
- Sign off :-D
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 3844d6f36bcee2b0e2102c2df1323cdd86940303
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Mar 16 09:23:24 2017 -0300
Bug 18275: Regression test
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Auth.pm | 9 ++++-----
t/db_dependent/Auth.t | 27 ++++++++++++++++++++++++---
2 files changed, 28 insertions(+), 8 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list