[koha-commits] main Koha release repository branch master updated. v16.11.00-619-g382d086
Git repo owner
gitmaster at git.koha-community.org
Fri Mar 24 19:51:35 CET 2017
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 382d086ecdb220f882382bbb58b0121d0604d684 (commit)
via 3f2ade46ace082e69cb9f40f7cf241853e1897f8 (commit)
via a39fbd78e61d62b680f7e592effc903e344a928f (commit)
via 62249ff5734819a148bff267855b570387ea231a (commit)
via bd01041ac6985656ca1bf1f2a6b9d565e98bd61d (commit)
from 9c347a7f3571b36b8c3415e41cf567fa76f0ad56 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 382d086ecdb220f882382bbb58b0121d0604d684
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Mar 10 12:32:06 2017 -0300
Bug 17755: (followup) Override ->search to allow filtering by branchcode
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 3f2ade46ace082e69cb9f40f7cf241853e1897f8
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Jan 19 15:09:15 2017 -0300
Bug 17755: (QA followup) Return $self when appropriate
As failure situations raise exceptions that should be handled outside
the object class, methods should return $self so successive calls can be
chained nicely.
This patch makes methods return $self and adjusts the tests to reflect
this change.
Make sure tests pass:
- Run:
$ prove t/db_dependent/Koha/Patron/Attribute/Types.t
=> SUCCESS: Tests return green
- Sign off :-D
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit a39fbd78e61d62b680f7e592effc903e344a928f
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Oct 31 15:09:43 2016 -0300
Bug 17755: Introduce Koha::Patron::Attribute::Type(s)
This patch introduces the Koha::Object-based classes for handling
patron attribute types.
It also adds branch limitation handling to the
Koha::Patron::Attribute::Type class.
It is built on top of the new Koha::Object::Library::Limit class
that extends Koha::Object so it handles library limits.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 62249ff5734819a148bff267855b570387ea231a
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Dec 12 11:15:45 2016 -0300
Bug 17755: Unit tests
This patch introduces unit tests for Koha::Object::Library::Limit. It is
done this way because it needs to be instantiated to be usable.
To test:
- Run:
$ prove t/db_dependent/Koha/Patron/Attribute/Types.t
=> SUCCESS: Tests pass
- Sign off :-D
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit bd01041ac6985656ca1bf1f2a6b9d565e98bd61d
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Dec 12 14:17:44 2016 -0300
Bug 17755: Introduce Koha::Object::Limit::Library
This patch introduces a new class for extending Koha::Object using
multiple inheritance. It cannot be used standalone, it needs to be
used in Koha::Object implementations like this:
use base qw( Koha::Object Koha::Object::Limit::Library );
Its goal is to provide a single way and place to deal with this common
pattern in Koha's codebase.
As it happened with Koha::Object, that needed to be tested in a real object
class, this work was done on top of Koha::Patron::Attribute::Type implementation
and it is fully covered by the tests that are introduced for it.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
Koha/Exceptions.pm | 9 +-
Koha/Object/Limit/Library.pm | 188 +++++++++++
.../Currencies.pm => Patron/Attribute/Type.pm} | 31 +-
Koha/{Libraries.pm => Patron/Attribute/Types.pm} | 45 +--
t/db_dependent/Koha/Patron/Attribute/Types.t | 339 ++++++++++++++++++++
5 files changed, 574 insertions(+), 38 deletions(-)
create mode 100644 Koha/Object/Limit/Library.pm
copy Koha/{Acquisition/Currencies.pm => Patron/Attribute/Type.pm} (68%)
copy Koha/{Libraries.pm => Patron/Attribute/Types.pm} (51%)
create mode 100644 t/db_dependent/Koha/Patron/Attribute/Types.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list