[koha-commits] main Koha release repository branch master updated. v16.11.00-643-g3db855b
Git repo owner
gitmaster at git.koha-community.org
Fri Mar 24 19:58:12 CET 2017
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 3db855b872ccbf133e238ddc537b6f0b818c931e (commit)
via e06c1931872f2a54e2a12cf2b8468480e613ce5c (commit)
via ec9ac4d7b9873dd99b92212564b698dc6bf904b1 (commit)
via 3ce090781970c869d6d4c78f9e0eb4eb3e0d8ad2 (commit)
via ebe44fc7febfa248842bf1f50ccb1c961f31259b (commit)
via afb7b7dc2df5e2c0f7ebb4ed75777fef4a5ab12a (commit)
via f9a5fd005efa2567be99f9eb2f44e5e79641f74c (commit)
via e63e4bb35a67a2beed52139b2f149623526d5e23 (commit)
via c44a377d9cc44538b6a7134f48763184c9a110ba (commit)
via b6797fdc8708e73eee0cfd7562e55543ed4f5e3b (commit)
via bb039e0328e0151b78c752e7a7be2c6a1c4f7d3a (commit)
via 2811d8555d5dc409b8a358795d3f188c87fa950b (commit)
via 0fbc8620e2180f67270403d4c3a81d7334b3f62e (commit)
via dc6702e3cd9aa17b41880975823305f5d5aa553c (commit)
via c8889f0ff7cfb83422f0136faaf1be9cdec5515c (commit)
via 925e664f42ff9546624946258fe27263e6041fa3 (commit)
via bfa3f410320e6baad98f277a6cfd9b41a4d68dac (commit)
via 01506e0195266a0e6b6005c43b9763bf4a09dd78 (commit)
via 2eda977de72434643863301726c5aa9f51be7b36 (commit)
via 0a40e0c60ff2ac405960cfd34033dd3d5896ac08 (commit)
via 1fa5660dbcd015b20cd3059dfdba11c0b4f345bd (commit)
via 21e496bd7bcf3cd3f8826410384005e0cabc17d4 (commit)
from 7b5c8cbf079725381341cea5494717d58735ca9b (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 3db855b872ccbf133e238ddc537b6f0b818c931e
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Mar 24 18:49:15 2017 +0000
Bug 13757 - DBRev 16.12.00.016
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit e06c1931872f2a54e2a12cf2b8468480e613ce5c
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Mar 22 18:51:48 2017 -0300
Bug 13757: (QA followup) Filter out non-editable params before storing
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit ec9ac4d7b9873dd99b92212564b698dc6bf904b1
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Mar 22 16:22:53 2017 -0300
Bug 13757: (QA followup) Exclude empty attributes from rendering if non-editable
In self registration opac displayable (and not editable) attributes are
displayed as empty. This an empty value is passed to the template for
creating an empty input and it shouldn't when the attribute is not
editable.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 3ce090781970c869d6d4c78f9e0eb4eb3e0d8ad2
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Feb 16 16:02:48 2017 -0300
Bug 13757: Attribute with value 0 should be stored
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit ebe44fc7febfa248842bf1f50ccb1c961f31259b
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Feb 16 16:02:22 2017 -0300
Bug 13757: (regression test) Attribute with value 0 should be stored
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit afb7b7dc2df5e2c0f7ebb4ed75777fef4a5ab12a
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Feb 3 15:22:57 2017 -0300
Bug 13757: Better display for attr changes in members-update.pl
This patch changes the way changed attributes are displayed for the
staff user to make the decision to approve (or not) the changes.
Regards
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit f9a5fd005efa2567be99f9eb2f44e5e79641f74c
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Feb 3 15:22:37 2017 -0300
Bug 13757: Make K::P::Modifications->pending return K::P::Attribute
This patch makes Koha::Patron::Modifications->pending return
Koha::Patron:Attribute objects. They are not stored on the DB but only
live in memory on runtime.
members-update.pl is the only place this is used, and this way we have
all we need for better rendering the UI.
Tests are added for the changed API.
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit e63e4bb35a67a2beed52139b2f149623526d5e23
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Feb 2 10:14:25 2017 -0300
Bug 13757: (QA followup) Fix non-editable attrs on failed save
When a field is not editable but displayable in the OPAC, and you submit
an incomplete/wrong update, those attributes are displayed as empty.
This patch fixes that.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit c44a377d9cc44538b6a7134f48763184c9a110ba
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Jan 30 12:36:57 2017 -0300
Bug 13757: (QA followup) Make opac-memberentry.pl handle attrs deletion
The original code on this bug skipped empty-valued attributes. But
emptying attributes is the only way to tell the controller script that
the user wants to delete them.
This patch makes opac-memberentry.pl check the existence of attributes
sharing the code of the empty for the given patron, and it stores the
deletion on the Koha::Patron::Modification as needed. Otherwise
deletions got skipped.
To test:
- Verify setting/deleting attributes that are opac-editable and verify
the results are sound.
https://bugs.koha-community.org/show_bug.cgi?id=13737
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit b6797fdc8708e73eee0cfd7562e55543ed4f5e3b
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Jan 31 12:41:51 2017 -0300
Bug 13757: Make Koha::Patron::Modification->store del empty attrs
This patch makes Koha::Patron::Modification->store delete the passed
attributes that contain empty values.
This is the way it currently works, as all opac-editable attributes are
presented to the end-user and they are allowed to delete them, and the
best way I found to represent the deletion on the modification request
is by setting it to the empty string. I chose this way because it is how
the staff interface handles it, so it is consistent.
To test:
- Apply this patch
- Run:
$ prove t/db_dependent/Koha/Patron/Modifications.t
=> SUCCESS: This time tests pass!
- Verify comment #70 on the bug is fixed now
- Sign off :-D
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
https://bugs.koha-community.org/show_bug.cgi?id=13737
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit bb039e0328e0151b78c752e7a7be2c6a1c4f7d3a
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Jan 31 12:39:53 2017 -0300
Bug 13757: (regression tests) Empty attributes should delete existing
This patch introduces tests for the required functionality.
To test:
- Run:
$ prove t/db_dependent/Koha/Patron/Modifications.t
=> FAIL: The current code doesn't work like that
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
https://bugs.koha-community.org/show_bug.cgi?id=13737
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 2811d8555d5dc409b8a358795d3f188c87fa950b
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Jan 20 10:59:27 2017 -0300
Bug 13757: (QA followup) Check DB structure before altering table
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 0fbc8620e2180f67270403d4c3a81d7334b3f62e
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Jan 3 17:19:30 2017 -0300
Bug 13757: (followup) Fix authorized value display when opac_display & not opac_editable
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit dc6702e3cd9aa17b41880975823305f5d5aa553c
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Dec 23 16:56:06 2016 -0300
Bug 13757: (followup) Regression tests for ->approve changes
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit c8889f0ff7cfb83422f0136faaf1be9cdec5515c
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Dec 23 16:19:06 2016 -0300
Bug 13757: (followup) Only touch opac_editable attributes
As reported by Owen, the members-update.pl was showing every attributes
the patron has (display issue) instead of showing only those affected by
the changes.
This patch fixes this by filtering the patron's attributes by opac
editability.
It also fixes Koha::Patron::Modification->approve so it only clears the
attributes with the updating 'code' and leaves the others untouched.
As its been coded so far (until someone refactors it all) the
Koha::Patron::Modification object needs to contain all the attributes
for a specific code. And it comes from parsing the UI's input.
Tests for Koha::Patron::Modification->approve to come.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 925e664f42ff9546624946258fe27263e6041fa3
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Dec 19 16:22:17 2016 -0300
Bug 13757: (followup) Staff interface changes
This patch adds proper extended attributes display and handling on the
patron modifications moderation page (members-update.pl).
It also adds changes checking to the opac-memberentry.pl page so it
only saves a modification request if there are changes (it only checked
regular fields and not the extended ones).
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit bfa3f410320e6baad98f277a6cfd9b41a4d68dac
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Dec 19 12:52:27 2016 -0300
Bug 13757: (followup) Remove warnings
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 01506e0195266a0e6b6005c43b9763bf4a09dd78
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Dec 19 12:51:04 2016 -0300
Bug 13757: Add extended attributes to the patron modification
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 2eda977de72434643863301726c5aa9f51be7b36
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Oct 27 11:52:20 2016 -0300
Bug 13757: DBIC update
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 0a40e0c60ff2ac405960cfd34033dd3d5896ac08
Author: Jesse Weaver <pianohacker at gmail.com>
Date: Wed Dec 14 12:30:10 2016 -0300
Bug 13757: OPAC changes
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 1fa5660dbcd015b20cd3059dfdba11c0b4f345bd
Author: Jesse Weaver <pianohacker at gmail.com>
Date: Wed Dec 14 12:29:10 2016 -0300
Bug 13757: DB update
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
commit 21e496bd7bcf3cd3f8826410384005e0cabc17d4
Author: Jesse Weaver <pianohacker at gmail.com>
Date: Wed Sep 2 17:54:04 2015 -0600
Bug 13757: Add the option to set patron attributes editable in the OPAC
Note: this is a squashed version of the original patchset, because it was needed
This patch adds an opac_editable property of borrower attribute types
that can be set in the interface. I'm removing work on OPAC and will
refactor it, keeping the author attribution.
Test plan:
1. Repeat the following with a new and existing borrower attribute
type:
2. Verify that "Editable in OPAC" can only be checked if "Display in
OPAC" is checked.
3. Verify that this new property is correctly saved.
Signed-off-by: Aleisha <aleishaamohia at hotmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Members/AttributeTypes.pm | 58 +++--
Koha.pm | 2 +-
Koha/Patron/Modification.pm | 48 ++--
Koha/Patron/Modifications.pm | 15 +-
Koha/Schema/Result/BorrowerAttributeType.pm | 12 +-
admin/patron-attr-types.pl | 25 ++-
installer/data/mysql/kohastructure.sql | 1 +
installer/data/mysql/updatedatabase.pl | 14 ++
koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 8 +
.../prog/en/modules/admin/patron-attr-types.tt | 16 ++
.../prog/en/modules/members/members-update.tt | 49 ++++-
.../bootstrap/en/modules/opac-memberentry.tt | 98 +++++++--
members/members-update.pl | 46 ++--
opac/opac-memberentry.pl | 229 ++++++++++++++++++--
t/db_dependent/Koha/Patron/Modifications.t | 106 ++++++++-
15 files changed, 627 insertions(+), 100 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list