[koha-commits] main Koha release repository branch master updated. v16.11.00-655-gd420e6a

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  d420e6ae210294884430d294e6cd97e4cc179fa8 (commit)
       via  4cc79c77c904e9a8e5ff35ca872b7673b3c005c9 (commit)
      from  6a6a71b9d8145fe11e4a01260b50a86b1e2b5c42 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d420e6ae210294884430d294e6cd97e4cc179fa8
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Jan 4 11:38:34 2017 +0100

    Bug 17844: Replace C4::Koha::get_notforloan_label_of with Koha::AuthorisedValues
    
    This patch is more a bugfix than a refactoring.
    Indeed the C4::Koha::get_notforloan_label_of behaviors were buggy:
    1/ It does not display the opac description at the OPAC, but always the
    staff description
    2/ It does not care of the framework of the biblio, but retrieve the
    first row of the marc_subfield_structure mapped with items.notforloan
    
    These 2 bugs can easily be fixed using the
    Koha::AuthorisedValues->search_by_koha_field
    
    Steps to recreate the issues:
    - Create 2 authorised value categories for not for loan (NFL1 and NFL2)
    with the same values. Define a different description for the OPAC.
    - Define link 952$7 to NFL1 for the default framework and to NFL2 for
    the BK framework
    - Create 2 bibliographic records (B1 using NFL1 and B2 using NFL2) with
    2 items each (1 item should have a not for loan value)
    - Go to the "Place a hold" view for this record.
    - In the item list, you should see the not for loan value
    => The staff description of NFL1 will always be used, even for the OPAC
    
    Test plan:
    - Recreate the issues without this patchset
    - Apply this patchset
    - Recreate the steps to recreate the issues
    => The staff description of NFL2 should be displayed for the B2 item
    => The opac description of NFL2 should be displayed for the B2 item at
    the OPAC
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 4cc79c77c904e9a8e5ff35ca872b7673b3c005c9
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Jan 4 11:53:33 2017 +0100

    Bug 17844: Remove C4::Koha::get_notforloan_label_of
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Koha.pm           |   53 --------------------------------------------------
 opac/opac-reserve.pl |    8 ++++++--
 reserve/request.pl   |    6 ++++--
 3 files changed, 10 insertions(+), 57 deletions(-)


hooks/post-receive
-- 
main Koha release repository