[koha-commits] main Koha release repository branch master updated. v16.11.00-661-g66d322d

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  66d322d9199782135895e7478b515c5c0eb8b9a9 (commit)
       via  66584e46bd183aa0a2eeaf6e66d62f3d43461539 (commit)
       via  d09096abaeca2e484839a4ba2cfcb31d603f23dc (commit)
       via  7a5709906bd53a44500e71ce169c67244e6e2e3f (commit)
      from  c8c52ba72e90656304e85f2958f3f6f5ff0f3487 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 66d322d9199782135895e7478b515c5c0eb8b9a9
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Dec 12 16:03:01 2016 +0100

    Bug 14146: Add the new pref CumulativeRestrictionPeriods
    
    Sponsored-by: Orex Digital
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 66584e46bd183aa0a2eeaf6e66d62f3d43461539
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Dec 12 16:04:07 2016 +0100

    Bug 14146: Clean a bit and make the code understandable
    
    The code was a bit weird and this patch cleans it a bit by renaming
    variables and adding a variable.
    
    Sponsored-by: Orex Digital
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit d09096abaeca2e484839a4ba2cfcb31d603f23dc
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Nov 30 19:33:44 2016 +0000

    Bug 14146: Add the ability to cumulate restriction periods
    
    At the moment the default behaviour is not to cumulate the restriction
    periods but to apply the longest one.
    This patch set creates a new syspref CumulativeRestrictionPeriods. If
    on, the behaviour changes and the restriction periods are cumulated: the
    days of the second restriction are added to the actual restriction
    period.
    
    We could add a new circulation rule instead of a syspref, but I am not
    sure it's very useful to have such granularity for this behaviour (can
    be changed if needed).
    
    How it works:
    Let's take 2 items, A and B.
    A is returned with Na days late, and B Nb days late
    The grace period is Ng and there is 1 day of suspension charge per day
    of overdue
    The suspension period is until day D = Na - Ng + Nb - Ng
    
    I would have expected D = Na + Nb - Ng but it's how it worked before
    this patch.
    
    Test plan:
    Create several overdue for a given patron
    Do the checkins and confirm that the period are added if the pref is on.
    If the pref is off, you should not get any changes in the existing behaviour.
    
    Sponsored-by: Orex Digital
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 7a5709906bd53a44500e71ce169c67244e6e2e3f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Dec 12 16:04:42 2016 +0100

    Bug 14146: Add tests for AddReturn + CumulativeRestrictionPeriods
    
    Sponsored-by: Orex Digital
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm                                  |   26 +++-
 installer/data/mysql/atomicupdate/bug_14146.sql    |    2 +
 installer/data/mysql/sysprefs.sql                  |    1 +
 .../en/modules/admin/preferences/circulation.pref  |    6 +
 t/db_dependent/Circulation.t                       |  128 ++++++++++++++++++++
 5 files changed, 157 insertions(+), 6 deletions(-)
 create mode 100644 installer/data/mysql/atomicupdate/bug_14146.sql


hooks/post-receive
-- 
main Koha release repository