[koha-commits] main Koha release repository branch master updated. v16.11.00-667-gd3cb1b0

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  d3cb1b0ab33b7070924611fd33e3a1aa3c34aab9 (commit)
       via  52d5519743b2108cd01fcce9b9786a3e461f8e76 (commit)
      from  95e6f6a612013bedbb26054295b3336008466aed (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d3cb1b0ab33b7070924611fd33e3a1aa3c34aab9
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Sat Jan 21 14:13:49 2017 +0100

    Bug 17970: Fix GetPreparedLetter behavior if nothing to substitute
    
    From C4::Letters::GetPreparedLetter:
    
        my $tables = $params{tables};
        my $substitute = $params{substitute};
    
        $tables || $substitute || $repeat
           or carp( "ERROR: nothing to substitute - both 'tables' and 'substitute' are empty" ),
              return;
    
    So if the parameter tables or substitute is passed but does not contain anything, it will not warn as expected.
    
    Test plan:
    1/ Apply the patch with tests
    2/ Confirm that they do not pass
    3/ Apply this patch
    4/ Confirm that the tests now pass
    
    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 52d5519743b2108cd01fcce9b9786a3e461f8e76
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Sat Jan 21 14:13:36 2017 +0100

    Bug 17970: Add tests to highlight the problem
    
    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Letters.pm            |   10 +++++-----
 t/db_dependent/Letters.t |   41 ++++++++++++++++++++++++++++++++++++++++-
 2 files changed, 45 insertions(+), 6 deletions(-)


hooks/post-receive
-- 
main Koha release repository