[koha-commits] main Koha release repository branch master updated. v16.11.00-701-g767ede8

Fri Mar 31 14:53:11 CEST 2017

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  767ede853bbc2d899c0b7c39ad884111d4e93902 (commit)
       via  7bbb8be387ee80359261613ebc727a77382d03fe (commit)
       via  0509d427b9ef7358cc7d044f19c4be2039ccfced (commit)
       via  164db2833e8fb746d50540ae286e0fef97a83a41 (commit)
       via  20fe28d42cad0088e1d474b2d8249e3a7eec6f7b (commit)
       via  91c087cebcab7b005ced31c6deb9519dad3b3abf (commit)
       via  e5d1f6c70835f23465af0a50821888b6211db37d (commit)
       via  6bdae255a919fbc7c4e8ae507190ea780a0b9860 (commit)
      from  e83d92a713e2deea3081a4ff8caa0d63ea66d8c8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 767ede853bbc2d899c0b7c39ad884111d4e93902
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Fri Mar 31 12:12:21 2017 +0000

    Bug 17560 - DBRev 16.12.00.020

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 7bbb8be387ee80359261613ebc727a77382d03fe
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Mar 20 11:10:44 2017 -0300

    Bug 17560: Improve wordings

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Amended as per comment33 of Alex Sassmannshausen.

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 0509d427b9ef7358cc7d044f19c4be2039ccfced
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Mar 10 10:59:41 2017 -0300

    Bug 17560: Improve strenght of hold existence test

    This patch is a QA follow-up to fix several issues:
    - 1 call to GetReserveFee was wrong in ModReserveFill
    - Update DB entry was wrong and insufficient
    - Add robustness to the tests in sco-main

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 164db2833e8fb746d50540ae286e0fef97a83a41
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Sun Nov 6 19:41:47 2016 +0000

    Bug 17560: Add a message when a patron checking in using the self checkout

    Sponsored-by: Cheshire Libraries

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 20fe28d42cad0088e1d474b2d8249e3a7eec6f7b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Sun Nov 6 18:55:22 2016 +0000

    Bug 17560: Update the wording when a patron places a hold at the OPAC

    Sponsored-by: Cheshire Libraries

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 91c087cebcab7b005ced31c6deb9519dad3b3abf
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Nov 3 16:12:38 2016 +0000

    Bug 17560: Hold fee placement at point of checkout

    Currently, Koha charges all patrons a hold fee in all circumstances, if
    a hold fee is applicable to their patron category.
    This is immediately applied at point of request.
    However, it would be useful to let patrons make requests without a
    charge
    being incurred until they physically have the item in their hands and
    checked out to their cards.

    The hold fee will only be added to the account  as soon as the item is
    checked out to the requesting patron.
    With this scenario, we will be certain that patrons have the correct
    item, and they are happy with what has been supplied.
    It also means that patrons can place holds via the OPAC without reaching
    the usage limit that has been selected.

    Test plan:
    0/ All the following steps must be done with a patron using a patron category with a hold fee
    1/ Make sure that the existing options for HoldFeeMode work as before
    2/ Select the third option "any time a hold is collected"
    3/ Place a hold on an item
    4/ Note that the patron has not been charged
    5/ Check this item from the staff interface
    6/ Note that the patron has been charged
    7/ Place another hold
    8/ Use the self checkout feature at the OPAC for the checkin
    9/ Note that the patron has been charged and a message is displayed to
    inform about the fee.

    Sponsored-by: Cheshire Libraries

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit e5d1f6c70835f23465af0a50821888b6211db37d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Nov 3 13:20:17 2016 +0000

    Bug 17560: Update current code

    This patch updates the current code to make it works with the new
    option's name of the syspref.
    It also refactor the tests to make them more reusable and robust.

    Sponsored-by: Cheshire Libraries

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 6bdae255a919fbc7c4e8ae507190ea780a0b9860
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Nov 3 08:16:26 2016 +0000

    Bug 17560: Add a third option to HoldFeeMode

    This patch adds a new 'any_time_is_collected' option to the HoldFeeMode
    syspref.
    The existing 'always' option is renamed with 'any_time_is_placed''

    Sponsored-by: Cheshire Libraries

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-----------------------------------------------------------------------

Summary of changes:
 C4/Reserves.pm                                     |   13 +-
 Koha.pm                                            |    2 +-
 installer/data/mysql/sysprefs.sql                  |    2 +-
 installer/data/mysql/updatedatabase.pl             |   14 ++
 .../en/modules/admin/preferences/circulation.pref  |    3 +-
 .../opac-tmpl/bootstrap/en/modules/opac-reserve.tt |    6 +-
 .../opac-tmpl/bootstrap/en/modules/sco/sco-main.tt |    3 +
 opac/sco/sco-main.pl                               |   40 +++++-
 t/db_dependent/Reserves/GetReserveFee.t            |  147 +++++++++++++++-----
 9 files changed, 184 insertions(+), 46 deletions(-)

hooks/post-receive
-- 
main Koha release repository