[koha-commits] main Koha release repository branch master updated. v16.11.00-708-g0f32bd9

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  0f32bd99997c82cf7b70eef32818dc817cbff64b (commit)
      from  664d6534171677455f3cf1467e8726146714133a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 0f32bd99997c82cf7b70eef32818dc817cbff64b
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Fri Mar 24 16:07:16 2017 +0100

    Bug 18329 - Batch record deletion broken
    
    Hie, Tools > Batch record deletion seems broken.
    Any deletion returns error :
    Bibliographic record YYY was not deleted. An error occurred. (The error was: {UNKNOWN}: DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1560. at /home/koha/src/C4/Biblio.pm line 3468 , see the Koha log file for more information).
    
    Looks like it is because of Bug 18242 which added a transaction  in C4::Biblio::_koha_delete_biblio_metadata : $schema->txn_do.
    The script batch_delete_records created a transaction with $dbh->{AutoCommit} = 0;
    
    This patch fixes by using also Koha::Schema in batch_delete_records to manage transaction.
    It also removes "$dbh->{RaiseError} = 1", this behavior is managed in Koha::Database.
    
    Test plan :
     - Go to Staff interface : Tools > Batch record deletion
     - Enter a few existing biblionumbers
     - Click on "Continue"
     - Click on "Delete selected records"
    => Without patch you get a DB error
    => With patch you get confirmation message
     - Try to get the biblios to confirm they are deleted : /cgi-bin/koha/catalogue/detail.pl?biblionumber=xxx
     - Test with and without Plack
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 tools/batch_delete_records.pl |   21 ++++++++++-----------
 1 file changed, 10 insertions(+), 11 deletions(-)


hooks/post-receive
-- 
main Koha release repository