[koha-commits] main Koha release repository branch master updated. v16.11.00-747-g50f4024

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  50f402405591ceb77c510f7cacd62749ac9e3b59 (commit)
      from  8bb7769cad1d9be8c2b8b6a3412bb5f5ede171bd (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 50f402405591ceb77c510f7cacd62749ac9e3b59
Author: David Cook <dcook at prosentient.com.au>
Date:   Tue Jan 19 16:37:09 2016 +1100

    Bug 15541 - Prevent normalization during matching/import process
    
    This patch allows you to use the "qualifier,qualifier" syntax
    in the Record Matching Rules "Search Index" when using the QueryParser.
    While QueryParser doesn't support this syntax, it will now fallback
    correctly to non-QueryParser functionality. Without the patch, your search
    will just fail silently.
    
    This patch also adds a "skip_normalize" option to C4::Search::SimpleSearch(),
    and uses the option during C4::Matcher::get_matches. This prevents
    the s/:/=/g and s/=/:/g normalization. This normalization is heavy-handed,
    and while it is necessary sometimes to generate a valid CCL query or
    QueryParser query, C4::Matcher::get_matches() already produces a valid
    CCL query, so we don't need to do this normalization.
    
    Additionally, this normalization causes problems when you use a
    Zebra register which isn't normalized: namely the "u" register.
    Strings are stored "as is", so http://localhost/koha/resource/1 is
    stored as is during indexing. When you search, you need to pass
    the exact same thing through the query to get a match. Using
    http=//localhost/koha/resource/1 in your query will yield zero results.
    
    _TEST PLAN_
    
    0) Apply patch
    
    1) Create a Record Matching Rule in Koha with the following details:
        Matching rule code: TEST
        Description: Test
        Match threshold: 100
        Record type: Bibliographic
        Match point 1:
            Search index: id-other,st-urx
            Score: 100
            Tag: 024
            Subfields: a
            Normalization rule: None
    2) Create a record in Koha with an indexable URI
        2a) Default framework
        2b) 024 $a http://koha-community.org/test $2 uri
        2c) 040 $c test
        2d) 245 $a This is a test record
        2e) 942 $c Books
        2f) Save (save again if cautioned about missing fields as these should autofill)
    3) Do a full re-index of Zebra
    4) Download your record from Koha as a .mrc file (ie isomarc, binary marc, etc)
    5) Go to "Stage MARC records for import"
        5a) Upload your .marc file.
        5b) Change your "Record matching rule" to "Test"
        5c) Click Stage for import
    9) It should say "1 records with at least one match in catalog per matching rule "Test".
    
    NOTE: For completeness, you can go through this process on a clean master branch,
    and note that it will say '0 records with at least one match in catalog per matching rule "TEST"'
    
    Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Matcher.pm                             |    6 ++++--
 C4/Search.pm                              |    9 +++++----
 Koha/SearchEngine/Elasticsearch/Search.pm |    6 +++++-
 3 files changed, 14 insertions(+), 7 deletions(-)


hooks/post-receive
-- 
main Koha release repository