[koha-commits] main Koha release repository branch master updated. v16.11.00-777-g36cfb22

Git repo owner gitmaster at git.koha-community.org
Fri Mar 31 17:17:26 CEST 2017


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  36cfb22621c5afa1d1e094a51e9d68937d1bf7d5 (commit)
       via  dd54e970a593e758fa7d914e1241b22196cb6f7c (commit)
       via  e610025babae7efac8415437fa7aee3fad9dce0a (commit)
       via  5d6ee0c7a0de306d68a66a23d7c2414d7274de74 (commit)
       via  d777df6b6f51dc65e6963c4e9ab0ed54b811813a (commit)
       via  46291a0c9f924f5f73824c18b1ee06c206ae9fb4 (commit)
      from  d28c2152abd1ba3b5dfd8af1ceffab094c552bfa (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 36cfb22621c5afa1d1e094a51e9d68937d1bf7d5
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Mar 29 16:39:36 2017 -0300

    Bug 17828: return $self to be consistent
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit dd54e970a593e758fa7d914e1241b22196cb6f7c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Mar 28 11:39:09 2017 -0300

    Bug 17828: Use Koha::Patron::Attributes instead of _resultset
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit e610025babae7efac8415437fa7aee3fad9dce0a
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Mar 27 12:47:14 2017 -0300

    Bug 17828: (QA followup) Add ->type and reuse it
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 5d6ee0c7a0de306d68a66a23d7c2414d7274de74
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu Mar 23 12:07:49 2017 -0300

    Bug 17828: (followup) Add Test::Exception as dependency
    
    Test::Exception is available on Jessie and already installed when
    koha-common gets installed
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit d777df6b6f51dc65e6963c4e9ab0ed54b811813a
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Dec 30 11:12:32 2016 -0300

    Bug 17828: Overload Koha::Patron::Attribute->store to check for unique_id and repeatable
    
    This patch introduces a Koha::Patron::Attribute->store method that does
    the required check for the corresponding Koha::Patron::Attribute::Type
    and raises an exception if trying to store more than one unique
    attribute code/value combination, and another exception for
    non-repeatable attribute types being stored while already existing on
    the DB.
    
    This patch introduces exception definitions for that purpose.
    
    To test:
    - Apply the unit tests patches
    - Run:
      $ prove t/db_dependent/Koha/Patron/Attributes.t
    => FAIL: Tests fail
    - Apply this patch
    - Run:
      $ prove t/db_dependent/Koha/Patron/Attributes.t
    => SUCCESS: Tests pass!
    - Sign off :-D
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 46291a0c9f924f5f73824c18b1ee06c206ae9fb4
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Dec 30 11:10:33 2016 -0300

    Bug 17828: Unit tests for Koha::Patron::Attribute->store
    
    Unit tests for an overloaded Koha::Patron::Attribute->store that
    checks attribute type's uniqueness property and raises an exception
    conveniently.
    
    It also tests for repeatable attribute type's property.
    
    Test plan on the implementing patch.
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Installer/PerlDependencies.pm        |   67 ++++++------
 Koha/Exceptions/Patron/Attribute.pm     |   20 ++++
 Koha/Patron/Attribute.pm                |   85 ++++++++++++++++
 t/db_dependent/Koha/Patron/Attributes.t |  170 ++++++++++++++++++++++++++++++-
 4 files changed, 310 insertions(+), 32 deletions(-)
 create mode 100644 Koha/Exceptions/Patron/Attribute.pm


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list