[koha-commits] main Koha release repository branch 16.05.x updated. v16.05.11-117-g21849ab

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 16.05.x has been updated
       via  21849ab0f95c5011a5e7aa9250d144e811839f74 (commit)
       via  61ddfb4c2aa3a160aac00c672d9c98c13aaadd6f (commit)
       via  d30bb78686cc7ca905e71424f3ebdbba0addbbef (commit)
       via  bcdf0ba34878637cfd967b824b175d5696fc3573 (commit)
      from  826f33b719c68ee0ddd85c1b927e5231ca514ac5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 21849ab0f95c5011a5e7aa9250d144e811839f74
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Fri Mar 24 16:07:16 2017 +0100

    Bug 18329 - Batch record deletion broken
    
    Hie, Tools > Batch record deletion seems broken.
    Any deletion returns error :
    Bibliographic record YYY was not deleted. An error occurred. (The error was: {UNKNOWN}: DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1560. at /home/koha/src/C4/Biblio.pm line 3468 , see the Koha log file for more information).
    
    Looks like it is because of Bug 18242 which added a transaction  in C4::Biblio::_koha_delete_biblio_metadata : $schema->txn_do.
    The script batch_delete_records created a transaction with $dbh->{AutoCommit} = 0;
    
    This patch fixes by using also Koha::Schema in batch_delete_records to manage transaction.
    It also removes "$dbh->{RaiseError} = 1", this behavior is managed in Koha::Database.
    
    Test plan :
     - Go to Staff interface : Tools > Batch record deletion
     - Enter a few existing biblionumbers
     - Click on "Continue"
     - Click on "Delete selected records"
    => Without patch you get a DB error
    => With patch you get confirmation message
     - Try to get the biblios to confirm they are deleted : /cgi-bin/koha/catalogue/detail.pl?biblionumber=xxx
     - Test with and without Plack
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Mason James <mtj at kohaaloha.com>

commit 61ddfb4c2aa3a160aac00c672d9c98c13aaadd6f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Apr 3 10:07:28 2017 -0300

    Bug 18242: 16.05 version - 16.11.x adaptation - Old::Checkouts vs OldIssues
    
    Signed-off-by: Mason James <mtj at kohaaloha.com>

commit d30bb78686cc7ca905e71424f3ebdbba0addbbef
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Mar 9 16:58:17 2017 -0300

    Bug 18242: 16.05 version - [SOLUTION 2]Handle correctly move to old_issues
    
    The table old_issues has a primary key defined on the issue_id column.
    This issue_id comes from the issues table when an item is checked in.
    
    In some case the value of issue_id already exists in the table
    
    Basically this happens when an item is returned and mysqld is restarted:
    The auto increment value for issues.issue_id will be reset to
    MAX(issue_id)+1 (which is the value of the last entry of old_issues).
    See also the description of bug 18003 for more informations.
    
    In this solution the change is done at code level instead of DB
    structure: If old_issues.issue_id already exists before moving from
    the issues table, the issue_id is updated (not on cascade for
    accountlines.issue_id, should it?) before the move.
    
    Signed-off-by: Mason James <mtj at kohaaloha.com>

commit bcdf0ba34878637cfd967b824b175d5696fc3573
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Mar 9 16:41:31 2017 -0300

    Bug 18242: 16.05 version - [SOLUTION 2]Add tests
    
    Signed-off-by: Mason James <mtj at kohaaloha.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm                    |   70 +++++++++++++++++++++-------------
 t/db_dependent/Circulation/Returns.t |   32 +++++++++++++++-
 tools/batch_delete_records.pl        |   23 ++++++-----
 3 files changed, 86 insertions(+), 39 deletions(-)


hooks/post-receive
-- 
main Koha release repository