[koha-commits] main Koha release repository branch master updated. v16.11.00-1028-ge10a415

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  e10a415ef92f69b2645866720e93fbbdd3c6672a (commit)
       via  91171650ac980415d9d2976fa6b19365fe545b37 (commit)
      from  ec822b855244cacf36757e9028779ad9d270c370 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit e10a415ef92f69b2645866720e93fbbdd3c6672a
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri May 12 10:59:11 2017 +0200

    Bug 18400: [QA Follow-up] Move sort outside the loop
    
    GetItemTypesCategorized can return descriptions that are still undef since
    Authorized values does not enforce a description in lib and lib_opac.
    When I add one ITEMTYPECAT auth value without descriptions, I can still
    generate the string comparison warnings on the itemtypes sort.
    In order to prevent the warning, we should add an empty string in the
    assignment on line 229.
    
    We do not need to copy the itemtypes hash if we move the sort outside the
    @advanced_search_types foreach. There is no need to sort it more than once.
    Note that I did not see any reasons btw for corruption of the structure
    inside this loop.
    
    Note: If we use ITEMTYPECAT without descriptions, we should probably leave
    them out. No need to show a checkbox without description on Advanced Search,
    but I would recommend to solve that on its own report. The whole ITEMTYPECAT
    functionality has imo not been designed properly.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 91171650ac980415d9d2976fa6b19365fe545b37
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Apr 7 12:51:49 2017 -0400

    Bug 18400 - Noisy warns in opac-search.pl during itemtype sorting
    
    To fix the warns we use a copy of itemtypes which is not touched by
    other code
    
    To test:
    Apply patches
    Ensure search still works
    
    Followed test plan, search works as expected.
    Signed-off-by: Marc Véron <veron at veron.ch>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 opac/opac-search.pl |    9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
main Koha release repository