[koha-commits] main Koha release repository branch 16.11.x updated. v16.11.07-92-g50f10a3

Mon May 22 00:10:52 CEST 2017

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 16.11.x has been updated
       via  50f10a39280d741945e501f7de8c12a34429cd5b (commit)
       via  243c75430c97df727c4f6a51228d95c401face88 (commit)
       via  5d745a88f0450320493b7e33371b53799d87f677 (commit)
       via  3166154e876b871ed97c1eaf1f02c0c26fc65c26 (commit)
       via  e6af6ae62ab7ab950aaccf24f95dd52334d93218 (commit)
       via  191a4de9a29305e55b9329a9c222b124ccb6a2e5 (commit)
       via  7d0e63da53ab77413d65a7c046417f287744a222 (commit)
       via  60903c88dc17739548dde43b75078bf08f64a257 (commit)
       via  6bb733f94c2f0a3952121beaa5d35984e6b1cfe8 (commit)
       via  f598d07f0d617fade96c35634bfad8d7c480fd03 (commit)
       via  3d37ed539f76005fe55f71f35def5c86d56db859 (commit)
       via  f5fbf222f4c947346f7c56938ff87388ea5fb136 (commit)
       via  b6a35d74be7b0b62ec86a26a91f579b7adc71998 (commit)
      from  81ccdf686944747dca34d24e49f3505e5fcc17c7 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 50f10a39280d741945e501f7de8c12a34429cd5b
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Tue May 9 13:33:52 2017 +0000

    Bug 18551: followup - hide advanced filters in header, move hidding to css file

    Test plan:
    The same as first patch, but also with advanced search form in header hidden
    on page load - see comment 4

    Issue with advanced search form is gone.
    Signed-off-by: Marc Véron <veron at veron.ch>

    Signed-off-by: Philippe <philippe.audet-fortin at inlibro.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    (cherry picked from commit 9719284622e2c3027ef615286ef417f920238c9f)
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

commit 243c75430c97df727c4f6a51228d95c401face88
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Fri May 5 15:00:05 2017 +0200

    Bug 18551 - Hide with CSS dynamic elements in member search

    In member search page, the result table is in Ajax so fully managed by Javascript. There is also a yellow dialog message prepared in HTML.

    Thoses elements are hidden by JS code : ie $("#patron_list_dialog").hide().

    The problem is that the static page is first loaded an displayed then the JS code runs an hides the elements.
    On a low performance computer, this action is visible and looks like there is a blinking yellow message.

    I propose to hide with CSS so that thoses elements are not displayed in static page and are there shown in dynamic JS code.

    Test plan :
    Check display is unchanged :
    - Go to home page /cgi-bin/koha/members/members-home.pl
    - Perform patron search from header search box
    - Perform patron search by clicking on a letter
    - Perform patron search from filters (left of results table)
    - Select a patron and add it to a list => you see the yellow message

    Yellow message does no longer appear with this patch.
    Signed-off-by: Marc Véron <veron at veron.ch>

    Signed-off-by: Philippe <philippe.audet-fortin at inlibro.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    (cherry picked from commit 5cc536c68b221823f4335b5b5db1108521f88a71)
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

commit 5d745a88f0450320493b7e33371b53799d87f677
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Thu May 11 09:10:50 2017 +0200

    Bug 18578: Use subdirectory in /tmp for session storage during installation

    Apply the change from bug 15553 to InstallAuth.pm too.

    Test plan:
    [1] Remove all cgisess_* files from your /tmp directory.
    [2] Remove directory /tmp/cgisess_koha_[your instance], if there.
    [3] Run the webinstaller
        /cgi-bin/koha/installer/install.pl?step=1&op=updatestructure
    [4] Check if you have cgisess_ files in /tmp/cgisess_koha_[your instance].

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    (cherry picked from commit c9de665c294f0e4416a9f1ea751e2859eb065a9c)
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

commit 3166154e876b871ed97c1eaf1f02c0c26fc65c26
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri May 19 11:39:24 2017 +0200

    Bug 18536: [QA Follow-up] Tiny regex simplification

    Simplify regex for removing table name.
    No need to escape a dot between the square brackets. No need to specify a
    number of 1 between parentheses.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    (cherry picked from commit 63c6eaca8d649cb7864b90e5e1ee9ac019daffdf)
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

commit e6af6ae62ab7ab950aaccf24f95dd52334d93218
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Thu May 4 08:54:30 2017 +0000

    Bug 18536: Generating CSV using profile in serials late issues doesn't work as described

    Description on editing csv profiles says:

    "You can also use your own headers (instead of the ones from Koha) by
    prefixing the field name with an header, followed by the equal sign."

    So the header should be optional, but in fact it's mandatory. Also the
    regular expression to cut table name from beginning of db column is not
    right.

    Test plan:

    0. Don't apply the patch
    1. Make two CSV profiles for exporting late issues
        a) SUPPLIER=aqbooksellers.name|TITLE=subscription.title|ISSUENUMBER=serial.serialseq|LATE SINCE=serial.planneddate
        b) aqbooksellers.name|TITLE=subscription.title|ISSUE NUMBER=serial.serialseq|LATE SINCE=serial.planneddate
    2. Export late issues, profile a) works as expected, profile b) doesn't
    3. Apply the patch
    4. Both profiles should work

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    (cherry picked from commit 6b8f9d7e14a8b93143185e814464393ef275631d)
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

commit 191a4de9a29305e55b9329a9c222b124ccb6a2e5
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri May 12 10:00:29 2017 -0400

    Bug 18597 - Quick add form does not transfer patron attributes values when switching forms/saving

    The function that switches between quick add/fulll form assumes labels
    are followed by values - patron_attr don't follow this pattern. This
    patch just moves the hidden input field

    To test:
    1 - Have some patron attributes (with/without auth values set)
    2 - Add them to QuickAddFields (patron_attr2 for example)
    3 - view quick add form and set some values
    4 - Switch to full form, values not transferred
    5 - Switch to quick add, view values, save
    6 - Values are not saved :-(
    7 - Apply patch
    8 - Repeat 3 - 5
    9 - Values are transferred and saved :-)

    Signed-off-by: Peggy Thrasher <p.thrasher at dover.nh.gov>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    (cherry picked from commit 48c87a19a68bf1157c471b8355f5eafe9ec305c1)
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

commit 7d0e63da53ab77413d65a7c046417f287744a222
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed May 3 15:21:40 2017 -0400

    Bug 18534 - When IndependentBranches is enabled the pickup location displayed incorrectly on request.pl

    To recreate:
    1 - Place a hold for pickup at Midway
    2 - Enable independentbranches
    3 - Login to staff interface as admin without superlibrarian status from
    a different branch
    4 - View the holds for the title you placed a hold on
    5 - The hold placed in step 1 should show a dropdown with current branch
    as pickup location, current branch is the only in that dropdown
    6 - Verify it displays correctly for superlibrarian
    7 - Apply patch
    8 - The correct pickup location should show and not be editable
    9 - Verify it is a dropdown

    Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    (cherry picked from commit 90575b64d5c4ed63e1eeded043865796bbcde244)
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

commit 60903c88dc17739548dde43b75078bf08f64a257
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Mon May 23 14:05:58 2016 +0000

    Bug 16568 - Talking Tech generates phone notifications for all overdue actions

    Regardless of whether the phone transport has been selected for a given
    overdue action or not, the Talking Tech outbound script generates and
    sends a line for that action.

    Test Plan:
    1) Enable Talking Tech
    2) Create one or more overdue actions without a phone transport selected
       and one or more with the phone transport selected
    3) Generate the overdues csv file to send to Itive
    4) Note the csv file has lines for actions that do not have the phone
       transport selected
    5) Apply this patch
    6) Repeat step 3
    7) Note the csv file now only has lines for actions that have the phone
       transport selected

    Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    (cherry picked from commit 86678bbc26954e5e4eddf8b11b652b4c83e80425)
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

commit 6bb733f94c2f0a3952121beaa5d35984e6b1cfe8
Author: Alex Buckley <alexbuckley at catalyst.net.nz>
Date:   Wed Apr 19 14:01:30 2017 +1200

    Bug 18438 - Implemented data-dismiss="modal" in returns.tt so that any warning messages hidden by a hold modal are displayed after it is dismissed

    Test plan:
    1. Check out an item to one patron whilst having that item also being on
    hold to another patron

    2. Check the item back in

    3. Notice a modal box appears greying out the background with three
    buttons 'Confirm hold', 'Print and confirm' and 'Ignore'. Click confirm
    and notice that the page refreshes and no yellow warning messages are
    able to be displayed

    4. Now that you have checked the item in. Try checking it in a second
    time by clicking on the Checkin tab and writing in the barcode.

    5. The modal box will appear again, this time with three buttons
    'Confirm', 'Print and confirm' and 'Cancel hold'

    6. Click the 'Confirm' button and the page refreshes again and the
    yellow warning message hidden by the modal box is not properly displayed
    to the user. Notice that the focus is on the barcode input box.

    7. Apply patch

    8. Try checking in the item again, and this time after clicking the
    'confirm' button on the modal box notice that the yellow warning message
    is displayed telling the user the item was "Not checked out". Also
    notice the focus is in the barcode inputbox.

    9. Drop the hold on the item and make sure it is not checked out.

    10. Repeat steps 1 and 2 and notice after clicking the 'Confirm hold'
    button the page refreshes and the item is successfully checked back in.
    With the focus on the barcode input.

    11. View koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt and
    notice that the button on line 345 does not use an onclick parameter

    Followed test plan, works as expected.
    Signed-off-by: Marc Véron <veron at veron.ch>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Amended-patch: remove spaces

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    (cherry picked from commit bbef5c4c3afadeebfe645048bb48ec81f21e0b59)
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

commit f598d07f0d617fade96c35634bfad8d7c480fd03
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu May 18 16:40:42 2017 -0300

    Bug 18376: Do not need to prepare a single statement, use do

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    (cherry picked from commit 285dd883564eaf96737b2be153bbe6d30e1b64f7)
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

commit 3d37ed539f76005fe55f71f35def5c86d56db859
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Tue Apr 4 14:17:15 2017 +0200

    Bug 18376 - authority framework creation fails under Plack

    With plack, when creating a new authority framework from another, you get the error :
    Can't call method "prepare" on an undefined value at (...)/src/admin/auth_tag_structure.pl line 267.

    Looks like plack does not like when the var $dbh from the script is called inside a sub.

    This patch adds a local var $dbh inside sub duplicate_auth_framework(), like in sub StringSearch().

    Also correctes a redefine of my $sth.

    Test plan:
    - Go to Administration > Authority types
    - Create a new type
    - On this new type click on Actions > MARC Structure
    - Select another type and click OK
    => You must get a table filled with the tag structure
    Check with and without plack
    You may not be able to reproduce the error with plack.

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    (cherry picked from commit 6a82ff4b8907f17fb17af3201ab6e96320a995bf)
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

commit f5fbf222f4c947346f7c56938ff87388ea5fb136
Author: Oliver Bock <oliver.bock at aei.mpg.de>
Date:   Mon Nov 30 13:57:58 2015 +0100

    Bug 14625 - LDAP: skip extended patron attributes in 'borrowers' attribute update

    * Any extended patron attributes will cause the update to fail as those attributes don't exist in the 'borrowers' table
    * The update of the extended patron attributes is already dealt with in checkpw_ldap()
    * Ergo: just skip those attributes here

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    I did not test this patch but code looks good

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    (cherry picked from commit 4c631a0824a38177279475f77e9246087fa97515)
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

commit b6a35d74be7b0b62ec86a26a91f579b7adc71998
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Wed May 10 16:04:36 2017 -0300

    Bug 18571: Add default ES configuration to koha-conf-site.xml.in

    This patch adds a default configuration entry for elasticsearch. It will
    add localhost:9200 to the server subsection, and koha_instance (replacing instance
    for the corresponding instance name) for the namespace.

    To test:
    - Apply the patch
    - Copy the file to the /etc/koha dir:
      $ sudo cp kohaclone/debian/templates/koha-conf-site.xml.in /etc/koha
    - Create a new instance:
      $ sudo koha-create --create-db test
    => SUCCESS: /etc/koha/sites/test/koha-conf.xml includes the mentioned section:

     <elasticsearch>
         <server>localhost:9200</server>
         <index_name>koha_test</index_name>
     </elasticsearch>

    - Sign off :-D

    Note: As the use of ES is syspref driven, this default entry doesn't have any use
    until ES is installed and SearchEngine set to Elasticsearch. So it doesn't hurt
    but will help end users test the ES integration. Advanced users will take care of
    this config entry manually (pointing to external servers/clusters, etc).

    Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    (cherry picked from commit 2855107383db654e92e219d7d2d88fa88a73d36e)
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-----------------------------------------------------------------------

Summary of changes:
 C4/Auth_with_ldap.pm                                  |    9 +++++++++
 C4/InstallAuth.pm                                     |    6 ++++--
 admin/auth_tag_structure.pl                           |    7 +++----
 debian/templates/koha-conf-site.xml.in                |    5 +++++
 koha-tmpl/intranet-tmpl/prog/css/staff-global.css     |    6 ++++++
 .../intranet-tmpl/prog/en/includes/patron-search.inc  |    9 ++++++---
 .../intranet-tmpl/prog/en/modules/circ/returns.tt     |    4 +++-
 .../intranet-tmpl/prog/en/modules/members/member.tt   |    4 ++--
 .../prog/en/modules/members/memberentrygen.tt         |    2 +-
 .../intranet-tmpl/prog/en/modules/reserve/request.tt  |   10 +++++++---
 .../cronjobs/thirdparty/TalkingTech_itiva_outbound.pl |    2 ++
 serials/lateissues-export.pl                          |   17 +++++++++++------
 12 files changed, 59 insertions(+), 22 deletions(-)

hooks/post-receive
-- 
main Koha release repository