[koha-commits] main Koha release repository branch master updated. v16.11.00-1128-g30ca02a

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  30ca02aee836fcb1933b2c671638937c503af31e (commit)
       via  8f726ae06d05951bb33540d122a47f1637b39f20 (commit)
       via  e704be99dcd0b162cb02d5c0e547953ab9f31eac (commit)
       via  b1e78d530a38d3edc04168d22671624589d6bbcc (commit)
       via  4fa3df9462eaa4a6a2399af4d7036d2f3ee990ce (commit)
      from  4f3dfd23ea12c3de64761b9e3a20e75e4e6a06c8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 30ca02aee836fcb1933b2c671638937c503af31e
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri May 26 11:20:42 2017 +0200

    Bug 18620: [QA Follow-up] Move the final rollback to the very end
    
    The new subtest in Reserves.t does not need its own transaction.
    Move the original rollback to the very end of the test.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    https://bugs.koha-community.org/show_bug.cgi?id=18478
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 8f726ae06d05951bb33540d122a47f1637b39f20
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue May 23 16:11:06 2017 -0400

    Bug 18478 - QA Followup
    
    Make sure to build necessary letters
    Fix awkward construction
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit e704be99dcd0b162cb02d5c0e547953ab9f31eac
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue May 16 11:01:02 2017 -0400

    Bug 18478 - Additional unit tests
    
    This method was not previously covered, we don't change it , but
    no reason to throw away these tests to ensure messages are created
    as expected
    
    To test:
    1 - Apply this patch first
    2 - Prove t/db_dependent/Reserves.t
    3 - Last tests fail
    4 - Apply other patch
    5 - All tests should pass
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit b1e78d530a38d3edc04168d22671624589d6bbcc
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed May 17 12:58:09 2017 -0400

    Bug 18478 - Unit tests
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit 4fa3df9462eaa4a6a2399af4d7036d2f3ee990ce
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed May 17 12:54:44 2017 -0400

    Bug 18478 - Some notices sent via SMS gateway fail
    
    It seems that for HOLD and DUE (and maybe more) notices we rely on
    C4::Letters::SendQueuedMessages
    to populate the correct address.
    
    This patch adjust that subroutine to correctly populate the field and/or
    fail messages if no SMS provider available
    
    To test:
     1 - Define a messaging prefs for a patron to recieve hold notices via
     SMS
     2 - Ensure you have defined an SMS message for 'HOLD' letter
     3 - Set an SMS alert number for patron
     4 - Set the SMS::Send driver to 'Email'
     5 - Fill a hold for the patron
     6 - Check the db and note the address is null
     7 - run process_message_queue.pl
     8 - Check db - address is null and message pending
     9 - Apply patch
    10 - run process_message_queue
    11 - Message to_address should be populated and message sent
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Letters.pm             |    8 +++++
 t/db_dependent/Letters.t  |   12 ++++++-
 t/db_dependent/Reserves.t |   80 +++++++++++++++++++++++++++++++++++++++++++--
 3 files changed, 96 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
main Koha release repository