[koha-commits] main Koha release repository branch master updated. v17.05.00-713-ga1bf319

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  a1bf319829c9d44991daa2fcf2593420f8445c5b (commit)
      from  cb26219903c30ee6acce926d4a1bb6152f35668c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a1bf319829c9d44991daa2fcf2593420f8445c5b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Oct 3 19:20:18 2017 -0300

    Bug 19405: Prevent api/v1/holds.t to fail randomly
    
    DBD::mysql::st execute failed: Duplicate entry 'cEMggO40gdPLhcVXbpry8x0izO8lHr8NafFIBJwm0D1HgiXA57YR0a0VVxhQBzvn' for key 'userid' [for Statement "INSERT INTO `borrowers` ( `branchcode`, `categorycode`, `flags`, `surname`, `userid`) VALUES ( ?, ?, ?, ?, ? )" with ParamValues: 0='N2ElsY9', 1='Kk8G', 2=80, 3='Test Surname', 4='cEMggO40gdPLhcVXbpry8x0izO8lHr8NafFIBJwm0D1HgiXA57YR0a0VVxhQBzvnnbgezJqmxqwz'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832.
    DBIx::Class::Storage::DBI::_dbh_execute(): Duplicate entry 'cEMggO40gdPLhcVXbpry8x0izO8lHr8NafFIBJwm0D1HgiXA57YR0a0VVxhQBzvn' for key 'userid' at /kohadevbox/koha/Koha/Object.pm line 121
    [18:52:19] t/db_dependent/api/v1/holds.t
    
    Reading the code I guess it happens if TestBuilder generates a userid with the size of borrowers.userid (75 chars). In that case the following lines are wrong:
    
    $borrower->userid($nopermission->{ userid }."z");
    $borrower2->userid($nopermission->{ userid }."x");
    $borrower3->userid($nopermission->{ userid }."y");
    
    The 3 patrons will have the same userid.
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-----------------------------------------------------------------------

Summary of changes:
 t/db_dependent/api/v1/holds.t |   89 +++++++++++++++++++++++------------------
 1 file changed, 49 insertions(+), 40 deletions(-)


hooks/post-receive
-- 
main Koha release repository