[koha-commits] main Koha release repository branch master updated. v17.05.00-735-g0d124e1
Git repo owner
gitmaster at git.koha-community.org
Fri Oct 6 17:15:03 CEST 2017
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 0d124e1bc322e6823c192c51effa0f3eecb2ac1f (commit)
via 5e63a3838102ee1fe8a1bc15640196ab611dbc89 (commit)
via 078eb77451dacd6042b783edf6f89f5ab95732b5 (commit)
via 5aa0280c6db66b8961ebfd644ebbdb80ca0081ba (commit)
via c7c3fc0a63c50c2741a636201880c59c57287a51 (commit)
via f92328332380c805f83ca7f4aed2e828bd112778 (commit)
via 285d72a023daab65626a3ba0f90e20ccfad45c95 (commit)
via 4edfc7900f6132c6771e4cfc820a5a3dc08d3e13 (commit)
via 12a754a703bc8f4279bb23aab09c39c0514b0a75 (commit)
via 6545cfe3f30789723b6f3c2e6e13af6e6c8e5fb9 (commit)
via d805c1ce81b38a659c7504d6b7620ab3b10e4089 (commit)
via 30b22c660f76f7a4c25a1239b020a7541a35b5d9 (commit)
via 1b41e7799b0071e97e37c63da4fe9d685d3b3fc3 (commit)
via c204171ff3cf4dedc64ea953c968447bcf7d9f65 (commit)
via 7d3eefd8f1cc474346f8804197ac5fb28776191e (commit)
via 07764f2b3114e5ccb72f7737e316d2cda3ad5068 (commit)
via 46ff8df19544e3e7c16a4e3f21b3b14bc043dd88 (commit)
via 3cf0caf05ca9577a26bb76d4910d8be8970aa06a (commit)
via 49c879150de0bb0b8a5d384f8ff1fa51a80d8c10 (commit)
via b91c20da903d1330bf7a997b794f83042bf86fb6 (commit)
via ea9255c00439fbedccab14a4a50b47fcb1ba05ac (commit)
from 10b5e1ee049605ae6a0614214a7dab76e20e0ca5 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 0d124e1bc322e6823c192c51effa0f3eecb2ac1f
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Aug 28 16:27:41 2017 +0000
Bug 19193: When displaying the fines of the guarantee on the guarantor account, price is not in correct format
1 - Have a patron with guarantees
2 - Charge some fines to the guarantees
3 - View the patron
4 - Fines are displayed unformatted
5 - Apply patch
6 - Refresh
7 - Fines should now be formatted correctly
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 5e63a3838102ee1fe8a1bc15640196ab611dbc89
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Mon Nov 21 12:08:52 2016 -0500
Bug 17664: Silence non-zebra warnings in t/db_dependent/Search.t
TEST PLAN
---------
0) back up database
1) drop database; create database
2) run web installer
3) prove t/db_dependent/Search.t
-- the spammy warnings (other than zebra index warnings) may
already be fixed, but the mocked value was not realistic.
4) apply patch
5) prove t/db_dependent/Search.t
-- notice only zebra index warnings.
6) run qa test tools
Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 078eb77451dacd6042b783edf6f89f5ab95732b5
Author: David Bourgault <david.bourgault at inlibro.com>
Date: Tue Sep 19 13:37:54 2017 -0400
Bug 19345: Add missing error flag to template
Adds a missing error flag to the template->param { } call.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 5aa0280c6db66b8961ebfd644ebbdb80ca0081ba
Author: Marc Véron <veron at veron.ch>
Date: Thu Sep 7 14:48:48 2017 +0200
Bug 18550: [Follow-up] Add POD descriptions to subs
This patch simply adds POD descriptions to subs affected by first patch.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c7c3fc0a63c50c2741a636201880c59c57287a51
Author: Marc Véron <veron at veron.ch>
Date: Fri May 5 15:08:56 2017 +0200
Bug 18550: Patron card creator: Print output does not respect layout units
To reproduce:
Text, images and barcode positions are always layed out based on PostScript points, regardless of unit defined in card layout.
To reproduce:
- Test on top of Bug 18541 (introduces layout grid)
- Create a card layout with a text field, an image and a barcode. Use points
as layout unit
- Activate layout grid
- Create PDF output, save
- Change layout unit to mm
- Create PDF output, save
- Compare PDFs. Verify that the positions are unchanged (still using points)
To test:
- Apply patch
- Create again PDF
- Verify that elements are positionad as expected (using unit, e.g. mm)
- Bonus test: Repeat with other units
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f92328332380c805f83ca7f4aed2e828bd112778
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Oct 6 08:21:23 2017 +0200
Bug 19315: [QA Follow-up] Trivial edits
Replace $subs->{bibnum} by $biblionumber on a following line.
The scalar in the boolean expression is not needed.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 285d72a023daab65626a3ba0f90e20ccfad45c95
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Sep 14 12:23:09 2017 +0000
Bug 19315: Use bibnum instead of biblionumber in routing-preview.pl and add item check
To test:
1 - Create a serial subscription attached to a record
2 - Receive some issues
3 - Edit the subscription
4 - Go to serails collection
5 - Try to print a routing list
6 - You may or may not get the right serial
7 - Additionally create a subscription attached to a bib with no items
8 - Try to print a routing list for this serial
9 - You will get 'Internal server error'
10 - Apply patch
11 - Print routing list for first serial
12 - You will always get the correct bib
13 - Print routing list for second serial
14 - You should no longer get an error
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 4edfc7900f6132c6771e4cfc820a5a3dc08d3e13
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Oct 2 14:22:27 2017 -0300
Bug 19398: Format date of birth in circ patron search
When searching for a patron from the circulation tab, the results table
shows the date of birth unformatted.
Test plan:
Apply this patch, search for patrons in the circ tab and confirm that
the date of birth are correctly formatted according to the dateformat
syspref
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 12a754a703bc8f4279bb23aab09c39c0514b0a75
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Oct 6 11:39:42 2017 +0200
Bug 19386: [QA Follow-up] Remove some default values
In the meantime bug 19403 added default nulls for gonenoaddress, lost
and debarred. So these lines can be removed safely.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 6545cfe3f30789723b6f3c2e6e13af6e6c8e5fb9
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Sep 28 17:31:04 2017 -0300
Bug 19386: Prevent t/db_dependent/SIP/Patron.t to fail randomly
Depending on the values used by TestBuilder, some tests from t/db_dependent/SIP/Patron.t can fail
# Failed test 'Not blocked without overdues when set to 'Don't block''
# at t/db_dependent/SIP/Patron.t line 55.
# got: '0'
# expected: '1'
# Failed test 'Not blocked without overdues when set to 'confirmation''
# at t/db_dependent/SIP/Patron.t line 61.
# got: '0'
# expected: '1'
# Failed test 'Not blocked without overdues when set to 'Block''
# at t/db_dependent/SIP/Patron.t line 67.
# got: '0'
# expected: '1'
Caused by this check in C4::SIP::ILS::Patron->new
110 for (qw(EXPIRED CHARGES CREDITS GNA LOST DBARRED NOTES)) {
111 ($flags->{$_}) or next;
[...]
115 if ($flags->{$_}->{noissues}) {
116 foreach my $toggle (qw(charge_ok renew_ok recall_ok hold_ok inet)) {
117 $ilspatron{$toggle} = 0; # if we get noissues, disable everything
118 }
119 }
120 }
Test plan:
Execute several times (50x?) these tests.
Without this patch they may fail
With this patch they must never fail
Signed-off-by: David Bourgault <david.bourgault at inlibro.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d805c1ce81b38a659c7504d6b7620ab3b10e4089
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Oct 6 11:58:42 2017 -0300
Bug 19198: Prevent the test to fail randomly
If categorycode is 'X', the test will fail
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 30b22c660f76f7a4c25a1239b020a7541a35b5d9
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Oct 6 11:49:38 2017 -0300
Bug 19198: do not autovivify
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 1b41e7799b0071e97e37c63da4fe9d685d3b3fc3
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Sep 13 11:59:19 2017 +0000
Bug 19198: (QA followup) Fix typo in conditions
'&' should be '&&'
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c204171ff3cf4dedc64ea953c968447bcf7d9f65
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Aug 29 14:25:20 2017 +0000
Bug 19198: Renewal as issue causes too many error
This patch moves some code and prevents checking for too many checkouts
when performing a renewal via checkout
To test:
1 - Set a rule to limit checkouts to a single issue, allowing renewal
2 - Issue an item to a patron
3 - Issue the same item
4 - In staff client you get a confirm to renew and a notice of Too Many
checkouts, don't confirm
5 - VIA Sip - you get a renewal response, but in logs the renewal fails
as a 'too
6 - Apply patch
7 - Via staff client you shoudl get renewal confirm with no too many
error
8 - SIP checkout should renew
Signed-off-by: Lee Jamison <ldjamison at marywood.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7d3eefd8f1cc474346f8804197ac5fb28776191e
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Aug 29 14:10:54 2017 +0000
Bug 19198: Unit tests
Signed-off-by: Lee Jamison <ldjamison at marywood.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 07764f2b3114e5ccb72f7737e316d2cda3ad5068
Author: Lari Taskula <lari.taskula at jns.fi>
Date: Wed Sep 27 17:59:55 2017 +0300
Bug 19374: CircSidebar overlapping transferred items table
When CircSidebar is activated, "Transferred items" table at
Circulation -> Transfers goes under the sidebar. This patch fixes the issue.
To test:
1. Enable CircSidebar system preference
2. Go to cgi-bin/koha/circ/branchtransfers.pl
3. Enter a barcode and click submit
4. Observe transferred items table under the circulation side bar
5. Apply patch
6. Enter a barcode and click submit
7. Observe transferred items is now correctly displayed
8. Also test with CircSidebar system preference deactivated
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Bug 19374: (follow-up) Remove stray closing div tag
To test:
1. Apply first patch and validate the document e.g. here
https://validator.w3.org/#validate_by_input
2. Observe "Stray end tag div." error
3. Apply this patch and validate again
4. Observe no errors
5. Go through test plan from first patch to make sure things still look nice
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 46ff8df19544e3e7c16a4e3f21b3b14bc043dd88
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Jul 20 14:28:20 2017 -0400
Bug 19135: Restore AllowHoldsOnPatronsPossessions behaviour
Bug caused by
commit bc39f0392bbebaad4c083f81308f652a325be042
Bug 14695 - Add ability to place multiple item holds on a given record per patron
Test Plan:
1) Set AllowHoldsOnPatronsPossessions to "Don't"
2) Check out an item to a patron
3) Place a hold on that item for the same patron
4) Note you are allowed to with no alert
5) Delete the hold
6) Apply this patch
7) Place a hold on that item for the same patron
8) Note you recieve an alert now
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3cf0caf05ca9577a26bb76d4910d8be8970aa06a
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Oct 6 11:05:49 2017 +0200
Bug 19260: [QA Follow-up] Remove obsolete $dbh
The variable is no longer used.
Removed a few empty lines on the way.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 49c879150de0bb0b8a5d384f8ff1fa51a80d8c10
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Thu Oct 5 20:37:25 2017 +0000
Bug 19260: Holds marked as problems being seen as expired ones and deleted wrongly
Test plan:
0) Apply just the first patch - the one with test
1) Run t/db_dependent/Reserves.t - test for CancelExpiredReserves should
fail
2) Apply the second patch
3) t/db_dependent/Reserves.t should pass now
Followed test plan, patch worked as described. Passes QA test tool
Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit b91c20da903d1330bf7a997b794f83042bf86fb6
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Thu Oct 5 20:36:31 2017 +0000
Bug 19260: Add test for CancelExpiredReserves
Passes QA test tool
Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ea9255c00439fbedccab14a4a50b47fcb1ba05ac
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Sep 29 11:49:30 2017 -0300
Bug 19388: FIX display item status if item is checked out
In course reserves, if an item which was added to a course is checked
out, it is not possible to show details for that course on OPAC.
The error says: "Template process failed: undef error - The method
onsite_checkout is not covered by tests! at
/home/koha/src/C4/Templates.pm line 121."
onsite_checkout is an attribute of Koha::Checkout, not Koha::Item
Test plan:
Create a course with 2 items that are checked out (standard and on-site)
At the OPAC, add them to your cart and confirm the status of these 2
items is correct
Confirm that on the detail page of the bib record as well as the detail
of the course.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
-----------------------------------------------------------------------
Summary of changes:
C4/Circulation.pm | 102 ++++++++++----------
C4/Patroncards/Patroncard.pm | 43 ++++++---
C4/Reserves.pm | 14 +--
Koha/QueryParser/Driver/PQF/query_plan/node.pm | 2 +-
.../en/includes/circ-patron-search-results.inc | 3 +-
.../prog/en/modules/circ/branchtransfers.tt | 4 +-
.../prog/en/modules/circ/circulation.tt | 2 +-
.../bootstrap/en/includes/item-status.inc | 10 +-
opac/opac-password-recovery.pl | 1 +
reserve/request.pl | 3 +-
serials/routing-preview.pl | 6 +-
t/db_dependent/Circulation.t | 60 +++++++++++-
t/db_dependent/Reserves.t | 63 +++++++++++-
t/db_dependent/SIP/Patron.t | 18 +++-
t/db_dependent/Search.t | 2 +-
15 files changed, 239 insertions(+), 94 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list