[koha-commits] main Koha release repository branch master updated. v17.05.00-778-gfed86d5
Git repo owner
gitmaster at git.koha-community.org
Mon Oct 9 21:21:04 CEST 2017
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via fed86d50420dcb3fb468c5743a1e370d075bc5e0 (commit)
via e90874241808354777cc1c27ad3ad106ffdc7cd4 (commit)
via 5ac69e3a19bb3a30554d41f862516bb92a70508a (commit)
via 7c82c9793062b93c463798db0fd606fbd2905d56 (commit)
via c84cab61b73574ae451fe93a09057252bcb830e4 (commit)
via 26f3ca8d88486e5948c400f0d19d8c5bdf392d2e (commit)
via b811dbbd8d8cdbe226bf123bc52daff426eac72f (commit)
via 0b0cc8584f223fff54cd729043f448be028ad792 (commit)
via 00b871e880ec93910671ee7294171c7d76a4794d (commit)
via 77a28050a6e4c68c25576ccbd576402a2e9590aa (commit)
via 09a16fc493c5082a47f0bc677972c4dc9ee18abf (commit)
via 972d6c946a193d070b56efafe0f4e3251e0dbd84 (commit)
via 3f46ec652b7f88acfba73db0ab66dcc69d2d05b3 (commit)
via 38526ca13aa63bf6dee90e8a408a8dfa93316b58 (commit)
via 359907e9a225235c299d736c26462b8cf3735828 (commit)
via 4553aa704038a7c797c10b39f3acc59b190b4021 (commit)
via 69ee06a490a64985dfccd01cf689ae77eea1d2d5 (commit)
via 5fc0a1f5b1ad58b4fa0a538cef5d2106fd39c71a (commit)
via 1a157575d360d663aed2c3c56f70aeeef64ca762 (commit)
via b97de5af12d54d2cce197e7ad755ac27df3a9604 (commit)
via 1fc0b652548510ef00a7e072cdf923357d5610aa (commit)
via b3b86caaa5473ea51dc7223146e4c7cf0db431dc (commit)
via a18b12ea7f52d5d017cb0f74723cbb50b6d04749 (commit)
via ecc5daaceb3c2bb4ea9be2860b839c1686eee2d8 (commit)
via 7f6f98e00c319e60e9296b96913c8321366a7d12 (commit)
via 2c07f63ae84dc16099999e3f7c38e1a49b758af8 (commit)
via b583e806c73cb79b35ee727a18f6b30ee32197f8 (commit)
via 799293c40fc4419b9df9ea941836778c2e359684 (commit)
via 0152e95c979ff38ed53887f5b1140fdd5e148812 (commit)
via c367705d9d154b195b29bf7c229046928a5f4718 (commit)
via 347ade5c1089813ccecbbd1bb0c91e828a914265 (commit)
via f59484df2246c0ee11c5d44f2dca762908864fe8 (commit)
via 36821be142b49a4c42ff740c33bda882d39bb885 (commit)
via 3822105060bf266a1064caaf14f9af270b9f1e11 (commit)
via faf1bd1e6e7478aec724e4dc33707d89d7820812 (commit)
via 87448e82d27921b867bc6982a279f8bdd2b85cb7 (commit)
via 3bdee4a05f782376e7851e1025c9909426f78c57 (commit)
via 639d7f308f6581880bc2f03cd722af6c76ecd7c5 (commit)
via e1a5c9e8c9e75bbb82184c732803ae8623b50bfd (commit)
via 511b3253576262878c953e7a3fe4a2941686ab1e (commit)
via 56500e8e676782155c5717e8db9786af394252d8 (commit)
from 725a3022c9ca025755a2d86a36ed84039deab232 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit fed86d50420dcb3fb468c5743a1e370d075bc5e0
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Oct 9 15:57:46 2017 -0300
Bug 19440: Existing calls need to be done in scalar context
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e90874241808354777cc1c27ad3ad106ffdc7cd4
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Oct 9 15:36:41 2017 -0300
Bug 19440: Identify overlimit problems in XISBN tests
This patch makes C4::XISBN::get_xisbns() return an errors hashref
including information of the failing fetches from xisbn services.
It tackles the situation of XISBN, which in some cases returns 'overlimit'
errors.
The patch makes the relevant functions check if the response->{stat} string
is 'ok' and returns the string in $errors otherwise.
This only happens when in list context. This allows to fix the randomly failing
tests while keeping the current behaviour.
All this code should be rewritten. It does the job bug doesn't have problems handling
or reoprting. This is just a band aid.
To test:
- Make sure
k$ prove t/db_dependent/XISBN.t
=> SUCCESS :-D
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 5ac69e3a19bb3a30554d41f862516bb92a70508a
Author: Marc Véron <veron at veron.ch>
Date: Wed May 3 16:23:22 2017 +0200
Bug 18528: Patron card creator template: switch form fields for card height and card width
This patch changes the sequnce of form fields for card height and card width.
To test:
- Apply patch
- Edit or create a patron card template
- Verify that the fields display in sequence Page height - Page width -Card height - Card width
Followed test plan, worked as intended
Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7c82c9793062b93c463798db0fd606fbd2905d56
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Sep 25 15:01:51 2017 -0300
Bug 19196: Rename page and per_page
This patch just renames 'page' and 'per_page' params, for
'_page' and '_per_page' respectively.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Lari Taskula <lari.taskula at jns.fi>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c84cab61b73574ae451fe93a09057252bcb830e4
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Aug 29 17:02:13 2017 -0300
Bug 19196: Make plugin available to endpoints
This patch just initializes the plugin on the main controller class so
it is available for all endpoints to use.
As it is not used, in order to test just restart plack and make sure the
endpoints work (run the t/db_dependent/api/v1 tests).
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Lari Taskula <lari.taskula at jns.fi>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 26f3ca8d88486e5948c400f0d19d8c5bdf392d2e
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Aug 29 16:52:48 2017 -0300
Bug 19196: Add Koha::REST::Plugin::Pagination
This patch introduces a Mojolicious plugin to be used on the REST api.
It adds a helper method:
add_pagination_headers
======================
When used, it adds a _Link_ header to the reponse with the calculated
values for pagination, and X-Total-Count containing the total results
like this:
my $params = $c->validation->output;
my $patrons = Koha::Patrons->search;
my $count = $patrons->count;
$c->add_pagination_headers({
total => $count,
params => $params )};
To test:
- Run:
$ sudo koha-shell kohadev
k$ cd kohaclone
k$ prove t/Koha/REST/Plugin/Pagination.t
=> SUCCESS: Tests pass!
- Sign off :-D
Sponsored-by: ByWater solutions
Sponsored-by: Camden County
Edit: I fixed a mistake on the POD (tcohen)
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Lari Taskula <lari.taskula at jns.fi>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit b811dbbd8d8cdbe226bf123bc52daff426eac72f
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Aug 29 17:00:50 2017 -0300
Bug 19196: Unit tests
This patch adds unit tests for the new pagination Mojo plugin.
Sponsored-by: ByWater Solutions
Sponsored-by: Camden County
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Lari Taskula <lari.taskula at jns.fi>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 0b0cc8584f223fff54cd729043f448be028ad792
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Mon Oct 2 14:33:02 2017 +0200
Bug 19397: Release team for 17.11
This patch adds the release team for 17.11 to about template.
Test plan:
Check the changes with the wiki pages for 17.05 and 17.11.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 00b871e880ec93910671ee7294171c7d76a4794d
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Sat Oct 7 00:07:31 2017 +0000
Bug 19255: QA Followup - Fix tabs for spaces
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 77a28050a6e4c68c25576ccbd576402a2e9590aa
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed Sep 6 13:01:17 2017 +0200
Bug 19255: [Follow-up] Typo "will accessible"
This patch speaks for itself.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 09a16fc493c5082a47f0bc677972c4dc9ee18abf
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Tue Sep 5 15:10:53 2017 +0200
Bug 19255: Correct explanation about list types on shelves.pl in staff
The explanation on list categories on the shelves form is removed.
The online help text is actualized.
Test plan:
Go to Lists in staff. Edit a list. The remarks about private and public
lists on the right side are gone.
Click Help. Read the adjusted text. Does it make sense?
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 972d6c946a193d070b56efafe0f4e3251e0dbd84
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Wed Aug 9 11:30:00 2017 +0200
Bug 18785: Force scalar context in Koha::Subscription::biblio
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3f46ec652b7f88acfba73db0ab66dcc69d2d05b3
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Mon Jun 12 13:01:14 2017 +0200
Bug 18785: Add the Koha::Subscription->biblio method
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 38526ca13aa63bf6dee90e8a408a8dfa93316b58
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Aug 9 16:45:31 2017 -0300
Bug 14039: Add the title to all places
There are other scripts where the borrower variable is not defined and
the fields are passed one by one.
To have a consistent behaviour we should add the title at the different
places.
Note that this script also add the use of the include file for
statistics.tt and remove the pass of parameters to the template, already
done later:
99 $template->param(%$borrower);
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 359907e9a225235c299d736c26462b8cf3735828
Author: David Roberts <david.roberts at ptfs-europe.com>
Date: Wed Jun 7 00:01:17 2017 +0100
Bug 14039: Add patron salutation to checkout screen
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 4553aa704038a7c797c10b39f3acc59b190b4021
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Mon Jul 10 00:14:10 2017 +0000
Bug 18916: Add pagination to top of search results in staff client
To look the same as OPAC.
To test:
1) Do a catalogue search in staff client that results in more than one
page
2) Notice pagination is only at the bottom
3) Apply patch and refresh page
4) Notice pagination is at top also
Sponsored-by: Catalyst IT
Signed-off-by: Lee Jamison <ldjamison at marywood.edu>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 69ee06a490a64985dfccd01cf689ae77eea1d2d5
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Mon Jul 10 00:07:38 2017 +0000
Bug 13205: [FOLLOW-UP] Fixing math and variable names
Have changed
my $last_page = $pages * ( $results_per_page - 1 );
to
my $last_page = ( $pages - 1) * $results_per_page;
which seems to fix the 'last' button offset! (Comment 10)
Will add the box to jump to a page in a separate patch.
Adding the pagination to the top on the staff client will be dealt with
in Bug 18916 as it is slightly out of the scope of this bug.
Signed-off-by: Lee Jamison <ldjamison at marywood.edu>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 5fc0a1f5b1ad58b4fa0a538cef5d2106fd39c71a
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Tue Jun 27 04:36:56 2017 +0000
Bug 13205: [FOLLOW-UP] Some extra logic
See Comment 8.
Test:
When on first page of results, confirm that the 'First' and 'Previous'
buttons do not show. Confirm they come back on the second page and every
page after.
When on last page of results, confirm that the 'Last' and 'Next' buttons
do not show. Confirm they come back on all previous pages.
Check on both staff side and OPAC.
Sponsored-by: Catalyst IT
Signed-off-by: Lee Jamison <ldjamison at marywood.edu>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 1a157575d360d663aed2c3c56f70aeeef64ca762
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Thu Feb 16 02:28:13 2017 +0000
Bug 13205: Last/first page options for result list paging for OPAC
Same fix but on OPAC side. Same test plan
Sponsored-by: Catalyst IT
Signed-off-by: Dilan Johnpulle <dilan at calyx.net.au>
Signed-off-by: Your Full Name <your_email>
Signed-off-by: Lee Jamison <ldjamison at marywood.edu>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit b97de5af12d54d2cce197e7ad755ac27df3a9604
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Wed Feb 15 02:42:10 2017 +0000
Bug 13205: Last/first page options for result list paging
This patch adds first and last page buttons to the pagination at the
bottom of a page of catalog search results.
To test:
1) Apply patch
2) Do a number of searches
3) For each search, ensure that the first and last page buttons work as
expected
Sponsored-by: Catalyst IT
Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Lee Jamison <ldjamison at marywood.edu>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 1fc0b652548510ef00a7e072cdf923357d5610aa
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Mon Aug 28 12:13:26 2017 +0200
Bug 19190: [Follow-up] Do not rely on the return of ModItem
touch_all_items looks at the return of ModItem to determine if the
operation was successful. But ModItem does not return a meaningful
value. This patch puts the ModItem call in an eval and looks at $@.
Test plan:
Run touch_all_items with a where condition and verbose option.
Put print 1/0; at the end of ModItem.
Run touch_all_items again. You should see: ERROR WITH ITEM xxx !!!!
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: David Bourgault <david.bourgault at inlibro.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit b3b86caaa5473ea51dc7223146e4c7cf0db431dc
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Mon Aug 28 11:59:19 2017 +0200
Bug 19190: Silly calculation of average time in touch_all scripts
When you want to calculate average time, do not divide count by time :)
Test plan:
Run the script with a where condition and verbose option and see that
the average time is meaningful.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: David Bourgault <david.bourgault at inlibro.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit a18b12ea7f52d5d017cb0f74723cbb50b6d04749
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Oct 9 14:29:41 2017 -0300
Bug 19043: DBRev 17.06.00.012
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ecc5daaceb3c2bb4ea9be2860b839c1686eee2d8
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Mon Oct 9 12:51:34 2017 +0200
Bug 19043: (QA follow-up) Add update DB entry and print warning
This follow-up takes care of the requested warning at upgrade time.
At the same time it removes the obsolete Columbia record when host and
port are equal to the formerly used values. Note that the new host for
on-campus use has been changed.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7f6f98e00c319e60e9296b96913c8321366a7d12
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Tue Aug 8 15:03:19 2017 +0200
Bug 19043: Z39.50 target clio-db.cc.columbia.edu:7090 is no longer publicly available
Test plan:
0) Apply the patch
1) Install all affected languages: de-DE, es-ES, fr-CA and pl-PL
2) Remove and recreate Koha database
3) Go through web installer in English and don't forgot to load sample Z39.50 servers
4) Go to Administration -> Z39.50/SRU Servers and confirm the sample
servers are here, but columbia.edu is not here
5) Repeat 2-4 for other languages: de-DE, es-ES, fr-CA and pl-PL
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 2c07f63ae84dc16099999e3f7c38e1a49b758af8
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Sep 27 16:04:04 2017 -0300
Bug 18449: Rename misleading button when renewing
If you hit the renewal limit on the renewal tab, the message gives you a
message like:
"Windows 8 / ( 50610018249545 ) has been renewed the maximum number of
times by Johnny Test ( 12345678 )"
And has a button that reads:
"Ignore and continue"
This button is misleading, as it may be interpreted as "ignore the limit
and continue to renew the item".
Signed-off-by: Dominic Pichette <dominic at inlibro.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit b583e806c73cb79b35ee727a18f6b30ee32197f8
Author: Alex Buckley <alexbuckley at catalyst.net.nz>
Date: Wed Sep 27 07:20:34 2017 +0000
Bug 19371: Changed table column text to 'Cancel?' on the patron circulation page
Test plan:
1. Place a hold on an item
2. Search for the patron who the hold is associated with
3. View the Hold(s) tab of the Checkouts page and notice there is a
column with the text 'Delete?' and a button below the table with the
text 'Cancel marked holds'
4. Apply patch
5. Notice that the column text described in step 3 now has the text
'Cancel?' and the button text is the same as it was in step 3
Sponsored-By: Catalyst IT
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 799293c40fc4419b9df9ea941836778c2e359684
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Oct 9 14:24:31 2017 -0300
Bug 13766: DBRev 17.06.00.011
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 0152e95c979ff38ed53887f5b1140fdd5e148812
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Mon Sep 4 20:36:38 2017 +0000
Bug 13766: Follow-up - use index_exists()
Changes check for existing index to use index_exists.
Also checks deletedbiblioitems for an existing ean index
and drops it if one is found.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c367705d9d154b195b29bf7c229046928a5f4718
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Thu Aug 17 13:54:36 2017 +0200
Bug 13766: Change *bibioitems.ean to mediumtext and add indexes
- biblioitems.ean and deleteditems.ean are changed
to mediumtext to match issn and isbn.
- An index is added for ean on both tables.
Patch cleans up inconsistencies caused by bug 5337 that
causes some older databases to have an existing index
on biblioitems.ean.
Signed-off-by: Colin Campbell <colin.campbell at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 347ade5c1089813ccecbbd1bb0c91e828a914265
Author: David Cook <dcook at prosentient.com.au>
Date: Tue Sep 26 11:45:25 2017 +1000
Bug 19367: $biblio variable redefined in same scope in ISBDdetail
The following warning is generated by ISBDdetail.pl:
my" variable $biblio masks earlier declaration in same scope
at ./catalogue/ISBDdetail.pl line 171.
This patch removes this unnecessary declaration, which removes the
warning.
_TEST PLAN_
After applying patch:
1) Check code compilation with "KOHA_CONF=/path/to/koha-conf.xml perl -c catalogue/ISBDdetail.pl"
2) Note the only message is "./catalogue/ISBDdetail.pl syntax OK"
2) On /cgi-bin/koha/catalogue/ISBDdetail.pl?biblionumber=1,
view the source of the page and verify that the Javascript
contains a holdcount e.g. "var holdcount = 0".
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f59484df2246c0ee11c5d44f2dca762908864fe8
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date: Tue Sep 19 12:58:12 2017 +0100
Bug 19340: Read basket details of transfer partner
Details of the basket an order is tranferred to or from
are displayed in the basket display.
Unfortunately these details were not being read so
the display incorrectly showed the details
of the current owning basket.
Signed-off-by: David Bourgault <david.bourgault at inlibro.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 36821be142b49a4c42ff740c33bda882d39bb885
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Oct 9 14:12:24 2017 -0300
Bug 13208: Display complete breadcrumbs on successful deletion
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3822105060bf266a1064caaf14f9af270b9f1e11
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Tue Sep 5 03:31:54 2017 +0000
Bug 13208: [FOLLOW-UP] Tests for Koha::Acquisition::Baskets
To test:
prove -v t/db_dependent/Koha/Acquisition/Baskets.t
Signed-off-by: David Bourgault <david.bourgault at inlibro.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit faf1bd1e6e7478aec724e4dc33707d89d7820812
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Sep 1 13:18:21 2017 +0000
Bug 13208: (QA follow-up) Remove blank breadcrumbs on successful deletion
After order is deleted we don't have a vendor or basket so we get blank
breadcrumbs, this removes them
Signed-off-by: David Bourgault <david.bourgault at inlibro.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 87448e82d27921b867bc6982a279f8bdd2b85cb7
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Fri Aug 18 03:23:55 2017 +0000
Bug 13208: [FOLLOW-UP] Perl documentation for modules
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: David Bourgault <david.bourgault at inlibro.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3bdee4a05f782376e7851e1025c9909426f78c57
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Thu Jul 27 01:54:35 2017 +0000
Bug 13208: [FOLLOW-UP] Creating and implementing new Koha::Acquisition::Basket[s] modules
Test plan remains the same.
Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: David Bourgault <david.bourgault at inlibro.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 639d7f308f6581880bc2f03cd722af6c76ecd7c5
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Wed Jun 28 01:24:00 2017 +0000
Bug 13208: Improving breadcrumbs for when cancelling an order
To test:
1) Go to Acquisitions -> Find a vendor -> View a basket with orders in
it (or make a new basket and add an order)
2) Click Cancel order
3) Notice incomplete breadcrumbs, and 'Acquisition' typo
4) Apply patch and refresh page
5) Breadcrumbs should be fixed. Confirm links to vendor and basket work
as expected
Sponsored-by: Catalyst IT
Signed-off-by: severine.queune <severine.queune at bulac.fr>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: David Bourgault <david.bourgault at inlibro.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e1a5c9e8c9e75bbb82184c732803ae8623b50bfd
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Mon Oct 9 08:43:32 2017 +0000
Bug 19437: (followup) Rearrange CancelExpiredReserves tests - fix typos
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 511b3253576262878c953e7a3fe4a2941686ab1e
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Oct 6 10:41:29 2017 +0200
Bug 19437: Rearranging tests for CancelExpiredReserves
This patch originates from a QA Follow-up on bug 19260.
The first 19260 patch adds CancelExpiredReserves tests to Reserves.t.
But note that we already have some tests in Holds/CancelReserves.t.
This patch does:
Renames Holds/CancelReserves.t to Reserves/CancelExpiredReserves.t.
Rearranges modules there.
Moves its existing tests into a first subtest.
Moves the new subtest from Reserves.t to CancelExpiredReserves.t.
Replaces $dbh->do('DELETE FROM reserves').
Adds some TestBuilder statements for missing data (by the move): adding
biblio, item, borrower (removing slow AddMember call).
Test plan:
Run Reserves.t and Reserves/CancelExpiredReserves.t.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 56500e8e676782155c5717e8db9786af394252d8
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Thu Oct 5 10:41:33 2017 +0200
Bug 19415: FindDuplicateAuthority is searching on biblioserver since 16.05
Commit b4392018bc1f9bf6a2f7dfe70b488856ad3a3897 [Bug 12478: make things using SimpleSearch use the new version] changed sub FindDuplicateAuthority and replaced this call (from 3.22.x) in 16.05 (pushed April 2016):
my ($error, $results, $total_hits) = C4::Search::SimpleSearch( $query, 0, 1, [ "authorityserver" ] );
The new call does unfortunately not include the authorityserver:
my ($error, $results, $total_hits) = $searcher->simple_search_compat( $query, 0, 1 );
Simple_search_compat redirects to C4/Search/SimpleSearch and SimpleSearch assumes a biblioserver if no server is passed.
This effectively makes FindDuplicateAuthority useless since we will no longer find duplicates and we could see an error like this in the log:
16:51:42-04/10 zebrasrv(51) [request] Search biblios ERROR 114 1 1+0 RPN @attrset Bib-1 @and @attr 1=authtype PERSO_NAME @attr 1=Heading Moerenhout
The fix is obviously trivial.
Test plan:
[1] Go to Authorities.
[2] Add a new authority PERSO_NAME with 100a Moerenhout.
[3] Repeat step 2. Verify that you get the duplicate authority warning.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
-----------------------------------------------------------------------
Summary of changes:
C4/AuthoritiesMarc.pm | 2 +-
C4/XISBN.pm | 11 +-
Koha.pm | 2 +-
Koha/{Biblios.pm => Acquisition/Basket.pm} | 31 ++--
Koha/{Biblios.pm => Acquisition/Baskets.pm} | 20 ++-
Koha/REST/Plugin/Pagination.pm | 143 +++++++++++++++++
Koha/REST/V1.pm | 1 +
Koha/Subscription.pm | 13 ++
acqui/basket.pl | 1 +
acqui/cancelorder.pl | 4 +
catalogue/ISBDdetail.pl | 1 -
catalogue/detail.pl | 2 +-
catalogue/search.pl | 2 +
.../mysql/de-DE/optional/sample_z3950_servers.sql | 3 +-
.../mysql/en/optional/sample_z3950_servers.sql | 3 +-
.../mysql/es-ES/optional/sample_z3950_servers.sql | 3 +-
.../fr-CA/facultatif/sample_z3950_servers.sql | 1 -
installer/data/mysql/kohastructure.sql | 6 +-
.../mysql/pl-PL/optional/sample_z3950_servers.sql | 3 +-
installer/data/mysql/updatedatabase.pl | 36 +++++
.../prog/en/includes/page-numbers.inc | 19 ++-
.../prog/en/includes/patron-title.inc | 8 +-
koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 52 +++---
.../intranet-tmpl/prog/en/modules/acqui/basket.tt | 4 +-
.../prog/en/modules/acqui/cancelorder.tt | 9 +-
.../prog/en/modules/catalogue/results.tt | 3 +
.../prog/en/modules/circ/circulation.tt | 2 +-
.../intranet-tmpl/prog/en/modules/circ/renew.tt | 2 +-
.../prog/en/modules/help/virtualshelves/shelves.tt | 27 ++--
.../prog/en/modules/members/statistics.tt | 4 +-
.../prog/en/modules/patroncards/edit-template.tt | 9 +-
.../prog/en/modules/virtualshelves/shelves.tt | 7 -
.../bootstrap/en/includes/page-numbers.inc | 26 +--
members/statistics.pl | 3 -
misc/maintenance/touch_all_biblios.pl | 2 +-
misc/maintenance/touch_all_items.pl | 5 +-
opac/opac-detail.pl | 2 +-
opac/opac-search.pl | 2 +
t/Koha/REST/Plugin/Pagination.t | 110 +++++++++++++
t/db_dependent/Holds/CancelReserves.t | 100 ------------
t/db_dependent/Koha/Acquisition/Baskets.t | 65 ++++++++
.../Koha/Subscription.t} | 32 ++--
t/db_dependent/Reserves.t | 63 +-------
t/db_dependent/Reserves/CancelExpiredReserves.t | 166 ++++++++++++++++++++
t/db_dependent/XISBN.t | 8 +-
45 files changed, 716 insertions(+), 302 deletions(-)
copy Koha/{Biblios.pm => Acquisition/Basket.pm} (65%)
copy Koha/{Biblios.pm => Acquisition/Baskets.pm} (73%)
create mode 100644 Koha/REST/Plugin/Pagination.pm
create mode 100644 t/Koha/REST/Plugin/Pagination.t
delete mode 100644 t/db_dependent/Holds/CancelReserves.t
create mode 100644 t/db_dependent/Koha/Acquisition/Baskets.t
copy t/{OpenLibrarySearch.t => db_dependent/Koha/Subscription.t} (55%)
create mode 100644 t/db_dependent/Reserves/CancelExpiredReserves.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list