[koha-commits] main Koha release repository branch master updated. v17.05.00-829-ga82d54d

Fri Oct 13 19:03:37 CEST 2017

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  a82d54d4b4f5eb7aa7d45afc13dac0a80c86f9ce (commit)
       via  e078ae12be45e91f12be8333962bde8c72b0de18 (commit)
       via  f5ea2cf3dd60ba55311e851eec025c55c118c5e3 (commit)
       via  3df96634267b40de3b5d2996ac4ed73e236c0373 (commit)
       via  47c77c0193db428c34f2410a94b44634d3c34579 (commit)
       via  ebffcdf4b938cd5a75ccf02a23341e6af3919ee8 (commit)
       via  5fc8c03b59aa72ef27a0de8ced55b4fafd7d9580 (commit)
       via  84bc17a894fb5023ca69836b4f584392ecfd8373 (commit)
       via  2386e33dbba4c561f3ce465cf1a0970d52b8efd5 (commit)
       via  5c45b2d69bcb17fbadc5e9794e70c5ccc4cfcc0a (commit)
       via  2aba85d811c6c4e89d0b2e1e560549898f098fd9 (commit)
       via  b830349f45007629f141a9835e05b95f90ee4b92 (commit)
       via  a16510a04af5c00b5857e7722cc8c69fb0d0b860 (commit)
       via  0dc722c5183bdd162eba6992a4d38a1a9d28f285 (commit)
       via  c991ac6b6184e299108b5f69d3e0e50dcfc6548d (commit)
       via  6426a82014aacd738dd94ca2ff1c9056af893d45 (commit)
       via  d099dc13bb4b9aa991caa0feaf24bed59c3c4844 (commit)
       via  e54065197515ec265d4bab6ceead35d4456ef0e5 (commit)
       via  cfa1aac9554ea9cba09aec30a4b1f85c09cb5f63 (commit)
       via  4c4d982ae45a3763fd70faedf1bbac225213de19 (commit)
       via  8b3d53db08a5d27a22df338ea4c3c2426992c12a (commit)
      from  307e55a7debdf5e1c960cbfea443b6b160c0ce9a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a82d54d4b4f5eb7aa7d45afc13dac0a80c86f9ce
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Mon Jul 10 14:54:56 2017 +0200

    Bug 18923: Warning in Biblio::GetCOinSBiblio

    Use of uninitialized value in concatenation (.) or string at C4/Biblio.pm line 1456.
    Note: In current master this is now line 1370 (Oct 9, 2017).

    Test plan:
    Enable COinSinOPACResults.
    Select a record with leader pos6==a and pos7==a. This triggers genre to be
    journalArticle and titletype to be a.
    Without this patch, do an opac search that includes this record.
    Check the log. You should see the warning.
    Apply this patch, search again and check the log. The warning should not be
    repeated again.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit e078ae12be45e91f12be8333962bde8c72b0de18
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Oct 13 13:54:43 2017 -0300

    Bug 19186: DBRev 17.06.00.015

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit f5ea2cf3dd60ba55311e851eec025c55c118c5e3
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Fri Oct 13 13:29:53 2017 +0000

    Bug 19186: (QA follow-up) Insert syspref SelfCheckoutByLogin if missing

    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 3df96634267b40de3b5d2996ac4ed73e236c0373
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Sep 27 14:13:05 2017 -0300

    Bug 19186: Change pref choice for SelfCheckoutByLogin - barcode vs cardnumber

    The SelfCheckoutByLogin lists 'Barcode' as an option, but this should be
    Cardnumber. Especially since more and more libraries are using chip
    cards instead of barcodes.

    Signed-off-by: David Bourgault <david.bourgault at inlibro.com>
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 47c77c0193db428c34f2410a94b44634d3c34579
Author: Alex Buckley <alexbuckley at catalyst.net.nz>
Date:   Wed Oct 11 12:43:45 2017 +0000

    Bug 19413: (follow-up) Changed fieldset id value

    Followed test plan again and patch still applies and works as expected.

    Signed-off-by: Dilan Johnpullé <dilan at calyx.net.au>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit ebffcdf4b938cd5a75ccf02a23341e6af3919ee8
Author: Alex Buckley <alexbuckley at catalyst.net.nz>
Date:   Thu Oct 5 15:18:01 2017 +1300

    Bug 19413: Moving the OK and Cancel inputs to the top of the 008 builder

    Followed test plan and patch applies and functions as described
    Signed-off-by: Dilan Johnpullé <dilan at calyx.net.au>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 5fc8c03b59aa72ef27a0de8ced55b4fafd7d9580
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Mon Oct 9 08:07:29 2017 +0000

    Bug 19438: Fix sorting by date due in overdues.pl

    Test plan:
    0) Do not apply the patch
    1) Have some overdued checkouts in your database
    2) Go to circulation -> overdues (overdues.pl)
    3) Try to sort the overdues table by due date and notice it is sorted
    alphabetically, not by date
    4) Apply the patch
    5) Try again and confirm, it is sorted by date

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 84bc17a894fb5023ca69836b4f584392ecfd8373
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Oct 13 13:41:11 2017 -0300

    Bug 19422: Make sure it will never happen again

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 2386e33dbba4c561f3ce465cf1a0970d52b8efd5
Author: David Bourgault <david.bourgault at inlibro.com>
Date:   Fri Oct 6 08:42:32 2017 -0400

    Bug 19422: Missing DROP TABLES in kohastructure.sql

    Adds DROP TABLE statements to the following tables
        - article_requests
        - biblio_metadata
        - deletedbiblio_metadata

    Test plan :
    Clean your database by running 'mysql < kohastructure.sql'.
    Without patch you'll get error messages.
    With patch everything will work fine, no warnings.

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 5c45b2d69bcb17fbadc5e9794e70c5ccc4cfcc0a
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Fri Sep 8 11:52:02 2017 -0400

    Bug 19275: clubs table broken at the opac if public enrollment is not allowed

    Test Plan:
    1. Create a template club and disable public enrollment
    2. Create a club and add it a patron
    3. login at the opac with this patron
    4. Note the borked clubs table
    5. Apply this patch
    6. Refresh the page
    7. Table is fixed!

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 2aba85d811c6c4e89d0b2e1e560549898f098fd9
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Oct 10 10:58:24 2017 -0300

    Bug 19083: Fix 'show all details' link on closed basket detail

    'Show all details' add columns on the basket summary page.
    This link is broken if the basket is closed.

    Indeed there is a JS error raised by $('#toolbar').fixFloat();
    The toolbar is not displayed if the basket is closed.

    This is caused by bug 12333, which added the floating toolbar.

    Test plan:
    Create 2 baskets with orders
    Close 1 basket
    Click on the 'show all details' links and confirm it works as expected
    Also confirm that the toolbar works correctly

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit b830349f45007629f141a9835e05b95f90ee4b92
Author: David Gustafsson <david.gustafsson at ub.gu.se>
Date:   Thu Oct 12 13:57:48 2017 +0200

    Bug 19453: Incorrect jQuery selector for fund drop down validation

    Steps to reproduce:
    1. Create a new basket
    2. Choose "Add to masket"
    3. Choose "From a staged file"
    4. Select a file
    5. Save without selecting a fund

    Expected results: A validation error should be shown, and form submit
    halted.

    Actual results: No validation error is shown and form submits.

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit a16510a04af5c00b5857e7722cc8c69fb0d0b860
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Oct 13 09:16:29 2017 +0200

    Bug 19425: (QA follow-up) Resolve 'push on reference experimental' warn

    QA tools reported for acqui/addorderiso2709.pl
       FAIL   valid: push on reference is experimental

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 0dc722c5183bdd162eba6992a4d38a1a9d28f285
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Fri Oct 6 09:47:26 2017 -0400

    Bug 19425: Adding orders from order file with multiple budgets per record triggers error

    If you import an order file ( using MarcItemFieldsToOrder ) that has a different budget for each item to be ordered, you will get an error and a partially created basket. This is because Koha attempts to add the item to each order *for each budget*. This is clearly incorrect. Instead, we should be grouping items by budget and for each budget only adding those items that have a matching budget.

    Test plan:
    1) Do not apply this patch
    2) Download the provided MARC record
    3) Add the branchcode 'ALD' to your server
    4) Add the ccode 'ACOL' to your server
    5) Add the budget codes 'adultay' and 'branchay' to your server
    6) Stage the order file
    7) Create a basket, import the order file
    8) No we have 3 records, 2 of them have 2 items each with different budget codes
    9) Attempt to import, note the error
    10) Apply this patch
    11) Repeat steps 6-8, note the order completes and results in 5 order lines being added to the basket!

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Christopher Kellermeyer <ckellermeyer at altadenalibrary.org>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    First step of test plan amended (not apply instead of apply).

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit c991ac6b6184e299108b5f69d3e0e50dcfc6548d
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Fri Oct 13 10:05:08 2017 +0000

    Bug 18374: (QA follow-up) Fix auto truncation for field:"value"

    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 6426a82014aacd738dd94ca2ff1c9056af893d45
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Fri Oct 13 09:53:04 2017 +0000

    Bug 18374: (QA follow-up) Simplify _truncate_terms

    By using a different split regex, we can simplify a bit the process of
    appending '*' to every word of the query

    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit d099dc13bb4b9aa991caa0feaf24bed59c3c4844
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Oct 6 15:37:38 2017 +0000

    Bug 18374: (follow-up) Add support and tests for quoted strings

    To test:
    1 - prove t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
    2 - do some searches in staff client and test results

    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit e54065197515ec265d4bab6ceead35d4456ef0e5
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Fri Sep 29 16:12:23 2017 +0200

    Bug 18374: (QA follow-up) Tidy up code

    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit cfa1aac9554ea9cba09aec30a4b1f85c09cb5f63
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Tue Sep 12 12:15:07 2017 -0300

    Bug 18374: (QA follow-up) Remove warning in Elasticsearch/Search.pm

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 4c4d982ae45a3763fd70faedf1bbac225213de19
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Apr 3 14:30:44 2017 -0400

    Bug 18374: Respect QueryAutoTruncate syspref in Elasticsearch

    This patchset adds a subroutine '_truncate_terms' to the ES QueryParser.

    If QueryAutoTruncate is enabled this function will be called for any
    search to add wildcard '*' to all terms

    To test:
    1 - Enable Elasticsearch and have some records indexed
    2 - Search for partial terms
    3 - Note they fail unless '*' is appended
    4 - Apply patch, leave QueryAutoTruncate disabled
    5 - Note partial term searches still fail
    6 - Enable QueryAutoTruncate
    7 - Note partial term searches succeed
    8 - Do some regular and advanced searches to make sure results are as
    expected

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 8b3d53db08a5d27a22df338ea4c3c2426992c12a
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Apr 6 14:27:50 2017 -0400

    Bug 18374: QueryAutoTruncate unit tests

    To test:
    1 - Apply just this patch - should fail
    2 - Apply the other patch - should pass

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-----------------------------------------------------------------------

Summary of changes:
 C4/Biblio.pm                                       |    4 +-
 Koha.pm                                            |    2 +-
 Koha/SearchEngine/Elasticsearch/QueryBuilder.pm    |   32 ++++++++
 Koha/SearchEngine/Elasticsearch/Search.pm          |    4 +-
 acqui/addorderiso2709.pl                           |    4 +-
 circ/overdue.pl                                    |    3 +-
 installer/data/mysql/kohastructure.sql             |    3 +
 installer/data/mysql/sysprefs.sql                  |    1 +
 installer/data/mysql/updatedatabase.pl             |   11 +++
 koha-tmpl/intranet-tmpl/prog/css/staff-global.css  |    9 +++
 .../prog/en/modules/acqui/addorderiso2709.tt       |    2 +-
 .../intranet-tmpl/prog/en/modules/acqui/basket.tt  |    2 +-
 .../en/modules/admin/preferences/circulation.pref  |    2 +-
 .../cataloguing/value_builder/marc21_field_008.tt  |    2 +-
 .../intranet-tmpl/prog/en/modules/circ/overdue.tt  |   10 ++-
 .../bootstrap/en/modules/clubs/clubs-tab.tt        |    8 +-
 t/{Makefile.t => check_kohastructure.t}            |   44 +++++------
 .../Koha_SearchEngine_Elasticsearch_Search.t       |   79 +++++++++++++++++++-
 18 files changed, 178 insertions(+), 44 deletions(-)
 copy t/{Makefile.t => check_kohastructure.t} (54%)

hooks/post-receive
-- 
main Koha release repository