[koha-commits] main Koha release repository branch 16.05.x updated. v16.05.17-71-g7c859a0
Git repo owner
gitmaster at git.koha-community.org
Tue Oct 24 08:22:44 CEST 2017
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 16.05.x has been updated
via 7c859a06957c205d28d9f11117d360bab6cf3780 (commit)
via 6e746e038a80d438e1562ecdadccc895cc72956b (commit)
via d5ac7d7d064358a94830563710f172dd528bee04 (commit)
via a49e29d7f5719750136403ebb6abb29f31a3b71c (commit)
via c0c699d0fb30ae72b6716a9e6e6edabbc583e034 (commit)
via 4b5c19df302a9738f315166ce5b9f0fff7f8116b (commit)
via 14e82ee30d0bbd24870d9e62c63a2968d15c0493 (commit)
via b02a0af06e92d244aa65b7cc2b451b74fc02bc0f (commit)
via 356047b920ddb96f587fea1631c64fbd6da8bc2d (commit)
via cd397d30b3f4d9c93ee836bafec96927d154f91f (commit)
via 0c9920bae163f8c700d0a6fced64dc433d7f19c2 (commit)
via 7faad3cef92b5e75ec1cf2761f5168c4b64388c7 (commit)
via 2af51f0b681cfc0e92f5360f4875b35f2f84aec7 (commit)
via 04c7552ac5fdd9ffa1d367f076754c44dd7d8d51 (commit)
via a47b8ca9ba8fafda5427e8ab3280cd1d67cfd5cd (commit)
via 3d61ff3e5da5b8ce9fee7b7f1eb04189c7f83f24 (commit)
via a832183e6cee084934b028ae46aec44e87c11eb7 (commit)
via 0e17d3bb329eeb3bb9e31aecfeddf5366ddae1d5 (commit)
via 01f6f3e57c3ebceb0555491a85c6804e8c7f7ec5 (commit)
via d77faf51ff094e17b016c345ab5472f300498b09 (commit)
via 2d6507a47ff7a7cb8518b0cb02848526bb558f07 (commit)
via 13c461793281d8065ddc76e8aa5cff90dd061496 (commit)
via 6bf4853fd862c4ee66ca9770bbe74d0bb933afe0 (commit)
via 1301ba18a60f1bd26be64b70147caaff840131f6 (commit)
via 39bb40f593da37e3f49fa906c3764cdeab589819 (commit)
via 0fe65fd42a654ccccf04d1609303e236d4ffa2c3 (commit)
via 182292e0a51e35fcff5433bd6d6c7c7b318d18b3 (commit)
via 76fd41c9857e433206632ac0185aa03e4c6b5c31 (commit)
via 3ebb4bd2e80f6bfd79c881fae2511645d1f80c11 (commit)
via a1be3908f2b31605ea83831220edd9ee855e5ffc (commit)
via b1aef2bd92729c5e120cbd350459b24a431a7f22 (commit)
via 2ff6f63cd055f2edcc60a212a646a1a488bed443 (commit)
via bf9fde7fa29369d0e0076280b27ac6f8afd089bd (commit)
via ce21b3a9d95f538be592627fe88d4cd8525bcab7 (commit)
via c4d30720d1874e270b71896647cd788fc87eaf27 (commit)
via 478d7297df3587503caad48734215ad5ffcf9d36 (commit)
via 708eff99dabb527b95a0b23fc2a71a1b513dd3ca (commit)
via 1a750d873e5a2931080d47129b3c36890c61bbe8 (commit)
via 0353dc2cec48d30640c1eac9bfc32c43e2a9d8dd (commit)
via 4ff8245ed2b14b91e2a47b06606dcf5eb97c1b2e (commit)
via a44af993d0aa32cc8852125afdfcc2fa12e2a274 (commit)
via 51e9dac429d7947ec40b84bdd9da4704bd85e5ff (commit)
via f26db1e56058f590a9128bd7324bfe5eaa1820e6 (commit)
via b26323891a763ca1e5de4cfd276dd46c06af0bef (commit)
via 9a6fae9a38f336ff590faf86cc0a89b356aee932 (commit)
via 14de764e5e737d512f42c8a51ccf8aba7112a649 (commit)
via 5bca22d7cf69d2cd1f351a9c2b276b74c242436d (commit)
via 75b85ad02e91999d3bb0cdaf7c8e0f77d9baedae (commit)
via c29db07813802fdafadd76a0db0aab1a83def15b (commit)
via 930d54f3cc9fdb9a05b2e0c707bda1dece00360a (commit)
via eabbc7f9de5d2aeba4b1c44baeafb9e2ecd9603e (commit)
via b09bf03d4e324e63eb8336df7d7a5a9414c0231b (commit)
via 4fc60a9afd8b00044e8a7d07b86186faea2bd6e3 (commit)
via b335a3abac06e1c5eb86e5f4375ed9e9765adc80 (commit)
via 9a79340b8f7697604707463c495f66fd52e3c544 (commit)
via 3320e622572850d4d0e6170d33391499e9020781 (commit)
via 7a9cef0b8a02cc6f5a9bca6cfc4326bf91475436 (commit)
via b2b1ee07cf024bc57ec268fd5c0e9e2ac9544b31 (commit)
via cb555851c644763bdd3c80676524b0c23fd79b3a (commit)
via 5c6f4968e05bbf92d4794f559be3296533993841 (commit)
via e3d4b94d67b5c325a3dcb25f555a6b3a4fd6cb48 (commit)
via 23d2002d424e58bc39e04a415b4d9ecf487cbe88 (commit)
via 68ac3ef2f39d37e88e128b885d2fb08600c7ddfa (commit)
via f76cfe153d41096f678683eed51d7e57dca645ba (commit)
via 8f20c30c3a9c8192c61cafbfe5117d7101d5932a (commit)
via 2b06af4eb3589ec06f03fc916c55a4b749f288af (commit)
via 12cb749e836efbcc10f37a23b14ffabe0fdc454a (commit)
via f1e25582b51c6d7911ffd430e5e10bcae80963d3 (commit)
via 9ce9b8db50c9701de650504bb147f656c251aacf (commit)
via ba82664d6f75977e9d737882386f8decc7813b63 (commit)
via 0b1d54a54409fc11a5f1db61fee68dda19fa3471 (commit)
from 1210a897592f1e213bd49c5a08cd4e8f62973940 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 7c859a06957c205d28d9f11117d360bab6cf3780
Author: Mason James <mtj at kohaaloha.com>
Date: Tue Oct 24 16:19:54 2017 +1300
[16.05.x] Small fixes for various tests
commit 6e746e038a80d438e1562ecdadccc895cc72956b
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Fri Sep 15 11:12:01 2017 +0200
Bug 19323: subscription edit permission issue
If a librarian has edit_subscription but not create_subscription :
When trying to edit a subscription, after saving permission is denied.
This is because permissions in serials/subscription-add.pl depends on arg 'op' and on edit this arg starts with 'modify' but changes to 'modsubscription' when saving.
Test plan :
- Create a user with staff access
- Define its permissions on serials : only edit_subscription
- Edit a subscription
- Click 'Next'
- Click 'Test prediction pattern'
- Click 'Save subscription'
=> Without patch you get to page serials/subscription-add.pl with permission denied
=> With patch subscription is saved and you get to subscription details page
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit 12bd6358cfe6c9348cb111d22f04097f7911babf)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit fe386c172496159198b34383c3080185de7ae0af)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit d5ac7d7d064358a94830563710f172dd528bee04
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Fri Sep 1 21:23:20 2017 -0400
Bug 19120: Leave cancelled ordered items alone when reopening basket
TEST PLAN
---------
1) Apply first patch
2) prove t/db_dependent/Acquisition/close_reopen_basket.t
-- FAILS
3) Apply this patch
4) prove t/db_dependent/Acquisition/close_reopen_basket.t
-- SUCCESS!
5) run koha qa test tools
Followed test plan, patch worked as described
Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit a49e29d7f5719750136403ebb6abb29f31a3b71c
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Fri Sep 1 21:21:40 2017 -0400
Bug 19120: Add tests to reproduce the problem
TEST PLAN
---------
1) apply this patch
2) prove t/db_dependent/Acquisition/close_reopen_basket.t
-- FAILS!
-- This proves the test works.
3) run koha qa test tools
Followed test plan, patch worked as described
Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit c0c699d0fb30ae72b6716a9e6e6edabbc583e034
Author: Alex Arnaud <alex.arnaud at biblibre.com>
Date: Fri Oct 6 07:19:15 2017 +0000
Bug 19418: (bug 12833 follow-up) Add missing use statement
Patron search fail on calling svc/members/search. This script
return a 500 error and the search stay on "Processing..."
Test plan:
- Enable ExtendedPatronAttributes system preference,
- make a standard search (search fields),
- check the search works and it doesn't stick on "Processing..."
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
I do not recreate the issue, but the change make sense and the issue has
been raised by several people
(cherry picked from commit 9c208a44313ed1f4bd12f8c9d3b45c5f2d386c5b)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit 2d04c80b37cb2f37f9709b8bcfc6b9a4e4eaaae9)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit 4b5c19df302a9738f315166ce5b9f0fff7f8116b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Oct 3 12:15:30 2017 -0300
Bug 19350: Add tests
commit 14e82ee30d0bbd24870d9e62c63a2968d15c0493
Author: Dobrica Pavlinusic <dpavlin at rot13.org>
Date: Wed Sep 20 16:01:16 2017 +0200
Bug 19350 - Holds without link in 773 trigger SQL::Abstract::puke
Test:
1. find bibio without items which has something in field 773
(for us, it's article) but doesn't have 0 or 9 (host item entry)
2. click on hold in left menu
3. verify application error
4. apply patch and verify that it works
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit b02a0af06e92d244aa65b7cc2b451b74fc02bc0f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Oct 9 15:57:46 2017 -0300
Bug 19440: Existing calls need to be done in scalar context
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 356047b920ddb96f587fea1631c64fbd6da8bc2d
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Oct 9 15:36:41 2017 -0300
Bug 19440: Identify overlimit problems in XISBN tests
This patch makes C4::XISBN::get_xisbns() return an errors hashref
including information of the failing fetches from xisbn services.
It tackles the situation of XISBN, which in some cases returns 'overlimit'
errors.
The patch makes the relevant functions check if the response->{stat} string
is 'ok' and returns the string in $errors otherwise.
This only happens when in list context. This allows to fix the randomly failing
tests while keeping the current behaviour.
All this code should be rewritten. It does the job bug doesn't have problems handling
or reoprting. This is just a band aid.
To test:
- Make sure
k$ prove t/db_dependent/XISBN.t
=> SUCCESS :-D
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit cd397d30b3f4d9c93ee836bafec96927d154f91f
Author: Christophe Croullebois <christophe.croullebois at biblibre.com>
Date: Wed Aug 23 07:57:30 2017 +0000
Bug 19165 - When adding from a staged file order discounts are not passed into C4::Acquisitions::populate_order_with_prices
Signed-off-by: Your Name <david.bourgault at inlibro.com>
commit 0c9920bae163f8c700d0a6fced64dc433d7f19c2
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Oct 9 16:20:49 2017 -0300
Bug 18996: (followup) Fix tests count [16.11.x]
This patch fixes a wrong tests count introduced on merging.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit 7faad3cef92b5e75ec1cf2761f5168c4b64388c7
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Thu Mar 30 04:15:54 2017 +0000
Bug 18351: Able to delete budget with funds
To test:
1) Create a budget, add a fund
2) Delete budget. Notice this is successful and triggers no warning
message etc.
3) Go to Funds. Notice the funds appear as if they are not there
4) Go into mysql and view the aqbudgetperiods table - notice the funds
are still there and are now inaccessible.
5) Apply patch
6) Create a budget, add a fund
7) Attempt to delete budget. Notice you can't click Delete button.
Confirm number of funds in hover message is correct.
8) Delete fund
9) Confirm you can now delete budget.
Sponsored-by: Catalyst IT
Signed-off-by: Felix Hemme <felix.hemme at thulb.uni-jena.de>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Bug 18351: [FOLLOW-UP] Some code fixes
See Comment 5. Ready to test.
Signed-off-by: Lee Jamison <ldjamison at marywood.edu>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Bug 18351: [FOLLOW-UP] Code fix
See comment 10.
Ready for testing.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Bug 18351: [FOLLOW-UP] Prevent deletion from forcing URL
This patch adds a check in the script for existing funds so that the
budget cannot be deleted when forcing the URL and has other small fixes.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Bug 18351: [FOLLOW-UP] Prevent deletion if funds are added after clicking 'Delete' and before confirming delete
Followed test plan and patch works as described.
Signed-off-by: Dilan Johnpullé <dilan at calyx.net.au>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit 0ed469525fe16e36663c1f5266568beb5e27672d)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit 2a9dc2e595d916e4fb94948871f665df06b7088b)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit 2af51f0b681cfc0e92f5360f4875b35f2f84aec7
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Tue Sep 5 21:16:05 2017 +0000
Bug 19257: Prevent warn when reopening a basket
To test:
1) Go to Acquisitions, find a vendor and a basket (create if you don't
have either)
2) Close the basket
3) View the basket and reopen it
4) Notice the warn
5) Apply the patch and repeat steps 1-3
6) Notice the warn no longer shows and the basket is reopened as
expected
Sponsored-by: Catalyst IT
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit 6ed1513e5fe91772c1720963006bf8f04452416d)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit f1677e56ecf1ea5f0ce2a408f1f11e931639e1d5)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit 04c7552ac5fdd9ffa1d367f076754c44dd7d8d51
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Thu Aug 31 21:25:28 2017 +0000
Bug 19229: Return to course when cancelling out of edit form
To test:
1) Ensure UseCourseReserves is enabled
2) Go to Course Reserves, create a course
3) Edit course
4) Click Cancel
5) Notice you are returned to the courses home page rather than returned
to the course
6) Apply patch
7) Go to edit course and click cancel again
8) Confirm you are returned to the course and that this feels like the
natural expectation.
Sponsored-by: Catalyst IT
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit f55af2fc078a7d6a05238232bc276e6924307179)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit ae405f61c8d4c04361267b500347a496a2ce7d58)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit a47b8ca9ba8fafda5427e8ab3280cd1d67cfd5cd
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Sep 6 13:14:56 2017 -0300
Bug 17834: Make translation easier
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 3d61ff3e5da5b8ce9fee7b7f1eb04189c7f83f24
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Thu Apr 20 03:12:14 2017 +0000
Bug 17834: Change library news text for single-branch libraries
To test:
1) Log into OPAC, go to home page
2) Confirm that the text shows as 'RSS feed for (branchname) library
news' if single-branch library
3) Confirm text shows as normal for libraries with more than one branch
Sponsored-by: Catalyst IT
Signed-off-by: maricris <mlabancia at gmail.com>
Signed-off-by: anafe <anafeazuela at yahoo.com>
Signed-off-by: iflora <iflora at unimas.my>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit a832183e6cee084934b028ae46aec44e87c11eb7
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Tue Oct 3 16:01:15 2017 +0200
Bug 19343: [16.11.X] Remove private lists with edit permission from search results
If the list is not shared, it should not be listed. We only need to remove
the allow_add line.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Conflicts:
Koha/Virtualshelves.pm
commit 0e17d3bb329eeb3bb9e31aecfeddf5366ddae1d5
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Oct 3 11:45:45 2017 -0300
Bug 19343: [16.11.X] Add tests
Conflicts:
t/db_dependent/Virtualshelves.t
commit 01f6f3e57c3ebceb0555491a85c6804e8c7f7ec5
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sat Aug 19 10:22:44 2017 +0200
Bug 14316: Clarify meaning of record number in Batch record modification tool
Same change as the first patch, but for the batch record
modification tool.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit d77faf51ff094e17b016c345ab5472f300498b09
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Mon Jun 8 02:03:34 2015 +0200
Bug 14316: Clarify meaning of record number in Batch record deletion tool
Changes the label from 'list of record numbers...' to
'List of biblionumbers or authority ids...' to make it
more clear to the user which kind of input is expected.
To test:
- Go to Tools > Batch record deletion
- Check the new description
- Decide if it's more clear or not
Signed-off-by: Marc Veron <veron at veron.ch>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 2d6507a47ff7a7cb8518b0cb02848526bb558f07
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Sep 1 08:41:51 2017 -0400
Bug 18946 [QA Followup] - code cleanup
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 13c461793281d8065ddc76e8aa5cff90dd061496
Author: Karam Qubsi <karamqubsi at gmail.com>
Date: Wed Jul 19 00:06:48 2017 +0800
Bug 18946 - Change language from external web fails
How to reproduce:
1. Get a multilingüal Koha like
http://demo1.orex.es/cgi-bin/koha/opac-changelanguage.pl?language=en
http://demo1.orex.es/cgi-bin/koha/opac-changelanguage.pl?language=es-ES
2. Copy that urls to any web page in an other domain -it must be in some
host - and try to link to the spanish or english version,it will keep you in the same position.
3. Apply this patch and try again , everything should work fine .
Signed-off-by: Hugo Agud <hagud at orex.es>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 6bf4853fd862c4ee66ca9770bbe74d0bb933afe0
Author: Lari Taskula <lari.taskula at jns.fi>
Date: Wed May 31 17:03:54 2017 +0300
Bug 18692 - intranet part
Fixes misplaced columns introduced by previous patch and adds the "-" for phone
transport type.
To test:
1. Set SMSSendDriver system preference on
2. Go to intranet messaging preferences
3. By default you should see checkboxes for all messages for SMS
4. Ensure columns are not misplaced (pushing one column too much to the right)
5. Delete sms method from one of the messages in message_transports table
6. Observe that "-" is displayed instead of checkbox for that message for SMS
7. Repeat same for TalkingTechItivaPhoneNotification system preference.
By default it may not have transports in message_transports, so make sure
to assign some in order to have the checkboxes visible.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 1301ba18a60f1bd26be64b70147caaff840131f6
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Thu Jun 1 17:22:42 2017 +0200
Bug 18692 - same with syspref TalkingTechItivaPhone
Fixes misplaced columns introduced by previous patch and adds the "-" for phone
transport type.
To test:
1. Set SMSSendDriver system preference on
2. Go to intra and OPAC messaging preferences
3. By default you should see checkboxes for all messages for SMS
4. Ensure columns are not misplaced (pushing one column too much to the right)
5. Delete sms method from one of the messages in message_transports table
6. Observe that "-" is displayed instead of checkbox for that message for SMS
7. Repeat same for TalkingTechItivaPhoneNotification system preference.
By default it may not have transports in message_transports, so make sure
to assign some in order to have the checkboxes visible.
https://bugs.koha-community.org/show_bug.cgi?id=8692
Signed-off-by: Michael Andrew Cabus <michael at bywatersolutons.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 39bb40f593da37e3f49fa906c3764cdeab589819
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Mon May 29 16:32:18 2017 +0200
Bug 18692 - When SMS is enabled the OPAC messaging table is misaligned
Bug 6726 had corrected the fact that when SMS is enabled the messaging table is missing a column.
Bug 6458 has broken this.
The SMS column is missing an else case with cell containing only "-" like other columns.
Test plan :
- set SMSSendDriver preference empty
- go to OPAC patron messaging
- column SMS should not be visible
- set SMSSendDriver preference not empty
- go to OPAC patron messaging
- column SMS appears with checkboxes
Signed-off-by: Michael Andrew Cabus <michael at bywatersolutons.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 0fe65fd42a654ccccf04d1609303e236d4ffa2c3
Author: Marc Véron <veron at veron.ch>
Date: Wed Aug 9 09:46:02 2017 +0200
Bug 18636: Sysprefs: Add explanation for conflict autonumbernum / BorrowerMandatoryFields
This patch adds a note to the system preferences autonembernum and
BorrowerMandatoryFields regarding a conflict if automembernum is on
and BorrowerMandatoryFields contains cardnumber.
To reproduce issue: See initial comment.
To test:
- Apply patch
- Verify that in system preferences note appears with both prefs
automembernum and BorrowerMandatoryFields
Followed test plan, works as described
Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit 65bce82b1fb32d3d98fe4d4ef1e1738a97749632)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit 07695e8de40c55f2837ae81b5e35b8e11656f272)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit 182292e0a51e35fcff5433bd6d6c7c7b318d18b3
Author: Marc Véron <veron at veron.ch>
Date: Tue Jun 27 18:50:44 2017 +0200
Bug 16485: collection column in Item search is always empty
This patch fills the column 'Collection' in item search from the item values.
To test:
- Go to item search
- Reproduce issue from initial comment
- Apply patch
- Verify that the column 'Collection' is filled
Still to do, but outside of my datatable skills:
Filter by drop down in the column header does a substring search.
Example: Filter for 'Fiction" returns both 'Fiction' and 'Non-fiction' items.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Laurence Rault <laurence.rault at biblibre.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit 6c1504cfdb301cb0f9f3a14b5db31a63f5c3b0a5)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit 74752502b309ddec4311a4311a3481bf54061187)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit 76fd41c9857e433206632ac0185aa03e4c6b5c31
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date: Wed Aug 2 17:12:44 2017 +0100
Bug 19024 Do not unset order cancelled status on basket close
On closing a basket, status is updated to ordered for orders not
completed. However the operation was resetting the status for
cancelled as well as new orders.
While display is correct from the basket view (it checks the
cancellation date). The status in the acquisitions tab from the
catalogue view reverts erroneously to ordered.
This patch adds cancelled to the statuses not updated on basket
close.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 3ebb4bd2e80f6bfd79c881fae2511645d1f80c11
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date: Tue Aug 15 11:44:12 2017 +0100
Bug 19024 Fix some infelicities of phrasing in test messages
The test messages were awkwardly phrased, re phrase them to
sound more natuaral. Patch is cosmetic (grammar) only
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit a1be3908f2b31605ea83831220edd9ee855e5ffc
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Aug 9 16:09:32 2017 -0300
Bug 19024: Add tests
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit b1aef2bd92729c5e120cbd350459b24a431a7f22
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Sep 1 16:20:18 2017 -0300
Bug 9857: Fix failing tests
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 2ff6f63cd055f2edcc60a212a646a1a488bed443
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Sep 1 16:20:18 2017 -0300
Bug 9857: Fix failing test
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit bf9fde7fa29369d0e0076280b27ac6f8afd089bd
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Fri Aug 18 08:36:59 2017 +0000
Bug 9857 - Follow-up - Fix for searches with su= or su:
When the initial search is su=.../su:... the links was
not constructed correctly. With this change, it should
be the case.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit ce21b3a9d95f538be592627fe88d4cd8525bcab7
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Fri Dec 4 01:17:50 2015 +0100
Bug 9857: Did you mean? uses wrong punctuation in search links
The link changes the search links generated by the plugins
from an=authid to an:authid, as suggested by Jared on the
bug report.
- Turn on the AuthorityFile und ExplodedTerms plugins
for the OPAC from the "Did you mean" section of the
administration module
- Search a term in your OPAC where one or several
authorities exist.
A last name or a place name might work well.
- Verify that there are suggestions displayed on top of
your result list.
- Verify that the link created is something like:
/cgi-bin/koha/opac-search.pl?q=an=14084
- Apply patch.
- Verify the link has changed a little and still works
correctly:
/cgi-bin/koha/opac-search.pl?q=an:14084
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit c4d30720d1874e270b71896647cd788fc87eaf27
Author: Alex Buckley <alexbuckley at catalyst.net.nz>
Date: Wed Jul 12 10:09:48 2017 +1200
Bug 18621: Added in value attribute to dateexpiry field
Test plan:
1. Create a patron category with the dateexpiry value of 29/9/2017
2. Create a patron user from that patron category (which I'll refer to as patron A) with the date
expiry value of 1/10/2017 and submit the form
3. Notice that the manual dateexpiry you have submitted is correctly
displayed
4. Create a duplicate patron with the same firstname and surname and
patron A, and set the date expiry value of 1/10/2017 and submit the form
5. The form displays a duplicate patron message. Notice that the dateexpiry input box is empty now
6. Select the new member (not a duplicate member) option in the
messagebox
7. The form successfully submits and notice that the date expiry value
displayed is that of the patron category (i.e. it is 29/9/2017) not the
dateexpiry value of 1/10/2017 that you manually set for this patron
8. Apply patch
9. Repeat step 4
10. The form displays a duplicate patron message. Notice the dateexpiry input box still
contains the value you entered which is 1/10/2017. Select the new member
(not a duplicate member) option in the messagebox
11. The form successfully submits and notice that the date expiry value
displayed is 1/10/2017 that you manually set for this patron
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit 515e62992893b72c54a34311088a9442a37d8138)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit 60b6d736ee306198af83e1a1482ff89280a05e7b)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit 478d7297df3587503caad48734215ad5ffcf9d36
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Jun 15 11:07:03 2017 -0400
Bug 18812 - SIP Patron status does not respect OverduesBlockCirc
To test:
1 - Set 'OverduesBlockCirc' to block
2 - Find or create a patron with overdues
3 - Perform a SIP patron lookup on that patron
misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL
--patron {userid or cardnumber} --password {pass} -m patron_information
4 - Note the first character of response is a ' '
5 - Apply patch
6 - Restart memcached, apache, and plack
7 - Perform SIP patron lookup
8 - Note the first character of response is 'Y'
9 - prove t/db_dependent/SIP/Patron.t
10 - Test should return green
Signed-off-by: Chris Kirby <chris.kirby at ilsleypubliclibrary.org>
Works as advertised
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit ff4f0858950c37eeede38b2f067841602b97d7ba)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit 4b360f1371a56268458b62e5c8c68da853b4e52d)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit 708eff99dabb527b95a0b23fc2a71a1b513dd3ca
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Jul 31 09:18:15 2017 -0400
Bug 19007 - Allow paypal payments via debit or credit card again
A recent change in Paypal has removed the previous default option of paying via debit or credit card without an account. To bring this option back, we need to send an additional parameter to the PayPal API.
Test Plan:
1) Enable paypal for your Koha instance
2) Ensure you are not logged in to PayPal
3) Attempt to pay a fine via PayPal
4) Not the the "Pay with Debit or Credit Card" option is missing
5) Apply this patch
6) Refresh opac-account.pl
7) Attempt to make a payment via PayPal again
8) Note the option "Pay with Debit or Credit Card" is now available
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: George Williams <gwilliams at nekls.org>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 1a750d873e5a2931080d47129b3c36890c61bbe8
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Feb 26 14:46:45 2016 +0000
Bug 15924 - Coce not enabled on lists
To test:
Enable Coce and disable other image services
Load a list and not there are no covers
Apply patch
Load a list and note there are covers
https://bugs.koha-community.org/show_bug.cgi?id=15924
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit 85b963d11fb5d8674ca6b0ec60821663f9d8cf19)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit 669b6839eab456f36ed7c65a7a97fa7b386ab4e6)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit 0353dc2cec48d30640c1eac9bfc32c43e2a9d8dd
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Sep 18 14:23:54 2017 -0300
Bug 19335: Fix 00-merge-conflict-markers.t when dockerised
This does not make sense, but fix a bug (why?)
Without this patch, the tests failed on po files:
[17:14:26] t/00-merge-conflict-markers.t .. Failed 1/1 subtests
Test Summary Report
-------------------
t/00-merge-conflict-markers.t (Wstat: 9 Tests: 0 Failed: 0)
Non-zero wait status: 9
Parse errors: Bad plan. You planned 1 tests but ran 0.
Result: FAIL
Note that this is not related to bug 19227.
if the ^>>>>>> and ^<<<<<< matches are done on the same line, the test fail
As saw it failed on *-pref.po files
misc/translator/po/kn-Knda-pref.po
misc/translator/po/ja-Jpan-JP-pref.po
misc/translator/po/nl-BE-pref.po
misc/translator/po/sr-Cyrl-pref.po
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit 0d03f143e25f498de780d2ddd1972c3be7947519)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit bdfec37ab66f9c72f86adc7d6045bc83b5a92d88)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit 4ff8245ed2b14b91e2a47b06606dcf5eb97c1b2e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Aug 31 11:47:11 2017 -0300
Bug 19227: Reduce the number of tests run by 00-merge-conflict-markers.t
The number of tests on jenkins is sometimes confusing:
https://jenkins.koha-community.org/job/Koha_Master_D8/lastCompletedBuild/testReport/(root)/t_00_merge_conflict_markers_t/
shows that 00-merge-conflict-markers.t ran 10,751 tests, 124 less than
the previous run. However 124 files have not been removed from the
codebase!
I suggest to count only 1 test for all files.
Moreover files from blib and cover_db are counted, they should be
excluded.
Test plan:
prove t/00-merge-conflict-markers.t
must return green
echo ">>>>>>>" >> mainpage.pl
and run the test again
It should now fail
Signed-off-by: Magnus Enger <magnus at libriotech.no>
Works as advertised.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit a44af993d0aa32cc8852125afdfcc2fa12e2a274
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Oct 5 17:42:21 2017 -0300
Bug 18794: Fix test ListMetadataFormats in OAI/Server.t
This test may fail on slow servers, it compares the response date with
'now', but both can differ a bit.
https://jenkins.koha-community.org/job/Koha_Master_D8/198/consoleFull
Failed test 'ListMetadataFormats'
at t/db_dependent/OAI/Server.t line 150.
Structures begin differing at:
$got->{responseDate} = '2017-06-12T14:31:51Z'
$expected->{responseDate} = '2017-06-12T14:31:50Z'
commit 51e9dac429d7947ec40b84bdd9da4704bd85e5ff
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Wed Jun 28 00:40:00 2017 +0000
Bug 18871: Make patron list name a link to view contents of list
The link is the same as the 'Add patrons' button in Actions dropdown,
but requires one less click, and makes finding the contents of the list
more obvious.
To test:
1) Go to Tools -> Patron lists
2) Create a patron list if you haven't already
3) Confirm that clicking the name of the list takes you to the correct
list and shows the expected content.
Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit d51059807690797aa4d16b0c0dd2932235a3b683)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit e570915729b6b8e02e22b0cfdff4440b75815d26)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit f26db1e56058f590a9128bd7324bfe5eaa1820e6
Author: Marc Véron <veron at veron.ch>
Date: Mon Jun 12 09:07:28 2017 +0200
Bug 18781: Translatability: Get rid of exposed tt directives in openlibrary-readapi.inc
The file koha-tmpl/opac-tmpl/bootstrap/en/includes/openlibrary-readapi.inc
exposes template directives to translation. The only string that should
appear in .po from this file is "Open Library: "
To test:
- Apply patch
- Verify that code changes make sense
- Bonus test: create a new language 'aa-AA', verify in aa-AA-opac-bootstrap.po
that there is only the following string for openlibrary-readapi.inc:
msgid "Open Library: "
msgstr ""
NOTE: Followed a test plan similar to bug 18776 comment 3
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit 23cc8b39682fea7b0a9150933c65c34ef22d23dd)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit 861fa8c8db8bd8bbd6281863d5029d55675f359c)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit b26323891a763ca1e5de4cfd276dd46c06af0bef
Author: Marc Véron <veron at veron.ch>
Date: Mon Jun 12 08:41:41 2017 +0200
Bug 18780: Translatability: Get rid of exposed tt directive in masthead-langmenu.inc
The file opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc exposes following tt directive to translators:
"[%% IF ( ( opaclanguagesdisplay ) && ( ! one_language_enabled ) && "
"( languages_loop ) && ( OpacLangSelectorMode == 'both' || "
"OpacLangSelectorMode == 'top') ) %%] "
This patch fixes it.
To test:
- Apply patch
- Verify that language selector in OPAC (top of the page) works as expected
- Bonus test: create a new language 'aa-AA', verify that line above does not
show up in aa-AA-opac-bootstrap.po
NOTE: Followed a test plan similar to bug 18776 comment 3
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit 255cadeb772d63b06f77146c95b8d6e4b31d5836)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit e0adbc10c09c25310f79fec55518fb5df50ad040)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit 9a6fae9a38f336ff590faf86cc0a89b356aee932
Author: Marc Véron <veron at veron.ch>
Date: Mon Jun 12 08:20:56 2017 +0200
Bug 18779: Translatability: Get rid of exposed tt directives in authorities-search-results.inc (OPAC)
The file opac-tmpl/bootstrap/en/includes/authorities-search-results.inc
exposes template directives to translation where translators should not
be confronted with.
Example:
"[%% PROCESS showreference heading=seeals.heading linkType='seealso' "
"type=seeals.type authid=seeals.authid %%] "
To test:
- Apply patch
- Verify that Authority search in OPAC works as before
- Bonus test: create a new language 'aa-AA', verify that line above
does not show up in aa-AA-opac-bootstrap.po
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit 331320f93a5ef5293c3bcad80b9554ddea0196b0)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit 4dc640244651c584347b01f35f2cb25b6369a638)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit 14de764e5e737d512f42c8a51ccf8aba7112a649
Author: Marc Véron <veron at veron.ch>
Date: Sun Jun 11 16:54:28 2017 +0200
Bug 18776: Translatability: Get rid of exposed tt directives in opac-advsearch.tt
The file opac-advsearch.tt exposes template directives to translation where translators should not be confronted with.
Example in po file:
"[%% IF ( ( OpacAdvSearchOptions and OpacAdvSearchOptions.grep('itemtype')."
"size > 0 and not expanded_options ) or ( OpacAdvSearchMoreOptions and "
"OpacAdvSearchMoreOptions.grep('itemtype').size > 0 and expanded_options ) ) "
"%%] "
To test:
- Apply patch
- Verify that advanced search in OPAC behaves as before
- Create a new translation for a 'language' aa-AA (perl translate create aa-AA)
- Verify that template directives ar no longer exposed in aa-AA-opac-bootstrap.po
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit ae684fc9491102ba0b560ca6f414a325e763b31a)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit b1bce06e515e22482ca555b85da19f965b475f5f)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit 5bca22d7cf69d2cd1f351a9c2b276b74c242436d
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Aug 4 16:44:51 2017 +0200
Bug 18754: [QA Follow-up] Tiny corrections
Converted one INCLUDE directive to PROCESS; we are not changing variables here. (The PROCESS directive is slightly faster than INCLUDE because it avoids the need to localise (i.e. copy) the variable stash before processing the template.)
Removed one vim inserted letter i.
Error in [% IF ( XISBN.publicationyear ) _ ', ' _ XISBN.publicationyear %][% END %] The concatenation became part of the condition.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit ff591f2c77a2a3c1de4a0e7167ccfeba08c2f128)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit 78e527129b0b547eff7311c3f25a4b1f679d2a97)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit 75b85ad02e91999d3bb0cdaf7c8e0f77d9baedae
Author: Marc Véron <veron at veron.ch>
Date: Fri Jun 9 15:43:36 2017 +0200
Bug 18754: Translatability: Get rid of exposed tt directives in opac-detail.tt
The file opac-detail.tt exposes a lot of template directives to translation where translators should not be confronted with.
Some examples from po file are:
$[% SUBFIELD.code %] [% SUBFIELD.value %]
%s [%% INCLUDE \"openlibrary-readapi.inc\" bib = { normalized_isbn => "
"normalized_isbn, lccn => lccn, normalized_oclc => normalized_oclc } %%]
See: [% IF ( nextTitle ) %][% nextTitle |html %][% ELSE %]next biblio[% END "
"%]
To test:
- Apply patch
- Do a search in OPAC that has more than 1 results
- Go to the detail page of one of the items found
- Verify that the details display as before and that you can
browse the results with Previous and Next
- In staff client, change OPACXSLTDetailsDisplay from 'default' to
empty for "no xslt" and repeat steps above
- In staff client, set HTML5MediaEnabled to 'OPAC' or 'OPAC and staff client'
- Verify that media catalogued in field 856 still work
- Create a new translation for a 'language' aa-AA (perl translate create aa-AA)
- Verify that template directives ar no longer exposed in aa-AA-opac-bootstrap.po
Followed test plan which works as intended
Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit 752aef4593f1aa2d64700bf9738e7e03907eb1cd)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit 65e09b28dbbe43772b9104ffcafa1f81441c4d70)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit c29db07813802fdafadd76a0db0aab1a83def15b
Author: Marc Véron <veron at veron.ch>
Date: Sun May 28 09:34:21 2017 +0200
Bug 18687: Translatability: abbr tag should not contain lang attribute
In manage-marc-import.tt, we have an abbreviation:
<abbr title="Differences between the original biblio and the imported" lang="en">Diff</abbr>
In translations (e.g. German), the line appears as follows:
<abbr title="Unterschiede zwischen Originaltitelsatz und importiertem Titelsatz" lang="en">Diff</abbr>
The lang attribute is wrong here, it is still "en".
The text language is the same as defined at the top of the page - or with other
words, the lang tag is superfluous.
This patch removes it.
To test:
Verify that code change makes sense.
Passes QA test and the change is logical
Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit 03c7f9366c97d6402e1e16182d7a2ddbbe37eccb)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit 9f96a3bb39c8fcb246a3caeeb2d7a24f46da7153)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit 930d54f3cc9fdb9a05b2e0c707bda1dece00360a
Author: Lee Jamison <ldjamison at marywood.edu>
Date: Fri Aug 11 18:58:53 2017 +0000
Bug 19088: plugins-upload causes error log noise
After uploading a plugin the error log indicates
use of uninitialized value in $op. This patch
silences the noise.
To test:
1) Set <enable_plugins> to 1 (one) in koha-conf.xml.
2) Set the UseKohaPlugins system preference to 'Enable'.
3) Navigate to Administration -> Manage plugins.
4) Install the test plugin KPZ file attached to this bug.
5) Notice the uninitialized value noise in the error log.
6) Uninstall the plugin (plack restart may be required if plack is
enabled).
7) Apply patch.
8) Install the plugin again.
9) Notice no noise in the error log.
10) Run qa tools.
11) Run prove t/db_dependent/Plugins.t
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit 1076a0edf32b621da54c53ea71595885f7e14c38)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit cdcc0458b796aff59a50e0f5d4c7b7140682eacf)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit eabbc7f9de5d2aeba4b1c44baeafb9e2ecd9603e
Author: Amit Gupta <amit.gupta at informaticsglobal.com>
Date: Tue Aug 15 22:21:37 2017 +0530
Bug 19118 - Due to wrong variable name passed vendor name is not coming in browser title bar
Test
1. Hit the page /cgi-bin/koha/acqui/supplier.pl?booksellerid=xx
xx is a booksellerid
2. Apply the patch and reload the page.
3. You can see vendor name in browser title bar.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit b09bf03d4e324e63eb8336df7d7a5a9414c0231b
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed Aug 16 13:15:19 2017 +0200
Bug 19126: Fix Members.t with IndependentBranches set
If you enabled that pref, Members.t fails with:
t/db_dependent/Members.t .. 63/63 # Looks like you failed 15 tests of 63.
The first one is:
t/db_dependent/Members.t .. 32/63
Failed test 'Staff patron not deleted from list'
at t/db_dependent/Members.t line 304.
Bottle neck is GetBorrowersToExpunge. The results of that sub depend on the
state of this preference.
Trivially fixing it here by disabling the pref before the first call.
Test plan:
[1] Do not apply this patch yet. Enable IndependentBranches.
[2] Run Members.t and observe that it fails.
[3] Apply this patch. And run Members.t again. It should pass now.
Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 4fc60a9afd8b00044e8a7d07b86186faea2bd6e3
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Aug 11 15:09:00 2017 -0300
Bug 9409: (QA followup) Add --dbhost help to koha-create man page
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit b335a3abac06e1c5eb86e5f4375ed9e9765adc80
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Fri Jun 23 01:46:50 2017 +0000
Bug 9409: Add --dbhost parameter and dbhost field
This allows setting the remote db host correctly for
request-db either with a command-line or passwd file.
Signed-off-by: Lee Jamison <ldjamison at marywood.edu>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 9a79340b8f7697604707463c495f66fd52e3c544
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Jul 7 11:25:24 2017 +0000
Bug 18469: QA Follow-up
Restore datepicker class
Use Koha.Preference
Copy changes to moremember
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit a66c0b1dd76a2fe08ed7ac189ad8a564372ab3a9)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit c26108afa776b9de93ebe7c334c0eeff8ea2ed98)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit 3320e622572850d4d0e6170d33391499e9020781
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Apr 21 10:08:27 2017 -0400
Bug 18469: Suspend all holds when specifying a date to resume hold does not keep date
Name of field had 'datepicker' embedded, this caused variable issue
To test:
1 - Place several holds for a patron
2 - Go to holds tab in circulation
3 - Select a date for suspend all holds until
4 - Suspend all holds
5 - Note date is not used, suspended indefinitely
6 - Apply patch
7 - Resume all suspended holds
8 - Select a date for suspend all holds until
9 - Suspend all holds
10 - Note date is used
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
(cherry picked from commit a58745d9dbbf98c79f4c1a3e7cd40fb45425fc91)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
(cherry picked from commit fec723524cbd972b4788f34e105908697c43ea01)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
commit 7a9cef0b8a02cc6f5a9bca6cfc4326bf91475436
Author: Marc Véron <veron at veron.ch>
Date: Wed Aug 2 18:01:06 2017 +0200
Bug 19027 - Circulation rules: Better wording for standard rules for all libraries
In Home > Administration > Circulation and fine rules, the standard value for
"Select a library: All libraries" is confusing and leads to support cases.
Change wording to "Standard rules for all libraries".
To test:
- Apply patch
- Go to Home > Administration > Circulation and fine rules
- Verfiy that text in drop down 'Select a library' makes sense.
Followed test plan which works as intended. I agree with the wording it
is significantly clearer than previously
Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit b2b1ee07cf024bc57ec268fd5c0e9e2ac9544b31
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Jul 14 11:25:42 2017 +0000
Bug 18941 - C4::Budgets GetBudgetByCode should return active budgets over inactive budgets
To test:
1 - Create an active budget
2 - Create an inactive budget
3 - Ensure they each have a fund with the same code
4 - Set MarcFieldsToOrder to get the budget_code from a marc field
5 - Stage a file using the duplicated code
6 - Add to a basket from the staged file
7 - Add the items
8 - Note funds are encumbered from the inactive budget
9 - Apply patch
10 - Repeat 5-8 with a new basket
11 - Note the active budget is now used
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit cb555851c644763bdd3c80676524b0c23fd79b3a
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Jul 14 11:06:16 2017 +0000
Bug 18941 - Unit tests
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 5c6f4968e05bbf92d4794f559be3296533993841
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Thu Aug 10 09:24:08 2017 +0200
Bug 19071: Fix Members/IssueSlip.t
Resolve:
DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha_master`.`clubs`, CONSTRAINT `clubs_ibfk_2` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`)) [for Statement "DELETE FROM branches"] at t/db_dependent/Members/IssueSlip.t line 44.
We do not need to delete all branches here.
Note: The test still needs attention for noisy userenv warns, but it should
pass now.
Test plan:
Run t/db_dependent/Members/IssueSlip.t
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit e3d4b94d67b5c325a3dcb25f555a6b3a4fd6cb48
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Thu Aug 10 09:13:44 2017 +0200
Bug 19071: Fix Circulation/issue.t
Resolve:
DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha_master`.`clubs`, CONSTRAINT `clubs_ibfk_2` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`)) [for Statement "DELETE FROM branches"] at t/db_dependent/Circulation/issue.t line 65.
Cause:
See also bug 19070.
We do not need to delete all branches here.
Test plan:
Run t/db_dependent/Circulation/issue.t
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 23d2002d424e58bc39e04a415b4d9ecf487cbe88
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Aug 10 15:06:39 2017 -0300
Bug 19047: Fix AddBiblio call in ShelfBrowser.t
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 68ac3ef2f39d37e88e128b885d2fb08600c7ddfa
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Mon Aug 7 08:44:43 2017 +0200
Bug 19047: Fix AddBiblio call in Reserves.t
AddBiblio does not return a title; the biblioitemnumber is stored in the
title variable.
The variables for biblioitemnumber are not used and can be removed.
Test plan:
Run t/db_dependent/Reserves.t
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit f76cfe153d41096f678683eed51d7e57dca645ba
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Aug 7 11:04:51 2017 -0300
Bug 19013: (QA followup) Set guarantorid to NULL patron sample data
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 8f20c30c3a9c8192c61cafbfe5117d7101d5932a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Jul 31 16:12:16 2017 -0300
Bug 19013: Fix borrowers.guarantorid in sammple_patrons.sql
That breaks randomly tests on Jenkins (Koha/Patrons.t)
It certainly affects data in other languages but I did not find a quick
and easy way to modify this file (replace all guarantorid values with
NULL)
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Easy fix
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 2b06af4eb3589ec06f03fc916c55a4b749f288af
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Oct 11 10:50:18 2017 -0300
Bug 19441: Remove ES-related tests
16.05.x do not provided stable ES support, it will take us too much time
to keep these tests up-to-date.
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 12cb749e836efbcc10f37a23b14ffabe0fdc454a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Oct 9 18:32:18 2017 -0300
Bug 19441: Fix t/db_dependent/Biblio/TransformKohaToMarc.t
Koha::Caches and Koha::MarcSubfieldStructures do not exist in 16.05.x
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit f1e25582b51c6d7911ffd430e5e10bcae80963d3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Oct 9 18:27:23 2017 -0300
Bug 19441: Fix t/db_dependent/Biblio/Isbd.t
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 9ce9b8db50c9701de650504bb147f656c251aacf
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Oct 9 18:25:36 2017 -0300
Bug 19441: Fix AutomaticItemModificationByAge.t
Koha::Caches does not exist in 16.05.x
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit ba82664d6f75977e9d737882386f8decc7813b63
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Oct 9 18:23:58 2017 -0300
Bug 19441: Fix AuthorisedValues.t
Koha::AuthorisedValueCategor[y|ies] do not exist in 16.05.x
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 0b1d54a54409fc11a5f1db61fee68dda19fa3471
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Oct 9 18:21:03 2017 -0300
Bug 19441: Fix xt/sample_notices.t
fr-CA is not up-to-date:
- RESERVESLIP have been renamed with HOLD_SLIP
- PASSWORD_RESET and MEMBERSHIP_EXPIRY are not defined
Signed-off-by: Mason James <mtj at kohaaloha.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Acquisition.pm | 8 +-
C4/Budgets.pm | 5 +-
C4/Items.pm | 7 ++
C4/SIP/ILS/Patron.pm | 3 +-
C4/Utils/DataTables/Members.pm | 1 +
C4/XISBN.pm | 11 +-
Koha/SuggestionEngine/Plugin/AuthorityFile.pm | 5 +-
Koha/SuggestionEngine/Plugin/ExplodedTerms.pm | 7 +-
Koha/Virtualshelves.pm | 38 +++++++
acqui/addorderiso2709.pl | 1 +
acqui/basket.pl | 2 +-
admin/aqbudgetperiods.pl | 30 ++++--
catalogue/detail.pl | 2 +-
circ/circulation.pl | 2 -
debian/docs/koha-create.xml | 10 +-
debian/scripts/koha-create | 18 +++-
.../data/mysql/de-DE/optional/sample_patrons.sql | 24 ++---
.../data/mysql/en/optional/sample_patrons.sql | 24 ++---
.../data/mysql/es-ES/optional/sample_patrons.sql | 24 ++---
.../mysql/fr-CA/obligatoire/sample_notices.sql | 6 +-
.../mysql/nb-NO/2-Valgfritt/sample_patrons.sql | 24 ++---
.../data/mysql/pl-PL/optional/sample_patrons.sql | 24 ++---
.../en/includes/catalogue/itemsearch_item.json.inc | 3 +-
.../prog/en/includes/messaging-preference-form.inc | 20 +++-
.../prog/en/modules/acqui/supplier.tt | 2 +-
.../prog/en/modules/admin/aqbudgetperiods.tt | 40 +++++---
.../prog/en/modules/admin/preferences/patrons.pref | 2 +
.../prog/en/modules/admin/smart-rules.tt | 2 +-
.../prog/en/modules/catalogue/itemsearch.tt | 4 +-
.../prog/en/modules/circ/circulation.tt | 6 +-
.../prog/en/modules/course_reserves/course.tt | 2 +-
.../prog/en/modules/members/memberentrygen.tt | 2 +-
.../prog/en/modules/members/moremember.tt | 6 +-
.../prog/en/modules/patron_lists/lists.tt | 2 +-
.../prog/en/modules/tools/batch_delete_records.tt | 2 +-
.../en/modules/tools/batch_record_modification.tt | 2 +-
.../prog/en/modules/tools/manage-marc-import.tt | 2 +-
.../en/includes/authorities-search-results.inc | 28 ++----
.../bootstrap/en/includes/masthead-langmenu.inc | 8 +-
.../bootstrap/en/includes/openlibrary-readapi.inc | 10 +-
.../bootstrap/en/modules/opac-advsearch.tt | 24 ++---
.../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 83 ++++++++-------
.../opac-tmpl/bootstrap/en/modules/opac-main.tt | 14 ++-
.../bootstrap/en/modules/opac-messaging.tt | 10 +-
.../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 20 +++-
members/moremember.pl | 2 -
opac/opac-account-pay.pl | 1 +
opac/opac-changelanguage.pl | 14 ++-
opac/opac-detail.pl | 2 +-
plugins/plugins-upload.pl | 2 +-
serials/subscription-add.pl | 3 +-
t/00-merge-conflict-markers.t | 30 +++---
t/SuggestionEngine_AuthorityFile.t | 2 +-
t/db_dependent/Acquisition/close_reopen_basket.t | 25 ++++-
t/db_dependent/Biblio/Isbd.t | 1 +
t/db_dependent/Biblio/TransformKohaToMarc.t | 18 ++--
t/db_dependent/Budgets.t | 24 ++++-
t/db_dependent/Circulation/issue.t | 1 -
t/db_dependent/Items.t | 17 +++-
.../Items/AutomaticItemModificationByAge.t | 5 +-
t/db_dependent/Koha_Elasticsearch. | 23 -----
t/db_dependent/Koha_Elasticsearch_Indexer.t | 55 ----------
.../Koha_SearchEngine_Elasticsearch_Search.t | 106 --------------------
t/db_dependent/Members.t | 4 +
t/db_dependent/Members/IssueSlip.t | 1 -
t/db_dependent/OAI/Server.t | 6 +-
t/db_dependent/Reserves.t | 6 +-
t/db_dependent/SIP/Message.t | 2 +-
t/db_dependent/SIP/Patron.t | 34 ++++++-
t/db_dependent/ShelfBrowser.t | 2 +-
t/db_dependent/SuggestionEngine_ExplodedTerms.t | 4 +-
t/db_dependent/Template/Plugin/AuthorisedValues.t | 3 +-
t/db_dependent/Virtualshelves.t | 91 ++++++++++++++++-
t/db_dependent/XISBN.t | 8 +-
74 files changed, 593 insertions(+), 469 deletions(-)
delete mode 100644 t/db_dependent/Koha_Elasticsearch.
delete mode 100644 t/db_dependent/Koha_Elasticsearch_Indexer.t
delete mode 100644 t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list