[koha-commits] main Koha release repository branch master updated. v17.05.00-979-g6d677ef
Git repo owner
gitmaster at git.koha-community.org
Fri Oct 27 19:16:02 CEST 2017
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 6d677ef82f44d44d8533a6fddb14952c60cd88b8 (commit)
via 3cb853ed8feda20b0f619278026aed283d7fa2e5 (commit)
via e9a7333833dbfa4e5f5514afb4654981a7691336 (commit)
via 2a1120c9ddccb8bb96c030ef906a93f6f84091b2 (commit)
via 8003dde3c9014101273902405514d7ca8bee76ea (commit)
via cc0cf2b4562eb8da53fbfb10460e5cb440b57c0b (commit)
via 6197f92a3f88db2b727f1ece9b4687064aa21f13 (commit)
via 9d1d3cd7fe5e7bec6fcb92f5553e4229b6d57f16 (commit)
via 22249e4ceda925792a62c203b16bac3c4e35a1af (commit)
via 377c9f15896e2ee4515f8b31a6424d5ec9d89f17 (commit)
via 6835760dcfa60abec027af3ff0cfafca8aea6f14 (commit)
via ab586abaee5efac2e5f7b652c5b226465698fb87 (commit)
via ff23e78f7b48e170b5b94864ff3639f8dd151b6a (commit)
via 774b9d5fd8197ffb40096be89947b3d3efe61398 (commit)
via edaebf2565fd4e5840d98813f6077445aa9b6bd5 (commit)
via 63a9c26fe5d5ec5b2ca1b5c7e61c78b4a26455bc (commit)
via ae4d8942925d1515fdb759fdbf27bf4944c3b158 (commit)
via ad1e2a517814b9cdb04dfed30b29d167b5304c85 (commit)
via 966b92a803f79082a10a9d84553f1f0b2d868024 (commit)
via 99caf5329ba2fecd7296c0d85baf49ffb8d6cd81 (commit)
via d25719d22312f300cde397e3a6d44ce496e998a1 (commit)
via 2f2d84316a445625c406ca22ceb692df01b5acd4 (commit)
via 70d72e3d9c072dd5e59c57026898bbd44fe7e1a7 (commit)
via 7c27958e6bd711abf34021fdfdf9063567e1e292 (commit)
via ad790bed2df9254416d23418d1c9348516a0ae9f (commit)
via 506d669424fd85edb7986fd045bde0821964bc1f (commit)
via ffee02e41dc319d5656addc10c7a63ee4afada8d (commit)
via 657c417a87f356479c82b11a602006f4f9ab375c (commit)
via 3d6e33134e94f49513e999ab0ca1414ef0e66b4a (commit)
via 7f7a6879b2df3cf52c56f4d75d020e34e60e7221 (commit)
via 64899db254375c39bd8e50583861a5e16f4616e8 (commit)
via c398cfa37781dd71f0a6eedba0a466f4d6edbee9 (commit)
via 9ac7f85375f9474c3f43b18ef6cead0c9a44d53f (commit)
via a3c4ce01b36bacf1169bd1897bf7f22a4ab992a8 (commit)
via 3b4e0e697879a229b2fa213362ebee0f1a988eb2 (commit)
via 4a4b3aa9486e97cd247042d0e13e418570719be0 (commit)
via 377bd10e0cb8c25d7f3201644b2bba4b732d4abf (commit)
via 088cdcda5f0d3f2df15644a481b50fbf4eac9fd2 (commit)
via bf6caa81e5dba170f75183caf3479c3d4856832a (commit)
via 27b99bb80b9f7bcf185c91d9fdb283813038ce71 (commit)
via bb1c184b840610a7f40409ec801317acd700e406 (commit)
via 30a0d4f6c97e783868128c051465722aefd95ac7 (commit)
via 99e487bc7162cee4bb9a8916637f4e1ddd7ccc00 (commit)
via bdf85f5e39edeb1e2e85629044f1df25f56484f5 (commit)
via a70c38f38001ec34749c9f4cc38a4eef9d2ed04a (commit)
via 83f97e662d77c99666c7873c947b91f9e8630a17 (commit)
via 971591d4ee8576d6782d32610bbae7cfe4674231 (commit)
via a522df7dd97f5d7e646966d9b7f4f18fe8df7e2d (commit)
via 27fca7aceb91124c037bb3545c351d3cf185e7bf (commit)
via 18809b137113c36115af1d165a3236901a42bc91 (commit)
via 58b6e957638418fea8d5a25e21da3530574db3e1 (commit)
via 264432f701d47ae166258a0d412b9089a9e05efe (commit)
via 48be40d1bfaf13a70b6bf4918e885d9158e25f66 (commit)
via 4f2d59e67b6d938ca2798fe8b7fc3ec6eda1d253 (commit)
via 3f2c1c879c0bdb920f00d968b6d25f3fd8635f95 (commit)
via c4113dce705a700acf1d7d271a044d1f555d7c81 (commit)
via 6336e53aedabccf50481c68c45929d90a463b8dd (commit)
via e08a0afa264f55294bda4a5d949012ad60639616 (commit)
via 570eb4026642f71e462c7746a9c91721aa9334c1 (commit)
from e6b8e123917275fa483d35649071f5847a425aef (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 6d677ef82f44d44d8533a6fddb14952c60cd88b8
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Oct 13 15:16:59 2017 -0300
Bug 19462: Add koha-elasticsearch documentation
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3cb853ed8feda20b0f619278026aed283d7fa2e5
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Oct 13 15:11:07 2017 -0300
Bug 19462: Add a koha-elasticsearch command
This patch adds a new command to be used for Elasticsearch-related
tasks.
The current implementation only offers the --rebuild action switch,
that allows reindexing Elasticsearch on a per-instance basis as we are
used to with the rest of the koha-* commands.
Other options could be added in a future: --status (ES server status
report, etc).
To test:
- Apply the whole patchset
- Have a suitable Koha+Elasticsearch setup [1]
- Run:
$ reset_all
- Run:
$ man koha-elasticsearch
=> SUCCESS: A pretty man page is displayed covering all options
- Run:
$ sudo koha-elasticsearch blah
=> SUCCESS: The script fails because blah is not a valid instance name
- Run:
$ sudo koha-elasticsearch -v kohadev
=> SUCCESS: Reindex happens!
- Try the -a, -b and -c option switches
- Sign off happily :-D
Sponsored-by: ByWater Solutions
[1] This is straightforward if you are using KohaDevBox and created the
box using: $ KOHA_ELASTICSEARCH=1 vagrant up
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e9a7333833dbfa4e5f5514afb4654981a7691336
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Sun Jan 1 07:17:55 2017 +0000
Bug 17467: Restart failing, missing instance parameter
This follow up should make it work. Perhaps there is a more
elegant way, but wanted to generate something that works.
Before this patch, the --restart stops Zebra, but does not
restart it. After, it does restart.
Before this patch, the --status gives nasty long help.
After this patch, reasonable output.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 2a1120c9ddccb8bb96c030ef906a93f6f84091b2
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Oct 19 15:54:52 2016 -0300
Bug 17467: Add tab-completion for koha-zebra
This patch adds tab-completion for bash, for the koha-zebra script.
To test:
- Run (on the vagrant user):
$ source kohaclone/debian/koha-common.bash-completion
- Run:
$ sudo koha-zebra -<TAB>
(<TAB> means press the tab key)
=> SUCCESS: Tab completion works as expected for the koha-zebra command.
- Sign off :-D
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 8003dde3c9014101273902405514d7ca8bee76ea
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Oct 19 11:24:01 2016 -0300
Bug 17467: (follow-up) Make the install script install koha-zebra
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit cc0cf2b4562eb8da53fbfb10460e5cb440b57c0b
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Oct 18 17:11:55 2016 -0300
Bug 17467: Add koha-zebra documentation
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 6197f92a3f88db2b727f1ece9b4687064aa21f13
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Oct 18 16:23:20 2016 -0300
Bug 17467: (follow-up) Make koha-zebra handle legacy script names
This patch adds the new koha-zebra script the ability to handle being
called by other script names, for backwards compatibility with the legacy
koha-*-zebra scripts.
It is intended to be used in conjunction with a patch that replaces the old
koha-*-zebra scripts for symbolic links, pointing to the new koha-zebra script.
To test:
- Apply this patch
- Create symbolic links to the new script:
vagrant at kohadevbox:~$ ln -s kohaclone/debian/scripts/koha-zebra koha-start-zebra
vagrant at kohadevbox:~$ ln -s kohaclone/debian/scripts/koha-zebra koha-stop-zebra
vagrant at kohadevbox:~$ ln -s kohaclone/debian/scripts/koha-zebra koha-restart-zebra
- Run:
$ sudo ./koha-start-zebra kohadev
=> SUCCESS: Same behaviour than the koha-start-zebra script
- Run:
sudo ./koha-stop-zebra kohadev
=> SUCCESS: Same behaviour than the koha-stop-zebra script
- Run:
sudo ./koha-restart-zebra kohadev
=> SUCCESS: Same behaviour than the koha-restart-zebra script
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9d1d3cd7fe5e7bec6fcb92f5553e4229b6d57f16
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Aug 12 18:54:07 2016 -0300
Bug 17467: Add koha-zebra script to handle Zebra daemons
This script is intended to replace the following currently used scripts
on packages setups:
- koha-start-zebra
- koha-stop-zebra
- koha-restart-zebra
It also introduces a --status option switch, for asking for daemon statuses
To test
- Apply the patch
- Run:
$ sudo debian/scripts/koha-zebra --start kohadev
=> SUCCESS: same behaviour than koha-start-zebra kohadev
- Run:
$ sudo debian/scripts/koha-zebra --stop kohadev
=> SUCCESS: same behaviour as koha-stop-zebra kohadev
- Run:
$ sudo debian/scripts/koha-zebra --restart kohadev
=> SUCCESS: same behaviour than koha-restart-zebra kohadev
- Run:
$ sudo debian/scripts/koha-zebra --status kohadev
=> SUCCESS: It correctly shows the status for the running (or not) process
Play with different combinations of this commands
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 22249e4ceda925792a62c203b16bac3c4e35a1af
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Jul 11 15:36:54 2016 +0000
Bug 16899: Add ability to disallow overpayments
Some SIP services ( such as Comprise ) require that an attempt at
over-paying a patron's account via SIP2 should fail, rather than create
a credit on the account. We should make this a configurable option on a
per-login basis in the SIP2 config file.
Test Plan:
1) Apply this patch
2) Enable the new parameter
disallow_overpayment="1"
for the login to be used in this test.
3) Restart your SIP server
4) Create or find a patron with fines
5) Attempt to send a payment via SIP for more than what the
patron's balance is
6) Note the response indicates a payment failure
7) Attempt to send a payment via SIP for the account balance or
less
8) Note the response indicates the payment has succeeded
9) Verify in Koha that the payment was processed
Signed-off-by: Rhonda Kuiper <kuiper at roundrocktexas.gov>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 377c9f15896e2ee4515f8b31a6424d5ec9d89f17
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sat Aug 26 15:09:41 2017 +0000
Bug 19178: Remove outdated sms/* scripts and related files
Those files appear unmaintained and unusable with current
Koha and should be removed.
It appears at some point there was work done on a feature
to send SMS messages to a phone number using a form in
the tools area.
This has never been documented, files and git history
make it look like work remained unfinished.
sms/sms_listen_windows_start.pl
- targetted for Windows, which is not supported by Koha
00-strict.t
- reference to sms removed
sms/sms_listen.pl
- refers to a table sms_messages that doesn't exist
- uses getmember() that doesn't exist
sms/sms.pl
- script calls routines that no longer exist in SMS.pm
error_codes(), parse_phone(), write_sms()
- template sms-home.tt is not accessible form anywhere
in the templates
sms-home.tt
- see sms/sms.pl
Signed-off-by: Magnus Enger <magnus at libriotech.no>
Makes sense. 00-strict.t runs OK after applying the patch.
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 6835760dcfa60abec027af3ff0cfafca8aea6f14
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Oct 26 10:46:03 2017 +0000
Bug 18389: (QA follow-up) Fix tabs, note used template, info on verbose
Fixed whitespace for QA tools
Added a verbose note when template found
Only print 'Modifying MARC' if verbose
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ab586abaee5efac2e5f7b652c5b226465698fb87
Author: Jon Knight <J.P.Knight at lboro.ac.uk>
Date: Wed Aug 23 09:03:38 2017 +0000
Bug 18690: Add error if there are multiple MARC templates with the same name
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ff23e78f7b48e170b5b94864ff3639f8dd151b6a
Author: Jon Knight <J.P.Knight at lboro.ac.uk>
Date: Tue May 30 18:12:15 2017 +0100
Bug 18690: Use MARC modification templates with bulkmarcimport.pl
When importing large numbers of MARC records from a legacy LMS to Koha
using bulkmarcimport.pl, it did not make use of the MARC modification
templates in the system (which can be useful for coversion of 852
fields to 952 fields for item holdings for example). This patch allows
MARC modification templates to be used with bulkmarcimport.pl.
To test:
1) Apply patch.
2) Set up a MARC modification template (in Home > Tools > MARC
modification templates) to make some changes to imported MARC
records (for example copy a subfield).
3) Take a test set of MARC records that have fields matching the
template and import them using the bulkmarcimport.pl tool. For example
if these MARC records are in testrecords.mrc and the MARC modification
template is called testtemplate use something like:
perl misc/migration_tools/bulkmarcimport.pl -commit 1000 \\
-file testrecords.mrc -marcmodtemplate testtemplate
4) Check the imported records in Koha to see that the required
modifications have been applied when the MARC records are imported.
5) Sign off.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 774b9d5fd8197ffb40096be89947b3d3efe61398
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Oct 24 18:10:40 2017 -0300
Bug 10267: Display the message only if the user enters too many characters
It seems better to display the warning if the user tries to enter too
many characters in the input.
Test plan:
With max=16
1. Copy/paste a string with 15, 16 and 17 characters
2. Enter a cardnumber of 15, 16, 17 characters
The warning should be displayed only the input overflows
Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit edaebf2565fd4e5840d98813f6077445aa9b6bd5
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Thu Apr 20 03:35:47 2017 +0000
Bug 10267: Show error message if user tries to enter too many characters for cardnumber
This patch displays a message if the user tries to enter more than the
max number of characters for a cardnumber.
To test:
1) Apply patch and go to Patrons -> New patron
2) Scroll down to Card number
3) Put in any characters. Notice that when you have entered the max
number of characters, you are unable to type any more.
4) Click out of the text field (so it loses focus), the error message will show up.
5) if you backspace some characters and click out of the text field
again, the message should disappear
Sponsored-by: Catalyst IT
Followed test plan, works as expected
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 63a9c26fe5d5ec5b2ca1b5c7e61c78b4a26455bc
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Oct 27 14:07:48 2017 -0300
Bug 13178: DBRev 17.06.000.025
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ae4d8942925d1515fdb759fdbf27bf4944c3b158
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Oct 27 13:26:51 2017 -0300
Bug 13178: DBIC Schema changes
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ad1e2a517814b9cdb04dfed30b29d167b5304c85
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Oct 24 15:04:32 2017 +0000
Bug 13178: (QA follow-up) fix kohastructure and update info in fields
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 966b92a803f79082a10a9d84553f1f0b2d868024
Author: Baptiste Wojtkowski <baptiste.wojtkowski at biblibre.com>
Date: Mon Jun 26 10:25:44 2017 +0000
Bug 13178: Correct Max cardnumberlength
($max is the value of the max size of a card number)
- $max not hardcoded anymore in C4::Memeber
- $max now correctly adapts to the field of cardnumber in database
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 99caf5329ba2fecd7296c0d85baf49ffb8d6cd81
Author: Baptiste Wojtkowski <baptiste.wojtkowski at biblibre.com>
Date: Mon Jun 19 15:04:28 2017 +0000
Bug 13178: increase max value of CardnumberLength
testplan
1 - Apply patch
2 - Run updatedatabase.pl
3 - Update dbix scheme
4 - set the value of CardnumberLength to a value between 16 and 32
5 - Check you can enter a propper cardnumber
(modify to 32 instead 20)
+ max value now depends on the database field value to
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d25719d22312f300cde397e3a6d44ce496e998a1
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Thu Aug 31 00:16:17 2017 +0000
Bug 19216: Fix broken table in OPAC for when club doesn't allow public enrolment
To test:
1) Apply bug 19214 and bug 19215 to fix other issues with patron clubs
2) Create a club template that DOES NOT allow public enrollment
3) Create a club, enrol a user
4) Log in as that user to the OPAC
5) Go to 'your summary' and click the Clubs tab
6) Notice the broken table with empty column
7) Edit the club template to allow public enrollment
8) Notice the table is fixed - so this bug is just when the club does
not allow public enrollment
9) Apply the patch
10) Edit the club template to NOT ALLOW public enrollment
11) Confirm the table in the OPAC is now fixed and does not leave an
empty column
Sponsored-by: Catalyst IT
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 2f2d84316a445625c406ca22ceb692df01b5acd4
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Oct 27 09:30:17 2017 +0200
Bug 17214: (QA follow-up) Print error message too in fallback case
If the error code is not known or empty, provide the message too.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Tested this by adding a die on shelves.pl line 180 (my $added = eval ..)
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 70d72e3d9c072dd5e59c57026898bbd44fe7e1a7
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Thu Apr 20 01:50:38 2017 +0000
Bug 17214: Add records to lists by biblionumber
To test:
1) Apply patch and go to Lists
2) Click on an existing list or create a new list
3) Add items by barcode, confirm this functionality still works
4) Trigger error messages (adding duplicate barcodes, barcodes that
don't exist) to confirm they still show as appropriate
5) Test adding by biblionumber, confirm this works as expected
6) Trigger error messages (adding duplicate biblionumbers, biblionumbers
that don't exist). Confirm wording is appropriate in messages.
7) Add both barcodes and biblionumbers at the same time, confirm this
works as expected
Sponsored-by: Catalyst IT
Signed-off-by: Israelex A Veleña for KohaCon17 <israelex19 at gmail.com>
Signed-off-by: Israelex A Veleña for KohaCon17 <israelex19 at gmail.com>
Signed-off-by: Harold <harold.sabanal at gmail.com>
Signed-off-by: macon lauren KohaCon2017 <caballeromaricon at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Bug 17214: [FOLLOW-UP] Using Koha::Biblios instead of GetBiblio
Ready to test
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7c27958e6bd711abf34021fdfdf9063567e1e292
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Oct 27 14:05:14 2017 -0300
Bug 2093: DBRev 17.06.000.024
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ad790bed2df9254416d23418d1c9348516a0ae9f
Author: Owen Leonard <oleonard at myacpl.org>
Date: Sat Apr 29 05:04:38 2017 +0000
Bug 2093: [Compiled CSS] Add OPAC dashboard for logged-in users
This patch contains the CSS file compiled from LESS.
Signed-off-by: Hugo Agud <hagud at orex.es>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
RM note: opac.css regenerated before push:
lessc --clean-css="--s0 --advanced --compatibility=ie7" bootstrap/less/opac.less > bootstrap/css/opac.css
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 506d669424fd85edb7986fd045bde0821964bc1f
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Wed Aug 2 23:25:35 2017 +0000
Bug 2093: (follow-up) Add OPAC dashboard for logged-in users
This patch:
- hides the dashboard if there is no dashboard information to display
- changes '5.00 due' to '5.00 due in fines and charges' for translation
- uses Koha::Holds in place of deprecated C4::Reserves methods
To test, confirm all the right information for holds still shows, and
confirm the dashboard is hidden if there are no checkouts, holds, fines
or overdues.
Signed-off-by: Hugo Agud <hagud at orex.es>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ffee02e41dc319d5656addc10c7a63ee4afada8d
Author: Owen Leonard <oleonard at myacpl.org>
Date: Sat Apr 29 04:57:42 2017 +0000
Bug 2093: (follow-up) Add OPAC dashboard for logged-in users
This patch adds some additional markup for applying styles to and the
corresponding CSS.
Also modified: Links to opac-user.pl should now open the correct tab.
To test, apply the patch and compile the modified LESS file. Clear your
browser cache if necessary. Follow the original test plan and confirm
that the revised links work correctly.
Signed-off-by: Hugo Agud <hagud at orex.es>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 657c417a87f356479c82b11a602006f4f9ab375c
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Wed Apr 26 05:18:13 2017 +0000
Bug 2093: Add OPAC Summary for logged-in users
This patch adds a summary to the OPAC once the user has logged in that
shows the users number of checkouts, overdues, holds pending, holds
waiting and total fines. We also have a syspref OPACUserSummary to turn
this feature on and off. Default is ON.
To test:
1) Apply patch and update database
2) Set up some checkouts, overdues, holds pending AND waiting and fines
for a user
3) Log into OPAC as that user, see summary. Confirm links all work as
expected
4) Confirm that if there are no checkouts / overdues etc that the link
disappears from the summary
5) Turn OPACUserSummary OFF and confirm the summary does not show on the
mainpage.
Sponsored-by: Catalyst IT
Signed-off-by: Hugo Agud <hagud at orex.es>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3d6e33134e94f49513e999ab0ca1414ef0e66b4a
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Oct 26 12:18:04 2017 +0000
Bug 19528: (QA follow-up) Adjust language for readability
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7f7a6879b2df3cf52c56f4d75d020e34e60e7221
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed Oct 25 13:39:35 2017 +0200
Bug 19528: Fix a few typos like corrosponding
[1] Replace corrosponding => corresponding
[2] Replace containts => contains
[3] Replace item_level-itypes => item-level_itypes
[4] Replace Managment => Management
[5] Replace should returns => should return
Test plan:
Note that this patch only deals with POD lines or test descriptions.
So there is nothing to test, just read the patch.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Patch amended by RM: The release notes should not be modified
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 64899db254375c39bd8e50583861a5e16f4616e8
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Thu Oct 26 09:31:50 2017 +0200
Bug 9031: (QA follow-up) Final changes to Calendar::days_between
The crash is caused by comparing two datetimes where one datetime is
floating and the other one was not. In that case the floating is
converted. Note too that DateTime overloads comparison operators.
This patch clones the two dates first. Puts them in floating both. And
just after that starts comparing etc.
Similar small change in hours_between.
Adding a test where the parameters are swapped for days_between.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c398cfa37781dd71f0a6eedba0a466f4d6edbee9
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Mar 14 12:46:28 2017 -0400
Bug 9031: Overdue items crossing DST boundary throw invalid local time exception
To test:
1 - Set TZ to America/New York
2 - Checkout item and set due date to '2016-03-09 02:29:00"
3 - Make sure fines are set for the item type, fine mode production,
calculate fines on return
4 - Check in item - invalid date time warning in logs
5 - Apply patch
6 - Check in item - no error
7 - prove t/Calendar.t
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Bug 9031: Use floating instead of UTC
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Squashed the changes for Calendar.pm; will add a follow-up to finally
overcoming the crash on Invalid local time.
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9ac7f85375f9474c3f43b18ef6cead0c9a44d53f
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Thu Oct 26 09:13:38 2017 +0200
Bug 9031: (QA follow-up) Pass the same timezone in Calendar.t
We do not need to change $ENV{TZ} or call tzset.
Pass $tz too for the second date.
Replace checking the datetime hash by delta calls.
Replacing the number of minutes.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
We will still crash with:
Invalid local time for date in time zone: America/New_York
But the changes in Calendar.pm will now resolve that.
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit a3c4ce01b36bacf1169bd1897bf7f22a4ab992a8
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Jul 7 13:03:39 2017 +0000
Bug 9031: Unit tests for DST crossing in (days|hours)_between
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Without the patch for Calendar.pm, this crashes on:
Invalid local time for date in time zone: America/New_York
But even with the original change to Calendar.pm, I would see:
Invalid local time for date in time zone: Europe/Amsterdam
Adding a follow-up for that.
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3b4e0e697879a229b2fa213362ebee0f1a988eb2
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Oct 27 12:34:32 2017 -0300
Bug 19493: Force scalar context to prevent future error
If someone decide the reuse the template->param statement to pass values
to the template, we will get the same issue.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 4a4b3aa9486e97cd247042d0e13e418570719be0
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed Oct 18 16:03:57 2017 +0200
Bug 19493: Remove few warnings from circulation.pl
If you click Submit on the staff home page without entering a cardnumber, you will find these warnings in the log:
Problem = a value of override_high_holds has been passed to param without key at /usr/share/koha/masterclone/C4/Templates.pm line 137.
Problem = a value of nopermission has been passed to param without key at /usr/share/koha/masterclone/C4/Templates.pm line 137.
Use of uninitialized value $val in concatenation (.) or string at /usr/share/koha/masterclone/C4/Templates.pm line 137.
Problem = a value of has been passed to param without key at /usr/share/koha/masterclone/C4/Templates.pm line 137.
Cause is this call to $template->param:
$template->param(
CircAutocompl => C4::Context->preference("CircAutocompl"),
debarments => GetDebarments({ borrowernumber => $borrowernumber }),
todaysdate => output_pref( { dt => dt_from_string()->set(hour => 23)->set(minute => 59), dateformat => 'sql' } ),
has_modifications => $has_modifications,
override_high_holds => $override_high_holds,
nopermission => scalar $query->param('nopermission'),
In this specific case GetDebarments returns undef in list context (empty list),
so all items in the list shift one place.
Either we should force GetDebarments to return []; or we force scalar context in a construction like this. This patch does the last thing.
Note: The calls in memberentry.pl and moremember.pl are not affected.
Test plan:
[1] Do not apply. Click Submit without cardnumber. Check the log.
[2] Apply. Click Submit again without cardnumber. Check log.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 377bd10e0cb8c25d7f3201644b2bba4b732d4abf
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Oct 20 10:26:04 2017 -0300
Bug 16660: (followup) Unit tests
This patch adds unit tests for the introduced changes in
build_query_compat.
It removes a warning too.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 088cdcda5f0d3f2df15644a481b50fbf4eac9fd2
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Oct 18 21:00:44 2017 +0000
Bug 16660: Add support for OpacSuppression to Elasticsearch
To test:
1 - Enable suppression
2 - Suppress some records
3 - Apply all the patches
4 - Reindex ES
5 - Search and don't get suppressed records
6 - Disable suppression
7 - Search and get all the records
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit bf6caa81e5dba170f75183caf3479c3d4856832a
Author: Srdjan <srdjan at catalyst.net.nz>
Date: Tue Feb 28 15:17:49 2017 +1300
Bug 16660: Moved Opac Supression filtering from opac-search.pl to Zebra::QueryBuilder
To test:
OPAC: Both SearchEngine "Elasticsearch" and "Zebra" should work with
OpacSuppression set to "yes"
NB: OPAC suppression is not implemented for Elasticsearch
Signed-off-by: David Bourgault <david.bourgault at inlibro.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 27b99bb80b9f7bcf185c91d9fdb283813038ce71
Author: Mason James <mtj at kohaaloha.com>
Date: Thu Dec 1 13:38:51 2016 +1300
Bug 18118: Unexpected behaviour with 'GoogleOpenIDConnect' and 'OpacPublic' syspref combination.
TEST PLAN
----------
1/ configure a working 'GoogleOpenIDConnect' account
See comment #5 which also links back to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892#c3
2/ set 'OpacPublic' (under OPAC) to 'Disabled' and
'GoogleOpenIDConnect' (under Administration) to 'Yes'.
3/ log in user successfully via google-auth, observe redirect to
opac-user.pl (bad)
4/ apply patch
-- on kohadevbox remember to restart all! Plack is unforgiving. :)
5/ log in user successfully via google-auth, observe expected
redirect to opac-main.pl (good)
While I would normally suggest running koha qa test tools, because
this file doesn't end in .pl, it doesn't get picked up by them.
6/ perlcritic -4 opac/svc/auth/googleopenidconnect
-- notice this is a level better than required. :)
This also eyeballs easily well.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit bb1c184b840610a7f40409ec801317acd700e406
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed Oct 18 16:00:34 2017 +0200
Bug 19484: Add test before using object itemtype
Patch applies and functions as described. I agree with you that importing NULL itemtypes is possible Marcel. A higher importance level makes sense.
Signed-off-by: Dilan Johnpullé <dilan at calyx.net.au>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 30a0d4f6c97e783868128c051465722aefd95ac7
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Oct 25 17:29:16 2017 -0300
Bug 19531: When saving patron record do not redirect to circ if not authorised
If the logged in patron does not have the necessary permission we should
not redirect to circulation.pl but moremember.pl instead
Test plan:
With the borrowers permission, you should be able to edit a patron and
be redirect to the moremember page
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 99e487bc7162cee4bb9a8916637f4e1ddd7ccc00
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Oct 2 14:30:14 2017 -0300
Bug 19389: Hide library groups pull down if empty
Regression introduced by bug
commit 141200794da9f27e0231e1c2dad4bcb994d650f3
Bug 15295: Koha::Libraries - Remove GetBranchCategories
The intranet advanced search page offers to search for groups of
libraries, even if the pull down is empty as no library groups have
been defined.
Test plan:
- Go to the adv search page at the intranet
- Without library group you must not see the "Groups of libraries"
dropdown list
- With at least a library group you must see it
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit bdf85f5e39edeb1e2e85629044f1df25f56484f5
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Oct 2 16:42:46 2017 -0300
Bug 19069: Fix 'does not match' behaviour in MARC modification template
The "does not match" condition does not behave as expected.
We want it to process the action if the subfield exists and that the
value does not match a given pattern.
Test plan:
Be creative and write different template actions using the "does not
match" condition.
Using the "Batch record modification" and the "Show MARC" popup, confirm
that the processed record is the one you are expecting.
Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit a70c38f38001ec34749c9f4cc38a4eef9d2ed04a
Author: Alex Buckley <alexbuckley at catalyst.net.nz>
Date: Wed Oct 11 13:41:27 2017 +0000
Bug 19029: (follow-up) Make security question appear on clone operations from one library to another
Message pops up for all instances of cloning now.
Works as expected.
Signed-off-by: Dilan Johnpullé <dilan at calyx.net.au>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 83f97e662d77c99666c7873c947b91f9e8630a17
Author: Alex Buckley <alexbuckley at catalyst.net.nz>
Date: Tue Oct 3 08:33:37 2017 +1300
Bug 19029: (follow-up) Implemented .format() to ease translation
Sponosred by: Catalyst IT
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 971591d4ee8576d6782d32610bbae7cfe4674231
Author: Alex Buckley <alexbuckley at catalyst.net.nz>
Date: Thu Aug 24 21:25:40 2017 +0000
Bug 19029: Add JavaScript security question for cloning circ rules
This patch introduces a Javascript security question which is displayed
to the user when they try to clone a circulation rule to a specific
branch when the rule is a 'Standard rule for all libraries"
The rationale for this patch is when the cloning takes place it
overwrites the existing rules of the destination branch and there is no
notification of this to the user. Therefore by implementing this patch
the user is asked if they want to clone the rule (if the rule is
standard accross all libraries) and are told that it
will overwrite the rules in the destination branch.
Test plan:
1. Create a circulation rule for all libraries
2. Make sure the 'select a library' option is set to 'Standard rules for all
libraries"
3. Click the 'Clone' button and notice that the cloning takes place
without any warning that it will overwrite the rules of the destination
branch
4. Apply patch
5. Return to the circulation and fine rules page
6. Repeat step 2
7. Click the clone button and notice a alert box appears asking if you
are sure you want to clone the standard rule to the destination branch.
Note: The name of the destination branch is included in the alert.
Also note that the user is informed of the consequences of performing
the action, i.e. that it will overwrite the existing rules in the
destination branch
8. Click 'Cancel' and notice that no cloning occurs
9. Click the clone button again and this time click 'OK' and notice
that the cloning takes place
10. Return to the Circulation and fine rules page and set the 'Select a
library' option to the name of an individual branch
11. Click the clone button and notice that the clone action takes place
Sponsored-By: Catalyst IT
Signed-off-by: David Bourgault <david.bourgault at inlibro.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit a522df7dd97f5d7e646966d9b7f4f18fe8df7e2d
Author: Alex Arnaud <alex.arnaud at biblibre.com>
Date: Thu Oct 12 07:24:33 2017 +0000
Bug 19443: Remove duplicate message when editing existing patron
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 27fca7aceb91124c037bb3545c351d3cf185e7bf
Author: Alex Arnaud <alex.arnaud at biblibre.com>
Date: Tue Oct 10 15:21:35 2017 +0000
Bug 19443: Wrong HTML in patron creation page (members/memberentry.pl)
The form provided on top of the page if Koha find a duplicate
patron is not closed. This cause some trouble.
Test plan:
- Edit the syspref IntranetUserJS and type the following code:
"$(document).ready(function() {
$("#memberentry_library_management").insertBefore("#memberentry_identity");
});"
- create a patron so that Koha will warn you about a duplicate one,
- click on "Not a duplicate. Save as new record",
- you should get error(s) about empty field(s).
Note that now, the library management part's fields are empty or
reset to default
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 18809b137113c36115af1d165a3236901a42bc91
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Oct 27 14:02:53 2017 -0300
Bug 12363: DBRev 17.06.000.023
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 58b6e957638418fea8d5a25e21da3530574db3e1
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Oct 17 10:55:09 2017 -0300
Bug 12363: Add a switch to mark|do not mark items as returned when lost
There are several ways to mark an item an lost:
- item list view (catalogue/moredetail.pl, "Items" tab)
- cataloguing (cataloguing/additem.pl)
- Batch item modification tools (tools/batchMod.pl)
- The long overdue cronjob (misc/cronjobs/longoverdue.pl)
So far only the cronjob is configurable, the others mark the item as
returned (does the checkin).
This behaviour should be controlable using a syspref, to let libraries
choose what fit best for them.
Test plan:
Use the 2 options of the pref, mark checked out items as lost using the
different possibilities, and confirm that the behaviours make sense to
you
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 264432f701d47ae166258a0d412b9089a9e05efe
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Oct 17 10:54:33 2017 -0300
Bug 12363: Add new pref MarkLostItemsAsReturned
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 48be40d1bfaf13a70b6bf4918e885d9158e25f66
Author: David Cook <dcook at prosentient.com.au>
Date: Tue Oct 10 12:05:16 2017 +1100
Bug 18884: Advanced search on staff client, Availability limit not properly limiting
Patch applies and functions as described.
Signed-off-by: Dilan Johnpullé <dilan at calyx.net.au>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 4f2d59e67b6d938ca2798fe8b7fc3ec6eda1d253
Author: Andreas Roussos <arouss1980 at gmail.com>
Date: Fri Oct 20 22:58:27 2017 +0300
Bug 19503: Duplicating a dropdown menu subfield yields an empty subfield tag
While editing a record in the staff client, if you clone a repeatable
dropdown subfield the cloned subfield's tag is empty. This can result
in data loss if the record is saved, re-opened, and saved yet again.
This patch (originally written by Sophie MEYNIEUX for bug 17818) fixes that.
Test plan:
0) [PREREQUISITE] In your MARC framework (Home > Administration > MARC
bibliographic framework) ensure that you have at least one subfield
of a particular tag linked to an authorised value (e.g. in UNIMARC,
tag 700 subfield 4 is 'Relator Code' and can be linked to CCODE for
testing purposes). This is so that the relevant subfield will be a
dropdown menu and not a textbox.
1) In the Staff Client, edit an existing record or create a new one.
Then, try to clone any subfield that is a dropdown menu. Observe
that the cloned subfield's tag is empty.
2) Apply the patch.
3) Hit CTRL-F5 in your browser (to ensure cataloging.js is re-loaded)
and try to clone a dropdown menu subfield again. This time the tag
is cloned as well.
Working as intended.
Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
https://bugs.koha-community.org/show_bug.cgi?id=16503
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3f2c1c879c0bdb920f00d968b6d25f3fd8635f95
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Oct 4 17:49:51 2017 -0300
Bug 19117: Add CSRF protection to paycollect.pl
Security bug, trivial changes, no need to provide procedure for script
kiddies.
Test plan:
Pay fines using the different options from the "Pay fines" tab.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c4113dce705a700acf1d7d271a044d1f555d7c81
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Wed Sep 13 03:44:19 2017 +0000
Bug 18956: Fix empty to in message queue
Follow the test plan in comment #20.
Also tweaked string, because it was really 'or' before too.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Amended text in added comment.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 6336e53aedabccf50481c68c45929d90a463b8dd
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Sep 8 08:53:37 2017 +0200
Bug 18956: (QA follow-up) Resolve a CGI::Param in list context warn
From the plack-error.log:
CGI::param called in list context from package CGI::Compile::ROOT::usr_share_koha_masterclone_opac_opac_2dpassword_2drecovery_2epl line 129, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e08a0afa264f55294bda4a5d949012ad60639616
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Fri Aug 25 15:09:38 2017 -0400
Bug 18956: Prevent leaking during password recovery
TEST PLAN
---------
It is assumed you have set the OpacResetPassword to 'allowed',
and likely in combination with OpacPasswordChange to 'Allowed'.
You will have two patrons: one with and another without
any email address entered. You will want to test this test plan
with both patrons.
$ git checkout -b bug_18956 origin/master
Prepend the following as understood between step sections:
opac -> forgot password and then enter...
correct login/cardnumber, it will email
delete from borrower_password_recovery;
correct email, it will email
delete from borrower_password_recovery;
correct login/cardnumber && correct email, it will email
delete from borrower_password_recovery;
wrong login/cardnumber && correct email, error page as expected
delete from borrower_password_recovery;
correct login/cardnumber && wrong email, error page as expected
delete from borrower_password_recovery;
wrong login/cardnumber && wrong email, error page as expected
delete from borrower_password_recovery;
submit empty -- INTERNAL SERVER ERROR?!
delete from borrower_password_recovery;
-- None of the above step sections displayed email.
correct login/cardnumber, it will email
correct login/cardnumber again, but it leaks email address!
delete from borrower_password_recovery;
correct email, it will email
correct email again, but it leaks login/cardnumber!
delete from borrower_password_recovery;
$ git bz apply 18956
-- choose interactive, and choose this counter patch.
repeat the same test set again
-- no leaks will occur, error message pages returned should
be reasonable, code should read reasonably.
run koha qa test tools.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 570eb4026642f71e462c7746a9c91721aa9334c1
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Sep 18 14:53:41 2017 -0300
Bug 19333: Fix XSS in opac-shelves
category is send back to the template, it must be escaped
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
-----------------------------------------------------------------------
Summary of changes:
C4/Acquisition.pm | 2 +-
C4/Biblio.pm | 4 +-
C4/Circulation.pm | 4 +-
C4/Log.pm | 2 +-
C4/MarcModificationTemplates.pm | 17 +-
C4/Members.pm | 8 +-
C4/NewsChannels.pm | 2 +-
C4/SIP/ILS.pm | 4 +-
C4/SIP/ILS/Transaction/FeePayment.pm | 17 +-
C4/SIP/Sip/MsgType.pm | 4 +-
C4/Serials.pm | 2 +-
Koha.pm | 2 +-
Koha/Calendar.pm | 26 +-
Koha/List/Patron.pm | 2 +-
Koha/MoreUtils.pm | 15 ++
Koha/Schema/Result/Borrower.pm | 8 +-
Koha/Schema/Result/BorrowerModification.pm | 8 +-
Koha/Schema/Result/Deletedborrower.pm | 8 +-
Koha/Schema/Result/PendingOfflineOperation.pm | 8 +-
Koha/Schema/Result/TmpHoldsqueue.pm | 8 +-
Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 1 +
Koha/SearchEngine/Zebra/QueryBuilder.pm | 26 +-
admin/searchengine/elasticsearch/mappings.yaml | 19 ++
authorities/authorities.pl | 2 +-
catalogue/updateitem.pl | 2 +-
cataloguing/addbiblio.pl | 2 +-
cataloguing/additem.pl | 2 +-
circ/circulation.pl | 2 +-
debian/docs/koha-common.xml | 12 +
debian/docs/koha-elasticsearch.xml | 100 +++++++
debian/docs/koha-zebra.xml | 88 +++++++
debian/koha-common.bash-completion | 37 +++
debian/koha-common.install | 2 +
debian/scripts/koha-elasticsearch | 180 +++++++++++++
debian/scripts/koha-zebra | 273 ++++++++++++++++++++
etc/SIPconfig.xml | 2 +-
installer/data/mysql/kohastructure.sql | 10 +-
installer/data/mysql/sysprefs.sql | 4 +-
installer/data/mysql/updatedatabase.pl | 44 ++++
.../prog/en/includes/html_helpers.inc | 4 +-
.../en/modules/admin/preferences/circulation.pref | 6 +
.../prog/en/modules/admin/preferences/opac.pref | 6 +
.../prog/en/modules/admin/preferences/patrons.pref | 2 +-
.../prog/en/modules/admin/smart-rules.tt | 18 +-
.../prog/en/modules/catalogue/advsearch.tt | 4 +-
.../prog/en/modules/members/memberentrygen.tt | 62 +++--
.../prog/en/modules/members/paycollect.tt | 3 +
.../intranet-tmpl/prog/en/modules/sms/sms-home.tt | 35 ---
.../prog/en/modules/virtualshelves/shelves.tt | 27 +-
koha-tmpl/intranet-tmpl/prog/js/cataloging.js | 1 +
koha-tmpl/intranet-tmpl/prog/js/staff-global.js | 4 +
koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +-
.../bootstrap/en/modules/clubs/clubs-tab.tt | 2 +
.../opac-tmpl/bootstrap/en/modules/opac-main.tt | 26 +-
.../bootstrap/en/modules/opac-password-recovery.tt | 9 +-
.../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 12 +-
koha-tmpl/opac-tmpl/bootstrap/less/opac.less | 70 +++++
members/memberentry.pl | 18 +-
members/moremember.pl | 2 +-
members/paycollect.pl | 9 +
misc/cronjobs/longoverdue.pl | 3 +-
misc/migration_tools/bulkmarcimport.pl | 40 ++-
opac/opac-main.pl | 20 ++
opac/opac-password-recovery.pl | 16 +-
opac/opac-search.pl | 55 ++--
opac/svc/auth/googleopenidconnect | 10 +-
sms/sms.pl | 37 ---
sms/sms_listen.pl | 123 ---------
sms/sms_listen_windows_start.pl | 17 --
svc/checkouts | 2 +-
t/Koha/SearchEngine/Zebra/QueryBuilder.t | 78 ++++++
t/Search/Zebra/QueryBuilder.t | 38 ---
t/db_dependent/00-strict.t | 4 +-
t/db_dependent/ArticleRequests.t | 6 +-
t/db_dependent/Calendar.t | 18 +-
t/db_dependent/Holds.t | 6 +-
t/db_dependent/Items.t | 4 +-
.../Koha_SearchEngine_Elasticsearch_Search.t | 16 +-
t/db_dependent/MarcModificationTemplates.t | 57 +++-
tools/batchMod.pl | 2 +-
virtualshelves/shelves.pl | 24 ++
81 files changed, 1419 insertions(+), 438 deletions(-)
create mode 100644 Koha/MoreUtils.pm
create mode 100644 debian/docs/koha-elasticsearch.xml
create mode 100644 debian/docs/koha-zebra.xml
create mode 100755 debian/scripts/koha-elasticsearch
create mode 100755 debian/scripts/koha-zebra
delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/sms/sms-home.tt
delete mode 100755 sms/sms.pl
delete mode 100755 sms/sms_listen.pl
delete mode 100755 sms/sms_listen_windows_start.pl
create mode 100644 t/Koha/SearchEngine/Zebra/QueryBuilder.t
delete mode 100644 t/Search/Zebra/QueryBuilder.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list