[koha-commits] main Koha release repository branch master updated. v17.05.00-1002-g790150b

Fri Oct 27 21:13:01 CEST 2017

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  790150b31277e6ded86823add0385c5960a4876e (commit)
       via  41a4a1d0dfcfab069eaca1c09e3645e960e92b8b (commit)
       via  09a49bc96734af8d7615a1c7b024ff69ee2df04c (commit)
       via  9dbc12ccede6fa5251bd8abc428ee6fa51cf19fa (commit)
       via  dcb87888deef5e032ce02882e14afc529b4d11fc (commit)
       via  0f6bab669e5717b2907cb4c4e8644e512fe98006 (commit)
       via  7f501ba31cc81c26829086dc4a47016996371d9b (commit)
       via  eba92195b6fef397918eb9b94a7782ecbf3878df (commit)
       via  3fe241f6100bd7ffc967fcc8e76659e9d861750b (commit)
       via  cf493b9b120447e3964679d1b3573871c6801e77 (commit)
       via  dc8c70b7452a524e9219b2da9dfe75f4e07ba087 (commit)
       via  b95f5c28aa8568c9d6bae241a6c1635c6a773d08 (commit)
       via  3df0c9ac70621b2b434b47424cc9be2d2ba58bc4 (commit)
       via  8c094e2dc3413425f1ddfe6e518221749f9373c4 (commit)
       via  9daf668ca3ddda59114d628d1188ab53dec848ee (commit)
       via  b20db441fef5bd19cb48245458eb1f4e5ef3ba28 (commit)
       via  f20a694f1332edfba9dc204a67f8594e23346166 (commit)
       via  1ac50443001dd56c96808ea73d565ac20c540669 (commit)
       via  7dcd30d1d8c0375bf57c69b91cbf4e73e000bd46 (commit)
       via  4fa34acc414a1580019df62c28bb39bb6d9f3e85 (commit)
       via  9a0853ef67099a62b29c88da55f70862060748ec (commit)
       via  d4a97bb5aefc2157586577c1c2c7f3331926dae0 (commit)
      from  0e7b093a103c95542ed24bdf6cb9d12c19048d04 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 790150b31277e6ded86823add0385c5960a4876e
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Wed Aug 2 10:35:49 2017 +0200

    Bug 19021: Fix Inventory columns sorting

    In inventory result page, items are shown in a JS DataTable.
    For an inventory with barcode file second column is not sortable for no reason.
    For an inventory without barcode file first column is not sortable but since it is the default sort order the sorting icon is still displayed.

    This patch corrects by setting default sort order on callnumber column.

    Test plan :
    - perform inventory with barcode file
    - look at result table
    - table is sorted by callnumber
    => Without patch second column is not sortable
    => With patch all columns are sortable
    - perform inventory without barcode file
    - look at result table
    => Without patch first column show sort icon and table is not sorted by callnumber
    => With patch first column is not sortable and table is sorted by callnumber

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 41a4a1d0dfcfab069eaca1c09e3645e960e92b8b
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Mon Jul 10 12:44:14 2017 +0100

    Bug 18920: Save DB_USE_TLS and FONT_DIR to install log

    Configuration values should be included in the koha-install-log
    so that when running Makefile.PL with the --prev-install-log option
    values can be read from there and reapplied rather than prompting
    the user on each subsequent run.
    This adds FONT_DIR and DB_USE_TLS (and its dependent options) to
    koha-install-log so that the set values will be written by make
    during a make install or make upgrade

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 09a49bc96734af8d7615a1c7b024ff69ee2df04c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Oct 27 15:33:14 2017 -0300

    Bug 19377: (follow-up) Remove charge for 'books' in ru-RU sample data

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 9dbc12ccede6fa5251bd8abc428ee6fa51cf19fa
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Sat Oct 7 00:20:40 2017 +0000

    Bug 19377: (follow-up) Remove charge for 'books' in all sample data

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit dcb87888deef5e032ce02882e14afc529b4d11fc
Author: David Cook <dcook at prosentient.com.au>
Date:   Thu Sep 28 13:00:27 2017 +1000

    Bug 19377: Remove $5 charge from sample item types

    Most of the sample item types come with a rental charge of $5.
    This is really annoying when you're testing Koha with a fast catalogued
    book, since you end up having to write off fines and change the item
    type before you can actually get to the testing you want to do.

    I left the rental charge on most other items so that you can test
    rental charges easily by using a item type other than BOOK or REF.

    _TEST PLAN_

    Before applying
    1) drop your test database
    2) create your test database
    3) install Koha via the web installer and install all sample data
    4) do a checkout
    5) note a $5 rental charge

    After applying
    1) drop your test database
    2) create your test database
    3) install Koha via the web installer and install all sample data
    4) do a checkout
    5) note no $5 rental charge

    Signed-off-by: Magnus Enger <magnus at libriotech.no>
    Applied the patch and looked at the change to the SQL-file. Looks
    good. That fine on books has surprised me one too many times! :-)

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 0f6bab669e5717b2907cb4c4e8644e512fe98006
Author: Marc Véron <veron at veron.ch>
Date:   Thu Sep 7 17:31:12 2017 +0200

    Bug 19274: Translatability: Fix new splitting problems related to database warnings

    The warnings about database problems introduce new translatability problems,
    mostly related to sentence splitting by html tags.

    To test:
    - Verify that text changes make sense
    - Apply patch, verify that messages properly.
      Note: To force display you might want to add '1 ||' to the related
      if statements, including line 134,  e.g. [% IF 1 || has_ai_issues %]
    - Bonus test: Go through an translation cicle and verify that fragemts as
      mentioned in initial comment are gone.

    (Amended to fix tiny typo)

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 7f501ba31cc81c26829086dc4a47016996371d9b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Oct 27 15:29:22 2017 -0300

    Bug 19231: No need to pass the size to the template

    We have the array already, we just need to call .size on it

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit eba92195b6fef397918eb9b94a7782ecbf3878df
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date:   Thu Aug 31 22:02:05 2017 +0000

    Bug 19231: Add number of attached items to confirm message when deleting course

    To test:
    1) Ensure UseCourseReserves is enabled
    2) Go to Course Reserves and create 3 new courses
    3) Add one item to a course, add two items to another course, and add no
    items to the third course
    4) Delete the course with no items. Confirm the error message shows up.
    No need to say how many attached items there are here (because there are
    none).
    5) Delete the course with one item. Confirm the error message shows and
    warns of the one attached item and makes grammatical sense
    6) Delete the course with two items. Confirm the error message shows and
    shows the correct number of attached items and makes grammatical sense
    7) Confirm clicking 'Cancel' and 'OK' does what is expected

    Sponsored-by: Catalyst IT
    Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

    Looks good!

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 3fe241f6100bd7ffc967fcc8e76659e9d861750b
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date:   Wed Aug 30 23:35:57 2017 +0000

    Bug 19212: Preventing warns when asking for discharge

    To test:
    1) Ensure the useDischarge syspref is enabled
    2) Log in to OPAC
    3) Go to 'ask for a discharge'
    4) Notice warns
    5) Apply patch and refresh page
    6) Notice warns are gone

    Sponsored-by: Catalyst IT

    Warnings reproduced in plack-error.log, with patch they are gone.
    Signed-off-by: Marc Véron <veron at veron.ch>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit cf493b9b120447e3964679d1b3573871c6801e77
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date:   Tue Aug 29 03:03:45 2017 +0000

    Bug 17039: Adding 'cancel' link and 'add new item' button to item edit form

    To test:
    1) Go the the detail page for a record on staff side
    2) Edit an existing item and scroll down to Save button
    3) Notice no easy way to add a new item or cancel out of the form
    4) Apply patch and refresh page
    5) You should now see a new button next to the Save button, 'Add a new
    item', and a link 'Cancel'
    6) Confirm clicking Cancel takes you back to the detail page for the
    record
    7) Go to edit an item again
    8) Change some fields/add some info to the item
    9) Click the 'Add a new item' button and a confirm box should pop up.
    10) Confirm that clicking 'cancel' does NOT take you to a new page, and
    your changes are still there
    11) Click the button again, and this time click 'OK'
    12) Confirm you are redirected to the 'add item' form

    Sponsored-by: Catalyst IT

    Signed-off-by: Hugo Agud <hagud at orex.es>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit dc8c70b7452a524e9219b2da9dfe75f4e07ba087
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Wed Aug 2 10:43:44 2017 +0200

    Bug 19022: inventory location and author display

    In inventory result page :
    Location is displayed after branch without any difference.
    Author is displayed into a paragraph making row hight.

    This patch adds for location a span with class like in catalogue detail page, and changes author to be on same line in order to have a more compact display for this table that may be huge.

    Test plan :
    - Perform inventory with a barcode file
    - Look at result
    => you see localtion in a new line after library and in italic
    => you see author after title on same line with "by" separator

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit b95f5c28aa8568c9d6bae241a6c1635c6a773d08
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Wed Sep 20 23:43:22 2017 +0200

    Bug 13796: (follow-up) Move renewal remaining statement back

    This moved the renewals remaining statement back out of the
    condition so it's visible always - with and without a rental
    fine on the item type.

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 3df0c9ac70621b2b434b47424cc9be2d2ba58bc4
Author: Marc Véron <veron at veron.ch>
Date:   Fri Apr 21 17:50:45 2017 +0200

    Bug 13796: OPAC: Display rental charge for renewing

    This patch displays the rental fee that will be applied for
    renewing (near "Renew" link on patron's summary page)

    To test:
    - Apply patch
    - Enable system preference 'OpacRenewalAllowed'
    - Verify that you have item types with and without rental fee
      for testing
    - Issue items with an without rental fee to a patron
    - In OPAC, display patron's summary page
    - Verify in table 'Checked out', items with rental charge display an information as
      appropriate (near the link 'Renew')

    Patch rewritten because of merge issues with previous patches. 2017-04-21 mv

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 8c094e2dc3413425f1ddfe6e518221749f9373c4
Author: Lari Taskula <lari.taskula at jns.fi>
Date:   Mon Oct 2 19:06:23 2017 +0300

    Bug 19400: Reminder to unset gone no address flag after patron makes a modification request

    Our librarians requested a reminder to unset "gone no address" flag from patron's
    record once the patron has made a modification request to update their address.

    I propose adding a message box under patron modification request to notify
    librarians about patrons that have gone no address flag on, and an option to
    unset the flag without the need of having to navigate into patron's details.

    To test:
    1. Apply patch
    2. Set "Gone no address" flag for your test patron. You can do this by going
       to patron modification screen in staff client.
    3. Go to OPAC with your test patron
    4. Make a modification request for your personal details
    5. Go to staff client and see pending modification requests
    6. Open the request you just created
    7. Observe a message dialog that says this patron has gone no address flag set
    8. Check the checkbox to unset the flag and approve the modification request
    9. Click Submit
    10. Observe your test patron no longer has gone no address flag set
    11. Repeat steps 2-7
    12. Do not check the checkbox, but approve the modification request
    13. Observe your test patron still has gone no address flag set
    14. Remove the gone no address flag from your test patron
    15. Repeat steps 3-6
    16. Observe there is no message dialog for gone no address

    Followed test plan, patch worked as described. Also ran QA test tools
    and all modified files passed

    Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 9daf668ca3ddda59114d628d1188ab53dec848ee
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Oct 27 14:32:40 2017 -0300

    Bug 14919: Remove notificationdate and reminderdate

    These columns are not used, we do not need to display them

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit b20db441fef5bd19cb48245458eb1f4e5ef3ba28
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Fri Oct 27 09:23:02 2017 -0400

    Bug 14919: (QA follow-up) Make script executable, fix typo

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit f20a694f1332edfba9dc204a67f8594e23346166
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sat Oct 14 20:21:51 2017 +0000

    Bug 14919: (follow-up) Changed status from 'in queue' to 'pending'

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 1ac50443001dd56c96808ea73d565ac20c540669
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Thu Oct 12 08:40:43 2017 +0200

    Bug 14919: (followup) Show accurate status in holds history

    This patch fixes the status showed in holds history table.

    The determination of status is following:

    1. "hold.found is 'F'" - Fullfilled - the hold was fullfilled by checking the
    item to patron. If hold reaches this state, it can't changed status
    anymore, or be cancelled, that's why this goes first

    2. "hold.cancellationdate is filled" - When the hold is cancelled, its
    eventually waiting or in transit status remains the same, only
    cancellation dat is filled, so this has to go second

    3. "hold.found is 'W'" - Hold is waiting

    4. "hold.found is 'T'" - Hold is in transit to target library

    Test plan:
    0) Apply the patch
    2) Read the status determination note in this commit message and confirm
    it makes sense
    1) Have patron/patrons with at least one hold in every status
    2) Go to holds history page and confirm it show the right status
    3) Try to break the status determination ;)

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 7dcd30d1d8c0375bf57c69b91cbf4e73e000bd46
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sat Oct 7 22:36:11 2017 +0200

    Bug 14919: (follow-up) Fixing some typos and adding to pref description

    - Adds 'holds' to pref description of intranetreadinghistory
    - Fixes typo in link to holds history from patron account
    - Changes reserve date to hold date in table heading

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 4fa34acc414a1580019df62c28bb39bb6d9f3e85
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Fri Oct 6 13:35:46 2017 +0000

    Bug 14919: Add holds history for patron

    Test plan:
    0) Have a patron with some current and old reserves
    1) Go to patron circulation page
    2) Notice, there is new item called "Holds history" in the left
    circulation menu
    3) Go to this page and confirm the data on this page are OK, and that
    ui does behave as expected
    4) Go to adminitration, columns setting, try to change the setting for
    holdshistory table and confirm it is taken into account on holds history
    page

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 9a0853ef67099a62b29c88da55f70862060748ec
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Fri Oct 6 08:04:34 2017 +0000

    Bug 14919: Add Koha::Patron->old_holds subroutine

    Test plan:
    Run t/db_dependent/Koha/Patrons.t

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit d4a97bb5aefc2157586577c1c2c7f3331926dae0
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Fri Oct 6 08:03:56 2017 +0000

    Bug 14919: Add test for Koha::Patron->old_holds subroutine

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-----------------------------------------------------------------------

Summary of changes:
 Koha/Patron.pm                                     |   14 +++
 admin/columns_settings.yml                         |   80 ++++++++-----
 .../data/mysql/en/optional/sample_itemtypes.sql    |    2 +-
 .../data/mysql/es-ES/optional/sample_itemtypes.sql |    2 +-
 .../data/mysql/pl-PL/optional/sample_itemtypes.sql |    2 +-
 .../mysql/ru-RU/optional/library_item_types.sql    |    2 +-
 .../intranet-tmpl/prog/en/includes/circ-menu.inc   |    5 +
 koha-tmpl/intranet-tmpl/prog/en/modules/about.tt   |   33 +++---
 .../prog/en/modules/admin/preferences/patrons.pref |    2 +-
 .../prog/en/modules/cataloguing/additem.tt         |   10 +-
 .../en/modules/course_reserves/course-details.tt   |    9 +-
 .../prog/en/modules/members/holdshistory.tt        |  121 ++++++++++++++++++++
 .../prog/en/modules/members/members-update.tt      |    8 ++
 .../prog/en/modules/tools/inventory.tt             |   16 ++-
 .../opac-tmpl/bootstrap/en/modules/opac-user.tt    |    3 +
 members/holdshistory.pl                            |   96 ++++++++++++++++
 members/members-update-do.pl                       |    9 ++
 misc/koha-install-log                              |    5 +
 opac/opac-discharge.pl                             |    2 +-
 opac/opac-user.pl                                  |    1 +
 t/db_dependent/Koha/Patrons.t                      |   16 ++-
 21 files changed, 380 insertions(+), 58 deletions(-)
 create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt
 create mode 100755 members/holdshistory.pl

hooks/post-receive
-- 
main Koha release repository