From gitmaster at git.koha-community.org Fri Sep 1 18:06:35 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 01 Sep 2017 16:06:35 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.05.00-527-g185927f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 185927f20981f36757c97fd33cc4c8ccd0ad5a3a (commit) via b66b86402cd84026f7dabaa2e567a1956b9bbe86 (commit) via 8901f5702a7c6755c1f84cde01d75765687bb060 (commit) via d928038a523b7ef44257ddfe97c405173c9b3b2e (commit) via 0e744d49b557e3401ae7b700b1410b022a4e851c (commit) via 0fc3f19605d3979333dc333237205b9bef6ab60b (commit) via 57427f7a10c887964fa4d4397c6ec238af2bc694 (commit) via 327495b5e0ec4de47d20bd27d6a1c5b88e0be191 (commit) via 4934ee4a1601bd268a7153b7189387bb073dd11f (commit) via f1b0dae9a6055e8ba5e9a9638af32060c1e17e33 (commit) via 48f54016a7accfc0cc43bf01cbac70a8482bc3f9 (commit) via bb31d99065c468fbec2443cd15894b03657a24d5 (commit) via 8fd0847c82adbcaf0af3285dd9cfc5e646ba6500 (commit) via a932d05ace6500a3b67888aad1306e58cfa8014f (commit) via 65bce82b1fb32d3d98fe4d4ef1e1738a97749632 (commit) via 6c1504cfdb301cb0f9f3a14b5db31a63f5c3b0a5 (commit) via 2e9165001f69312255ad1b6706f040784460d5d1 (commit) via 16c25a36988b47fb9fcbabd91fdace5f98f9caed (commit) via 7db6067dc4cc55bee771fedb31e2454b72123ac0 (commit) via 786deba62beb5a52a543af5415610e14f7d0a8c5 (commit) via d0e3891e251a6a11188d70a5480af0e44b8c1fb0 (commit) via 515e62992893b72c54a34311088a9442a37d8138 (commit) via a887aeb2dff4e52f35f1f64bfc267867987cbb53 (commit) via 82f183c5ea802e3231cb2442cf32474c92bd6ab4 (commit) via ee49d5698a11ee5806aff8c8581fa22002435cff (commit) via 947834f1821449faf9148f06c84f5638b0941435 (commit) via 391bf4f38dcaa89745115409d01cca9cd1e99dce (commit) via f24e339dd603e015557107048d1a678293cb2e65 (commit) via f10f6a19c53beb37e3ee0808ef6bb18bd88bef8a (commit) via ae7e0ee56a17ae2a0c6fdaa96c6b04229aabca74 (commit) via 9d207f3832bc49232f30e8d7dbf2ac60e3ab9699 (commit) via 8c90bb78c9fe411c5ea549f8100939e29b7a4bc1 (commit) via 7abe6e9670ecb9b879e3b8c237fd9fad35f5ff18 (commit) via ff4f0858950c37eeede38b2f067841602b97d7ba (commit) via 7f27ef71e26720604b738c86c084b91858ef7c1a (commit) via 9cc7268362219e39b22aebb03a83e013f467d93a (commit) via 10311769d460a775aa8c8ee8a190836a8f2b1f1e (commit) via 8d08254b2202353517c16f34172cb92dcdd5befa (commit) via 85b963d11fb5d8674ca6b0ec60821663f9d8cf19 (commit) via 831d75d09c276f25f919cbdc16c8e4105fe8ddc9 (commit) via ccac8ba6d3799c52adc80298b96a8efaf05c4a9e (commit) via 239589b119c88a321fb8245f859855c41dda6566 (commit) via d5ea914f4dc41f78dbb3a59f894f6ecbb9a1afa4 (commit) via 51a65731c0fa15c37351ce6bc478fa6dc63fc64f (commit) from d51059807690797aa4d16b0c0dd2932235a3b683 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 185927f20981f36757c97fd33cc4c8ccd0ad5a3a Author: Nick Clemens Date: Fri Aug 11 15:39:53 2017 +0000 Bug 19076 - followup - delete fines from additional renewal Signed-off-by: Christopher Brannon Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart commit b66b86402cd84026f7dabaa2e567a1956b9bbe86 Author: Nick Clemens Date: Thu Aug 10 15:20:58 2017 +0000 Bug 19076 - Move issue logging in AddIssue into condtional clause Currently AddIssue tests if renewal, but logs an issue even if so. This patch moves the logging into the conditional so a log entry is only added if we aren't renewing (as renewals are logged separately) To test: 1 - prove t/db_dependent/Circulation.t - one test should fail 2 - Enable both issue and renewal logs 3 - Checkout an item to a patron 4 - View the logs - the issue is captured 5 - Checkout the item to the patron again and confirm renewal 6 - Both an issue and a renewal are logged 7 - Apply patch 8 Repeat 1-6, tests should pass and only renewal should be logged Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart commit 8901f5702a7c6755c1f84cde01d75765687bb060 Author: Nick Clemens Date: Thu Aug 10 15:20:19 2017 +0000 Bug 19076 - unit tests Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart commit d928038a523b7ef44257ddfe97c405173c9b3b2e Author: Jonathan Druart Date: Mon Aug 28 14:00:28 2017 -0300 Bug 19081: Do not list plugins that have been uninstalled Under plack, can_load should not check if a package is in cache, but reload it. Otherwise plugins that have been uninstalled will still get listed. The error raised by can_load must only be displayed if the plugin has been removed. Test plan: 1/ Upload a plugin 2/ Note the plugin is listed as installed 3/ Modify the package of the plugin to add a compilation error (use 'Foo' for instance) 4/ Reload the page 5/ The plugin is not listed and a warning appear in the logs 6/ Remove the compilation error and uninstall the plugin 7/ The plugin is no longer listed and no warning appear in the logs Signed-off-by: Lee Jamison Signed-off-by: Kyle M Hall Bug 19081: Remove useless $plugin_file variable Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit 0e744d49b557e3401ae7b700b1410b022a4e851c Author: Marcel de Rooy Date: Mon Aug 28 08:51:24 2017 +0200 Bug 19004: [QA Follow-up] No need to check item-level_itypes again As Jonathan pointed out, GetItem already called effective_itemtype. So we can just use $item->{itype} here. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit 0fc3f19605d3979333dc333237205b9bef6ab60b Author: Marcel de Rooy Date: Wed Aug 9 16:30:03 2017 +0200 Bug 19004: Adjust AddReturn for retrieving item type In the regular situation, you can get itemtype via biblio and then biblioitem as well as via biblioitem (at least when item-level_itypes is set to biblio). But since Koha unfortunately defined two relations in item, one for biblioitemnumber (the good one) and one for biblionumber (redundant), TestBuilder (correctly) builds one biblioitem and two biblios. If you item-level_itypes to biblio record, this will result in failing tests when calling AddReturn (in this case Koha/Patrons.t). It will crash on: Can't call method "itemtype" on an undefined value at C4/Circulation.pm line 1826. Cause: AddReturn goes via the biblionumber to biblio and than to biblioitems, and it does not find a biblioitem. (Not a fault from TestBuilder but a database design problem.) This patch makes a small change in AddReturn to retrieve the itemtype via biblioitem. It actually is a shorter road than items->biblio->biblioitems. Note: I do not test the Biblioitems->find call, since we already checked the GetItem call before and we have a foreign key constraint. I did not call $item->effective_itemtype since we still use GetItem; this could be done later. Adjusted Circulation/Returns.t too: If we add an item with TestBuilder and we called AddBiblio before, we should link biblioitemnumber as well. Test plan: [1] Do not apply this patch yet. [2] Set item-level_itypes to biblio record. [3] Run t/db_dependent/Koha/Patrons.t. (It should fail.) [4] Apply this patch. [5] Run t/db_dependent/Koha/Patrons.t again. [6] Run t/db_dependent/Circulation/Returns.t [7] Git grep on AddReturn and run a few other tests calling it. Note: Bugs 19070/19071 address three tests that call AddReturn too. [8] In the interface, check in a book. Signed-off-by: Marcel de Rooy Note: Bugs 19070 and 19071 are already pushed. The command in comment #4 has all the tests successful. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit 57427f7a10c887964fa4d4397c6ec238af2bc694 Author: Marcel de Rooy Date: Sun Jul 30 16:53:00 2017 +0200 Bug 19004: Patrons.t should create its own data for enrollment fees. If the patron categories J, K, YA would not exist, Patrons.t would fail. Test plan: [1] Remove one of these patron categories. [2] Run t/db_dependent/Koha/Patrons.t Signed-off-by: Marcel de Rooy Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit 327495b5e0ec4de47d20bd27d6a1c5b88e0be191 Author: Katrin Fischer Date: Sat Aug 19 10:22:44 2017 +0200 Bug 14316: Clarify meaning of record number in Batch record modification tool Same change as the first patch, but for the batch record modification tool. Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit 4934ee4a1601bd268a7153b7189387bb073dd11f Author: Katrin Fischer Date: Mon Jun 8 02:03:34 2015 +0200 Bug 14316: Clarify meaning of record number in Batch record deletion tool Changes the label from 'list of record numbers...' to 'List of biblionumbers or authority ids...' to make it more clear to the user which kind of input is expected. To test: - Go to Tools > Batch record deletion - Check the new description - Decide if it's more clear or not Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit f1b0dae9a6055e8ba5e9a9638af32060c1e17e33 Author: Kyle M Hall Date: Fri Sep 1 08:41:51 2017 -0400 Bug 18946 [QA Followup] - code cleanup Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit 48f54016a7accfc0cc43bf01cbac70a8482bc3f9 Author: Karam Qubsi Date: Wed Jul 19 00:06:48 2017 +0800 Bug 18946 - Change language from external web fails How to reproduce: 1. Get a multiling?al Koha like http://demo1.orex.es/cgi-bin/koha/opac-changelanguage.pl?language=en http://demo1.orex.es/cgi-bin/koha/opac-changelanguage.pl?language=es-ES 2. Copy that urls to any web page in an other domain -it must be in some host - and try to link to the spanish or english version,it will keep you in the same position. 3. Apply this patch and try again , everything should work fine . Signed-off-by: Hugo Agud Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit bb31d99065c468fbec2443cd15894b03657a24d5 Author: Lari Taskula Date: Wed May 31 17:03:54 2017 +0300 Bug 18692 - intranet part Fixes misplaced columns introduced by previous patch and adds the "-" for phone transport type. To test: 1. Set SMSSendDriver system preference on 2. Go to intranet messaging preferences 3. By default you should see checkboxes for all messages for SMS 4. Ensure columns are not misplaced (pushing one column too much to the right) 5. Delete sms method from one of the messages in message_transports table 6. Observe that "-" is displayed instead of checkbox for that message for SMS 7. Repeat same for TalkingTechItivaPhoneNotification system preference. By default it may not have transports in message_transports, so make sure to assign some in order to have the checkboxes visible. Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 8fd0847c82adbcaf0af3285dd9cfc5e646ba6500 Author: Fridolin Somers Date: Thu Jun 1 17:22:42 2017 +0200 Bug 18692 - same with syspref TalkingTechItivaPhone Fixes misplaced columns introduced by previous patch and adds the "-" for phone transport type. To test: 1. Set SMSSendDriver system preference on 2. Go to intra and OPAC messaging preferences 3. By default you should see checkboxes for all messages for SMS 4. Ensure columns are not misplaced (pushing one column too much to the right) 5. Delete sms method from one of the messages in message_transports table 6. Observe that "-" is displayed instead of checkbox for that message for SMS 7. Repeat same for TalkingTechItivaPhoneNotification system preference. By default it may not have transports in message_transports, so make sure to assign some in order to have the checkboxes visible. https://bugs.koha-community.org/show_bug.cgi?id=8692 Signed-off-by: Michael Andrew Cabus Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit a932d05ace6500a3b67888aad1306e58cfa8014f Author: Fridolin Somers Date: Mon May 29 16:32:18 2017 +0200 Bug 18692 - When SMS is enabled the OPAC messaging table is misaligned Bug 6726 had corrected the fact that when SMS is enabled the messaging table is missing a column. Bug 6458 has broken this. The SMS column is missing an else case with cell containing only "-" like other columns. Test plan : - set SMSSendDriver preference empty - go to OPAC patron messaging - column SMS should not be visible - set SMSSendDriver preference not empty - go to OPAC patron messaging - column SMS appears with checkboxes Signed-off-by: Michael Andrew Cabus Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 65bce82b1fb32d3d98fe4d4ef1e1738a97749632 Author: Marc V?ron Date: Wed Aug 9 09:46:02 2017 +0200 Bug 18636: Sysprefs: Add explanation for conflict autonumbernum / BorrowerMandatoryFields This patch adds a note to the system preferences autonembernum and BorrowerMandatoryFields regarding a conflict if automembernum is on and BorrowerMandatoryFields contains cardnumber. To reproduce issue: See initial comment. To test: - Apply patch - Verify that in system preferences note appears with both prefs automembernum and BorrowerMandatoryFields Followed test plan, works as described Signed-off-by: Alex Buckley Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit 6c1504cfdb301cb0f9f3a14b5db31a63f5c3b0a5 Author: Marc V?ron Date: Tue Jun 27 18:50:44 2017 +0200 Bug 16485: collection column in Item search is always empty This patch fills the column 'Collection' in item search from the item values. To test: - Go to item search - Reproduce issue from initial comment - Apply patch - Verify that the column 'Collection' is filled Still to do, but outside of my datatable skills: Filter by drop down in the column header does a substring search. Example: Filter for 'Fiction" returns both 'Fiction' and 'Non-fiction' items. Signed-off-by: Owen Leonard Signed-off-by: Laurence Rault Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart commit 2e9165001f69312255ad1b6706f040784460d5d1 Author: Colin Campbell Date: Wed Aug 2 17:12:44 2017 +0100 Bug 19024 Do not unset order cancelled status on basket close On closing a basket, status is updated to ordered for orders not completed. However the operation was resetting the status for cancelled as well as new orders. While display is correct from the basket view (it checks the cancellation date). The status in the acquisitions tab from the catalogue view reverts erroneously to ordered. This patch adds cancelled to the statuses not updated on basket close. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit 16c25a36988b47fb9fcbabd91fdace5f98f9caed Author: Colin Campbell Date: Tue Aug 15 11:44:12 2017 +0100 Bug 19024 Fix some infelicities of phrasing in test messages The test messages were awkwardly phrased, re phrase them to sound more natuaral. Patch is cosmetic (grammar) only Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit 7db6067dc4cc55bee771fedb31e2454b72123ac0 Author: Jonathan Druart Date: Wed Aug 9 16:09:32 2017 -0300 Bug 19024: Add tests Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit 786deba62beb5a52a543af5415610e14f7d0a8c5 Author: Katrin Fischer Date: Fri Aug 18 08:36:59 2017 +0000 Bug 9857 - Follow-up - Fix for searches with su= or su: When the initial search is su=.../su:... the links was not constructed correctly. With this change, it should be the case. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit d0e3891e251a6a11188d70a5480af0e44b8c1fb0 Author: Katrin Fischer Date: Fri Dec 4 01:17:50 2015 +0100 Bug 9857: Did you mean? uses wrong punctuation in search links The link changes the search links generated by the plugins from an=authid to an:authid, as suggested by Jared on the bug report. - Turn on the AuthorityFile und ExplodedTerms plugins for the OPAC from the "Did you mean" section of the administration module - Search a term in your OPAC where one or several authorities exist. A last name or a place name might work well. - Verify that there are suggestions displayed on top of your result list. - Verify that the link created is something like: /cgi-bin/koha/opac-search.pl?q=an=14084 - Apply patch. - Verify the link has changed a little and still works correctly: /cgi-bin/koha/opac-search.pl?q=an:14084 Signed-off-by: Fr?d?ric Demians Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit 515e62992893b72c54a34311088a9442a37d8138 Author: Alex Buckley Date: Wed Jul 12 10:09:48 2017 +1200 Bug 18621: Added in value attribute to dateexpiry field Test plan: 1. Create a patron category with the dateexpiry value of 29/9/2017 2. Create a patron user from that patron category (which I'll refer to as patron A) with the date expiry value of 1/10/2017 and submit the form 3. Notice that the manual dateexpiry you have submitted is correctly displayed 4. Create a duplicate patron with the same firstname and surname and patron A, and set the date expiry value of 1/10/2017 and submit the form 5. The form displays a duplicate patron message. Notice that the dateexpiry input box is empty now 6. Select the new member (not a duplicate member) option in the messagebox 7. The form successfully submits and notice that the date expiry value displayed is that of the patron category (i.e. it is 29/9/2017) not the dateexpiry value of 1/10/2017 that you manually set for this patron 8. Apply patch 9. Repeat step 4 10. The form displays a duplicate patron message. Notice the dateexpiry input box still contains the value you entered which is 1/10/2017. Select the new member (not a duplicate member) option in the messagebox 11. The form successfully submits and notice that the date expiry value displayed is 1/10/2017 that you manually set for this patron Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit a887aeb2dff4e52f35f1f64bfc267867987cbb53 Author: Katrin Fischer Date: Fri Aug 18 00:14:52 2017 +0200 Bug 19129 - Follow-up - Add changes to patron duplicate warning Adds logic from the previous fix to the brief patron summary shown when checking a possible patron duplicate. Bonus: Also fixes missing patron category description there. To Test: - Add 2 patrons - Add a patron with the same surname and firstname as an existing patron in order to trigger the duplicate message - Click "View existing patron" - Verify display is correct when existing patron is - an organisation - not an organisation - Verify that the patron category description shows Signed-off-by: Aleisha Amohia Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit 82f183c5ea802e3231cb2442cf32474c92bd6ab4 Author: Katrin Fischer Date: Thu Aug 17 14:51:08 2017 +0000 Bug 19129 - Clean up Details tab for Organisation patrons Problem: A patron category "I" would cause display problems on the details in the intranet. This is because the templates confused patron category "I" with patron type "I" (organisation). Patch: - Cleans up variable confusion between categorycode and categorytype. - The template contained code to change the labels below the address to 'Organisational phone:" etc., I have removed this part as it does not match the edit form anymore. - Initials, date of birth and gender are still hidden for organisation - matching the edit form. Bonus: - The patron category description was missing on the right and left side of the details tab. Now it displays. - Fixes some html issues: - doubled up class attribute in a tag - doubled up To test: - Create 3 patrons - patron category code doesn't matter, but category type organisation - patron category code 'I', category type NOT organisation - patron category code NOT I, category type NOT organisaton - Check details tab in patron account in staff for all 3 - Verify patron category description shows correctly - Verify information added to the account displays correctly (phone numbers, emails, ...) Signed-off-by: Aleisha Amohia Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit ee49d5698a11ee5806aff8c8581fa22002435cff Author: Kyle M Hall Date: Fri Sep 1 09:56:09 2017 +0000 Bug 11580 - [QA Followup] Remove debug statements Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit 947834f1821449faf9148f06c84f5638b0941435 Author: Baptiste Wojtkowski Date: Thu Feb 23 16:21:05 2017 +0000 Bug 11580 : Added unit test Added one unit test when the syspref useDaysMode is active. This does not move code anymore Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit 391bf4f38dcaa89745115409d01cca9cd1e99dce Author: Sophie Meynieux Date: Wed Nov 16 16:46:04 2016 +0100 Bug 11580 - If returnBeforeExpiry is ON, use calendar to calculate return date not on closed day (depending on useDaysMode) Test plan: 1. ReturnBeforeExpiry is activated 2. useDaysMode is different from "circulation rules only" 3. Set expiry date of a patron to a near date 4. Set a closed day on calendar for this date 5. Do a checkout Without patch, return date will be patron expiration date With the patch, return date will be last open day before patron expiration day Signed-off-by: Claire Gravely Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit f24e339dd603e015557107048d1a678293cb2e65 Author: Aleisha Amohia Date: Tue Jun 27 04:14:47 2017 +0000 Bug 16726: [FOLLOW-UP] Putting text in h1 Works as outlined in test plan, search terms now appear at top as h1 as well Signed-off-by: Dilan Johnpull? Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit f10f6a19c53beb37e3ee0808ef6bb18bd88bef8a Author: Aleisha Amohia Date: Wed Jun 7 02:09:36 2017 +0000 Bug 16726: Clear text in syspref searchbox after submitting To test: 1) Go to Admin -> search for a system preference 2) Notice your search stays in the search box (this is inconsistent with search behaviour across Koha) 3) Apply patch and refresh page 4) Make another search 5) Confirm search still works as expected and search terms have been cleared from search box 6) Confirm search terms show at the top of the results Sponsored-by: Catalyst IT Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit ae7e0ee56a17ae2a0c6fdaa96c6b04229aabca74 Author: Marcel de Rooy Date: Tue Dec 20 16:58:05 2016 +0100 Bug 17797: Add XSLT_Handler in opac/unapi Replaces some code by a call to existing module. Removes the $@->code and $@->message calls. Test plan [1] Run /cgi-bin/koha/unapi?id=koha:biblionumber:[number]&format=marcxml [2] Try some variations. Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 9d207f3832bc49232f30e8d7dbf2ac60e3ab9699 Author: Kyle M Hall Date: Wed Aug 30 12:06:36 2017 -0400 Bug 19209 [Followup] - Ensure checkouts don't prevent deleting patrons Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 8c90bb78c9fe411c5ea549f8100939e29b7a4bc1 Author: Tomas Cohen Arazi Date: Wed Aug 30 12:30:05 2017 -0300 Bug 19209: (QA followup) Improve tests This path merges the pager() test and adds search results count tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 7abe6e9670ecb9b879e3b8c237fd9fad35f5ff18 Author: Tomas Cohen Arazi Date: Wed Aug 30 12:09:37 2017 -0300 Bug 19209: Add ->is_paged method to Koha::Objects This patch adds ->is_paged to Koha::Objects. It is inherited from the underlying resultset from DBIC so there's no code besides adding it to the known methods in AUTOLOAD. Tests are added for the newly exported method. To test: - Apply this patch - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/Koha/Objects.t => SUCCESS: Tests pass! - Sign off :-D Sponsored-by: Camden County Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit ff4f0858950c37eeede38b2f067841602b97d7ba Author: Nick Clemens Date: Thu Jun 15 11:07:03 2017 -0400 Bug 18812 - SIP Patron status does not respect OverduesBlockCirc To test: 1 - Set 'OverduesBlockCirc' to block 2 - Find or create a patron with overdues 3 - Perform a SIP patron lookup on that patron misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL --patron {userid or cardnumber} --password {pass} -m patron_information 4 - Note the first character of response is a ' ' 5 - Apply patch 6 - Restart memcached, apache, and plack 7 - Perform SIP patron lookup 8 - Note the first character of response is 'Y' 9 - prove t/db_dependent/SIP/Patron.t 10 - Test should return green Signed-off-by: Chris Kirby Works as advertised Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 7f27ef71e26720604b738c86c084b91858ef7c1a Author: Jonathan Druart Date: Mon Aug 7 17:29:43 2017 -0300 Bug 19056: Replace C4::Reserves::GetReserveCount with Koha::Patron->holds->count This subroutine is only used once and can easily be replaced with Koha::Patron->holds->count Test plan: - Set maxreserves=5 - Place 3 holds for a given patron - Place again 3 holds for this patron 3+3 > 5 => The holds must not be placed Signed-off-by: Marc V?ron Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart commit 9cc7268362219e39b22aebb03a83e013f467d93a Author: Jonathan Druart Date: Mon Aug 7 17:25:15 2017 -0300 Bug 19055: Remove C4::Reserves::GetReservesToBranch This subroutine is no longer in used and can be removed Test plan: git grep GetReservesToBranch must not return any results Signed-off-by: Marc V?ron Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart commit 10311769d460a775aa8c8ee8a190836a8f2b1f1e Author: Kyle M Hall Date: Mon Jul 31 09:18:15 2017 -0400 Bug 19007 - Allow paypal payments via debit or credit card again A recent change in Paypal has removed the previous default option of paying via debit or credit card without an account. To bring this option back, we need to send an additional parameter to the PayPal API. Test Plan: 1) Enable paypal for your Koha instance 2) Ensure you are not logged in to PayPal 3) Attempt to pay a fine via PayPal 4) Not the the "Pay with Debit or Credit Card" option is missing 5) Apply this patch 6) Refresh opac-account.pl 7) Attempt to make a payment via PayPal again 8) Note the option "Pay with Debit or Credit Card" is now available Signed-off-by: Kyle M Hall Signed-off-by: George Williams Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart commit 8d08254b2202353517c16f34172cb92dcdd5befa Author: Marc V?ron Date: Sat Feb 18 18:35:39 2017 +0100 Bug 14353 - Show 'damaged' and other status on the 'place holds' page in staff This patch adds status 'Damaged' to 'Information' 'Status' in the items table on 'Place hold' page. To test: - Apply patch - In staff client, try to place an item level hold for items with 'Damaged' status. - Verify that the status 'Damaged' appears in the column 'Information'. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 85b963d11fb5d8674ca6b0ec60821663f9d8cf19 Author: Nick Clemens Date: Fri Feb 26 14:46:45 2016 +0000 Bug 15924 - Coce not enabled on lists To test: Enable Coce and disable other image services Load a list and not there are no covers Apply patch Load a list and note there are covers https://bugs.koha-community.org/show_bug.cgi?id=15924 Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart commit 831d75d09c276f25f919cbdc16c8e4105fe8ddc9 Author: Kyle M Hall Date: Wed Aug 30 10:35:03 2017 -0400 Bug 19208 - Pay select option doesn't pay the selected fine The "Pay selected" option on the Fines tab in the borrower account page doesn't work as intended. The fine on top of the list gets the amount deducted, even if another fine is choosen from the list. Test Plan: 1) Create two or three fines, using the Create manual invoice function. 2) Choose one of the fines (not the one on the top) and click Pay selected 3) Pay a partial amount 4) Go back to the Pay fines tab an notice that the fine you selected has not changed. Instead, either the top fine or the total (see attachment) has ben affected. 5) Apply this patch 6) Repeat steps 1-3 7) Note the correct fine is paid Signed-off-by: Andreas Hedstr?m Mace Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart commit ccac8ba6d3799c52adc80298b96a8efaf05c4a9e Author: Jonathan Druart Date: Fri Sep 1 12:58:18 2017 -0300 Bug 18718: DBRev 17.05.00.005 Signed-off-by: Jonathan Druart commit 239589b119c88a321fb8245f859855c41dda6566 Author: Marc V?ron Date: Fri Jun 2 12:11:47 2017 +0200 Bug 18718: Language selector in staff header menu similar to OPAC This patch adds a language selector menu to the top menu of staff client similar to the OPAC. Display of language selectors at top, bottom or both can be configured with system preference StaffLangSelectorModer. It defaults to bottom. To test: - Apply patch - Udate database - Restart plack and memchached - Go to staff client, verify that language selector displays at the bottom of the page (as before) - Go to system preferences, verify that there is a new preference StaffLanguageSelectorMode (name similar to the sypref ror OPAC), and that it is set to 'footer' - Change mode for top, both and footer and verify, go to staff client and verify for each that the language selector displays as appropriate (Amended for comment #2 2017-06-02 mv) Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit d5ea914f4dc41f78dbb3a59f894f6ecbb9a1afa4 Author: Serhij Dubyk {?????? ?????} Date: Tue Aug 22 17:19:32 2017 +0300 Bug 17827 - Untranslatable "by" in MARC21slim2intranetResults.xsl Signed-off-by: Serhij Dubyk {?????? ?????} The "by" after the title was not translatable in the result lists of the intranet. This patch fixes it by removing a comment, that caused a problem with the translation scripts. To test: Test: Before this patch in file en-GB-marc-MARC21.po present next paragraph: msgid "by " msgstr " by " According string "by " in the file MARC21slim2intranetResults.xsl can not be translated (in other languages). After applying this patch performed next command: cd /usr/share/koha/misc/translator sudo env KOHA_CONF=/etc/koha/sites/mykohainstance/koha-conf.xml PERL5LIB=/usr/share/koha/lib perl -I /usr/share/koha/lib "./translate" update Now in the file en-GB-marc-MARC21.po present the following (modified) paragraph: msgid "by " msgstr " by " https://bugs.koha-community.org/show_bug.cgi?id=17827 Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 51a65731c0fa15c37351ce6bc478fa6dc63fc64f Author: Aleisha Amohia Date: Tue Aug 29 04:51:40 2017 +0000 Bug 19194: Check itemtype is defined when receiving an order To test: 1) Find a record with an item that has no itemtype (or remove the itemtype of an item) 2) Go to Acquisitions -> Find a vendor or make a new one -> create a new basket 3) Add the record from Step 1 to your basket 4) Close the basket 5) Go back to the vendor and click 'Receive shipments' 6) Put in an invoice number, click Next 7) Click the Receive link for your item 8) Confirm you see an internal server error 9) Apply the patch and refresh the page 10) The error should be gone and behaviour should continue as expected Sponsored-by: Catalyst IT Signed-off-by: Lee Jamison Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: C4/Acquisition.pm | 6 +- C4/Circulation.pm | 22 +++--- C4/Reserves.pm | 53 -------------- C4/SIP/ILS/Patron.pm | 3 +- Koha.pm | 2 +- Koha/Objects.pm | 2 +- Koha/Plugins.pm | 6 +- Koha/SuggestionEngine/Plugin/AuthorityFile.pm | 5 +- Koha/SuggestionEngine/Plugin/ExplodedTerms.pm | 7 +- acqui/orderreceive.pl | 4 +- installer/data/mysql/sysprefs.sql | 3 +- installer/data/mysql/updatedatabase.pl | 10 +++ .../en/includes/catalogue/itemsearch_item.json.inc | 3 +- .../intranet-tmpl/prog/en/includes/circ-menu.inc | 7 +- .../intranet-tmpl/prog/en/includes/header.inc | 1 + .../prog/en/includes/intranet-bottom.inc | 4 +- .../prog/en/includes/langmenu-staff-top.inc} | 10 +-- .../prog/en/includes/members-toolbar.inc | 4 +- .../prog/en/includes/messaging-preference-form.inc | 20 ++++-- .../prog/en/includes/prefs-admin-search.inc | 2 +- .../prog/en/modules/admin/preferences.tt | 2 + .../prog/en/modules/admin/preferences/patrons.pref | 2 + .../en/modules/admin/preferences/staff_client.pref | 7 ++ .../prog/en/modules/catalogue/itemsearch.tt | 4 +- .../prog/en/modules/members/memberentrygen.tt | 2 +- .../prog/en/modules/members/moremember-brief.tt | 28 +++----- .../prog/en/modules/members/moremember.tt | 74 +++++++++----------- .../prog/en/modules/members/paycollect.tt | 2 - .../prog/en/modules/reserve/request.tt | 4 +- .../prog/en/modules/tools/batch_delete_records.tt | 2 +- .../en/modules/tools/batch_record_modification.tt | 2 +- .../prog/en/xslt/MARC21slim2intranetResults.xsl | 2 +- .../bootstrap/en/modules/opac-messaging.tt | 10 ++- .../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 20 +++++- members/moremember.pl | 6 +- members/paycollect.pl | 5 +- opac/opac-account-pay.pl | 1 + opac/opac-changelanguage.pl | 14 ++-- opac/unapi | 27 +++---- reserve/request.pl | 3 +- t/db_dependent/Acquisition/close_reopen_basket.t | 15 +++- t/db_dependent/Circulation.t | 17 ++++- t/db_dependent/Circulation/Returns.t | 4 +- t/db_dependent/Circulation/dateexpiry.t | 22 +++++- t/db_dependent/Holds.t | 5 +- t/db_dependent/Koha/Objects.t | 36 ++++++++-- t/db_dependent/Koha/Patrons.t | 16 ++--- t/db_dependent/SIP/Patron.t | 34 ++++++++- 48 files changed, 313 insertions(+), 227 deletions(-) copy koha-tmpl/{opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc => intranet-tmpl/prog/en/includes/langmenu-staff-top.inc} (72%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Sep 1 22:22:44 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 01 Sep 2017 20:22:44 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.05.00-534-gecf6ca5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via ecf6ca5d6e1472bab68f174ab50a20eec6b74888 (commit) via c758e222428ba6ad69b3d52ee6030d02e17ae964 (commit) via be4f624b326574a14260c94c90aeb10a9ab56d91 (commit) via ba1f2f93ef58c8dd935add3e215facdd4a589d12 (commit) via fba915e911a3b50ff9a0ea96d25a464836471073 (commit) via a6de2b66d19b8418dcb792c23e17b211e4c17719 (commit) via 49778103ce528ccfc7fcc8be26bcae3b4ae7815b (commit) from 185927f20981f36757c97fd33cc4c8ccd0ad5a3a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ecf6ca5d6e1472bab68f174ab50a20eec6b74888 Author: Owen Leonard Date: Wed May 31 13:58:27 2017 +0000 Bug 18708 [Revised] Show itemBarcodeFallbackSearch results in a modal window This patch modifies the circulation template so that itemBarcodeFallbackSearch results show in a modal window. To test, enable the itemBarcodeFallbackSearch system preference and open a patron's account in circulation. - Submit a string which will return search results. When the page reloads a modal should display showing a table of title search results. - Test the "Check out" button and confirm that the correct item is submitted. - Test closing the modal and re-displaying it using the new "Show matching titles" button. - Confirm that the "Add record using fast cataloging" button still works correctly. - Submit a string which will return no results. No modal window should display, and only the "Add record" button should appear. - Confirm that normal checkout works correctly. - Test with itemBarcodeFallbackSearch disabled, and with a user who lacks Fast Cataloging permission. Revision removes a heading which was made redundant by the modal markup. Signed-off-by: Josef Moravec Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit c758e222428ba6ad69b3d52ee6030d02e17ae964 Author: Jonathan Druart Date: Thu Jan 19 20:14:51 2017 +0100 Bug 17967: TT syntax for notices - Prove that ODUE is compatible Nothing new here, unless we are introducing a regression. The items.fine is a trick of our historical syntax. We need to provide a way to access this value from the a notice template using the TT syntax. A bug 17976 has been opened for discussion. Test plan: Define ODUE and OVERDUES_SLIP notice templates and use it to generate overdue notices from the cronjob script (misc/cronjobs/overdue_notices.pl) or the interface (members/print_overdues.pl). You should be able to generate the same notices with and without using the TT syntax Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit be4f624b326574a14260c94c90aeb10a9ab56d91 Author: Jonathan Druart Date: Tue Jan 17 04:32:58 2017 +0100 Bug 17966: TT syntax for notices - Prove that ISSUESLIP is compatible Here we go, you will notice at the dependency list that this one is a bit different. In our former syntax we have 2 custom tags and . These tags were allowed to permit loop on the checked out items and the overdue items. In this patch, we will use the "loops" parameter, introduced by bug 17971, to pass the list of checkouts and overdues to the template. Note that Kyle suggested another approach on bug 15283: all the checkouts were send into the same array and each element of this array calls the is_from_today method, to know if the checkout is an overdue. I don't think we should rely on the Koha API, that's why I suggest to pass 2 differents object list, 1 which contains the checkouts and another one with the overdues. Note that we do rely on the Koha API, we call the Koha::Checkout->item and Koha::Item->biblio to propose an equivalent TT notice. But I think we can accept that. Test plan: Define the ISSUESLIP and ISSUEQSLIP notice templates to generate the same notices you generated with the historical syntax. Signed-off-by: Kyle M Hall https://bugs.koha-community.org/show_bug.cgi?id=17969 Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit ba1f2f93ef58c8dd935add3e215facdd4a589d12 Author: Jonathan Druart Date: Wed Aug 2 12:46:11 2017 -0300 Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace GetReserveId can easily be replaced with a call to Koha::Holds->search->next->reserve_id It will ease next changes to use Koha::Hold objects Test plan: Cancel a reserve and print a slip reserve Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit fba915e911a3b50ff9a0ea96d25a464836471073 Author: Jonathan Druart Date: Wed Aug 2 12:00:00 2017 -0300 Bug 19057: Remove C4::Reserves::GetReserve Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit a6de2b66d19b8418dcb792c23e17b211e4c17719 Author: Jonathan Druart Date: Wed Aug 2 12:21:20 2017 -0300 Bug 19057: Move C4::Reserve::GetReserve to Koha::Holds This GetReserve subroutine can be replaced with Koha::Holds->find Test plan: - git grep GetReserve must not return results where GetReserve is called - Cancel a reserve Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit 49778103ce528ccfc7fcc8be26bcae3b4ae7815b Author: Jonathan Druart Date: Fri Sep 1 16:20:18 2017 -0300 Bug 9857: Fix failing tests Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: C4/ILSDI/Services.pm | 6 +- C4/Letters.pm | 6 + C4/Members.pm | 58 +++-- C4/Overdues.pm | 3 + C4/Reserves.pm | 162 +++++------- Koha/REST/V1/Hold.pm | 18 +- koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 18 +- .../prog/en/modules/circ/circulation.tt | 89 +++++-- .../intranet-tmpl/prog/js/pages/circulation.js | 4 + t/SuggestionEngine_AuthorityFile.t | 2 +- t/db_dependent/Circulation.t | 4 +- t/db_dependent/Circulation/issue.t | 5 +- t/db_dependent/Holds.t | 99 +++---- t/db_dependent/Items/MoveItemFromBiblio.t | 13 +- t/db_dependent/Letters/TemplateToolkit.t | 274 +++++++++++++++++++- t/db_dependent/Reserves.t | 10 +- t/db_dependent/SuggestionEngine_ExplodedTerms.t | 4 +- 17 files changed, 527 insertions(+), 248 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 5 12:15:15 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 05 Sep 2017 10:15:15 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.02-59-g47a61e6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via 47a61e683fcabe386b64d4802ebcf9bb381acddb (commit) via c4b52cb4eff83399435a574041c12c5b4040a000 (commit) via 9bc653e4976945494a8e51caa6fc101abc8545ec (commit) via 0ad7c91a4b805e64fe8f529fa5f9db014dd0e18c (commit) via 923013b6f96cc24d68505a71b96416280020b309 (commit) via c0cc4229904e2c91fd583c1b905ce3a214990ccb (commit) via 2fabe5ee8f719140065b429f6a13f4633c3145a8 (commit) via 6bdc17da42b62d351593540577a06a6827be94ff (commit) via f2fad9d2b884c8b52def21f00b9c78542ed58a49 (commit) via be1bd8b56140b1ac45259c1ac3c6de25a45687b8 (commit) via 84c5bebcd3a93d21bd7b800b63ba3506adcaf0bf (commit) via 5e5cd8025301bb6efc2031f9e6f8a48a768a0dc8 (commit) via 44ccf758fe94bb105c57866411a5aba5cde5f610 (commit) via 933f139b77cc3f75946317103848f957ebf057cc (commit) via b4d95e2b08415e8041edec0c012411177decc413 (commit) via aa28f0833fd525b6918f333440fbde23a2efc39d (commit) via 12dcd7f2e79dd9b53a0cfc1ed6e3d88fd7446405 (commit) via 9b7969033f6820e7e9af314018f87ec462cc5b6d (commit) via bc0a636c18b3bb66e29dd7ca0bf4488fe742d75f (commit) via 77a8be98a47c3a424a4e81e1da25fbfed961bec3 (commit) via 0565a70c5cb4c8f365d64658109b4d84e8964952 (commit) via 06261dce0b397a4057d343e50aaf244ddff5f974 (commit) via 011030fc4cf3447db2b4fef85344cedc429fa1ae (commit) via ac54b9703689d9c29d8b195253d26f2ff866e564 (commit) via 14646cd3f84db891f1fe5562ba2577c3fc82cd7c (commit) via 1c5b315787c5714b2453f9b1ec9eb66ae6aa51b3 (commit) via 24fb60d714e5c6dc3ad3dec1295b871e196cfa98 (commit) via 5380e93aca3376e1526e79d02169c8a4d877d645 (commit) from ce8ddbf8ea7d463a822a70f474310b8b618d6347 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 47a61e683fcabe386b64d4802ebcf9bb381acddb Author: Fridolin Somers Date: Thu Aug 24 09:38:56 2017 +0200 Increment version for 17.05.03 release Signed-off-by: Fridolin Somers commit c4b52cb4eff83399435a574041c12c5b4040a000 Merge: 0ad7c91 9bc653e Author: Fridolin Somers Date: Thu Aug 24 09:34:54 2017 +0200 Merge remote-tracking branch 'translate/17.05.03-translate-20170824' into rm_170503 commit 9bc653e4976945494a8e51caa6fc101abc8545ec Author: root Date: Thu Aug 24 04:30:10 2017 -0300 Translation updates for Koha 17.05.03 commit 0ad7c91a4b805e64fe8f529fa5f9db014dd0e18c Author: Fridolin Somers Date: Thu Aug 24 09:23:50 2017 +0200 Update release notes for 17.05.03 release Signed-off-by: Fridolin Somers commit 923013b6f96cc24d68505a71b96416280020b309 Author: Fridolin Somers Date: Thu Aug 24 09:23:21 2017 +0200 remove html notes of 17.05 commit c0cc4229904e2c91fd583c1b905ce3a214990ccb Author: Amit Gupta Date: Tue Aug 15 08:33:41 2017 +0530 Bug 19035 - Stored XSS in lists.pl To Test 1. Hit the page /cgi-bin/koha/patron_lists/lists.pl 2. Click on new patron list 3. Add a text in the field Name that contains js 4. Save the page. 5. Notice js is execute 6. Apply patch and reload, the js is escaped Fixed in both the pages list.pl and list.pl?patron_list_id=xx xx is patronlist id Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit 34dcc80055998c7b301de6e2bbcfa20067c8a63c) Signed-off-by: Fridolin Somers commit 2fabe5ee8f719140065b429f6a13f4633c3145a8 Author: Amit Gupta Date: Tue Aug 15 20:58:34 2017 +0530 Bug 19114 - Stored XSS in parcels.pl Test 1. Hit the page /cgi-bin/koha/acqui/parcels.pl?booksellerid=xx xx is booksellerid 2. Add a text in the field Vendor invoice that contains java script 3. Save the page. 4. Notice js is execute 5. Apply patch and reload the js is escaped Fixed XSS for parcels.pl/parcel.pl/orderreceive.pl Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit a4ee6ce526cf0b7897badf427c18ae6bfbefe0c5) Signed-off-by: Fridolin Somers commit 6bdc17da42b62d351593540577a06a6827be94ff Author: Amit Gupta Date: Tue Aug 15 19:51:48 2017 +0530 Bug 19112 - Stored XSS in basketheader.pl page To Test 1. Hit the page /cgi-bin/koha/acqui/basketheader.pl?booksellerid=1&op=add_form 2. Add a text in the field Basket name, Internal note, Vendor note that contains java script 3. Save the page 4. Notice js is execute 5. Apply patch, reload, js is escaped. Fixed XSS on pages basket.pl/basketheader.pl/bookseller.pl Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit 65c7b505ee56f088f3c475595e53fbe53a77d4a2) Signed-off-by: Fridolin Somers commit f2fad9d2b884c8b52def21f00b9c78542ed58a49 Author: Amit Gupta Date: Tue Aug 15 15:00:55 2017 +0530 Bug 19110 - XSS Stored in branches.pl To Test 1. Hit the page /cgi-bin/koha/admin/branches.pl?op=add_form_category 2. Add a text in the field Name and description that contains js. 3. Save the page. 4. Notice js is execute 5. Apply patch and reload, the js is escaped Fixed for js escaped execute for both pages 1. /cgi-bin/koha/admin/branches.pl?op=delete_confirm&branchcode=xx xx is branchcode 2. /cgi-bin/koha/admin/branches.pl?op=add_form with Group(s): Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit 0a44868b21c4ec9f3e6a7c4e4f7db8ee22e014b6) Signed-off-by: Fridolin Somers commit be1bd8b56140b1ac45259c1ac3c6de25a45687b8 Author: Amit Gupta Date: Tue Aug 15 23:22:32 2017 +0530 Bug 19100 - XSS Flaws in memberentry.pl 1. Hit /cgi-bin/koha/members/memberentry.pl?op=add&guarantorid=xx xx - is a guarantorid 2. Notice the java script is executed. 3. Apply patch. 4. Reload page, and hit the page again /cgi-bin/koha/members/memberentry.pl?op=add&guarantorid=xx xx - is a guarantorid. 5. Notice it is no longer executed. NOTE: I had to test in Microsoft Edge, because Chrome was blocking XSS for me. Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit d42639166c9de0e83b16b04cd8c05146648b03fd) Signed-off-by: Fridolin Somers commit 84c5bebcd3a93d21bd7b800b63ba3506adcaf0bf Author: Amit Gupta Date: Tue Aug 15 09:23:13 2017 +0530 Bug 19105 - XSS Stored in holidays.pl To Test 1. Hit the page /cgi-bin/koha/tools/holidays.pl 2. Select the date 3. Add a text in the field Title and Description that contains js 4. Save the page. 5. Notice js is execute 6. Apply patch and reload, the js is escaped Fixed for all holidays Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit 1ceb4367c6879be812b600487385c53bb005260d) Signed-off-by: Fridolin Somers commit 5e5cd8025301bb6efc2031f9e6f8a48a768a0dc8 Author: Amit Gupta Date: Tue Aug 15 22:58:02 2017 +0530 Bug 16069 - XSS issue in basket.pl page 1. Hit /cgi-bin/koha/acqui/basket.pl?basketno=xx xx - is a basketno 2. Notice the java script is executed. 3. Apply patch. 4. Reload page, and hit the page again /cgi-bin/koha/acqui/basket.pl?basketno==xx xx - is a basketno. 5. Notice it is no longer executed. Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit 91711087e93e5da6265bac329791e45afb7d354f) Signed-off-by: Fridolin Somers commit 44ccf758fe94bb105c57866411a5aba5cde5f610 Author: Amit Gupta Date: Fri Aug 11 21:08:14 2017 +0530 Bug 19079 - XSS Flaws in Membership page 1. Hit /cgi-bin/koha/members/moremember.pl?borrowernumber=xx. xx - is a borrowernumber 2. Notice the java script is executed. 4. Apply patch. 5. Reload page, and hit the page again /cgi-bin/koha/members/moremember.pl?borrowernumber=xx. xx - is a borrowernumber. 6. Notice it is no longer executed. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart (cherry picked from commit 4f48532c4f3bede64533af6415e507640e2ed6e0) Signed-off-by: Fridolin Somers commit 933f139b77cc3f75946317103848f957ebf057cc Author: Amit Gupta Date: Fri Aug 4 09:44:52 2017 +0530 Bug 19033: XSS Flaws in Currencies and exchange page 1. Hit /cgi-bin/koha/admin/currency.pl 2. Enter search currencies box. 3. Notice the iframe is executed 4. Apply patch 5. Reload page, and enter iframe again on search currencies box. 6. Notice it is no longer executed Signed-off-by: Tomas Cohen Arazi Fixes the issue, follows common practice on the codebase. Signed-off-by: Jonathan Druart (cherry picked from commit 08fe6c3c3a8b3370ea212b049573a8618cf1e9e3) Signed-off-by: Fridolin Somers commit b4d95e2b08415e8041edec0c012411177decc413 Author: Jonathan Druart Date: Tue Aug 15 13:26:12 2017 -0300 Bug 19034: (followup 2) Fix letters.tt XSS flaw Signed-off-by: Jonathan Druart (cherry picked from commit 9877aa340e75697cdb435eddf825451a93b91eaf) Signed-off-by: Fridolin Somers commit aa28f0833fd525b6918f333440fbde23a2efc39d Author: Tomas Cohen Arazi Date: Mon Aug 7 11:27:33 2017 -0300 Bug 19034: (followup) Fix letters.tt XSS flaw Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart (cherry picked from commit d7ffd52dfd46190e630c1f25738e77d8d6ebebc8) Signed-off-by: Fridolin Somers commit 12dcd7f2e79dd9b53a0cfc1ed6e3d88fd7446405 Author: Amit Gupta Date: Fri Aug 4 10:41:49 2017 +0530 Bug 19034: XSS Flaws in Z39.50/SRU servers administration 1. Hit /cgi-bin/koha/admin/z3950servers.pl 2. Enter search Z39.50/SRU servers box. 3. Notice the iframe is executed. 4. Apply patch. 5. Reload page, and enter iframe again on search Z39.50/SRU servers box. 6. Notice it is no longer executed. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart (cherry picked from commit cd0c7ad870f4c2d202e2d6e31c1078bd29da979e) Signed-off-by: Fridolin Somers commit 9b7969033f6820e7e9af314018f87ec462cc5b6d Author: Amit Gupta Date: Fri Aug 4 10:38:12 2017 +0530 Bug 19034: XSS Flaws in Cities 1. Hit /cgi-bin/koha/admin/cities.pl 2. Enter search cities box. 3. Notice the iframe is executed. 4. Apply patch. 5. Reload page, and enter iframe again on search cities box. 6. Notice it is no longer executed. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart (cherry picked from commit 8b294c5a4bece7086688fb44c7c45a1ee820247c) Signed-off-by: Fridolin Somers commit bc0a636c18b3bb66e29dd7ca0bf4488fe742d75f Author: Amit Gupta Date: Fri Aug 4 10:34:19 2017 +0530 Bug 19034: XSS Flaws in Patron categories pages 1. Hit /cgi-bin/koha/admin/categories.pl 2. Enter search patron categories box. 3. Notice the iframe is executed. 4. Apply patch. 5. Reload page, and enter iframe again on search patron categories box. 6. Notice it is no longer executed. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart (cherry picked from commit 28b9a1246781fb45427a593703542a99600f6d1f) Signed-off-by: Fridolin Somers commit 77a8be98a47c3a424a4e81e1da25fbfed961bec3 Author: Amit Gupta Date: Mon Aug 7 20:49:56 2017 +0530 Bug 19050 - XSS Flaws in Quick spine label creator 1. Hit /cgi-bin/koha/labels/spinelabel-home.pl 2. Enter barcode text box. 3. Notice the iframe is executed 4. Apply patch 5. Reload page, and enter iframe again on barcode text box. 6. Notice it is no longer executed Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit 18b6e1f5272ee4e2c4c1971a4346c1759df4b3d6) Signed-off-by: Fridolin Somers commit 0565a70c5cb4c8f365d64658109b4d84e8964952 Author: Amit Gupta Date: Mon Aug 7 21:43:56 2017 +0530 Bug 19051 - XSS Flaws in - Batch item modification page 1. Hit /cgi-bin/koha/tools/batchMod.pl 2. Enter in the Barcode list (one barcode per line) text area. 3. Notice the iframe is executed. 4. Apply patch. 5. Reload page, and enter iframe again on Barcode list (one barcode per line) text area. 6. Notice it is no longer executed. 7. Fixes for both barcode and itemnumber. Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit 0726c79361a22051b847e9fe8668ab6faf81479a) Signed-off-by: Fridolin Somers commit 06261dce0b397a4057d343e50aaf244ddff5f974 Author: Amit Gupta Date: Mon Aug 7 21:24:44 2017 +0530 Bug 19051 - XSS Flaws in Batch item deletion page 1. Hit /cgi-bin/koha/tools/batchMod.pl?del=1 2. Enter in the Barcode list (one barcode per line) text area. 3. Notice the iframe is executed. 4. Apply patch. 5. Reload page, and enter iframe again on Barcode list (one barcode per line) text area. 6. Notice it is no longer executed. 7. Fixes for both barcode and itemnumber. Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit 560d5e472ae30d9f0d0984cd6dbf34ca12b0cae1) Signed-off-by: Fridolin Somers commit 011030fc4cf3447db2b4fef85344cedc429fa1ae Author: Amit Gupta Date: Mon Aug 7 21:08:36 2017 +0530 Bug 19051 - XSS Flaws in - Batch record deletion page 1. Hit /cgi-bin/koha/tools/batch_delete_records.pl 2. Enter in the Record number list (one per line) text area. 3. Notice the iframe is executed. 4. Apply patch. 5. Reload page, and enter iframe again on Record number list (one per line) text area. 6. Notice it is no longer executed. 7. Fixes for both biblio and authority records. Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit 63fce3cdb10637a14efa5ac61e9fb21e4b04e364) Signed-off-by: Fridolin Somers commit ac54b9703689d9c29d8b195253d26f2ff866e564 Author: Amit Gupta Date: Mon Aug 7 22:17:14 2017 +0530 Bug 19052 - XSS Flaws in - Invoice search page 1. Hit /cgi-bin/koha/acqui/invoices.pl 2. Enter Invoiceno, ISBN/EAN/ISSN, Title, Author, Publihser, Publication year search box. 3. Notice the iframe is executed. 4. Apply patch. 5. Reload page, and enter iframe again on Invoiceno, ISBN/EAN/ISSN, Title, Author, Publihser, Publication year search box. 6. Notice it is no longer executed. Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit 44c25d74b64ed9f125362e9627c7f9bc5635d369) Signed-off-by: Fridolin Somers commit 14646cd3f84db891f1fe5562ba2577c3fc82cd7c Author: Amit Gupta Date: Mon Aug 7 22:04:30 2017 +0530 Bug 19052 - XSS Flaws in vendor search page 1. Hit /cgi-bin/koha/acqui/booksellers.pl 2. Enter vendor search box. 3. Notice the iframe is executed. 4. Apply patch. 5. Reload page, and enter iframe again on vendor search box. 6. Notice it is no longer executed. Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit d8b1c8fc7d9ba254b1e71d1501abfae4102e7eea) Signed-off-by: Fridolin Somers commit 1c5b315787c5714b2453f9b1ec9eb66ae6aa51b3 Author: Amit Gupta Date: Mon Aug 7 22:34:05 2017 +0530 Bug 19054 - XSS Flaws in Report - Top Most-circulated items 1. Hit /cgi-bin/koha/reports/cat_issues_top.pl 2. Enter in Callnumber, Day, Month, Year search box. 3. Notice the iframe is executed. 4. Apply patch. 5. Reload page, and enter iframe again on Callnumber, Day, Month, Year search box. 6. Notice it is no longer executed. Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit 755a1fb372b29443b7d128c4c710f7a7ed63f189) Signed-off-by: Fridolin Somers commit 24fb60d714e5c6dc3ad3dec1295b871e196cfa98 Author: Amit Gupta Date: Thu Aug 10 21:51:38 2017 +0530 Bug 19078 - XSS Flaws in System preferences 1. Hit /cgi-bin/koha/admin/preferences.pl 2. Enter in search system preferences box. 3. Notice the java script is executed. 4. Apply patch. 5. Reload page, and enter in search system preferences box. 6. Notice it is no longer executed. Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit b7bb60d76041bf00f6a28fe3a55ecc2c7912a275) Signed-off-by: Fridolin Somers commit 5380e93aca3376e1526e79d02169c8a4d877d645 Author: Jonathan Druart Date: Wed Aug 9 14:08:24 2017 -0300 Bug 18726: Fix XSS at the OPAC - biblionumber The biblionumber parameter is sent by the user, we must escape all of them to avoid XSS. Fixes: Cross-site scripting OPAC pages Signed-off-by: Amit Gupta Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit 0676334968c27337cc1f3a3407ac6eeaef75f201) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- installer/data/mysql/updatedatabase.pl | 6 + .../intranet-tmpl/prog/en/modules/acqui/basket.tt | 14 +- .../prog/en/modules/acqui/basketheader.tt | 8 +- .../prog/en/modules/acqui/booksellers.tt | 4 +- .../prog/en/modules/acqui/invoices.tt | 24 +- .../prog/en/modules/acqui/orderreceive.tt | 4 +- .../intranet-tmpl/prog/en/modules/acqui/parcel.tt | 6 +- .../intranet-tmpl/prog/en/modules/acqui/parcels.tt | 2 +- .../prog/en/modules/admin/branches.tt | 14 +- .../prog/en/modules/admin/categories.tt | 2 +- .../intranet-tmpl/prog/en/modules/admin/cities.tt | 2 +- .../prog/en/modules/admin/currency.tt | 2 +- .../prog/en/modules/admin/preferences.tt | 2 +- .../prog/en/modules/admin/z3950servers.tt | 2 +- .../prog/en/modules/labels/spinelabel-print.tt | 2 +- .../prog/en/modules/members/memberentrygen.tt | 2 +- .../prog/en/modules/patron_lists/list.tt | 4 +- .../prog/en/modules/patron_lists/lists.tt | 2 +- .../prog/en/modules/reports/cat_issues_top.tt | 2 +- .../prog/en/modules/tools/batchMod-del.tt | 2 +- .../prog/en/modules/tools/batchMod-edit.tt | 2 +- .../prog/en/modules/tools/batch_delete_records.tt | 4 +- .../prog/en/modules/tools/holidays.tt | 24 +- .../intranet-tmpl/prog/en/modules/tools/letter.tt | 4 +- .../bootstrap/en/includes/opac-bottom.inc | 6 +- .../bootstrap/en/includes/opac-detail-sidebar.inc | 14 +- .../bootstrap/en/modules/opac-ISBDdetail.tt | 2 +- .../bootstrap/en/modules/opac-MARCdetail.tt | 12 +- .../bootstrap/en/modules/opac-alert-subscribe.tt | 10 +- .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 34 +- .../en/modules/opac-full-serial-issues.tt | 6 +- .../bootstrap/en/modules/opac-serial-issues.tt | 2 +- members/moremember.pl | 2 + misc/release_notes/release_notes_17_05_00.html | 1604 -------- misc/release_notes/release_notes_17_05_01.html | 424 -- misc/release_notes/release_notes_17_05_03.md | 295 ++ misc/translator/po/am-Ethi-marc-MARC21.po | 2 +- misc/translator/po/am-Ethi-marc-NORMARC.po | 2 +- misc/translator/po/am-Ethi-marc-UNIMARC.po | 2 +- misc/translator/po/am-Ethi-opac-bootstrap.po | 62 +- misc/translator/po/am-Ethi-staff-help.po | 2 +- misc/translator/po/am-Ethi-staff-prog.po | 1896 +++++---- misc/translator/po/ar-Arab-marc-MARC21.po | 2 +- misc/translator/po/ar-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ar-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ar-Arab-opac-bootstrap.po | 76 +- misc/translator/po/ar-Arab-staff-help.po | 14 +- misc/translator/po/ar-Arab-staff-prog.po | 1935 ++++----- misc/translator/po/as-IN-marc-MARC21.po | 2 +- misc/translator/po/as-IN-marc-NORMARC.po | 2 +- misc/translator/po/as-IN-marc-UNIMARC.po | 2 +- misc/translator/po/as-IN-opac-bootstrap.po | 62 +- misc/translator/po/as-IN-staff-help.po | 2 +- misc/translator/po/as-IN-staff-prog.po | 1896 +++++---- misc/translator/po/az-AZ-marc-MARC21.po | 2 +- misc/translator/po/az-AZ-marc-NORMARC.po | 2 +- misc/translator/po/az-AZ-marc-UNIMARC.po | 2 +- misc/translator/po/az-AZ-opac-bootstrap.po | 62 +- misc/translator/po/az-AZ-staff-help.po | 2 +- misc/translator/po/az-AZ-staff-prog.po | 1896 +++++---- misc/translator/po/be-BY-marc-MARC21.po | 2 +- misc/translator/po/be-BY-marc-NORMARC.po | 2 +- misc/translator/po/be-BY-marc-UNIMARC.po | 2 +- misc/translator/po/be-BY-opac-bootstrap.po | 62 +- misc/translator/po/be-BY-staff-help.po | 2 +- misc/translator/po/be-BY-staff-prog.po | 1900 +++++---- misc/translator/po/bg-Cyrl-marc-MARC21.po | 2 +- misc/translator/po/bg-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/bg-Cyrl-marc-UNIMARC.po | 2 +- misc/translator/po/bg-Cyrl-opac-bootstrap.po | 62 +- misc/translator/po/bg-Cyrl-staff-help.po | 2 +- misc/translator/po/bg-Cyrl-staff-prog.po | 1896 +++++---- misc/translator/po/bn-IN-marc-MARC21.po | 2 +- misc/translator/po/bn-IN-marc-NORMARC.po | 2 +- misc/translator/po/bn-IN-marc-UNIMARC.po | 2 +- misc/translator/po/bn-IN-opac-bootstrap.po | 62 +- misc/translator/po/bn-IN-staff-help.po | 2 +- misc/translator/po/bn-IN-staff-prog.po | 1896 +++++---- misc/translator/po/ca-ES-marc-MARC21.po | 2 +- misc/translator/po/ca-ES-marc-NORMARC.po | 2 +- misc/translator/po/ca-ES-marc-UNIMARC.po | 2 +- misc/translator/po/ca-ES-opac-bootstrap.po | 68 +- misc/translator/po/ca-ES-staff-help.po | 2 +- misc/translator/po/ca-ES-staff-prog.po | 1898 +++++---- misc/translator/po/cs-CZ-marc-MARC21.po | 6 +- misc/translator/po/cs-CZ-marc-NORMARC.po | 2 +- misc/translator/po/cs-CZ-marc-UNIMARC.po | 2 +- misc/translator/po/cs-CZ-opac-bootstrap.po | 74 +- misc/translator/po/cs-CZ-pref.po | 238 +- misc/translator/po/cs-CZ-staff-help.po | 2 +- misc/translator/po/cs-CZ-staff-prog.po | 1908 +++++---- misc/translator/po/cy-GB-marc-MARC21.po | 2 +- misc/translator/po/cy-GB-marc-NORMARC.po | 2 +- misc/translator/po/cy-GB-marc-UNIMARC.po | 2 +- misc/translator/po/cy-GB-opac-bootstrap.po | 62 +- misc/translator/po/cy-GB-staff-help.po | 2 +- misc/translator/po/cy-GB-staff-prog.po | 1896 +++++---- misc/translator/po/da-DK-marc-MARC21.po | 2 +- misc/translator/po/da-DK-marc-NORMARC.po | 2 +- misc/translator/po/da-DK-marc-UNIMARC.po | 2 +- misc/translator/po/da-DK-opac-bootstrap.po | 62 +- misc/translator/po/da-DK-staff-help.po | 2 +- misc/translator/po/da-DK-staff-prog.po | 1903 +++++---- misc/translator/po/de-CH-marc-MARC21.po | 2 +- misc/translator/po/de-CH-marc-NORMARC.po | 2 +- misc/translator/po/de-CH-marc-UNIMARC.po | 2 +- misc/translator/po/de-CH-opac-bootstrap.po | 76 +- misc/translator/po/de-CH-staff-help.po | 6 +- misc/translator/po/de-CH-staff-prog.po | 1907 +++++---- misc/translator/po/de-DE-marc-MARC21.po | 2 +- misc/translator/po/de-DE-marc-NORMARC.po | 2 +- misc/translator/po/de-DE-marc-UNIMARC.po | 2 +- misc/translator/po/de-DE-opac-bootstrap.po | 80 +- misc/translator/po/de-DE-staff-help.po | 8 +- misc/translator/po/de-DE-staff-prog.po | 1927 ++++----- misc/translator/po/el-GR-marc-MARC21.po | 2 +- misc/translator/po/el-GR-marc-NORMARC.po | 2 +- misc/translator/po/el-GR-marc-UNIMARC.po | 240 +- misc/translator/po/el-GR-opac-bootstrap.po | 74 +- misc/translator/po/el-GR-staff-help.po | 2 +- misc/translator/po/el-GR-staff-prog.po | 2101 +++++----- misc/translator/po/en-GB-marc-MARC21.po | 2 +- misc/translator/po/en-GB-marc-NORMARC.po | 2 +- misc/translator/po/en-GB-marc-UNIMARC.po | 2 +- misc/translator/po/en-GB-opac-bootstrap.po | 62 +- misc/translator/po/en-GB-staff-help.po | 2 +- misc/translator/po/en-GB-staff-prog.po | 1896 +++++---- misc/translator/po/en-NZ-marc-MARC21.po | 2 +- misc/translator/po/en-NZ-marc-NORMARC.po | 2 +- misc/translator/po/en-NZ-marc-UNIMARC.po | 2 +- misc/translator/po/en-NZ-opac-bootstrap.po | 69 +- misc/translator/po/en-NZ-staff-help.po | 2 +- misc/translator/po/en-NZ-staff-prog.po | 1998 ++++----- misc/translator/po/eo-marc-MARC21.po | 2 +- misc/translator/po/eo-marc-NORMARC.po | 2 +- misc/translator/po/eo-marc-UNIMARC.po | 2 +- misc/translator/po/eo-opac-bootstrap.po | 65 +- misc/translator/po/eo-staff-help.po | 2 +- misc/translator/po/eo-staff-prog.po | 1898 +++++---- misc/translator/po/es-ES-marc-MARC21.po | 2 +- misc/translator/po/es-ES-marc-NORMARC.po | 2 +- misc/translator/po/es-ES-marc-UNIMARC.po | 2 +- misc/translator/po/es-ES-opac-bootstrap.po | 76 +- misc/translator/po/es-ES-staff-help.po | 6 +- misc/translator/po/es-ES-staff-prog.po | 1918 +++++---- misc/translator/po/eu-marc-MARC21.po | 2 +- misc/translator/po/eu-marc-NORMARC.po | 2 +- misc/translator/po/eu-marc-UNIMARC.po | 2 +- misc/translator/po/eu-opac-bootstrap.po | 67 +- misc/translator/po/eu-staff-help.po | 2 +- misc/translator/po/eu-staff-prog.po | 1896 +++++---- misc/translator/po/fa-Arab-marc-MARC21.po | 2 +- misc/translator/po/fa-Arab-marc-NORMARC.po | 2 +- misc/translator/po/fa-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/fa-Arab-opac-bootstrap.po | 62 +- misc/translator/po/fa-Arab-staff-help.po | 2 +- misc/translator/po/fa-Arab-staff-prog.po | 1897 +++++---- misc/translator/po/fi-FI-marc-MARC21.po | 2 +- misc/translator/po/fi-FI-marc-NORMARC.po | 2 +- misc/translator/po/fi-FI-marc-UNIMARC.po | 2 +- misc/translator/po/fi-FI-opac-bootstrap.po | 70 +- misc/translator/po/fi-FI-pref.po | 81 +- misc/translator/po/fi-FI-staff-help.po | 2 +- misc/translator/po/fi-FI-staff-prog.po | 2053 +++++----- misc/translator/po/fo-FO-marc-MARC21.po | 2 +- misc/translator/po/fo-FO-marc-NORMARC.po | 2 +- misc/translator/po/fo-FO-marc-UNIMARC.po | 2 +- misc/translator/po/fo-FO-opac-bootstrap.po | 62 +- misc/translator/po/fo-FO-staff-help.po | 2 +- misc/translator/po/fo-FO-staff-prog.po | 1896 +++++---- misc/translator/po/fr-CA-marc-MARC21.po | 20 +- misc/translator/po/fr-CA-marc-NORMARC.po | 2 +- misc/translator/po/fr-CA-marc-UNIMARC.po | 2 +- misc/translator/po/fr-CA-opac-bootstrap.po | 69 +- misc/translator/po/fr-CA-staff-help.po | 2 +- misc/translator/po/fr-CA-staff-prog.po | 1936 ++++----- misc/translator/po/fr-FR-marc-MARC21.po | 2 +- misc/translator/po/fr-FR-marc-NORMARC.po | 2 +- misc/translator/po/fr-FR-marc-UNIMARC.po | 2 +- misc/translator/po/fr-FR-opac-bootstrap.po | 79 +- misc/translator/po/fr-FR-pref.po | 4 +- misc/translator/po/fr-FR-staff-help.po | 2 +- misc/translator/po/fr-FR-staff-prog.po | 1916 ++++----- misc/translator/po/gl-marc-MARC21.po | 2 +- misc/translator/po/gl-marc-NORMARC.po | 2 +- misc/translator/po/gl-marc-UNIMARC.po | 2 +- misc/translator/po/gl-opac-bootstrap.po | 62 +- misc/translator/po/gl-staff-help.po | 2 +- misc/translator/po/gl-staff-prog.po | 1899 +++++---- misc/translator/po/he-Hebr-marc-MARC21.po | 2 +- misc/translator/po/he-Hebr-marc-NORMARC.po | 2 +- misc/translator/po/he-Hebr-marc-UNIMARC.po | 2 +- misc/translator/po/he-Hebr-opac-bootstrap.po | 62 +- misc/translator/po/he-Hebr-staff-help.po | 2 +- misc/translator/po/he-Hebr-staff-prog.po | 1899 +++++---- misc/translator/po/hi-marc-MARC21.po | 2 +- misc/translator/po/hi-marc-NORMARC.po | 2 +- misc/translator/po/hi-marc-UNIMARC.po | 2 +- misc/translator/po/hi-opac-bootstrap.po | 68 +- misc/translator/po/hi-staff-help.po | 2 +- misc/translator/po/hi-staff-prog.po | 1904 +++++---- misc/translator/po/hr-HR-marc-MARC21.po | 2 +- misc/translator/po/hr-HR-marc-NORMARC.po | 2 +- misc/translator/po/hr-HR-marc-UNIMARC.po | 2 +- misc/translator/po/hr-HR-opac-bootstrap.po | 62 +- misc/translator/po/hr-HR-staff-help.po | 2 +- misc/translator/po/hr-HR-staff-prog.po | 1898 +++++---- misc/translator/po/hu-HU-marc-MARC21.po | 2 +- misc/translator/po/hu-HU-marc-NORMARC.po | 2 +- misc/translator/po/hu-HU-marc-UNIMARC.po | 2 +- misc/translator/po/hu-HU-opac-bootstrap.po | 66 +- misc/translator/po/hu-HU-staff-help.po | 2 +- misc/translator/po/hu-HU-staff-prog.po | 1896 +++++---- misc/translator/po/hy-Armn-marc-MARC21.po | 2 +- misc/translator/po/hy-Armn-marc-NORMARC.po | 2 +- misc/translator/po/hy-Armn-marc-UNIMARC.po | 2 +- misc/translator/po/hy-Armn-opac-bootstrap.po | 68 +- misc/translator/po/hy-Armn-staff-help.po | 2 +- misc/translator/po/hy-Armn-staff-prog.po | 1904 +++++---- misc/translator/po/ia-marc-MARC21.po | 99 +- misc/translator/po/ia-marc-NORMARC.po | 2 +- misc/translator/po/ia-marc-UNIMARC.po | 2 +- misc/translator/po/ia-opac-bootstrap.po | 62 +- misc/translator/po/ia-staff-help.po | 2 +- misc/translator/po/ia-staff-prog.po | 1896 +++++---- misc/translator/po/id-ID-marc-MARC21.po | 2 +- misc/translator/po/id-ID-marc-NORMARC.po | 2 +- misc/translator/po/id-ID-marc-UNIMARC.po | 2 +- misc/translator/po/id-ID-opac-bootstrap.po | 62 +- misc/translator/po/id-ID-staff-help.po | 2 +- misc/translator/po/id-ID-staff-prog.po | 1898 +++++---- misc/translator/po/iq-CA-marc-MARC21.po | 2 +- misc/translator/po/iq-CA-marc-NORMARC.po | 2 +- misc/translator/po/iq-CA-marc-UNIMARC.po | 2 +- misc/translator/po/iq-CA-opac-bootstrap.po | 62 +- misc/translator/po/iq-CA-staff-help.po | 2 +- misc/translator/po/iq-CA-staff-prog.po | 1896 +++++---- misc/translator/po/is-IS-marc-MARC21.po | 2 +- misc/translator/po/is-IS-marc-NORMARC.po | 2 +- misc/translator/po/is-IS-marc-UNIMARC.po | 2 +- misc/translator/po/is-IS-opac-bootstrap.po | 62 +- misc/translator/po/is-IS-staff-help.po | 2 +- misc/translator/po/is-IS-staff-prog.po | 1896 +++++---- misc/translator/po/it-IT-marc-MARC21.po | 2 +- misc/translator/po/it-IT-marc-NORMARC.po | 2 +- misc/translator/po/it-IT-marc-UNIMARC.po | 2 +- misc/translator/po/it-IT-opac-bootstrap.po | 69 +- misc/translator/po/it-IT-staff-help.po | 2 +- misc/translator/po/it-IT-staff-prog.po | 1904 +++++---- misc/translator/po/iu-CA-marc-MARC21.po | 2 +- misc/translator/po/iu-CA-marc-NORMARC.po | 2 +- misc/translator/po/iu-CA-marc-UNIMARC.po | 2 +- misc/translator/po/iu-CA-opac-bootstrap.po | 62 +- misc/translator/po/iu-CA-staff-help.po | 2 +- misc/translator/po/iu-CA-staff-prog.po | 1896 +++++---- misc/translator/po/ja-Jpan-JP-marc-MARC21.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-NORMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-UNIMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-opac-bootstrap.po | 62 +- misc/translator/po/ja-Jpan-JP-staff-help.po | 2 +- misc/translator/po/ja-Jpan-JP-staff-prog.po | 1910 +++++---- misc/translator/po/ka-marc-MARC21.po | 2 +- misc/translator/po/ka-marc-NORMARC.po | 2 +- misc/translator/po/ka-marc-UNIMARC.po | 2 +- misc/translator/po/ka-opac-bootstrap.po | 62 +- misc/translator/po/ka-staff-help.po | 2 +- misc/translator/po/ka-staff-prog.po | 1896 +++++---- misc/translator/po/km-KH-marc-MARC21.po | 2 +- misc/translator/po/km-KH-marc-NORMARC.po | 2 +- misc/translator/po/km-KH-marc-UNIMARC.po | 2 +- misc/translator/po/km-KH-opac-bootstrap.po | 62 +- misc/translator/po/km-KH-staff-help.po | 2 +- misc/translator/po/km-KH-staff-prog.po | 1896 +++++---- misc/translator/po/kn-Knda-marc-MARC21.po | 2 +- misc/translator/po/kn-Knda-marc-NORMARC.po | 2 +- misc/translator/po/kn-Knda-marc-UNIMARC.po | 2 +- misc/translator/po/kn-Knda-opac-bootstrap.po | 62 +- misc/translator/po/kn-Knda-staff-help.po | 2 +- misc/translator/po/kn-Knda-staff-prog.po | 1899 +++++---- misc/translator/po/ko-Kore-KP-marc-MARC21.po | 2 +- misc/translator/po/ko-Kore-KP-marc-NORMARC.po | 2 +- misc/translator/po/ko-Kore-KP-marc-UNIMARC.po | 2 +- misc/translator/po/ko-Kore-KP-opac-bootstrap.po | 62 +- misc/translator/po/ko-Kore-KP-staff-help.po | 2 +- misc/translator/po/ko-Kore-KP-staff-prog.po | 1904 +++++---- misc/translator/po/ku-Arab-marc-MARC21.po | 2 +- misc/translator/po/ku-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ku-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ku-Arab-opac-bootstrap.po | 62 +- misc/translator/po/ku-Arab-staff-help.po | 2 +- misc/translator/po/ku-Arab-staff-prog.po | 1898 +++++---- misc/translator/po/lo-Laoo-marc-MARC21.po | 2 +- misc/translator/po/lo-Laoo-marc-NORMARC.po | 2 +- misc/translator/po/lo-Laoo-marc-UNIMARC.po | 2 +- misc/translator/po/lo-Laoo-opac-bootstrap.po | 62 +- misc/translator/po/lo-Laoo-staff-help.po | 2 +- misc/translator/po/lo-Laoo-staff-prog.po | 1901 +++++---- misc/translator/po/mi-NZ-marc-MARC21.po | 2 +- misc/translator/po/mi-NZ-marc-NORMARC.po | 2 +- misc/translator/po/mi-NZ-marc-UNIMARC.po | 2 +- misc/translator/po/mi-NZ-opac-bootstrap.po | 62 +- misc/translator/po/mi-NZ-staff-help.po | 2 +- misc/translator/po/mi-NZ-staff-prog.po | 1896 +++++---- misc/translator/po/ml-marc-MARC21.po | 2 +- misc/translator/po/ml-marc-NORMARC.po | 2 +- misc/translator/po/ml-marc-UNIMARC.po | 2 +- misc/translator/po/ml-opac-bootstrap.po | 62 +- misc/translator/po/ml-staff-help.po | 2 +- misc/translator/po/ml-staff-prog.po | 1896 +++++---- misc/translator/po/mon-marc-MARC21.po | 2 +- misc/translator/po/mon-marc-NORMARC.po | 2 +- misc/translator/po/mon-marc-UNIMARC.po | 2 +- misc/translator/po/mon-opac-bootstrap.po | 62 +- misc/translator/po/mon-staff-help.po | 2 +- misc/translator/po/mon-staff-prog.po | 1896 +++++---- misc/translator/po/mr-marc-MARC21.po | 2 +- misc/translator/po/mr-marc-NORMARC.po | 2 +- misc/translator/po/mr-marc-UNIMARC.po | 2 +- misc/translator/po/mr-opac-bootstrap.po | 62 +- misc/translator/po/mr-staff-help.po | 2 +- misc/translator/po/mr-staff-prog.po | 1901 +++++---- misc/translator/po/ms-MY-marc-MARC21.po | 2 +- misc/translator/po/ms-MY-marc-NORMARC.po | 2 +- misc/translator/po/ms-MY-marc-UNIMARC.po | 2 +- misc/translator/po/ms-MY-opac-bootstrap.po | 62 +- misc/translator/po/ms-MY-staff-help.po | 2 +- misc/translator/po/ms-MY-staff-prog.po | 1910 +++++---- misc/translator/po/my-marc-MARC21.po | 2 +- misc/translator/po/my-marc-NORMARC.po | 2 +- misc/translator/po/my-marc-UNIMARC.po | 2 +- misc/translator/po/my-opac-bootstrap.po | 62 +- misc/translator/po/my-staff-help.po | 2 +- misc/translator/po/my-staff-prog.po | 1896 +++++---- misc/translator/po/nb-NO-marc-MARC21.po | 2 +- misc/translator/po/nb-NO-marc-NORMARC.po | 2 +- misc/translator/po/nb-NO-marc-UNIMARC.po | 2 +- misc/translator/po/nb-NO-opac-bootstrap.po | 976 ++--- misc/translator/po/nb-NO-staff-help.po | 2 +- misc/translator/po/nb-NO-staff-prog.po | 1904 +++++---- misc/translator/po/ne-NE-marc-MARC21.po | 2 +- misc/translator/po/ne-NE-marc-NORMARC.po | 2 +- misc/translator/po/ne-NE-marc-UNIMARC.po | 2 +- misc/translator/po/ne-NE-opac-bootstrap.po | 62 +- misc/translator/po/ne-NE-staff-help.po | 2 +- misc/translator/po/ne-NE-staff-prog.po | 1896 +++++---- misc/translator/po/nl-BE-marc-MARC21.po | 2 +- misc/translator/po/nl-BE-marc-NORMARC.po | 2 +- misc/translator/po/nl-BE-marc-UNIMARC.po | 2 +- misc/translator/po/nl-BE-opac-bootstrap.po | 62 +- misc/translator/po/nl-BE-staff-help.po | 2 +- misc/translator/po/nl-BE-staff-prog.po | 1901 +++++---- misc/translator/po/nl-NL-marc-MARC21.po | 2 +- misc/translator/po/nl-NL-marc-NORMARC.po | 2 +- misc/translator/po/nl-NL-marc-UNIMARC.po | 2 +- misc/translator/po/nl-NL-opac-bootstrap.po | 62 +- misc/translator/po/nl-NL-staff-help.po | 2 +- misc/translator/po/nl-NL-staff-prog.po | 1900 +++++---- misc/translator/po/nn-NO-marc-MARC21.po | 2 +- misc/translator/po/nn-NO-marc-NORMARC.po | 2 +- misc/translator/po/nn-NO-marc-UNIMARC.po | 2 +- misc/translator/po/nn-NO-opac-bootstrap.po | 62 +- misc/translator/po/nn-NO-staff-help.po | 2 +- misc/translator/po/nn-NO-staff-prog.po | 1896 +++++---- misc/translator/po/oc-marc-MARC21.po | 2 +- misc/translator/po/oc-marc-NORMARC.po | 2 +- misc/translator/po/oc-marc-UNIMARC.po | 2 +- misc/translator/po/oc-opac-bootstrap.po | 62 +- misc/translator/po/oc-staff-help.po | 2 +- misc/translator/po/oc-staff-prog.po | 1904 +++++---- misc/translator/po/pbr-marc-MARC21.po | 2 +- misc/translator/po/pbr-marc-NORMARC.po | 2 +- misc/translator/po/pbr-marc-UNIMARC.po | 2 +- misc/translator/po/pbr-opac-bootstrap.po | 62 +- misc/translator/po/pbr-staff-help.po | 2 +- misc/translator/po/pbr-staff-prog.po | 1896 +++++---- misc/translator/po/pl-PL-marc-MARC21.po | 2 +- misc/translator/po/pl-PL-marc-NORMARC.po | 2 +- misc/translator/po/pl-PL-marc-UNIMARC.po | 2 +- misc/translator/po/pl-PL-opac-bootstrap.po | 72 +- misc/translator/po/pl-PL-staff-help.po | 2 +- misc/translator/po/pl-PL-staff-prog.po | 1913 +++++---- misc/translator/po/prs-marc-MARC21.po | 2 +- misc/translator/po/prs-marc-NORMARC.po | 2 +- misc/translator/po/prs-marc-UNIMARC.po | 2 +- misc/translator/po/prs-opac-bootstrap.po | 62 +- misc/translator/po/prs-staff-help.po | 2 +- misc/translator/po/prs-staff-prog.po | 1899 +++++---- misc/translator/po/pt-BR-marc-MARC21.po | 2 +- misc/translator/po/pt-BR-marc-NORMARC.po | 2 +- misc/translator/po/pt-BR-marc-UNIMARC.po | 2 +- misc/translator/po/pt-BR-opac-bootstrap.po | 62 +- misc/translator/po/pt-BR-staff-help.po | 2 +- misc/translator/po/pt-BR-staff-prog.po | 1904 +++++---- misc/translator/po/pt-PT-marc-MARC21.po | 2 +- misc/translator/po/pt-PT-marc-NORMARC.po | 2 +- misc/translator/po/pt-PT-marc-UNIMARC.po | 2 +- misc/translator/po/pt-PT-opac-bootstrap.po | 69 +- misc/translator/po/pt-PT-staff-help.po | 2 +- misc/translator/po/pt-PT-staff-prog.po | 1904 +++++---- misc/translator/po/ro-RO-marc-MARC21.po | 2 +- misc/translator/po/ro-RO-marc-NORMARC.po | 2 +- misc/translator/po/ro-RO-marc-UNIMARC.po | 2 +- misc/translator/po/ro-RO-opac-bootstrap.po | 64 +- misc/translator/po/ro-RO-staff-help.po | 2 +- misc/translator/po/ro-RO-staff-prog.po | 1896 +++++---- misc/translator/po/ru-RU-marc-MARC21.po | 2 +- misc/translator/po/ru-RU-marc-NORMARC.po | 2 +- misc/translator/po/ru-RU-marc-UNIMARC.po | 2 +- misc/translator/po/ru-RU-opac-bootstrap.po | 71 +- misc/translator/po/ru-RU-staff-help.po | 2 +- misc/translator/po/ru-RU-staff-prog.po | 1902 +++++---- misc/translator/po/rw-RW-marc-MARC21.po | 2 +- misc/translator/po/rw-RW-marc-NORMARC.po | 2 +- misc/translator/po/rw-RW-marc-UNIMARC.po | 2 +- misc/translator/po/rw-RW-opac-bootstrap.po | 62 +- misc/translator/po/rw-RW-staff-help.po | 2 +- misc/translator/po/rw-RW-staff-prog.po | 1896 +++++---- misc/translator/po/sd-PK-marc-MARC21.po | 2 +- misc/translator/po/sd-PK-marc-NORMARC.po | 2 +- misc/translator/po/sd-PK-marc-UNIMARC.po | 2 +- misc/translator/po/sd-PK-opac-bootstrap.po | 62 +- misc/translator/po/sd-PK-staff-help.po | 2 +- misc/translator/po/sd-PK-staff-prog.po | 1896 +++++---- misc/translator/po/sk-SK-marc-MARC21.po | 2 +- misc/translator/po/sk-SK-marc-NORMARC.po | 2 +- misc/translator/po/sk-SK-marc-UNIMARC.po | 2 +- misc/translator/po/sk-SK-opac-bootstrap.po | 68 +- misc/translator/po/sk-SK-staff-help.po | 2 +- misc/translator/po/sk-SK-staff-prog.po | 1904 +++++---- misc/translator/po/sl-SI-marc-MARC21.po | 2 +- misc/translator/po/sl-SI-marc-NORMARC.po | 2 +- misc/translator/po/sl-SI-marc-UNIMARC.po | 2 +- misc/translator/po/sl-SI-opac-bootstrap.po | 62 +- misc/translator/po/sl-SI-staff-help.po | 2 +- misc/translator/po/sl-SI-staff-prog.po | 1896 +++++---- misc/translator/po/sq-AL-marc-MARC21.po | 2 +- misc/translator/po/sq-AL-marc-NORMARC.po | 2 +- misc/translator/po/sq-AL-marc-UNIMARC.po | 2 +- misc/translator/po/sq-AL-opac-bootstrap.po | 69 +- misc/translator/po/sq-AL-staff-help.po | 2 +- misc/translator/po/sq-AL-staff-prog.po | 1896 +++++---- misc/translator/po/sr-Cyrl-marc-MARC21.po | 2 +- misc/translator/po/sr-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/sr-Cyrl-marc-UNIMARC.po | 2 +- misc/translator/po/sr-Cyrl-opac-bootstrap.po | 62 +- misc/translator/po/sr-Cyrl-staff-help.po | 2 +- misc/translator/po/sr-Cyrl-staff-prog.po | 1896 +++++---- misc/translator/po/sv-SE-marc-MARC21.po | 2 +- misc/translator/po/sv-SE-marc-NORMARC.po | 2 +- misc/translator/po/sv-SE-marc-UNIMARC.po | 2 +- misc/translator/po/sv-SE-opac-bootstrap.po | 69 +- misc/translator/po/sv-SE-staff-help.po | 2 +- misc/translator/po/sv-SE-staff-prog.po | 1904 +++++---- misc/translator/po/sw-KE-marc-MARC21.po | 30 +- misc/translator/po/sw-KE-marc-NORMARC.po | 2 +- misc/translator/po/sw-KE-marc-UNIMARC.po | 2 +- misc/translator/po/sw-KE-opac-bootstrap.po | 62 +- misc/translator/po/sw-KE-staff-help.po | 2 +- misc/translator/po/sw-KE-staff-prog.po | 1896 +++++---- misc/translator/po/ta-LK-marc-MARC21.po | 2 +- misc/translator/po/ta-LK-marc-NORMARC.po | 2 +- misc/translator/po/ta-LK-marc-UNIMARC.po | 2 +- misc/translator/po/ta-LK-opac-bootstrap.po | 62 +- misc/translator/po/ta-LK-staff-help.po | 2 +- misc/translator/po/ta-LK-staff-prog.po | 1896 +++++---- misc/translator/po/ta-marc-MARC21.po | 372 +- misc/translator/po/ta-marc-NORMARC.po | 2 +- misc/translator/po/ta-marc-UNIMARC.po | 2 +- misc/translator/po/ta-opac-bootstrap.po | 290 +- misc/translator/po/ta-staff-help.po | 2 +- misc/translator/po/ta-staff-prog.po | 2105 +++++----- misc/translator/po/tet-marc-MARC21.po | 2 +- misc/translator/po/tet-marc-NORMARC.po | 2 +- misc/translator/po/tet-marc-UNIMARC.po | 2 +- misc/translator/po/tet-opac-bootstrap.po | 62 +- misc/translator/po/tet-staff-help.po | 2 +- misc/translator/po/tet-staff-prog.po | 1903 +++++---- misc/translator/po/th-TH-marc-MARC21.po | 2 +- misc/translator/po/th-TH-marc-NORMARC.po | 2 +- misc/translator/po/th-TH-marc-UNIMARC.po | 2 +- misc/translator/po/th-TH-opac-bootstrap.po | 62 +- misc/translator/po/th-TH-staff-help.po | 2 +- misc/translator/po/th-TH-staff-prog.po | 1896 +++++---- misc/translator/po/tl-PH-marc-MARC21.po | 12 +- misc/translator/po/tl-PH-marc-NORMARC.po | 2 +- misc/translator/po/tl-PH-marc-UNIMARC.po | 2 +- misc/translator/po/tl-PH-opac-bootstrap.po | 62 +- misc/translator/po/tl-PH-staff-help.po | 14 +- misc/translator/po/tl-PH-staff-prog.po | 1896 +++++---- misc/translator/po/tr-TR-marc-MARC21.po | 2 +- misc/translator/po/tr-TR-marc-NORMARC.po | 2 +- misc/translator/po/tr-TR-marc-UNIMARC.po | 2 +- misc/translator/po/tr-TR-opac-bootstrap.po | 82 +- misc/translator/po/tr-TR-pref.po | 11 +- misc/translator/po/tr-TR-staff-help.po | 2 +- misc/translator/po/tr-TR-staff-prog.po | 2144 +++++----- misc/translator/po/uk-UA-marc-MARC21.po | 2 +- misc/translator/po/uk-UA-marc-NORMARC.po | 2 +- misc/translator/po/uk-UA-marc-UNIMARC.po | 14 +- misc/translator/po/uk-UA-opac-bootstrap.po | 82 +- misc/translator/po/uk-UA-pref.po | 30 +- misc/translator/po/uk-UA-staff-help.po | 41 +- misc/translator/po/uk-UA-staff-prog.po | 4222 ++++++++++---------- misc/translator/po/ur-Arab-marc-MARC21.po | 2 +- misc/translator/po/ur-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ur-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ur-Arab-opac-bootstrap.po | 62 +- misc/translator/po/ur-Arab-staff-help.po | 2 +- misc/translator/po/ur-Arab-staff-prog.po | 1896 +++++---- misc/translator/po/vi-VN-marc-MARC21.po | 2 +- misc/translator/po/vi-VN-marc-NORMARC.po | 2 +- misc/translator/po/vi-VN-marc-UNIMARC.po | 2 +- misc/translator/po/vi-VN-opac-bootstrap.po | 62 +- misc/translator/po/vi-VN-staff-help.po | 2 +- misc/translator/po/vi-VN-staff-prog.po | 1899 +++++---- misc/translator/po/zh-Hans-CN-marc-MARC21.po | 2 +- misc/translator/po/zh-Hans-CN-marc-NORMARC.po | 2 +- misc/translator/po/zh-Hans-CN-marc-UNIMARC.po | 2 +- misc/translator/po/zh-Hans-CN-opac-bootstrap.po | 62 +- misc/translator/po/zh-Hans-CN-staff-help.po | 2 +- misc/translator/po/zh-Hans-CN-staff-prog.po | 1904 +++++---- misc/translator/po/zh-Hans-TW-marc-MARC21.po | 2 +- misc/translator/po/zh-Hans-TW-marc-NORMARC.po | 2 +- misc/translator/po/zh-Hans-TW-marc-UNIMARC.po | 2 +- misc/translator/po/zh-Hans-TW-opac-bootstrap.po | 72 +- misc/translator/po/zh-Hans-TW-staff-help.po | 12 +- misc/translator/po/zh-Hans-TW-staff-prog.po | 1930 ++++----- 528 files changed, 88932 insertions(+), 79153 deletions(-) delete mode 100644 misc/release_notes/release_notes_17_05_00.html delete mode 100644 misc/release_notes/release_notes_17_05_01.html create mode 100644 misc/release_notes/release_notes_17_05_03.md hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 5 12:20:41 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 05 Sep 2017 10:20:41 +0000 Subject: [koha-commits] main Koha release repository annotated tag v17.05.03 created. v17.05.03 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The annotated tag, v17.05.03 has been created at 065a46912eca2f1659648f5d76f6f290d47235bf (tag) tagging 47a61e683fcabe386b64d4802ebcf9bb381acddb (commit) replaces v17.05.02 tagged by Fridolin Somers on Tue Sep 5 12:05:37 2017 +0200 - Log ----------------------------------------------------------------- Koha security release 17.05.03 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAABAgAGBQJZrnbxAAoJECvJNkKAZAZuf5wH/jq/Q7IGBr1GN8o4eoVliyru buq8AyeewCAYJLYI3q7K3WypKxSxGv3YgpwjwY7bmeDiWcHBjZWHFAntI0FdCfPT jr1J/XK1AfBPoxgzwMfQia/o+PkUkxtFmsD08ZCum2wnSlSloWYbLbgQQuwfXJUK AC3lfZyYf9d/9MWwveLyEJzAQsGcw5TEYRRh0/3PHe22C+azy5xHGTWG2LIcCm4M f08HyZ2gWLZiLTawnV3FTqOjGD/P+gra/s7SLyaHNAZ2nGcQyekNF/abjpqvbPGC +yLCjeEtEOKnqFTbhRT0Lwd3PtRwUGnEmZRvvNDKmZXrfELZpxn8oENhPJxe1j0= =sfAl -----END PGP SIGNATURE----- Aleisha Amohia (2): Bug 18918: Disable CSV option if no CSV profiles exist Bug 18545: Remove use of onclick from OPAC cart Alex Buckley (1): Bug 18987 - Added Koha::Account package pragma to Patron.pm Amit Gupta (20): Bug 19078 - XSS Flaws in System preferences Bug 19054 - XSS Flaws in Report - Top Most-circulated items Bug 19052 - XSS Flaws in vendor search page Bug 19052 - XSS Flaws in - Invoice search page Bug 19051 - XSS Flaws in - Batch record deletion page Bug 19051 - XSS Flaws in Batch item deletion page Bug 19051 - XSS Flaws in - Batch item modification page Bug 19050 - XSS Flaws in Quick spine label creator Bug 19034: XSS Flaws in Patron categories pages Bug 19034: XSS Flaws in Cities Bug 19034: XSS Flaws in Z39.50/SRU servers administration Bug 19033: XSS Flaws in Currencies and exchange page Bug 19079 - XSS Flaws in Membership page Bug 16069 - XSS issue in basket.pl page Bug 19105 - XSS Stored in holidays.pl Bug 19100 - XSS Flaws in memberentry.pl Bug 19110 - XSS Stored in branches.pl Bug 19112 - Stored XSS in basketheader.pl page Bug 19114 - Stored XSS in parcels.pl Bug 19035 - Stored XSS in lists.pl Chris Kirby (1): Bug 18839: Suggestion.pl spelling mistake Fridolin Somers (5): Bug 18965 - branch transfer limits pagination save bug remove html notes of 17.05 Update release notes for 17.05.03 release Merge remote-tracking branch 'translate/17.05.03-translate-20170824' into rm_170503 Increment version for 17.05.03 release Jonathan Druart (10): Bug 18982: Use KOHA_INTRANET_URL instead of syspref staffClientBaseURL Bug 18982: category.categorycode must be uppercase Bug 18982: Create a specific itemtype for these tests Bug 18982: Create a circ rule for the data we created Bug 18982: Remove data in the correct order Bug 18545: Re-add call to enableCheckboxActions Bug 18539: Forbid list context calls for Koha::Objects->find Bug 18539: remove occurrence in ReNewSubscription.t Bug 18726: Fix XSS at the OPAC - biblionumber Bug 19034: (followup 2) Fix letters.tt XSS flaw Lari Taskula (4): Bug 18976: Fix t/db_dependent/Auth.t cleanup Bug 18976: (follow-up) Fix t/db_dependent/Search/History.t cleanup Bug 18977: Rollback branch in t/db_dependent/SIP/Message.t Bug 18991: Fix cleanup in t/db_dependent/Log.t Marc V?ron (1): Bug 18832: Missing space between icon and label in button 'Patron lists' Marcel de Rooy (9): Bug 18605: Remove TRUNCATE from C4/HoldsQueue.pm Bug 19000: Fix typo in closing p tag for items Bug 18991: [QA Follow-up] Use schema txn_begin and txn_rollback Bug 18361: Koha::Objects->find should accept composite primary keys Bug 18361: Additional tests for Koha::Objects->find Bug 18361: [QA Follow-up] Resolve warning on undef values supplied Bug 18951: Some t/Biblio tests are database dependent (git mv) Bug 18951: Create data for TransformKohaToMarc.t Bug 18951: Adjust Isbd.t Nick Clemens (2): Bug 18367 - Fix untranslatable string from Bug 18264 Bug 18367 - (QA Followup) Only warn if doing a lookup and not having an item Owen Leonard (1): Bug 18545 [Follow-up] Remove use of onclick from OPAC Cart Tomas Cohen Arazi (2): Bug 18361: (QA followup) Add tests for the no params case Bug 19034: (followup) Fix letters.tt XSS flaw root (1): Translation updates for Koha 17.05.03 ----------------------------------------------------------------------- hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Sep 6 14:23:09 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 06 Sep 2017 12:23:09 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.03-5-g70a0ee9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via 70a0ee9b5911a0d28c0312e7e3517bd7a42a6f08 (commit) via 50e257e217a66fa61edca5ee481c16c980838fd8 (commit) via bba3b49c0960de7aa928c20209eaf5441f47da22 (commit) via 74c6b8a116658a0616b5825e9805ea65bb9cd504 (commit) via 67806ae612569160aac1d6cf57347d07b85e24bc (commit) from 47a61e683fcabe386b64d4802ebcf9bb381acddb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 70a0ee9b5911a0d28c0312e7e3517bd7a42a6f08 Author: Kyle M Hall Date: Fri Aug 18 04:45:41 2017 +0000 Bug 18996 [QA Followup] - Fix some minor whitespace issues Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart (cherry picked from commit 1262962a7d22b9c9b712025c5220033356c857e0) Signed-off-by: Fridolin Somers commit 50e257e217a66fa61edca5ee481c16c980838fd8 Author: Marcel de Rooy Date: Wed Aug 2 13:01:47 2017 +0200 Bug 18996: [QA Follow-up] Remove global variables from Message.t As per request of Colin in comment18, this patch makes the use of global variables in Message.t no longer needed. The three subtests are now completely independent and could well be moved to separate test scripts. Note: Strictly speaking, the use of global (package) variables could potentially introduce new bugs (e.g. if the value is modified outside the script). This seems not to be the case here, but we are safe now. Test plan: Run the test again. Signed-off-by: Marcel de Rooy Signed-off-by: Colin Campbell Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart (cherry picked from commit 37d07b28ce4089f691631bde3f6e9a2fe7b81b10) Signed-off-by: Fridolin Somers commit bba3b49c0960de7aa928c20209eaf5441f47da22 Author: Marcel de Rooy Date: Sat Jul 29 13:38:31 2017 +0200 Bug 18996: Add checkin subtest in SIP/Message.t Variable $branch was not used. Promoted some global vars to our. Shared the branchcode between all three subtests now. The third subtest contains all six cases mentioned in the first patch. Test plan: Run t/db_dependent/SIP/Message.t Signed-off-by: Marcel de Rooy Signed-off-by: Colin Campbell Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart (cherry picked from commit 2490401be149d825108fc9c9f8bf556e64e2323d) commit 74c6b8a116658a0616b5825e9805ea65bb9cd504 Author: Marcel de Rooy Date: Tue Aug 1 14:10:56 2017 +0200 Bug 18996: Resolve an uninitialized warning from ILS/Item.pm From the syslog call on line 107/108. The field $item->{title} has not been initialized. When catching the warns in a test script with Test::Warn, I got: Use of uninitialized value $args[1] in sprintf at /usr/lib/x86_64-linux-gnu/perl/5.20/Sys/Syslog.pm line 423. This simply resolves the warning. We might have a closer look to this title field on another report though. Test plan: Run Message.t from the next patch without this fix. It will fail since the additional warning makes warnings_like return false. Signed-off-by: Marcel de Rooy Signed-off-by: Colin Campbell Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart (cherry picked from commit 66a7565995c00495fe670c809d9c7cf0c900fc7f) Signed-off-by: Fridolin Somers commit 67806ae612569160aac1d6cf57347d07b85e24bc Author: Marcel de Rooy Date: Fri Jul 28 10:29:51 2017 +0200 Bug 18996: Handle data corruption from old_issues at SIP checkin As per bug 18966 AddReturn returns false with a DataCorrupted message when the issue_id at hand already occurs in the old_issues table. This should be handled when returning an item via SIP too. SIP should not pretend that the checkin was successful, since this item needs special care. The following six different situations are handled: [1] An attempt to checkin an invalid barcode is handled as before. The ok flag is false; the screen message shows 'Invalid Item'. [2] We receive a DataCorrupted message: the alert type is set to the unused 98 code to indicate this new error condition. The ok flag is false; the screen message shows 'Checkin failed: data problem'. [3] The item checked in was not checked out AND the option checked_in_ok is active. The ok flag is set to true; no screen message. [4] The item checked in was not checked out AND the option checked_in_ok is not active. The ok flag is not changed (normally false); the screen message shows 'Item not checked out'. [5] (The regular checkin) The item was checked out and AddReturn returned true. The ok flag is true; no screen message. [6] ("Otherwise") The item was checked out, but AddReturn returned false. The ok flag is false; the screen message shows 'Checkin failed'. Note: Currently this case only refers to the Wrongbranch and withdrawn messages from AddReturn (where doreturn==0). Note: Situation 1 and 5 are unchanged. Behavior is slightly changed for situation 3 and 4; the option is only used when the item was not checked out. Situation 2 and situation 6 are changed. After bug 18966 SIP returned OK in case of data corruption (while checkin failed). In the remaining cases under [6] SIP also returned OK while checkin failed. Test plan: [1] Test all six cases listed above. In order to simulate data corruption insert the issue_id at hand in old_issues before you check in. In cases 3 and 4 you need to toggle the option in your SIPconfig.xml and restart the SIP server. Case 6 can be tested by checking out at branch A, adjusting the value of pref AllowReturnToBranch and checking in at branch B. Signed-off-by: Marcel de Rooy Signed-off-by: Colin Campbell Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart (cherry picked from commit 97ec4ae98c8792835717bf1de19f8782b7cb1994) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: C4/SIP/ILS.pm | 37 +++---- C4/SIP/ILS/Item.pm | 36 +++---- C4/SIP/ILS/Transaction/Checkin.pm | 4 +- t/db_dependent/SIP/Message.t | 204 ++++++++++++++++++++++++++++++++----- 4 files changed, 217 insertions(+), 64 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Sep 6 15:15:15 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 06 Sep 2017 13:15:15 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.03-10-g4c86b57 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via 4c86b575b2ef09cceefa9a2718053e45a71c2b25 (commit) via c6a3c7c39babf64ad916650277ab752e54072916 (commit) via ad4c173bca27de2b05a1c47a3977212f72654c40 (commit) via c4e608d29954195f01ea170ff06d7e8da4814707 (commit) via 5b1c9cd3f27d377ddee5635f32fd1a3e2626409c (commit) from 70a0ee9b5911a0d28c0312e7e3517bd7a42a6f08 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4c86b575b2ef09cceefa9a2718053e45a71c2b25 Author: Jonathan Druart Date: Mon Aug 14 10:26:48 2017 -0300 Bug 18331: POST_CHOMP everywhere! Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit 3c6168d37436b7312e130f796d47271ff2de77cf) Signed-off-by: Fridolin Somers commit c6a3c7c39babf64ad916650277ab752e54072916 Author: Josef Moravec Date: Tue Aug 8 08:23:57 2017 +0000 Bug 18331: Followup - fix path to orders_by_budget csv header Signed-off-by: Josef Moravec Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit 14484ba4234fd1cbb925b5f3a4844da863c65d5a) Signed-off-by: Fridolin Somers commit ad4c173bca27de2b05a1c47a3977212f72654c40 Author: Lee Jamison Date: Fri Aug 4 19:27:22 2017 +0000 Bug 18331: Followup - Fix CSV export (once and for all!) Follow-up on Comment 21 to correct the empty_line.inc include in basket.tt https://bugs.koha-community.org/show_bug.cgi?id=18331 Signed-off-by: Lee Jamison Signed-off-by: Josef Moravec Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit 2ee4e0ac381ed23fa23b1117725b2f6a0e0db4de) Signed-off-by: Fridolin Somers commit c4e608d29954195f01ea170ff06d7e8da4814707 Author: Marc V?ron Date: Thu Aug 3 17:50:30 2017 +0200 Bug 18331: Force tt to insert newline to empty_line.inc See end of comment #4 and IRC: http://irc.koha-community.org/koha/2017-08-03#i_1958062 Signed-off-by: Lee Jamison Signed-off-by: Josef Moravec Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit a10e5383016a5cb4117719ac858cbe02a53e457b) Signed-off-by: Fridolin Somers commit 5b1c9cd3f27d377ddee5635f32fd1a3e2626409c Author: Jonathan Druart Date: Mon Jun 12 17:04:47 2017 -0300 Bug 18331: Fix CSV export (once and for all!) I am going to try and explain the problem here in order to make it a have-to-read for next changes. There are several things to test when and most of the time we break something when we try to fix something else. You have to test different CSV export, not only one. There are not all processed the same way. For instance acqui/csv/basket.tt does not contain any strings to translate and the translate script will copy the original file as it. But reports/csv/orders_by_budget.tt will not! Indeed it contains "TOTAL" which will be translated. The generated tt file for the translated language will remove all the carriage returns! That's why we cannot rely on TT for newlines (contrary to bug 16914 assumption). There are two possible methods: 1/ Fix the translate script => Hum... nope 2/ Remove all carriage returns and make them explicit by including an file that only contains 1 carriage return This second method is implemented in this patch. How it works: Use the PRE_CHOMP "[%-" and POST_CHOMP "-%]" (http://www.template-toolkit.org/docs/manual/Config.html#section_PRE_CHOMP_POST_CHOMP) to remove all the newlines that could be added by TT in the original (en) files. Then include the new_line.inc to add a new line. That way original and translated files will behave the same way. The BLOCK in the csv_headers avoid to have the newlines added, in any cases. For instance: by default we will have an empty line at the end of the headers, but the translated headers will not have it. Test plan: At least 2 signoffs will be needed, please test carefully! You will need to generate CSV with at least 2 entries! Test with the non-translated interface (en) and with the language you want. To test with a translated language you will *have to*: - cd misc/translator - perl translate update LANG - manually edit the po file, remove the fuzzy tags, correctly translate the string (do not forget the additional %s in the headers) - perl translate install LANG 1/ Export basket and basketgroup as CSV 2/ Export late orders as CSV 3/ Export items (from the item search) as CSV 4/ Export the 2 reports "Orders by fund" and "Cash register" as CSV Signed-off-by: Lee Jamison Signed-off-by: Josef Moravec Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit 8403799c7212349bee70090249e3425afd62423b) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: .../prog/en/includes/csv_headers/acqui/basket.tt | 2 +- .../prog/en/includes/csv_headers/acqui/basketgroup.tt | 2 +- .../prog/en/includes/csv_headers/acqui/lateorders.tt | 2 +- .../en/includes/csv_headers/catalogue/itemsearch.tt | 2 +- .../csv_headers/reports/cash_register_stats.tt | 2 +- .../includes/csv_headers/reports/orders_by_budget.tt | 2 +- .../intranet-tmpl/prog/en/includes/empty_line.inc | 1 + .../intranet-tmpl/prog/en/modules/acqui/csv/basket.tt | 9 ++++++--- .../prog/en/modules/acqui/csv/basketgroup.tt | 10 ++++++---- .../prog/en/modules/acqui/csv/lateorders.tt | 10 ++++++---- .../prog/en/modules/catalogue/itemsearch_csv.tt | 8 +++++--- .../prog/en/modules/reports/csv/cash_register_stats.tt | 16 +++++++++------- .../prog/en/modules/reports/csv/orders_by_budget.tt | 14 ++++++++------ 13 files changed, 47 insertions(+), 33 deletions(-) create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/empty_line.inc hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Sep 6 15:22:09 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 06 Sep 2017 13:22:09 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.03-12-ga0bc776 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via a0bc776e67569b83dc3d5bc47069ceb1408badb2 (commit) via 39a2f6421e3d0b2c415ad9abc655193357e24328 (commit) from 4c86b575b2ef09cceefa9a2718053e45a71c2b25 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a0bc776e67569b83dc3d5bc47069ceb1408badb2 Author: Nick Clemens Date: Fri Jul 7 17:55:50 2017 +0000 Bug 16976 - Unit tests Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 07c0d968b70421852ac4915633fa7f3cbd0d18cd) Signed-off-by: Fridolin Somers commit 39a2f6421e3d0b2c415ad9abc655193357e24328 Author: Nick Clemens Date: Fri Jun 16 06:36:22 2017 -0400 Bug 16976 - Authorities searches with double quotes gives ZOOM error 20003 [Alternate] I dug into this a little bit, it seems the issue is that we were double processing the query because of an extra call to C4::AuthoritiesMarc::SearchAuthorities I think we can simply remove this call To test: 1 - Perform an authority search for a value that returns results 2 - Wrap it in quotes and search 3 - 'Internal server error' 4 - Apply patch 5 - Search with quotes succeeds https://bugs.koha-community.org/show_bug.cgi?id=16796 Signed-off-by: Lee Jamison Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 9c8a04acb05466356fec8e9d6d13183295719c7d) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: Koha/SearchEngine/Zebra/QueryBuilder.pm | 1 - t/Search/Zebra/QueryBuilder.t | 38 +++++++++++++++++++++++++++++++ 2 files changed, 38 insertions(+), 1 deletion(-) create mode 100644 t/Search/Zebra/QueryBuilder.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Sep 6 15:26:36 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 06 Sep 2017 13:26:36 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.03-17-ga21f8a5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via a21f8a552ba5798342eca04a534ea9a1503b7843 (commit) via a17aa443b101f15be2b27a4bd45faa6473818247 (commit) via 1f83e41f2e9d92027401b6ffc8ebe052fe0beab3 (commit) via efd3acb03e345a4e5c7f576038ed14961bbab3d6 (commit) via 4c50a19ab920b488193d78ee18d89bb143ddae4a (commit) from a0bc776e67569b83dc3d5bc47069ceb1408badb2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a21f8a552ba5798342eca04a534ea9a1503b7843 Author: Jonathan Druart Date: Tue Aug 15 12:16:33 2017 -0300 Bug 18624: Do not return 1 in tests Signed-off-by: Jonathan Druart (cherry picked from commit 03c5eb0babc3fd7b0ecf45a8a5db91a67718d3b4) Signed-off-by: Fridolin Somers commit a17aa443b101f15be2b27a4bd45faa6473818247 Author: Tomas Cohen Arazi Date: Mon Aug 7 16:23:24 2017 -0300 Bug 18624: (followup) opac-authorities-home.tt uses 'any' Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit 9d7d524f21fbf83ef7e1031e36c9772ffe21db90) Signed-off-by: Fridolin Somers commit 1f83e41f2e9d92027401b6ffc8ebe052fe0beab3 Author: Nick Clemens Date: Fri Jun 16 09:53:39 2017 -0400 Bug 18624: Run time errors when searching authorities with Elastic search 5.3 It seems we have a syntax mismatch - any vs all all seems to the be list we expect so updating code that way To test: 1 - Enabled Elasticsearch 2 - Index some authorities 3 - Perform a 'Search entire record' search 4 - Internal server error ( Invalid marclist field provided: all at /usr/local/koha/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line 433. ) 5 - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t => FAIL: Tests fail because 'any is used' 6 - Apply patch 7 - Search should work 8 - Run: k$ prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t => SUCCESS: Tests pass! 9 Sign off :-D Signed-off-by: Tomas Cohen Arazi Edited the test plan so it mentions the new tests Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit cfb52579ec2f8859226e0e40f66d5a6d7a2ed73f) Signed-off-by: Fridolin Somers commit efd3acb03e345a4e5c7f576038ed14961bbab3d6 Author: Tomas Cohen Arazi Date: Mon Aug 7 16:09:56 2017 -0300 Bug 18624: Regression test for 'any' vs 'all' This test makes it explicit that the only string producing _all as index on build_authorities_query_compat is 'all'. To test: - Apply this patch - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t => FAIL: Test fails because the list of valid values is wrong in Koha. Note: this list has to be in sync with the templates passing the same values. A followup will be added to fix a discrepancy found between OPAC and Intranet. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit b308b0814bcd149e3f899058e693938d982bb425) Signed-off-by: Fridolin Somers commit 4c50a19ab920b488193d78ee18d89bb143ddae4a Author: Tomas Cohen Arazi Date: Mon Aug 7 16:07:40 2017 -0300 Bug 18624: Minor refactoring to ease testing Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit ff41b87302c1b242f9edd7b2e8c253bd18b57ac1) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 27 +++++----- .../bootstrap/en/modules/opac-authorities-home.tt | 2 +- .../Koha/SearchEngine/Elasticsearch/QueryBuilder.t | 55 ++++++++++++++++++++ 3 files changed, 70 insertions(+), 14 deletions(-) create mode 100644 t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Sep 6 15:29:52 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 06 Sep 2017 13:29:52 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.03-18-g8f3a7d8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via 8f3a7d800271cb2611de0cb369e907b16c30fb0b (commit) from a21f8a552ba5798342eca04a534ea9a1503b7843 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8f3a7d800271cb2611de0cb369e907b16c30fb0b Author: Jonathan Druart Date: Mon Aug 7 13:50:32 2017 -0300 Bug 19053: Keep auto_renew flag if a confirmation is needed If an item is checked out with the auto renewal flag and a confirmation is needed (holds exist, past due date, etc.) the auto renewal flag will get lost. Test plan: - Check an item out and specify a past due date - Confirm the checkout on the confirmation screen => Without this patch the checkout is not marked as auto renewal => With this patch applied the auto renewal flag will be set to the checkout Signed-off-by: Josef Moravec Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart (cherry picked from commit 3808dbc1d22b3adc43a09ba7ce00aaca01f95f5a) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: circ/circulation.pl | 1 + koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 1 + 2 files changed, 2 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Sep 6 15:35:01 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 06 Sep 2017 13:35:01 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.03-23-gf067450 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via f067450d8011fb0a27a28524bec359ffad4f2278 (commit) via 5699df9deed09edbaa3db1087f3e453c28ac1091 (commit) via 3bbb89c57181c113d64ec7649195de30b52d0806 (commit) via c6e3f2ac0575849a0b48170506a4986a50ac8bf1 (commit) via 4dd020a3019cd7e2b357153ec737b15eea95f671 (commit) from 8f3a7d800271cb2611de0cb369e907b16c30fb0b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f067450d8011fb0a27a28524bec359ffad4f2278 Author: Marcel de Rooy Date: Fri Aug 11 08:34:45 2017 +0200 Bug 19049: [QA Follow-up] Mock config, default format As requested by QA: [1] Mock_config enable_plugins in the test. [2] Fallback to MARC when format is empty. Remove die statement. Added: [3] Remove $marc. This variable got obsolete during development. [4] Add test on $input_file and $plugin_class. Test $text before calling Handler or processing $text. No need to split undef if somehow Handler returned undef, etc. If the routine returns an empty arrayref, stage-marc-import will do fine. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit a423fcff42da05e9ebf9f2b4a2f192023346e93e) Signed-off-by: Fridolin Somers commit 5699df9deed09edbaa3db1087f3e453c28ac1091 Author: Kyle M Hall Date: Thu Aug 10 09:02:37 2017 -0400 Bug 19049 [QA Followup] - Make plugin name first item in description Signed-off-by: Jonathan Druart (cherry picked from commit d8f6315b6d9b1c7145f6036b55b7927f6d6e6e48) Signed-off-by: Fridolin Somers commit 3bbb89c57181c113d64ec7649195de30b52d0806 Author: Marcel de Rooy Date: Thu Aug 10 13:02:23 2017 +0200 Bug 19049: [Follow-up] Make sure that GetPlugins finds the plugin We have to mock_config the pluginsdir before Plugins is loaded, and we should pass an absolute path (not a relative one). If you did not install the test to_marc plugin, this test would fail. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall Verified patch is compatible with original KitchenSink to_marc plugin Signed-off-by: Jonathan Druart (cherry picked from commit 0987b135ea0bb8fbd4fc39643b19715dc6e3a1c8) Signed-off-by: Fridolin Somers commit c6e3f2ac0575849a0b48170506a4986a50ac8bf1 Author: Marcel de Rooy Date: Tue Aug 8 14:51:41 2017 +0200 Bug 19049: Testing RecordsFromMarcPlugin with a to_marc plugin This patch adds a simple to_marc plugin in t/Koha/Plugin that is used in the added subtest in ImportBatch.t. Test plan: [1] Run t/db_dependent/ImportBatch.t [2] Copy the to_marc test plugin from t to your plugin directory. Under Debian packages, you should do something like: mkdir -p /var/lib/koha/master/plugins/Koha/Plugin/ cp [yourclone]/t/Koha/Plugin/MarcFieldValues.pm /var/lib/koha/master/plugins/Koha/Plugin/ [3] Check if you see this plugin on plugins/plugins-home.pl [4] Create a text file with some fields like: (Note: The plugin needs an empty line between both "records".) 100,a = Test Author 1 245,a = Title One 100,a = Author 2 245,a = Title Two [5] Go to stage-marc-import.pl. Upload the created file. Select the plugin in the format combo and proceed. Did you create two records ? Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart (cherry picked from commit 83f60adbab8e96f0f14ec547029582623ac3a068) Signed-off-by: Fridolin Somers commit 4dd020a3019cd7e2b357153ec737b15eea95f671 Author: Marcel de Rooy Date: Mon Aug 7 21:24:48 2017 +0200 Bug 19049: Fix regression on stage-marc-import with to_marc plugin Bug 12412 added the use of to_marc plugins allowing arbitrary file formats in stage-marc-import (as long as the plugins can handle them). The feature was not very visible in the code, and when bug 10407 added the marcxml format, it made some changes that broke the use of to_marc. This patch restores the functionality by: [1] Adding a sub RecordsFromMarcPlugin to ImportBatch.pm, specifically addressing the conversion from arbitrary formats to MARC::Record. The original to_marc interface is used: pass it the file contents, and it returns a string consisting of a number of MARC blobs separated by \x1D. Consequently, the call of to_marc is removed from routine BatchStageMarcRecords where it did not belong. The to_marc_plugin parameter is removed and two calls are adjusted accordingly. [2] Instead of a separate combo with plugins, the format combo contains MARC, MARCXML and optionally some plugin formats. [3] The code in stage-marc-import.pl now clearly shows the three main format types: MARC, MARCXML or plugin based. Note: This patch restores more or less the situation after bug 12412, but I would actually recommend to have the to_marc plugins return MARC::Record objects instead of large text strings. In the second example I added a to_marc plugin that actually converts MARC record objects to string format, while RecordsFromMarcPlugin reconverts them to MARC::Records. Test plan: See second patch. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart (cherry picked from commit d24568b67256fab79b42ead54302c76d1c9653d7) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: C4/ImportBatch.pm | 53 +++++++++--- .../prog/en/modules/tools/stage-marc-import.tt | 20 +---- misc/stage_file.pl | 2 +- t/Koha/Plugin/MarcFieldValues.pm | 86 ++++++++++++++++++++ t/db_dependent/ImportBatch.t | 43 +++++++++- tools/stage-marc-import.pl | 10 ++- 6 files changed, 179 insertions(+), 35 deletions(-) create mode 100644 t/Koha/Plugin/MarcFieldValues.pm hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Sep 6 15:43:07 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 06 Sep 2017 13:43:07 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.03-24-gbfdaf11 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via bfdaf1136d86194102f247de58069caa5febb539 (commit) from f067450d8011fb0a27a28524bec359ffad4f2278 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bfdaf1136d86194102f247de58069caa5febb539 Author: Baptiste Wojtkowski Date: Mon Jul 10 08:11:33 2017 +0000 Bug 18919: Repair "Transaction branch" in cash_register_stats.pl - values of the option fields are now correctly loaded TEST PLAN: go to domain/cgi-bin/koha/reports/cash_register_stats.pl 1 - Make a report for all branches => it works 2 - Make a report for any branch => you will get the same or no result 3 - apply patch 4 - Repeat 2 => it should work Followed test plan worked as intended Signed-off-by: Alex Buckley Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 7b5457cd0f17173ae9ebca2e71696cc09709a910) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Sep 6 18:35:23 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 06 Sep 2017 16:35:23 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.05.00-540-g0c6538f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 0c6538f033f43cde33d186561a93a197467bd9a1 (commit) via 1417f83e8b8a57e70e9120244a36204cf4acb3c2 (commit) via f7e8391fd3aa38cdd00ce943bd826399685253d7 (commit) via 2671eb2f93340e8fb3c794cff918d86c526cc47f (commit) via 88e82a01218775b8d780769d9fdc8c0054e37180 (commit) via b37ba1be0b8eaf6b778881d3e6e3c9d213757d06 (commit) from ecf6ca5d6e1472bab68f174ab50a20eec6b74888 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0c6538f033f43cde33d186561a93a197467bd9a1 Author: Jonathan Druart Date: Wed Sep 6 13:14:56 2017 -0300 Bug 17834: Make translation easier Signed-off-by: Jonathan Druart commit 1417f83e8b8a57e70e9120244a36204cf4acb3c2 Author: Aleisha Amohia Date: Thu Apr 20 03:12:14 2017 +0000 Bug 17834: Change library news text for single-branch libraries To test: 1) Log into OPAC, go to home page 2) Confirm that the text shows as 'RSS feed for (branchname) library news' if single-branch library 3) Confirm text shows as normal for libraries with more than one branch Sponsored-by: Catalyst IT Signed-off-by: maricris Signed-off-by: anafe Signed-off-by: iflora Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit f7e8391fd3aa38cdd00ce943bd826399685253d7 Author: Aleisha Amohia Date: Thu Aug 31 00:01:59 2017 +0000 Bug 19215: Fixing typo in URL for patron clubs To test: 1) Go to Tools -> Clubs 2) Create a new club template if you do not already have one 3) Edit the template 4) Notice the URL is incorrect and the page is not found 5) Apply patch and go back to Clubs 6) Click edit button 7) Link should work as expected Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 2671eb2f93340e8fb3c794cff918d86c526cc47f Author: Jonathan Druart Date: Mon Sep 4 12:06:56 2017 -0300 Bug 18927: Use fully qualified subroutine names in C4::Items rebuild_zebra.pl fails in some conditions (perl version?) I do not recreate but it has been reported that reindex fails with: error retrieving biblio 94540 at /usr/share/koha/bin/migration_tools/rebuild_zebra.pl line 683, line 751. To fix it we can use fully qualified subroutine names for: GetMarcFromKohaField GetMarcBiblio GetBiblionumberFromItemnumber TransformKohaToMarc GetFrameworkCode Test plan: Confirm the rebuild_zebra script still works correctly after this patch Signed-off-by: Lee Jamison Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 88e82a01218775b8d780769d9fdc8c0054e37180 Author: Jonathan Druart Date: Wed Sep 6 12:52:46 2017 -0300 Bug 11580: Add one more test and clear the cache Make sure we are not just returning J-1 and clear the cache before and after the tests. Signed-off-by: Jonathan Druart commit b37ba1be0b8eaf6b778881d3e6e3c9d213757d06 Author: Alex Arnaud Date: Wed Sep 6 15:36:15 2017 +0000 Bug 11580 - Fix expiry calculation and rewrite tests Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 6 ++-- C4/Items.pm | 30 +++++++++--------- .../intranet-tmpl/prog/en/modules/clubs/clubs.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-main.tt | 14 ++++++++- misc/migration_tools/rebuild_zebra.pl | 8 ++--- t/db_dependent/Circulation/CalcDateDue.t | 32 ++++++++++++++++++-- t/db_dependent/Circulation/dateexpiry.t | 22 +------------- 7 files changed, 68 insertions(+), 46 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 7 20:06:08 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 07 Sep 2017 18:06:08 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.05.00-558-gb56c195 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b56c19528e332381384639ed347d11508086c547 (commit) via ddf494b18f6c422d3654b0a78a63be86f5356065 (commit) via 693cc1122b2b96ef2fc176b07371a4608104eaaf (commit) via 9ffda7a7bc9f627165954b8272f1bb71c1b2beff (commit) via 6ed1513e5fe91772c1720963006bf8f04452416d (commit) via 5f989a81dff29db78620057d70ed864b32486bc0 (commit) via 6a9fafe3090333647244db99ccd39d53e51b781c (commit) via 594c48fb5b2c03f5d638d7115e42820294e32343 (commit) via 24003b84ce637d228a4062dcf29415eb8e4f2162 (commit) via 3c31e6e795cda3ea9b2ae4372d36572fc9e06f61 (commit) via 7aef2f3298b0348c2a3994e344e32e5bc41f1f07 (commit) via f55af2fc078a7d6a05238232bc276e6924307179 (commit) via 1ffba42465faaaa257a3a82555aaeaed0c23ae43 (commit) via 62605145932c452bee8e5b6f49ce1b5a75803bd7 (commit) via 8cb6ed24ffb6f7bfa74b7ea4062070cc5cd0e6d2 (commit) via d60cc56613755a432bb0962b2e808229c8c575c1 (commit) via d53f7607b57d253e7f95bb6c2d699ed3e93c84b1 (commit) via ebd1039bbdb041c7691eaaa2a977af9cd1687d3e (commit) from 0c6538f033f43cde33d186561a93a197467bd9a1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b56c19528e332381384639ed347d11508086c547 Author: Aleisha Amohia Date: Tue Sep 5 22:42:14 2017 +0000 Bug 19258: Prevent warn when reversing a payment The following warn is triggered when I click the Reverse button next to an individual payment on the Account tab: CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_members_boraccount_2epl line 63, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. To test: 1) Go to a members detail page in staff side, create a manual invoice, pay it 2) Go to the Account tab, click Reverse next to the payment you just made 3) Notice warns 4) Apply patch and repeat steps 1 & 2 5) Warns should be gone Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit ddf494b18f6c422d3654b0a78a63be86f5356065 Author: Aleisha Amohia Date: Tue Sep 5 22:38:12 2017 +0000 Bug 19258: Preventing warns when paying a fine or charge from Pay selected button The following warns are triggered when I click the Pay selected button: CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_members_pay_2epl line 267, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_members_pay_2epl line 273, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. To test: 1) Go to a members detail page in staff side and create a manual invoice 2) Go to the pay fines tab, select the fine you just created and click Pay selected 3) Notice warns 4) Apply patch and repeat steps 1 & 2 5) Warns should be gone Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 693cc1122b2b96ef2fc176b07371a4608104eaaf Author: Aleisha Amohia Date: Tue Sep 5 22:34:18 2017 +0000 Bug 19258: Prevent warns when writing off an individual fine The following warns are triggered when I click the Write Off button next to an individual fine or charge: CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_members_pay_2epl line 171, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. (this shows many times) Use of uninitialized value in subroutine entry at /usr/share/perl5/URI/Escape.pm line 184. To test: 1) Go to a members detail page in staff side and create a manual invoice 2) Go to the pay fines tab, click the Write off button next to the invoice you just created 3) Notice warns 4) Apply patch and repeat steps 1 & 2 5) Warns should be gone Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 9ffda7a7bc9f627165954b8272f1bb71c1b2beff Author: Aleisha Amohia Date: Tue Sep 5 22:05:36 2017 +0000 Bug 19258: Prevent warn when paying a fine or charge To test: 1) Go to a members detail page in staff client 2) Select the Fines tab in the left pane 3) Select the Create manual invoice tab below the button menu bar 4) Create a fine and click save (e.g. Type: Fine, Amount: 5.00) 5) Select the Pay fines tab below the button menu bar 6) Click Pay on the item 7) Blank the staff error log 8) click confirm -- staff error log has message 9) apply this first patch 10) repeat steps 3-8 -- staff error log is blank 11) run koha qa test tools Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 6ed1513e5fe91772c1720963006bf8f04452416d Author: Aleisha Amohia Date: Tue Sep 5 21:16:05 2017 +0000 Bug 19257: Prevent warn when reopening a basket To test: 1) Go to Acquisitions, find a vendor and a basket (create if you don't have either) 2) Close the basket 3) View the basket and reopen it 4) Notice the warn 5) Apply the patch and repeat steps 1-3 6) Notice the warn no longer shows and the basket is reopened as expected Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 5f989a81dff29db78620057d70ed864b32486bc0 Author: Marcel de Rooy Date: Mon Jul 10 14:15:09 2017 +0200 Bug 18921: Resolve a few warnings in C4/XSLT.pm Resolves warnings like: Use of uninitialized value in hash element at C4/XSLT.pm line 262. Use of uninitialized value in numeric eq (==) at C4/XSLT.pm line 267. Use of uninitialized value $status in concatenation (.) or string at C4/XSLT.pm line 300. Note: Line numbers are not exactly the same anymore. Test plan: [1] Enable XSLT view in OPAC [2] Without this patch, you will probably have some of these warnings when doing some opac searches. [3] Apply this patch. Check the logs again. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 6a9fafe3090333647244db99ccd39d53e51b781c Author: Jonathan Druart Date: Thu Sep 7 14:15:20 2017 -0300 Bug 19214: prevent crash if club_template_field is called in list context Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 594c48fb5b2c03f5d638d7115e42820294e32343 Author: Aleisha Amohia Date: Wed Aug 30 23:54:56 2017 +0000 Bug 19214: Prevent crash if ->club or ->patron is called in list context To test: 1) Create a club template and a club. 2) Add a user to the club 3) Log in to the OPAC as that user 4) Go to 'your summary' and click the Clubs tab 5) Notice clubs do not load and a warn shows: Template process failed: undef error - Cannot use "->find" in list context at /home/vagrant/kohaclone/Koha/Club/Enrollment.pm line 62. 6) Go to the staff side and go to the member page of that user 7) Go to 'details' and click the Clubs tab 8) Notice clubs do not load and a warn shows: Template process failed: undef error - Cannot use "->find" in list context at /home/vagrant/kohaclone/Koha/Club/Enrollment.pm line 71. 9) Apply patch 1) Repeat steps 4-7, confirming the errors do not show and clubs info loads correctly Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 24003b84ce637d228a4062dcf29415eb8e4f2162 Author: Owen Leonard Date: Mon Jun 12 11:49:37 2017 +0000 Bug 17893 - Move JavaScript to the footer on staff client catalog pages This patch modifies multiple catalog-related pages in order to move embedded JavaScript to the footer. The JavaScript previously embedded in cat-toolbar.inc is moved to a separate file (catalog.js). To test, apply the patch and test JavaScript-driven interactions on all modified pages, including JS which isn't page-specific (menus, help, etc). The functionality of the catalog toolbar should be tested on each page. - Bibliographic detail pages (standard, MARC, labeled MARC, ISBD). - Advanced search page - Local cover image viewer - Item search page - Item detail page - Search history page - Checkout history page https://bugs.koha-community.org/show_bug.cgi?id=17839 Signed-off-by: Lee Jamison Signed-off-by: Jonathan Druart commit 3c31e6e795cda3ea9b2ae4372d36572fc9e06f61 Author: Aleisha Amohia Date: Fri Jan 27 03:37:31 2017 +0000 Bug 12691: Use Koha.Preference in Self-Checkout For calls to SCOUserJS, SCOUserCSS, OPACUserCSS, AllowSelfCheckReturns, OpacFavicon, ShowPatronImageInWebBasedSelfCheck, SelfCheckoutByLogin Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Bug 12691: [FOLLOW-UP] Follow-up patch This patch fixes merge conflicts and fixes the problems in Comment 7 QA tools complain about missing bracket, will be fixed in next followup Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Bug 12691: [FOLLOW-UP] Missing bracket Patch adds bracket to template file (Comment 16) Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Bug 12691: [FOLLOW-UP] Fixing some logic Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Patches have been squashed for readability and 1 removal occurrence of display_patron_image has been reintroduced. Signed-off-by: Jonathan Druart commit 7aef2f3298b0348c2a3994e344e32e5bc41f1f07 Author: Aleisha Amohia Date: Thu Aug 31 21:18:24 2017 +0000 Bug 19228: Trigger confirm delete when removing item from course To test: 1) Enable UseCourseReserves syspref 2) Go to Course Reserves 3) Add a new course if you don't already have one 4) Add an item to the course 5) Click 'remove' to delete the item from the course 6) Notice the item deletes straight away with no confirmation prompt 7) Apply the patch 8) Repeat steps 4 and 5 9) Confirm the confirmation box pops up and works as expected Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit f55af2fc078a7d6a05238232bc276e6924307179 Author: Aleisha Amohia Date: Thu Aug 31 21:25:28 2017 +0000 Bug 19229: Return to course when cancelling out of edit form To test: 1) Ensure UseCourseReserves is enabled 2) Go to Course Reserves, create a course 3) Edit course 4) Click Cancel 5) Notice you are returned to the courses home page rather than returned to the course 6) Apply patch 7) Go to edit course and click cancel again 8) Confirm you are returned to the course and that this feels like the natural expectation. Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 1ffba42465faaaa257a3a82555aaeaed0c23ae43 Author: Marcel de Rooy Date: Thu Sep 7 11:48:09 2017 +0200 Bug 19268: Fix TestBuilder parameter in C/Branch.t and K/P/Messaging.t The values parameter should be called value. See bug 15339. Test plan: Run the adjusted tests. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 62605145932c452bee8e5b6f49ce1b5a75803bd7 Author: Jonathan Druart Date: Thu Sep 7 13:55:01 2017 -0300 Bug 15339: Remove extra 'my' Signed-off-by: Jonathan Druart commit 8cb6ed24ffb6f7bfa74b7ea4062070cc5cd0e6d2 Author: Marcel de Rooy Date: Thu Sep 7 09:24:28 2017 +0200 Bug 15339: [QA Follow-up] Add a warning too when source is not supplied When you do not supply a source and add a few wrong parameters, you would not be warned. Because build simply returns undef. Adding a carp and a test for that situation too. Note: In the earlier subtest 'trivial tests' build was called without source. This now generates a warning. We just catch if there is a warning and test the actual warning itself later on. Test plan: Run t/db_dependent/TestBuilder.t Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit d60cc56613755a432bb0962b2e808229c8c575c1 Author: Jonathan Druart Date: Wed Sep 6 13:41:47 2017 -0300 Bug 15339: Improve parameter validation Only value and source are allowed Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit d53f7607b57d253e7f95bb6c2d699ed3e93c84b1 Author: Martin Persson Date: Wed Dec 9 11:31:12 2015 +0100 Bug 15339: TestBuilder warnings (tests) Makes TestBuilder::build() alert the user when unreognized parameters are passed, which happens when the user supplies the column values directly, forgetting the 'value' hash. This patch contains the tests that doubles as a demonstration of the kind of error the patch is intended to prevent. Sponsored-By: Halland County Library Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit ebd1039bbdb041c7691eaaa2a977af9cd1687d3e Author: Martin Persson Date: Tue Dec 8 20:55:01 2015 +0100 Bug 15339: TestBuilder warnings (code) Makes TestBuilder::build() alert the user when unreognized parameters are passed, which happens when the user supplies the column values directly, forgetting the 'value' hash. This patch holds the code changes. Examples of the kind of errors that it catches are in the tests (separate patch). Sponsored-By: Halland County Library Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: C4/XSLT.pm | 6 +- Koha/Club/Enrollment.pm | 4 +- Koha/Club/Field.pm | 2 +- acqui/basket.pl | 2 +- .../intranet-tmpl/prog/en/includes/cat-toolbar.inc | 129 +---- .../prog/en/includes/catalog-strings.inc | 30 + .../prog/en/modules/catalogue/ISBDdetail.tt | 29 +- .../prog/en/modules/catalogue/MARCdetail.tt | 48 +- .../prog/en/modules/catalogue/advsearch.tt | 52 +- .../prog/en/modules/catalogue/detail.tt | 606 ++++++++++---------- .../prog/en/modules/catalogue/imageviewer.tt | 42 +- .../prog/en/modules/catalogue/issuehistory.tt | 30 +- .../prog/en/modules/catalogue/itemsearch.tt | 476 +++++++-------- .../prog/en/modules/catalogue/labeledMARCdetail.tt | 49 +- .../prog/en/modules/catalogue/moredetail.tt | 22 +- .../prog/en/modules/catalogue/search-history.tt | 218 +++---- .../en/modules/course_reserves/course-details.tt | 10 +- .../prog/en/modules/course_reserves/course.tt | 2 +- koha-tmpl/intranet-tmpl/prog/js/catalog.js | 112 ++++ .../opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 20 +- members/boraccount.pl | 2 +- members/pay.pl | 11 +- members/paycollect.pl | 2 +- opac/sco/sco-main.pl | 15 +- t/db_dependent/Circulation/Branch.t | 8 +- t/db_dependent/Koha/Patron/Messages.t | 2 +- t/db_dependent/TestBuilder.t | 36 +- t/lib/TestBuilder.pm | 9 +- 28 files changed, 1016 insertions(+), 958 deletions(-) create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/catalog-strings.inc create mode 100644 koha-tmpl/intranet-tmpl/prog/js/catalog.js hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 7 20:10:02 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 07 Sep 2017 18:10:02 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.05.00-561-gb465362 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b4653629f63d410326036cef5aa8a70c55d17f45 (commit) via ad9f89c6c32ba8e8fc52566d5e8c7e5b8c9d43e9 (commit) via 3aeb1fc7e85e01cebf7ef726ea1d877b7b0edab6 (commit) from b56c19528e332381384639ed347d11508086c547 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b4653629f63d410326036cef5aa8a70c55d17f45 Author: Tomas Cohen Arazi Date: Wed Sep 6 14:45:00 2017 -0300 Bug 19256: (QA followup) Add missing POD Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit ad9f89c6c32ba8e8fc52566d5e8c7e5b8c9d43e9 Author: Kyle M Hall Date: Wed Sep 6 10:15:55 2017 -0400 Bug 19256: (QA followup) Remove warn from unit test Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 3aeb1fc7e85e01cebf7ef726ea1d877b7b0edab6 Author: Jonathan Druart Date: Tue Sep 5 10:15:59 2017 -0300 Bug 19256: Make Koha::Acq::Order using Koha::Object At the moment we have 2 different modules for acquisition orders: Koha::Tmp::Order[s] and Koha::Acquisition::Order The later has been added before the creation of Koha::Object. Koha::Tmp::Order[s] has been created to make the TT syntax for notices works with acquisition order data. This patch removes the temporary packages Koha::Tmp::Order[s] and adapt the code of Koha::Acquisition::Order[s] to be based on Koha::Object[s]. It also overloads Koha::Object->new to add the trick that was done in Koha::Acquisition::Order->insert. This is needed because acqui/addorder.pl is called from several places and CGI->Vars is used to retrieved order's attributes (and so much more). To avoid regression, the easiest (but not cleanest) way to do is to filter on aqorders column's names. This is *not* a pattern to follow! Test plan: Create basket and add orders from different ways, then continue a whole acquisition process Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: C4/Acquisition.pm | 13 +- C4/Letters.pm | 2 +- Koha/Acquisition/Order.pm | 124 +++++++++++--------- Koha/{Tmp => Acquisition}/Orders.pm | 18 +-- Koha/Tmp/Order.pm | 44 ------- acqui/addorder.pl | 5 +- acqui/addorderiso2709.pl | 6 +- acqui/finishreceive.pl | 5 +- admin/currency.pl | 6 +- t/db_dependent/Acquisition.t | 17 +-- t/db_dependent/Acquisition/CancelReceipt.t | 22 ++-- t/db_dependent/Acquisition/GetBasketAsCSV.t | 6 +- .../Acquisition/GetBasketsInfosByBookseller.t | 10 +- .../Acquisition/GetOrdersByBiblionumber.t | 14 +-- t/db_dependent/Acquisition/Invoices.t | 20 ++-- t/db_dependent/Acquisition/NewOrder.t | 16 +-- t/db_dependent/Acquisition/OrderFromSubscription.t | 8 +- t/db_dependent/Acquisition/OrderUsers.t | 15 ++- t/db_dependent/Acquisition/StandingOrders.t | 29 +++-- t/db_dependent/Acquisition/TransferOrder.t | 8 +- t/db_dependent/Acquisition/close_reopen_basket.t | 12 +- t/db_dependent/Bookseller.t | 18 +-- t/db_dependent/Budgets.t | 12 +- t/db_dependent/Letters.t | 6 +- t/db_dependent/UsageStats.t | 2 +- 25 files changed, 203 insertions(+), 235 deletions(-) rename Koha/{Tmp => Acquisition}/Orders.pm (79%) delete mode 100644 Koha/Tmp/Order.pm hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sun Sep 10 11:06:43 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sun, 10 Sep 2017 09:06:43 +0000 Subject: [koha-commits] main Koha release repository branch 16.11.x updated. v16.11.11-1-15-g293d05d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 16.11.x has been updated via 293d05d0af9817e7d0b31bbb19684494f259714a (commit) via fe0e8e740a044ca2002091aaacbe0843749fe56d (commit) via 396ff22074d681d055539fa8928476fe4228a7be (commit) via 96d5d2995cd56ee41b9f26e621f6903d823323d5 (commit) via 9f06cd63b54d39510b230227bca52530d25fc221 (commit) via 8ef1bf53cfa0c7ee74bd157c39adc68b5e1121c7 (commit) via 4e59f94961cd39d079bcd3664a8e5f7fa479c156 (commit) via 35bbde509361ebccbf5205083b17ed650d41eeb1 (commit) via 98631a3e7617416acbcfdff51451367789307556 (commit) via 333ff8c73d90e59f14e4ee95b3c414f36837c249 (commit) via 61d79bc04b2beecf708a352933b6a69dab414be0 (commit) via 00fa408221776634ecd1066b9e67349ff2d535dd (commit) via 82a8f296827edf58319213640979075b60b79fe3 (commit) via 4fa59dbd8e7cabf92fb7d470d4ec385480f0184a (commit) via 9cefbaf964772848cc338a910d55c558bf579d1a (commit) from b06a26fa83f6af37ee098ac0101deff786beca6e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 293d05d0af9817e7d0b31bbb19684494f259714a Author: Marcel de Rooy Date: Tue Aug 22 16:41:46 2017 +0200 Bug 19163: Critical typo in stage-marc-import process Template says ISO2709 but script wants MARC or MARCXML.. Slipped in with bug 19049. Trivial but critical fix. Test plan: Import a MARC file. Signed-off-by: Tomas Cohen Arazi I picked this fix because I think MARC is always ambiguous. ISO2709 clearly denotes the serialization format used. Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer commit fe0e8e740a044ca2002091aaacbe0843749fe56d Author: Marcel de Rooy Date: Fri Aug 11 08:34:45 2017 +0200 Bug 19049: [QA Follow-up] Mock config, default format As requested by QA: [1] Mock_config enable_plugins in the test. [2] Fallback to MARC when format is empty. Remove die statement. Added: [3] Remove $marc. This variable got obsolete during development. [4] Add test on $input_file and $plugin_class. Test $text before calling Handler or processing $text. No need to split undef if somehow Handler returned undef, etc. If the routine returns an empty arrayref, stage-marc-import will do fine. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit a423fcff42da05e9ebf9f2b4a2f192023346e93e) Signed-off-by: Fridolin Somers (cherry picked from commit f067450d8011fb0a27a28524bec359ffad4f2278) Signed-off-by: Katrin Fischer commit 396ff22074d681d055539fa8928476fe4228a7be Author: Kyle M Hall Date: Thu Aug 10 09:02:37 2017 -0400 Bug 19049 [QA Followup] - Make plugin name first item in description Signed-off-by: Jonathan Druart (cherry picked from commit d8f6315b6d9b1c7145f6036b55b7927f6d6e6e48) Signed-off-by: Fridolin Somers (cherry picked from commit 5699df9deed09edbaa3db1087f3e453c28ac1091) Signed-off-by: Katrin Fischer commit 96d5d2995cd56ee41b9f26e621f6903d823323d5 Author: Marcel de Rooy Date: Thu Aug 10 13:02:23 2017 +0200 Bug 19049: [Follow-up] Make sure that GetPlugins finds the plugin We have to mock_config the pluginsdir before Plugins is loaded, and we should pass an absolute path (not a relative one). If you did not install the test to_marc plugin, this test would fail. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall Verified patch is compatible with original KitchenSink to_marc plugin Signed-off-by: Jonathan Druart (cherry picked from commit 0987b135ea0bb8fbd4fc39643b19715dc6e3a1c8) Signed-off-by: Fridolin Somers (cherry picked from commit 3bbb89c57181c113d64ec7649195de30b52d0806) Signed-off-by: Katrin Fischer commit 9f06cd63b54d39510b230227bca52530d25fc221 Author: Marcel de Rooy Date: Tue Aug 8 14:51:41 2017 +0200 Bug 19049: Testing RecordsFromMarcPlugin with a to_marc plugin This patch adds a simple to_marc plugin in t/Koha/Plugin that is used in the added subtest in ImportBatch.t. Test plan: [1] Run t/db_dependent/ImportBatch.t [2] Copy the to_marc test plugin from t to your plugin directory. Under Debian packages, you should do something like: mkdir -p /var/lib/koha/master/plugins/Koha/Plugin/ cp [yourclone]/t/Koha/Plugin/MarcFieldValues.pm /var/lib/koha/master/plugins/Koha/Plugin/ [3] Check if you see this plugin on plugins/plugins-home.pl [4] Create a text file with some fields like: (Note: The plugin needs an empty line between both "records".) 100,a = Test Author 1 245,a = Title One 100,a = Author 2 245,a = Title Two [5] Go to stage-marc-import.pl. Upload the created file. Select the plugin in the format combo and proceed. Did you create two records ? Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart (cherry picked from commit 83f60adbab8e96f0f14ec547029582623ac3a068) Signed-off-by: Fridolin Somers (cherry picked from commit c6e3f2ac0575849a0b48170506a4986a50ac8bf1) Signed-off-by: Katrin Fischer commit 8ef1bf53cfa0c7ee74bd157c39adc68b5e1121c7 Author: Marcel de Rooy Date: Mon Aug 7 21:24:48 2017 +0200 Bug 19049: Fix regression on stage-marc-import with to_marc plugin Bug 12412 added the use of to_marc plugins allowing arbitrary file formats in stage-marc-import (as long as the plugins can handle them). The feature was not very visible in the code, and when bug 10407 added the marcxml format, it made some changes that broke the use of to_marc. This patch restores the functionality by: [1] Adding a sub RecordsFromMarcPlugin to ImportBatch.pm, specifically addressing the conversion from arbitrary formats to MARC::Record. The original to_marc interface is used: pass it the file contents, and it returns a string consisting of a number of MARC blobs separated by \x1D. Consequently, the call of to_marc is removed from routine BatchStageMarcRecords where it did not belong. The to_marc_plugin parameter is removed and two calls are adjusted accordingly. [2] Instead of a separate combo with plugins, the format combo contains MARC, MARCXML and optionally some plugin formats. [3] The code in stage-marc-import.pl now clearly shows the three main format types: MARC, MARCXML or plugin based. Note: This patch restores more or less the situation after bug 12412, but I would actually recommend to have the to_marc plugins return MARC::Record objects instead of large text strings. In the second example I added a to_marc plugin that actually converts MARC record objects to string format, while RecordsFromMarcPlugin reconverts them to MARC::Records. Test plan: See second patch. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart (cherry picked from commit d24568b67256fab79b42ead54302c76d1c9653d7) Signed-off-by: Fridolin Somers (cherry picked from commit 4dd020a3019cd7e2b357153ec737b15eea95f671) Signed-off-by: Katrin Fischer commit 4e59f94961cd39d079bcd3664a8e5f7fa479c156 Author: Jonathan Druart Date: Mon Aug 7 13:50:32 2017 -0300 Bug 19053: Keep auto_renew flag if a confirmation is needed If an item is checked out with the auto renewal flag and a confirmation is needed (holds exist, past due date, etc.) the auto renewal flag will get lost. Test plan: - Check an item out and specify a past due date - Confirm the checkout on the confirmation screen => Without this patch the checkout is not marked as auto renewal => With this patch applied the auto renewal flag will be set to the checkout Signed-off-by: Josef Moravec Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart (cherry picked from commit 3808dbc1d22b3adc43a09ba7ce00aaca01f95f5a) Signed-off-by: Fridolin Somers (cherry picked from commit 8f3a7d800271cb2611de0cb369e907b16c30fb0b) Signed-off-by: Katrin Fischer commit 35bbde509361ebccbf5205083b17ed650d41eeb1 Author: Tomas Cohen Arazi Date: Mon Aug 7 16:07:40 2017 -0300 Bug 18624: Minor refactoring to ease testing Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit ff41b87302c1b242f9edd7b2e8c253bd18b57ac1) Signed-off-by: Fridolin Somers (cherry picked from commit 4c50a19ab920b488193d78ee18d89bb143ddae4a) Signed-off-by: Katrin Fischer commit 98631a3e7617416acbcfdff51451367789307556 Author: Nick Clemens Date: Fri Jul 7 17:55:50 2017 +0000 Bug 16976 - Unit tests Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 07c0d968b70421852ac4915633fa7f3cbd0d18cd) Signed-off-by: Fridolin Somers (cherry picked from commit a0bc776e67569b83dc3d5bc47069ceb1408badb2) Signed-off-by: Katrin Fischer commit 333ff8c73d90e59f14e4ee95b3c414f36837c249 Author: Nick Clemens Date: Fri Jun 16 06:36:22 2017 -0400 Bug 16976 - Authorities searches with double quotes gives ZOOM error 20003 [Alternate] I dug into this a little bit, it seems the issue is that we were double processing the query because of an extra call to C4::AuthoritiesMarc::SearchAuthorities I think we can simply remove this call To test: 1 - Perform an authority search for a value that returns results 2 - Wrap it in quotes and search 3 - 'Internal server error' 4 - Apply patch 5 - Search with quotes succeeds https://bugs.koha-community.org/show_bug.cgi?id=16796 Signed-off-by: Lee Jamison Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit 9c8a04acb05466356fec8e9d6d13183295719c7d) Signed-off-by: Fridolin Somers (cherry picked from commit 39a2f6421e3d0b2c415ad9abc655193357e24328) Signed-off-by: Katrin Fischer commit 61d79bc04b2beecf708a352933b6a69dab414be0 Author: Jonathan Druart Date: Mon Aug 14 10:26:48 2017 -0300 Bug 18331: POST_CHOMP everywhere! Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit 3c6168d37436b7312e130f796d47271ff2de77cf) Signed-off-by: Fridolin Somers (cherry picked from commit 4c86b575b2ef09cceefa9a2718053e45a71c2b25) Signed-off-by: Katrin Fischer commit 00fa408221776634ecd1066b9e67349ff2d535dd Author: Josef Moravec Date: Tue Aug 8 08:23:57 2017 +0000 Bug 18331: Followup - fix path to orders_by_budget csv header Signed-off-by: Josef Moravec Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit 14484ba4234fd1cbb925b5f3a4844da863c65d5a) Signed-off-by: Fridolin Somers (cherry picked from commit c6a3c7c39babf64ad916650277ab752e54072916) Signed-off-by: Katrin Fischer commit 82a8f296827edf58319213640979075b60b79fe3 Author: Lee Jamison Date: Fri Aug 4 19:27:22 2017 +0000 Bug 18331: Followup - Fix CSV export (once and for all!) Follow-up on Comment 21 to correct the empty_line.inc include in basket.tt https://bugs.koha-community.org/show_bug.cgi?id=18331 Signed-off-by: Lee Jamison Signed-off-by: Josef Moravec Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit 2ee4e0ac381ed23fa23b1117725b2f6a0e0db4de) Signed-off-by: Fridolin Somers (cherry picked from commit ad4c173bca27de2b05a1c47a3977212f72654c40) Signed-off-by: Katrin Fischer commit 4fa59dbd8e7cabf92fb7d470d4ec385480f0184a Author: Marc V?ron Date: Thu Aug 3 17:50:30 2017 +0200 Bug 18331: Force tt to insert newline to empty_line.inc See end of comment #4 and IRC: http://irc.koha-community.org/koha/2017-08-03#i_1958062 Signed-off-by: Lee Jamison Signed-off-by: Josef Moravec Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit a10e5383016a5cb4117719ac858cbe02a53e457b) Signed-off-by: Fridolin Somers (cherry picked from commit c4e608d29954195f01ea170ff06d7e8da4814707) Signed-off-by: Katrin Fischer commit 9cefbaf964772848cc338a910d55c558bf579d1a Author: Jonathan Druart Date: Mon Jun 12 17:04:47 2017 -0300 Bug 18331: Fix CSV export (once and for all!) I am going to try and explain the problem here in order to make it a have-to-read for next changes. There are several things to test when and most of the time we break something when we try to fix something else. You have to test different CSV export, not only one. There are not all processed the same way. For instance acqui/csv/basket.tt does not contain any strings to translate and the translate script will copy the original file as it. But reports/csv/orders_by_budget.tt will not! Indeed it contains "TOTAL" which will be translated. The generated tt file for the translated language will remove all the carriage returns! That's why we cannot rely on TT for newlines (contrary to bug 16914 assumption). There are two possible methods: 1/ Fix the translate script => Hum... nope 2/ Remove all carriage returns and make them explicit by including an file that only contains 1 carriage return This second method is implemented in this patch. How it works: Use the PRE_CHOMP "[%-" and POST_CHOMP "-%]" (http://www.template-toolkit.org/docs/manual/Config.html#section_PRE_CHOMP_POST_CHOMP) to remove all the newlines that could be added by TT in the original (en) files. Then include the new_line.inc to add a new line. That way original and translated files will behave the same way. The BLOCK in the csv_headers avoid to have the newlines added, in any cases. For instance: by default we will have an empty line at the end of the headers, but the translated headers will not have it. Test plan: At least 2 signoffs will be needed, please test carefully! You will need to generate CSV with at least 2 entries! Test with the non-translated interface (en) and with the language you want. To test with a translated language you will *have to*: - cd misc/translator - perl translate update LANG - manually edit the po file, remove the fuzzy tags, correctly translate the string (do not forget the additional %s in the headers) - perl translate install LANG 1/ Export basket and basketgroup as CSV 2/ Export late orders as CSV 3/ Export items (from the item search) as CSV 4/ Export the 2 reports "Orders by fund" and "Cash register" as CSV Signed-off-by: Lee Jamison Signed-off-by: Josef Moravec Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit 8403799c7212349bee70090249e3425afd62423b) Signed-off-by: Fridolin Somers (cherry picked from commit 5b1c9cd3f27d377ddee5635f32fd1a3e2626409c) Signed-off-by: Katrin Fischer ----------------------------------------------------------------------- Summary of changes: C4/ImportBatch.pm | 53 +++++++++--- Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 27 +++--- Koha/SearchEngine/Zebra/QueryBuilder.pm | 1 - circ/circulation.pl | 1 + .../prog/en/includes/csv_headers/acqui/basket.tt | 2 +- .../en/includes/csv_headers/acqui/basketgroup.tt | 2 +- .../en/includes/csv_headers/acqui/lateorders.tt | 2 +- .../includes/csv_headers/catalogue/itemsearch.tt | 2 +- .../csv_headers/reports/cash_register_stats.tt | 2 +- .../csv_headers/reports/orders_by_budget.tt | 2 +- .../intranet-tmpl/prog/en/includes/empty_line.inc | 1 + .../prog/en/modules/acqui/csv/basket.tt | 9 +- .../prog/en/modules/acqui/csv/basketgroup.tt | 10 ++- .../prog/en/modules/acqui/csv/lateorders.tt | 10 ++- .../prog/en/modules/catalogue/itemsearch_csv.tt | 8 +- .../prog/en/modules/circ/circulation.tt | 1 + .../en/modules/reports/csv/cash_register_stats.tt | 16 ++-- .../en/modules/reports/csv/orders_by_budget.tt | 14 ++-- .../prog/en/modules/tools/stage-marc-import.tt | 20 +---- misc/stage_file.pl | 2 +- t/Koha/Plugin/MarcFieldValues.pm | 86 ++++++++++++++++++++ t/Search/Zebra/QueryBuilder.t | 38 +++++++++ t/db_dependent/ImportBatch.t | 43 +++++++++- tools/stage-marc-import.pl | 8 +- 24 files changed, 279 insertions(+), 81 deletions(-) create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/empty_line.inc create mode 100644 t/Koha/Plugin/MarcFieldValues.pm create mode 100644 t/Search/Zebra/QueryBuilder.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sun Sep 10 11:24:29 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sun, 10 Sep 2017 09:24:29 +0000 Subject: [koha-commits] main Koha release repository branch 16.11.x updated. v16.11.11-1-17-gd2b84a8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 16.11.x has been updated via d2b84a87fbeae550a9dbc9800202813daf1affd8 (commit) via e2b85aa9b96410dab6ecf5c1736e295c9cc07894 (commit) from 293d05d0af9817e7d0b31bbb19684494f259714a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d2b84a87fbeae550a9dbc9800202813daf1affd8 Author: Julian Maurice Date: Wed Jun 7 11:29:46 2017 +0200 Bug 18741: Fix loading of SQL files in web installer Test plan: 1. Start a normal install using the web installer 2. When asked to select data to load, verify that 'message_transport_types' is checked, and check some optional data files 3. Continue the install to the end 4. Verify that message_transport_types is not empty, and that the optional data you checked is there Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit e2b85aa9b96410dab6ecf5c1736e295c9cc07894 Author: Fridolin Somers Date: Fri May 5 15:00:05 2017 +0200 Bug 18551 - Hide with CSS dynamic elements in member search In member search page, the result table is in Ajax so fully managed by Javascript. There is also a yellow dialog message prepared in HTML. Thoses elements are hidden by JS code : ie $("#patron_list_dialog").hide(). The problem is that the static page is first loaded an displayed then the JS code runs an hides the elements. On a low performance computer, this action is visible and looks like there is a blinking yellow message. I propose to hide with CSS so that thoses elements are not displayed in static page and are there shown in dynamic JS code. Test plan : Check display is unchanged : - Go to home page /cgi-bin/koha/members/members-home.pl - Perform patron search from header search box - Perform patron search by clicking on a letter - Perform patron search from filters (left of results table) - Select a patron and add it to a list => you see the yellow message Yellow message does no longer appear with this patch. Signed-off-by: Marc V?ron Signed-off-by: Philippe Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 5cc536c68b221823f4335b5b5db1108521f88a71) Signed-off-by: Katrin Fischer ----------------------------------------------------------------------- Summary of changes: installer/install.pl | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 12 14:47:22 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 12 Sep 2017 12:47:22 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.03-25-g1c82876 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via 1c8287632ea36e6d2a8ade922fe129f5f792d6d3 (commit) from bfdaf1136d86194102f247de58069caa5febb539 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1c8287632ea36e6d2a8ade922fe129f5f792d6d3 Author: Marcel de Rooy Date: Mon Jul 10 14:15:09 2017 +0200 Bug 18921: Resolve a few warnings in C4/XSLT.pm Resolves warnings like: Use of uninitialized value in hash element at C4/XSLT.pm line 262. Use of uninitialized value in numeric eq (==) at C4/XSLT.pm line 267. Use of uninitialized value $status in concatenation (.) or string at C4/XSLT.pm line 300. Note: Line numbers are not exactly the same anymore. Test plan: [1] Enable XSLT view in OPAC [2] Without this patch, you will probably have some of these warnings when doing some opac searches. [3] Apply this patch. Check the logs again. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart (cherry picked from commit 5f989a81dff29db78620057d70ed864b32486bc0) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: C4/XSLT.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 12 14:53:54 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 12 Sep 2017 12:53:54 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.03-26-g0f9175c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via 0f9175c0b26e9e8d65bf39dab80d99e5d7455346 (commit) from 1c8287632ea36e6d2a8ade922fe129f5f792d6d3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0f9175c0b26e9e8d65bf39dab80d99e5d7455346 Author: Marc V?ron Date: Fri Aug 4 10:52:13 2017 +0200 Bug 18649: Translatability: Get rid of tt directive in translation for admin/categories.tt and onboardingstep2.tt New patch without trailing IF construction in tt directives as requested in comment #28 To test: Verify that translation tool no longer shows tt directives as described in comment #1 New patch, needs SO. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit 79338bde3e01708fe331a54745f45c620c121805) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt | 6 +++++- .../intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 12 14:56:16 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 12 Sep 2017 12:56:16 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.03-27-g4d42774 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via 4d427740196bb0a9bcfe80787af8cdf769c06b76 (commit) from 0f9175c0b26e9e8d65bf39dab80d99e5d7455346 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4d427740196bb0a9bcfe80787af8cdf769c06b76 Author: Marc V?ron Date: Mon May 22 21:09:06 2017 +0200 Bug 18652: Get rid of tt directive in translation for uncertainprice.tt Translation tool shows toe following for ncertainprice.tt 0; url=[% scriptname %]?booksellerid=[% booksellerid %] This patch fixes it. To test: - Apply patch - Verify that code change makes sense - Verify that Home > Acquisitions > [vendor] > Uncertain prices for [vendor] works as before - Additional test (for a langunage 'aa-AA') perl translate create aa-AA verify that line 41 no longer appears in aa-AA-staff-prog.po Amended to switch from BLOCK to a template variable, see comment #5 Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart (cherry picked from commit 2ee82801c7a8686523f9c5e95b0f43d44e52e4ab) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 12 15:14:34 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 12 Sep 2017 13:14:34 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.03-28-g036b317 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via 036b317c0c0e96b0eb344d767cca7f87da4fb875 (commit) from 4d427740196bb0a9bcfe80787af8cdf769c06b76 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 036b317c0c0e96b0eb344d767cca7f87da4fb875 Author: Marc V?ron Date: Tue May 23 17:09:49 2017 +0200 Bug 18660: Translatability: Get rid of template directives [%% in translation for patroncards-errors.inc Translation for koha-tmpl/intranet-tmpl/prog/en/includes/patroncards-errors.inc contains a lot of (partial) template directives like: %%]%s %sLayout: [%% This patch fixes it To test: - Verify that code changes make sense - Apply patch - Create a translation (cd misc/translator , then: perl translate create aa-AA - Verify that in po/aa-AA-staff-prog.po contains no fragments like %%] or [%% for patroncards-errors.inc - Try to get an error: Try a link like http://[YOUR SERVER]/cgi-bin/koha/patroncards/create-pdf.pl?batch_id=1&template_id=999&layout_id=999&start_card=1 ...where template_id and layout_id do not exist (Amended for comment #2 2017-06-05 mv) (Amended for comment #6 2017-08-02 mv) Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart (cherry picked from commit 7e39bbc61aedd6383f4d6a1b4728711c6922e877) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: .../prog/en/includes/patroncards-errors.inc | 58 ++++++++++++-------- 1 file changed, 34 insertions(+), 24 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 12 15:18:33 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 12 Sep 2017 13:18:33 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.03-29-gb9ff28f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via b9ff28f719cb17d37e5eaecc4fb09b9032cc38e5 (commit) from 036b317c0c0e96b0eb344d767cca7f87da4fb875 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b9ff28f719cb17d37e5eaecc4fb09b9032cc38e5 Author: Marc V?ron Date: Mon Jun 12 07:48:57 2017 +0200 Bug 18778 - Translatability: Get rid of tt directive in translation for item-status.inc The file opac-tmpl/bootstrap/en/includes/item-status.inc exposes a template directive where translators should not be confronted with. "%s %s [%%#- This include takes two parameters: an item structure and an " "optional loan (issue) structure. The issue structure is used by course " "reserves pages, which do not use an API to fetch items that populates item." "datedue. -%%] %s %s %s %s " This patch fixes new lines inside a tt directive (comment). It is merely a string patch. To test: Verify that the code changes make sense. (Bonus test: create a new language 'aa-AA', verify that line above does not show up in aa-AA-opac-bootstrap.po) NOTE: Followed test plan similar to bug 18776 comment 3. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart (cherry picked from commit c8551645d5bdd3e6fb5b7e03280521a2fbaef636) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 12 15:21:25 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 12 Sep 2017 13:21:25 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.03-30-gafb2cb0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via afb2cb0c74b6a137652ec1a2e96fc480a5a50f96 (commit) from b9ff28f719cb17d37e5eaecc4fb09b9032cc38e5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit afb2cb0c74b6a137652ec1a2e96fc480a5a50f96 Author: Serhij Dubyk {?????? ?????} Date: Tue Aug 22 17:19:32 2017 +0300 Bug 17827 - Untranslatable "by" in MARC21slim2intranetResults.xsl Signed-off-by: Serhij Dubyk {?????? ?????} The "by" after the title was not translatable in the result lists of the intranet. This patch fixes it by removing a comment, that caused a problem with the translation scripts. To test: Test: Before this patch in file en-GB-marc-MARC21.po present next paragraph: msgid "by " msgstr " by " According string "by " in the file MARC21slim2intranetResults.xsl can not be translated (in other languages). After applying this patch performed next command: cd /usr/share/koha/misc/translator sudo env KOHA_CONF=/etc/koha/sites/mykohainstance/koha-conf.xml PERL5LIB=/usr/share/koha/lib perl -I /usr/share/koha/lib "./translate" update Now in the file en-GB-marc-MARC21.po present the following (modified) paragraph: msgid "by " msgstr " by " https://bugs.koha-community.org/show_bug.cgi?id=17827 Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit d5ea914f4dc41f78dbb3a59f894f6ecbb9a1afa4) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 12 15:56:04 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 12 Sep 2017 13:56:04 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.03-31-g4b71c92 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via 4b71c9239708cd4d60190ed907fec03d1f8b08bc (commit) from afb2cb0c74b6a137652ec1a2e96fc480a5a50f96 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4b71c9239708cd4d60190ed907fec03d1f8b08bc Author: David Cook Date: Thu Jul 27 11:58:28 2017 +1000 Bug 18898 - Some permissions for Reports can be bypassed If you manually visit the following links when you only have permission to run reports, you'll still be able to access the ability to create and edit reports: /cgi-bin/koha/reports/guided_reports.pl?phase=Create%20report%20from%20SQL /cgi-bin/koha/reports/guided_reports.pl?phase=Edit%20SQL This patch ties these 2 unaccounted for phases to the create_reports permission. With patch, issue no longer can be reproduced. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 2fdfbaf0ddbf214c0efb9a3a3c2595a54517f795) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: reports/guided_reports.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 12 16:04:43 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 12 Sep 2017 14:04:43 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.03-32-gd179da5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via d179da572b1d6bd7066d96f494aa805b86b92ae1 (commit) from 4b71c9239708cd4d60190ed907fec03d1f8b08bc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d179da572b1d6bd7066d96f494aa805b86b92ae1 Author: Jonathan Druart Date: Thu Jul 6 18:10:10 2017 -0300 Bug 18906: Display all funds the logged in user can use There are complex conditions to know if a librarian can use a fund, we cannot do that with a SQL query, we need to use C4::Budgets::CanUserUseBudget When this patch is applied then all funds are visible to both superlibrarian patrons and patrons with all acq permissions Signed-off-by: Alex Buckley Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 19a7b498e1f4355ab1e4ee0adb5db299613f3f5c) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: admin/aqbudgets.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 12 16:06:59 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 12 Sep 2017 14:06:59 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.03-35-g92b08a2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via 92b08a23e3b2c001d208b82b6ffee2af756ca51f (commit) via 1865db52bbf9413574c22ee2c9180137ac357918 (commit) via aca614cd95b32d2953927e8e3e908bc1248b541c (commit) from d179da572b1d6bd7066d96f494aa805b86b92ae1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 92b08a23e3b2c001d208b82b6ffee2af756ca51f Author: Fridolin Somers Date: Thu Jul 6 08:48:18 2017 +0200 Bug 18900: wrong number format in receiving order Bug 18471 added number formating in order receive. I found a bug generated by this. Koha::Number::Price defines methods to (un)format price depending on CurrencyFormat syspref. The bug is that for CurrencyFormat US, some params are not defined in this module so there are retrieved from system locale. If system locale is not en_US, the params will be wrong. For example fr_FR will define ',' as decimal and so saved unit price is divided by 1000. To recreate: - On a server with locale 'fr_FR' - With Plack mode - Set CurrencyFormat on 'US' - Open a basket - Place an order for an item - Close basket - Receive order with changing 'Actual Cost' to '1,234' - Note the 'Actual Cost' is now '1.23' - Run unit test t/Number/Price.t without and with patch Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart (cherry picked from commit e35903574ce666bca32eb4676f311b99bb268ec2) Signed-off-by: Fridolin Somers commit 1865db52bbf9413574c22ee2c9180137ac357918 Author: Tomas Cohen Arazi Date: Wed Aug 9 12:01:17 2017 -0300 Bug 18900: (QA followup) Make tests conditional to locale existence It is important to highlight that tests have been skipped instead of having them pass on the absence of the required fr_FR.UTF-8 locale installed on the system. This patch does that check and effectively skips them. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart (cherry picked from commit 61f2ec769073709be3b688654ec355b3f4fbe522) Signed-off-by: Fridolin Somers commit aca614cd95b32d2953927e8e3e908bc1248b541c Author: Fridolin Somers Date: Thu Jul 6 08:44:51 2017 +0200 Bug 18900: add UT to Number/Price.t This patch adds unit tests to t/Number/Price.t in order to valid the problem. Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart (cherry picked from commit 91dee226cdd089353dc71e559aa9e0b34fddf72e) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: Koha/Number/Price.pm | 3 +++ t/Number/Price.t | 22 +++++++++++++++++++++- 2 files changed, 24 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 12 16:08:53 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 12 Sep 2017 14:08:53 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.03-37-g906d602 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via 906d602c1f5150edcb933846ec28a8c03f425fe1 (commit) via 2c90bd3dd184a46060dc9b7ee185dc91521ec1d1 (commit) from 92b08a23e3b2c001d208b82b6ffee2af756ca51f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 906d602c1f5150edcb933846ec28a8c03f425fe1 Author: Jonathan Druart Date: Wed Aug 9 12:59:20 2017 -0300 Bug 19067: Test Makefile.PL mapping Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart (cherry picked from commit 19eb17c7894c4d2d53ecfc1ad4e417aa86ab9410) Signed-off-by: Fridolin Somers commit 2c90bd3dd184a46060dc9b7ee185dc91521ec1d1 Author: Tomas Cohen Arazi Date: Wed Aug 9 12:27:00 2017 -0300 Bug 19067: Map clubs/ into INTRANET_CGI_DIR in Makefile.PL This patch adds the required entry in Makefile.PL so the clubs/ dir is correctly installed during the make install step. To test: - Run: $ cd kohaclone $ perl Makefile.PL - Follow any install method and options - Run $ make $ ls blib/INTRANET_CGI_DIR/ | grep clubs => FAIL: No clubs dir - Run: $ make clean - Apply this patch - Run: $ perl Makefile.PL - Follow any install method and options - Run $ make $ ls blib/INTRANET_CGI_DIR/ | grep clubs => SUCCESS: The clubs/ dir is correctly picked for inclussion in the intranet cgi dir - Sign off :-D Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart (cherry picked from commit e57b3a6c4d9bb6319f038909832281dd4a9e39e5) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: Makefile.PL | 1 + t/{Breeding.t => Makefile.t} | 30 ++++++++++++++++++++++++------ 2 files changed, 25 insertions(+), 6 deletions(-) copy t/{Breeding.t => Makefile.t} (54%) mode change 100755 => 100644 hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 12 16:15:37 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 12 Sep 2017 14:15:37 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.03-38-gc37b2f3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via c37b2f31d512fe200da7410199d311171306b8b0 (commit) from 906d602c1f5150edcb933846ec28a8c03f425fe1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c37b2f31d512fe200da7410199d311171306b8b0 Author: Marcel de Rooy Date: Tue Aug 22 16:41:46 2017 +0200 Bug 19163: Critical typo in stage-marc-import process Template says ISO2709 but script wants MARC or MARCXML.. Slipped in with bug 19049. Trivial but critical fix. Test plan: Import a MARC file. Signed-off-by: Tomas Cohen Arazi I picked this fix because I think MARC is always ambiguous. ISO2709 clearly denotes the serialization format used. Signed-off-by: Liz Rea Signed-off-by: Jonathan Druart (cherry picked from commit af791d83e435587494fa04a45375f48a3e2ad236) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: tools/stage-marc-import.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 12 16:18:03 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 12 Sep 2017 14:18:03 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.03-39-gc87b963 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via c87b963818076a58661922116893ff052b2d76a9 (commit) from c37b2f31d512fe200da7410199d311171306b8b0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c87b963818076a58661922116893ff052b2d76a9 Author: Chris Cormack Date: Wed Aug 2 10:15:10 2017 +1200 Bug 18046: CAS logout infinite redirect To test (You need a CAS server and CAS configured in Koha) 1/ Login using CAS in Koha 2/ Logout in Koha 3/ Notice you get redirected again and again 4/ Apply patch 5/ Login with CAS, then logout 6/ Notice logout works, but no longer infinitely redirected Signed-off-by: Katrin Fischer Patch has been in production use for several months on several instances. Fixes a critical bug. Signed-off-by: Marcel de Rooy Looks like a typical workaround, but evidently works. Not tested with CAS. Signed-off-by: Jonathan Druart (cherry picked from commit 13ca4962068b184f803b6588e53e39209a77f2b6) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: C4/Auth_with_cas.pm | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 12 16:26:57 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 12 Sep 2017 14:26:57 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.03-40-gf8a6f62 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via f8a6f62d45b556251820f18f45bc4a3661af142e (commit) from c87b963818076a58661922116893ff052b2d76a9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f8a6f62d45b556251820f18f45bc4a3661af142e Author: Kyle M Hall Date: Wed Aug 30 09:37:48 2017 -0400 Bug 19205 - Pay selected fine generates 500 error Using the pay selected option from the borrowers account, to pay for one specific fine among other gives a 500 error, despite the payment going through. Test Plan: 1) Add two fines using the Create manual invoice function. 2) Select one fine and "pay selected". 3) Pay a part of the amount. 4) Note error 5) Apply this patch 6) Repeat steps 1-3 7) No error! Signed-off-by: Andreas Hedstr?m Mace Signed-off-by: Jonathan Druart (cherry picked from commit 86e8612c020cea44be123be45f2e503af38ef98b) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: members/paycollect.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 12 16:40:25 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 12 Sep 2017 14:40:25 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.03-41-g6431bf5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via 6431bf5d9a20737bcd6a8c4ac4426c5ba1bffd80 (commit) from f8a6f62d45b556251820f18f45bc4a3661af142e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6431bf5d9a20737bcd6a8c4ac4426c5ba1bffd80 Author: Aleisha Amohia Date: Tue Aug 29 04:51:40 2017 +0000 Bug 19194: Check itemtype is defined when receiving an order To test: 1) Find a record with an item that has no itemtype (or remove the itemtype of an item) 2) Go to Acquisitions -> Find a vendor or make a new one -> create a new basket 3) Add the record from Step 1 to your basket 4) Close the basket 5) Go back to the vendor and click 'Receive shipments' 6) Put in an invoice number, click Next 7) Click the Receive link for your item 8) Confirm you see an internal server error 9) Apply the patch and refresh the page 10) The error should be gone and behaviour should continue as expected Sponsored-by: Catalyst IT Signed-off-by: Lee Jamison Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit 51a65731c0fa15c37351ce6bc478fa6dc63fc64f) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: acqui/orderreceive.pl | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 12 16:44:03 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 12 Sep 2017 14:44:03 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.03-42-gdcda5a4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via dcda5a4dc52eebe621ccfd491eddbb162c476ebb (commit) from 6431bf5d9a20737bcd6a8c4ac4426c5ba1bffd80 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit dcda5a4dc52eebe621ccfd491eddbb162c476ebb Author: Kyle M Hall Date: Wed Aug 30 10:35:03 2017 -0400 Bug 19208 - Pay select option doesn't pay the selected fine The "Pay selected" option on the Fines tab in the borrower account page doesn't work as intended. The fine on top of the list gets the amount deducted, even if another fine is choosen from the list. Test Plan: 1) Create two or three fines, using the Create manual invoice function. 2) Choose one of the fines (not the one on the top) and click Pay selected 3) Pay a partial amount 4) Go back to the Pay fines tab an notice that the fine you selected has not changed. Instead, either the top fine or the total (see attachment) has ben affected. 5) Apply this patch 6) Repeat steps 1-3 7) Note the correct fine is paid Signed-off-by: Andreas Hedstr?m Mace Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart (cherry picked from commit 831d75d09c276f25f919cbdc16c8e4105fe8ddc9) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt | 2 -- members/paycollect.pl | 5 +---- 2 files changed, 1 insertion(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 12 16:46:30 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 12 Sep 2017 14:46:30 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.03-43-g111ab4e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via 111ab4e63257410bf7ca34e80e46675603072c36 (commit) from dcda5a4dc52eebe621ccfd491eddbb162c476ebb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 111ab4e63257410bf7ca34e80e46675603072c36 Author: Alex Sassmannshausen Date: Thu Aug 10 13:00:19 2017 +0200 Bug 19073: (bug 15758 follow-up) Dereference correct value from Koha::Object. * tools/modborrowers.pl: Dereference 'branchcode' rather than 'value'. Test Plan: - Carry out "Batch patron modification" with any number of patrons. + Change the library. + Hit Save. - The library will not have been updated. - Apply patch. - Run same modification. - The library will have been updated Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart (cherry picked from commit 8a328a20bf3a74268346104281688b2a81be80e6) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: tools/modborrowers.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 12 16:58:22 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 12 Sep 2017 14:58:22 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.03-44-g1a50b44 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via 1a50b447d3d58b40d8f84e7c264f01abcb42a826 (commit) from 111ab4e63257410bf7ca34e80e46675603072c36 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1a50b447d3d58b40d8f84e7c264f01abcb42a826 Author: Jonathan Druart Date: Mon Sep 4 12:06:56 2017 -0300 Bug 18927: Use fully qualified subroutine names in C4::Items rebuild_zebra.pl fails in some conditions (perl version?) I do not recreate but it has been reported that reindex fails with: error retrieving biblio 94540 at /usr/share/koha/bin/migration_tools/rebuild_zebra.pl line 683, line 751. To fix it we can use fully qualified subroutine names for: GetMarcFromKohaField GetMarcBiblio GetBiblionumberFromItemnumber TransformKohaToMarc GetFrameworkCode Test plan: Confirm the rebuild_zebra script still works correctly after this patch Signed-off-by: Lee Jamison Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit 2671eb2f93340e8fb3c794cff918d86c526cc47f) ----------------------------------------------------------------------- Summary of changes: C4/Items.pm | 30 +++++++++++++++--------------- misc/migration_tools/rebuild_zebra.pl | 8 ++++---- 2 files changed, 19 insertions(+), 19 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 12 17:01:12 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 12 Sep 2017 15:01:12 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.03-46-g9600158 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via 960015819e0c19ef85c458d0bdaec8a24cd86dc3 (commit) via 68bbe3fb0d8238bf651d335d5a8dbaf72156f3ee (commit) from 1a50b447d3d58b40d8f84e7c264f01abcb42a826 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 960015819e0c19ef85c458d0bdaec8a24cd86dc3 Author: Jonathan Druart Date: Thu Sep 7 14:15:20 2017 -0300 Bug 19214: prevent crash if club_template_field is called in list context Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart (cherry picked from commit 6a9fafe3090333647244db99ccd39d53e51b781c) Signed-off-by: Fridolin Somers commit 68bbe3fb0d8238bf651d335d5a8dbaf72156f3ee Author: Aleisha Amohia Date: Wed Aug 30 23:54:56 2017 +0000 Bug 19214: Prevent crash if ->club or ->patron is called in list context To test: 1) Create a club template and a club. 2) Add a user to the club 3) Log in to the OPAC as that user 4) Go to 'your summary' and click the Clubs tab 5) Notice clubs do not load and a warn shows: Template process failed: undef error - Cannot use "->find" in list context at /home/vagrant/kohaclone/Koha/Club/Enrollment.pm line 62. 6) Go to the staff side and go to the member page of that user 7) Go to 'details' and click the Clubs tab 8) Notice clubs do not load and a warn shows: Template process failed: undef error - Cannot use "->find" in list context at /home/vagrant/kohaclone/Koha/Club/Enrollment.pm line 71. 9) Apply patch 1) Repeat steps 4-7, confirming the errors do not show and clubs info loads correctly Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart (cherry picked from commit 594c48fb5b2c03f5d638d7115e42820294e32343) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: Koha/Club/Enrollment.pm | 4 ++-- Koha/Club/Field.pm | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 12 17:13:10 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 12 Sep 2017 15:13:10 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.05.00-586-g5400795 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 5400795a6651adc021801052fa0186747983b587 (commit) via 6eebfe5fe02be3c2ab3285b58cf50fac980cb302 (commit) via 4efe251f353cb9eddd302b6214e1f4392620b395 (commit) via 3d07449358010392b111a674c3606cdfe2cbe47e (commit) via d0c372c5fa0e867d346b342ae470b31c33d52b26 (commit) via 87773a6d661f122a52b34f6c67255424c335e297 (commit) via 434162c1756b16b5fc715fd1cb762aaf8aff7b2b (commit) via db35492c795540d6c3b10f7cba18698aeb84a816 (commit) via 3e631f418a3fafa485b650f0975ee0d06e366884 (commit) via dc60c344768540c5e02c8e46e8ae43f7921d252a (commit) via 562435e767c99670dd9fb8935a2ed483b7a61930 (commit) via ac653bc7cec4e2ca1f8653efff4a9c44f4255540 (commit) via f45fc4d10b84dfbd8040d12484553db8c87ec45a (commit) via 15dee475180ac362e182e1708d1c8b1b1e25e635 (commit) via ca8f8b4cd91fac4acb6e2338720b8e0a82bce0b0 (commit) via 7e222bb0796196f1e466b73d909fd28d529cab75 (commit) via 35e3de845c591958d66c6602940453f2a803a7ee (commit) via f8502b0d197bab4b4966e9e02253d30f7fcf29f8 (commit) via 99e691feee5ef29bbc9d24a916fc4aa2fab6bba6 (commit) via 6ae69d27815dc01ab515b6d8f0239ef5fe59251c (commit) via 5a64723e6d3d21b3e0d9302b273b6fbb43c969af (commit) via 0ed469525fe16e36663c1f5266568beb5e27672d (commit) via 133e25c56ac79e0b88b89e3b749df338e63a93d0 (commit) via 4d223bdc6156fab0667867f3990854fddfab5684 (commit) via 889fabe9f28f3b6ef35fc36e73b12652f258510c (commit) from b4653629f63d410326036cef5aa8a70c55d17f45 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5400795a6651adc021801052fa0186747983b587 Author: Dominic Pichette Date: Tue Sep 12 10:13:58 2017 -0400 Bug 18584 - removed white space in C4/Accounts.pm Test Plan: 1-go to C4/Accounts.pm 2-there should not be a trailing space at line 279. Signed-off-by: Dominic Pichette Signed-off-by: Jonathan Druart commit 6eebfe5fe02be3c2ab3285b58cf50fac980cb302 Author: Jon Knight Date: Mon Aug 21 15:04:20 2017 +0000 Bug 19068: Add quantity field to the opac suggestions form This enhancement just exposes the quantity field to the OPAC suggestions form to permit the end user to enter this if they wish. The librarians can of course override this quantity when they process the suggestion. Test Plan (assuming using kohadevbox VM): 1) apply patch and turn on purchase suggestions 2) Go to http://localhost:8080/cgi-bin/koha/opac-suggestions.pl?op=add and notice that there is now a quantity field available. 3) Make a purchasing suggestion using this form, including a quantity. 4) Log in as a member of library staff and go to Home ? Acquisitions ? Suggestions 5) Confirm that the previously entered suggestion is there, and that the correct quantity appears in the "Acquisition information" section. 6) Edit the purchasing suggestion, change the quantity, save it and check that the new quantity appears in the suggestion. I've popped an ID attribute of "opac-suggestion-quantity" to the surrounding
  • so that CSS can easily make this optional field disappear (as suggested by cait on IRC). Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 4efe251f353cb9eddd302b6214e1f4392620b395 Author: Jonathan Druart Date: Wed Sep 6 11:23:10 2017 -0300 Bug 12346: Display the correct number of pending patron modifications on the patron module home page Due to the way members-home.pl handles the variable $branch, the number of patron modifications listed on members-home.pl may differ from the number listed on mainpage.pl. When the librarian clicks this link, he or she may see a different number than was listed, or none at all! Test Plan: 0) Set IndependentBranchesPatronModifications = Yes 1) Create a number of modification request for BranchA 2) Log into the staff intranet with a patron without superlibrarian permissions and set your branch to BranchB 3) Note the modifications alert to does not display on mainpage.pl 4) Click the "Patrons" link to take you to members-home.pl 5) Note the modifictions alert does display on this page 6) Apply this patch 7) Reload members-home.pl, note the alert no longer displays QA notes: What was the point of the branch variable? Followed test plan, patch worked as described. Also passed QA test tool Signed-off-by: Alex Buckley Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 3d07449358010392b111a674c3606cdfe2cbe47e Author: Nick Clemens Date: Fri Sep 1 14:39:25 2017 +0000 Bug 17380: [QA Follow-up] Report error to user instead of throwing exception Internal server errors are good, user feedback is better. Signed-off-by: Marcel de Rooy Tiny change: removed the obsolete 'use Koha::Exceptions'. Signed-off-by: Jonathan Druart commit d0c372c5fa0e867d346b342ae470b31c33d52b26 Author: Nick Clemens Date: Fri Sep 1 14:39:03 2017 +0000 Bug 17380: (QA followup) Fix parameter in tests Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 87773a6d661f122a52b34f6c67255424c335e297 Author: Marcel de Rooy Date: Mon Jun 26 12:51:59 2017 +0200 Bug 17380: Do not allow Default template in merge form This patch makes the following changes: [1] Removes Default from the template list. We should not merge with the Default framework, since it does not have a reporting tag. [2] Rearranges the error section in the template. It is confusing to have two error sections in this template. The error CANNOT_MOVE is not used. The error FRAMEWORK_NOT_SELECTED is replaced by WRONG_FRAMEWORK. [3] Do not allow to merge a record with itself. [4] Check if the merge reference record still contains any MARC tags. [5] Additional polishing: Simplify passing frameworks to template. Remove an unused Koha::Authority::Types->search. Remove obsolete POD header for functions from the script. Test plan: [1] Select two authorities to merge. Verify that you cannot select Default anymore as framework for the reference record. [2] Reproduce error WRONG_COUNT by adding another authid=999 in the URL after you selected two authority records for merging. [3] Remove the third authid from the URL and change the first or second authid into an unexisting record id. You should generate an Internal Server Error. The log should show the exception message. [4] Merge two authorities. Deselect all MARC tags. Should trigger the error EMPTY_MARC in the template. [5] Select the same authority record twice for merging. Should trigger the error DESTRUCTIVE_MERGE in the template. Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 434162c1756b16b5fc715fd1cb762aaf8aff7b2b Author: Marcel de Rooy Date: Tue Jul 4 14:31:21 2017 +0200 Bug 17380: Graceful resolution of missing reporting tag in merge Altough this patch deals with a mostly hypothetical case and this report makes it practically impossible anymore to merge with records in the Default framework (having no reporting tag), we can make the code of sub merge still a bit more robust here. If you would merge biblio records from one authtype to another and the new framework would not have a reporting tag, before this patch the result would be data loss. Merge would handle this request as a delete. This patch makes merge handle it differently: instead of clearing the biblio records, it keeps $a and $9 in order to make a future corrective merge possible. Note: The additional condition on line 1468 for $tags_using_authtype makes sure that we do not select all fields when the authtype should unexpectedly be empty string (Default). This prevents crashing on a "Control fields do not have subfields" error. Test plan: [1] Run t/db_dependent/Authorities/Merge.t Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit db35492c795540d6c3b10f7cba18698aeb84a816 Author: Marcel de Rooy Date: Mon Jun 26 13:41:56 2017 +0200 Bug 17380: Do not use GuessAuthTypeCode in MetadataRecord::Authority If we got an authtypecode from the database and this value is not NULL since the table column does not allow it, there is no need to call GuessAuthTypeCode for empty string (read: Default framework) in the sub get_from_authid. Furthermore, we remove three Koha::MetadataRecord::Authority->new calls. They are useless, since we do not pass a record. It just generates: No record passed at authorities/merge.pl line 96. Can't bless non-reference value at Koha/MetadataRecord/Authority.pm line 66. Instead we throw an ObjectNotFound exception. Test plan: [1] Run t/db_dependent/Koha_Authority.t [2] Interface will be tested in the following patches. Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 3e631f418a3fafa485b650f0975ee0d06e366884 Author: Marcel de Rooy Date: Thu Feb 23 10:02:57 2017 +0100 Bug 17380: Add some checks around Authorities::Types->find Resolves: Use of uninitialized value $biblio_fields in scalar chop at authorities/detail.pl line 212. Can't call method "authtypetext" on an undefined value at authorities/detail.pl line 216. Can't call method "authtypecode" on an undefined value at authorities/detail.pl line 180. NOTE: Some of these problems have actually been resolved now by bugs 18801 and 18811, but it is still better imo to have these checks. Test plan: [1] Verify unchanged behavior. Search for some authorities on authorities.pl and click on the details of a record. [2] Open an authorities detail page and change the authid in the URL to a not existing number. Instead of an internal server error, you should see a message like "The authority record you requested does not exist". Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit dc60c344768540c5e02c8e46e8ae43f7921d252a Author: Jonathan Druart Date: Tue Sep 12 12:04:50 2017 -0300 Bug 18811: DBRev 17.05.00.006 Signed-off-by: Jonathan Druart commit 562435e767c99670dd9fb8935a2ed483b7a61930 Author: Marcel de Rooy Date: Mon Sep 4 09:27:09 2017 +0200 Bug 18811: [QA Follow-up] Resolved POD warnings Trivial changes to silence qa tools on POD warnings for Subfields and Tags. Note: Since Subfield and Tag only contain one sub which is considered as private by Pod::Coverage, these modules are listed as unrated (no public symbols defined) and trigger a FAIL on pod coverage in qa tools. This fail can be ignored. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit ac653bc7cec4e2ca1f8653efff4a9c44f4255540 Author: Marcel de Rooy Date: Mon Sep 4 09:19:01 2017 +0200 Bug 18811: [QA Follow-up] Add tests for Koha::Authority::Subfields/Tags Renaming t/db_dependent/Authorities to Authority Adding Subfields.t and Tags.t Test plan: [1] prove t/db_dependent/Authority Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit f45fc4d10b84dfbd8040d12484553db8c87ec45a Author: Marcel de Rooy Date: Fri Jun 23 07:59:04 2017 +0200 Bug 18811: Atomic update to print warning at upgrade time The warning encourages people to run the auth_show_hidden_data script to check for data in hidden fields and adjust their frameworks. Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 15dee475180ac362e182e1708d1c8b1b1e25e635 Author: Marcel de Rooy Date: Thu Jun 22 15:39:41 2017 +0200 Bug 18811: Add a script for checking authority data in hidden fields If you edit an authority record while having data in hidden fields or subfields, that data will be lost now. This script can help you to unhide some fields and prevent data loss. Test plan: [1] Add a PERSO_NAME record. Fill e.g. 100b. [2] Hide 100b in the PERSO_NAME framework. [3] Run auth_show_hidden_data.pl and verify that it reports 100b in the PERSO_NAME framework. Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit ca8f8b4cd91fac4acb6e2338720b8e0a82bce0b0 Author: Marcel de Rooy Date: Thu Jun 22 13:42:38 2017 +0200 Bug 18811: Add Koha Objects for authority tags and subfields Trivial copy and paste activity. Will be used in a later patch. No test plan needed. Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 7e222bb0796196f1e466b73d909fd28d529cab75 Author: Marcel de Rooy Date: Thu Jun 15 12:30:27 2017 +0200 Bug 18811: Change visibility checks in authorities.pl The check is now <=-4 or >=5, but the framework uses 0 for Show all and -5 for Hide all. (Note that sql installer scripts also use 8.) When modifying an authority, the script also showed hidden fields when filled, since it did not check the hidden field but only the tab field. NOTE: The proposed solution restores consistency, but will remove hidden fields from the MARC record. Test plan: [1] Set field 942a to Show all in an authority framework. [2] Open a new record in this framework and verify that you see 942a. [3] Edit an existing record in this framework and verify again. [4] Set field 942a now to Hide all in this framework. [5] Open a new record in this framework and verify that 942a is hidden. [6] Edit an existing record in this framework and verify again. Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 35e3de845c591958d66c6602940453f2a803a7ee Author: Jonathan Druart Date: Wed Sep 6 10:42:28 2017 -0300 Bug 19262: Remove xt/author/pod_spell.t If you run `prove xt/author/pod_spell.t` without having Test::Spelling installed, it will skip the tests. If you install the lib-test-spelling-perl, the test will fail: xt/author/pod_spell.t .. You said to run 0 tests at xt/author/pod_spell.t line 21. xt/author/pod_spell.t .. Dubious, test returned 25 (wstat 6400, 0x1900) No subtests run This is because the call to all_pod_files_spelling_ok is expecting a path If we try to fix it with adding "." as parameter, the tests will raise tone of errors. Let's remove this file Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit f8502b0d197bab4b4966e9e02253d30f7fcf29f8 Author: Jonathan Druart Date: Thu Aug 31 11:47:11 2017 -0300 Bug 19227: Reduce the number of tests run by 00-merge-conflict-markers.t The number of tests on jenkins is sometimes confusing: https://jenkins.koha-community.org/job/Koha_Master_D8/lastCompletedBuild/testReport/(root)/t_00_merge_conflict_markers_t/ shows that 00-merge-conflict-markers.t ran 10,751 tests, 124 less than the previous run. However 124 files have not been removed from the codebase! I suggest to count only 1 test for all files. Moreover files from blib and cover_db are counted, they should be excluded. Test plan: prove t/00-merge-conflict-markers.t must return green echo ">>>>>>>" >> mainpage.pl and run the test again It should now fail Signed-off-by: Magnus Enger Works as advertised. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 99e691feee5ef29bbc9d24a916fc4aa2fab6bba6 Author: Mark Tompsett Date: Fri Sep 1 13:16:43 2017 -0400 Bug 19235: Password entry visible in OPAC Self-registration The HTML code was "text" instead of "password". TEST PLAN ---------- 1) 'Allow' PatronSelfRegistration system preference 2) Define the PatronSelfRegistrationDefaultCategory system preference (e.g. PT) 3) Open OPAC 4) Click 'Register here' on the right. (/cgi-bin/koha/opac-memberentry.pl) 5) Scroll to bottom 6) enter some passwords -- visible 7) apply this patch 8) refresh page 9) repeat 5-6 as needed -- passwords should not be visible while entering 10) run koha qa test tools Signed-off-by: Lee Jamison Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 6ae69d27815dc01ab515b6d8f0239ef5fe59251c Author: Jonathan Druart Date: Fri Sep 8 09:41:21 2017 -0300 Bug 19277: Make sure the tests will pass even if they are slow This patch was my first attempt to fix the issue. I think it is good to have it, if issue.timestamp and issue.issuedate are the same, the result will be orderd by issue_id. The tests highlight the fact that checkouts must be displayed in the correct order. Signed-off-by: Lee Jamison Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 5a64723e6d3d21b3e0d9302b273b6fbb43c969af Author: Jonathan Druart Date: Fri Sep 8 09:38:28 2017 -0300 Bug 19277: TT syntax - Display ordered data This issue has been highlighted by a failing test: ISSUESLIP displays checkouts in random order I thought it was because of dates comparison, but it comes from the following line in C4::Letters::_get_tt_params my $objects = $module->search( { $key => { -in => $values } } ); The DBMS will return data like there is ordered in the DB. For instance: select borrowernumber from borrowers where borrowernumber in (5, 3, 1); or select borrowernumber from borrowers where borrowernumber=5 or borrowernumber=3 or borrowernumber=1; will return 1, 3, 5 I did not find a generic way to do that, so used "ORDER BY FIELD" which will not be portable. Test plan: If you do not apply this patch, the tests will sometime fail Signed-off-by: Lee Jamison Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 0ed469525fe16e36663c1f5266568beb5e27672d Author: Aleisha Amohia Date: Thu Mar 30 04:15:54 2017 +0000 Bug 18351: Able to delete budget with funds To test: 1) Create a budget, add a fund 2) Delete budget. Notice this is successful and triggers no warning message etc. 3) Go to Funds. Notice the funds appear as if they are not there 4) Go into mysql and view the aqbudgetperiods table - notice the funds are still there and are now inaccessible. 5) Apply patch 6) Create a budget, add a fund 7) Attempt to delete budget. Notice you can't click Delete button. Confirm number of funds in hover message is correct. 8) Delete fund 9) Confirm you can now delete budget. Sponsored-by: Catalyst IT Signed-off-by: Felix Hemme Signed-off-by: Owen Leonard Bug 18351: [FOLLOW-UP] Some code fixes See Comment 5. Ready to test. Signed-off-by: Lee Jamison Signed-off-by: Owen Leonard Bug 18351: [FOLLOW-UP] Code fix See comment 10. Ready for testing. Signed-off-by: Owen Leonard Bug 18351: [FOLLOW-UP] Prevent deletion from forcing URL This patch adds a check in the script for existing funds so that the budget cannot be deleted when forcing the URL and has other small fixes. Signed-off-by: Owen Leonard Bug 18351: [FOLLOW-UP] Prevent deletion if funds are added after clicking 'Delete' and before confirming delete Followed test plan and patch works as described. Signed-off-by: Dilan Johnpull? Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 133e25c56ac79e0b88b89e3b749df338e63a93d0 Author: Marcel de Rooy Date: Fri Sep 8 10:14:10 2017 +0200 Bug 15438: [QA Follow-up] Moving POD statement for CanBookBeIssued The statement for head3 NB ('nota bene'?) looks like a hash key in the list of possible return values for $needsconfirmation. Moved it up and prefixed it with IMPORTANT. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 4d223bdc6156fab0667867f3990854fddfab5684 Author: Colin Campbell Date: Wed Aug 24 13:52:52 2016 +0100 Bug 15438 - Checking out an on-hold item sends holder's borrowernumber in AF (screen message) field. The returns from C4::Circulation::CanBookBeIssued used to be structured as a hashref of entries like REASON => { data => 'foo', moredata => 'bar', }; Some entries still are. But many are now REASON => 1, data => 'foo', moredata => 'bar', The sip Checkout routine still assumed the former, as it reports any causes it was not aware of (to maintain support for a changing api) The data fields could leak into the screen message field of the response. e.g. the borrowernumber or surname of the borrower who has a hold on an issued title. Some real messages were getting obscured by this This patch sanatizes the return from from CanBookBeIssued by removing keys which are not all uppercase It also fixes a case where the key's data element was used for the screen message when we should use the key itself Updated the documentation of CanBookBeIssued to flag up the assumption re case and the fact that 3 elements rather than two may be returned The loop through the returned keys was a bit bogus so we now explicitly jump out if noerror is unset Signed-off-by: Marcel de Rooy Tested quite extensively. Test results put on Bugzilla. Signed-off-by: Jonathan Druart commit 889fabe9f28f3b6ef35fc36e73b12652f258510c Author: Fridolin Somers Date: Tue Sep 12 14:57:25 2017 +0200 Bug 18654 - Translatability: Get rid of tt directives starting with [%% in translation for itemsearch.tt Followup correcting a typo of previous patch : name="holdingbranch" options = branche it is branche[s] Test plan : - Look at 'Current location' in item search => Without patch you see only 'All libraries' => With patch you see 'All libraries' and each existing library, like in 'Home library' Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: C4/Accounts.pm | 2 +- C4/AuthoritiesMarc.pm | 14 ++- C4/Circulation.pm | 8 +- C4/Letters.pm | 13 +- C4/Members.pm | 9 +- C4/SIP/ILS/Transaction/Checkout.pm | 42 +++++-- Koha.pm | 2 +- Koha/{Biblioitem.pm => Authority/Subfield.pm} | 10 +- Koha/{Biblioitems.pm => Authority/Subfields.pm} | 18 +-- Koha/{City.pm => Authority/Tag.pm} | 10 +- Koha/{Biblioitems.pm => Authority/Tags.pm} | 18 +-- Koha/MetadataRecord/Authority.pm | 7 -- admin/aqbudgetperiods.pl | 30 +++-- authorities/authorities.pl | 14 +-- authorities/detail.pl | 8 +- authorities/merge.pl | 86 ++++++++------ installer/data/mysql/updatedatabase.pl | 9 ++ .../prog/en/modules/admin/aqbudgetperiods.tt | 40 +++++-- .../prog/en/modules/authorities/merge.tt | 60 ++++------ .../prog/en/modules/catalogue/itemsearch.tt | 2 +- .../bootstrap/en/modules/opac-memberentry.tt | 8 +- .../bootstrap/en/modules/opac-suggestions.tt | 1 + members/members-home.pl | 14 ++- misc/maintenance/auth_show_hidden_data.pl | 124 ++++++++++++++++++++ t/00-merge-conflict-markers.t | 17 ++- t/db_dependent/{Authorities => Authority}/Merge.t | 33 +++++- .../{Authorities => Authority}/MergeRequests.t | 0 t/db_dependent/Authority/Subfields.t | 49 ++++++++ t/db_dependent/Authority/Tags.t | 48 ++++++++ t/db_dependent/Letters/TemplateToolkit.t | 14 ++- xt/author/pod_spell.t | 22 ---- 31 files changed, 517 insertions(+), 215 deletions(-) copy Koha/{Biblioitem.pm => Authority/Subfield.pm} (86%) copy Koha/{Biblioitems.pm => Authority/Subfields.pm} (78%) copy Koha/{City.pm => Authority/Tag.pm} (87%) copy Koha/{Biblioitems.pm => Authority/Tags.pm} (80%) create mode 100755 misc/maintenance/auth_show_hidden_data.pl rename t/db_dependent/{Authorities => Authority}/Merge.t (93%) rename t/db_dependent/{Authorities => Authority}/MergeRequests.t (100%) create mode 100644 t/db_dependent/Authority/Subfields.t create mode 100644 t/db_dependent/Authority/Tags.t delete mode 100644 xt/author/pod_spell.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 12 17:14:51 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 12 Sep 2017 15:14:51 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.03-47-g4c76583 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via 4c76583e6d3079bad51048f62f43c3c433f1e9bd (commit) from 960015819e0c19ef85c458d0bdaec8a24cd86dc3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4c76583e6d3079bad51048f62f43c3c433f1e9bd Author: Fridolin Somers Date: Wed Aug 2 11:21:58 2017 +0200 Bug 19023 - inventory tool performance Inventory tool performance seems to be worst since 16.11. I think it is because of authorized values computing changed by Bug 17249. For each subfield of each item, we try to get the authorized value description with Koha::AuthorisedValues->search_by_marc_field. But this method does not use cache like Koha::AuthorisedValues->get_description_by_koha_field. I propose to use Koha::AuthorisedValues->get_description_by_koha_field and also to look for authorized value description only for item fields used in TT : location, notforloan, itemlost, damaged, withdrawn. I have experimented inventory time on 100 items from 5s to 1s. Test plan : - Without patch - Perform inventory with barcode file - Check results and mesure execution time - Apply patch - Reperform inventory with same barcode file - Check results is the same - Compare execution time - Run prove t/db_dependent/Items/GetItemsForInventory.t Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart (cherry picked from commit 95f1844e6c46ff51de9f95f99fcdf3369c756fd4) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: tools/inventory.pl | 22 ++++++++-------------- 1 file changed, 8 insertions(+), 14 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 12 17:50:30 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 12 Sep 2017 15:50:30 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.05.00-593-gc73b6d5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via c73b6d51dac3d07d32135f0f891cc6418101a53b (commit) via c43a555dbce3a50a752cdf397379766c46fb3555 (commit) via adf4077b39c96bd353fb733b3e8093550cb9db09 (commit) via 71b9dc1e3932db29e8fa7a32dd25e7e54c95f228 (commit) via db5848bf2a5b5f881a1cf59fb794ecfd01841c8d (commit) via a86d7fd3d097987da8e97054ff37e3061eeb9811 (commit) via 82115d164a15767965d267826cc64e74132bd374 (commit) from 5400795a6651adc021801052fa0186747983b587 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c73b6d51dac3d07d32135f0f891cc6418101a53b Author: Marcel de Rooy Date: Thu Sep 7 14:34:18 2017 +0200 Bug 19059: [QA Follow-up] Typo holds for hold Resolves: The method found is not covered by tests at C4/Reserves.pm line 815. Test plan: Run t/db_dependent/Holds/CancelReserves.t Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit c43a555dbce3a50a752cdf397379766c46fb3555 Author: Jonathan Druart Date: Fri Sep 1 16:50:26 2017 -0300 Bug 19059: Fix compilation issues Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit adf4077b39c96bd353fb733b3e8093550cb9db09 Author: Jonathan Druart Date: Mon Aug 7 15:13:17 2017 -0300 Bug 19059: Remove CancelReserve It's done! Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 71b9dc1e3932db29e8fa7a32dd25e7e54c95f228 Author: Jonathan Druart Date: Fri Aug 4 10:44:56 2017 -0300 Bug 19059: Remove CancelReserve - do not log DELETE There is something wrong with the DELETE log, it should be replaced with a FILLED log. Anyway, here we do not want it to be logged. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit db5848bf2a5b5f881a1cf59fb794ecfd01841c8d Author: Jonathan Druart Date: Thu Aug 3 18:00:22 2017 -0300 Bug 19059: Remove CancelReserve - add new tests This is bonus, let's add new tests Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit a86d7fd3d097987da8e97054ff37e3061eeb9811 Author: Jonathan Druart Date: Thu Aug 3 15:12:25 2017 -0300 Bug 19059: Remove CancelReserve - move tests Move the existing tests Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 82115d164a15767965d267826cc64e74132bd374 Author: Jonathan Druart Date: Wed Aug 2 14:00:12 2017 -0300 Bug 19059: Move C4::Reserves::CancelReserve to Koha::Hold->cancel This patch adds a new Koha::Hold->cancel method and replaces the calls to C4::Reserves::CancelReserve with it. Test plan: - Add and cancel holds - Change priority of holds Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: C4/Biblio.pm | 3 +- C4/ILSDI/Services.pm | 2 +- C4/Reserves.pm | 111 ++++--------- C4/SIP/ILS/Transaction/Hold.pm | 14 +- Koha/Hold.pm | 58 ++++++- Koha/Patron/Discharge.pm | 3 +- Koha/REST/V1/Hold.pm | 2 +- circ/branchtransfers.pl | 23 ++- circ/returns.pl | 6 +- circ/waitingreserves.pl | 2 +- opac/opac-modrequest.pl | 6 +- reserve/request.pl | 3 +- t/db_dependent/Circulation.t | 4 +- t/db_dependent/Holds.t | 68 +++----- t/db_dependent/Holds/HoldFulfillmentPolicy.t | 19 +-- t/db_dependent/Holds/HoldItemtypeLimit.t | 8 +- t/db_dependent/HoldsQueue.t | 25 +-- t/db_dependent/Koha/Holds.t | 222 ++++++++++++++++++++++++++ t/db_dependent/Reserves.t | 93 +---------- t/db_dependent/UsageStats.t | 2 +- tools/batch_delete_records.pl | 2 +- 21 files changed, 403 insertions(+), 273 deletions(-) create mode 100644 t/db_dependent/Koha/Holds.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 14 15:35:32 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 14 Sep 2017 13:35:32 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.03-49-gea316ad Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via ea316ad4ae5b4aea4c255d08d36bfcb0b705c23b (commit) via dcafcbc036f9229d2d2854012f80fe051012a349 (commit) from 4c76583e6d3079bad51048f62f43c3c433f1e9bd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ea316ad4ae5b4aea4c255d08d36bfcb0b705c23b Author: Fridolin Somers Date: Tue Sep 12 14:57:25 2017 +0200 Bug 18654 - Translatability: Get rid of tt directives starting with [%% in translation for itemsearch.tt Followup correcting a typo of previous patch : name="holdingbranch" options = branche it is branche[s] Test plan : - Look at 'Current location' in item search => Without patch you see only 'All libraries' => With patch you see 'All libraries' and each existing library, like in 'Home library' Signed-off-by: Jonathan Druart (cherry picked from commit 889fabe9f28f3b6ef35fc36e73b12652f258510c) Signed-off-by: Fridolin Somers commit dcafcbc036f9229d2d2854012f80fe051012a349 Author: Marc V?ron Date: Thu Jun 29 15:22:54 2017 +0200 Bug 18654 - Translatability: Get rid of tt directives starting with [%% in translation for itemsearch.tt This patch removes entries like the following in translations of itemsearch.tt: "[%% INCLUDE form_field_select name=\"homebranch\" options = branches " "empty_option = \"All libraries\" %%] [%% INCLUDE form_field_select name=" "\"holdingbranch\" options = branches empty_option = \"All libraries\" %%] %s " "[%% INCLUDE form_field_select name=\"location\" options = locations " "empty_option = \"All locations\" %%] %s " New patch on top of Bug 18633 that resolves parts of initial comment. To test: - Verify that in itemsearch.tt no tt directives are splitted by new lines (search for [% INCLUDE ) - Verify that itemsearch.tt works as before Followed test plan and verified that tt directives are not split by new lines, the changes to the fieldset tags in comment 3 have been removed and itemtype.tt still works correctly as before Signed-off-by: Alex Buckley Signed-off-by: Jonathan Druart (cherry picked from commit 25fa02272d16c98d49a6020e867f60bc0510d960) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/catalogue/itemsearch.tt | 36 ++++---------------- 1 file changed, 6 insertions(+), 30 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Sep 16 09:15:14 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sat, 16 Sep 2017 07:15:14 +0000 Subject: [koha-commits] main Koha release repository branch 16.11.x updated. v16.11.11-1-39-g42b3010 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 16.11.x has been updated via 42b30105ffd2b6814873fad1cff5cd4d35c140ee (commit) via ff554650015bb06bf4bf0146d81c653bd0f2c61d (commit) via b559399ad52645041697558ae3eb710628c53781 (commit) via 632d47db0b86542512b443e9bb69c00c3add31a7 (commit) via 9fc57e9768426bf84d00e8238ff3851ced6e2997 (commit) via a374afe92df9b25a231c20296f50c351606d2e32 (commit) via 85a57d0f94c18483ff67ef53a7e067c8ebdca4b9 (commit) via 605dcc6e1aa4b0666eb646813f13f7088d7d2b3d (commit) via 65eb8108509cc5c50a2e819585efe34bdb6f7ff3 (commit) via fc4a184a5fda8571a7548996d5813205d25e6e5f (commit) via 41350af22570d32148c673e846e45d46fa1806c5 (commit) via 73533f0b67faba3355b27046d4017714fc08f81d (commit) via 353d5a1560976c34152ada5895d15446b8cc1754 (commit) via 3e561bb3d6b1cca470340dd1aa22dab44fc8d193 (commit) via c4064d0226a67d4aca8eece7c7b54c8f370afaa7 (commit) via 4c90c0de023ca8edb2cab2425264f367ffacfadb (commit) via 502dddf9da62c5206d2be7fd94cf3ff95003dc7f (commit) via 099897fd2738e4589f9e8412be242ccf000fcb69 (commit) via 255dca62aa5f3989a981b493774517f8f53d01cb (commit) via d62eea1bf38b0939b173bce2f170fa810bd194aa (commit) via f270020500ef4956c73c2b9630d70e32ebae6921 (commit) via 056b10fcec4a68b9e379f3eb1be9120e7b2b3e98 (commit) from d2b84a87fbeae550a9dbc9800202813daf1affd8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 42b30105ffd2b6814873fad1cff5cd4d35c140ee Author: Fridolin Somers Date: Tue Sep 12 14:57:25 2017 +0200 Bug 18654 - Translatability: Get rid of tt directives starting with [%% in translation for itemsearch.tt Followup correcting a typo of previous patch : name="holdingbranch" options = branche it is branche[s] Test plan : - Look at 'Current location' in item search => Without patch you see only 'All libraries' => With patch you see 'All libraries' and each existing library, like in 'Home library' Signed-off-by: Jonathan Druart (cherry picked from commit 889fabe9f28f3b6ef35fc36e73b12652f258510c) Signed-off-by: Fridolin Somers (cherry picked from commit ea316ad4ae5b4aea4c255d08d36bfcb0b705c23b) Signed-off-by: Katrin Fischer commit ff554650015bb06bf4bf0146d81c653bd0f2c61d Author: Marc V?ron Date: Thu Jun 29 15:22:54 2017 +0200 Bug 18654 - Translatability: Get rid of tt directives starting with [%% in translation for itemsearch.tt This patch removes entries like the following in translations of itemsearch.tt: "[%% INCLUDE form_field_select name=\"homebranch\" options = branches " "empty_option = \"All libraries\" %%] [%% INCLUDE form_field_select name=" "\"holdingbranch\" options = branches empty_option = \"All libraries\" %%] %s " "[%% INCLUDE form_field_select name=\"location\" options = locations " "empty_option = \"All locations\" %%] %s " New patch on top of Bug 18633 that resolves parts of initial comment. To test: - Verify that in itemsearch.tt no tt directives are splitted by new lines (search for [% INCLUDE ) - Verify that itemsearch.tt works as before Followed test plan and verified that tt directives are not split by new lines, the changes to the fieldset tags in comment 3 have been removed and itemtype.tt still works correctly as before Signed-off-by: Alex Buckley Signed-off-by: Jonathan Druart (cherry picked from commit 25fa02272d16c98d49a6020e867f60bc0510d960) Signed-off-by: Fridolin Somers (cherry picked from commit dcafcbc036f9229d2d2854012f80fe051012a349) Signed-off-by: Katrin Fischer commit b559399ad52645041697558ae3eb710628c53781 Author: Fridolin Somers Date: Wed Aug 2 11:21:58 2017 +0200 Bug 19023 - inventory tool performance Inventory tool performance seems to be worst since 16.11. I think it is because of authorized values computing changed by Bug 17249. For each subfield of each item, we try to get the authorized value description with Koha::AuthorisedValues->search_by_marc_field. But this method does not use cache like Koha::AuthorisedValues->get_description_by_koha_field. I propose to use Koha::AuthorisedValues->get_description_by_koha_field and also to look for authorized value description only for item fields used in TT : location, notforloan, itemlost, damaged, withdrawn. I have experimented inventory time on 100 items from 5s to 1s. Test plan : - Without patch - Perform inventory with barcode file - Check results and mesure execution time - Apply patch - Reperform inventory with same barcode file - Check results is the same - Compare execution time - Run prove t/db_dependent/Items/GetItemsForInventory.t Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart (cherry picked from commit 95f1844e6c46ff51de9f95f99fcdf3369c756fd4) Signed-off-by: Fridolin Somers (cherry picked from commit 4c76583e6d3079bad51048f62f43c3c433f1e9bd) Signed-off-by: Katrin Fischer commit 632d47db0b86542512b443e9bb69c00c3add31a7 Author: Jonathan Druart Date: Mon Sep 4 12:06:56 2017 -0300 Bug 18927: Use fully qualified subroutine names in C4::Items rebuild_zebra.pl fails in some conditions (perl version?) I do not recreate but it has been reported that reindex fails with: error retrieving biblio 94540 at /usr/share/koha/bin/migration_tools/rebuild_zebra.pl line 683, line 751. To fix it we can use fully qualified subroutine names for: GetMarcFromKohaField GetMarcBiblio GetBiblionumberFromItemnumber TransformKohaToMarc GetFrameworkCode Test plan: Confirm the rebuild_zebra script still works correctly after this patch Signed-off-by: Lee Jamison Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit 2671eb2f93340e8fb3c794cff918d86c526cc47f) (cherry picked from commit 1a50b447d3d58b40d8f84e7c264f01abcb42a826) Signed-off-by: Katrin Fischer commit 9fc57e9768426bf84d00e8238ff3851ced6e2997 Author: Alex Sassmannshausen Date: Thu Aug 10 13:00:19 2017 +0200 Bug 19073: (bug 15758 follow-up) Dereference correct value from Koha::Object. * tools/modborrowers.pl: Dereference 'branchcode' rather than 'value'. Test Plan: - Carry out "Batch patron modification" with any number of patrons. + Change the library. + Hit Save. - The library will not have been updated. - Apply patch. - Run same modification. - The library will have been updated Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart (cherry picked from commit 8a328a20bf3a74268346104281688b2a81be80e6) Signed-off-by: Fridolin Somers (cherry picked from commit 111ab4e63257410bf7ca34e80e46675603072c36) Signed-off-by: Katrin Fischer commit a374afe92df9b25a231c20296f50c351606d2e32 Author: Fridolin Somers Date: Thu Jul 6 08:48:18 2017 +0200 Bug 18900: wrong number format in receiving order Bug 18471 added number formating in order receive. I found a bug generated by this. Koha::Number::Price defines methods to (un)format price depending on CurrencyFormat syspref. The bug is that for CurrencyFormat US, some params are not defined in this module so there are retrieved from system locale. If system locale is not en_US, the params will be wrong. For example fr_FR will define ',' as decimal and so saved unit price is divided by 1000. To recreate: - On a server with locale 'fr_FR' - With Plack mode - Set CurrencyFormat on 'US' - Open a basket - Place an order for an item - Close basket - Receive order with changing 'Actual Cost' to '1,234' - Note the 'Actual Cost' is now '1.23' - Run unit test t/Number/Price.t without and with patch Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart (cherry picked from commit e35903574ce666bca32eb4676f311b99bb268ec2) Signed-off-by: Fridolin Somers (cherry picked from commit 92b08a23e3b2c001d208b82b6ffee2af756ca51f) Signed-off-by: Katrin Fischer commit 85a57d0f94c18483ff67ef53a7e067c8ebdca4b9 Author: Tomas Cohen Arazi Date: Wed Aug 9 12:01:17 2017 -0300 Bug 18900: (QA followup) Make tests conditional to locale existence It is important to highlight that tests have been skipped instead of having them pass on the absence of the required fr_FR.UTF-8 locale installed on the system. This patch does that check and effectively skips them. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart (cherry picked from commit 61f2ec769073709be3b688654ec355b3f4fbe522) Signed-off-by: Fridolin Somers (cherry picked from commit 1865db52bbf9413574c22ee2c9180137ac357918) Signed-off-by: Katrin Fischer commit 605dcc6e1aa4b0666eb646813f13f7088d7d2b3d Author: Fridolin Somers Date: Thu Jul 6 08:44:51 2017 +0200 Bug 18900: add UT to Number/Price.t This patch adds unit tests to t/Number/Price.t in order to valid the problem. Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart (cherry picked from commit 91dee226cdd089353dc71e559aa9e0b34fddf72e) Signed-off-by: Fridolin Somers (cherry picked from commit aca614cd95b32d2953927e8e3e908bc1248b541c) Signed-off-by: Katrin Fischer commit 65eb8108509cc5c50a2e819585efe34bdb6f7ff3 Author: Jonathan Druart Date: Thu Jul 6 18:10:10 2017 -0300 Bug 18906: Display all funds the logged in user can use There are complex conditions to know if a librarian can use a fund, we cannot do that with a SQL query, we need to use C4::Budgets::CanUserUseBudget When this patch is applied then all funds are visible to both superlibrarian patrons and patrons with all acq permissions Signed-off-by: Alex Buckley Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 19a7b498e1f4355ab1e4ee0adb5db299613f3f5c) Signed-off-by: Fridolin Somers (cherry picked from commit d179da572b1d6bd7066d96f494aa805b86b92ae1) Signed-off-by: Katrin Fischer commit fc4a184a5fda8571a7548996d5813205d25e6e5f Author: David Cook Date: Thu Jul 27 11:58:28 2017 +1000 Bug 18898 - Some permissions for Reports can be bypassed If you manually visit the following links when you only have permission to run reports, you'll still be able to access the ability to create and edit reports: /cgi-bin/koha/reports/guided_reports.pl?phase=Create%20report%20from%20SQL /cgi-bin/koha/reports/guided_reports.pl?phase=Edit%20SQL This patch ties these 2 unaccounted for phases to the create_reports permission. With patch, issue no longer can be reproduced. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 2fdfbaf0ddbf214c0efb9a3a3c2595a54517f795) Signed-off-by: Fridolin Somers (cherry picked from commit 4b71c9239708cd4d60190ed907fec03d1f8b08bc) Signed-off-by: Katrin Fischer commit 41350af22570d32148c673e846e45d46fa1806c5 Author: Serhij Dubyk {?????? ?????} Date: Tue Aug 22 17:19:32 2017 +0300 Bug 17827 - Untranslatable "by" in MARC21slim2intranetResults.xsl Signed-off-by: Serhij Dubyk {?????? ?????} The "by" after the title was not translatable in the result lists of the intranet. This patch fixes it by removing a comment, that caused a problem with the translation scripts. To test: Test: Before this patch in file en-GB-marc-MARC21.po present next paragraph: msgid "by " msgstr " by " According string "by " in the file MARC21slim2intranetResults.xsl can not be translated (in other languages). After applying this patch performed next command: cd /usr/share/koha/misc/translator sudo env KOHA_CONF=/etc/koha/sites/mykohainstance/koha-conf.xml PERL5LIB=/usr/share/koha/lib perl -I /usr/share/koha/lib "./translate" update Now in the file en-GB-marc-MARC21.po present the following (modified) paragraph: msgid "by " msgstr " by " https://bugs.koha-community.org/show_bug.cgi?id=17827 Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit d5ea914f4dc41f78dbb3a59f894f6ecbb9a1afa4) Signed-off-by: Fridolin Somers (cherry picked from commit afb2cb0c74b6a137652ec1a2e96fc480a5a50f96) Signed-off-by: Katrin Fischer commit 73533f0b67faba3355b27046d4017714fc08f81d Author: Marc V?ron Date: Mon Jun 12 07:48:57 2017 +0200 Bug 18778 - Translatability: Get rid of tt directive in translation for item-status.inc The file opac-tmpl/bootstrap/en/includes/item-status.inc exposes a template directive where translators should not be confronted with. "%s %s [%%#- This include takes two parameters: an item structure and an " "optional loan (issue) structure. The issue structure is used by course " "reserves pages, which do not use an API to fetch items that populates item." "datedue. -%%] %s %s %s %s " This patch fixes new lines inside a tt directive (comment). It is merely a string patch. To test: Verify that the code changes make sense. (Bonus test: create a new language 'aa-AA', verify that line above does not show up in aa-AA-opac-bootstrap.po) NOTE: Followed test plan similar to bug 18776 comment 3. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart (cherry picked from commit c8551645d5bdd3e6fb5b7e03280521a2fbaef636) Signed-off-by: Fridolin Somers (cherry picked from commit b9ff28f719cb17d37e5eaecc4fb09b9032cc38e5) Signed-off-by: Katrin Fischer commit 353d5a1560976c34152ada5895d15446b8cc1754 Author: Marc V?ron Date: Tue May 23 17:09:49 2017 +0200 Bug 18660: Translatability: Get rid of template directives [%% in translation for patroncards-errors.inc Translation for koha-tmpl/intranet-tmpl/prog/en/includes/patroncards-errors.inc contains a lot of (partial) template directives like: %%]%s %sLayout: [%% This patch fixes it To test: - Verify that code changes make sense - Apply patch - Create a translation (cd misc/translator , then: perl translate create aa-AA - Verify that in po/aa-AA-staff-prog.po contains no fragments like %%] or [%% for patroncards-errors.inc - Try to get an error: Try a link like http://[YOUR SERVER]/cgi-bin/koha/patroncards/create-pdf.pl?batch_id=1&template_id=999&layout_id=999&start_card=1 ...where template_id and layout_id do not exist (Amended for comment #2 2017-06-05 mv) (Amended for comment #6 2017-08-02 mv) Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart (cherry picked from commit 7e39bbc61aedd6383f4d6a1b4728711c6922e877) Signed-off-by: Fridolin Somers (cherry picked from commit 036b317c0c0e96b0eb344d767cca7f87da4fb875) Signed-off-by: Katrin Fischer commit 3e561bb3d6b1cca470340dd1aa22dab44fc8d193 Author: Marc V?ron Date: Mon May 22 21:09:06 2017 +0200 Bug 18652: Get rid of tt directive in translation for uncertainprice.tt Translation tool shows toe following for ncertainprice.tt 0; url=[% scriptname %]?booksellerid=[% booksellerid %] This patch fixes it. To test: - Apply patch - Verify that code change makes sense - Verify that Home > Acquisitions > [vendor] > Uncertain prices for [vendor] works as before - Additional test (for a langunage 'aa-AA') perl translate create aa-AA verify that line 41 no longer appears in aa-AA-staff-prog.po Amended to switch from BLOCK to a template variable, see comment #5 Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart (cherry picked from commit 2ee82801c7a8686523f9c5e95b0f43d44e52e4ab) Signed-off-by: Fridolin Somers (cherry picked from commit 4d427740196bb0a9bcfe80787af8cdf769c06b76) Signed-off-by: Katrin Fischer commit c4064d0226a67d4aca8eece7c7b54c8f370afaa7 Author: Marc V?ron Date: Fri Aug 4 10:52:13 2017 +0200 Bug 18649: Translatability: Get rid of tt directive in translation for admin/categories.tt and onboardingstep2.tt New patch without trailing IF construction in tt directives as requested in comment #28 To test: Verify that translation tool no longer shows tt directives as described in comment #1 New patch, needs SO. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit 79338bde3e01708fe331a54745f45c620c121805) Signed-off-by: Fridolin Somers (cherry picked from commit 0f9175c0b26e9e8d65bf39dab80d99e5d7455346) Signed-off-by: Katrin Fischer commit 4c90c0de023ca8edb2cab2425264f367ffacfadb Author: Marcel de Rooy Date: Mon Jul 10 14:15:09 2017 +0200 Bug 18921: Resolve a few warnings in C4/XSLT.pm Resolves warnings like: Use of uninitialized value in hash element at C4/XSLT.pm line 262. Use of uninitialized value in numeric eq (==) at C4/XSLT.pm line 267. Use of uninitialized value $status in concatenation (.) or string at C4/XSLT.pm line 300. Note: Line numbers are not exactly the same anymore. Test plan: [1] Enable XSLT view in OPAC [2] Without this patch, you will probably have some of these warnings when doing some opac searches. [3] Apply this patch. Check the logs again. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart (cherry picked from commit 5f989a81dff29db78620057d70ed864b32486bc0) Signed-off-by: Fridolin Somers (cherry picked from commit 1c8287632ea36e6d2a8ade922fe129f5f792d6d3) Signed-off-by: Katrin Fischer commit 502dddf9da62c5206d2be7fd94cf3ff95003dc7f Author: Jonathan Druart Date: Mon Sep 11 16:08:41 2017 -0300 Bug 18996: [16.11.x] use Koha::OldIssues instead of Koha::Old::Checkouts commit 099897fd2738e4589f9e8412be242ccf000fcb69 Author: Marcel de Rooy Date: Wed Aug 2 13:01:47 2017 +0200 Bug 18996: [16.11.x] [QA Follow-up] Remove global variables from Message.t As per request of Colin in comment18, this patch makes the use of global variables in Message.t no longer needed. The three subtests are now completely independent and could well be moved to separate test scripts. Note: Strictly speaking, the use of global (package) variables could potentially introduce new bugs (e.g. if the value is modified outside the script). This seems not to be the case here, but we are safe now. Test plan: Run the test again. Signed-off-by: Marcel de Rooy Signed-off-by: Colin Campbell Signed-off-by: Kyle M Hall commit 255dca62aa5f3989a981b493774517f8f53d01cb Author: Marcel de Rooy Date: Sat Jul 29 13:38:31 2017 +0200 Bug 18996: [16.11.x] Add checkin subtest in SIP/Message.t Variable $branch was not used. Promoted some global vars to our. Shared the branchcode between all three subtests now. The third subtest contains all six cases mentioned in the first patch. Test plan: Run t/db_dependent/SIP/Message.t Signed-off-by: Marcel de Rooy Signed-off-by: Colin Campbell Signed-off-by: Kyle M Hall commit d62eea1bf38b0939b173bce2f170fa810bd194aa Author: Marcel de Rooy Date: Tue Aug 1 14:10:56 2017 +0200 Bug 18996: [16.11.x] Resolve an uninitialized warning from ILS/Item.pm From the syslog call on line 107/108. The field $item->{title} has not been initialized. When catching the warns in a test script with Test::Warn, I got: Use of uninitialized value $args[1] in sprintf at /usr/lib/x86_64-linux-gnu/perl/5.20/Sys/Syslog.pm line 423. This simply resolves the warning. We might have a closer look to this title field on another report though. Test plan: Run Message.t from the next patch without this fix. It will fail since the additional warning makes warnings_like return false. Signed-off-by: Marcel de Rooy Signed-off-by: Colin Campbell Signed-off-by: Kyle M Hall commit f270020500ef4956c73c2b9630d70e32ebae6921 Author: Marcel de Rooy Date: Fri Jul 28 10:29:51 2017 +0200 Bug 18996: [16.11.x] Handle data corruption from old_issues at SIP checkin As per bug 18966 AddReturn returns false with a DataCorrupted message when the issue_id at hand already occurs in the old_issues table. This should be handled when returning an item via SIP too. SIP should not pretend that the checkin was successful, since this item needs special care. The following six different situations are handled: [1] An attempt to checkin an invalid barcode is handled as before. The ok flag is false; the screen message shows 'Invalid Item'. [2] We receive a DataCorrupted message: the alert type is set to the unused 98 code to indicate this new error condition. The ok flag is false; the screen message shows 'Checkin failed: data problem'. [3] The item checked in was not checked out AND the option checked_in_ok is active. The ok flag is set to true; no screen message. [4] The item checked in was not checked out AND the option checked_in_ok is not active. The ok flag is not changed (normally false); the screen message shows 'Item not checked out'. [5] (The regular checkin) The item was checked out and AddReturn returned true. The ok flag is true; no screen message. [6] ("Otherwise") The item was checked out, but AddReturn returned false. The ok flag is false; the screen message shows 'Checkin failed'. Note: Currently this case only refers to the Wrongbranch and withdrawn messages from AddReturn (where doreturn==0). Note: Situation 1 and 5 are unchanged. Behavior is slightly changed for situation 3 and 4; the option is only used when the item was not checked out. Situation 2 and situation 6 are changed. After bug 18966 SIP returned OK in case of data corruption (while checkin failed). In the remaining cases under [6] SIP also returned OK while checkin failed. Test plan: [1] Test all six cases listed above. In order to simulate data corruption insert the issue_id at hand in old_issues before you check in. In cases 3 and 4 you need to toggle the option in your SIPconfig.xml and restart the SIP server. Case 6 can be tested by checking out at branch A, adjusting the value of pref AllowReturnToBranch and checking in at branch B. Signed-off-by: Marcel de Rooy Signed-off-by: Colin Campbell Signed-off-by: Kyle M Hall commit 056b10fcec4a68b9e379f3eb1be9120e7b2b3e98 Author: Chris Cormack Date: Wed Aug 2 10:15:10 2017 +1200 Bug 18046: CAS logout infinite redirect To test (You need a CAS server and CAS configured in Koha) 1/ Login using CAS in Koha 2/ Logout in Koha 3/ Notice you get redirected again and again 4/ Apply patch 5/ Login with CAS, then logout 6/ Notice logout works, but no longer infinitely redirected Signed-off-by: Katrin Fischer Patch has been in production use for several months on several instances. Fixes a critical bug. Signed-off-by: Marcel de Rooy Looks like a typical workaround, but evidently works. Not tested with CAS. Signed-off-by: Jonathan Druart (cherry picked from commit 13ca4962068b184f803b6588e53e39209a77f2b6) Signed-off-by: Fridolin Somers (cherry picked from commit c87b963818076a58661922116893ff052b2d76a9) Signed-off-by: Katrin Fischer ----------------------------------------------------------------------- Summary of changes: C4/Auth_with_cas.pm | 1 + C4/Items.pm | 30 +-- C4/SIP/ILS.pm | 37 ++-- C4/SIP/ILS/Item.pm | 2 +- C4/SIP/ILS/Transaction/Checkin.pm | 4 +- C4/XSLT.pm | 6 +- Koha/Number/Price.pm | 3 + admin/aqbudgets.pl | 3 +- .../prog/en/includes/patroncards-errors.inc | 58 +++--- .../prog/en/modules/acqui/uncertainprice.tt | 3 +- .../prog/en/modules/admin/categories.tt | 6 +- .../prog/en/modules/catalogue/itemsearch.tt | 36 +--- .../prog/en/xslt/MARC21slim2intranetResults.xsl | 2 +- .../bootstrap/en/includes/item-status.inc | 10 +- misc/migration_tools/rebuild_zebra.pl | 8 +- reports/guided_reports.pl | 2 +- t/Number/Price.t | 22 ++- t/db_dependent/SIP/Message.t | 206 +++++++++++++++++--- tools/inventory.pl | 22 +-- tools/modborrowers.pl | 2 +- 20 files changed, 312 insertions(+), 151 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Sep 19 16:52:27 2017 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 19 Sep 2017 14:52:27 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.05.00-620-ge98c178 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e98c178c081d4bb5673e6b04bf817b9c452cba8c (commit) via 6ce1cc6aada33d7f72b8d3b0b9af4add65a93842 (commit) via 06b602b0976e2a8d53ff31f95a2213cbeb98e9cb (commit) via 438a3dea0c8ef1a5adcec58d8b97474d14ccca9b (commit) via 17c5b76597b9a356bc215a3682d7293e307fcc46 (commit) via a59eaa5277b60055df216373247efc654551d579 (commit) via 7f5e8668a75e2a75b638fbb39ca3b5576bcf76d3 (commit) via c7ac741e6a5d5e9bf4fb96dda3e4fabeace7f025 (commit) via 45aea7ae1df815d241e7a34fbb5c42e9475f6d04 (commit) via 9355e5204074349c232c58caa678a8ab40c18efe (commit) via 83704cb1fab33feb0262fdab99bccf0052243d14 (commit) via e722c0a29f730869df24cbe48afcedc12bb57344 (commit) via 0f9dce409f6dba60cbb52ae682e70d8203e96ea1 (commit) via 80c749df80f08be46b895715045b38cd1ded2ed1 (commit) via 30311019987dcddd410fd86c018443e9480253b5 (commit) via 6ead305ba4ee9ae5795b3956b41b6a723d7c894d (commit) via 2fcf6e88ba6c95461df127293ffd4931a48118f4 (commit) via b36a0e1a59b92294cabe0ea33886f43f8ef1a5fe (commit) via e2d56c0b2b6b45af2926fe3c8b80c35868fb3738 (commit) via e4eee19747cb4c1bea2b71b9759a7bc940079492 (commit) via 91bdd9533b38f79e084dbfd34c7db4ada2b4041c (commit) via ed94450bd6bfa509b96d0c2dcd77a3b1cf20086c (commit) via c0d4313e571d44841cb2a472487e0616cd91c88f (commit) via 0ae70349809d51552e4297625db1382aa4e26dc5 (commit) via ff22cb46a5f6a1f75422c2a90e1f80ccb05c30b9 (commit) via 0d03f143e25f498de780d2ddd1972c3be7947519 (commit) via 5bb19808bb23a01a257a0970bd7e2ae43fb5b3d6 (commit) from c73b6d51dac3d07d32135f0f891cc6418101a53b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e98c178c081d4bb5673e6b04bf817b9c452cba8c Author: Aleisha Amohia Date: Tue Aug 29 05:02:29 2017 +0000 Bug 19195: Preventing noisy warns when creating or editing a basket To test: 1) Open the koha intranet error log 2) Go to Acquisitions -> Find or create a vendor 3) Create a new basket, filling all fields 4) Notice warns in error log 5) Edit this basket 6) Notice warns in error log 7) Apply patch 8) Create another basket, confirm warns do not show 9) Edit this basket, confirm warns do not show Sponsored-by: Catalyst IT Signed-off-by: Jonathan Druart commit 6ce1cc6aada33d7f72b8d3b0b9af4add65a93842 Author: Dobrica Pavlinusic Date: Mon Sep 18 17:37:21 2017 +0200 Bug 19332 - Basket grouping PDF and CSV exports empty This bug was introduced in commit 2bf3ce268de6bc8b2386cfb5d768f60b05d75f44 Bug 17196: [QA Follow-up] Additional fix on acqui/basketgroup Signed-off-by: Lee Jamison Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 06b602b0976e2a8d53ff31f95a2213cbeb98e9cb Author: Aleisha Amohia Date: Tue Aug 29 21:21:00 2017 +0000 Bug 19180: [FOLLOW-UP] Renaming all instances of 'name' variable to 'booksellername' ... when referring to the name of the vendor. To test: 1) Confirm vendor shows on webpage title (tab name) 2) Confirm vendor shows in breadcrumbs 3) Confirm vendor shows in heading when viewing basket ('Basket x (1) for vendor') Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Caroline Cyr La Rose Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 438a3dea0c8ef1a5adcec58d8b97474d14ccca9b Author: Aleisha Amohia Date: Sun Aug 27 23:00:15 2017 +0000 Bug 19180: Add vendor name to breadcrumbs when closing an order To test: 1) Go to Acquisitions 2) Find a vendor and a basket 3) Click 'Close basket' button 4) Notice that on confirmation page, breadcrumbs are missing vendor 5) Apply patch and refresh page 6) Vendor name should now show 7) Confirm link to vendor works as expected Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 17c5b76597b9a356bc215a3682d7293e307fcc46 Author: Aleisha Amohia Date: Wed Aug 30 04:36:50 2017 +0000 Bug 16204: Show friendly error message if trying to edit record which no longer exists To test: 1) Create a record 2) Click Edit -> Edit record. open this in another tab 3) Delete the record in the original tab 4) Refresh the edit form in the other tab. Notice the software error 5) Apply patch and refresh page 6) There should be a nice error message with the form fields and buttons hidden. Confirm links work as expected. Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit a59eaa5277b60055df216373247efc654551d579 Author: Marc V?ron Date: Wed Sep 6 17:46:27 2017 +0200 Bug 18541: (QA follow-up) Add some POD for draw_guide_grid Add description to POD for draw_guide_grid Signed-off-by: Marcel de Rooy Amended: Moved the description from draw_guide_box to .._grid. Signed-off-by: Jonathan Druart commit 7f5e8668a75e2a75b638fbb39ca3b5576bcf76d3 Author: Marcel de Rooy Date: Wed Sep 6 16:14:26 2017 +0200 Bug 18541: [QA Follow-up] Add POD to Patroncard.pm Just adding the POD framework to make qa tools happy. The authors are encouraged to complete this information. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit c7ac741e6a5d5e9bf4fb96dda3e4fabeace7f025 Author: Marc V?ron Date: Wed Sep 6 15:56:55 2017 +0200 Bug 18541: (QA follow-up) Fix wrong variable name ($layout_xml vs $print_layout_xml) This patch changes variable names as mentioned in comments #11 and #13 Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 45aea7ae1df815d241e7a34fbb5c42e9475f6d04 Author: Marc V?ron Date: Thu May 4 17:36:24 2017 +0200 Bug 18541 - Patron card creator: Add a grid to support layout design Add a layout grid to patron card creator to figure out the positions of text fields, barcode and images. To test: - Apply on top of patch 18465 - Go to Home > Tools > Patron card creator - Edit or create a layout - Turn on new choice 'Guide grid' in section 'General settings' - Leave 'Units' unchanged - Crate a PDF using 'Card batches' - Notice that card is printed with a layout grid that reflects selected unit with each 5th and 10th line in different color, unit description displayed bottom left, card dimensions displayed top right in small print inside the layout grid - Print PDF. Set printer settings in Adobe Reader or other PDF printing software to 'Actual size' to prevent scaling to printer's printable region - Mesure out printed PDF and verify that grid corresponds to selecte unit. - Go back to layout definition and choose an other unit, repeat steps to verify that grid respects selected unit. - Go back to layout definition, turn grid off, create PDF, verify that grid does not display in PDF Note for testers / QAers: Position of card elements (text, image...) do not respect the unit, this will be fixed in Bug 18550 Followed test plan and it worked as intended Signed-off-by: Alex Buckley Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 9355e5204074349c232c58caa678a8ab40c18efe Author: Owen Leonard Date: Tue Jun 6 18:35:07 2017 +0000 Bug 18739 - Add SVG version of staff-home-icons-sprite image Images display correctly. Followed test plan and patch works as described. Signed-off-by: Dilan Johnpull? Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart commit 83704cb1fab33feb0262fdab99bccf0052243d14 Author: Owen Leonard Date: Thu Jun 8 16:01:32 2017 +0000 Bug 15644 - City dropdown default selection when modifying a patron matches only on city This patch modifies the include files which contain the form fields for city, state, zipcode, etc. shown on the patron entry screen. The files are modified so that the city/state/zip