[koha-commits] main Koha release repository branch master updated. v17.05.00-534-gecf6ca5
Git repo owner
gitmaster at git.koha-community.org
Fri Sep 1 22:22:44 CEST 2017
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via ecf6ca5d6e1472bab68f174ab50a20eec6b74888 (commit)
via c758e222428ba6ad69b3d52ee6030d02e17ae964 (commit)
via be4f624b326574a14260c94c90aeb10a9ab56d91 (commit)
via ba1f2f93ef58c8dd935add3e215facdd4a589d12 (commit)
via fba915e911a3b50ff9a0ea96d25a464836471073 (commit)
via a6de2b66d19b8418dcb792c23e17b211e4c17719 (commit)
via 49778103ce528ccfc7fcc8be26bcae3b4ae7815b (commit)
from 185927f20981f36757c97fd33cc4c8ccd0ad5a3a (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit ecf6ca5d6e1472bab68f174ab50a20eec6b74888
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed May 31 13:58:27 2017 +0000
Bug 18708 [Revised] Show itemBarcodeFallbackSearch results in a modal window
This patch modifies the circulation template so that
itemBarcodeFallbackSearch results show in a modal window.
To test, enable the itemBarcodeFallbackSearch system preference and open
a patron's account in circulation.
- Submit a string which will return search results. When the page
reloads a modal should display showing a table of title search
results.
- Test the "Check out" button and confirm that the correct item is
submitted.
- Test closing the modal and re-displaying it using the new "Show
matching titles" button.
- Confirm that the "Add record using fast cataloging" button still
works correctly.
- Submit a string which will return no results. No modal window should
display, and only the "Add record" button should appear.
- Confirm that normal checkout works correctly.
- Test with itemBarcodeFallbackSearch disabled, and with a user who
lacks Fast Cataloging permission.
Revision removes a heading which was made redundant by the modal markup.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c758e222428ba6ad69b3d52ee6030d02e17ae964
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Jan 19 20:14:51 2017 +0100
Bug 17967: TT syntax for notices - Prove that ODUE is compatible
Nothing new here, unless we are introducing a regression.
The items.fine is a trick of our historical syntax.
We need to provide a way to access this value from the a notice template
using the TT syntax.
A bug 17976 has been opened for discussion.
Test plan:
Define ODUE and OVERDUES_SLIP notice templates and use it to generate
overdue notices from the cronjob script (misc/cronjobs/overdue_notices.pl)
or the interface (members/print_overdues.pl).
You should be able to generate the same notices with and without using
the TT syntax
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit be4f624b326574a14260c94c90aeb10a9ab56d91
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jan 17 04:32:58 2017 +0100
Bug 17966: TT syntax for notices - Prove that ISSUESLIP is compatible
Here we go, you will notice at the dependency list that this one is a
bit different.
In our former syntax we have 2 custom tags <checkedout> and <overdue>.
These tags were allowed to permit loop on the checked out items and the
overdue items.
In this patch, we will use the "loops" parameter, introduced by bug
17971, to pass the list of checkouts and overdues to the template.
Note that Kyle suggested another approach on bug 15283: all the
checkouts were send into the same array and each element of this
array calls the is_from_today method, to know if the checkout is an
overdue.
I don't think we should rely on the Koha API, that's why I suggest to
pass 2 differents object list, 1 which contains the checkouts and
another one with the overdues.
Note that we do rely on the Koha API, we call the Koha::Checkout->item
and Koha::Item->biblio to propose an equivalent TT notice. But I think
we can accept that.
Test plan:
Define the ISSUESLIP and ISSUEQSLIP notice templates to generate the
same notices you generated with the historical syntax.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
https://bugs.koha-community.org/show_bug.cgi?id=17969
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ba1f2f93ef58c8dd935add3e215facdd4a589d12
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Aug 2 12:46:11 2017 -0300
Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace
GetReserveId can easily be replaced with a call to
Koha::Holds->search->next->reserve_id
It will ease next changes to use Koha::Hold objects
Test plan:
Cancel a reserve and print a slip reserve
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit fba915e911a3b50ff9a0ea96d25a464836471073
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Aug 2 12:00:00 2017 -0300
Bug 19057: Remove C4::Reserves::GetReserve
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit a6de2b66d19b8418dcb792c23e17b211e4c17719
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Aug 2 12:21:20 2017 -0300
Bug 19057: Move C4::Reserve::GetReserve to Koha::Holds
This GetReserve subroutine can be replaced with Koha::Holds->find
Test plan:
- git grep GetReserve
must not return results where GetReserve is called
- Cancel a reserve
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 49778103ce528ccfc7fcc8be26bcae3b4ae7815b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Sep 1 16:20:18 2017 -0300
Bug 9857: Fix failing tests
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
-----------------------------------------------------------------------
Summary of changes:
C4/ILSDI/Services.pm | 6 +-
C4/Letters.pm | 6 +
C4/Members.pm | 58 +++--
C4/Overdues.pm | 3 +
C4/Reserves.pm | 162 +++++-------
Koha/REST/V1/Hold.pm | 18 +-
koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 18 +-
.../prog/en/modules/circ/circulation.tt | 89 +++++--
.../intranet-tmpl/prog/js/pages/circulation.js | 4 +
t/SuggestionEngine_AuthorityFile.t | 2 +-
t/db_dependent/Circulation.t | 4 +-
t/db_dependent/Circulation/issue.t | 5 +-
t/db_dependent/Holds.t | 99 +++----
t/db_dependent/Items/MoveItemFromBiblio.t | 13 +-
t/db_dependent/Letters/TemplateToolkit.t | 274 +++++++++++++++++++-
t/db_dependent/Reserves.t | 10 +-
t/db_dependent/SuggestionEngine_ExplodedTerms.t | 4 +-
17 files changed, 527 insertions(+), 248 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list