[koha-commits] main Koha release repository branch 17.05.x updated. v17.05.03-17-ga21f8a5

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.05.x has been updated
       via  a21f8a552ba5798342eca04a534ea9a1503b7843 (commit)
       via  a17aa443b101f15be2b27a4bd45faa6473818247 (commit)
       via  1f83e41f2e9d92027401b6ffc8ebe052fe0beab3 (commit)
       via  efd3acb03e345a4e5c7f576038ed14961bbab3d6 (commit)
       via  4c50a19ab920b488193d78ee18d89bb143ddae4a (commit)
      from  a0bc776e67569b83dc3d5bc47069ceb1408badb2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a21f8a552ba5798342eca04a534ea9a1503b7843
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Aug 15 12:16:33 2017 -0300

    Bug 18624: Do not return 1 in tests
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 03c5eb0babc3fd7b0ecf45a8a5db91a67718d3b4)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit a17aa443b101f15be2b27a4bd45faa6473818247
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Aug 7 16:23:24 2017 -0300

    Bug 18624: (followup) opac-authorities-home.tt uses 'any'
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 9d7d524f21fbf83ef7e1031e36c9772ffe21db90)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 1f83e41f2e9d92027401b6ffc8ebe052fe0beab3
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Jun 16 09:53:39 2017 -0400

    Bug 18624: Run time errors when searching authorities with Elastic search 5.3
    
    It seems we have a syntax mismatch - any vs all
    
    all seems to the be list we expect so updating code that way
    
    To test:
    1 - Enabled Elasticsearch
    2 - Index some authorities
    3 - Perform a 'Search entire record' search
    4 - Internal server error (
            Invalid marclist field provided: all at
            /usr/local/koha/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
            line 433.
            )
    5 - Run:
        $ sudo koha-shell kohadev
       k$ cd kohaclone
       k$ prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
    => FAIL: Tests fail because 'any is used'
    6 - Apply patch
    7 - Search should work
    8 - Run:
       k$ prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
    => SUCCESS: Tests pass!
    9 Sign off :-D
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Edited the test plan so it mentions the new tests
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit cfb52579ec2f8859226e0e40f66d5a6d7a2ed73f)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit efd3acb03e345a4e5c7f576038ed14961bbab3d6
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Aug 7 16:09:56 2017 -0300

    Bug 18624: Regression test for 'any' vs 'all'
    
    This test makes it explicit that the only string producing _all as index on build_authorities_query_compat is 'all'.
    To test:
    - Apply this patch
    - Run:
      $ sudo koha-shell kohadev
     k$ cd kohaclone
     k$ prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
    => FAIL: Test fails because the list of valid values is wrong in Koha.
    
    Note: this list has to be in sync with the templates passing the same values. A followup will be added
    to fix a discrepancy found between OPAC and Intranet.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit b308b0814bcd149e3f899058e693938d982bb425)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 4c50a19ab920b488193d78ee18d89bb143ddae4a
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Aug 7 16:07:40 2017 -0300

    Bug 18624: Minor refactoring to ease testing
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit ff41b87302c1b242f9edd7b2e8c253bd18b57ac1)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/SearchEngine/Elasticsearch/QueryBuilder.pm    |   27 +++++-----
 .../bootstrap/en/modules/opac-authorities-home.tt  |    2 +-
 .../Koha/SearchEngine/Elasticsearch/QueryBuilder.t |   55 ++++++++++++++++++++
 3 files changed, 70 insertions(+), 14 deletions(-)
 create mode 100644 t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t


hooks/post-receive
-- 
main Koha release repository