[koha-commits] main Koha release repository branch master updated. v17.05.00-561-gb465362

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  b4653629f63d410326036cef5aa8a70c55d17f45 (commit)
       via  ad9f89c6c32ba8e8fc52566d5e8c7e5b8c9d43e9 (commit)
       via  3aeb1fc7e85e01cebf7ef726ea1d877b7b0edab6 (commit)
      from  b56c19528e332381384639ed347d11508086c547 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit b4653629f63d410326036cef5aa8a70c55d17f45
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Wed Sep 6 14:45:00 2017 -0300

    Bug 19256: (QA followup) Add missing POD
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit ad9f89c6c32ba8e8fc52566d5e8c7e5b8c9d43e9
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Wed Sep 6 10:15:55 2017 -0400

    Bug 19256: (QA followup) Remove warn from unit test
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 3aeb1fc7e85e01cebf7ef726ea1d877b7b0edab6
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Sep 5 10:15:59 2017 -0300

    Bug 19256: Make Koha::Acq::Order using Koha::Object
    
    At the moment we have 2 different modules for acquisition orders:
    Koha::Tmp::Order[s] and Koha::Acquisition::Order
    The later has been added before the creation of Koha::Object.
    Koha::Tmp::Order[s] has been created to make the TT syntax for notices
    works with acquisition order data.
    
    This patch removes the temporary packages Koha::Tmp::Order[s] and adapt
    the code of Koha::Acquisition::Order[s] to be based on Koha::Object[s].
    
    It also overloads Koha::Object->new to add the trick that was done in
    Koha::Acquisition::Order->insert. This is needed because acqui/addorder.pl
    is called from several places and CGI->Vars is used to retrieved order's
    attributes (and so much more). To avoid regression, the easiest (but not
    cleanest) way to do is to filter on aqorders column's names.
    This is *not* a pattern to follow!
    
    Test plan:
    Create basket and add orders from different ways, then continue a whole
    acquisition process
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-----------------------------------------------------------------------

Summary of changes:
 C4/Acquisition.pm                                  |   13 +-
 C4/Letters.pm                                      |    2 +-
 Koha/Acquisition/Order.pm                          |  124 +++++++++++---------
 Koha/{Tmp => Acquisition}/Orders.pm                |   18 +--
 Koha/Tmp/Order.pm                                  |   44 -------
 acqui/addorder.pl                                  |    5 +-
 acqui/addorderiso2709.pl                           |    6 +-
 acqui/finishreceive.pl                             |    5 +-
 admin/currency.pl                                  |    6 +-
 t/db_dependent/Acquisition.t                       |   17 +--
 t/db_dependent/Acquisition/CancelReceipt.t         |   22 ++--
 t/db_dependent/Acquisition/GetBasketAsCSV.t        |    6 +-
 .../Acquisition/GetBasketsInfosByBookseller.t      |   10 +-
 .../Acquisition/GetOrdersByBiblionumber.t          |   14 +--
 t/db_dependent/Acquisition/Invoices.t              |   20 ++--
 t/db_dependent/Acquisition/NewOrder.t              |   16 +--
 t/db_dependent/Acquisition/OrderFromSubscription.t |    8 +-
 t/db_dependent/Acquisition/OrderUsers.t            |   15 ++-
 t/db_dependent/Acquisition/StandingOrders.t        |   29 +++--
 t/db_dependent/Acquisition/TransferOrder.t         |    8 +-
 t/db_dependent/Acquisition/close_reopen_basket.t   |   12 +-
 t/db_dependent/Bookseller.t                        |   18 +--
 t/db_dependent/Budgets.t                           |   12 +-
 t/db_dependent/Letters.t                           |    6 +-
 t/db_dependent/UsageStats.t                        |    2 +-
 25 files changed, 203 insertions(+), 235 deletions(-)
 rename Koha/{Tmp => Acquisition}/Orders.pm (79%)
 delete mode 100644 Koha/Tmp/Order.pm


hooks/post-receive
-- 
main Koha release repository