[koha-commits] main Koha release repository branch 17.05.x updated. v17.05.03-35-g92b08a2

Git repo owner gitmaster at git.koha-community.org
Tue Sep 12 16:06:59 CEST 2017


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.05.x has been updated
       via  92b08a23e3b2c001d208b82b6ffee2af756ca51f (commit)
       via  1865db52bbf9413574c22ee2c9180137ac357918 (commit)
       via  aca614cd95b32d2953927e8e3e908bc1248b541c (commit)
      from  d179da572b1d6bd7066d96f494aa805b86b92ae1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 92b08a23e3b2c001d208b82b6ffee2af756ca51f
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Thu Jul 6 08:48:18 2017 +0200

    Bug 18900: wrong number format in receiving order
    
    Bug 18471 added number formating in order receive.
    
    I found a bug generated by this.
    Koha::Number::Price defines methods to (un)format price depending on CurrencyFormat syspref.
    The bug is that for CurrencyFormat US, some params are not defined in this module so there are retrieved from system locale. If system locale is not en_US, the params will be wrong. For example fr_FR will define ',' as decimal and so saved unit price is divided by 1000.
    
    To recreate:
    - On a server with locale 'fr_FR'
    - With Plack mode
    - Set CurrencyFormat on 'US'
    - Open a basket
    - Place an order for an item
    - Close basket
    - Receive order with changing 'Actual Cost' to '1,234'
    - Note the 'Actual Cost' is now '1.23'
    - Run unit test t/Number/Price.t without and with patch
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit e35903574ce666bca32eb4676f311b99bb268ec2)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 1865db52bbf9413574c22ee2c9180137ac357918
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Wed Aug 9 12:01:17 2017 -0300

    Bug 18900: (QA followup) Make tests conditional to locale existence
    
    It is important to highlight that tests have been skipped instead of having them pass
    on the absence of the required fr_FR.UTF-8 locale installed on the system.
    
    This patch does that check and effectively skips them.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 61f2ec769073709be3b688654ec355b3f4fbe522)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit aca614cd95b32d2953927e8e3e908bc1248b541c
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Thu Jul 6 08:44:51 2017 +0200

    Bug 18900: add UT to Number/Price.t
    
    This patch adds unit tests to t/Number/Price.t in order to valid the problem.
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 91dee226cdd089353dc71e559aa9e0b34fddf72e)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/Number/Price.pm |    3 +++
 t/Number/Price.t     |   22 +++++++++++++++++++++-
 2 files changed, 24 insertions(+), 1 deletion(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list