[koha-commits] main Koha release repository branch master updated. v17.05.00-593-gc73b6d5
Git repo owner
gitmaster at git.koha-community.org
Tue Sep 12 17:50:30 CEST 2017
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via c73b6d51dac3d07d32135f0f891cc6418101a53b (commit)
via c43a555dbce3a50a752cdf397379766c46fb3555 (commit)
via adf4077b39c96bd353fb733b3e8093550cb9db09 (commit)
via 71b9dc1e3932db29e8fa7a32dd25e7e54c95f228 (commit)
via db5848bf2a5b5f881a1cf59fb794ecfd01841c8d (commit)
via a86d7fd3d097987da8e97054ff37e3061eeb9811 (commit)
via 82115d164a15767965d267826cc64e74132bd374 (commit)
from 5400795a6651adc021801052fa0186747983b587 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit c73b6d51dac3d07d32135f0f891cc6418101a53b
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Thu Sep 7 14:34:18 2017 +0200
Bug 19059: [QA Follow-up] Typo holds for hold
Resolves:
The method found is not covered by tests at C4/Reserves.pm line 815.
Test plan:
Run t/db_dependent/Holds/CancelReserves.t
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c43a555dbce3a50a752cdf397379766c46fb3555
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Sep 1 16:50:26 2017 -0300
Bug 19059: Fix compilation issues
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit adf4077b39c96bd353fb733b3e8093550cb9db09
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Aug 7 15:13:17 2017 -0300
Bug 19059: Remove CancelReserve
It's done!
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 71b9dc1e3932db29e8fa7a32dd25e7e54c95f228
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Aug 4 10:44:56 2017 -0300
Bug 19059: Remove CancelReserve - do not log DELETE
There is something wrong with the DELETE log, it should be replaced with
a FILLED log.
Anyway, here we do not want it to be logged.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit db5848bf2a5b5f881a1cf59fb794ecfd01841c8d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Aug 3 18:00:22 2017 -0300
Bug 19059: Remove CancelReserve - add new tests
This is bonus, let's add new tests
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit a86d7fd3d097987da8e97054ff37e3061eeb9811
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Aug 3 15:12:25 2017 -0300
Bug 19059: Remove CancelReserve - move tests
Move the existing tests
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 82115d164a15767965d267826cc64e74132bd374
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Aug 2 14:00:12 2017 -0300
Bug 19059: Move C4::Reserves::CancelReserve to Koha::Hold->cancel
This patch adds a new Koha::Hold->cancel method and replaces the calls
to C4::Reserves::CancelReserve with it.
Test plan:
- Add and cancel holds
- Change priority of holds
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
-----------------------------------------------------------------------
Summary of changes:
C4/Biblio.pm | 3 +-
C4/ILSDI/Services.pm | 2 +-
C4/Reserves.pm | 111 ++++---------
C4/SIP/ILS/Transaction/Hold.pm | 14 +-
Koha/Hold.pm | 58 ++++++-
Koha/Patron/Discharge.pm | 3 +-
Koha/REST/V1/Hold.pm | 2 +-
circ/branchtransfers.pl | 23 ++-
circ/returns.pl | 6 +-
circ/waitingreserves.pl | 2 +-
opac/opac-modrequest.pl | 6 +-
reserve/request.pl | 3 +-
t/db_dependent/Circulation.t | 4 +-
t/db_dependent/Holds.t | 68 +++-----
t/db_dependent/Holds/HoldFulfillmentPolicy.t | 19 +--
t/db_dependent/Holds/HoldItemtypeLimit.t | 8 +-
t/db_dependent/HoldsQueue.t | 25 +--
t/db_dependent/Koha/Holds.t | 222 ++++++++++++++++++++++++++
t/db_dependent/Reserves.t | 93 +----------
t/db_dependent/UsageStats.t | 2 +-
tools/batch_delete_records.pl | 2 +-
21 files changed, 403 insertions(+), 273 deletions(-)
create mode 100644 t/db_dependent/Koha/Holds.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list