[koha-commits] main Koha release repository branch 17.05.x updated. v17.05.04-35-g9f8cdea

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.05.x has been updated
       via  9f8cdead6e29f029e01038ecb4fbd6216544e996 (commit)
      from  b3e2933f5c36101784a1780444dd619655ee7ea2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 9f8cdead6e29f029e01038ecb4fbd6216544e996
Author: Magnus Enger <magnus at libriotech.no>
Date:   Thu Aug 17 22:48:07 2017 +0200

    Bug 19134: C4::SMS falils on long driver name
    
    Code in C4::SMS takes the part of the SMS::Send-driver that comes after
    SMS::Send and tries to turn it into part of a path to a YAML file
    that can contain additional parameters to SMS::Send. The current
    code works for e.g. SMS::Send::A::B, but if there is one or more
    extra names, it fails to turn :: into /. So we have:
    SMS::Send::A::B    -> SMS/Send/A/B
    SMS::Send::A::B::C -> SMS/Send/A/B::C
    This patch makes sure all occurrences of :: are turned into /, by
    adding a "g" modifier at the end of the regex.
    
    Testing:
    Testing this preperly would take a whole lot of setup for a very
    small change. I would suggest that the following two oneliners
    are enough to demonstrate that the change makes sense:
    $ perl -e '$x = "a::b::c"; $x =~ s|::|/|; print $x, "\n";'
    $ perl -e '$x = "a::b::c"; $x =~ s|::|/|g; print $x, "\n";'
    
    So:
    - Check that the output of these oneliners make sense
    - Check that the patch changes the code in a similar way to the
      change from the first oneliner to the second.
    
    Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit a4237785d9a2bf2bbf4cf988bc98ac4935842e91)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/SMS.pm |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


hooks/post-receive
-- 
main Koha release repository