[koha-commits] main Koha release repository branch master updated. v17.11.00-1018-g92c1eb7
Git repo owner
gitmaster at git.koha-community.org
Mon Apr 2 23:21:42 CEST 2018
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 92c1eb7db3d46c1495afd6181514be72bdb703c2 (commit)
via a08ad004942a79b7781c2a5cabc21d6cb468006a (commit)
via d2d16d6f850adf1e2b528f4ded6de174921b2a03 (commit)
via 6ac49d9cdac831f6b72d675aa1436fd9e264be92 (commit)
via 52f58f2ec0e9f0270c807cccd95749e853a8d64a (commit)
via 2c2e29463a73fa1ece1808378013160347036143 (commit)
via 0d255e42241008f028a55fec7eede0a61075c547 (commit)
via 97a7420735a8304bc8dbb6e123461837da921870 (commit)
via c7bde81dd8444dfe099d66d89731ef281744341f (commit)
via 769ae66d5e0b50ba7d806e32ade347737b2a7ebc (commit)
via 7b1dc1b6089c88755a66d2e23215a86622a82f0b (commit)
via 2fff1c66a73161e9969ed4354e4824c589daf19e (commit)
via 9b6e65d3fd28d78a3c0182ee50b6cf3dc6d3a7a2 (commit)
via fc033fa03758b4a1a106b295bb0a0cab2fb00738 (commit)
via 9a07da768c52c0f79130b465bc46a8578c80c487 (commit)
via 2deaead2566a62ce7772cd15a5ffbeb6216a539a (commit)
via d5afc40805cc8ede026fcb52629a183388bd25cd (commit)
via d55a7eb316e699c32178cbde9d60b6005c4d3e98 (commit)
via a251be4b80bda3392cde16826cc6c52ff421174e (commit)
via adf1835890f5aba60c587c3e905bbd1e003a417c (commit)
via e4cdd58b188e785a6d00cf3b7de0e9021d2489c6 (commit)
via 83b364ec56ae94a077542691f790d6153d90c4d1 (commit)
via 391bc7623c25c46111719e3988f110e2cc2174a9 (commit)
via 9dcdd49b6b383730191334a01794f7b8318a537e (commit)
via bba218444e9e475981670f1663d341204d1e67ce (commit)
via 6ef1e5d4edff50afd571e7b3d9bfc7ab078e90bd (commit)
via d22a1308d52fb55ebe280f545d1f3718aa16cbdf (commit)
via 6560a9a706686d4a28d23f15d223bbc88c0b5c50 (commit)
from 08039f41c196f9119e5ca82f762e5260d8c81a1a (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 92c1eb7db3d46c1495afd6181514be72bdb703c2
Author: Roch D'Amour <roch.damour at inlibro.com>
Date: Thu Feb 22 16:08:59 2018 -0500
Bug 18820: Main block size now adjust to OpacNavRight like it would for opacuserlogin
Test plans :
- "beforepatch.png" shows the result you get when OpacNavRight and opacnav are set to false.
- "opacuserlogin=f_opacnav=f.png" shows the result with the patch and OpacNavRight and opacnav set to false
- "opacuserlogin=t_opacnav=f.png" shows the result with the patch and OpacNavRight set to true and opacnav set to false
Applied patch, can confirm it functions as expected.
Signed-off-by: Dilan Johnpullé <dilan at calyx.net.au>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit a08ad004942a79b7781c2a5cabc21d6cb468006a
Author: Paudet <philippe.audet-fortin at inlibro.com>
Date: Mon Jun 19 09:27:15 2017 -0400
Bug 18820: Adding lines that check if opacuserlogin is enable and if OpacNav has content.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Dominic Pichette <dominic at inlibro.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d2d16d6f850adf1e2b528f4ded6de174921b2a03
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Mar 29 16:12:28 2018 -0300
Bug 20497: Access LibraryThing assets using HTTPS
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 6ac49d9cdac831f6b72d675aa1436fd9e264be92
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Mar 27 16:46:16 2018 +0000
Bug 19892: (follow-up) Replace one more instance
This patch replaces one more instance of [% IF ( numbersphr ) %].
To test, apply the patch and view the source of the OPAC home page.
With the OPACNumbersPreferPhrase system preference set to 'use,' you
should find this in the HTML source:
<option value="callnum,phr">Call number</option>
With the preference set to 'don't use,' you should find this:
<option value="callnum">Call number</option>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 52f58f2ec0e9f0270c807cccd95749e853a8d64a
Author: Charlotte Cordwell <charlotte.cordwell123 at gmail.com>
Date: Thu Jan 18 01:29:05 2018 +0000
Bug 19892: Replace numbersphr variable with Koha.Preference('OPACNumbersPreferPhrase') in OPAC
Test Case
1) Check that the following files have been changed properly.
opac/opac-search.pl
opac/opac-main.pl
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
2)Apply bug
3) Check that there are no differences in behaviour as a result of the patch.
Signed-off-by: Roch D'Amour <roch.damour at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 2c2e29463a73fa1ece1808378013160347036143
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Apr 2 18:05:39 2018 -0300
Bug 20291: DBRev 17.12.00.025
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 0d255e42241008f028a55fec7eede0a61075c547
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Mar 29 10:14:59 2018 +0000
Bug 20291: (follow-up) Rename NoLoginInstructions to OpacLoginInstructions
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 97a7420735a8304bc8dbb6e123461837da921870
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Feb 27 10:45:46 2018 +0000
Bug 20291: (follow-up) Add sysprefs.sql changes
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c7bde81dd8444dfe099d66d89731ef281744341f
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Feb 21 04:56:23 2018 +0000
Bug 20291: Add a StaffLoginInstructions preference for adding text to staff client login
To test:
1 - Apply patches
2 - Upgrade database
3 - Check the staff client login page, should be no change
4 - Add something to the preferene
5 - It should appear on the login page
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 769ae66d5e0b50ba7d806e32ade347737b2a7ebc
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Mar 29 13:00:36 2018 +0000
Bug 20052: (follow-up) Fix QA tool complaints and bad copy
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7b1dc1b6089c88755a66d2e23215a86622a82f0b
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Jan 15 14:38:13 2018 +0000
Bug 20052: Add Koha Reports object class
To test:
prove -v t/db_dependent/Koha/Reports.t
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Maksim Sen <maksim.sen at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 2fff1c66a73161e9969ed4354e4824c589daf19e
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Wed Mar 28 19:58:37 2018 +0000
Bug 18382: (QA follow-up) Make new unit test pass
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9b6e65d3fd28d78a3c0182ee50b6cf3dc6d3a7a2
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Mar 27 14:09:54 2018 -0300
Bug 18382: Add a test
This is what I am expecting but I may be wrong.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit fc033fa03758b4a1a106b295bb0a0cab2fb00738
Author: Kyle M Hall <kyle at bywatetsolutions.com>
Date: Tue Mar 27 10:45:09 2018 -0400
Bug 18382: (QA follow-up) Don't set suspend_until if dt if undefined
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9a07da768c52c0f79130b465bc46a8578c80c487
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Thu Mar 22 09:17:46 2018 +0100
Bug 18382: (QA follow-up) Replace ->ymd by ->datetime
The first patch makes Hold.t fail on:
not ok 8 - Hold is suspended with a date, truncation takes place automatically
Failed test 'Hold is suspended with a date, truncation takes place automatically'
at Hold.t line 94.
got: '2018-03-22'
expected: '2018-03-22T00:00:00'
We could remove the midnight time there, but we also could replace ymd by
datetime. The cpan doc tells us:
Same as $dt->ymd('-') . 'T' . $dt->hms(':')
Test plan:
With this patch, run Hold.t again. It should pass now.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 2deaead2566a62ce7772cd15a5ffbeb6216a539a
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Jun 5 10:46:45 2017 -0400
Bug 18382: action_logs entry for module HOLDS, action SUSPEND is spammy
When a hold is suspended, 'suspend_until' is represented as a DateTime object, complete with locale. All told, this is about 800 lines of text.
Test Plan:
1) Enable the HoldsLog syspref
2) Add a hold on a record/item
3) Suspend the hold with a date to resume
4) Note the massive amount of date in the suspend_until field
5) Apply this patch
6) Suspend another hold with a date to resume
7) Note the log has an acutal date in the suspend_until field
Check the logs using module 'Holds' and Action 'Suspend'
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d5afc40805cc8ede026fcb52629a183388bd25cd
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Mar 29 12:33:56 2018 +0000
Bug 20494: Remove unused code in neworderempty.pl and addbiblio.pl
Should be sufficient to read code and see all lines were commented and
that this patch removes useless lines
To be thorough, ensure that your can add an order to a basket and add a
biblio.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d55a7eb316e699c32178cbde9d60b6005c4d3e98
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Jul 19 20:29:26 2017 -0300
Bug 18979: Speed up 'valid-templates.t' tests
Test plan:
Confirm than prove xt/author/valid-templates.t is quicker with this
patch.
Before I got:
Files=1, Tests=840, 21 wallclock secs ( 0.18 usr 0.02 sys + 20.28 cusr
0.32 csys = 20.80 CPU)
After:
Files=1, Tests=840, 17 wallclock secs ( 0.06 usr 0.01 sys + 21.56 cusr
0.48 csys = 22.11 CPU)
Signed-off-by: David Bourgault <david.bourgault at inlibro.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit a251be4b80bda3392cde16826cc6c52ff421174e
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Feb 23 10:58:27 2018 +0000
Bug 20282: Match course reserve on holdingbranch
To test:
1 - Add a course (Course Reserves)
2 - Add an item to the course
3 - Ensure to change the holding branch for the course reserve
4 - Modify the course item
5 - Note the dropdwn for holding branch is unset
6 - Apply patch
7 - Modify the course item
8 - Dropdown should be correctly populated
Signed-off-by: Maksim Sen <maksim.sen at inlibro.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit adf1835890f5aba60c587c3e905bbd1e003a417c
Author: Kyle M Hall <kyle at bywatetsolutions.com>
Date: Mon Mar 12 07:15:12 2018 -0400
Bug 20369: Analytics search is broken with QueryAutoTruncate set to 'only if * is added'
Test Plan:
1) Enable EasyAnalytics
2) Disable QueryAutoTruncate
3) Create an analytic record, add some host items to it
4) Browser to the analytics tab for the record
5) Click the link in the 'used in' column of the table
6) No search results
7) Apply this patch
8) Reload the page, now you get the analytic record!
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e4cdd58b188e785a6d00cf3b7de0e9021d2489c6
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Wed Jan 3 11:20:46 2018 +0000
Bug 19907: Fix email validation in patron edit form
Test plan:
0) Confirm that email validation is not working in add/edit patron form
1) Apply the patch
2) Edit/add patron, the e-mail validation should be working now
3) Ensure the password validation is still working (use test plan from
bug 19908)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 83b364ec56ae94a077542691f790d6153d90c4d1
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Mar 26 12:22:15 2018 -0300
Bug 20462: Ensure batch item deletion will not delete the same item twice
This has been done on bug 9509 when barcodes are scaned, but not when using a text file.
Test plan (stolen from Barton on the bug report):
1) Create a text file containing duplicate barcodes
Here's a quick way to do that, substitute INSTANCE for the instance name of your test server:
sudo koha-mysql INSTANCE <<< "select barcode from items where barcode is not null limit 3" | sed '1d;p' > /tmp/dup_barcodes.txt
2) Go to Home › Tools › Batch item deletion
3) Click 'Choose File', select the file you created in step 1.
4) Click 'Continue'
5) Note that duplicate items appear in the list of items to batch delete
6) Check 'Delete records if no items remain'
7) This will trigger a software error
Note that entering the barcodes via the 'scan items one by one' text box removes duplicates in the list, so this only causes problems when uploading a file.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 391bc7623c25c46111719e3988f110e2cc2174a9
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Apr 2 14:30:23 2018 -0300
Bug 20318: Add class 'required' to the label
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9dcdd49b6b383730191334a01794f7b8318a537e
Author: Christophe Croullebois <christophe.croullebois at biblibre.com>
Date: Wed Mar 14 14:28:28 2018 +0000
Bug 20318: Merge invoices can lead to an merged invoice without Invoice number
When you want to merge invoices you have a page with a non editable
field 'Invoice number:' it shows the content of the first invoice to be
merged.
But if you validate by clicking the 'merge' button you arrive on the
next page which says that 'Invoice has been modified' and if you quit
this page without saving you have now a merged invoice without Invoice
number.
This tiny patch just prevents this issue to occur.
Test plan :
1° go to the acqui/invoices.pl page and search invoices to merge.
You must have at least 2 invoices on the same vendor
2° check boxes to select invoices to merge and click on 'merge selected
invoices' button
3° next page you see the non editable field 'Invoice number:'
4° click on the 'merge' button
5° next page you see 'Invoice has been modified'
6° leave this page i.e click on the left link 'Invoices'
7° search invoices you'll see the merged invoice without invoice number.
Apply the patch, replay the steps 1 to 3
4° on this page you can enter your invoice number and click on the
'merge' button.
If you leave this field empty and click merge, a message informs you
that it is required and you can not merge.
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit bba218444e9e475981670f1663d341204d1e67ce
Author: Kyle M Hall <kyle at bywatetsolutions.com>
Date: Fri Mar 30 07:08:30 2018 -0400
Bug 18474: (QA follow-up) Remove useless else in template
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 6ef1e5d4edff50afd571e7b3d9bfc7ab078e90bd
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Dec 21 15:59:24 2017 -0300
Bug 18474: Restore multiple holds when patron is searched for
We lost the ability to place multiple holds when we are searching for
patrons. The multi_holds parameter is lost and not handled correctly in
the template.
Test plan:
- Make sure you can place multiple holds for a patron you will search for
- Same for simple hold
TODO the multiple holds view should not be displayed if only 1 record
has been selected from the search result.
Signed-off-by: claude brayer <claude.brayer at cea.fr>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d22a1308d52fb55ebe280f545d1f3718aa16cbdf
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Mar 23 17:12:13 2018 +0000
Bug 20385: (follow-up) Assign blank instead of inappropraite value
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 6560a9a706686d4a28d23f15d223bbc88c0b5c50
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Mar 13 14:57:47 2018 +0000
Bug 20385: Don't try to get info for bad authtypecodes
TO test:
0 - Have a koha with ES enabled and some auth records
1 - backup your db
2 - sudo koha-mysql <<instance>>
3 - UPDATE auth_types SET authtypecode="PERSO_NAMB" WHERE
authtypecode="PERSO_NAME" (or adjust as necessary)
4 - Search for some authorities where a PERSO_NAME record will be
returned
5 - KA_BOOM!
6 - Apply patch
7 - Results are returned, they do not display a code, viewing record you
won't see code
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
-----------------------------------------------------------------------
Summary of changes:
C4/Search.pm | 2 +-
Koha.pm | 2 +-
Koha/Hold.pm | 5 ++--
Koha/{ClassSource.pm => Report.pm} | 6 ++--
Koha/{ClassSources.pm => Reports.pm} | 12 ++++----
Koha/SearchEngine/Elasticsearch/Search.pm | 8 ++----
acqui/neworderempty.pl | 6 ----
cataloguing/addbiblio.pl | 6 ----
installer/data/mysql/sysprefs.sql | 3 +-
installer/data/mysql/updatedatabase.pl | 16 +++++++++++
.../en/includes/circ-patron-search-results.inc | 13 ++++++---
.../intranet-tmpl/prog/en/modules/acqui/invoice.tt | 2 +-
.../prog/en/modules/acqui/invoices.tt | 8 ++++--
.../admin/preferences/enhanced_content.pref | 2 +-
.../prog/en/modules/admin/preferences/opac.pref | 2 +-
.../en/modules/admin/preferences/staff_client.pref | 5 ++++
koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt | 1 +
.../en/modules/course_reserves/add_items-step2.tt | 2 +-
.../prog/en/modules/members/memberentrygen.tt | 12 --------
.../prog/en/modules/reserve/request.tt | 5 ++++
koha-tmpl/intranet-tmpl/prog/js/members.js | 7 +++++
.../opac-tmpl/bootstrap/en/includes/masthead.inc | 8 +++---
.../bootstrap/en/modules/opac-advsearch.tt | 4 +--
.../opac-tmpl/bootstrap/en/modules/opac-auth.tt | 6 ++--
.../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 24 ++++------------
.../opac-tmpl/bootstrap/en/modules/opac-main.tt | 12 +++++---
.../opac-tmpl/bootstrap/en/modules/opac-results.tt | 6 +---
opac/opac-main.pl | 4 ---
opac/opac-search.pl | 3 --
reserve/request.pl | 11 +++----
t/db_dependent/Hold.t | 5 +++-
.../Koha/{Acquisition/Funds.t => Reports.t} | 30 +++++++++++---------
tools/batchMod.pl | 1 +
xt/author/valid-templates.t | 17 +++++++++++
34 files changed, 135 insertions(+), 121 deletions(-)
copy Koha/{ClassSource.pm => Report.pm} (89%)
copy Koha/{ClassSources.pm => Reports.pm} (81%)
copy t/db_dependent/Koha/{Acquisition/Funds.t => Reports.t} (51%)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list