[koha-commits] main Koha release repository branch master updated. v17.11.00-1210-gf553d76

Mon Apr 16 19:19:59 CEST 2018

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  f553d76600e967b4492f03494f34170c8cf5d83e (commit)
       via  d0b0732c970f09781ca4bf6d90f0302e93c418ff (commit)
       via  4c14c4998dc7eeb79a02911d8ed37db5393f3de8 (commit)
       via  84fe9a2adeafb7d0393779bcfafdbd49e25736dd (commit)
       via  f95c7845fecaefd6e7c2fd68f2381710f1ebc7a4 (commit)
       via  3f983c7249f2141a2908f1cef4e9c5a0c2ba282d (commit)
       via  a4ccd04d066ab304619c34adf15f9124e1cf6ee6 (commit)
       via  84327359787fe681e4ae456df330bcb4591f6291 (commit)
       via  f4c1e91a2fce18dca1708fe933f142541ea2190d (commit)
       via  38132cabbb88a51b3b457972dc7119eecdc9cfb5 (commit)
       via  8ad45474324b672fb48d8b7af83a94184cd1b2f9 (commit)
      from  77853e2e538a8503d1283331d4b1dc743a3e1591 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit f553d76600e967b4492f03494f34170c8cf5d83e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Apr 16 14:09:03 2018 -0300

    Bug 11674: DBRev 17.12.00.031

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit d0b0732c970f09781ca4bf6d90f0302e93c418ff
Author: Pasi Kallinen <pasi.kallinen at joensuu.fi>
Date:   Thu Feb 1 12:00:02 2018 +0200

    Bug 11674: Configuration for MARC field doc URLs

    Add a new system preference MarcFieldDocURL. Setting it to some URL
    will make all the MARC documentation links point to that in
    the MARC edit UI. Leaving the value empty will use the old defaults
    (http://loc.gov for MARC21 and http://archive.ifla.org for UNIMARC).

    There are some possible substitutions usable in the URL:
     - {MARC} is replaced with either "MARC21" or "UNIMARC"
     - {FIELD} is replaced by the MARC field number, eg. "000", "048", ...
     - {LANG} is replaced by the UI language, eg. "en", or "fi-FI"

    To test:

    1) Go to Cataloguing > New record
    2) Clicking on the question mark links in the MARC edit will
       open a window to either loc.gov or archive.ifla.org
    3) Install patch, run updatedatabase, etc
    4) Redo parts 1, and 2.
    5) Set the value of MarcFieldDocURL to
       http://example.com/?field={FIELD}&marc={MARC}&lang={LANG}
    6) Redo parts 1 and 2
    7) Clicking on the question mark links in the MARC edit will
       open a window to example.com, with the proper substitutions
       in the URL for the field, marc flavour and language

    Signed-off-by: Pasi Kallinen <pasi.kallinen at joensuu.fi>

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 4c14c4998dc7eeb79a02911d8ed37db5393f3de8
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Fri Apr 13 11:43:21 2018 +0000

    Bug 18007: Interface updates to notices and notice previews

    This patch makes changes to the form for adding and editing notices, and
    to the template for viewing a rendered preview of notices.

    - Preview now shows side-by-side comparisons
    - JavaScript has been movied out of template into separate file
    - Validation of the add/edit form improved through use of validation
      plugin

    To test, apply the patch on top of those for Bug 17981

    - Add a new notice.
      - Confirm that the form can't be submitted without data in the "code"
        and "name" fields.
      - Confirm that the form can't be submitted without filling in at least
        one message template (subject and body).
      - Confirm that you cannot submit the form while using an
        existing notice code.
      - Follow Bug 17981's test plan for testing the preview function.
        Confirm that the preview loads correctly and looks correct.
        - Test both with old syntax messages which require conversion and
          messages in template-toolkit syntax.

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Fixed conflicts caused by bug 20538.

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 84fe9a2adeafb7d0393779bcfafdbd49e25736dd
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Mon Apr 16 00:25:56 2018 +0200

    Bug 20515: (QA follow-up) Fix capitalization on 'Ill Requests'

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit f95c7845fecaefd6e7c2fd68f2381710f1ebc7a4
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date:   Fri Apr 13 11:41:37 2018 +0100

    Bug 20515: (follow-up) Add missing CAN_user_ill

    This follow up patch adds two missing CAN_user_ill tests in templates

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 3f983c7249f2141a2908f1cef4e9c5a0c2ba282d
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date:   Mon Apr 9 15:41:57 2018 +0100

    Bug 20515: (QA follow-up) Remove specific superlibrarian check

    Removed the test for CAN_user_superlibrarian as requested

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit a4ccd04d066ab304619c34adf15f9124e1cf6ee6
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date:   Wed Apr 4 12:09:52 2018 +0100

    Bug 20515: Fix permission check on "ILL request" menu options

    This patch adds the following additional conditions to the display of
    both the ILL Requests drop down "More" menu option and the "ILL Requests"
    option on the intranet front page:

    Before:

    [% IF Koha.Preference('ILLModule') %]

    After:

    [% IF Koha.Preference('ILLModule') && (CAN_user_ill || CAN_user_superlibrarian) %]

    This prevents the options being displayed to users who have no
    permissions to work with ILL.

    Test plan:

    View both the intranet front page and "More" dropdown while logged in as
    a user without ILL permissions, ensure the options do not display. Then
    do the same with a user with ILL permissions, ensure the options do
    display.

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 84327359787fe681e4ae456df330bcb4591f6291
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Mon Apr 9 11:38:44 2018 +0200

    Bug 20539: Remove warnings in catalogue/search.pl

    Test plan:
    1. Start a search from intranet
    2. See several warnings in logs
    3. Apply patch (&& reload starman)
    4. Start a new search
    5. Confirm that warnings are gone and that the search still works

    Signed-off-by: Roch D'Amour <roch.damour at inlibro.com>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit f4c1e91a2fce18dca1708fe933f142541ea2190d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Apr 16 12:56:01 2018 -0300

    Bug 18725: Test return values of make_column_dirty

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 38132cabbb88a51b3b457972dc7119eecdc9cfb5
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Apr 13 09:38:50 2018 +0200

    Bug 18725: (QA follow-up) Use make_column_dirty instead of status change

    Moving the status to the invalid 'processing' might well have unwanted
    side-effects. (The status column will be set to empty string and we have
    a problem if it is not processed.)

    This patch allows pass-through of DBIX's make_column_dirty in
    Koha::Object (simple tests included) and uses it to force an update.
    If the update does not return true, it still exits.

    Test plan:
    [1] Read the changes.
    [2] Run t/db_dependent/Koha/Object.t

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 8ad45474324b672fb48d8b7af83a94184cd1b2f9
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Oct 26 09:04:59 2017 -0400

    Bug 18725: Prevent process_message_queue to send duplicate emails if message_queue is not writable.

    Last week, we had a database server whose disk filled, causing database writes to fail.

    This meant that messages in message_queue marked 'pending' were not marked as 'sent' when they were added to the postfix mail queue; messages were sent every 15 minutes (as specified in the cron job) until the disk space issues were cleared.

    I would suggest adding a token write to the start of process_message_queue.pl as a 'canary in the coal mine'. If the database write fails, process_message_queue should stop, because it's not safe to proceed sending emails that may not be marked 'sent'.

    Test Plan:
    1) Apply this patch
    2) Make the message_queue table unwriteable somehow
    3) Run process_message_queue.pl
    4) Script should die with error

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-----------------------------------------------------------------------

Summary of changes:
 C4/Letters.pm                                      |    6 +
 Koha.pm                                            |    2 +-
 Koha/Object.pm                                     |    2 +-
 catalogue/search.pl                                |   69 +++---
 installer/data/mysql/sysprefs.sql                  |    1 +
 installer/data/mysql/updatedatabase.pl             |   11 +
 .../intranet-tmpl/prog/en/includes/circ-menu.inc   |    2 +-
 .../intranet-tmpl/prog/en/includes/header.inc      |    4 +-
 .../intranet-tmpl/prog/en/includes/ill-toolbar.inc |    2 +-
 .../en/modules/admin/preferences/cataloguing.pref  |    8 +
 .../prog/en/modules/cataloguing/addbiblio.tt       |    8 +-
 .../intranet-tmpl/prog/en/modules/intranet-main.tt |    2 +-
 .../intranet-tmpl/prog/en/modules/tools/letter.tt  |  224 ++------------------
 .../prog/en/modules/tools/preview_letter.tt        |   56 +++--
 koha-tmpl/intranet-tmpl/prog/js/letter.js          |  183 ++++++++++++++++
 t/db_dependent/Koha/Object.t                       |   14 +-
 16 files changed, 328 insertions(+), 266 deletions(-)
 create mode 100644 koha-tmpl/intranet-tmpl/prog/js/letter.js

hooks/post-receive
-- 
main Koha release repository