[koha-commits] main Koha release repository branch master updated. v17.11.00-1240-ge6f729c

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  e6f729cfa0a1bb362e66646413fb0ef40af9d9ea (commit)
       via  681a25f802dc3d2c1eaf63a2d1e7efa3f0d3f585 (commit)
       via  74e0dfb4376c971d916299827aca1d65cd0852a1 (commit)
      from  0797d9cc09fdb8e0f1b1e0b5824775ff6286c60a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit e6f729cfa0a1bb362e66646413fb0ef40af9d9ea
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu Apr 19 11:13:06 2018 -0300

    Bug 20590: Include Koha::Exceptions::Exception
    
    This patch makes Koha::Exceptions::Object include
    Koha::Exceptions::Exception so it is not required to include it
    excplicitly for using this exceptions.
    
    To test:
    - Run:
      $ kshell
     $k prove t/Koha/Exceptions.t
    => FAIL: Tests fail because Koha::Exceptions::Exception is not
    (implicitly or explicitly included)
    - Apply this patch
    - Run
     k$ prove t/Koha/Exceptions.t
    => SUCCESS: Tests pass!
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 681a25f802dc3d2c1eaf63a2d1e7efa3f0d3f585
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu Apr 19 11:12:31 2018 -0300

    Bug 20590: Unit tests
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 74e0dfb4376c971d916299827aca1d65cd0852a1
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Apr 16 12:39:15 2018 -0300

    Bug 20590: Improve Koha::Exceptions in string context
    
    I was working on bug 20580 and noticed that the exceptions are not
    stringified and so not really useful when displayed in string context.
    
    This patch is for discussion and not ready for inclusion
    
    Still need to fix:
    Koha/REST/V1/Patrons.pm (The error is "Given xxx does not exist")
    Koha/Object.pm: in ->store, Koha::Exceptions::Object::FKConstraint is
    raised but we cannot set 'value'
    
    Another note: In Koha::Exceptions::Exception I do not have access to
    $self->line_number and $self->filename
    
    See also
    http://search.cpan.org/~drolsky/Exception-Class-1.44/lib/Exception/Class/Base.pm#OVERRIDING_THE_as_string_METHOD
    
    Test plan:
    Apply patch from bug 20580 and execute create_superlibrarian.pl with an
    invalid categorycode
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-----------------------------------------------------------------------

Summary of changes:
 C4/Members.pm                                      |    6 ++---
 Koha/Exceptions.pm                                 |    5 +----
 Koha/Exceptions/Object.pm                          |    7 +++---
 .../default_search_class.pl => Koha/Exceptions.t}  |   23 ++++++++++----------
 4 files changed, 20 insertions(+), 21 deletions(-)
 copy t/{db_dependent/default_search_class.pl => Koha/Exceptions.t} (57%)
 mode change 100755 => 100644


hooks/post-receive
-- 
main Koha release repository