[koha-commits] main Koha release repository branch 17.11.x updated. v17.11.04-46-g219e427
Git repo owner
gitmaster at git.koha-community.org
Tue Apr 24 02:28:43 CEST 2018
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 17.11.x has been updated
via 219e427f29554c323b2016dd67898c21f10d8fcb (commit)
via ad1802de5485ac31533094f9b54c8cb6078d71f4 (commit)
via 379ffd043e712ace62c3702ca6aa9d94229938bd (commit)
via b02528d8bb7e8e86d0157166e0d2868e64d19d51 (commit)
via 1665a91b21130c3c6912613acce391a18921a827 (commit)
via c4ce0990452fb8cf1a52c732928b8f5f8789471a (commit)
via 3f118604af4ff965a1a320656e40762f9958e791 (commit)
via 67ca82fe5acd7ba772fdd79539a1f8b270f31dc5 (commit)
via 174dc4cb2e1de70b310aea2b812ce959ad5ab174 (commit)
via aa7954907b94487f17d13573c19d9fbd7c6677b2 (commit)
via 8450d2020bdfd524ebd20f0de8d278497fce0759 (commit)
via c9ee7c8d3b34da110702cfd93e16b11350d19a6d (commit)
via 336e7faaf451ff29d43a4a557861fbc8511c8e5e (commit)
via 931db23ee369580bbaf137547accef5a8f47412e (commit)
via a85d33314cb48a493bbc26f5350911dc5c6b2c51 (commit)
via 4fe8810dbc4153dbc2a6eac064e60878b97fe347 (commit)
via f2106cc732fd085f33ac3b25be3610ff8ccfe0c6 (commit)
via 265a8f6218e39b5180e5f210cd8ba833908f93db (commit)
via 63d7065abcdee17154c5d57e663a4898ab1fac56 (commit)
via 7852d967d1982de2c19571b8733ea8273458882b (commit)
via 830ce35795f7bbd68d6b68c4795cb36f27fe2b6d (commit)
via 6bf4623501ce0e6a26c3ede9b54a324331f51480 (commit)
via 33bb028c9e683ac440573bc44b01aabda2b95fba (commit)
from 6fe90c2228ab6116f1d30d811aad2a6eb342153a (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 219e427f29554c323b2016dd67898c21f10d8fcb
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Mon Dec 4 10:04:48 2017 +0100
Bug 19739: Add default ES configuration to koha-conf.xml
Bug 18571 added default ES configuration for packaging config.
This patch adds it to dev install in koha-conf.xml.
Database name is used in index_name to allow multiple installs.
Test plan :
- Run dev install
- Install ElasticSearch server and Koha deps
- Enable ElasticSearch in Koha
- Check indexing and searching works directly
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit ad1802de5485ac31533094f9b54c8cb6078d71f4
Author: Charles Farmer <charles at inlibro.com>
Date: Fri Jan 19 16:04:19 2018 -0500
Bug 19955: Minor grammatical correction
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 379ffd043e712ace62c3702ca6aa9d94229938bd
Author: Kyle M Hall <kyle at bywatetsolutions.com>
Date: Thu Jan 11 13:00:31 2018 -0500
Bug 19955: Add ability to process only one 'type' of message ( sms, email, etc ) for a given run of process_message_queue.pl
It would be nice to allow emails to be sent overnight, but limit the sending of SMS messages to hours when people are awake. Adding a type limit to process_message_queue.pl would allow this to be accomplished easily.
Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit b02528d8bb7e8e86d0157166e0d2868e64d19d51
Author: Victor Grousset <victor.grousset at biblibre.com>
Date: Thu Mar 22 15:44:00 2018 +0100
Bug 20461: Serials: fix ignored params in subscription creation form
In subscription-add.pl, the two params aren't passed to
NewSubscription() but they are to ModSubscription()
== Test plan ==
1. Enable syspref "makePreviousSerialAvailable"
2. Create a minimal subscription with a value in the "Item type" and
"item type for older issues" fields.
3. Edit the subscription
4. You should see that the two fields are empty. This is the bug.
5. Apply this patch
6. Do step 2 and 3
7. You should see that the two fields have the right value
8. Express the joy of a successful and easy sign off.
(this is important, otherwise the sign off spell won't work!)
Signed-off-by: delaye <stephane.delaye at biblibre.com>
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 1665a91b21130c3c6912613acce391a18921a827
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Fri Feb 23 14:29:48 2018 +0100
Bug 20067: Fix other checks for linked authorised value categories
The same pattern was used in other files, this patch fixes it.
Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit c4ce0990452fb8cf1a52c732928b8f5f8789471a
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Fri Feb 23 14:20:17 2018 +0100
Bug 20067: Fix false display of authorised value for materials on staff detail page
Koha didn't check for a linked authorised value category for
Koha didn't check for a linked authorised value category for
items.materials correctly which led to displaying false information
on the detail page.
To test:
- before applying the patch:
- make sure sample data and configuration is loaded
- edit any item
- write 2 in the $3 materials specificed
- check the details page normal view - it will display 'restocking'
- apply patch
- check display, it should now show "2"
- link 952$3 (MARC21) to ORDER_CANCELLATION_REASON
- check display again, it should now show 'restocking'
Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 3f118604af4ff965a1a320656e40762f9958e791
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jan 2 15:42:12 2018 -0300
Bug 18593: Move suggestions when bibliographic records are merged
When bibliographic records are merged, the suggestions.biblionumber
field should be replaced with the new record.
Ideally we should have kept an history of the merges, to know what was
the original record. Now we cannot fix the broken links.
Test plan:
1) Create a suggestion in OPAC
2) Accept the suggestion in staff
3) Add order from this suggestion
4) Go to cataloguing search and search for the record and another
5) Merge the suggestion record with the catalog record - catalog record wins (should be the more common case when a patron suggests something that already exists)
6) Verify that after merging, the new title displays in the acquisition record
7) Verify that the suggestion info no longer displays in basket
From Katrin's test plan:
8) Verify that the new title doesn't display in suggestions. The old title will still show as suggested (not updated)
=> This is the title from suggestions.title, I think it makes sense to show this one.
Maybe we should open a new bug report to improve the display of the suggestion, and link to the bibliographic record
Signed-off-by: Lucie Gay <lucie.gay at ens-paris-saclay.fr>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 67ca82fe5acd7ba772fdd79539a1f8b270f31dc5
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Fri Mar 23 19:25:20 2018 +0000
Bug 18570: Follow up to fix test noise
This sets a valid email and changes the tests
to expect it was sent.
prove t/db_dependent/Passwordrecovery.t
-- noise before patch
-- no noise after patch
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 174dc4cb2e1de70b310aea2b812ce959ad5ab174
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Mon Mar 12 11:51:59 2018 +0100
Bug 11936: (QA follow-up) Consistent log message for item insert
Fix the same error in another place
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit aa7954907b94487f17d13573c19d9fbd7c6677b2
Author: Magnus Enger <magnus at libriotech.no>
Date: Thu Feb 22 10:37:08 2018 +0100
Bug 11936: Consistent log message for item insert
If you use bulkmarcimport.pl to import records with items it looks
like the successfull insert of the record is reported multiple time,
but the second and subsequent "ok" is really related to importing
the item(s).
This patch changes the log message on successfully inserting an item
to match the log message given when inserting an item fails.
To test, the easy way:
- Look at lines 530 and 536 of bulkmarcimport.pl, and note that the
"op" in those two lines are different
- Apply the patch
- Look at lines 530 and 536 again, and note that the "op" is now
identical, and that this makes sense, since they are both related
to the same operation, specifically inserting an item
To test, the hard way
- Have some records with items
- Import the records with bulkmarcimport.pl, and make sure to specify
the -l option, to create a log of the actions taken
- Look at the log and verify it looks something like this:
id;operation;status
1;insert;ok
1;insert;ok
2;insert;ok
2;insert;ok
- Apply this patch and import some more records with items. The log
should now be similar to this:
id;operation;status
1;insert;ok
1;insertitem;ok
2;insert;ok
2;insertitem;ok
Signed-off-by: Maksim Sen <maksim.sen at inlibro.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 8450d2020bdfd524ebd20f0de8d278497fce0759
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Mar 13 10:15:31 2018 +0000
Bug 20383: Hide link to plugin management if plugins are not enabled
This patch adds a check in admin-home.pl to see whether plugins are
enabled. If plugins are disabled, the link to plugins management is
hidden even if the user has plugin management permission.
To test, view the administration home page with plugins enabled and
disabled via the enable_plugins flag in the Koha configuration file.
Also test using users with different plugins permissions:
- Plugins enabled
- CAN_user_plugins = 1
-> Plugins link appears
- CAN_user_plugins = 0
-> Plugins link hidden
- Plugins disabled
- CAN_user_plugins = 1,
- CAN_user_plugins = 0
-> Plugins link hidden
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit c9ee7c8d3b34da110702cfd93e16b11350d19a6d
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Mar 12 12:56:08 2018 +0000
Bug 20372: Correct toolbar markup on some pages
Differences in markup around some toolbars has the potential to create
CSS styling problems. This patch changes the markup to be consistent
with other instances of <div id="toolbar"></div>
To test, apply the patch and view these pages:
- Course reserves (main page)
- Course reserves -> Course detail page
- Reports -> Dictionary
On each of these pages the toolbar should look correct.
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 336e7faaf451ff29d43a4a557861fbc8511c8e5e
Author: Maksim Sen <maksim.sen at inlibro.com>
Date: Mon Mar 12 16:15:30 2018 -0400
Bug 20376: Make select/unselect all ignore disabled checkboxes on batch record deletion
Test Plan:
0.1 - find at least one biblionumber that has at least one item checked out
0.2 - find at least one biblionumber that has zero items checked out.
1 - Go into the module "Tools > Batch record deletion"
2 - in "List of biblionumbers or authority ids (one per line)" put the values you found in step 0.1 and 0.2
3 - click continue
4 - biblionumbers with at least one item checked out should not be clickable.
5 - biblionumbers with zero items checked out should be clickable.
6 - click "Select all" and "Clear all", both buttons should change the "checked" status of the enabled AND disabled biblionumber checkboxes.
7 - apply patch
8 - click "Select all" and "Clear all", both buttons should change the "checked" status of ONLY the enabled biblionumber checkboxes.
Signed-off-by: JM Broust <jean-manuel.broust at univ-lyon2.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Conflicts:
koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 931db23ee369580bbaf137547accef5a8f47412e
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Tue Oct 31 02:28:58 2017 +0000
Bug 19547: Deal with --create-db missing debian.cnf issue
Followed test plan. Patch functions as described and both commands execute.
Signed-off-by: Dilan Johnpullé <dilan at calyx.net.au>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit a85d33314cb48a493bbc26f5350911dc5c6b2c51
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Mon Oct 30 17:59:43 2017 -0400
Bug 19547: MariaDB install has no debian.cnf
This attempts to handle issues arising when running
koha-create on a system that never had MySQL installed.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 4fe8810dbc4153dbc2a6eac064e60878b97fe347
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Fri Mar 9 11:54:16 2018 +0000
Bug 18570: (QA follow-up) Improved POD
This tweaks the perldoc for SendQueuedMessages and adds
some for _get_unsent_messages.
TEST PLAN
---------
perldoc C4::Letters
-- look at _add_attachments (ugly), _get_unsent_messages (non-existent),
SendQueuedMessages (no reference to borrowernumber or letter_code).
apply patch
perldoc C4::Letters
-- confirm that SendQueuedMessages and _get_unsent_messages
have reasonable POD information.
-- notice how _add_attachments' POD is now readable
run koha qa test tools
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit f2106cc732fd085f33ac3b25be3610ff8ccfe0c6
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Thu Mar 8 00:15:33 2018 +0000
Bug 18570: Send Password Reset Emails immediately
Run through the password reset process, and your server
should send the message immediate, not waiting for the
cronjob.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 265a8f6218e39b5180e5f210cd8ba833908f93db
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Thu Mar 8 00:13:09 2018 +0000
Bug 18570: Prove that the letter code parameter tweaks work
Run the following commands:
kshell
prove -v t/db_dependent/Letters.t
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 63d7065abcdee17154c5d57e663a4898ab1fac56
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Wed Mar 7 23:59:54 2018 +0000
Bug 18570: Tests to prove if email send was attempted
kshell
prove -v t/db_dependent/Passwordrecovery.t
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 7852d967d1982de2c19571b8733ea8273458882b
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Mar 16 09:02:36 2018 +0100
Bug 20430: (See also bug 19436) Button display depends on wrong server count
This is a QA follow-up of bug 19436, submitted separately for ease of
backporting it. (The bug was not raised by 19436.)
Obviously, the number of authority servers not biblio servers should
be the key factor for showing or hiding the button for new authority
records via Z39.50/SRU.
Trivial fix.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 830ce35795f7bbd68d6b68c4795cb36f27fe2b6d
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Tue Mar 6 12:26:19 2018 +0100
Bug 20341: Show authorized value description for withdrawn like damaged and lost
Actually catalog detail page shows for damaged and lost items the authorized value description if exists.
We must do the same for withdrawn information.
Test plan :
1) Set for items a subfield linked to items.withdrawn and using the authorized value category 'WITHDRAWN'
2) Edit the authorized value category to add value '2' and description 'Eaten by dog'
3) Edit an item to set this withdrawn value
4) Go to staff interface and look at items in record detail page /cgi-bin/koh/catalogue/detail.pl :
=> Without patch you see 'Withdrawn' and with patch you see 'Eaten by dog'
5) Go to OPAc and look at items in record detail page /cgi-bin/koha/opac-detail.pl :
=> Without patch you see 'Withdrawn' and with patch you see 'Eaten by dog'
Signed-off-by: delaye <stephane.delaye at biblibre.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 6bf4623501ce0e6a26c3ede9b54a324331f51480
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Mon Feb 5 08:25:03 2018 +0000
Bug 19908: Do not use .optional in password match validation function
Test plan:
0) Aplly only first patch
1) You will be able to submit a from on member-password.pl even if the
passwords don't match
2) Apply this patch -> you can't be able to submit the form if the
paswords don't match, but you'll be able to submit the form when
password fields are blank
Signed-off-by: Roch D'Amour <roch.damour at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 33bb028c9e683ac440573bc44b01aabda2b95fba
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Wed Jan 3 10:56:37 2018 +0000
Bug 19908: Password fields in edit/add patron form should respect BorrowerMandatoryField preference
Test plan:
0) Do not apply the patch, note the password field is always required
1) Apply the patch
2) Try to add and edit patron with and without "password" in BorrowerMandatoryField, it should always respect this setting
3) Use "Change password" button in patron toolbar, the password field
should be never required here - when leaved blank, the password is
unchanged
4) Play with minPasswordLength and RequireStrongPassword preferences,
to ensure they work as expected
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Conflicts:
koha-tmpl/intranet-tmpl/prog/en/modules/members/member-password.tt
koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Letters.pm | 69 ++++++++++++++++----
C4/Search.pm | 2 +-
Koha/Patron/Password/Recovery.pm | 7 +-
admin/admin-home.pl | 6 ++
authorities/authorities-home.pl | 2 +-
catalogue/detail.pl | 10 ++-
catalogue/itemsearch.pl | 6 +-
catalogue/moredetail.pl | 6 +-
cataloguing/merge.pl | 8 ++-
circ/circulation.pl | 2 +-
debian/scripts/koha-create | 13 +++-
etc/koha-conf.xml | 5 ++
.../prog/en/includes/password_check.inc | 2 +-
.../prog/en/modules/admin/admin-home.tt | 2 +-
.../prog/en/modules/catalogue/detail.tt | 10 ++-
.../en/modules/course_reserves/course-details.tt | 14 ++--
.../en/modules/course_reserves/course-reserves.tt | 8 +--
.../prog/en/modules/members/member-password.tt | 2 -
.../prog/en/modules/members/memberentrygen.tt | 3 +-
.../prog/en/modules/reports/dictionary.tt | 4 +-
.../prog/en/modules/tools/batch_delete_records.tt | 4 +-
.../bootstrap/en/includes/item-status.inc | 7 +-
misc/cronjobs/process_message_queue.pl | 5 +-
misc/migration_tools/bulkmarcimport.pl | 4 +-
serials/subscription-add.pl | 2 +-
t/db_dependent/Letters.t | 17 +++--
t/db_dependent/Passwordrecovery.t | 14 +++-
tools/inventory.pl | 4 +-
28 files changed, 173 insertions(+), 65 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list