[koha-commits] main Koha release repository branch master updated. v17.11.00-1350-g84f090d

Wed Apr 25 17:00:13 CEST 2018

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  84f090d1958105a8810cd8f4d71d1d1f88ed73ea (commit)
       via  59b2f2edb954ae8ad4e2bd1e3758be66cbba618c (commit)
       via  e1676955f71bfd7d2fedbe52956e5e03a975a8c7 (commit)
       via  8d3eba6a297f4fd993ddf237b6cd66cfda38ff95 (commit)
       via  1d12311ac189b928b840e8842076492cdc8369d3 (commit)
       via  532d07c00bb2e522ea7448a00cf80558f9c13dbe (commit)
       via  e08a36c25a67da083d5d3bdf0dd58b4a71144e9d (commit)
       via  0c45edcebb474009d8da64bd479b0f9de1872e15 (commit)
       via  0f1ebf68a6a5e1fcb42caa1479a4856a0a4653aa (commit)
       via  d31b0bfdfc2d15eb94255240b6233315120f2bfe (commit)
       via  ccf62d46d7143965086fae7770c2fb27031e1bb6 (commit)
       via  f26b68a07f8ac8e5dd47a1e478e47507e424453a (commit)
       via  a5f526ae0fc488607cf766335626294d6027a406 (commit)
       via  e05cd22723d9c7f8bf5fc1ce3149df9c41dc9df1 (commit)
      from  896644d90125a930e1acbc19ce5d80aaf5d91278 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 84f090d1958105a8810cd8f4d71d1d1f88ed73ea
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Apr 23 10:37:48 2018 -0300

    Bug 19204: Add tests for new days_mode parameter

    Sponsored-by: Goethe-Institut

    Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 59b2f2edb954ae8ad4e2bd1e3758be66cbba618c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Apr 23 18:52:00 2018 -0300

    Bug 19204: Add a test: holiday is expiration date

    Sponsored-by: Goethe-Institut

    Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit e1676955f71bfd7d2fedbe52956e5e03a975a8c7
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Apr 23 18:12:00 2018 -0300

    Bug 19204: Clean the tests a bit to reuse the same pattern

    The same pattern is used several times in test:
    checkout, checkin, get the debarment, compare the dates and remove the
    debarment.
    Let's move that to a separate subroutine

    Sponsored-by: Goethe-Institut

    Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 8d3eba6a297f4fd993ddf237b6cd66cfda38ff95
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Apr 23 15:23:00 2018 -0300

    Bug 19204: Make the debarment date calculation depends on finesCalendar

    This patchs adds the ability to calculate the end of the suspension date
    (debarment date) using the finesCalendar syspref.
    Prior to this patch it was never calculating without taking into account
    the calendar.

    calculated without taking holidays into account.
    This was a problem because the restriction could end in the middle of a
    period the library is closed.

    Test plan:
    - Set finescalendar to 'not including days the library is closed'
    - Set a circulation condition with no fine/maxfine, but fine days and
    max fine days instead
    - Check out an item with a due date in the past
    - Check the item in and verify the restriction date
    - Clean the restriction

    - Add holidays to your calendar on the calculated restriction date
    - Check the item out again with the same due date in the past
    - Check in the item again
    - Verify the calculated restriction end date has changed, it's set to the day
    after the holiday.

    Fines in days restriction calculation is correctly taking calendar
    into account.

    Sponsored-by: Goethe-Institut

    Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 1d12311ac189b928b840e8842076492cdc8369d3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Apr 25 10:37:08 2018 -0300

    Bug 20100: DBRev 17.12.00.040

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 532d07c00bb2e522ea7448a00cf80558f9c13dbe
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Apr 25 10:46:11 2018 -0300

    Bug 20100: Set ProtectSuperlibrarianPrivileges by default

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit e08a36c25a67da083d5d3bdf0dd58b4a71144e9d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Apr 25 10:34:59 2018 -0300

    Bug 20100: Explain why the checkbox is disabled

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 0c45edcebb474009d8da64bd479b0f9de1872e15
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Wed Apr 25 13:33:05 2018 +0200

    Bug 20100: (QA follow-up) Pref description and improve code in member-flags

    Two points as mentioned on Bugzilla comment29.
    [1] Improve pref description. Feedback from comment30 incorporated.
    [2] Improve code in member-flags. Check if we change librarian flag first.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Tested the die with "disable_superlibrarian_privs => 0" in member-flags.

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 0f1ebf68a6a5e1fcb42caa1479a4856a0a4653aa
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Wed Apr 25 13:09:05 2018 +0200

    Bug 20100: (QA follow-up) Change syspref name to full version

    As per RM request, changing the shorter name to its full form.
    Result of a git grep | sed.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    No occurrences to be found anymore with git grep -i.

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit d31b0bfdfc2d15eb94255240b6233315120f2bfe
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Apr 20 11:52:17 2018 +0000

    Bug 20100: (QA follow-up) Use template logic instead of js to disable superlib box

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit ccf62d46d7143965086fae7770c2fb27031e1bb6
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Wed Jan 31 16:47:23 2018 +0100

    Bug 20100: Disallow access to superlibrarian privileges at client side

    This last patch activates the check at client side.
    If the pref ProtectSuperlibPrivs is enabled, non-superlibs should not be
    able to change superlibrarian privileges via the interface.

    Test plan:
    [1] Enable the pref.
    [2] Login as superlib and add/remove superlib privs to a staff user.
    [3] Login as another user (no superlib, but having borrowers, permissions
        and staff_access). Verify that you cannot add or remove superlib
        privs.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: JM Broust <jean-manuel.broust at univ-lyon2.fr>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit f26b68a07f8ac8e5dd47a1e478e47507e424453a
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Wed Jan 31 15:02:36 2018 +0100

    Bug 20100: Disallow access to superlib privileges at server side

    Depends on pref ProtectSuperlibPrivs.
    If enabled, script member-flags.pl will not allow you to add or remove
    superlib privs when you are no superlibrarian.
    The follow-up patch will enable the check at client side.

    Test plan:
    [1] Enable the pref. Do not apply the third patch (client side).
    [2] Login as superlib and add/remove superlib privs to a staff user.
    [3] Login as another user (no superlib, but having borrowers, permissions
        and staff_access). Verify that you have an internal server error when
        you add or remove superlib privs. The log contains a warning.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: JM Broust <jean-manuel.broust at univ-lyon2.fr>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit a5f526ae0fc488607cf766335626294d6027a406
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Wed Jan 31 16:23:18 2018 +0100

    Bug 20100: Introduce preference ProtectSuperlibPrivs

    This pref allows you to block changes to superlibrarian privileges at
    client and server side for non-superlibrarians.
    This patch only contains the db rev and the preference description.

    Test plan:
    Run dbrev or new install. Check pref value.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: JM Broust <jean-manuel.broust at univ-lyon2.fr>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit e05cd22723d9c7f8bf5fc1ce3149df9c41dc9df1
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Wed Apr 25 09:21:30 2018 +0200

    Bug 20538: Prevent warnings in xt/author/valid-templates.t

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm                                  |   14 +-
 Koha.pm                                            |    2 +-
 Koha/Calendar.pm                                   |    2 +-
 installer/data/mysql/sysprefs.sql                  |    1 +
 installer/data/mysql/updatedatabase.pl             |   12 ++
 .../prog/en/modules/admin/preferences/patrons.pref |    7 +
 .../prog/en/modules/members/member-flags.tt        |   21 ++-
 members/member-flags.pl                            |    8 +-
 t/Calendar.t                                       |   15 +-
 t/db_dependent/Circulation.t                       |  176 +++++++++++++++-----
 xt/author/valid-templates.t                        |    6 +-
 11 files changed, 206 insertions(+), 58 deletions(-)

hooks/post-receive
-- 
main Koha release repository