[koha-commits] main Koha release repository branch 17.11.x updated. v17.11.08-27-g60ee36a

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.11.x has been updated
       via  60ee36a1e025bd1f075957b7875b8fa5111fc2cf (commit)
       via  1ea32136b526c92b1d4f6a7d0db849786692514e (commit)
       via  d397a1b66743f5714a3d87275b89330304906faf (commit)
      from  0865b082d2e2f37722fdd06dfca052f5a7866faf (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 60ee36a1e025bd1f075957b7875b8fa5111fc2cf
Author: Victor Grousset <victor.grousset at biblibre.com>
Date:   Fri May 11 17:43:33 2018 +0200

    Bug 20623: (QA follow-up) avoid fetch() calls in some cases
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 35d887fece0634eb92d030b959aeb991f10a0239)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 1ea32136b526c92b1d4f6a7d0db849786692514e
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri May 11 11:33:32 2018 +0200

    Bug 20623: (QA follow-up) Remove one find call
    
    Imo these somewhat weird lines ask for improvement, but I don't want to change
    the exact conditions here. Just removing the need to call find twice.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 1bc3bbfdc78bfd559fec841c6ca47ddcbeb0f179)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit d397a1b66743f5714a3d87275b89330304906faf
Author: Victor Grousset <victor.grousset at biblibre.com>
Date:   Fri Apr 20 11:17:26 2018 +0200

    Bug 20623: Fix basket group PDF when itemtype not itemtype table
    
    When an item has an itemtype not in the itemtype table. Trying to fetch
    it's description lead to an error.
    Using authorized values like ccode to populate the itemtypes of the
    biblioitems (instead of the itemtype table) can lead to such data.
    Or importing records with invalid itemtype codes. Koha doesn't do enough
    checks at import to at least warn about these issues.
    
    == Test plan ==
    1. first we need an item with an itype not in the item_types table
       1. download a record as MARCXML
       2. find it's item type in administration; and the related code
       3. open the MARCXML file and search for occurences of the code
            and replace them by some non-existing value like "FOOBAR"
       4. also change the barcode so it won't be ignored because
            it's a duplicate
       5. also change the title to easily find it later in the search
       6. tools → "Stage MARC records for import"
       7. upload your file
       8. "stage for import"
       9. click "Manage staged records"
            You should end on the page related to your staged record
       10. "Import this batch into the catalog"
    
    2. now we need it in a basket group
       1. have/create a active budget
       2. have/create a fund
       3. have/create a vendor with minimal info
       4. create a basket with minimal info
       5. add our imported item to the basket
            for example search it by name
       6. go to the basket. URL should be
          /cgi-bin/koha/acqui/basket.pl?basketno=XXXXX
       7. close this basket
            and tick "Attach this basket to a new basket group with the same name"
       8. you will end up in the basket groups lists
       9. go to the "closed" tab
       11. go to the basket group
              your vendor page => Basket groups => Closed
    
    3. export as PDF, it should fail (internal server error)
         this is the bug (no kidding ^_^)
    4. apply this patch
    5. reexport the basket as PDF
    6. it should work
    7. create an item type (in administration)
         that has the same code as the one that you put in the MARCXML
    8. reexport the basket as PDF
    9. check that in the PDF that the description is here:
         table at the bottom of the document → "Document" column
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    (cherry picked from commit 3811985c3a55b72900ba005c6867059776ee9281)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 acqui/basketgroup.pl |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)


hooks/post-receive
-- 
main Koha release repository