[koha-commits] main Koha release repository branch master updated. v18.05.00-424-g537c309
Git repo owner
gitmaster at git.koha-community.org
Thu Aug 9 14:23:40 CEST 2018
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 537c30984fcd1cf3dc2efef43545fba0803e6b99 (commit)
via 5260482a619fa5aa88e83a8c2c3afe1b159ad5fa (commit)
via 1b43cab3dd4fb34e4c3a1509415057448496eb82 (commit)
via ac0f3b880a4220317ddde107c508c32f75b09aa1 (commit)
via fe6cb85c5580b582a0047769d88be23757df0ef5 (commit)
via af82a1d59709d02b767613539146b59fa10c3ab3 (commit)
via 9d4c7350612dfb941a84a0e62ffe3efe19ccc4f8 (commit)
via bf9527457fb31012b65514a36f8f4001157771b4 (commit)
via 8d9eb9734f2584c7b5f92689ecbd9a3adba173fd (commit)
via f16fb888f132703063f0591e329d72d065f4b1d9 (commit)
via f4cf075fbea353a5cbf11aaead37c92eac8179b2 (commit)
via ff3987c023a658e63e46ea8601666916287c8ec5 (commit)
via 5abcd3312adc02a14465a0781f735b8494d60f42 (commit)
via 76a06a7050643add32f4cbccbdc2fb00f66f5485 (commit)
via e8e29d3140007b9b92d97ed2f1df7445c6eeb4f9 (commit)
via 6e7fd122147bafcd2b66c1ecfde2e9be1cdcccef (commit)
via 62aacb5865719e27224bf8f1963de1888d2ca05d (commit)
via 948566e7f36a75a186f96b5ee07b5120a5413ca5 (commit)
from 70bfac5ce5ee8e806015861d6cb473dfe1ee80b6 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 537c30984fcd1cf3dc2efef43545fba0803e6b99
Author: David Cook <dcook at prosentient.com.au>
Date: Tue May 23 12:06:59 2017 +1000
Bug 18586: Create module to mint RDF subject URIs
Created the Koha::RDF module to mint URIs for RDF documents that
represent Koha bibliographic records.
_TEST PLAN_
To test the module, just run 'prove t/Koha/RDF.t'.
You'll get
some warnings about not being able to find koha-conf.xml, but
you can safely ignore them or you can point to any koha-conf.xml
file since it's not used by the test in actuality.
Signed-off-by: Magnus Enger <magnus at libriotech.no>
Works as expected. No warnings when run like:
sudo koha-shell -c "prove t/Koha/RDF.t" kohadev
Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 5260482a619fa5aa88e83a8c2c3afe1b159ad5fa
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Apr 5 11:53:07 2018 +0000
Bug 20779: Style refresh for patron detail page
This patch makes style and markup changes to the patron detail page
template in order to make the display of information somewhat more
compact and to increase the visibility of the edit controls.
To test you should enable the patronimages system preference. Apply the
patch and view the detail page for a patron.
- Check that the page looks correct and that sections like "Alternate
address" and "Alternative contact" are empty when there is no data.
- Check that the "Manage patron image" tool works correctly.
Signed-off-by: Cab Vinton <director at plaistowlibrary.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 1b43cab3dd4fb34e4c3a1509415057448496eb82
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Jul 30 17:33:29 2018 +0000
Bug 21132: Highlight active filters on saved report page
This patch adds a more obvious way of see which search terms have been
submitted to filter the table of saved reports.
The patch also moves embedded CSS into a separate file.
To test you should have multiple saved reports.
- Apply the patch and go to Reports -> Use saved.
- Filter the table of reports by submitting one or more terms in the
sidebar "Filter" form.
- Confirm that the terms you submit are shown at the top of the table of
results.
- Confirm that clicking the "Clear" link clears the search filter.
Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Followed the test plan and it works.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit ac0f3b880a4220317ddde107c508c32f75b09aa1
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu May 18 21:07:11 2017 -0400
Bug 18635: Unit tests
I also adjust a few tests that assume value of $nb_of_patrons to not
rely on existing datas
To test:
1 - Apply this patch only
2 - Prove t/db_dependent/Koha/Patrons.t
3 - Tests fail
4 - Apply other patch
5 - Tests pass
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit fe6cb85c5580b582a0047769d88be23757df0ef5
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu May 18 21:08:22 2017 -0400
Bug 18635: Koha::Patron->guarantees() should return results alphabetically
To test:
1 - Add the same guarantor to a number of patrons, ensuring random order
alphabetically
2 - View the guarantors record, note unordered list of guarantees
3 - Apply patch
4 - Guarantees are alphabetical
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit af82a1d59709d02b767613539146b59fa10c3ab3
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Tue Jul 3 15:52:05 2018 +0200
Bug 21033: Remove few warns in acqui/basket.pl
Resolve (line numbers based on 16.11.x):
Use of uninitialized value in hash element at acqui/basket.pl line 337.
Use of uninitialized value in hash element at acqui/basket.pl line 338.
Use of uninitialized value in hash element at acqui/basket.pl line 340.
Use of uninitialized value in hash element at acqui/basket.pl line 342.
Use of uninitialized value in hash element at acqui/basket.pl line 344.
Argument "" isn't numeric in multiplication (*) at koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt line 486.
Argument "" isn't numeric in multiplication (*) at koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt line 591.
Test plan:
If you have older acq data, you may have records in aqorders with field
tax_rate_on_ordering is NULL. These orders will trigger the above warns.
If you do not have, you could simulate by setting this field to NULL.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 9d4c7350612dfb941a84a0e62ffe3efe19ccc4f8
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Jul 19 15:13:55 2018 +0000
Bug 20828: Step 4 of moremember is used for Housebound and additional attributes
This patch modifies the patron edit process so that "Housebound roles"
can be edited as a separate step.
To test, apply the patch and open an existing patron's detail page
(moremember.tt). Test the "edit" links for 'Housebound roles' and
'Additional attributes and identifiers' and confirm that each opens its
own edit page, and saving changes works correctly.
Signed-off-by: Cab Vinton <bibliwho at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit bf9527457fb31012b65514a36f8f4001157771b4
Author: David Bourgault <dav.bour at gmail.com>
Date: Tue May 1 14:03:52 2018 -0400
Bug 20660: Return date override affects debarments in AddReturn
Re-did the patch to follow best practices.
TEST PLAN:
0. Apply first patch only
1. prove t/db_dependent/Circulation.t
2. Apply second patch
3. prove t/db_dependent/Circulation.t
prove should fail the first time and pass the second time.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 8d9eb9734f2584c7b5f92689ecbd9a3adba173fd
Author: David Bourgault <dav.bour at gmail.com>
Date: Tue May 1 14:01:50 2018 -0400
Bug 20660: Test AddReturn with $return_date override
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit f16fb888f132703063f0591e329d72d065f4b1d9
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Jul 4 15:05:25 2018 -0300
Bug 21035: Handle new lines when running reports
See https://metacpan.org/pod/Text::CSV_XS#Embedded-newlines
Test plan:
1) Choose two items, say barcode '123' and '456'
2) Change the public note on 123 to read
Line1
Line2
(I.e. type 'Line1', then press Enter, type 'Line2' and click update).
3) Change the public note on 456 to read
Public note has one and only one line.
Click update.
4) Create a report with the followng query:
select barcode, itemnotes from items where barcode in ( '123', '456' )
Let's say that this is report number 10.
5) run ./misc/cronjobs/runreport.pl --format=csv REPORT_ID:
=> You should see both lines
Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Followed the test plan and it works.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit f4cf075fbea353a5cbf11aaead37c92eac8179b2
Author: David Cook <dcook at prosentient.com.au>
Date: Mon Jul 30 14:35:40 2018 +1000
Bug 21131: Remove the TinyMCE.isDirty() check that caused unexpected behaviour
When using the WYSIWYG editor for system preferences, the editor only
updates the textarea element if the content is different from the
original content. This means if you change a system preference and
then change it back to the original content, the textarea will have
the 2nd last change you made.
This patch removes the TinyMCE.isDirty() check, which was responsible
for comparing the original and changed content. Every input/keydown/dragend
or TinyMCE command will cause the textarea element to be updated and
trigger the input event which causes the "modified" class to be added
to the element, so that the system preference can be saved.
__TEST PLAN__
_Before applying_
0. Change "UseWYSIWYGinSystemPreferences" to "Show"
1. Change "opaccredits" to "123a"
2. Click "Save all OPAC preferences"
3. Reload the page
4. Change "opaccredits" to "123"
5. Change "opaccredits" to "123a"
6. Click "Save all OPAC preferences"
7. Reload the page
8. Note that "opaccredits" says "123"
_Apply the patch_
_After applying_
1. Change "opaccredits" to "123a"
2. Change "opaccredits" to "123"
3. Click "Save all OPAC preferences"
4. Reload the page
5. Note that "opaccredits" says "123" (and not "123a")
6. Change "opaccredits" to "1234"
7. Click "Save all OPAC preferences"
8. Reload the page
9. Note that "opaccredits" says "1234"
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit ff3987c023a658e63e46ea8601666916287c8ec5
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Jul 27 17:22:54 2018 +0000
Bug 19291: Make breadcrumbs for OPAC search history consistent with other patron account pages
This patch adds the logged-in patron's name to the search history page's
breadcrumb navigation.
To test, apply the patch and view the OPAC search history page with no
user logged in. The breadcrumbs should read:
- Home -> Search history
Log in and return to the search history page. The breadcrumbs should
read:
- Home -> Owen Leonard -> Your search history
Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Followed the test plan and it works.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
https://bugs.koha-community.org/show_bug.cgi?id=21137
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 5abcd3312adc02a14465a0781f735b8494d60f42
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jul 31 12:14:54 2018 -0300
Bug 21056: Add another flush later
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 76a06a7050643add32f4cbccbdc2fb00f66f5485
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Jul 9 14:05:29 2018 -0400
Bug 21056: Changing the logged in library can fail sporadically
We are getting reports that sometimes changing the logged in library via selectbranchprinter.pl sometimes appears to fail. Flushing the session after updating the branch appears to fix this.
Test Plan:
1) Change your logged in library repeatedly. Hopefully ( sort of ) it will fail to change.
You may want to try various browsers.
2) Apply this patch
3) Note the change no longer fails
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit e8e29d3140007b9b92d97ed2f1df7445c6eeb4f9
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Aug 6 15:26:49 2018 -0300
Bug 21141: Handle non-existent itemnumbers in batch item modification/deletion
The itemnumber list passed from a file in the batch item
modification/deletion tools is not tested.
Like barcodes we should make sure they refer to a valid items in the DB.
Test plan:
- Create a file with barcodes, itemnumbers and random lines
- Use the batch item modification and deletion tools with this file
You should see a table with a list of invalid barcodes and itemnumbers.
Without this patch you got the following error:
Can't call method "title" on an undefined value at
/home/vagrant/kohaclone/tools/batchMod.pl line 580
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 6e7fd122147bafcd2b66c1ecfde2e9be1cdcccef
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Jul 16 11:21:48 2018 -0300
Bug 21050: Fix datepickers on LabelItemSearch
calendar.inc must be in the jsinclude block when jsfooter is set
Test plan:
- Open or create a label batch.
- Click "Add items" to trigger the pop-up search window.
- Date picker should work now
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 62aacb5865719e27224bf8f1963de1888d2ca05d
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Aug 2 13:46:31 2018 +0000
Bug 21148: Dropdowns styled by the Select2 plugin do not highlight missing required fields
This patch adds some CSS to target mandatory fields on the add item
screen which are styled by the Select2 plugin.
To test you must have at least one item field marked mandatory and
linked to an authorized value.
Open the add item form for an existing record. Try to submit the form
without making a selection in the mandatory dropdown. You should get an
alert warning you that you have empty mandatory fields, and the field
should be highlighted in yellow.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 948566e7f36a75a186f96b5ee07b5120a5413ca5
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Thu Aug 2 16:11:07 2018 +0000
Bug 21154: Remove unused subs from C4::Serials
Test plan:
Run these commands, grep should not return any occurences, prove should
return green:
git grep GetSerialStatusFromSerialId
git grep GetDistributedTo
git grep SetDistributedTo
git grep SetDistributedto
git grep in_array
git grep is_barcode_in_use
kshell
prove t/db_dependent/Serials.t
Signed-off-by: Pierre-Luc Lapointe <pierreluc.lapointe at inLibro.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Circulation.pm | 1 +
C4/Serials.pm | 93 ----
Koha/Patron.pm | 2 +-
Koha/RDF.pm | 50 +++
acqui/basket.pl | 4 +-
circ/selectbranchprinter.pl | 2 +
koha-tmpl/intranet-tmpl/prog/css/reports.css | 75 ++++
koha-tmpl/intranet-tmpl/prog/css/select2.css | 4 +
koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 4 +
.../prog/en/includes/wysiwyg-systempreferences.inc | 8 +-
.../intranet-tmpl/prog/en/modules/labels/search.tt | 4 +-
.../prog/en/modules/members/memberentrygen.tt | 7 +-
.../prog/en/modules/members/moremember.tt | 442 ++++++++++++--------
.../en/modules/reports/guided_reports_start.tt | 37 +-
.../prog/en/modules/tools/batchMod-del.tt | 50 ++-
.../prog/en/modules/tools/batchMod-edit.tt | 54 ++-
.../bootstrap/en/modules/opac-search-history.tt | 1 +
members/memberentry.pl | 8 +-
misc/cronjobs/runreport.pl | 1 +
.../default_search_class.pl => Koha/RDF.t} | 22 +-
t/db_dependent/Circulation.t | 15 +-
t/db_dependent/Koha/Patrons.t | 58 ++-
t/db_dependent/Serials.t | 6 +-
tools/batchMod.pl | 16 +-
24 files changed, 588 insertions(+), 376 deletions(-)
create mode 100644 Koha/RDF.pm
create mode 100644 koha-tmpl/intranet-tmpl/prog/css/reports.css
copy t/{db_dependent/default_search_class.pl => Koha/RDF.t} (59%)
mode change 100755 => 100644
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list