[koha-commits] main Koha release repository branch master updated. v18.05.00-484-g610c628

Thu Aug 16 16:17:39 CEST 2018

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  610c628def96437c0cc75ec2d2455cd373c5db18 (commit)
       via  bce549bc4c0f9fefddb34fe614f6bf79aef882ea (commit)
       via  b19090c4505c0f407a7f3cbfe3c14da5cfecc657 (commit)
       via  c957b52ef8bba734043157445470bedc36feae5e (commit)
       via  644de1c4e7616b13ea203f72b661ecb17ffa84a0 (commit)
       via  51933c7753f04cdc7baa745037919e601ec3d798 (commit)
      from  4ae91ba2633bac7ec607c8519433ba3cacbde1fd (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 610c628def96437c0cc75ec2d2455cd373c5db18
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Aug 16 14:03:28 2018 +0000

    Bug 21226: DBRev 18.06.00.015

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit bce549bc4c0f9fefddb34fe614f6bf79aef882ea
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Aug 15 11:58:12 2018 -0300

    Bug 21226: Remove xISBN services

    OCLC has decided to retire all xISBN services:
    https://www.oclc.org/developer/news/2018/xid-decommission.en.html

    The code for related features has to be removed from Koha.

    Test plan:
    You need to be familiar with the different sysprefs (I am not):
    - FRBRizeEditions
    - SyndeticsEnabled
    - SyndeticsEditions
    - ThingISBN

    Make sure there are no regressions introduced by this patchset.

    QA Note: C4/XISBN.pm should be renammed

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit b19090c4505c0f407a7f3cbfe3c14da5cfecc657
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Aug 15 11:36:21 2018 -0300

    Bug 21226: DB Changes

    Remove prefs OCLCAffiliateID, XISBN and XISBNDailyLimit

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit c957b52ef8bba734043157445470bedc36feae5e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Aug 15 12:21:38 2018 -0300

    Bug 21230: Prevent Reserves.t to fail randomly

    The following test can fail if the hold has been generated with found => 'W':
     #   Failed test 'No tests run for subtest "_koha_notify_reserve() tests"'
     #   at t/db_dependent/Reserves.t line 675.
    Can't call method "to_address" on an undefined value at
    t/db_dependent/Reserves.t line 661.
     # Looks like your test exited with 255 just after 56.

    We should call AddReserve instead.

    Test plan:
    0. Do not apply this patch
    1. Do the following change:
        my $hold = $builder->build({
                source => 'Reserve',
                value => {
                   borrowernumber=>$hold_borrower,
                   found => 'W', # This line is added, do not forget the comma above
                }
            });
    2. Prove it makes the test fail
    3. stash the changes and apply this patch
    4. Make sure the tests pass

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 644de1c4e7616b13ea203f72b661ecb17ffa84a0
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Aug 14 16:30:09 2018 -0300

    Bug 21222: (bug 20226 follow-up) Fix patron creation

    Since bug 20226 you cannot longer creation a patron, memberentry.pl will
    explode with
    Template process failed: undef error - DBIC result _type  isn't of the
    _type Category at /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/includes/str/members-menu.inc
    line 22.

    The problem is that "patron" is actually defined and the test in
    str/members-menu.inc does not work as expected.

    It comes from
      commit 7b1d08df0f4f69c52826c80a13158245287f4c00
      Bug 19936: Replace Generate_Userid - Update the occurrences
    where I needed $patron to be defined in order to use Koha::Patron->generate_userid
    on an blessed object.
    But this was actually wrong, as it could have side-effects.

    Test plan:
    Create a new patron
    Edit it
    Retest bug 19936 and make sure the userid is generated correctly in the
    different situations

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 51933c7753f04cdc7baa745037919e601ec3d798
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Aug 14 16:26:39 2018 -0300

    Bug 21221: Shortcut memberentry scripts if patron does not exist

    If borrowernumber is passed and that it does not refer to a valid patron
    in DB, we should not continue the script and display an error instead.

    Test plan:
    Create a patron
    Edit a patron
    => Both should work ok
    You can also test the other action memberentry.pl manage.

    Edit it again but modify the borrowernumber parameter
    => You should see a friendly user message saying that the patron does
    not exist.

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/UsageStats.pm                                   |    1 -
 C4/XISBN.pm                                        |   18 ++------------
 Koha.pm                                            |    2 +-
 installer/data/mysql/sysprefs.sql                  |    3 ---
 installer/data/mysql/updatedatabase.pl             |    9 +++++++
 .../admin/preferences/enhanced_content.pref        |   16 -------------
 .../prog/en/modules/members/memberentrygen.tt      |   20 +++++++++++++---
 members/memberentry.pl                             |   25 ++++++++++++--------
 t/db_dependent/Reserves.t                          |   11 ++++-----
 t/db_dependent/UsageStats.t                        |    1 -
 t/db_dependent/XISBN.t                             |   17 +------------
 11 files changed, 49 insertions(+), 74 deletions(-)

hooks/post-receive
-- 
main Koha release repository