[koha-commits] main Koha release repository branch master updated. v18.05.00-614-g34827d6

Git repo owner gitmaster at git.koha-community.org
Thu Aug 30 16:19:25 CEST 2018


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  34827d660cc018e68e09bed16170fbd0abf941cd (commit)
       via  4dec4be0994bb8fd41014c43ce3ae510ece0d37e (commit)
       via  43326754b110c62fbb2909eea1595656833f8c02 (commit)
       via  c267716e6bdbe6858a78380b49cccf5f81e1ed4c (commit)
       via  7b114c51eb971010ddb20e492e74090b19a24be4 (commit)
       via  ff16c7d662252162d0f2cd51cfd4c01bd495b8b5 (commit)
       via  a51681fc7a36b6e6bbf7991876c579a1a1f98b1d (commit)
       via  0757736eaf3bda30042aef5247b3b01a9a3b25bd (commit)
       via  cd43cf715bdb4e55baf9d5cd1114eec47b0eaeca (commit)
       via  8302af7b017b7554ef1ceb27966e4c1e39fdfc18 (commit)
       via  f191e2ad678cf660980d0f8619e7e5a91aebf600 (commit)
       via  284cf15a255c30fb2a1f6ce0ddbcb5a5ebb6bc80 (commit)
       via  1756b874a3d0d921ea9e733849e3783a7b172e23 (commit)
       via  aa97f13411576d651b1ee95a94da1ca644a24bde (commit)
       via  3795141f54991e0a4c95629754ac2759330ed2e6 (commit)
       via  63ab5dd3e9f6a1ef14e165260eafe0303d0bb735 (commit)
       via  20abe30c7bda8bb9133174132396a7dd958f6845 (commit)
       via  f36ce76ea8c4c207ea3f9bb215316c196c3b0c6f (commit)
       via  592905a4d2d41a1a7b757c48fbac8fc6f025bf9b (commit)
       via  ec257ca25baf19e3895abb2c4061af7592a2b9b4 (commit)
       via  2b1b168ec470da576c0a6c4aa8d458235a76018e (commit)
       via  f52ba648e2c64293966eca820326e33873c54343 (commit)
       via  ac93446a89f76fca2db90137885a72c918066d5a (commit)
       via  80ff78413e8de325ec49eb0edd88cfaaf3b4f50b (commit)
       via  aba0c1ddc7b86104ebc8187e57329e43d2a0ea9f (commit)
       via  d8ee32e706b1d59d091b03f5728a96f4bf2b413a (commit)
       via  38428fd71e76fdd7c9a452bc831affa03918994c (commit)
       via  59d436ee6023985a299f568fab9fd896492b207a (commit)
       via  be691d86e35acebace0f1576ea9380f405dd55ce (commit)
       via  823c76cdc58b7b80b365a4f313fed3462f0df720 (commit)
       via  ca2430480eaa4338b3e4aed766589b1406565d69 (commit)
       via  44d7063209137696d0c844ff82880a973029e534 (commit)
       via  3f01c8630aeead13ccd054de2eeca7b4eb3c221e (commit)
       via  7ae0dfa076996cef5644ef8a9a28cb613fc625c2 (commit)
       via  f0652790df8d711dc69c35be5be97761538ccd1e (commit)
       via  7c05f4fbe41800a9be4b6d4bdc8d7c7ddeb69ef9 (commit)
       via  82ec02b53883e2d3e815a77b17d2078931abbb29 (commit)
       via  a3848cb7023946aa6aaa23aae4067f44e3ba4fef (commit)
      from  898cd1d91f54735263d696118e1191e46a73b1c5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 34827d660cc018e68e09bed16170fbd0abf941cd
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Aug 30 13:40:18 2018 +0000

    Bug 20366: (RM follow-up) Fix typo 'hrml'
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 4dec4be0994bb8fd41014c43ce3ae510ece0d37e
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Thu Aug 2 13:15:16 2018 +0000

    Bug 20366: (follow-up) Fix link to subscription
    
    Sponsored-by: BULAC - http://www.bulac.fr/
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 43326754b110c62fbb2909eea1595656833f8c02
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue May 8 13:31:55 2018 -0300

    Bug 20366: Add subscription info to the acq tab on the biblio detail page
    
    On the "Acquisition details" tab of the bibliographic detail page, the
    subscription information are missing.
    This patch replace the call to GetHistory with Koha::Acquisition::Orders
    in order to simplify the code and make use of new Koha::
    packages/methods.
    
    TODO: Add column settings (show/hide columns) to this table (?)
    
    Sponsored-by: BULAC - http://www.bulac.fr/
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit c267716e6bdbe6858a78380b49cccf5f81e1ed4c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue May 8 13:32:47 2018 -0300

    Bug 20366: Add new method Koha::Acquisition::Basket->basket_group
    
    Can be moved to a separate bug report.
    
    Sponsored-by: BULAC - http://www.bulac.fr/
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 7b114c51eb971010ddb20e492e74090b19a24be4
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue May 8 13:30:44 2018 -0300

    Bug 20366: Add new method Koha::Acquisition::Order->subscription
    
    Can be moved to a separate bug report.
    
    Sponsored-by: BULAC - http://www.bulac.fr/
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit ff16c7d662252162d0f2cd51cfd4c01bd495b8b5
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Mar 28 12:53:42 2018 -0300

    Bug 20365: Allow several orders on the same subscriptions
    
    Do we really need this limitation?
    
    Sponsored-by: BULAC - http://www.bulac.fr/
    
    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit a51681fc7a36b6e6bbf7991876c579a1a1f98b1d
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Aug 30 13:46:06 2018 +0000

    Bug 20726: (RM follow-up) Add missing filters
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 0757736eaf3bda30042aef5247b3b01a9a3b25bd
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Jun 4 17:11:46 2018 -0300

    Bug 20726: Add title to the price column headers
    
    Sponsored-by: BULAC - http://www.bulac.fr/
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit cd43cf715bdb4e55baf9d5cd1114eec47b0eaeca
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue May 29 17:10:58 2018 -0300

    Bug 20726: Sort by statuses then ordernumbers
    
    Not received and most recent at the top.
    
    Sponsored-by: BULAC - http://www.bulac.fr/
    
    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 8302af7b017b7554ef1ceb27966e4c1e39fdfc18
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue May 29 16:59:05 2018 -0300

    Bug 20726: Add show/hide already received orders links
    
    Sponsored-by: BULAC - http://www.bulac.fr/
    
    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit f191e2ad678cf660980d0f8619e7e5a91aebf600
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon May 7 20:07:28 2018 -0300

    Bug 20726: Add DataTables
    
    Sponsored-by: BULAC - http://www.bulac.fr/
    
    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 284cf15a255c30fb2a1f6ce0ddbcb5a5ebb6bc80
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon May 7 20:00:25 2018 -0300

    Bug 20726: Add acquisition history on the subscription detail page
    
    Since bug 20365 is going to add the ability to create several pending orders on
    the same subscription we should display the history of the acquisitions on the
    subscription detail page.
    
    Sponsored-by: BULAC - http://www.bulac.fr/
    
    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 1756b874a3d0d921ea9e733849e3783a7b172e23
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon May 7 19:46:05 2018 -0300

    Bug 20726: Add new method Acquisition::Order->invoice
    
    Can be moved to a separate bug report.
    
    Sponsored-by: BULAC - http://www.bulac.fr/
    
    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit aa97f13411576d651b1ee95a94da1ca644a24bde
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon May 7 19:29:19 2018 -0300

    Bug 20726: Add new method Koha::Acquisition::Order->fund
    
    Can be moved to a separate bug report.
    
    Sponsored-by: BULAC - http://www.bulac.fr/
    
    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 3795141f54991e0a4c95629754ac2759330ed2e6
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Aug 6 19:42:20 2018 -0300

    Bug 21207: Remove unused RM C4::Overdues::GetItems sub
    
    Test plan:
      git grep GetItems
      | grep -v GetItemsInCollection
      | grep -v GetItemsForInventory
      | grep -v GetItemsInfo
      | grep -v GetItemsLocationInfo
      | grep -v GetItemsAvailable
      | grep -v GetItemsByBiblioitemnumber
    
    should not return any occurrences of code in perl scripts
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 63ab5dd3e9f6a1ef14e165260eafe0303d0bb735
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Aug 30 13:21:35 2018 +0000

    Bug 21157: Compiled CSS
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 20abe30c7bda8bb9133174132396a7dd958f6845
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Mon Aug 13 14:07:46 2018 +0000

    Bug 21157: Improve style of OPAC login modal
    
    This patch revises the style of the OPAC's login form modal view. The
    goal is simply to make it look nicer.
    
    To test, apply the patch and regenerate the OPAC's CSS
    (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
    
    In the OPAC, click the "Log in to your account" link at the top of the
    page. It should trigger the login modal. While the modal is displayed,
    resize the browser width to confirm that the form handles different
    widths well.
    
    Sign off if you think this is an improvement.
    
    Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit f36ce76ea8c4c207ea3f9bb215316c196c3b0c6f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Aug 29 14:38:56 2018 -0300

    Bug 13618: (follow-up) Add html filters to all the variables
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 592905a4d2d41a1a7b757c48fbac8fc6f025bf9b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Aug 15 14:21:47 2018 -0300

    Bug 21139: (follow-up) Floating toolbars - Remove unecessary height
    
    Found where QAing bug 20935, we actually want the hidden toolbar to be
    the exact same height as the visible one.
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit ec257ca25baf19e3895abb2c4061af7592a2b9b4
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Aug 16 12:12:11 2018 -0300

    Bug 21183: Fix ->get_column call context
    
    I am not sure to understand what's going on here.
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 2b1b168ec470da576c0a6c4aa8d458235a76018e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Aug 6 15:53:33 2018 -0300

    Bug 21183: Replace C4::Items::GetItemnumberFromBarcode calls
    
    C4::Items::GetItemnumberFromBarcode calls can be replaced with
      Koha::Items->find({ barcode => $barcode });
    
    We should make sure the barcode existed in DB and so that ->find
    returns an object. Note that most of the time we just wanted to know if
    the barcode existed.
    The changes are very simple, the only one that need attention is
    the one in batchMod.pl. It is basically reusing what we did on
    bug 21141.
    
    Test plan:
    Use the batch item modification/deletion tools to modify/delete items
    from their barcode (using the textarea or a file)
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit f52ba648e2c64293966eca820326e33873c54343
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Aug 6 15:53:54 2018 -0300

    Bug 21183: Remove GetItemnumberFromBarcode
    
    Test plan:
      git grep GetItemnumberFromBarcode
    should not return anything
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit ac93446a89f76fca2db90137885a72c918066d5a
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Fri May 4 15:18:59 2018 +0000

    Bug 20740: Update two-column templates with Bootstrap grid, Administration part 4
    
    This patch modifies several administration templates to use the
    Bootstrap grid instead of YUI.
    
    This patch also removes obsolete "text/javascript" attributes from
    <script> tags in the modified templates.
    
    To test, apply the patch and view the following pages, confirming that
    they look correct at various browser widths:
    
     - Administration -> Currencies and exchange rates
       - View and edit currencies
     - Administration -> Did you mean?
     - Administration -> EDI accounts
       - View and edit accounts
     - Administration -> Library EANs
       - View and edit EANs
     - Administration -> Item search fields
       - View and edit item search fields
    
    Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 80ff78413e8de325ec49eb0edd88cfaaf3b4f50b
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue May 1 18:46:33 2018 +0000

    Bug 20739: Update two-column templates with Bootstrap grid, Administration part 3
    
    This patch modifies several acquisitions templates to use the Bootstrap
    grid instead of YUI.
    
    This patch also removes obsolete "text/javascript" attributes from
    <script> tags in the modified templates.
    
    To test, apply the patch and view the following pages, confirming that
    they look correct at various browser widths:
    
     - Administration -> Columns settings
     - Administration -> Patron categories
       - View and edit patron categories
     - Administration -> Cities and towns
       - View and edit cities
     - Administration -> Classification sources
       - View and edit classification sources
     - Administration -> MARC bibliographic framework test
    
    I'm not sure if this standalone interface is actually in use, but you
    can navigate directly to /cgi-bin/koha/admin/clone-rules.pl to see a
    form which is usually submitted from the circulation and fines rules
    interface. View the page to confirm it looks correct.
    
    Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit aba0c1ddc7b86104ebc8187e57329e43d2a0ea9f
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue May 1 18:31:00 2018 +0000

    Bug 20738: Update two-column templates with Bootstrap grid, Administration part 2
    
    This patch modifies several acquisitions templates to use the Bootstrap
    grid instead of YUI.
    
    This patch also removes obsolete "text/javascript" attributes from
    <script> tags in the modified templates.
    
    To test, apply the patch and view the following pages, confirming that
    they look correct at various browser widths:
    
     - Administration -> Authority types
       - View list of and edit authority types
         -> MARC tag structure for an authority type
            - View list of and edit tags
              -> Subfields
                 - View list of and edit subfields
     - Administration -> MARC bibliographic framework
       - View list of and edit frameworks
     - Administration -> Libraries
       - View and edit libraries
     - Administration -> Library transfer limits
    
    Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit d8ee32e706b1d59d091b03f5728a96f4bf2b413a
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue May 1 17:39:51 2018 +0000

    Bug 20736: Update two-column templates with Bootstrap grid, Administration part 1
    
    This patch modifies several acquisitions templates to use the Bootstrap
    grid instead of YUI.
    
    This patch also removes obsolete "text/javascript" attributes from
    <script> tags in the modified templates.
    
    To test, apply the patch and view the following pages, confirming that
    they look correct at various browser widths:
    
     - Administration -> Budgets
       - View budgets list, view and edit budgets
       - View budget -> Planning -> Plan by months
     - Administration -> Funds
       - View funds list, view and edit funds
     - Acquisitions -> Vendor -> Contracts
       - View contracts list, view and edit contracts
     - Administration -> Audio alerts
     - Administration -> Authorized values
    
    Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 38428fd71e76fdd7c9a452bc831affa03918994c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Aug 15 15:17:57 2018 -0300

    Bug 19991: Remove warning from opac-user
    
    Use of uninitialized value in split at
    /home/vagrant/kohaclone/opac/opac-user.pl line 78.
    
    Use of uninitialized value $search_query in string ne at
    /home/vagrant/kohaclone/opac/opac-user.pl line 367.
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 59d436ee6023985a299f568fab9fd896492b207a
Author: Charlotte Cordwell <charlotte.cordwell123 at gmail.com>
Date:   Wed Jan 17 20:46:59 2018 +0000

    Bug 19991: use Modern::Perl in OPAC perl scripts
    
    Test Case:
    Check the following files have been updated from
    use strict;
    use warnings;
    to
    use Modern::Perl;
    
    errors/400.pl
    errors/401.pl
    errors/402.pl
    errors/403.pl
    errors/404.pl
    errors/500.pl
    opac-account-pay-paypal-return.pl
    opac-alert-subscribe.pl
    opac-authorities-home.pl
    opac-authoritiesdetail.pl
    opac-browser.pl
    opac-ics.pl
    opac-image.pl
    opac-imageviewer.pl
    opac-messaging.pl
    opac-modrequest-suspend.pl
    opac-modrequest.pl
    opac-mymessages.pl
    opac-overdrive-search.pl
    opac-passwd.pl
    opac-patron-image.pl
    opac-privacy.pl
    opac-ratings-ajax.pl
    opac-ratings.pl
    opac-readingrecord.pl
    opac-renew.pl
    opac-sendshelf.pl
    opac-serial-issues.pl
    opac-showreviews.pl
    opac-suggestions.pl
    opac-tags_subject.pl
    opac-topissues.pl
    opac-user.pl
    sco/help.pl
    sco/printslip.pl
    sco/sco-patron-image.pl
    svc/overdrive_proxy
    svc/suggestion
    unapi
    
    Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit be691d86e35acebace0f1576ea9380f405dd55ce
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Jul 25 12:25:58 2018 -0300

    Bug 21096: Do not display loggedinusername in template
    
    This patch is a little fix for a much bigger hidden issues.
    
    The original issue:
    1. Set the firstname and surname values of a paontr to utf-8 characters
    ("wide characters"), for instance 月月
    2. Use this patron to login at the staff interface
    => In the header the logged in patron's info (concat of firstname and
    surname) are displayed correctly
    3. Hit whatever link
    => In the header the info are now displayed incorrectly
    ("ææ")
    
    What happens?
    After that the user loggin, loggedinusername is set with the value from
    the DB (borrowers.userid)
    On next hits it is picked from the session (which contains the decoded
    utf8 value, see first lines of C4::Context->set_userenv)
    From C4::Auth::checkauth:
    834             $s_userid = $session->param('id') // ''
    
    The quick fix is to use the logged_in_user variable in the template, but
    it seems that issues may occurred if external authentication is used
    (ldap, shib, cas). Could someone test this?
    
    Test plan:
    Make sure the original issue is fixed
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 823c76cdc58b7b80b365a4f313fed3462f0df720
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Aug 10 17:02:38 2018 -0300

    Bug 21168: Handle deleted checked-in items on checking in
    
    circ/returns.pl generates a server error when attempting to checkin an item while
    the list of previously-returned items contains an item that has been deleted.
    Error text: Can't call method "biblio" on an undefined value at /usr/share/koha/intranet/cgi-bin/circ/returns.pl line 606.
    
    Test plan:
    - checkout two items
    - checkin item1
    - on a separate tab, delete item1
    - on the original tab (which still shows item1 in the list of Checked-In Items), attempt to check in item2
    => No error appears
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit ca2430480eaa4338b3e4aed766589b1406565d69
Author: Kyle M Hall <kyle at bywatersolutiosn.com>
Date:   Thu Aug 16 07:11:17 2018 -0400

    Bug 21231: BlockReturnofLostItems does not prevent lost items being found
    
    When the syspref BlockReturnOfLostItems is set to Block, the item is blocked from being returned, but is still considered found -- it's set to lost=0 and a refund is applied to the patron (if circ rules allow). The item can then be checked in a second time and returned as it is no longer lost.
    
    Test Plan:
    1) Set an item to lost
    2) Set BlockReturnOfLostItems to Block
    3) Check the lost item in
    4) Checkin  message should say item is lost and cannot be returned
    5) Check lost status of item, it should remain unchanged
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 44d7063209137696d0c844ff82880a973029e534
Author: Kyle M Hall <kyle at bywatersolutiosn.com>
Date:   Thu Aug 16 07:10:43 2018 -0400

    Bug 21231: Add Unit Test
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 3f01c8630aeead13ccd054de2eeca7b4eb3c221e
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Aug 30 10:59:58 2018 +0000

    Bug 21068: DBRev 18.06.00.021
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 7ae0dfa076996cef5644ef8a9a28cb613fc625c2
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Aug 24 17:00:31 2018 -0300

    Bug 21068: Remove table borrower_sync if needed
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit f0652790df8d711dc69c35be5be97761538ccd1e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Aug 15 12:49:02 2018 -0300

    Bug 21068: DB changes
    
    The update DB entry will not remove the prefs if NorwegianPatronDBEnable
    is set.
    This patch could be reverted locally by people using it.
    
    Signed-off-by: Benjamin Rokseth <benjamin.rokseth at deichman.no>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 7c05f4fbe41800a9be4b6d4bdc8d7c7ddeb69ef9
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Aug 13 13:49:56 2018 -0300

    Bug 21068: Remove NorwegianPatronDB related code
    
    Bug 11401 introduced code to support Norwegian national library card.
    This code is too specific to be part of Koha as it, it should be a
    plugin instead.
    Moreover nobody uses it, but a modified version (see comment 3).
    
    Test plan:
    Add/edit/delete patron and make sure there are no regressions introduced
    by these patches
    
    Signed-off-by: Benjamin Rokseth <benjamin.rokseth at deichman.no>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 82ec02b53883e2d3e815a77b17d2078931abbb29
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Mon Aug 13 09:54:44 2018 +0100

    Bug 21199: (QA follow-up) Add show_attributes to perldoc
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit a3848cb7023946aa6aaa23aae4067f44e3ba4fef
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Aug 9 19:34:58 2018 -0300

    Bug 21199: Hide patron's attributes from ILSDI if required
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Auth.pm                                         |    2 +-
 C4/Circulation.pm                                  |    4 +-
 C4/ILSDI/Services.pm                               |    5 +-
 C4/ImportBatch.pm                                  |    5 +-
 C4/Installer/PerlDependencies.pm                   |   20 -
 C4/Items.pm                                        |   38 +-
 C4/Members.pm                                      |    6 -
 C4/Overdues.pm                                     |   34 -
 Koha.pm                                            |    2 +-
 Koha/Acquisition/Basket.pm                         |   13 +
 Koha/{Report.pm => Acquisition/BasketGroup.pm}     |   14 +-
 Koha/{ApiKeys.pm => Acquisition/BasketGroups.pm}   |   18 +-
 Koha/Acquisition/{Fund.pm => Invoice.pm}           |    6 +-
 Koha/Acquisition/{Funds.pm => Invoices.pm}         |   10 +-
 Koha/Acquisition/Order.pm                          |   47 ++
 Koha/NorwegianPatronDB.pm                          |  676 --------------------
 Koha/Patron.pm                                     |   50 --
 catalogue/detail.pl                                |   10 +-
 circ/returns.pl                                    |    7 +-
 installer/data/mysql/kohastructure.sql             |   18 -
 installer/data/mysql/sysprefs.sql                  |    5 -
 installer/data/mysql/updatedatabase.pl             |   16 +
 .../lib/jquery/plugins/jquery.fixFloat.js          |    2 +-
 .../intranet-tmpl/prog/en/includes/header.inc      |    4 +-
 .../prog/en/includes/members-toolbar.inc           |    9 +-
 .../prog/en/includes/nl-search-form.tt             |    9 -
 .../prog/en/includes/str/members-menu.inc          |    1 -
 .../prog/en/modules/acqui/newordersubscription.tt  |    7 +-
 .../intranet-tmpl/prog/en/modules/acqui/parcel.tt  |    2 +-
 .../prog/en/modules/admin/aqbudgetperiods.tt       |   25 +-
 .../prog/en/modules/admin/aqbudgets.tt             |   33 +-
 .../prog/en/modules/admin/aqcontract.tt            |   28 +-
 .../intranet-tmpl/prog/en/modules/admin/aqplan.tt  |   27 +-
 .../prog/en/modules/admin/audio_alerts.tt          |   24 +-
 .../en/modules/admin/auth_subfields_structure.tt   |   26 +-
 .../prog/en/modules/admin/auth_tag_structure.tt    |   26 +-
 .../prog/en/modules/admin/authorised_values.tt     |   26 +-
 .../prog/en/modules/admin/authtypes.tt             |   25 +-
 .../prog/en/modules/admin/biblio_framework.tt      |   26 +-
 .../en/modules/admin/branch_transfer_limits.tt     |   27 +-
 .../prog/en/modules/admin/branches.tt              |   26 +-
 .../prog/en/modules/admin/categories.tt            |   25 +-
 .../prog/en/modules/admin/checkmarc.tt             |   24 +-
 .../intranet-tmpl/prog/en/modules/admin/cities.tt  |   40 +-
 .../prog/en/modules/admin/classsources.tt          |   23 +-
 .../prog/en/modules/admin/clone-rules.tt           |   22 +-
 .../prog/en/modules/admin/columns_settings.tt      |   25 +-
 .../prog/en/modules/admin/currency.tt              |   25 +-
 .../prog/en/modules/admin/didyoumean.tt            |   25 +-
 .../prog/en/modules/admin/edi_accounts.tt          |   23 +-
 .../prog/en/modules/admin/edi_ean_accounts.tt      |   23 +-
 .../prog/en/modules/admin/items_search_field.tt    |   25 +-
 .../prog/en/modules/admin/items_search_fields.tt   |   25 +-
 .../prog/en/modules/admin/preferences/patrons.pref |   22 -
 .../prog/en/modules/catalogue/detail.tt            |   45 +-
 .../intranet-tmpl/prog/en/modules/circ/offline.tt  |    2 +-
 .../intranet-tmpl/prog/en/modules/circ/returns.tt  |    7 +-
 .../prog/en/modules/members/deletemem.tt           |    6 -
 .../prog/en/modules/members/member.tt              |    5 -
 .../prog/en/modules/members/memberentrygen.tt      |   12 -
 .../prog/en/modules/members/moremember.tt          |   26 -
 .../prog/en/modules/members/nl-search.tt           |  180 ------
 .../prog/en/modules/patron_lists/add-modify.tt     |    2 +-
 .../prog/en/modules/serials/subscription-add.tt    |    2 +-
 .../prog/en/modules/serials/subscription-detail.tt |  102 ++-
 .../prog/en/modules/virtualshelves/shelves.tt      |    4 +-
 koha-tmpl/intranet-tmpl/prog/js/datatables.js      |    6 +-
 koha-tmpl/intranet-tmpl/prog/js/members-menu.js    |   44 +-
 koha-tmpl/opac-tmpl/bootstrap/css/opac.css         |    2 +-
 .../opac-tmpl/bootstrap/css/src/_responsive.scss   |    5 +
 koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss    |   53 ++
 .../opac-tmpl/bootstrap/en/includes/masthead.inc   |    3 +-
 labels/label-edit-batch.pl                         |    9 +-
 members/deletemem.pl                               |   27 +-
 members/mancredit.pl                               |    4 +-
 members/maninvoice.pl                              |    4 +-
 members/memberentry.pl                             |   17 -
 members/moremember.pl                              |   14 -
 members/nl-search.pl                               |  167 -----
 misc/cronjobs/nl-sync-from-koha.pl                 |  202 ------
 misc/cronjobs/nl-sync-to-koha.pl                   |  186 ------
 opac/errors/400.pl                                 |    4 +-
 opac/errors/401.pl                                 |    4 +-
 opac/errors/402.pl                                 |    4 +-
 opac/errors/403.pl                                 |    4 +-
 opac/errors/404.pl                                 |    4 +-
 opac/errors/500.pl                                 |    4 +-
 opac/opac-account-pay-paypal-return.pl             |    3 +-
 opac/opac-alert-subscribe.pl                       |    4 +-
 opac/opac-authorities-home.pl                      |    3 +-
 opac/opac-authoritiesdetail.pl                     |    3 +-
 opac/opac-browser.pl                               |    3 +-
 opac/opac-ics.pl                                   |    3 +-
 opac/opac-image.pl                                 |    3 +-
 opac/opac-imageviewer.pl                           |    3 +-
 opac/opac-messaging.pl                             |    3 +-
 opac/opac-modrequest-suspend.pl                    |    3 +-
 opac/opac-modrequest.pl                            |    3 +-
 opac/opac-mymessages.pl                            |    3 +-
 opac/opac-overdrive-search.pl                      |    3 +-
 opac/opac-passwd.pl                                |    3 +-
 opac/opac-patron-image.pl                          |    3 +-
 opac/opac-privacy.pl                               |    2 +-
 opac/opac-ratings-ajax.pl                          |    3 +-
 opac/opac-ratings.pl                               |    3 +-
 opac/opac-readingrecord.pl                         |    3 +-
 opac/opac-renew.pl                                 |    3 +-
 opac/opac-sendshelf.pl                             |    3 +-
 opac/opac-serial-issues.pl                         |    3 +-
 opac/opac-showreviews.pl                           |    3 +-
 opac/opac-suggestions.pl                           |    4 +-
 opac/opac-tags_subject.pl                          |    3 +-
 opac/opac-topissues.pl                             |    3 +-
 opac/opac-user.pl                                  |    7 +-
 opac/sco/help.pl                                   |    3 +-
 opac/sco/printslip.pl                              |    3 +-
 opac/sco/sco-patron-image.pl                       |    3 +-
 opac/svc/overdrive_proxy                           |    3 +-
 opac/svc/suggestion                                |    3 +-
 opac/unapi                                         |    3 +-
 rotating_collections/addItems.pl                   |    5 +-
 serials/serials-edit.pl                            |    9 +-
 serials/subscription-detail.pl                     |   66 +-
 t/00-load.t                                        |    6 +-
 t/NorwegianPatronDB.t                              |  599 -----------------
 t/db_dependent/Circulation/Returns.t               |    5 +-
 t/db_dependent/ILSDI_Services.t                    |   35 +-
 t/db_dependent/Koha/Acquisition/Basket.t           |   33 +-
 t/db_dependent/Koha/Acquisition/Order.t            |   77 ++-
 tools/batchMod.pl                                  |   28 +-
 130 files changed, 896 insertions(+), 2917 deletions(-)
 copy Koha/{Report.pm => Acquisition/BasketGroup.pm} (82%)
 copy Koha/{ApiKeys.pm => Acquisition/BasketGroups.pm} (78%)
 copy Koha/Acquisition/{Fund.pm => Invoice.pm} (89%)
 copy Koha/Acquisition/{Funds.pm => Invoices.pm} (84%)
 delete mode 100644 Koha/NorwegianPatronDB.pm
 delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/nl-search-form.tt
 delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/members/nl-search.tt
 delete mode 100755 members/nl-search.pl
 delete mode 100755 misc/cronjobs/nl-sync-from-koha.pl
 delete mode 100755 misc/cronjobs/nl-sync-to-koha.pl
 delete mode 100644 t/NorwegianPatronDB.t


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list