[koha-commits] main Koha release repository branch 17.11.x updated. v17.11.12-59-g516f580

Wed Dec 5 09:30:50 CET 2018

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.11.x has been updated
       via  516f58008cf6859590bc925d01023813565b361e (commit)
       via  7e259683c8741dbd72ce01f3c6ff2f990344e47d (commit)
       via  0eedb1580cffc1e976076c877624a0b4f57803bb (commit)
       via  5c42c2686c208b7c287b44da1743ac903b10f92a (commit)
       via  aaae83d1bfb8da0b0593138efd59610fdeb8e483 (commit)
       via  7c9b946994f8e44750b0fd4ed81c803e60352823 (commit)
       via  dc86427ca4a0dd6bd9c530e733860026fffb63aa (commit)
       via  5a4f634784d2592f52d9488995020b47304ec87f (commit)
      from  93dc736ee27b6d7026f98997164a93813dc9a20c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 516f58008cf6859590bc925d01023813565b361e
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Nov 16 12:51:27 2018 +0000

    Bug 20598: Update number of tests

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 119653a3a133d5bb138234d2e45a13f8a7e447fe)

    Conflicts:
    	t/db_dependent/Circulation.t
    (cherry picked from commit 1d797a8e5cf960dac27c1d0b47771bc379a1b239)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 7e259683c8741dbd72ce01f3c6ff2f990344e47d
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Nov 16 10:37:55 2018 +0100

    Bug 20598: (QA follow-up) Tiny fixes

    [1] Correct POD for _FixOverduesOnReturn
    Is called by AddReturn, AddRenewal and LostItem.
    Also tested in Circulation.t btw

    [2] $dbh is not used in _FixOverduesOnReturn
    [3] Moving all parameters to the first line.
    [4] Variable $uquery is not used too.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 867f88076eb47c434c3edf6f7903238b5a465cdb)
    (cherry picked from commit 2c7717546705d2bebcaed3cc43e6cf6f48359c4a)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 0eedb1580cffc1e976076c877624a0b4f57803bb
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Mon Nov 5 13:31:40 2018 +0000

    Bug 20598: Unit test

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit b9ed7699e3da4966681a21c85bc78d99123d1681)
    (cherry picked from commit 25ea817edfb2263474090dae3c809820df9b69c0)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 5c42c2686c208b7c287b44da1743ac903b10f92a
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Tue Apr 17 14:11:41 2018 -0400

    Bug 20598: Accruing fines not closed out by longoverdue.pl if WhenLostForgiveFine is not enabled

    Test Plan:
    1) Ensure WhenLostForgiveFine is disabled
    2) Create an overdue with a fine
    3) Mark it lost with longoverdue.pl
    4) Note it is still marked as an accruing fine
    5) Apply this patch
    6) Repeat steps 1-3
    7) Note it is no longer an accruing fine!

    Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
    Followed the test plan and it works.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 461a6f53b85becbefb18c0cb9356384a479aa9f1)
    (cherry picked from commit 180909e7a7400505c032b9f4fa186c016cf2a890)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit aaae83d1bfb8da0b0593138efd59610fdeb8e483
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Nov 16 10:04:55 2018 +0100

    Bug 18677: (QA follow-up) Trivial fixes to Chargelostitem.t

    Kind of funny that we did not touch this test here. But it passed!
    Trivial fixes:
    [1] Typo precessfee
    [2] Typo the linked
    [3] Add rollback

    Test plan:
    Run t/db_dependent/Circulation/Chargelostitem.t

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit fab9936ddb68e15cae356cb4c52a3be806948f83)

    Signed-off-by: Jesse Maseto <jesse at bywatersolution.com>
    (cherry picked from commit 2d1332938c2bfc0df44afbc332dcfa2657ffad75)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 7c9b946994f8e44750b0fd4ed81c803e60352823
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Nov 1 11:47:47 2018 -0300

    Bug 18677: Remove new issue_id param from charlostitem

    We have the itemnumber no need to pass the issue_id, we can retrieve it
    from chargelostitem

    Signed-off-by: Michal Denar <black23 at gmail.com>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 3475670881e75f47bc6b7e21f0563162e428b831)

    Signed-off-by: Jesse Maseto <jesse at bywatersolution.com>
    (cherry picked from commit 8b02c6c3a1aed55d44a721d44d6c606c0935ccb2)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit dc86427ca4a0dd6bd9c530e733860026fffb63aa
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Nov 1 11:47:16 2018 -0300

    Bug 18677: Make the tests pass

    Signed-off-by: Michal Denar <black23 at gmail.com>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit cd250dae36b8dd03cbfa1b2ab691202a51daa58b)

    Signed-off-by: Jesse Maseto <jesse at bywatersolution.com>
    (cherry picked from commit 6adfbd33f12e3813d19a208ec0bdb251626207a6)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 5a4f634784d2592f52d9488995020b47304ec87f
Author: Kyle M Hall <kyle at bywatetsolutions.com>
Date:   Wed Apr 11 14:08:57 2018 -0400

    Bug 18677: issue_id is not added to accountlines for lost item fees

    Test Plan:
    1) Apply this patch
    2) prove t/db_dependent/Accounts.t

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Michal Denar <black23 at gmail.com>

    [EDIT:]
    Patch should have increased the number of tests obviously.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit cde7a8e72c04ad31bdda66908e5e0482276bdcb8)

    Signed-off-by: Jesse Maseto <jesse at bywatersolution.com>
    (cherry picked from commit b876d09e35aae7ff6926cbe64c51ddae12257e33)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Accounts.pm                              |    4 ++++
 C4/Circulation.pm                           |   18 +++++++-----------
 t/db_dependent/Accounts.t                   |   19 ++++++++++++++++++-
 t/db_dependent/Circulation.t                |   11 ++++++++++-
 t/db_dependent/Circulation/Chargelostitem.t |    6 ++++--
 5 files changed, 43 insertions(+), 15 deletions(-)

hooks/post-receive
-- 
main Koha release repository